mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-25 00:04:33 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

branches/innodb+: page_zip_dir_delete(): Do not clear the last record on

Browse source 
a secondary index leaf page, because that could break delete buffering.

btr_page_get_father_node_ptr(): Remove a TODO comment regarding this.
This commit is contained in:
marko 2008-09-30 11:21:39 +00:00
parent 2cf9ce26fc
commit 1141a8e06e
2 changed files with 24 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
btr/btr0btr.c
View file

@ -609,9 +609,7 @@ btr_page_get_father_node_ptr(
The first record from the free list can be used to find the
father node. */
user_rec = page_header_get_ptr(page, PAGE_FREE);
/* TODO: make sure that delete buffering never zeroes out
the data bytes. TODO: make sure that empty pages are
never recompressed. */
/* TODO: make sure that empty pages are never recompressed. */
ut_a(user_rec);
} else {
user_rec = btr_cur_get_rec(cursor);

30
page/page0zip.c
View file

@ -4017,9 +4017,29 @@ page_zip_dir_delete(
The "owned" and "deleted" flags will be cleared. */
mach_write_to_2(slot_free, page_offset(rec));
if (!page_is_leaf(page) || !dict_index_is_clust(index)) {
/* The compression algorithm expects info_bits and n_owned
to be 0 for deleted records. */
rec[-REC_N_NEW_EXTRA_BYTES] = 0; /* info_bits and n_owned */
if (!page_is_leaf(page)) {
ut_ad(!rec_offs_any_extern(offsets));
goto skip_blobs;
goto clear_rec;
}
if (!dict_index_is_clust(index)) {
ut_ad(!rec_offs_any_extern(offsets));
/* Do not clear the last record on a secondary index
leaf page, because that could break delete
buffering. */
if (!page_get_n_recs(page)) {
#ifdef UNIV_ZIP_DEBUG
ut_a(page_zip_validate(page_zip, page));
#endif /* UNIV_ZIP_DEBUG */
return;
}
goto clear_rec;
}
n_ext = rec_offs_n_extern(offsets);
@ -4049,11 +4069,7 @@ page_zip_dir_delete(
memset(ext_end, 0, n_ext * BTR_EXTERN_FIELD_REF_SIZE);
}
skip_blobs:
/* The compression algorithm expects info_bits and n_owned
to be 0 for deleted records. */
rec[-REC_N_NEW_EXTRA_BYTES] = 0; /* info_bits and n_owned */
clear_rec:
page_zip_clear_rec(page_zip, rec, index, offsets);
}