mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-16 03:52:35 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDEV-23626: CONNECT VIR tables return inconsistent error for UPDATE

Browse source 
- Before the patch UPDATE error message for VIR tables was different from TRUNCATE,UPDATE,DELETE
Reviewed by: <Olivier Bertrand>, vicentiu@mariadb.org
This commit is contained in:
Anel Husakovic 2020-09-08 00:01:09 +02:00 committed by anel
parent c62843a055
commit 1118b66a22
3 changed files with 38 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
storage/connect/connect.cc
View file

@ -297,6 +297,13 @@ bool CntOpenTable(PGLOBAL g, PTDB tdbp, MODE mode, char *c1, char *c2,
PTDB utp;
if (!(utp = tdbp->Duplicate(g))) {
/* If table type is of type virtual retrieve global parameter as it was.*/
if (tdbp->GetAmType() == TYPE_AM_VIR) {
if (tdbp->OpenDB(g)) {
printf("%s\n", g->Message);
throw 7;
}
}
sprintf(g->Message, MSG(INV_UPDT_TABLE), tdbp->GetName());
throw 4;
} // endif tp

14
storage/connect/mysql-test/connect/r/general.result
View file

@ -16,3 +16,17 @@ SELECT * FROM t1;
a
10
DROP TABLE t1;
#
# MDEV-23626: CONNECT VIR tables return inconsistent error for UPDATE
#
CREATE TABLE numbers
ENGINE=CONNECT,
TABLE_TYPE=VIR,
BLOCK_SIZE=3;
TRUNCATE TABLE numbers;
ERROR HY000: Got error 174 'Virtual tables are read only' from CONNECT
DELETE FROM numbers WHERE n = 1;
ERROR HY000: Got error 174 'Virtual tables are read only' from CONNECT
UPDATE numbers SET n = 10 WHERE n = 1;
ERROR HY000: Got error 174 'Virtual tables are read only' from CONNECT
DROP TABLE numbers;

17
storage/connect/mysql-test/connect/t/general.test
View file

@ -14,3 +14,20 @@ SELECT * FROM t1;
ALTER TABLE t1 TABLE_TYPE=NON_EXISTING;
SELECT * FROM t1;
DROP TABLE t1;
--echo #
--echo # MDEV-23626: CONNECT VIR tables return inconsistent error for UPDATE
--echo #
CREATE TABLE numbers
ENGINE=CONNECT,
TABLE_TYPE=VIR,
BLOCK_SIZE=3;
--error ER_GET_ERRMSG
TRUNCATE TABLE numbers;
--error ER_GET_ERRMSG
DELETE FROM numbers WHERE n = 1;
--error ER_GET_ERRMSG
UPDATE numbers SET n = 10 WHERE n = 1;
DROP TABLE numbers;