mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2026-05-14 19:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Bug#59307 Valgrind: uninitialized value in rw_lock_set_writer_id_and_recursion_flag()

Browse source 
rw_lock_create_func(): Initialize lock->writer_thread, so that Valgrind
will not complain even when Valgrind instrumentation is not enabled.
Flag lock->writer_thread uninitialized, so that Valgrind can complain
when it is used uninitialized.

rw_lock_set_writer_id_and_recursion_flag(): Revert the bogus Valgrind
instrumentation that was pushed in the first attempt to fix this bug.
This commit is contained in:
Marko Mäkelä 2011-02-15 10:51:33 +02:00
commit 0efaef7d46
5 changed files with 69 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
storage/innodb_plugin/include/sync0rw.ic
View file

@ -280,7 +280,6 @@ rw_lock_set_writer_id_and_recursion_flag(
local_thread = lock->writer_thread;
success = os_compare_and_swap_thread_id(
&lock->writer_thread, local_thread, curr_thread);
UNIV_MEM_VALID(&success, sizeof(success));
ut_a(success);
lock->recursive = recursive;