From db674c9f877c338a38cfbeb372804e5f5b3ed339 Mon Sep 17 00:00:00 2001 From: Sven Sandberg Date: Mon, 7 Jul 2008 17:38:47 +0200 Subject: [PATCH 1/2] BUG#37933: Test "rpl_insert" fails - timing problem in replication test ? Problem: the test syncs slave by a 'wait_condition' waiting until table t1 has 5000 rows. However, there is no guarantee that t1 makes it to the slave before the wait_condition. Fix: sync_slave_with_master just after t1 was created. mysql-test/suite/rpl/t/rpl_insert.test: Added sync_slave_with_master to ensure that table t1 is on slave before the slave executes wait_condition. --- mysql-test/suite/rpl/t/rpl_insert.test | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mysql-test/suite/rpl/t/rpl_insert.test b/mysql-test/suite/rpl/t/rpl_insert.test index 00e814951d5..d304dfb6cc7 100644 --- a/mysql-test/suite/rpl/t/rpl_insert.test +++ b/mysql-test/suite/rpl/t/rpl_insert.test @@ -13,6 +13,9 @@ USE mysqlslap; CREATE TABLE t1 (id INT, name VARCHAR(64)); +sync_slave_with_master; +connection master; + let $query = "INSERT DELAYED INTO t1 VALUES (1, 'Dr. No'), (2, 'From Russia With Love'), (3, 'Goldfinger'), (4, 'Thunderball'), (5, 'You Only Live Twice')"; --exec $MYSQL_SLAP --silent --concurrency=5 --iterations=200 --query=$query --delimiter=";" From e1b5b1ec1eec320fdc23e886c5ebe33f2a9f1445 Mon Sep 17 00:00:00 2001 From: Sven Sandberg Date: Tue, 8 Jul 2008 12:56:05 +0200 Subject: [PATCH 2/2] BUG#37962: *_func tests containing sleeps/race conditions This is not a fix, it just disables the erroneous test cases. mysql-test/t/disabled.def: Disabled a number of new tests that contain sleeps and that have not been checked for race conditions. At least some of them contain race conditions. --- mysql-test/t/disabled.def | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/mysql-test/t/disabled.def b/mysql-test/t/disabled.def index d5f90b1ffa7..b3b92066dda 100644 --- a/mysql-test/t/disabled.def +++ b/mysql-test/t/disabled.def @@ -96,3 +96,13 @@ transaction_alloc_block_size_basic_64 : Bug #36522: Some tests of system variabl transaction_prealloc_size_basic_64 : Bug #36522: Some tests of system variables have diffs on 64bit platorms wait_timeout_basic_64 : Bug #36522: Some tests of system variables have diffs on 64bit platorms wait_timeout_func : BUG#36873 2008-07-06 sven wait_timeout_func.test fails randomly +delayed_insert_limit_func : BUG#37962 2008-07-08 sven *_func tests containing sleeps/race conditions +event_scheduler_func : BUG#37962 2008-07-08 sven *_func tests containing sleeps/race conditions +innodb_max_dirty_pages_pct_func : BUG#37962 2008-07-08 sven *_func tests containing sleeps/race conditions +interactive_timeout_func : BUG#37962 2008-07-08 sven *_func tests containing sleeps/race conditions +query_cache_wlock_invalidate_func : BUG#37962 2008-07-08 sven *_func tests containing sleeps/race conditions +rpl_init_slave_func : BUG#37962 2008-07-08 sven *_func tests containing sleeps/race conditions +rpl_max_binlog_size_func : BUG#37962 2008-07-08 sven *_func tests containing sleeps/race conditions +slow_query_log_func : BUG#37962 2008-07-08 sven *_func tests containing sleeps/race conditions +sql_low_priority_updates_func : BUG#37962 2008-07-08 sven *_func tests containing sleeps/race conditions +timestamp_func : BUG#37962 2008-07-08 sven *_func tests containing sleeps/race conditions