mirror of
https://github.com/MariaDB/server.git
synced 2026-05-14 19:07:15 +02:00
Check and remove high stack usage
I checked all stack overflow potential problems found with gcc -Wstack-usage=16384 and clang -Wframe-larger-than=16384 -no-inline Fixes: Added '#pragma clang diagnostic ignored "-Wframe-larger-than="' to a lot of function to where stack usage large but resonable. - Added stack check warnings to BUILD scrips when using clang and debug. Function changed to use malloc instead allocating things on stack: - read_bootstrap_query() now allocates line_buffer (20000 bytes) with malloc() instead of using stack. This has a small performance impact but this is not releant for bootstrap. - mroonga grn_select() used 65856 bytes on stack. Changed it to use malloc(). - Wsrep_schema::replay_transaction() and Wsrep_schema::recover_sr_transactions(). - Connect zipOpen3() Not fixed: - mroonga/vendor/groonga/lib/expr.c grn_proc_call() uses 43712 byte on stack. However this is not easy to fix as the stack used is caused by a lot of code generated by defines. - Most changes in mroonga/groonga where only adding of pragmas to disable stack warnings. - rocksdb/options/options_helper.cc uses 20288 of stack space. (no reason to fix except to get rid of the compiler warning) - Causes using alloca() where the allocation size is resonable. - An issue in libmariadb (reported to connectors).
This commit is contained in:
parent
07faba08b9
commit
0ccdf54b64
32 changed files with 293 additions and 106 deletions
|
|
@ -568,6 +568,9 @@ static int my_process_result(MYSQL *mysql_arg)
|
|||
#define MAX_RES_FIELDS 50
|
||||
#define MAX_FIELD_DATA_SIZE 255
|
||||
|
||||
/* Stack usage 18888 with clang */
|
||||
PRAGMA_DISABLE_CHECK_STACK_FRAME
|
||||
|
||||
static int my_process_stmt_result(MYSQL_STMT *stmt)
|
||||
{
|
||||
int field_count;
|
||||
|
|
@ -656,6 +659,7 @@ static int my_process_stmt_result(MYSQL_STMT *stmt)
|
|||
mysql_free_result(result);
|
||||
return row_count;
|
||||
}
|
||||
PRAGMA_REENABLE_CHECK_STACK_FRAME
|
||||
|
||||
|
||||
/* Prepare statement, execute, and process result set for given query */
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue