mirror/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-01-16 03:52:35 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDEV-35246 Vector search skips a row in the table

Browse source 
stronger condition in select_neighbors() to reject exact matches too
This commit is contained in:
Sergei Golubchik 2024-10-25 21:38:08 +02:00
parent d50663198c
commit 0b9bc6c3cd
3 changed files with 47 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
mysql-test/main/vector2.result
View file

@ -321,3 +321,38 @@ t1 CREATE TABLE `t1` (
`v` vector(2) DEFAULT x'4041424344454647' `v` vector(2) DEFAULT x'4041424344454647'
) ENGINE=MyISAM DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci ) ENGINE=MyISAM DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci
drop table t1; drop table t1;
#
# MDEV-35246 Vector search skips a row in the table
#
set rand_seed1=1, rand_seed2=2;
create or replace table t1 (a int, v vector(1) not null, vector(v) max_edges_per_node=6);
insert into t1 select seq, vec_fromtext(concat('[',seq,']')) from seq_1_to_200;
update t1 set v = vec_fromtext(concat('[33]')) where a <= 15;
select a, vec_totext(v) from t1 order by vec_distance_euclidean(v,vec_fromtext('[33]')) limit 25;
a vec_totext(v)
1 [33]
10 [33]
11 [33]
12 [33]
13 [33]
14 [33]
15 [33]
2 [33]
28 [28]
29 [29]
3 [33]
30 [30]
31 [31]
32 [32]
33 [33]
34 [34]
35 [35]
36 [36]
37 [37]
4 [33]
5 [33]
6 [33]
7 [33]
8 [33]
9 [33]
drop table t1;

11
mysql-test/main/vector2.test
View file

@ -246,3 +246,14 @@ drop table t;
create table t1 (f vector(1) default 0x30313233, v vector(2) default x'4041424344454647'); create table t1 (f vector(1) default 0x30313233, v vector(2) default x'4041424344454647');
show create table t1; show create table t1;
drop table t1; drop table t1;
--echo #
--echo # MDEV-35246 Vector search skips a row in the table
--echo #
set rand_seed1=1, rand_seed2=2;
create or replace table t1 (a int, v vector(1) not null, vector(v) max_edges_per_node=6);
insert into t1 select seq, vec_fromtext(concat('[',seq,']')) from seq_1_to_200;
update t1 set v = vec_fromtext(concat('[33]')) where a <= 15;
--sorted_result
select a, vec_totext(v) from t1 order by vec_distance_euclidean(v,vec_fromtext('[33]')) limit 25;
drop table t1;

2
sql/vector_mhnsw.cc
View file

@ -906,7 +906,7 @@ static int select_neighbors(MHNSW_Share *ctx, TABLE *graph, size_t layer,
const float target_dista= vec->distance_to_target / alpha; const float target_dista= vec->distance_to_target / alpha;
bool discard= false; bool discard= false;
for (size_t i=0; i < neighbors.num; i++) for (size_t i=0; i < neighbors.num; i++)
if ((discard= node->distance_to(neighbors.links[i]->vec) < target_dista)) if ((discard= node->distance_to(neighbors.links[i]->vec) <= target_dista))
break; break;
if (!discard) if (!discard)
target.push_neighbor(layer, node); target.push_neighbor(layer, node);