post-fix for #1504

cmake/install_layout.cmake

@@ -175,7 +175,7 @@ SET(INSTALL_BINDIR_DEB                  "bin")
 SET(INSTALL_SBINDIR_DEB                 "sbin")
 SET(INSTALL_SCRIPTDIR_DEB               "bin")
 SET(INSTALL_SYSCONFDIR_DEB              "/etc")
-SET(INSTALL_SYSCONF2DIR_DEB             "/etc/mysql/conf.d")
+SET(INSTALL_SYSCONF2DIR_DEB             "/etc/mysql/mariadb.conf.d")
 #
 SET(INSTALL_LIBDIR_DEB                  "lib/${CMAKE_CXX_LIBRARY_ARCHITECTURE}")
 SET(INSTALL_PLUGINDIR_DEB               "lib/mysql/plugin")

cmake/plugin.cmake

@@ -252,7 +252,6 @@ MACRO(MYSQL_ADD_PLUGIN)
             SET(ARG_CONFIG "${CMAKE_CURRENT_BINARY_DIR}/CMakeFiles/${target}.cnf")
             FILE(WRITE ${ARG_CONFIG} "[mariadb]\nplugin-load-add=${ARG_MODULE_OUTPUT_NAME}.so\n")
           ENDIF()
-          INSTALL(FILES ${ARG_CONFIG} COMPONENT ${ARG_COMPONENT} DESTINATION ${INSTALL_SYSCONF2DIR})
           SET(CPACK_RPM_${ARG_COMPONENT}_USER_FILELIST ${ignored} "%config(noreplace) ${INSTALL_SYSCONF2DIR}/*" PARENT_SCOPE)
           SET(CPACK_RPM_${ARG_COMPONENT}_POST_INSTALL_SCRIPT_FILE ${CMAKE_SOURCE_DIR}/support-files/rpm/plugin-postin.sh PARENT_SCOPE)
           SET(CPACK_RPM_${ARG_COMPONENT}_POST_TRANS_SCRIPT_FILE ${CMAKE_SOURCE_DIR}/support-files/rpm/server-posttrans.sh PARENT_SCOPE)
@@ -262,6 +261,9 @@ MACRO(MYSQL_ADD_PLUGIN)
       SET(ARG_COMPONENT Server)
     ENDIF()
     MYSQL_INSTALL_TARGETS(${target} DESTINATION ${INSTALL_PLUGINDIR} COMPONENT ${ARG_COMPONENT})
+    IF(ARG_CONFIG AND INSTALL_SYSCONF2DIR)
+      INSTALL(FILES ${ARG_CONFIG} COMPONENT ${ARG_COMPONENT} DESTINATION ${INSTALL_SYSCONF2DIR})
+    ENDIF()
   ENDIF()
 
   GET_FILENAME_COMPONENT(subpath ${CMAKE_CURRENT_SOURCE_DIR} NAME)

debian/additions/mariadb.cnf

@@ -18,6 +18,9 @@
 #
 [client-server]
 
+socket                  = /run/mysqld/mysqld.sock
+#port                   = 3306
+
 # Import all .cnf files from configuration directory
 !includedir /etc/mysql/conf.d/
 !includedir /etc/mysql/mariadb.conf.d/

debian/additions/mariadb.conf.d/50-client.cnf

@@ -7,9 +7,6 @@
 # Default is Latin1, if you need UTF-8 set this (also in server section)
 default-character-set = utf8mb4
 
-# socket location
-socket = /run/mysqld/mysqld.sock
-
 # Example of client certificate usage
 # ssl-cert=/etc/mysql/client-cert.pem
 # ssl-key=/etc/mysql/client-key.pem

debian/additions/mariadb.conf.d/50-mysql-clients.cnf

@@ -4,8 +4,6 @@
 #
 
 [mysql]
-# Default is Latin1, if you need UTF-8 set this (also in server section)
-default-character-set = utf8mb4
 
 [mysql_upgrade]
 

debian/additions/mariadb.conf.d/50-mysqld_safe.cnf

@@ -1,5 +1,5 @@
-# NOTE: This file is read only by the traditional SysV init script, not systemd.
+# NOTE: THIS FILE IS READ ONLY BY THE TRADITIONAL SYSV INIT SCRIPT, NOT SYSTEMD.
-# MariaDB systemd does _not_ utilize mysqld_safe nor read this file.
+# MARIADB SYSTEMD DOES _NOT_ UTILIZE MYSQLD_SAFE NOR READ THIS FILE.
 #
 # For similar behavior, systemd users should create the following file:
 # /etc/systemd/system/mariadb.service.d/migrated-from-my.cnf-settings.conf
@@ -22,8 +22,7 @@
 # This will be passed to all mysql clients
 # It has been reported that passwords should be enclosed with ticks/quotes
 # especially if they contain "#" chars...
-# Remember to edit /etc/mysql/debian.cnf when changing the socket location.
+
-socket = /run/mysqld/mysqld.sock
 nice   = 0
 skip_log_error
 syslog

debian/additions/mariadb.conf.d/50-server.cnf

@@ -14,8 +14,6 @@
 
 user                    = mysql
 pid-file                = /run/mysqld/mysqld.pid
-socket                  = /run/mysqld/mysqld.sock
-#port                   = 3306
 basedir                 = /usr
 datadir                 = /var/lib/mysql
 tmpdir                  = /tmp

debian/additions/my.cnf

@@ -1 +0,0 @@
-mariadb.cnf

debian/mariadb-plugin-connect.install

@@ -1,2 +1,2 @@
-etc/mysql/conf.d/connect.cnf  etc/mysql/mariadb.conf.d
+etc/mysql/mariadb.conf.d/connect.cnf
 usr/lib/mysql/plugin/ha_connect.so

debian/mariadb-plugin-cracklib-password-check.install

@@ -1,2 +1,2 @@
-etc/mysql/conf.d/cracklib_password_check.cnf etc/mysql/mariadb.conf.d
+etc/mysql/mariadb.conf.d/cracklib_password_check.cnf 
 usr/lib/mysql/plugin/cracklib_password_check.so

debian/mariadb-plugin-gssapi-server.install

@@ -1,2 +1,2 @@
-etc/mysql/conf.d/auth_gssapi.cnf etc/mysql/mariadb.conf.d
+etc/mysql/mariadb.conf.d/auth_gssapi.cnf 
 usr/lib/mysql/plugin/auth_gssapi.so

debian/mariadb-plugin-oqgraph.install

@@ -1,2 +1,2 @@
-etc/mysql/conf.d/oqgraph.cnf etc/mysql/mariadb.conf.d
+etc/mysql/mariadb.conf.d/oqgraph.cnf
 usr/lib/mysql/plugin/ha_oqgraph.so

debian/mariadb-plugin-rocksdb.install

@@ -1,4 +1,4 @@
-etc/mysql/conf.d/rocksdb.cnf etc/mysql/mariadb.conf.d
+etc/mysql/mariadb.conf.d/rocksdb.cnf
 usr/bin/mariadb-ldb
 usr/bin/myrocks_hotbackup
 usr/lib/mysql/plugin/ha_rocksdb.so

debian/mariadb-plugin-spider.install

@@ -1,2 +1,2 @@
-etc/mysql/conf.d/spider.cnf  etc/mysql/mariadb.conf.d
+etc/mysql/mariadb.conf.d/spider.cnf
 usr/lib/mysql/plugin/ha_spider.so

debian/mysql-common.install

@@ -1 +0,0 @@
-debian/additions/my.cnf etc/mysql

debian/mysql-common.links

@@ -0,0 +1 @@
+etc/mysql/mariadb.cnf etc/mysql/my.cnf

storage/spider/CMakeLists.txt

@@ -50,8 +50,14 @@ ELSEIF(PLUGIN_PARTITION MATCHES "^NO$")
 ELSE()
   INCLUDE_DIRECTORIES(${CMAKE_SOURCE_DIR}/storage/spider/hs_client)
 
-  MYSQL_ADD_PLUGIN(spider ${SPIDER_SOURCES}
+  IF(DEB)
-    STORAGE_ENGINE COMPONENT spider-engine MODULE_ONLY MODULE_OUTPUT_NAME "ha_spider")
+    SET(extra_options COMPONENT spider-engine)
+  ELSE()
+    SET(extra_options CONFIG spider.cnf)
+  ENDIF()
+
+  MYSQL_ADD_PLUGIN(spider ${SPIDER_SOURCES} ${extra_options}
+    STORAGE_ENGINE MODULE_ONLY)
   IF(NOT TARGET spider)
     RETURN()
   ENDIF()

storage/spider/spider.cnf

@@ -0,0 +1,5 @@
+[mariadb]
+#
+#  uncomment the following line to enable SPIDER storage engine
+#
+#plugin-load-add=ha_spider.so