2009-09-23 23:32:31 +02:00
|
|
|
#ifndef ITEM_SUBSELECT_INCLUDED
|
|
|
|
#define ITEM_SUBSELECT_INCLUDED
|
|
|
|
|
2012-01-13 15:50:02 +01:00
|
|
|
/* Copyright (c) 2002, 2011, Oracle and/or its affiliates.
|
2002-05-12 22:46:42 +02:00
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
2006-12-23 20:17:15 +01:00
|
|
|
the Free Software Foundation; version 2 of the License.
|
2002-05-12 22:46:42 +02:00
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program; if not, write to the Free Software
|
2011-06-30 17:46:53 +02:00
|
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */
|
2002-05-12 22:46:42 +02:00
|
|
|
|
|
|
|
/* subselect Item */
|
|
|
|
|
2005-05-04 15:05:56 +02:00
|
|
|
#ifdef USE_PRAGMA_INTERFACE
|
2002-05-12 22:46:42 +02:00
|
|
|
#pragma interface /* gcc class implementation */
|
|
|
|
#endif
|
|
|
|
|
2011-04-25 17:22:25 +02:00
|
|
|
#include <queues.h>
|
|
|
|
|
2002-09-03 08:50:36 +02:00
|
|
|
class st_select_lex;
|
|
|
|
class st_select_lex_unit;
|
2002-05-12 22:46:42 +02:00
|
|
|
class JOIN;
|
2010-01-28 14:48:33 +01:00
|
|
|
class select_result_interceptor;
|
2002-09-03 08:50:36 +02:00
|
|
|
class subselect_engine;
|
2010-01-28 14:48:33 +01:00
|
|
|
class subselect_hash_sj_engine;
|
2002-11-07 22:45:19 +01:00
|
|
|
class Item_bool_func2;
|
2010-03-31 16:05:33 +02:00
|
|
|
class Comp_creator;
|
|
|
|
|
|
|
|
typedef class st_select_lex SELECT_LEX;
|
|
|
|
|
|
|
|
/**
|
|
|
|
Convenience typedef used in this file, and further used by any files
|
|
|
|
including this file.
|
|
|
|
*/
|
|
|
|
typedef Comp_creator* (*chooser_compare_func_creator)(bool invert);
|
2010-01-28 14:48:33 +01:00
|
|
|
class Cached_item;
|
2002-11-07 22:45:19 +01:00
|
|
|
|
2002-06-19 16:52:44 +02:00
|
|
|
/* base class for subselects */
|
2002-05-12 22:46:42 +02:00
|
|
|
|
2002-11-13 00:14:39 +01:00
|
|
|
class Item_subselect :public Item_result_field
|
2002-05-12 22:46:42 +02:00
|
|
|
{
|
2011-05-04 17:08:58 +02:00
|
|
|
bool value_assigned; /* value already assigned to subselect */
|
2011-05-11 23:14:15 +02:00
|
|
|
bool own_engine; /* the engine was not taken from other Item_subselect */
|
2002-05-12 22:46:42 +02:00
|
|
|
protected:
|
2003-05-28 15:52:56 +02:00
|
|
|
/* thread handler, will be assigned in fix_fields only */
|
|
|
|
THD *thd;
|
2004-02-08 19:14:13 +01:00
|
|
|
/* old engine if engine was changed */
|
|
|
|
subselect_engine *old_engine;
|
2003-10-16 23:36:01 +02:00
|
|
|
/* cache of used external tables */
|
2004-07-04 07:46:28 +02:00
|
|
|
table_map used_tables_cache;
|
2002-09-03 08:50:36 +02:00
|
|
|
/* allowed number of columns (1 for single value subqueries) */
|
2002-06-19 16:52:44 +02:00
|
|
|
uint max_columns;
|
2004-08-13 09:01:30 +02:00
|
|
|
/* where subquery is placed */
|
|
|
|
enum_parsing_place parsing_place;
|
2002-12-06 20:55:53 +01:00
|
|
|
/* work with 'substitution' */
|
|
|
|
bool have_to_be_excluded;
|
2004-02-08 19:14:13 +01:00
|
|
|
/* cache of constant state */
|
2003-10-16 23:36:01 +02:00
|
|
|
bool const_item_cache;
|
2010-02-12 00:59:58 +01:00
|
|
|
|
|
|
|
bool inside_first_fix_fields;
|
|
|
|
bool done_first_fix_fields;
|
2011-06-21 14:50:07 +02:00
|
|
|
Item *expr_cache;
|
|
|
|
/*
|
|
|
|
Set to TRUE if at optimization or execution time we determine that this
|
|
|
|
item's value is a constant. We need this member because it is not possible
|
|
|
|
to substitute 'this' with a constant item.
|
|
|
|
*/
|
|
|
|
bool forced_const;
|
|
|
|
#ifndef DBUG_OFF
|
|
|
|
/* Count the number of times this subquery predicate has been executed. */
|
|
|
|
uint exec_counter;
|
|
|
|
#endif
|
2002-05-12 22:46:42 +02:00
|
|
|
public:
|
2010-01-28 14:48:33 +01:00
|
|
|
/*
|
|
|
|
Used inside Item_subselect::fix_fields() according to this scenario:
|
|
|
|
> Item_subselect::fix_fields
|
|
|
|
> engine->prepare
|
|
|
|
> child_join->prepare
|
|
|
|
(Here we realize we need to do the rewrite and set
|
|
|
|
substitution= some new Item, eg. Item_in_optimizer )
|
|
|
|
< child_join->prepare
|
|
|
|
< engine->prepare
|
|
|
|
*ref= substitution;
|
2010-05-11 09:53:40 +02:00
|
|
|
substitution= NULL;
|
2010-01-28 14:48:33 +01:00
|
|
|
< Item_subselect::fix_fields
|
|
|
|
*/
|
2011-06-21 14:50:07 +02:00
|
|
|
/* TODO make this protected member again. */
|
2002-11-28 18:29:26 +01:00
|
|
|
Item *substitution;
|
2002-09-03 08:50:36 +02:00
|
|
|
/* engine that perform execution of subselect (single select or union) */
|
2011-06-21 14:50:07 +02:00
|
|
|
/* TODO make this protected member again. */
|
2003-10-16 23:36:01 +02:00
|
|
|
subselect_engine *engine;
|
2011-06-21 14:50:07 +02:00
|
|
|
/* unit of subquery */
|
|
|
|
st_select_lex_unit *unit;
|
2010-02-12 00:59:58 +01:00
|
|
|
/* A reference from inside subquery predicate to somewhere outside of it */
|
|
|
|
class Ref_to_outside : public Sql_alloc
|
|
|
|
{
|
|
|
|
public:
|
|
|
|
st_select_lex *select; /* Select where the reference is pointing to */
|
|
|
|
/*
|
|
|
|
What is being referred. This may be NULL when we're referring to an
|
|
|
|
aggregate function.
|
|
|
|
*/
|
|
|
|
Item *item;
|
|
|
|
};
|
|
|
|
/*
|
|
|
|
References from within this subquery to somewhere outside of it (i.e. to
|
|
|
|
parent select, grandparent select, etc)
|
2009-06-22 13:46:31 +02:00
|
|
|
*/
|
2010-02-12 00:59:58 +01:00
|
|
|
List<Ref_to_outside> upper_refs;
|
|
|
|
st_select_lex *parent_select;
|
2010-07-10 12:37:30 +02:00
|
|
|
|
|
|
|
/*
|
2010-02-12 00:59:58 +01:00
|
|
|
TRUE<=>Table Elimination has made it redundant to evaluate this select
|
|
|
|
(and so it is not part of QEP, etc)
|
2010-07-10 12:37:30 +02:00
|
|
|
*/
|
2009-06-22 13:46:31 +02:00
|
|
|
bool eliminated;
|
|
|
|
|
2003-07-07 17:40:19 +02:00
|
|
|
/* changed engine indicator */
|
|
|
|
bool engine_changed;
|
2004-02-08 19:14:13 +01:00
|
|
|
/* subquery is transformed */
|
|
|
|
bool changed;
|
2003-07-07 17:40:19 +02:00
|
|
|
|
2006-10-31 18:51:09 +01:00
|
|
|
/* TRUE <=> The underlying SELECT is correlated w.r.t some ancestor select */
|
|
|
|
bool is_correlated;
|
|
|
|
|
2003-07-07 17:40:19 +02:00
|
|
|
enum subs_type {UNKNOWN_SUBS, SINGLEROW_SUBS,
|
2003-07-24 14:26:21 +02:00
|
|
|
EXISTS_SUBS, IN_SUBS, ALL_SUBS, ANY_SUBS};
|
2003-05-14 20:51:33 +02:00
|
|
|
|
2002-10-08 22:49:59 +02:00
|
|
|
Item_subselect();
|
|
|
|
|
2003-07-07 17:40:19 +02:00
|
|
|
virtual subs_type substype() { return UNKNOWN_SUBS; }
|
2010-09-30 17:32:44 +02:00
|
|
|
bool is_in_predicate()
|
|
|
|
{
|
|
|
|
return (substype() == Item_subselect::IN_SUBS ||
|
|
|
|
substype() == Item_subselect::ALL_SUBS ||
|
|
|
|
substype() == Item_subselect::ANY_SUBS);
|
|
|
|
}
|
2003-07-07 17:40:19 +02:00
|
|
|
|
2004-07-04 07:46:28 +02:00
|
|
|
/*
|
2010-01-28 14:48:33 +01:00
|
|
|
We need this method, because some compilers do not allow 'this'
|
|
|
|
pointer in constructor initialization list, but we need to pass a pointer
|
|
|
|
to subselect Item class to select_result_interceptor's constructor.
|
2002-10-08 22:49:59 +02:00
|
|
|
*/
|
2004-07-04 07:46:28 +02:00
|
|
|
virtual void init (st_select_lex *select_lex,
|
2010-01-28 14:48:33 +01:00
|
|
|
select_result_interceptor *result);
|
2002-10-08 22:49:59 +02:00
|
|
|
|
2002-09-03 08:50:36 +02:00
|
|
|
~Item_subselect();
|
2003-12-30 11:08:19 +01:00
|
|
|
void cleanup();
|
2004-07-04 07:46:28 +02:00
|
|
|
virtual void reset()
|
2002-09-03 08:50:36 +02:00
|
|
|
{
|
2010-03-09 16:03:54 +01:00
|
|
|
eliminated= FALSE;
|
2002-09-03 08:50:36 +02:00
|
|
|
null_value= 1;
|
|
|
|
}
|
Fix bug lp:985667, MDEV-229
Analysis:
The reason for the wrong result is the interaction between constant
optimization (in this case 1-row table) and subquery optimization.
- First the outer query is optimized, and 'make_join_statistics' finds that
table t2 has one row, reads that row, and marks the whole table as constant.
This also means that all fields of t2 are constant.
- Next, we optimize the subquery in the end of the outer 'make_join_statistics'.
The field 'f2' is considered constant, with value '3'. The subquery predicate
is rewritten as the constant TRUE.
- The outer query execution detects early that the whole query result is empty
and calls 'return_zero_rows'. Since the query is with implicit grouping, we
have to produce one row with special values for the aggregates (depending on
each aggregate function), and NULL values for all non-aggregate fields. This
function calls 'no_rows_in_result' to set each aggregate function to the
default value when it aggregates over an empty result, and then calls
'send_data', which in turn evaluates each Item in the SELECT list.
- When evaluation reaches the subquery predicate, it executes the subquery
with field 'f2' having a constant value '3', and the subquery produces the
incorrect result '7'.
Solution:
Implement Item::no_rows_in_result for all subquery predicates. In order to
make this work, it is also needed to make all val_* methods of all subquery
predicates respect the Item_subselect::forced_const flag. Otherwise subqueries
are executed anyways, and override the default value set by no_rows_in_result
with whatever result is produced from the subquery evaluation.
2012-04-27 11:59:17 +02:00
|
|
|
/**
|
|
|
|
Set the subquery result to the default value for the predicate when the
|
|
|
|
subquery is known to produce an empty result.
|
|
|
|
*/
|
|
|
|
void no_rows_in_result()= 0;
|
2010-12-15 11:54:25 +01:00
|
|
|
virtual bool select_transformer(JOIN *join);
|
2002-09-03 08:50:36 +02:00
|
|
|
bool assigned() { return value_assigned; }
|
|
|
|
void assigned(bool a) { value_assigned= a; }
|
2002-05-12 22:46:42 +02:00
|
|
|
enum Type type() const;
|
2002-12-15 10:14:53 +01:00
|
|
|
bool is_null()
|
|
|
|
{
|
2006-11-28 14:44:11 +01:00
|
|
|
update_null_value();
|
2002-12-15 10:14:53 +01:00
|
|
|
return null_value;
|
|
|
|
}
|
2005-07-01 06:05:42 +02:00
|
|
|
bool fix_fields(THD *thd, Item **ref);
|
2010-02-12 00:59:58 +01:00
|
|
|
bool mark_as_dependent(THD *thd, st_select_lex *select, Item *item);
|
|
|
|
void fix_after_pullout(st_select_lex *new_parent, Item **ref);
|
|
|
|
void recalc_used_tables(st_select_lex *new_parent, bool after_pullout);
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
virtual bool exec();
|
2010-10-23 20:28:58 +02:00
|
|
|
/*
|
|
|
|
If subquery optimization or execution determines that the subquery has
|
|
|
|
an empty result, mark the subquery predicate as a constant value.
|
|
|
|
*/
|
|
|
|
void make_const()
|
|
|
|
{
|
|
|
|
used_tables_cache= 0;
|
|
|
|
const_item_cache= 0;
|
|
|
|
forced_const= TRUE;
|
|
|
|
}
|
2002-09-28 17:34:56 +02:00
|
|
|
virtual void fix_length_and_dec();
|
2002-06-19 16:52:44 +02:00
|
|
|
table_map used_tables() const;
|
2005-04-16 07:08:34 +02:00
|
|
|
table_map not_null_tables() const { return 0; }
|
2003-10-16 23:36:01 +02:00
|
|
|
bool const_item() const;
|
2003-10-27 00:01:27 +01:00
|
|
|
inline table_map get_used_tables_cache() { return used_tables_cache; }
|
2003-12-06 20:37:24 +01:00
|
|
|
Item *get_tmp_table_item(THD *thd);
|
2003-10-16 23:36:01 +02:00
|
|
|
void update_used_tables();
|
2008-02-22 11:30:33 +01:00
|
|
|
virtual void print(String *str, enum_query_type query_type);
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
virtual bool have_guarded_conds() { return FALSE; }
|
2003-07-07 17:40:19 +02:00
|
|
|
bool change_engine(subselect_engine *eng)
|
|
|
|
{
|
2004-02-08 19:14:13 +01:00
|
|
|
old_engine= engine;
|
2003-07-07 17:40:19 +02:00
|
|
|
engine= eng;
|
|
|
|
engine_changed= 1;
|
|
|
|
return eng == 0;
|
|
|
|
}
|
2005-10-13 09:53:00 +02:00
|
|
|
/*
|
|
|
|
True if this subquery has been already evaluated. Implemented only for
|
|
|
|
single select and union subqueries only.
|
|
|
|
*/
|
|
|
|
bool is_evaluated() const;
|
2006-11-01 02:31:56 +01:00
|
|
|
bool is_uncacheable() const;
|
2010-11-22 23:01:24 +01:00
|
|
|
bool is_expensive() { return TRUE; }
|
2005-10-13 09:53:00 +02:00
|
|
|
|
2004-11-18 17:10:07 +01:00
|
|
|
/*
|
|
|
|
Used by max/min subquery to initialize value presence registration
|
|
|
|
mechanism. Engine call this method before rexecution query.
|
|
|
|
*/
|
|
|
|
virtual void reset_value_registration() {}
|
2004-10-07 21:54:31 +02:00
|
|
|
enum_parsing_place place() { return parsing_place; }
|
WL#3817: Simplify string / memory area types and make things more consistent (first part)
The following type conversions was done:
- Changed byte to uchar
- Changed gptr to uchar*
- Change my_string to char *
- Change my_size_t to size_t
- Change size_s to size_t
Removed declaration of byte, gptr, my_string, my_size_t and size_s.
Following function parameter changes was done:
- All string functions in mysys/strings was changed to use size_t
instead of uint for string lengths.
- All read()/write() functions changed to use size_t (including vio).
- All protocoll functions changed to use size_t instead of uint
- Functions that used a pointer to a string length was changed to use size_t*
- Changed malloc(), free() and related functions from using gptr to use void *
as this requires fewer casts in the code and is more in line with how the
standard functions work.
- Added extra length argument to dirname_part() to return the length of the
created string.
- Changed (at least) following functions to take uchar* as argument:
- db_dump()
- my_net_write()
- net_write_command()
- net_store_data()
- DBUG_DUMP()
- decimal2bin() & bin2decimal()
- Changed my_compress() and my_uncompress() to use size_t. Changed one
argument to my_uncompress() from a pointer to a value as we only return
one value (makes function easier to use).
- Changed type of 'pack_data' argument to packfrm() to avoid casts.
- Changed in readfrm() and writefrom(), ha_discover and handler::discover()
the type for argument 'frmdata' to uchar** to avoid casts.
- Changed most Field functions to use uchar* instead of char* (reduced a lot of
casts).
- Changed field->val_xxx(xxx, new_ptr) to take const pointers.
Other changes:
- Removed a lot of not needed casts
- Added a few new cast required by other changes
- Added some cast to my_multi_malloc() arguments for safety (as string lengths
needs to be uint, not size_t).
- Fixed all calls to hash-get-key functions to use size_t*. (Needed to be done
explicitely as this conflict was often hided by casting the function to
hash_get_key).
- Changed some buffers to memory regions to uchar* to avoid casts.
- Changed some string lengths from uint to size_t.
- Changed field->ptr to be uchar* instead of char*. This allowed us to
get rid of a lot of casts.
- Some changes from true -> TRUE, false -> FALSE, unsigned char -> uchar
- Include zlib.h in some files as we needed declaration of crc32()
- Changed MY_FILE_ERROR to be (size_t) -1.
- Changed many variables to hold the result of my_read() / my_write() to be
size_t. This was needed to properly detect errors (which are
returned as (size_t) -1).
- Removed some very old VMS code
- Changed packfrm()/unpackfrm() to not be depending on uint size
(portability fix)
- Removed windows specific code to restore cursor position as this
causes slowdown on windows and we should not mix read() and pread()
calls anyway as this is not thread safe. Updated function comment to
reflect this. Changed function that depended on original behavior of
my_pwrite() to itself restore the cursor position (one such case).
- Added some missing checking of return value of malloc().
- Changed definition of MOD_PAD_CHAR_TO_FULL_LENGTH to avoid 'long' overflow.
- Changed type of table_def::m_size from my_size_t to ulong to reflect that
m_size is the number of elements in the array, not a string/memory
length.
- Moved THD::max_row_length() to table.cc (as it's not depending on THD).
Inlined max_row_length_blob() into this function.
- More function comments
- Fixed some compiler warnings when compiled without partitions.
- Removed setting of LEX_STRING() arguments in declaration (portability fix).
- Some trivial indentation/variable name changes.
- Some trivial code simplifications:
- Replaced some calls to alloc_root + memcpy to use
strmake_root()/strdup_root().
- Changed some calls from memdup() to strmake() (Safety fix)
- Simpler loops in client-simple.c
BitKeeper/etc/ignore:
added libmysqld/ha_ndbcluster_cond.cc
---
added debian/defs.mk debian/control
client/completion_hash.cc:
Remove not needed casts
client/my_readline.h:
Remove some old types
client/mysql.cc:
Simplify types
client/mysql_upgrade.c:
Remove some old types
Update call to dirname_part
client/mysqladmin.cc:
Remove some old types
client/mysqlbinlog.cc:
Remove some old types
Change some buffers to be uchar to avoid casts
client/mysqlcheck.c:
Remove some old types
client/mysqldump.c:
Remove some old types
Remove some not needed casts
Change some string lengths to size_t
client/mysqlimport.c:
Remove some old types
client/mysqlshow.c:
Remove some old types
client/mysqlslap.c:
Remove some old types
Remove some not needed casts
client/mysqltest.c:
Removed some old types
Removed some not needed casts
Updated hash-get-key function arguments
Updated parameters to dirname_part()
client/readline.cc:
Removed some old types
Removed some not needed casts
Changed some string lengths to use size_t
client/sql_string.cc:
Removed some old types
dbug/dbug.c:
Removed some old types
Changed some string lengths to use size_t
Changed some prototypes to avoid casts
extra/comp_err.c:
Removed some old types
extra/innochecksum.c:
Removed some old types
extra/my_print_defaults.c:
Removed some old types
extra/mysql_waitpid.c:
Removed some old types
extra/perror.c:
Removed some old types
extra/replace.c:
Removed some old types
Updated parameters to dirname_part()
extra/resolve_stack_dump.c:
Removed some old types
extra/resolveip.c:
Removed some old types
include/config-win.h:
Removed some old types
include/decimal.h:
Changed binary strings to be uchar* instead of char*
include/ft_global.h:
Removed some old types
include/hash.h:
Removed some old types
include/heap.h:
Removed some old types
Changed records_under_level to be 'ulong' instead of 'uint' to clarify usage of variable
include/keycache.h:
Removed some old types
include/m_ctype.h:
Removed some old types
Changed some string lengths to use size_t
Changed character length functions to return uint
unsigned char -> uchar
include/m_string.h:
Removed some old types
Changed some string lengths to use size_t
include/my_alloc.h:
Changed some string lengths to use size_t
include/my_base.h:
Removed some old types
include/my_dbug.h:
Removed some old types
Changed some string lengths to use size_t
Changed db_dump() to take uchar * as argument for memory to reduce number of casts in usage
include/my_getopt.h:
Removed some old types
include/my_global.h:
Removed old types:
my_size_t -> size_t
byte -> uchar
gptr -> uchar *
include/my_list.h:
Removed some old types
include/my_nosys.h:
Removed some old types
include/my_pthread.h:
Removed some old types
include/my_sys.h:
Removed some old types
Changed MY_FILE_ERROR to be in line with new definitions of my_write()/my_read()
Changed some string lengths to use size_t
my_malloc() / my_free() now uses void *
Updated parameters to dirname_part() & my_uncompress()
include/my_tree.h:
Removed some old types
include/my_trie.h:
Removed some old types
include/my_user.h:
Changed some string lengths to use size_t
include/my_vle.h:
Removed some old types
include/my_xml.h:
Removed some old types
Changed some string lengths to use size_t
include/myisam.h:
Removed some old types
include/myisammrg.h:
Removed some old types
include/mysql.h:
Removed some old types
Changed byte streams to use uchar* instead of char*
include/mysql_com.h:
Removed some old types
Changed some string lengths to use size_t
Changed some buffers to be uchar* to avoid casts
include/queues.h:
Removed some old types
include/sql_common.h:
Removed some old types
include/sslopt-longopts.h:
Removed some old types
include/violite.h:
Removed some old types
Changed some string lengths to use size_t
libmysql/client_settings.h:
Removed some old types
libmysql/libmysql.c:
Removed some old types
libmysql/manager.c:
Removed some old types
libmysqld/emb_qcache.cc:
Removed some old types
libmysqld/emb_qcache.h:
Removed some old types
libmysqld/lib_sql.cc:
Removed some old types
Removed some not needed casts
Changed some buffers to be uchar* to avoid casts
true -> TRUE, false -> FALSE
mysys/array.c:
Removed some old types
mysys/charset.c:
Changed some string lengths to use size_t
mysys/checksum.c:
Include zlib to get definition for crc32
Removed some old types
mysys/default.c:
Removed some old types
Changed some string lengths to use size_t
mysys/default_modify.c:
Changed some string lengths to use size_t
Removed some not needed casts
mysys/hash.c:
Removed some old types
Changed some string lengths to use size_t
Note: Prototype of hash_key() has changed which may cause problems if client uses hash_init() with a cast for the hash-get-key function.
hash_element now takes 'ulong' as the index type (cleanup)
mysys/list.c:
Removed some old types
mysys/mf_cache.c:
Changed some string lengths to use size_t
mysys/mf_dirname.c:
Removed some old types
Changed some string lengths to use size_t
Added argument to dirname_part() to avoid calculation of length for 'to'
mysys/mf_fn_ext.c:
Removed some old types
Updated parameters to dirname_part()
mysys/mf_format.c:
Removed some old types
Changed some string lengths to use size_t
mysys/mf_getdate.c:
Removed some old types
mysys/mf_iocache.c:
Removed some old types
Changed some string lengths to use size_t
Changed calculation of 'max_length' to be done the same way in all functions
mysys/mf_iocache2.c:
Removed some old types
Changed some string lengths to use size_t
Clean up comments
Removed not needed indentation
mysys/mf_keycache.c:
Removed some old types
mysys/mf_keycaches.c:
Removed some old types
mysys/mf_loadpath.c:
Removed some old types
mysys/mf_pack.c:
Removed some old types
Changed some string lengths to use size_t
Removed some not needed casts
Removed very old VMS code
Updated parameters to dirname_part()
Use result of dirnam_part() to remove call to strcat()
mysys/mf_path.c:
Removed some old types
mysys/mf_radix.c:
Removed some old types
mysys/mf_same.c:
Removed some old types
mysys/mf_sort.c:
Removed some old types
mysys/mf_soundex.c:
Removed some old types
mysys/mf_strip.c:
Removed some old types
mysys/mf_tempdir.c:
Removed some old types
mysys/mf_unixpath.c:
Removed some old types
mysys/mf_wfile.c:
Removed some old types
mysys/mulalloc.c:
Removed some old types
mysys/my_alloc.c:
Removed some old types
Changed some string lengths to use size_t
Use void* as type for allocated memory area
Removed some not needed casts
Changed argument 'Size' to 'length' according coding guidelines
mysys/my_chsize.c:
Changed some buffers to be uchar* to avoid casts
mysys/my_compress.c:
More comments
Removed some old types
Changed string lengths to use size_t
Changed arguments to my_uncompress() to make them easier to understand
Changed packfrm()/unpackfrm() to not be depending on uint size (portability fix)
Changed type of 'pack_data' argument to packfrm() to avoid casts.
mysys/my_conio.c:
Changed some string lengths to use size_t
mysys/my_create.c:
Removed some old types
mysys/my_div.c:
Removed some old types
mysys/my_error.c:
Removed some old types
mysys/my_fopen.c:
Removed some old types
mysys/my_fstream.c:
Removed some old types
Changed some string lengths to use size_t
writen -> written
mysys/my_getopt.c:
Removed some old types
mysys/my_getwd.c:
Removed some old types
More comments
mysys/my_init.c:
Removed some old types
mysys/my_largepage.c:
Removed some old types
Changed some string lengths to use size_t
mysys/my_lib.c:
Removed some old types
mysys/my_lockmem.c:
Removed some old types
mysys/my_malloc.c:
Removed some old types
Changed malloc(), free() and related functions to use void *
Changed all functions to use size_t
mysys/my_memmem.c:
Indentation cleanup
mysys/my_once.c:
Removed some old types
Changed malloc(), free() and related functions to use void *
mysys/my_open.c:
Removed some old types
mysys/my_pread.c:
Removed some old types
Changed all functions to use size_t
Added comment for how my_pread() / my_pwrite() are supposed to work.
Removed windows specific code to restore cursor position as this causes slowdown on windows and we should not mix read() and pread() calls anyway as this is not thread safe.
(If we ever would really need this, it should be enabled only with a flag argument)
mysys/my_quick.c:
Removed some old types
Changed all functions to use size_t
mysys/my_read.c:
Removed some old types
Changed all functions to use size_t
mysys/my_realloc.c:
Removed some old types
Use void* as type for allocated memory area
Changed all functions to use size_t
mysys/my_static.c:
Removed some old types
mysys/my_static.h:
Removed some old types
mysys/my_vle.c:
Removed some old types
mysys/my_wincond.c:
Removed some old types
mysys/my_windac.c:
Removed some old types
mysys/my_write.c:
Removed some old types
Changed all functions to use size_t
mysys/ptr_cmp.c:
Removed some old types
Changed all functions to use size_t
mysys/queues.c:
Removed some old types
mysys/safemalloc.c:
Removed some old types
Changed malloc(), free() and related functions to use void *
Changed all functions to use size_t
mysys/string.c:
Removed some old types
Changed all functions to use size_t
mysys/testhash.c:
Removed some old types
mysys/thr_alarm.c:
Removed some old types
mysys/thr_lock.c:
Removed some old types
mysys/tree.c:
Removed some old types
mysys/trie.c:
Removed some old types
mysys/typelib.c:
Removed some old types
plugin/daemon_example/daemon_example.cc:
Removed some old types
regex/reginit.c:
Removed some old types
server-tools/instance-manager/buffer.cc:
Changed some string lengths to use size_t
Changed buffer to be of type uchar*
server-tools/instance-manager/buffer.h:
Changed some string lengths to use size_t
Changed buffer to be of type uchar*
server-tools/instance-manager/commands.cc:
Removed some old types
Changed some string lengths to use size_t
Changed buffer to be of type uchar*
server-tools/instance-manager/instance_map.cc:
Removed some old types
Changed some string lengths to use size_t
Changed buffer to be of type uchar*
server-tools/instance-manager/instance_options.cc:
Changed buffer to be of type uchar*
Replaced alloc_root + strcpy() with strdup_root()
server-tools/instance-manager/mysql_connection.cc:
Changed buffer to be of type uchar*
server-tools/instance-manager/options.cc:
Removed some old types
server-tools/instance-manager/parse.cc:
Changed some string lengths to use size_t
server-tools/instance-manager/parse.h:
Removed some old types
Changed some string lengths to use size_t
server-tools/instance-manager/protocol.cc:
Changed some buffers to be uchar* to avoid casts
Changed some string lengths to use size_t
server-tools/instance-manager/protocol.h:
Changed some string lengths to use size_t
server-tools/instance-manager/user_map.cc:
Removed some old types
Changed some string lengths to use size_t
sql/derror.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Changed some string lengths to use size_t
sql/discover.cc:
Changed in readfrm() and writefrom() the type for argument 'frmdata' to uchar** to avoid casts
Changed some string lengths to use size_t
Changed some buffers to be uchar* to avoid casts
sql/event_data_objects.cc:
Removed some old types
Added missing casts for alloc() and sprintf()
sql/event_db_repository.cc:
Changed some buffers to be uchar* to avoid casts
Added missing casts for sprintf()
sql/event_queue.cc:
Removed some old types
sql/field.cc:
Removed some old types
Changed memory buffers to be uchar*
Changed some string lengths to use size_t
Removed a lot of casts
Safety fix in Field_blob::val_decimal() to not access zero pointer
sql/field.h:
Removed some old types
Changed memory buffers to be uchar* (except of store() as this would have caused too many other changes).
Changed some string lengths to use size_t
Removed some not needed casts
Changed val_xxx(xxx, new_ptr) to take const pointers
sql/field_conv.cc:
Removed some old types
Added casts required because memory area pointers are now uchar*
sql/filesort.cc:
Initalize variable that was used unitialized in error conditions
sql/gen_lex_hash.cc:
Removed some old types
Changed memory buffers to be uchar*
Changed some string lengths to use size_t
Removed a lot of casts
Safety fix in Field_blob::val_decimal() to not access zero pointer
sql/gstream.h:
Added required cast
sql/ha_ndbcluster.cc:
Removed some old types
Updated hash-get-key function arguments
Changed some buffers to be uchar* to avoid casts
Added required casts
Removed some not needed casts
sql/ha_ndbcluster.h:
Removed some old types
sql/ha_ndbcluster_binlog.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Replaced sql_alloc() + memcpy() + set end 0 with sql_strmake()
Changed some string lengths to use size_t
Added missing casts for alloc() and sprintf()
sql/ha_ndbcluster_binlog.h:
Removed some old types
sql/ha_ndbcluster_cond.cc:
Removed some old types
Removed some not needed casts
sql/ha_ndbcluster_cond.h:
Removed some old types
sql/ha_partition.cc:
Removed some old types
Changed prototype for change_partition() to avoid casts
sql/ha_partition.h:
Removed some old types
sql/handler.cc:
Removed some old types
Changed some string lengths to use size_t
sql/handler.h:
Removed some old types
Changed some string lengths to use size_t
Changed type for 'frmblob' parameter for discover() and ha_discover() to get fewer casts
sql/hash_filo.h:
Removed some old types
Changed all functions to use size_t
sql/hostname.cc:
Removed some old types
sql/item.cc:
Removed some old types
Changed some string lengths to use size_t
Use strmake() instead of memdup() to create a null terminated string.
Updated calls to new Field()
sql/item.h:
Removed some old types
Changed malloc(), free() and related functions to use void *
Changed some buffers to be uchar* to avoid casts
sql/item_cmpfunc.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
sql/item_cmpfunc.h:
Removed some old types
sql/item_create.cc:
Removed some old types
sql/item_func.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Removed some not needed casts
Added test for failing alloc() in init_result_field()
Remove old confusing comment
Fixed compiler warning
sql/item_func.h:
Removed some old types
sql/item_row.cc:
Removed some old types
sql/item_row.h:
Removed some old types
sql/item_strfunc.cc:
Include zlib (needed becasue we call crc32)
Removed some old types
sql/item_strfunc.h:
Removed some old types
Changed some types to match new function prototypes
sql/item_subselect.cc:
Removed some old types
sql/item_subselect.h:
Removed some old types
sql/item_sum.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Removed some not needed casts
sql/item_sum.h:
Removed some old types
sql/item_timefunc.cc:
Removed some old types
Changed some string lengths to use size_t
sql/item_timefunc.h:
Removed some old types
sql/item_xmlfunc.cc:
Changed some string lengths to use size_t
sql/item_xmlfunc.h:
Removed some old types
sql/key.cc:
Removed some old types
Removed some not needed casts
sql/lock.cc:
Removed some old types
Added some cast to my_multi_malloc() arguments for safety
sql/log.cc:
Removed some old types
Changed some string lengths to use size_t
Changed some buffers to be uchar* to avoid casts
Changed usage of pwrite() to not assume it holds the cursor position for the file
Made usage of my_read() safer
sql/log_event.cc:
Removed some old types
Added checking of return value of malloc() in pack_info()
Changed some buffers to be uchar* to avoid casts
Removed some 'const' to avoid casts
Added missing casts for alloc() and sprintf()
Added required casts
Removed some not needed casts
Added some cast to my_multi_malloc() arguments for safety
sql/log_event.h:
Removed some old types
Changed some buffers to be uchar* to avoid casts
sql/log_event_old.cc:
Changed some buffers to be uchar* to avoid casts
Removed some not needed casts
sql/log_event_old.h:
Changed some buffers to be uchar* to avoid casts
sql/mf_iocache.cc:
Removed some old types
sql/my_decimal.cc:
Changed memory area to use uchar*
sql/my_decimal.h:
Changed memory area to use uchar*
sql/mysql_priv.h:
Removed some old types
Changed malloc(), free() and related functions to use void *
Changed some string lengths to use size_t
Changed definition of MOD_PAD_CHAR_TO_FULL_LENGTH to avoid long overflow
Changed some buffers to be uchar* to avoid casts
sql/mysqld.cc:
Removed some old types
sql/net_serv.cc:
Removed some old types
Changed some string lengths to use size_t
Changed some buffers to be uchar* to avoid casts
Ensure that vio_read()/vio_write() return values are stored in a size_t variable
Removed some not needed casts
sql/opt_range.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Removed some not needed casts
sql/opt_range.h:
Removed some old types
Changed some buffers to be uchar* to avoid casts
sql/opt_sum.cc:
Removed some old types
Removed some not needed casts
sql/parse_file.cc:
Removed some old types
Changed some string lengths to use size_t
Changed alloc_root + memcpy + set end 0 -> strmake_root()
sql/parse_file.h:
Removed some old types
sql/partition_info.cc:
Removed some old types
Added missing casts for alloc()
Changed some buffers to be uchar* to avoid casts
sql/partition_info.h:
Changed some buffers to be uchar* to avoid casts
sql/protocol.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Removed some not needed casts
sql/protocol.h:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Changed some string lengths to use size_t
sql/records.cc:
Removed some old types
sql/repl_failsafe.cc:
Removed some old types
Changed some string lengths to use size_t
Added required casts
sql/rpl_filter.cc:
Removed some old types
Updated hash-get-key function arguments
Changed some string lengths to use size_t
sql/rpl_filter.h:
Changed some string lengths to use size_t
sql/rpl_injector.h:
Removed some old types
sql/rpl_record.cc:
Removed some old types
Removed some not needed casts
Changed some buffers to be uchar* to avoid casts
sql/rpl_record.h:
Removed some old types
Changed some buffers to be uchar* to avoid casts
sql/rpl_record_old.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Removed some not needed casts
sql/rpl_record_old.h:
Removed some old types
Changed some buffers to be uchar* to avoid cast
sql/rpl_rli.cc:
Removed some old types
sql/rpl_tblmap.cc:
Removed some old types
sql/rpl_tblmap.h:
Removed some old types
sql/rpl_utility.cc:
Removed some old types
sql/rpl_utility.h:
Removed some old types
Changed type of m_size from my_size_t to ulong to reflect that m_size is the number of elements in the array, not a string/memory length
sql/set_var.cc:
Removed some old types
Updated parameters to dirname_part()
sql/set_var.h:
Removed some old types
sql/slave.cc:
Removed some old types
Changed some string lengths to use size_t
sql/slave.h:
Removed some old types
sql/sp.cc:
Removed some old types
Added missing casts for printf()
sql/sp.h:
Removed some old types
Updated hash-get-key function arguments
sql/sp_cache.cc:
Removed some old types
Added missing casts for printf()
Updated hash-get-key function arguments
sql/sp_head.cc:
Removed some old types
Added missing casts for alloc() and printf()
Added required casts
Updated hash-get-key function arguments
sql/sp_head.h:
Removed some old types
sql/sp_pcontext.cc:
Removed some old types
sql/sp_pcontext.h:
Removed some old types
sql/sql_acl.cc:
Removed some old types
Changed some string lengths to use size_t
Changed some buffers to be uchar* to avoid casts
Removed some not needed casts
Added required casts
sql/sql_analyse.cc:
Changed some buffers to be uchar* to avoid casts
sql/sql_analyse.h:
Changed some buffers to be uchar* to avoid casts
sql/sql_array.h:
Removed some old types
sql/sql_base.cc:
Removed some old types
Updated hash-get-key function arguments
sql/sql_binlog.cc:
Removed some old types
Added missing casts for printf()
sql/sql_cache.cc:
Removed some old types
Updated hash-get-key function arguments
Removed some not needed casts
Changed some string lengths to use size_t
sql/sql_cache.h:
Removed some old types
Removed reference to not existing function cache_key()
Updated hash-get-key function arguments
sql/sql_class.cc:
Removed some old types
Updated hash-get-key function arguments
Added missing casts for alloc()
Updated hash-get-key function arguments
Moved THD::max_row_length() to table.cc (as it's not depending on THD)
Removed some not needed casts
sql/sql_class.h:
Removed some old types
Changed malloc(), free() and related functions to use void *
Removed some not needed casts
Changed some string lengths to use size_t
Moved max_row_length and max_row_length_blob() to table.cc, as they are not depending on THD
sql/sql_connect.cc:
Removed some old types
Added required casts
sql/sql_db.cc:
Removed some old types
Removed some not needed casts
Added some cast to my_multi_malloc() arguments for safety
Added missing casts for alloc()
sql/sql_delete.cc:
Removed some old types
sql/sql_handler.cc:
Removed some old types
Updated hash-get-key function arguments
Added some cast to my_multi_malloc() arguments for safety
sql/sql_help.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Removed some not needed casts
sql/sql_insert.cc:
Removed some old types
Added missing casts for alloc() and printf()
sql/sql_lex.cc:
Removed some old types
sql/sql_lex.h:
Removed some old types
Removed some not needed casts
sql/sql_list.h:
Removed some old types
Removed some not needed casts
sql/sql_load.cc:
Removed some old types
Removed compiler warning
sql/sql_manager.cc:
Removed some old types
sql/sql_map.cc:
Removed some old types
sql/sql_map.h:
Removed some old types
sql/sql_olap.cc:
Removed some old types
sql/sql_parse.cc:
Removed some old types
Trivial move of code lines to make things more readable
Changed some string lengths to use size_t
Added missing casts for alloc()
sql/sql_partition.cc:
Removed some old types
Removed compiler warnings about not used functions
Changed some buffers to be uchar* to avoid casts
Removed some not needed casts
sql/sql_partition.h:
Removed some old types
Changed some buffers to be uchar* to avoid casts
sql/sql_plugin.cc:
Removed some old types
Added missing casts for alloc()
Updated hash-get-key function arguments
sql/sql_prepare.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Added missing casts for alloc() and printf()
sql-common/client.c:
Removed some old types
Changed some memory areas to use uchar*
sql-common/my_user.c:
Changed some string lengths to use size_t
sql-common/pack.c:
Changed some buffers to be uchar* to avoid casts
sql/sql_repl.cc:
Added required casts
Changed some buffers to be uchar* to avoid casts
Changed some string lengths to use size_t
sql/sql_select.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Removed some old types
sql/sql_select.h:
Removed some old types
Changed some buffers to be uchar* to avoid casts
sql/sql_servers.cc:
Removed some old types
Updated hash-get-key function arguments
sql/sql_show.cc:
Removed some old types
Added missing casts for alloc()
Removed some not needed casts
sql/sql_string.cc:
Removed some old types
Added required casts
sql/sql_table.cc:
Removed some old types
Removed compiler warning about not used variable
Changed some buffers to be uchar* to avoid casts
Removed some not needed casts
sql/sql_test.cc:
Removed some old types
sql/sql_trigger.cc:
Removed some old types
Added missing casts for alloc()
sql/sql_udf.cc:
Removed some old types
Updated hash-get-key function arguments
sql/sql_union.cc:
Removed some old types
sql/sql_update.cc:
Removed some old types
Removed some not needed casts
sql/sql_view.cc:
Removed some old types
sql/sql_yacc.yy:
Removed some old types
Changed some string lengths to use size_t
Added missing casts for alloc()
sql/stacktrace.c:
Removed some old types
sql/stacktrace.h:
Removed some old types
sql/structs.h:
Removed some old types
sql/table.cc:
Removed some old types
Updated hash-get-key function arguments
Changed some buffers to be uchar* to avoid casts
Removed setting of LEX_STRING() arguments in declaration
Added required casts
More function comments
Moved max_row_length() here from sql_class.cc/sql_class.h
sql/table.h:
Removed some old types
Changed some string lengths to use size_t
sql/thr_malloc.cc:
Use void* as type for allocated memory area
Changed all functions to use size_t
sql/tzfile.h:
Changed some buffers to be uchar* to avoid casts
sql/tztime.cc:
Changed some buffers to be uchar* to avoid casts
Updated hash-get-key function arguments
Added missing casts for alloc()
Removed some not needed casts
sql/uniques.cc:
Removed some old types
Removed some not needed casts
sql/unireg.cc:
Removed some old types
Changed some buffers to be uchar* to avoid casts
Removed some not needed casts
Added missing casts for alloc()
storage/archive/archive_reader.c:
Removed some old types
storage/archive/azio.c:
Removed some old types
Removed some not needed casts
storage/archive/ha_archive.cc:
Removed some old types
Changed type for 'frmblob' in archive_discover() to match handler
Updated hash-get-key function arguments
Removed some not needed casts
storage/archive/ha_archive.h:
Removed some old types
storage/blackhole/ha_blackhole.cc:
Removed some old types
storage/blackhole/ha_blackhole.h:
Removed some old types
storage/csv/ha_tina.cc:
Removed some old types
Updated hash-get-key function arguments
Changed some buffers to be uchar* to avoid casts
storage/csv/ha_tina.h:
Removed some old types
Removed some not needed casts
storage/csv/transparent_file.cc:
Removed some old types
Changed type of 'bytes_read' to be able to detect read errors
Fixed indentation
storage/csv/transparent_file.h:
Removed some old types
storage/example/ha_example.cc:
Removed some old types
Updated hash-get-key function arguments
storage/example/ha_example.h:
Removed some old types
storage/federated/ha_federated.cc:
Removed some old types
Updated hash-get-key function arguments
Removed some not needed casts
storage/federated/ha_federated.h:
Removed some old types
storage/heap/_check.c:
Changed some buffers to be uchar* to avoid casts
storage/heap/_rectest.c:
Removed some old types
storage/heap/ha_heap.cc:
Removed some old types
storage/heap/ha_heap.h:
Removed some old types
storage/heap/heapdef.h:
Removed some old types
storage/heap/hp_block.c:
Removed some old types
Changed some string lengths to use size_t
storage/heap/hp_clear.c:
Removed some old types
storage/heap/hp_close.c:
Removed some old types
storage/heap/hp_create.c:
Removed some old types
storage/heap/hp_delete.c:
Removed some old types
storage/heap/hp_hash.c:
Removed some old types
storage/heap/hp_info.c:
Removed some old types
storage/heap/hp_open.c:
Removed some old types
storage/heap/hp_rfirst.c:
Removed some old types
storage/heap/hp_rkey.c:
Removed some old types
storage/heap/hp_rlast.c:
Removed some old types
storage/heap/hp_rnext.c:
Removed some old types
storage/heap/hp_rprev.c:
Removed some old types
storage/heap/hp_rrnd.c:
Removed some old types
storage/heap/hp_rsame.c:
Removed some old types
storage/heap/hp_scan.c:
Removed some old types
storage/heap/hp_test1.c:
Removed some old types
storage/heap/hp_test2.c:
Removed some old types
storage/heap/hp_update.c:
Removed some old types
storage/heap/hp_write.c:
Removed some old types
Changed some string lengths to use size_t
storage/innobase/handler/ha_innodb.cc:
Removed some old types
Updated hash-get-key function arguments
Added missing casts for alloc() and printf()
Removed some not needed casts
storage/innobase/handler/ha_innodb.h:
Removed some old types
storage/myisam/ft_boolean_search.c:
Removed some old types
storage/myisam/ft_nlq_search.c:
Removed some old types
storage/myisam/ft_parser.c:
Removed some old types
Changed some buffers to be uchar* to avoid casts
storage/myisam/ft_static.c:
Removed some old types
storage/myisam/ft_stopwords.c:
Removed some old types
storage/myisam/ft_update.c:
Removed some old types
Changed some buffers to be uchar* to avoid casts
storage/myisam/ftdefs.h:
Removed some old types
Changed some buffers to be uchar* to avoid casts
storage/myisam/fulltext.h:
Removed some old types
storage/myisam/ha_myisam.cc:
Removed some old types
storage/myisam/ha_myisam.h:
Removed some old types
storage/myisam/mi_cache.c:
Removed some old types
Changed some buffers to be uchar* to avoid casts
storage/myisam/mi_check.c:
Removed some old types
storage/myisam/mi_checksum.c:
Removed some old types
storage/myisam/mi_close.c:
Removed some old types
storage/myisam/mi_create.c:
Removed some old types
storage/myisam/mi_delete.c:
Removed some old types
storage/myisam/mi_delete_all.c:
Removed some old types
storage/myisam/mi_dynrec.c:
Removed some old types
storage/myisam/mi_extra.c:
Removed some old types
storage/myisam/mi_key.c:
Removed some old types
storage/myisam/mi_locking.c:
Removed some old types
storage/myisam/mi_log.c:
Removed some old types
storage/myisam/mi_open.c:
Removed some old types
Removed some not needed casts
Check argument of my_write()/my_pwrite() in functions returning int
Added casting of string lengths to size_t
storage/myisam/mi_packrec.c:
Removed some old types
Changed some buffers to be uchar* to avoid casts
storage/myisam/mi_page.c:
Removed some old types
storage/myisam/mi_preload.c:
Removed some old types
storage/myisam/mi_range.c:
Removed some old types
storage/myisam/mi_rfirst.c:
Removed some old types
storage/myisam/mi_rkey.c:
Removed some old types
storage/myisam/mi_rlast.c:
Removed some old types
storage/myisam/mi_rnext.c:
Removed some old types
storage/myisam/mi_rnext_same.c:
Removed some old types
storage/myisam/mi_rprev.c:
Removed some old types
storage/myisam/mi_rrnd.c:
Removed some old types
storage/myisam/mi_rsame.c:
Removed some old types
storage/myisam/mi_rsamepos.c:
Removed some old types
storage/myisam/mi_scan.c:
Removed some old types
storage/myisam/mi_search.c:
Removed some old types
storage/myisam/mi_static.c:
Removed some old types
storage/myisam/mi_statrec.c:
Removed some old types
storage/myisam/mi_test1.c:
Removed some old types
storage/myisam/mi_test2.c:
Removed some old types
storage/myisam/mi_test3.c:
Removed some old types
storage/myisam/mi_unique.c:
Removed some old types
storage/myisam/mi_update.c:
Removed some old types
storage/myisam/mi_write.c:
Removed some old types
storage/myisam/myisam_ftdump.c:
Removed some old types
storage/myisam/myisamchk.c:
Removed some old types
storage/myisam/myisamdef.h:
Removed some old types
storage/myisam/myisamlog.c:
Removed some old types
Indentation fix
storage/myisam/myisampack.c:
Removed some old types
storage/myisam/rt_index.c:
Removed some old types
storage/myisam/rt_split.c:
Removed some old types
storage/myisam/sort.c:
Removed some old types
storage/myisam/sp_defs.h:
Removed some old types
storage/myisam/sp_key.c:
Removed some old types
storage/myisammrg/ha_myisammrg.cc:
Removed some old types
storage/myisammrg/ha_myisammrg.h:
Removed some old types
storage/myisammrg/myrg_close.c:
Removed some old types
storage/myisammrg/myrg_def.h:
Removed some old types
storage/myisammrg/myrg_delete.c:
Removed some old types
storage/myisammrg/myrg_open.c:
Removed some old types
Updated parameters to dirname_part()
storage/myisammrg/myrg_queue.c:
Removed some old types
storage/myisammrg/myrg_rfirst.c:
Removed some old types
storage/myisammrg/myrg_rkey.c:
Removed some old types
storage/myisammrg/myrg_rlast.c:
Removed some old types
storage/myisammrg/myrg_rnext.c:
Removed some old types
storage/myisammrg/myrg_rnext_same.c:
Removed some old types
storage/myisammrg/myrg_rprev.c:
Removed some old types
storage/myisammrg/myrg_rrnd.c:
Removed some old types
storage/myisammrg/myrg_rsame.c:
Removed some old types
storage/myisammrg/myrg_update.c:
Removed some old types
storage/myisammrg/myrg_write.c:
Removed some old types
storage/ndb/include/util/ndb_opts.h:
Removed some old types
storage/ndb/src/cw/cpcd/main.cpp:
Removed some old types
storage/ndb/src/kernel/vm/Configuration.cpp:
Removed some old types
storage/ndb/src/mgmclient/main.cpp:
Removed some old types
storage/ndb/src/mgmsrv/InitConfigFileParser.cpp:
Removed some old types
Removed old disabled code
storage/ndb/src/mgmsrv/main.cpp:
Removed some old types
storage/ndb/src/ndbapi/NdbBlob.cpp:
Removed some old types
storage/ndb/src/ndbapi/NdbOperationDefine.cpp:
Removed not used variable
storage/ndb/src/ndbapi/NdbOperationInt.cpp:
Added required casts
storage/ndb/src/ndbapi/NdbScanOperation.cpp:
Added required casts
storage/ndb/tools/delete_all.cpp:
Removed some old types
storage/ndb/tools/desc.cpp:
Removed some old types
storage/ndb/tools/drop_index.cpp:
Removed some old types
storage/ndb/tools/drop_tab.cpp:
Removed some old types
storage/ndb/tools/listTables.cpp:
Removed some old types
storage/ndb/tools/ndb_config.cpp:
Removed some old types
storage/ndb/tools/restore/consumer_restore.cpp:
Changed some buffers to be uchar* to avoid casts with new defintion of packfrm()
storage/ndb/tools/restore/restore_main.cpp:
Removed some old types
storage/ndb/tools/select_all.cpp:
Removed some old types
storage/ndb/tools/select_count.cpp:
Removed some old types
storage/ndb/tools/waiter.cpp:
Removed some old types
strings/bchange.c:
Changed function to use uchar * and size_t
strings/bcmp.c:
Changed function to use uchar * and size_t
strings/bmove512.c:
Changed function to use uchar * and size_t
strings/bmove_upp.c:
Changed function to use uchar * and size_t
strings/ctype-big5.c:
Changed functions to use size_t
Changed character length functions to return uint
strings/ctype-bin.c:
Changed functions to use size_t
strings/ctype-cp932.c:
Changed functions to use size_t
Changed character length functions to return uint
strings/ctype-czech.c:
Fixed indentation
Changed functions to use size_t
strings/ctype-euc_kr.c:
Changed functions to use size_t
Changed character length functions to return uint
strings/ctype-eucjpms.c:
Changed functions to use size_t
Changed character length functions to return uint
unsigned char -> uchar
strings/ctype-gb2312.c:
Changed functions to use size_t
Changed character length functions to return uint
strings/ctype-gbk.c:
Changed functions to use size_t
Changed character length functions to return uint
strings/ctype-latin1.c:
Changed functions to use size_t
Changed character length functions to return uint
unsigned char -> uchar
strings/ctype-mb.c:
Changed functions to use size_t
Changed character length functions to return uint
strings/ctype-simple.c:
Changed functions to use size_t
Simpler loops for caseup/casedown
unsigned int -> uint
unsigned char -> uchar
strings/ctype-sjis.c:
Changed functions to use size_t
Changed character length functions to return uint
strings/ctype-tis620.c:
Changed functions to use size_t
Changed character length functions to return uint
unsigned char -> uchar
strings/ctype-uca.c:
Changed functions to use size_t
unsigned char -> uchar
strings/ctype-ucs2.c:
Moved inclusion of stdarg.h to other includes
usigned char -> uchar
Changed functions to use size_t
Changed character length functions to return uint
strings/ctype-ujis.c:
Changed functions to use size_t
Changed character length functions to return uint
unsigned char -> uchar
strings/ctype-utf8.c:
Changed functions to use size_t
unsigned char -> uchar
Indentation fixes
strings/ctype-win1250ch.c:
Indentation fixes
Changed functions to use size_t
strings/ctype.c:
Changed functions to use size_t
strings/decimal.c:
Changed type for memory argument to uchar *
strings/do_ctype.c:
Indentation fixes
strings/my_strtoll10.c:
unsigned char -> uchar
strings/my_vsnprintf.c:
Changed functions to use size_t
strings/r_strinstr.c:
Removed some old types
Changed functions to use size_t
strings/str_test.c:
Removed some old types
strings/strappend.c:
Changed functions to use size_t
strings/strcont.c:
Removed some old types
strings/strfill.c:
Removed some old types
strings/strinstr.c:
Changed functions to use size_t
strings/strlen.c:
Changed functions to use size_t
strings/strmake.c:
Changed functions to use size_t
strings/strnlen.c:
Changed functions to use size_t
strings/strnmov.c:
Changed functions to use size_t
strings/strto.c:
unsigned char -> uchar
strings/strtod.c:
Changed functions to use size_t
strings/strxnmov.c:
Changed functions to use size_t
strings/xml.c:
Changed functions to use size_t
Indentation fixes
tests/mysql_client_test.c:
Removed some old types
tests/thread_test.c:
Removed some old types
vio/test-ssl.c:
Removed some old types
vio/test-sslclient.c:
Removed some old types
vio/test-sslserver.c:
Removed some old types
vio/vio.c:
Removed some old types
vio/vio_priv.h:
Removed some old types
Changed vio_read()/vio_write() to work with size_t
vio/viosocket.c:
Changed vio_read()/vio_write() to work with size_t
Indentation fixes
vio/viossl.c:
Changed vio_read()/vio_write() to work with size_t
Indentation fixes
vio/viosslfactories.c:
Removed some old types
vio/viotest-ssl.c:
Removed some old types
win/README:
More explanations
2007-05-10 11:59:39 +02:00
|
|
|
bool walk(Item_processor processor, bool walk_subquery, uchar *arg);
|
2009-06-22 13:46:31 +02:00
|
|
|
bool mark_as_eliminated_processor(uchar *arg);
|
2010-09-05 17:43:47 +02:00
|
|
|
bool eliminate_subselect_processor(uchar *arg);
|
|
|
|
bool set_fake_select_as_master_processor(uchar *arg);
|
2009-08-31 22:02:09 +02:00
|
|
|
bool enumerate_field_refs_processor(uchar *arg);
|
2009-10-17 00:57:48 +02:00
|
|
|
bool check_vcol_func_processor(uchar *int_arg)
|
|
|
|
{
|
|
|
|
return trace_unsupported_by_check_vcol_func_processor("subselect");
|
|
|
|
}
|
2010-11-22 23:01:24 +01:00
|
|
|
/**
|
|
|
|
Callback to test if an IN predicate is expensive.
|
2002-05-12 22:46:42 +02:00
|
|
|
|
2010-11-22 23:01:24 +01:00
|
|
|
@notes
|
|
|
|
The return value affects the behavior of make_cond_for_table().
|
|
|
|
|
|
|
|
@retval TRUE if the predicate is expensive
|
|
|
|
@retval FALSE otherwise
|
|
|
|
*/
|
|
|
|
bool is_expensive_processor(uchar *arg) { return TRUE; }
|
2002-05-12 22:46:42 +02:00
|
|
|
|
Bug#21904 (parser problem when using IN with a double "(())")
Before this fix, a IN predicate of the form: "IN (( subselect ))", with two
parenthesis, would be evaluated as a single row subselect: if the subselect
returns more that 1 row, the statement would fail.
The SQL:2003 standard defines a special exception in the specification,
and mandates that this particular form of IN predicate shall be equivalent
to "IN ( subselect )", which involves a table subquery and works with more
than 1 row.
This fix implements "IN (( subselect ))", "IN ((( subselect )))" etc
as per the SQL:2003 requirement.
All the details related to the implementation of this change have been
commented in the code, and the relevant sections of the SQL:2003 spec
are given for reference, so they are not repeated here.
Having access to the spec is a requirement to review in depth this patch.
mysql-test/r/subselect.result:
Implement IN predicate special exceptions with subselects.
mysql-test/t/subselect.test:
Implement IN predicate special exceptions with subselects.
sql/item_subselect.cc:
Implement IN predicate special exceptions with subselects.
sql/item_subselect.h:
Implement IN predicate special exceptions with subselects.
sql/sql_yacc.yy:
Implement IN predicate special exceptions with subselects, cleanup.
2007-01-30 01:32:52 +01:00
|
|
|
/**
|
|
|
|
Get the SELECT_LEX structure associated with this Item.
|
|
|
|
@return the SELECT_LEX structure associated with this Item
|
|
|
|
*/
|
|
|
|
st_select_lex* get_select_lex();
|
2009-11-17 15:06:46 +01:00
|
|
|
const char *func_name() const { DBUG_ASSERT(0); return "subselect"; }
|
2010-07-10 12:37:30 +02:00
|
|
|
virtual bool expr_cache_is_needed(THD *);
|
2011-07-19 22:19:10 +02:00
|
|
|
virtual void get_cache_parameters(List<Item> ¶meters);
|
2011-11-13 11:02:13 +01:00
|
|
|
virtual bool is_subquery_processor (uchar *opt_arg) { return 1; }
|
2011-12-19 08:38:37 +01:00
|
|
|
bool limit_index_condition_pushdown_processor(uchar *opt_arg)
|
|
|
|
{
|
|
|
|
return TRUE;
|
|
|
|
}
|
Bug#21904 (parser problem when using IN with a double "(())")
Before this fix, a IN predicate of the form: "IN (( subselect ))", with two
parenthesis, would be evaluated as a single row subselect: if the subselect
returns more that 1 row, the statement would fail.
The SQL:2003 standard defines a special exception in the specification,
and mandates that this particular form of IN predicate shall be equivalent
to "IN ( subselect )", which involves a table subquery and works with more
than 1 row.
This fix implements "IN (( subselect ))", "IN ((( subselect )))" etc
as per the SQL:2003 requirement.
All the details related to the implementation of this change have been
commented in the code, and the relevant sections of the SQL:2003 spec
are given for reference, so they are not repeated here.
Having access to the spec is a requirement to review in depth this patch.
mysql-test/r/subselect.result:
Implement IN predicate special exceptions with subselects.
mysql-test/t/subselect.test:
Implement IN predicate special exceptions with subselects.
sql/item_subselect.cc:
Implement IN predicate special exceptions with subselects.
sql/item_subselect.h:
Implement IN predicate special exceptions with subselects.
sql/sql_yacc.yy:
Implement IN predicate special exceptions with subselects, cleanup.
2007-01-30 01:32:52 +01:00
|
|
|
|
2010-01-28 14:48:33 +01:00
|
|
|
friend class select_result_interceptor;
|
2002-12-19 20:15:09 +01:00
|
|
|
friend class Item_in_optimizer;
|
2005-07-01 06:05:42 +02:00
|
|
|
friend bool Item_field::fix_fields(THD *, Item **);
|
2006-02-15 17:45:06 +01:00
|
|
|
friend int Item_field::fix_outer_field(THD *, Field **, Item **);
|
2005-07-01 06:05:42 +02:00
|
|
|
friend bool Item_ref::fix_fields(THD *, Item **);
|
2005-04-29 01:43:56 +02:00
|
|
|
friend void mark_select_range_as_dependent(THD*,
|
|
|
|
st_select_lex*, st_select_lex*,
|
|
|
|
Field*, Item*, Item_ident*);
|
2010-10-10 16:18:11 +02:00
|
|
|
friend bool convert_join_subqueries_to_semijoins(JOIN *join);
|
|
|
|
|
2002-05-12 22:46:42 +02:00
|
|
|
};
|
|
|
|
|
2002-06-19 16:52:44 +02:00
|
|
|
/* single value subselect */
|
|
|
|
|
2002-12-19 06:38:32 +01:00
|
|
|
class Item_cache;
|
2002-12-19 20:15:09 +01:00
|
|
|
class Item_singlerow_subselect :public Item_subselect
|
2002-06-19 16:52:44 +02:00
|
|
|
{
|
|
|
|
protected:
|
2002-12-19 06:38:33 +01:00
|
|
|
Item_cache *value, **row;
|
2002-06-19 16:52:44 +02:00
|
|
|
public:
|
2003-10-02 21:19:41 +02:00
|
|
|
Item_singlerow_subselect(st_select_lex *select_lex);
|
2010-09-06 14:34:24 +02:00
|
|
|
Item_singlerow_subselect() :Item_subselect(), value(0), row (0)
|
|
|
|
{}
|
2003-07-07 17:40:19 +02:00
|
|
|
|
2004-02-08 19:14:13 +01:00
|
|
|
void cleanup();
|
2003-07-07 17:40:19 +02:00
|
|
|
subs_type substype() { return SINGLEROW_SUBS; }
|
|
|
|
|
2002-12-19 06:38:32 +01:00
|
|
|
void reset();
|
Fix bug lp:985667, MDEV-229
Analysis:
The reason for the wrong result is the interaction between constant
optimization (in this case 1-row table) and subquery optimization.
- First the outer query is optimized, and 'make_join_statistics' finds that
table t2 has one row, reads that row, and marks the whole table as constant.
This also means that all fields of t2 are constant.
- Next, we optimize the subquery in the end of the outer 'make_join_statistics'.
The field 'f2' is considered constant, with value '3'. The subquery predicate
is rewritten as the constant TRUE.
- The outer query execution detects early that the whole query result is empty
and calls 'return_zero_rows'. Since the query is with implicit grouping, we
have to produce one row with special values for the aggregates (depending on
each aggregate function), and NULL values for all non-aggregate fields. This
function calls 'no_rows_in_result' to set each aggregate function to the
default value when it aggregates over an empty result, and then calls
'send_data', which in turn evaluates each Item in the SELECT list.
- When evaluation reaches the subquery predicate, it executes the subquery
with field 'f2' having a constant value '3', and the subquery produces the
incorrect result '7'.
Solution:
Implement Item::no_rows_in_result for all subquery predicates. In order to
make this work, it is also needed to make all val_* methods of all subquery
predicates respect the Item_subselect::forced_const flag. Otherwise subqueries
are executed anyways, and override the default value set by no_rows_in_result
with whatever result is produced from the subquery evaluation.
2012-04-27 11:59:17 +02:00
|
|
|
void no_rows_in_result() { reset(); make_const(); }
|
2010-12-15 11:54:25 +01:00
|
|
|
bool select_transformer(JOIN *join);
|
2002-12-19 06:38:33 +01:00
|
|
|
void store(uint i, Item* item);
|
2004-11-11 19:39:35 +01:00
|
|
|
double val_real();
|
2002-06-19 16:52:44 +02:00
|
|
|
longlong val_int ();
|
|
|
|
String *val_str (String *);
|
2005-02-08 23:50:45 +01:00
|
|
|
my_decimal *val_decimal(my_decimal *);
|
|
|
|
bool val_bool();
|
2012-05-04 07:16:38 +02:00
|
|
|
bool get_date(MYSQL_TIME *ltime, ulonglong fuzzydate);
|
2002-12-19 06:38:32 +01:00
|
|
|
enum Item_result result_type() const;
|
2006-11-07 17:16:17 +01:00
|
|
|
enum_field_types field_type() const;
|
2002-09-28 17:34:56 +02:00
|
|
|
void fix_length_and_dec();
|
2002-11-13 00:14:39 +01:00
|
|
|
|
2002-12-19 06:38:33 +01:00
|
|
|
uint cols();
|
2010-07-23 22:16:29 +02:00
|
|
|
Item* element_index(uint i) { return reinterpret_cast<Item*>(row[i]); }
|
2002-12-19 06:38:33 +01:00
|
|
|
Item** addr(uint i) { return (Item**)row + i; }
|
|
|
|
bool check_cols(uint c);
|
|
|
|
bool null_inside();
|
|
|
|
void bring_value();
|
|
|
|
|
Bug#21904 (parser problem when using IN with a double "(())")
Before this fix, a IN predicate of the form: "IN (( subselect ))", with two
parenthesis, would be evaluated as a single row subselect: if the subselect
returns more that 1 row, the statement would fail.
The SQL:2003 standard defines a special exception in the specification,
and mandates that this particular form of IN predicate shall be equivalent
to "IN ( subselect )", which involves a table subquery and works with more
than 1 row.
This fix implements "IN (( subselect ))", "IN ((( subselect )))" etc
as per the SQL:2003 requirement.
All the details related to the implementation of this change have been
commented in the code, and the relevant sections of the SQL:2003 spec
are given for reference, so they are not repeated here.
Having access to the spec is a requirement to review in depth this patch.
mysql-test/r/subselect.result:
Implement IN predicate special exceptions with subselects.
mysql-test/t/subselect.test:
Implement IN predicate special exceptions with subselects.
sql/item_subselect.cc:
Implement IN predicate special exceptions with subselects.
sql/item_subselect.h:
Implement IN predicate special exceptions with subselects.
sql/sql_yacc.yy:
Implement IN predicate special exceptions with subselects, cleanup.
2007-01-30 01:32:52 +01:00
|
|
|
/**
|
|
|
|
This method is used to implement a special case of semantic tree
|
|
|
|
rewriting, mandated by a SQL:2003 exception in the specification.
|
|
|
|
The only caller of this method is handle_sql2003_note184_exception(),
|
|
|
|
see the code there for more details.
|
2007-02-01 17:36:17 +01:00
|
|
|
Note that this method breaks the object internal integrity, by
|
|
|
|
removing it's association with the corresponding SELECT_LEX,
|
|
|
|
making this object orphan from the parse tree.
|
|
|
|
No other method, beside the destructor, should be called on this
|
|
|
|
object, as it is now invalid.
|
Bug#21904 (parser problem when using IN with a double "(())")
Before this fix, a IN predicate of the form: "IN (( subselect ))", with two
parenthesis, would be evaluated as a single row subselect: if the subselect
returns more that 1 row, the statement would fail.
The SQL:2003 standard defines a special exception in the specification,
and mandates that this particular form of IN predicate shall be equivalent
to "IN ( subselect )", which involves a table subquery and works with more
than 1 row.
This fix implements "IN (( subselect ))", "IN ((( subselect )))" etc
as per the SQL:2003 requirement.
All the details related to the implementation of this change have been
commented in the code, and the relevant sections of the SQL:2003 spec
are given for reference, so they are not repeated here.
Having access to the spec is a requirement to review in depth this patch.
mysql-test/r/subselect.result:
Implement IN predicate special exceptions with subselects.
mysql-test/t/subselect.test:
Implement IN predicate special exceptions with subselects.
sql/item_subselect.cc:
Implement IN predicate special exceptions with subselects.
sql/item_subselect.h:
Implement IN predicate special exceptions with subselects.
sql/sql_yacc.yy:
Implement IN predicate special exceptions with subselects, cleanup.
2007-01-30 01:32:52 +01:00
|
|
|
@return the SELECT_LEX structure that was given in the constructor.
|
|
|
|
*/
|
|
|
|
st_select_lex* invalidate_and_restore_select_lex();
|
|
|
|
|
2010-07-10 12:37:30 +02:00
|
|
|
Item* expr_cache_insert_transformer(uchar *thd_arg);
|
|
|
|
|
2002-12-19 20:15:09 +01:00
|
|
|
friend class select_singlerow_subselect;
|
2002-06-19 16:52:44 +02:00
|
|
|
};
|
|
|
|
|
2005-02-08 23:50:45 +01:00
|
|
|
/* used in static ALL/ANY optimization */
|
2004-11-18 17:10:07 +01:00
|
|
|
class select_max_min_finder_subselect;
|
2003-10-27 00:01:27 +01:00
|
|
|
class Item_maxmin_subselect :public Item_singlerow_subselect
|
2003-08-12 11:38:03 +02:00
|
|
|
{
|
2004-11-18 17:10:07 +01:00
|
|
|
protected:
|
2003-10-16 14:54:47 +02:00
|
|
|
bool max;
|
2004-12-07 20:18:15 +01:00
|
|
|
bool was_values; // Set if we have found at least one row
|
2003-08-12 11:38:03 +02:00
|
|
|
public:
|
2004-09-10 12:09:27 +02:00
|
|
|
Item_maxmin_subselect(THD *thd, Item_subselect *parent,
|
2003-10-27 00:01:27 +01:00
|
|
|
st_select_lex *select_lex, bool max);
|
2008-02-22 11:30:33 +01:00
|
|
|
virtual void print(String *str, enum_query_type query_type);
|
2004-11-18 17:10:07 +01:00
|
|
|
void cleanup();
|
|
|
|
bool any_value() { return was_values; }
|
|
|
|
void register_value() { was_values= TRUE; }
|
|
|
|
void reset_value_registration() { was_values= FALSE; }
|
Fix bug lp:985667, MDEV-229
Analysis:
The reason for the wrong result is the interaction between constant
optimization (in this case 1-row table) and subquery optimization.
- First the outer query is optimized, and 'make_join_statistics' finds that
table t2 has one row, reads that row, and marks the whole table as constant.
This also means that all fields of t2 are constant.
- Next, we optimize the subquery in the end of the outer 'make_join_statistics'.
The field 'f2' is considered constant, with value '3'. The subquery predicate
is rewritten as the constant TRUE.
- The outer query execution detects early that the whole query result is empty
and calls 'return_zero_rows'. Since the query is with implicit grouping, we
have to produce one row with special values for the aggregates (depending on
each aggregate function), and NULL values for all non-aggregate fields. This
function calls 'no_rows_in_result' to set each aggregate function to the
default value when it aggregates over an empty result, and then calls
'send_data', which in turn evaluates each Item in the SELECT list.
- When evaluation reaches the subquery predicate, it executes the subquery
with field 'f2' having a constant value '3', and the subquery produces the
incorrect result '7'.
Solution:
Implement Item::no_rows_in_result for all subquery predicates. In order to
make this work, it is also needed to make all val_* methods of all subquery
predicates respect the Item_subselect::forced_const flag. Otherwise subqueries
are executed anyways, and override the default value set by no_rows_in_result
with whatever result is produced from the subquery evaluation.
2012-04-27 11:59:17 +02:00
|
|
|
void no_rows_in_result();
|
2003-08-12 11:38:03 +02:00
|
|
|
};
|
|
|
|
|
2002-06-19 16:52:44 +02:00
|
|
|
/* exists subselect */
|
|
|
|
|
|
|
|
class Item_exists_subselect :public Item_subselect
|
|
|
|
{
|
|
|
|
protected:
|
2005-04-01 01:14:30 +02:00
|
|
|
bool value; /* value of this item (boolean: exists/not-exists) */
|
2002-06-19 16:52:44 +02:00
|
|
|
|
2011-05-11 23:14:15 +02:00
|
|
|
void init_length_and_dec();
|
|
|
|
|
2002-06-19 16:52:44 +02:00
|
|
|
public:
|
2003-10-02 21:19:41 +02:00
|
|
|
Item_exists_subselect(st_select_lex *select_lex);
|
2002-10-27 22:27:00 +01:00
|
|
|
Item_exists_subselect(): Item_subselect() {}
|
|
|
|
|
2003-07-07 17:40:19 +02:00
|
|
|
subs_type substype() { return EXISTS_SUBS; }
|
2002-12-19 06:38:32 +01:00
|
|
|
void reset()
|
2002-09-03 08:50:36 +02:00
|
|
|
{
|
2010-03-09 16:03:54 +01:00
|
|
|
eliminated= FALSE;
|
2002-09-03 08:50:36 +02:00
|
|
|
value= 0;
|
|
|
|
}
|
Fix bug lp:985667, MDEV-229
Analysis:
The reason for the wrong result is the interaction between constant
optimization (in this case 1-row table) and subquery optimization.
- First the outer query is optimized, and 'make_join_statistics' finds that
table t2 has one row, reads that row, and marks the whole table as constant.
This also means that all fields of t2 are constant.
- Next, we optimize the subquery in the end of the outer 'make_join_statistics'.
The field 'f2' is considered constant, with value '3'. The subquery predicate
is rewritten as the constant TRUE.
- The outer query execution detects early that the whole query result is empty
and calls 'return_zero_rows'. Since the query is with implicit grouping, we
have to produce one row with special values for the aggregates (depending on
each aggregate function), and NULL values for all non-aggregate fields. This
function calls 'no_rows_in_result' to set each aggregate function to the
default value when it aggregates over an empty result, and then calls
'send_data', which in turn evaluates each Item in the SELECT list.
- When evaluation reaches the subquery predicate, it executes the subquery
with field 'f2' having a constant value '3', and the subquery produces the
incorrect result '7'.
Solution:
Implement Item::no_rows_in_result for all subquery predicates. In order to
make this work, it is also needed to make all val_* methods of all subquery
predicates respect the Item_subselect::forced_const flag. Otherwise subqueries
are executed anyways, and override the default value set by no_rows_in_result
with whatever result is produced from the subquery evaluation.
2012-04-27 11:59:17 +02:00
|
|
|
void no_rows_in_result();
|
2002-09-03 08:50:36 +02:00
|
|
|
|
2002-06-19 16:52:44 +02:00
|
|
|
enum Item_result result_type() const { return INT_RESULT;}
|
|
|
|
longlong val_int();
|
2004-11-11 19:39:35 +01:00
|
|
|
double val_real();
|
2002-06-19 16:52:44 +02:00
|
|
|
String *val_str(String*);
|
2005-02-08 23:50:45 +01:00
|
|
|
my_decimal *val_decimal(my_decimal *);
|
|
|
|
bool val_bool();
|
2002-09-28 17:34:56 +02:00
|
|
|
void fix_length_and_dec();
|
2008-02-22 11:30:33 +01:00
|
|
|
virtual void print(String *str, enum_query_type query_type);
|
2002-12-06 20:55:53 +01:00
|
|
|
|
2010-07-10 12:37:30 +02:00
|
|
|
Item* expr_cache_insert_transformer(uchar *thd_arg);
|
|
|
|
|
2002-06-19 16:52:44 +02:00
|
|
|
friend class select_exists_subselect;
|
2003-09-14 08:40:57 +02:00
|
|
|
friend class subselect_uniquesubquery_engine;
|
|
|
|
friend class subselect_indexsubquery_engine;
|
2002-06-19 16:52:44 +02:00
|
|
|
};
|
2002-09-03 08:50:36 +02:00
|
|
|
|
2006-10-31 18:51:09 +01:00
|
|
|
|
2011-03-29 12:33:59 +02:00
|
|
|
TABLE_LIST * const NO_JOIN_NEST=(TABLE_LIST*)0x1;
|
|
|
|
|
2010-09-30 17:32:44 +02:00
|
|
|
/*
|
|
|
|
Possible methods to execute an IN predicate. These are set by the optimizer
|
2010-10-05 15:00:31 +02:00
|
|
|
based on user-set optimizer switches, semantic analysis and cost comparison.
|
2010-09-30 17:32:44 +02:00
|
|
|
*/
|
|
|
|
#define SUBS_NOT_TRANSFORMED 0 /* No execution method was chosen for this IN. */
|
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
******
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
2011-11-12 10:29:12 +01:00
|
|
|
/* The Final decision about the strategy is made. */
|
|
|
|
#define SUBS_STRATEGY_CHOSEN 1
|
|
|
|
#define SUBS_SEMI_JOIN 2 /* IN was converted to semi-join. */
|
|
|
|
#define SUBS_IN_TO_EXISTS 4 /* IN was converted to correlated EXISTS. */
|
|
|
|
#define SUBS_MATERIALIZATION 8 /* Execute IN via subquery materialization. */
|
2010-09-30 17:32:44 +02:00
|
|
|
/* Partial matching substrategies of MATERIALIZATION. */
|
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
******
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
2011-11-12 10:29:12 +01:00
|
|
|
#define SUBS_PARTIAL_MATCH_ROWID_MERGE 16
|
|
|
|
#define SUBS_PARTIAL_MATCH_TABLE_SCAN 32
|
2011-05-04 17:08:58 +02:00
|
|
|
/* ALL/ANY will be transformed with max/min optimization */
|
2011-07-18 22:45:38 +02:00
|
|
|
/* The subquery has not aggregates, transform it into a MAX/MIN query. */
|
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
******
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
2011-11-12 10:29:12 +01:00
|
|
|
#define SUBS_MAXMIN_INJECTED 64
|
2011-07-18 22:45:38 +02:00
|
|
|
/* The subquery has aggregates, use a special max/min subselect engine. */
|
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
******
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
2011-11-12 10:29:12 +01:00
|
|
|
#define SUBS_MAXMIN_ENGINE 128
|
2011-05-04 17:08:58 +02:00
|
|
|
|
2010-09-30 17:32:44 +02:00
|
|
|
|
2010-01-28 14:48:33 +01:00
|
|
|
/**
|
|
|
|
Representation of IN subquery predicates of the form
|
|
|
|
"left_expr IN (SELECT ...)".
|
2006-10-31 18:51:09 +01:00
|
|
|
|
2010-02-19 22:55:57 +01:00
|
|
|
@details
|
2006-10-31 18:51:09 +01:00
|
|
|
This class has:
|
2010-01-28 14:48:33 +01:00
|
|
|
- A "subquery execution engine" (as a subclass of Item_subselect) that allows
|
|
|
|
it to evaluate subqueries. (and this class participates in execution by
|
|
|
|
having was_null variable where part of execution result is stored.
|
2006-10-31 18:51:09 +01:00
|
|
|
- Transformation methods (todo: more on this).
|
|
|
|
|
|
|
|
This class is not used directly, it is "wrapped" into Item_in_optimizer
|
|
|
|
which provides some small bits of subquery evaluation.
|
|
|
|
*/
|
2002-10-27 22:27:00 +01:00
|
|
|
|
|
|
|
class Item_in_subselect :public Item_exists_subselect
|
|
|
|
{
|
2010-01-17 15:51:10 +01:00
|
|
|
protected:
|
2010-01-28 14:48:33 +01:00
|
|
|
/*
|
|
|
|
Cache of the left operand of the subquery predicate. Allocated in the
|
|
|
|
runtime memory root, for each execution, thus need not be freed.
|
|
|
|
*/
|
|
|
|
List<Cached_item> *left_expr_cache;
|
|
|
|
bool first_execution;
|
|
|
|
|
2003-05-14 20:51:33 +02:00
|
|
|
/*
|
2003-07-02 00:45:22 +02:00
|
|
|
expr & optimizer used in subselect rewriting to store Item for
|
2003-05-14 20:51:33 +02:00
|
|
|
all JOIN in UNION
|
|
|
|
*/
|
|
|
|
Item *expr;
|
2002-12-06 20:55:53 +01:00
|
|
|
bool was_null;
|
2003-05-14 20:51:33 +02:00
|
|
|
bool abort_on_null;
|
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
******
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
2011-11-12 10:29:12 +01:00
|
|
|
/* A bitmap of possible execution strategies for an IN predicate. */
|
|
|
|
uchar in_strategy;
|
2002-10-27 22:27:00 +01:00
|
|
|
public:
|
2011-03-29 12:33:59 +02:00
|
|
|
Item_in_optimizer *optimizer;
|
2011-05-25 17:31:13 +02:00
|
|
|
protected:
|
2006-10-31 18:51:09 +01:00
|
|
|
/* Used to trigger on/off conditions that were pushed down to subselect */
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
bool *pushed_cond_guards;
|
2010-09-05 17:43:47 +02:00
|
|
|
Comp_creator *func;
|
|
|
|
|
|
|
|
protected:
|
|
|
|
bool init_cond_guards();
|
2010-12-15 11:54:25 +01:00
|
|
|
bool select_in_like_transformer(JOIN *join);
|
|
|
|
bool single_value_transformer(JOIN *join);
|
|
|
|
bool row_value_transformer(JOIN * join);
|
2010-09-30 17:32:44 +02:00
|
|
|
bool fix_having(Item *having, st_select_lex *select_lex);
|
2010-12-15 11:54:25 +01:00
|
|
|
bool create_single_in_to_exists_cond(JOIN * join,
|
|
|
|
Item **where_item,
|
|
|
|
Item **having_item);
|
|
|
|
bool create_row_in_to_exists_cond(JOIN * join,
|
|
|
|
Item **where_item,
|
|
|
|
Item **having_item);
|
2010-09-05 17:43:47 +02:00
|
|
|
public:
|
|
|
|
Item *left_expr;
|
2010-01-17 15:51:10 +01:00
|
|
|
/* Priority of this predicate in the convert-to-semi-join-nest process. */
|
|
|
|
int sj_convert_priority;
|
|
|
|
/*
|
|
|
|
Used by subquery optimizations to keep track about in which clause this
|
|
|
|
subquery predicate is located:
|
2011-03-29 12:33:59 +02:00
|
|
|
NO_JOIN_NEST - the predicate is an AND-part of the WHERE
|
2010-01-17 15:51:10 +01:00
|
|
|
join nest pointer - the predicate is an AND-part of ON expression
|
|
|
|
of a join nest
|
|
|
|
NULL - for all other locations
|
|
|
|
*/
|
|
|
|
TABLE_LIST *emb_on_expr_nest;
|
|
|
|
/*
|
|
|
|
Types of left_expr and subquery's select list allow to perform subquery
|
|
|
|
materialization. Currently, we set this to FALSE when it as well could
|
|
|
|
be TRUE. This is to be properly addressed with fix for BUG#36752.
|
|
|
|
*/
|
|
|
|
bool types_allow_materialization;
|
|
|
|
|
|
|
|
/*
|
|
|
|
Same as above, but they also allow to scan the materialized table.
|
|
|
|
*/
|
|
|
|
bool sjm_scan_allowed;
|
2011-12-14 01:39:29 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
JoinTaB Materialization (JTBM) members
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
TRUE <=> This subselect has been converted into non-mergeable semi-join
|
|
|
|
table.
|
|
|
|
*/
|
|
|
|
bool is_jtbm_merged;
|
|
|
|
|
|
|
|
/* (Applicable if is_jtbm_merged==TRUE) Time required to run the materialized join */
|
2011-05-25 17:31:13 +02:00
|
|
|
double jtbm_read_time;
|
2011-12-14 01:39:29 +01:00
|
|
|
|
|
|
|
/* (Applicable if is_jtbm_merged==TRUE) Number of output rows in materialized join */
|
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
******
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
2011-11-12 10:29:12 +01:00
|
|
|
double jtbm_record_count;
|
2011-12-14 01:39:29 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
(Applicable if is_jtbm_merged==TRUE) TRUE <=> The materialized subselect is
|
|
|
|
a degenerate subselect which produces 0 or 1 rows, which we know at
|
|
|
|
optimization phase.
|
|
|
|
Examples:
|
|
|
|
1. subquery has "Impossible WHERE":
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
|
2011-12-14 01:39:29 +01:00
|
|
|
SELECT * FROM ot WHERE ot.column IN (SELECT it.col FROM it WHERE 2 > 3)
|
|
|
|
|
|
|
|
2. Subquery produces one row which opt_sum.cc is able to get with one lookup:
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
|
2011-12-14 01:39:29 +01:00
|
|
|
SELECT * FROM ot WHERE ot.column IN (SELECT MAX(it.key_col) FROM it)
|
|
|
|
*/
|
|
|
|
bool is_jtbm_const_tab;
|
|
|
|
|
|
|
|
/*
|
|
|
|
(Applicable if is_jtbm_const_tab==TRUE) Whether the subquery has produced
|
|
|
|
the row (or not)
|
|
|
|
*/
|
|
|
|
bool jtbm_const_row_found;
|
|
|
|
|
2010-04-25 10:23:52 +02:00
|
|
|
/*
|
2010-06-11 16:43:06 +02:00
|
|
|
TRUE<=>this is a flattenable semi-join, false overwise.
|
2010-04-25 10:23:52 +02:00
|
|
|
*/
|
2010-05-23 21:13:18 +02:00
|
|
|
bool is_flattenable_semijoin;
|
2011-04-05 10:20:03 +02:00
|
|
|
|
2011-07-17 08:57:43 +02:00
|
|
|
/*
|
|
|
|
TRUE<=>registered in the list of semijoins in outer select
|
|
|
|
*/
|
|
|
|
bool is_registered_semijoin;
|
2011-08-29 17:57:41 +02:00
|
|
|
|
2011-04-05 10:20:03 +02:00
|
|
|
/*
|
|
|
|
Used to determine how this subselect item is represented in the item tree,
|
|
|
|
in case there is a need to locate it there and replace with something else.
|
|
|
|
Two options are possible:
|
|
|
|
1. This item is there 'as-is'.
|
|
|
|
1. This item is wrapped within Item_in_optimizer.
|
|
|
|
*/
|
|
|
|
Item *original_item()
|
|
|
|
{
|
|
|
|
return is_flattenable_semijoin ? (Item*)this : (Item*)optimizer;
|
|
|
|
}
|
2010-04-25 10:23:52 +02:00
|
|
|
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
bool *get_cond_guard(int i)
|
|
|
|
{
|
|
|
|
return pushed_cond_guards ? pushed_cond_guards + i : NULL;
|
|
|
|
}
|
2007-04-18 02:35:29 +02:00
|
|
|
void set_cond_guard_var(int i, bool v)
|
|
|
|
{
|
|
|
|
if ( pushed_cond_guards)
|
|
|
|
pushed_cond_guards[i]= v;
|
|
|
|
}
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
bool have_guarded_conds() { return test(pushed_cond_guards); }
|
|
|
|
|
2004-11-18 17:10:07 +01:00
|
|
|
Item_func_not_all *upper_item; // point on NOT/NOP before ALL/SOME subquery
|
2003-07-24 14:26:21 +02:00
|
|
|
|
2003-10-02 21:19:41 +02:00
|
|
|
Item_in_subselect(Item * left_expr, st_select_lex *select_lex);
|
2003-08-23 12:29:38 +02:00
|
|
|
Item_in_subselect()
|
2010-01-28 14:48:33 +01:00
|
|
|
:Item_exists_subselect(), left_expr_cache(0), first_execution(TRUE),
|
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
******
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
2011-11-12 10:29:12 +01:00
|
|
|
abort_on_null(0), in_strategy(SUBS_NOT_TRANSFORMED), optimizer(0),
|
2011-08-29 17:57:41 +02:00
|
|
|
pushed_cond_guards(NULL), func(NULL), emb_on_expr_nest(NULL),
|
2011-12-07 16:21:51 +01:00
|
|
|
is_jtbm_merged(FALSE), is_jtbm_const_tab(FALSE),
|
2010-09-05 17:43:47 +02:00
|
|
|
upper_item(0)
|
|
|
|
{}
|
2010-01-28 14:48:33 +01:00
|
|
|
void cleanup();
|
2003-07-07 17:40:19 +02:00
|
|
|
subs_type substype() { return IN_SUBS; }
|
2002-12-06 20:55:53 +01:00
|
|
|
void reset()
|
|
|
|
{
|
2010-03-09 16:03:54 +01:00
|
|
|
eliminated= FALSE;
|
2002-12-06 20:55:53 +01:00
|
|
|
value= 0;
|
|
|
|
null_value= 0;
|
|
|
|
was_null= 0;
|
|
|
|
}
|
2010-12-15 11:54:25 +01:00
|
|
|
bool select_transformer(JOIN *join);
|
2010-09-30 17:32:44 +02:00
|
|
|
bool create_in_to_exists_cond(JOIN *join_arg);
|
|
|
|
bool inject_in_to_exists_cond(JOIN *join_arg);
|
2010-07-18 14:59:24 +02:00
|
|
|
|
2010-01-28 14:48:33 +01:00
|
|
|
virtual bool exec();
|
2002-12-06 20:55:53 +01:00
|
|
|
longlong val_int();
|
2004-11-11 19:39:35 +01:00
|
|
|
double val_real();
|
2002-12-06 20:55:53 +01:00
|
|
|
String *val_str(String*);
|
2005-04-01 01:14:30 +02:00
|
|
|
my_decimal *val_decimal(my_decimal *);
|
2007-10-30 13:27:21 +01:00
|
|
|
void update_null_value () { (void) val_bool(); }
|
2005-04-01 01:14:30 +02:00
|
|
|
bool val_bool();
|
2003-05-14 20:51:33 +02:00
|
|
|
void top_level_item() { abort_on_null=1; }
|
2006-10-31 18:51:09 +01:00
|
|
|
inline bool is_top_level_item() { return abort_on_null; }
|
2003-05-14 20:51:33 +02:00
|
|
|
bool test_limit(st_select_lex_unit *unit);
|
2008-02-22 11:30:33 +01:00
|
|
|
virtual void print(String *str, enum_query_type query_type);
|
2006-05-11 14:30:54 +02:00
|
|
|
bool fix_fields(THD *thd, Item **ref);
|
2011-05-04 17:08:58 +02:00
|
|
|
void fix_length_and_dec();
|
2010-02-12 00:59:58 +01:00
|
|
|
void fix_after_pullout(st_select_lex *new_parent, Item **ref);
|
|
|
|
void update_used_tables();
|
2010-09-05 17:43:47 +02:00
|
|
|
bool setup_mat_engine();
|
2010-01-28 14:48:33 +01:00
|
|
|
bool init_left_expr_cache();
|
2010-02-19 22:55:57 +01:00
|
|
|
/* Inform 'this' that it was computed, and contains a valid result. */
|
|
|
|
void set_first_execution() { if (first_execution) first_execution= FALSE; }
|
2010-07-10 12:37:30 +02:00
|
|
|
bool expr_cache_is_needed(THD *thd);
|
2010-03-29 16:04:35 +02:00
|
|
|
|
2011-05-25 17:31:13 +02:00
|
|
|
int optimize(double *out_rows, double *cost);
|
2010-03-29 16:04:35 +02:00
|
|
|
/*
|
|
|
|
Return the identifier that we could use to identify the subquery for the
|
|
|
|
user.
|
|
|
|
*/
|
|
|
|
int get_identifier();
|
2011-08-29 17:57:41 +02:00
|
|
|
|
|
|
|
void mark_as_condition_AND_part(TABLE_LIST *embedding)
|
|
|
|
{
|
|
|
|
emb_on_expr_nest= embedding;
|
|
|
|
}
|
|
|
|
|
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
******
Fix MySQL BUG#12329653
In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
the server produced in incorrect error message that there
is an aggregate function without GROUP BY, for artificially
created MIN/MAX functions during subquery MIN/MAX optimization.
The fix introduces a way to distinguish between artifially
created MIN/MAX functions as a result of a rewrite, and normal
ones present in the query. The test for ONLY_FULL_GROUP_BY violation
now tests in addition if a MIN/MAX function was part of a MIN/MAX
subquery rewrite.
In order to be able to distinguish these MIN/MAX functions, the
patch introduces an additional flag in Item_in_subselect::in_strategy -
SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
final choice of a subuqery strategy. In order to make the choice
consistent, access to Item_in_subselect::in_strategy is provided
via new class methods.
2011-11-12 10:29:12 +01:00
|
|
|
bool test_strategy(uchar strategy)
|
|
|
|
{ return test(in_strategy & strategy); }
|
|
|
|
|
|
|
|
/**
|
|
|
|
Test that the IN strategy was chosen for execution. This is so
|
|
|
|
when the CHOSEN flag is ON, and there is no other strategy.
|
|
|
|
*/
|
|
|
|
bool test_set_strategy(uchar strategy)
|
|
|
|
{
|
|
|
|
DBUG_ASSERT(strategy == SUBS_SEMI_JOIN ||
|
|
|
|
strategy == SUBS_IN_TO_EXISTS ||
|
|
|
|
strategy == SUBS_MATERIALIZATION ||
|
|
|
|
strategy == SUBS_PARTIAL_MATCH_ROWID_MERGE ||
|
|
|
|
strategy == SUBS_PARTIAL_MATCH_TABLE_SCAN ||
|
|
|
|
strategy == SUBS_MAXMIN_INJECTED ||
|
|
|
|
strategy == SUBS_MAXMIN_ENGINE);
|
|
|
|
return ((in_strategy & SUBS_STRATEGY_CHOSEN) &&
|
|
|
|
(in_strategy & ~SUBS_STRATEGY_CHOSEN) == strategy);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool is_set_strategy()
|
|
|
|
{ return test(in_strategy & SUBS_STRATEGY_CHOSEN); }
|
|
|
|
|
|
|
|
bool has_strategy()
|
|
|
|
{ return in_strategy != SUBS_NOT_TRANSFORMED; }
|
|
|
|
|
|
|
|
void add_strategy (uchar strategy)
|
|
|
|
{
|
|
|
|
DBUG_ASSERT(strategy != SUBS_NOT_TRANSFORMED);
|
|
|
|
DBUG_ASSERT(!(strategy & SUBS_STRATEGY_CHOSEN));
|
|
|
|
/*
|
|
|
|
TODO: PS re-execution breaks this condition, because
|
|
|
|
check_and_do_in_subquery_rewrites() is called for each reexecution
|
|
|
|
and re-adds the same strategies.
|
|
|
|
DBUG_ASSERT(!(in_strategy & SUBS_STRATEGY_CHOSEN));
|
|
|
|
*/
|
|
|
|
in_strategy|= strategy;
|
|
|
|
}
|
|
|
|
|
|
|
|
void reset_strategy(uchar strategy)
|
|
|
|
{
|
|
|
|
DBUG_ASSERT(strategy != SUBS_NOT_TRANSFORMED);
|
|
|
|
in_strategy= strategy;
|
|
|
|
}
|
|
|
|
|
|
|
|
void set_strategy(uchar strategy)
|
|
|
|
{
|
|
|
|
/* Check that only one strategy is set for execution. */
|
|
|
|
DBUG_ASSERT(strategy == SUBS_SEMI_JOIN ||
|
|
|
|
strategy == SUBS_IN_TO_EXISTS ||
|
|
|
|
strategy == SUBS_MATERIALIZATION ||
|
|
|
|
strategy == SUBS_PARTIAL_MATCH_ROWID_MERGE ||
|
|
|
|
strategy == SUBS_PARTIAL_MATCH_TABLE_SCAN ||
|
|
|
|
strategy == SUBS_MAXMIN_INJECTED ||
|
|
|
|
strategy == SUBS_MAXMIN_ENGINE);
|
|
|
|
in_strategy= (SUBS_STRATEGY_CHOSEN | strategy);
|
|
|
|
}
|
|
|
|
|
2002-12-06 20:55:53 +01:00
|
|
|
friend class Item_ref_null_helper;
|
2003-04-22 23:01:19 +02:00
|
|
|
friend class Item_is_not_null_test;
|
2010-01-28 14:48:33 +01:00
|
|
|
friend class Item_in_optimizer;
|
2003-09-14 08:40:57 +02:00
|
|
|
friend class subselect_indexsubquery_engine;
|
2010-01-28 14:48:33 +01:00
|
|
|
friend class subselect_hash_sj_engine;
|
2010-03-09 11:14:06 +01:00
|
|
|
friend class subselect_partial_match_engine;
|
2002-11-07 22:45:19 +01:00
|
|
|
};
|
|
|
|
|
2003-09-29 11:39:38 +02:00
|
|
|
|
2002-11-07 22:45:19 +01:00
|
|
|
/* ALL/ANY/SOME subselect */
|
|
|
|
class Item_allany_subselect :public Item_in_subselect
|
|
|
|
{
|
|
|
|
public:
|
2006-07-21 01:04:04 +02:00
|
|
|
chooser_compare_func_creator func_creator;
|
2003-10-16 14:54:47 +02:00
|
|
|
bool all;
|
|
|
|
|
2006-07-21 01:04:04 +02:00
|
|
|
Item_allany_subselect(Item * left_expr, chooser_compare_func_creator fc,
|
|
|
|
st_select_lex *select_lex, bool all);
|
2003-09-20 17:31:56 +02:00
|
|
|
|
2011-07-18 22:45:38 +02:00
|
|
|
void cleanup();
|
2003-07-24 14:26:21 +02:00
|
|
|
// only ALL subquery has upper not
|
2004-11-18 17:10:07 +01:00
|
|
|
subs_type substype() { return all?ALL_SUBS:ANY_SUBS; }
|
2010-12-15 11:54:25 +01:00
|
|
|
bool select_transformer(JOIN *join);
|
2010-09-05 17:43:47 +02:00
|
|
|
void create_comp_func(bool invert) { func= func_creator(invert); }
|
2008-02-22 11:30:33 +01:00
|
|
|
virtual void print(String *str, enum_query_type query_type);
|
2011-05-04 17:08:58 +02:00
|
|
|
bool is_maxmin_applicable(JOIN *join);
|
2011-05-11 23:14:15 +02:00
|
|
|
bool transform_into_max_min(JOIN *join);
|
Fix bug lp:985667, MDEV-229
Analysis:
The reason for the wrong result is the interaction between constant
optimization (in this case 1-row table) and subquery optimization.
- First the outer query is optimized, and 'make_join_statistics' finds that
table t2 has one row, reads that row, and marks the whole table as constant.
This also means that all fields of t2 are constant.
- Next, we optimize the subquery in the end of the outer 'make_join_statistics'.
The field 'f2' is considered constant, with value '3'. The subquery predicate
is rewritten as the constant TRUE.
- The outer query execution detects early that the whole query result is empty
and calls 'return_zero_rows'. Since the query is with implicit grouping, we
have to produce one row with special values for the aggregates (depending on
each aggregate function), and NULL values for all non-aggregate fields. This
function calls 'no_rows_in_result' to set each aggregate function to the
default value when it aggregates over an empty result, and then calls
'send_data', which in turn evaluates each Item in the SELECT list.
- When evaluation reaches the subquery predicate, it executes the subquery
with field 'f2' having a constant value '3', and the subquery produces the
incorrect result '7'.
Solution:
Implement Item::no_rows_in_result for all subquery predicates. In order to
make this work, it is also needed to make all val_* methods of all subquery
predicates respect the Item_subselect::forced_const flag. Otherwise subqueries
are executed anyways, and override the default value set by no_rows_in_result
with whatever result is produced from the subquery evaluation.
2012-04-27 11:59:17 +02:00
|
|
|
void no_rows_in_result();
|
2002-10-27 22:27:00 +01:00
|
|
|
};
|
|
|
|
|
2003-09-29 11:39:38 +02:00
|
|
|
|
2002-12-27 20:19:25 +01:00
|
|
|
class subselect_engine: public Sql_alloc
|
2002-09-03 08:50:36 +02:00
|
|
|
{
|
|
|
|
protected:
|
2010-01-28 14:48:33 +01:00
|
|
|
select_result_interceptor *result; /* results storage class */
|
2002-09-03 08:50:36 +02:00
|
|
|
THD *thd; /* pointer to current THD */
|
|
|
|
Item_subselect *item; /* item, that use this engine */
|
2002-09-28 17:34:56 +02:00
|
|
|
enum Item_result res_type; /* type of results */
|
2006-11-07 17:16:17 +01:00
|
|
|
enum_field_types res_field_type; /* column type of the results */
|
2002-12-27 20:19:25 +01:00
|
|
|
bool maybe_null; /* may be null (first item in select) */
|
2002-09-03 08:50:36 +02:00
|
|
|
public:
|
|
|
|
|
2010-01-28 14:48:33 +01:00
|
|
|
enum enum_engine_type {ABSTRACT_ENGINE, SINGLE_SELECT_ENGINE,
|
|
|
|
UNION_ENGINE, UNIQUESUBQUERY_ENGINE,
|
2010-02-19 22:55:57 +01:00
|
|
|
INDEXSUBQUERY_ENGINE, HASH_SJ_ENGINE,
|
2010-03-09 11:14:06 +01:00
|
|
|
ROWID_MERGE_ENGINE, TABLE_SCAN_ENGINE};
|
2010-01-28 14:48:33 +01:00
|
|
|
|
2010-12-14 13:08:05 +01:00
|
|
|
subselect_engine(THD *thd_arg, Item_subselect *si,
|
|
|
|
select_result_interceptor *res)
|
2002-09-03 08:50:36 +02:00
|
|
|
{
|
|
|
|
result= res;
|
|
|
|
item= si;
|
2002-09-28 17:34:56 +02:00
|
|
|
res_type= STRING_RESULT;
|
2006-12-02 02:26:52 +01:00
|
|
|
res_field_type= MYSQL_TYPE_VAR_STRING;
|
2002-12-27 20:19:25 +01:00
|
|
|
maybe_null= 0;
|
2010-12-14 13:08:05 +01:00
|
|
|
set_thd(thd_arg);
|
2002-09-03 08:50:36 +02:00
|
|
|
}
|
2002-12-27 20:19:25 +01:00
|
|
|
virtual ~subselect_engine() {}; // to satisfy compiler
|
2004-02-08 19:14:13 +01:00
|
|
|
virtual void cleanup()= 0;
|
2004-07-04 07:46:28 +02:00
|
|
|
|
2005-08-09 22:23:56 +02:00
|
|
|
/*
|
|
|
|
Also sets "thd" for subselect_engine::result.
|
|
|
|
Should be called before prepare().
|
|
|
|
*/
|
|
|
|
void set_thd(THD *thd_arg);
|
2003-10-02 21:19:41 +02:00
|
|
|
THD * get_thd() { return thd; }
|
2002-09-03 08:50:36 +02:00
|
|
|
virtual int prepare()= 0;
|
2002-12-19 06:38:33 +01:00
|
|
|
virtual void fix_length_and_dec(Item_cache** row)= 0;
|
2006-10-31 18:51:09 +01:00
|
|
|
/*
|
|
|
|
Execute the engine
|
|
|
|
|
|
|
|
SYNOPSIS
|
|
|
|
exec()
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
|
2006-10-31 18:51:09 +01:00
|
|
|
DESCRIPTION
|
|
|
|
Execute the engine. The result of execution is subquery value that is
|
|
|
|
either captured by previously set up select_result-based 'sink' or
|
|
|
|
stored somewhere by the exec() method itself.
|
|
|
|
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
A required side effect: If at least one pushed-down predicate is
|
|
|
|
disabled, subselect_engine->no_rows() must return correct result after
|
|
|
|
the exec() call.
|
2006-10-31 18:51:09 +01:00
|
|
|
|
|
|
|
RETURN
|
|
|
|
0 - OK
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
1 - Either an execution error, or the engine was "changed", and the
|
2006-10-31 18:51:09 +01:00
|
|
|
caller should call exec() again for the new engine.
|
|
|
|
*/
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
virtual int exec()= 0;
|
2005-02-08 23:50:45 +01:00
|
|
|
virtual uint cols()= 0; /* return number of columns in select */
|
2003-11-17 19:53:40 +01:00
|
|
|
virtual uint8 uncacheable()= 0; /* query is uncacheable */
|
2002-09-28 17:34:56 +02:00
|
|
|
enum Item_result type() { return res_type; }
|
2006-11-07 17:16:17 +01:00
|
|
|
enum_field_types field_type() { return res_field_type; }
|
2002-11-28 18:29:26 +01:00
|
|
|
virtual void exclude()= 0;
|
2006-12-12 03:57:23 +01:00
|
|
|
virtual bool may_be_null() { return maybe_null; };
|
2003-10-16 23:36:01 +02:00
|
|
|
virtual table_map upper_select_const_tables()= 0;
|
|
|
|
static table_map calc_const_tables(TABLE_LIST *);
|
2010-05-26 22:18:18 +02:00
|
|
|
static table_map calc_const_tables(List<TABLE_LIST> &list);
|
2008-02-22 11:30:33 +01:00
|
|
|
virtual void print(String *str, enum_query_type query_type)= 0;
|
2010-01-28 14:48:33 +01:00
|
|
|
virtual bool change_result(Item_subselect *si,
|
2011-05-04 17:08:58 +02:00
|
|
|
select_result_interceptor *result,
|
|
|
|
bool temp= FALSE)= 0;
|
2004-10-27 20:11:06 +02:00
|
|
|
virtual bool no_tables()= 0;
|
2005-10-13 09:53:00 +02:00
|
|
|
virtual bool is_executed() const { return FALSE; }
|
2006-10-31 18:51:09 +01:00
|
|
|
/* Check if subquery produced any rows during last query execution */
|
|
|
|
virtual bool no_rows() = 0;
|
2010-01-28 14:48:33 +01:00
|
|
|
virtual enum_engine_type engine_type() { return ABSTRACT_ENGINE; }
|
2010-03-29 16:04:35 +02:00
|
|
|
virtual int get_identifier() { DBUG_ASSERT(0); return 0; }
|
2006-11-07 17:16:17 +01:00
|
|
|
protected:
|
|
|
|
void set_row(List<Item> &item_list, Item_cache **row);
|
2002-09-03 08:50:36 +02:00
|
|
|
};
|
|
|
|
|
2003-09-29 11:39:38 +02:00
|
|
|
|
2002-09-03 08:50:36 +02:00
|
|
|
class subselect_single_select_engine: public subselect_engine
|
|
|
|
{
|
2011-11-24 17:48:58 +01:00
|
|
|
bool prepared; /* simple subselect is prepared */
|
|
|
|
bool executed; /* simple subselect is executed */
|
|
|
|
bool optimize_error; /* simple subselect optimization failed */
|
2002-09-03 08:50:36 +02:00
|
|
|
st_select_lex *select_lex; /* corresponding select_lex */
|
|
|
|
JOIN * join; /* corresponding JOIN structure */
|
|
|
|
public:
|
2010-12-14 13:08:05 +01:00
|
|
|
subselect_single_select_engine(THD *thd_arg, st_select_lex *select,
|
2010-01-28 14:48:33 +01:00
|
|
|
select_result_interceptor *result,
|
2002-09-03 08:50:36 +02:00
|
|
|
Item_subselect *item);
|
2003-12-30 11:08:19 +01:00
|
|
|
void cleanup();
|
2002-11-13 23:26:18 +01:00
|
|
|
int prepare();
|
2002-12-19 06:38:33 +01:00
|
|
|
void fix_length_and_dec(Item_cache** row);
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
int exec();
|
2002-11-13 23:26:18 +01:00
|
|
|
uint cols();
|
2003-11-17 19:53:40 +01:00
|
|
|
uint8 uncacheable();
|
2002-11-28 18:29:26 +01:00
|
|
|
void exclude();
|
2003-10-16 23:36:01 +02:00
|
|
|
table_map upper_select_const_tables();
|
2008-02-22 11:30:33 +01:00
|
|
|
virtual void print (String *str, enum_query_type query_type);
|
2011-05-04 17:08:58 +02:00
|
|
|
bool change_result(Item_subselect *si,
|
|
|
|
select_result_interceptor *result,
|
|
|
|
bool temp);
|
2004-10-27 20:11:06 +02:00
|
|
|
bool no_tables();
|
2006-12-12 03:57:23 +01:00
|
|
|
bool may_be_null();
|
2005-10-13 09:53:00 +02:00
|
|
|
bool is_executed() const { return executed; }
|
2006-10-31 18:51:09 +01:00
|
|
|
bool no_rows();
|
2010-01-28 14:48:33 +01:00
|
|
|
virtual enum_engine_type engine_type() { return SINGLE_SELECT_ENGINE; }
|
2010-03-29 16:04:35 +02:00
|
|
|
int get_identifier();
|
2010-01-28 14:48:33 +01:00
|
|
|
|
|
|
|
friend class subselect_hash_sj_engine;
|
|
|
|
friend class Item_in_subselect;
|
2011-12-14 01:39:29 +01:00
|
|
|
friend bool setup_jtbm_semi_joins(JOIN *join, List<TABLE_LIST> *join_list,
|
|
|
|
Item **join_where);
|
|
|
|
|
2002-09-03 08:50:36 +02:00
|
|
|
};
|
|
|
|
|
2003-09-29 11:39:38 +02:00
|
|
|
|
2002-09-03 08:50:36 +02:00
|
|
|
class subselect_union_engine: public subselect_engine
|
|
|
|
{
|
|
|
|
st_select_lex_unit *unit; /* corresponding unit structure */
|
|
|
|
public:
|
2010-12-14 13:08:05 +01:00
|
|
|
subselect_union_engine(THD *thd_arg, st_select_lex_unit *u,
|
2010-01-28 14:48:33 +01:00
|
|
|
select_result_interceptor *result,
|
2002-09-03 08:50:36 +02:00
|
|
|
Item_subselect *item);
|
2004-02-08 19:14:13 +01:00
|
|
|
void cleanup();
|
2002-11-13 23:26:18 +01:00
|
|
|
int prepare();
|
2002-12-19 06:38:33 +01:00
|
|
|
void fix_length_and_dec(Item_cache** row);
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
int exec();
|
2002-11-13 23:26:18 +01:00
|
|
|
uint cols();
|
2003-11-17 19:53:40 +01:00
|
|
|
uint8 uncacheable();
|
2002-11-28 18:29:26 +01:00
|
|
|
void exclude();
|
2003-10-16 23:36:01 +02:00
|
|
|
table_map upper_select_const_tables();
|
2008-02-22 11:30:33 +01:00
|
|
|
virtual void print (String *str, enum_query_type query_type);
|
2011-05-04 17:08:58 +02:00
|
|
|
bool change_result(Item_subselect *si,
|
|
|
|
select_result_interceptor *result,
|
|
|
|
bool temp= FALSE);
|
2004-10-27 20:11:06 +02:00
|
|
|
bool no_tables();
|
2005-10-13 09:53:00 +02:00
|
|
|
bool is_executed() const;
|
2006-10-31 18:51:09 +01:00
|
|
|
bool no_rows();
|
2010-01-28 14:48:33 +01:00
|
|
|
virtual enum_engine_type engine_type() { return UNION_ENGINE; }
|
2002-09-03 08:50:36 +02:00
|
|
|
};
|
2003-07-07 17:40:19 +02:00
|
|
|
|
2003-09-29 11:39:38 +02:00
|
|
|
|
2003-07-07 17:40:19 +02:00
|
|
|
struct st_join_table;
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
A subquery execution engine that evaluates the subquery by doing one index
|
|
|
|
lookup in a unique index.
|
|
|
|
|
|
|
|
This engine is used to resolve subqueries in forms
|
|
|
|
|
|
|
|
outer_expr IN (SELECT tbl.unique_key FROM tbl WHERE subq_where)
|
|
|
|
|
|
|
|
or, tuple-based:
|
|
|
|
|
|
|
|
(oe1, .. oeN) IN (SELECT uniq_key_part1, ... uniq_key_partK
|
|
|
|
FROM tbl WHERE subqwhere)
|
|
|
|
|
|
|
|
i.e. the subquery is a single table SELECT without GROUP BY, aggregate
|
|
|
|
functions, etc.
|
|
|
|
*/
|
|
|
|
|
2003-09-14 08:40:57 +02:00
|
|
|
class subselect_uniquesubquery_engine: public subselect_engine
|
2003-07-07 17:40:19 +02:00
|
|
|
{
|
2003-07-07 23:08:00 +02:00
|
|
|
protected:
|
2003-07-07 17:40:19 +02:00
|
|
|
st_join_table *tab;
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
Item *cond; /* The WHERE condition of subselect */
|
2006-10-31 18:51:09 +01:00
|
|
|
/*
|
|
|
|
TRUE<=> last execution produced empty set. Valid only when left
|
|
|
|
expression is NULL.
|
|
|
|
*/
|
|
|
|
bool empty_result_set;
|
|
|
|
bool null_keypart; /* TRUE <=> constructed search tuple has a NULL */
|
2003-07-07 17:40:19 +02:00
|
|
|
public:
|
|
|
|
|
2003-10-02 21:19:41 +02:00
|
|
|
// constructor can assign THD because it will be called after JOIN::prepare
|
2003-11-28 11:18:13 +01:00
|
|
|
subselect_uniquesubquery_engine(THD *thd_arg, st_join_table *tab_arg,
|
2003-09-14 08:40:57 +02:00
|
|
|
Item_subselect *subs, Item *where)
|
2010-12-14 13:08:05 +01:00
|
|
|
:subselect_engine(thd_arg, subs, 0), tab(tab_arg), cond(where)
|
|
|
|
{}
|
2003-09-29 11:39:38 +02:00
|
|
|
~subselect_uniquesubquery_engine();
|
2004-02-08 19:14:13 +01:00
|
|
|
void cleanup();
|
2003-07-07 17:40:19 +02:00
|
|
|
int prepare();
|
|
|
|
void fix_length_and_dec(Item_cache** row);
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
int exec();
|
2003-07-07 17:40:19 +02:00
|
|
|
uint cols() { return 1; }
|
2011-05-04 17:08:58 +02:00
|
|
|
uint8 uncacheable() { return UNCACHEABLE_DEPENDENT_INJECTED; }
|
2003-09-29 11:39:38 +02:00
|
|
|
void exclude();
|
2003-10-16 23:36:01 +02:00
|
|
|
table_map upper_select_const_tables() { return 0; }
|
2008-02-22 11:30:33 +01:00
|
|
|
virtual void print (String *str, enum_query_type query_type);
|
2011-05-04 17:08:58 +02:00
|
|
|
bool change_result(Item_subselect *si,
|
|
|
|
select_result_interceptor *result,
|
|
|
|
bool temp= FALSE);
|
2004-10-27 20:11:06 +02:00
|
|
|
bool no_tables();
|
2010-02-19 22:55:57 +01:00
|
|
|
int index_lookup(); /* TIMOUR: this method needs refactoring. */
|
2006-10-31 18:51:09 +01:00
|
|
|
int scan_table();
|
|
|
|
bool copy_ref_key();
|
2010-02-19 22:55:57 +01:00
|
|
|
int copy_ref_key_simple(); /* TIMOUR: this method needs refactoring. */
|
2006-10-31 18:51:09 +01:00
|
|
|
bool no_rows() { return empty_result_set; }
|
2010-01-28 14:48:33 +01:00
|
|
|
virtual enum_engine_type engine_type() { return UNIQUESUBQUERY_ENGINE; }
|
2003-07-07 23:08:00 +02:00
|
|
|
};
|
|
|
|
|
2003-09-29 11:39:38 +02:00
|
|
|
|
2003-09-14 08:40:57 +02:00
|
|
|
class subselect_indexsubquery_engine: public subselect_uniquesubquery_engine
|
2003-07-07 23:08:00 +02:00
|
|
|
{
|
2006-10-31 18:51:09 +01:00
|
|
|
/* FALSE for 'ref', TRUE for 'ref-or-null'. */
|
2003-07-17 18:39:31 +02:00
|
|
|
bool check_null;
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
/*
|
|
|
|
The "having" clause. This clause (further reffered to as "artificial
|
|
|
|
having") was inserted by subquery transformation code. It contains
|
|
|
|
Item(s) that have a side-effect: they record whether the subquery has
|
|
|
|
produced a row with NULL certain components. We need to use it for cases
|
|
|
|
like
|
|
|
|
(oe1, oe2) IN (SELECT t.key, t.no_key FROM t1)
|
|
|
|
where we do index lookup on t.key=oe1 but need also to check if there
|
|
|
|
was a row such that t.no_key IS NULL.
|
|
|
|
|
|
|
|
NOTE: This is currently here and not in the uniquesubquery_engine. Ideally
|
|
|
|
it should have been in uniquesubquery_engine in order to allow execution of
|
|
|
|
subqueries like
|
|
|
|
|
|
|
|
(oe1, oe2) IN (SELECT primary_key, non_key_maybe_null_field FROM tbl)
|
|
|
|
|
|
|
|
We could use uniquesubquery_engine for the first component and let
|
|
|
|
Item_is_not_null_test( non_key_maybe_null_field) to handle the second.
|
|
|
|
|
|
|
|
However, subqueries like the above are currently not handled by index
|
|
|
|
lookup-based subquery engines, the engine applicability check misses
|
|
|
|
them: it doesn't switch the engine for case of artificial having and
|
|
|
|
[eq_]ref access (only for artifical having + ref_or_null or no having).
|
|
|
|
The above example subquery is handled as a full-blown SELECT with eq_ref
|
|
|
|
access to one table.
|
|
|
|
|
|
|
|
Due to this limitation, the "artificial having" currently needs to be
|
|
|
|
checked by only in indexsubquery_engine.
|
|
|
|
*/
|
|
|
|
Item *having;
|
2003-07-07 23:08:00 +02:00
|
|
|
public:
|
2003-10-02 21:19:41 +02:00
|
|
|
|
|
|
|
// constructor can assign THD because it will be called after JOIN::prepare
|
2006-12-14 23:51:37 +01:00
|
|
|
subselect_indexsubquery_engine(THD *thd_arg, st_join_table *tab_arg,
|
2003-09-14 08:40:57 +02:00
|
|
|
Item_subselect *subs, Item *where,
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
Item *having_arg, bool chk_null)
|
2006-12-14 23:51:37 +01:00
|
|
|
:subselect_uniquesubquery_engine(thd_arg, tab_arg, subs, where),
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
check_null(chk_null),
|
|
|
|
having(having_arg)
|
2003-07-07 23:08:00 +02:00
|
|
|
{}
|
BUG#24127: (a,b) IN (SELECT c,d ...) can produce wrong results if a and/or b are NULLs:
- Make the code produce correct result: use an array of triggers to turn on/off equalities for each
compared column. Also turn on/off optimizations based on those equalities.
- Make EXPLAIN output show "Full scan on NULL key" for tables for which we switch between
ref/unique_subquery/index_subquery and ALL access.
- index_subquery engine now has HAVING clause when it is needed, and it is
displayed in EXPLAIN EXTENDED
- Fix incorrect presense of "Using index" for index/unique-based subqueries (BUG#22930)
// bk trigger note: this commit refers to BUG#24127
mysql-test/r/ndb_subquery.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect2.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Updated test results (checked)
mysql-test/r/subselect3.result:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
mysql-test/t/subselect3.test:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Testcases
sql/item_cmpfunc.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- For row-based IN subqueries, use one flag per each column. Set the flags appropriately before
running the subquery.
sql/item_cmpfunc.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added Item_func_trig_cond::get_triv_var()
sql/item_subselect.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/item_subselect.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Item_subselect::exec() and subselect_*_engine::exec() don't have parameter
anymore - now Item_subselect owns the pushed down predicates guard flags.
- A correct set of conditional predicates is now pushed into row-based IN
subquery.
- select_indexsubquery_engine now has "HAVING clause" (needed for correct query
results), and it is shown in EXPLAIN EXTENDED
sql/mysql_priv.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/mysqld.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Added "in_having_cond" special Item name
sql/sql_lex.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
sql/sql_select.cc:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix subquery optimization code to match the changes in what kinds of
conditions are pushed down into subqueries
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
sql/sql_select.h:
BUG#24127: wrong result for (null,not-null) IN (SELECT a,b ...)
- Make "ref" analyzer be able to work with conditional equalities
- Fix wrong EXPLAIN output in some queries with subquery (BUG#22390)
2007-01-12 21:22:41 +01:00
|
|
|
int exec();
|
2008-02-22 11:30:33 +01:00
|
|
|
virtual void print (String *str, enum_query_type query_type);
|
2010-01-28 14:48:33 +01:00
|
|
|
virtual enum_engine_type engine_type() { return INDEXSUBQUERY_ENGINE; }
|
2003-07-07 17:40:19 +02:00
|
|
|
};
|
2005-10-13 09:53:00 +02:00
|
|
|
|
2010-03-31 16:05:33 +02:00
|
|
|
/*
|
|
|
|
This function is actually defined in sql_parse.cc, but it depends on
|
|
|
|
chooser_compare_func_creator defined in this file.
|
|
|
|
*/
|
|
|
|
Item * all_any_subquery_creator(Item *left_expr,
|
|
|
|
chooser_compare_func_creator cmp,
|
|
|
|
bool all,
|
|
|
|
SELECT_LEX *select_lex);
|
|
|
|
|
2005-10-13 09:53:00 +02:00
|
|
|
|
|
|
|
inline bool Item_subselect::is_evaluated() const
|
|
|
|
{
|
|
|
|
return engine->is_executed();
|
|
|
|
}
|
|
|
|
|
2010-01-28 14:48:33 +01:00
|
|
|
|
2006-11-01 02:31:56 +01:00
|
|
|
inline bool Item_subselect::is_uncacheable() const
|
|
|
|
{
|
|
|
|
return engine->uncacheable();
|
|
|
|
}
|
|
|
|
|
2010-03-09 11:14:06 +01:00
|
|
|
/**
|
|
|
|
Compute an IN predicate via a hash semi-join. This class is responsible for
|
|
|
|
the materialization of the subquery, and the selection of the correct and
|
|
|
|
optimal execution method (e.g. direct index lookup, or partial matching) for
|
|
|
|
the IN predicate.
|
|
|
|
*/
|
|
|
|
|
|
|
|
class subselect_hash_sj_engine : public subselect_engine
|
|
|
|
{
|
2010-04-05 22:16:45 +02:00
|
|
|
public:
|
2010-03-09 11:14:06 +01:00
|
|
|
/* The table into which the subquery is materialized. */
|
|
|
|
TABLE *tmp_table;
|
|
|
|
/* TRUE if the subquery was materialized into a temp table. */
|
|
|
|
bool is_materialized;
|
|
|
|
/*
|
|
|
|
The old engine already chosen at parse time and stored in permanent memory.
|
|
|
|
Through this member we can re-create and re-prepare materialize_join for
|
|
|
|
each execution of a prepared statement. We also reuse the functionality
|
|
|
|
of subselect_single_select_engine::[prepare | cols].
|
|
|
|
*/
|
|
|
|
subselect_single_select_engine *materialize_engine;
|
|
|
|
/*
|
|
|
|
QEP to execute the subquery and materialize its result into a
|
|
|
|
temporary table. Created during the first call to exec().
|
|
|
|
*/
|
|
|
|
JOIN *materialize_join;
|
|
|
|
/*
|
|
|
|
A conjunction of all the equality condtions between all pairs of expressions
|
|
|
|
that are arguments of an IN predicate. We need these to post-filter some
|
|
|
|
IN results because index lookups sometimes match values that are actually
|
|
|
|
not equal to the search key in SQL terms.
|
2011-03-22 11:09:55 +01:00
|
|
|
*/
|
2010-03-09 11:14:06 +01:00
|
|
|
Item_cond_and *semi_join_conds;
|
2011-05-28 18:34:04 +02:00
|
|
|
Name_resolution_context *semi_join_conds_context;
|
|
|
|
|
2010-03-09 11:14:06 +01:00
|
|
|
|
|
|
|
subselect_hash_sj_engine(THD *thd, Item_subselect *in_predicate,
|
|
|
|
subselect_single_select_engine *old_engine)
|
2011-03-22 11:09:55 +01:00
|
|
|
: subselect_engine(thd, in_predicate, NULL),
|
|
|
|
tmp_table(NULL), is_materialized(FALSE), materialize_engine(old_engine),
|
|
|
|
materialize_join(NULL), semi_join_conds(NULL), lookup_engine(NULL),
|
|
|
|
count_partial_match_columns(0), count_null_only_columns(0),
|
2011-08-22 23:00:13 +02:00
|
|
|
count_columns_with_nulls(0), strategy(UNDEFINED)
|
2010-12-14 13:08:05 +01:00
|
|
|
{}
|
2010-03-09 11:14:06 +01:00
|
|
|
~subselect_hash_sj_engine();
|
|
|
|
|
2011-05-25 17:31:13 +02:00
|
|
|
bool init(List<Item> *tmp_columns, uint subquery_id);
|
2010-03-09 11:14:06 +01:00
|
|
|
void cleanup();
|
2010-07-16 12:52:02 +02:00
|
|
|
int prepare();
|
2010-03-09 11:14:06 +01:00
|
|
|
int exec();
|
|
|
|
virtual void print(String *str, enum_query_type query_type);
|
|
|
|
uint cols()
|
|
|
|
{
|
|
|
|
return materialize_engine->cols();
|
|
|
|
}
|
2010-07-10 12:37:30 +02:00
|
|
|
uint8 uncacheable() { return materialize_engine->uncacheable(); }
|
2010-03-09 11:14:06 +01:00
|
|
|
table_map upper_select_const_tables() { return 0; }
|
|
|
|
bool no_rows() { return !tmp_table->file->stats.records; }
|
|
|
|
virtual enum_engine_type engine_type() { return HASH_SJ_ENGINE; }
|
|
|
|
/*
|
|
|
|
TODO: factor out all these methods in a base subselect_index_engine class
|
|
|
|
because all of them have dummy implementations and should never be called.
|
|
|
|
*/
|
|
|
|
void fix_length_and_dec(Item_cache** row);//=>base class
|
|
|
|
void exclude(); //=>base class
|
|
|
|
//=>base class
|
2011-05-04 17:08:58 +02:00
|
|
|
bool change_result(Item_subselect *si,
|
|
|
|
select_result_interceptor *result,
|
|
|
|
bool temp= FALSE);
|
2010-03-09 11:14:06 +01:00
|
|
|
bool no_tables();//=>base class
|
2011-03-22 11:09:55 +01:00
|
|
|
|
|
|
|
protected:
|
|
|
|
/* The engine used to compute the IN predicate. */
|
|
|
|
subselect_engine *lookup_engine;
|
|
|
|
/* Keyparts of the only non-NULL composite index in a rowid merge. */
|
|
|
|
MY_BITMAP non_null_key_parts;
|
|
|
|
/* Keyparts of the single column indexes with NULL, one keypart per index. */
|
|
|
|
MY_BITMAP partial_match_key_parts;
|
|
|
|
uint count_partial_match_columns;
|
|
|
|
uint count_null_only_columns;
|
2011-08-22 23:00:13 +02:00
|
|
|
uint count_columns_with_nulls;
|
2011-03-22 11:09:55 +01:00
|
|
|
/* Possible execution strategies that can be used to compute hash semi-join.*/
|
|
|
|
enum exec_strategy {
|
|
|
|
UNDEFINED,
|
|
|
|
COMPLETE_MATCH, /* Use regular index lookups. */
|
|
|
|
PARTIAL_MATCH, /* Use some partial matching strategy. */
|
|
|
|
PARTIAL_MATCH_MERGE, /* Use partial matching through index merging. */
|
|
|
|
PARTIAL_MATCH_SCAN, /* Use partial matching through table scan. */
|
|
|
|
IMPOSSIBLE /* Subquery materialization is not applicable. */
|
|
|
|
};
|
|
|
|
/* The chosen execution strategy. Computed after materialization. */
|
|
|
|
exec_strategy strategy;
|
|
|
|
exec_strategy get_strategy_using_schema();
|
|
|
|
exec_strategy get_strategy_using_data();
|
|
|
|
ulonglong rowid_merge_buff_size(bool has_non_null_key,
|
|
|
|
bool has_covering_null_row,
|
|
|
|
MY_BITMAP *partial_match_key_parts);
|
|
|
|
void choose_partial_match_strategy(bool has_non_null_key,
|
|
|
|
bool has_covering_null_row,
|
|
|
|
MY_BITMAP *partial_match_key_parts);
|
|
|
|
bool make_semi_join_conds();
|
|
|
|
subselect_uniquesubquery_engine* make_unique_engine();
|
|
|
|
|
2010-03-09 11:14:06 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
|
2010-02-19 22:55:57 +01:00
|
|
|
/*
|
2011-11-17 00:25:10 +01:00
|
|
|
Distinguish the type of (0-based) row numbers from the type of the index into
|
2010-02-19 22:55:57 +01:00
|
|
|
an array of row numbers.
|
|
|
|
*/
|
|
|
|
typedef ha_rows rownum_t;
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
An Ordered_key is an in-memory table index that allows O(log(N)) time
|
|
|
|
lookups of a multi-part key.
|
|
|
|
|
|
|
|
If the index is over a single column, then this column may contain NULLs, and
|
|
|
|
the NULLs are stored and tested separately for NULL in O(1) via is_null().
|
|
|
|
Multi-part indexes assume that the indexed columns do not contain NULLs.
|
|
|
|
|
|
|
|
TODO:
|
|
|
|
= Due to the unnatural assymetry between single and multi-part indexes, it
|
|
|
|
makes sense to somehow refactor or extend the class.
|
|
|
|
|
|
|
|
= This class can be refactored into a base abstract interface, and two
|
|
|
|
subclasses:
|
|
|
|
- one to represent single-column indexes, and
|
|
|
|
- another to represent multi-column indexes.
|
|
|
|
Such separation would allow slightly more efficient implementation of
|
|
|
|
the single-column indexes.
|
|
|
|
= The current design requires such indexes to be fully recreated for each
|
|
|
|
PS (re)execution, however most of the comprising objects can be reused.
|
|
|
|
*/
|
|
|
|
|
2010-03-09 11:14:06 +01:00
|
|
|
class Ordered_key : public Sql_alloc
|
2010-02-19 22:55:57 +01:00
|
|
|
{
|
|
|
|
protected:
|
|
|
|
/*
|
|
|
|
Index of the key in an array of keys. This index allows to
|
|
|
|
construct (sub)sets of keys represented by bitmaps.
|
|
|
|
*/
|
2010-02-22 16:16:55 +01:00
|
|
|
uint keyid;
|
2010-02-19 22:55:57 +01:00
|
|
|
/* The table being indexed. */
|
|
|
|
TABLE *tbl;
|
|
|
|
/* The columns being indexed. */
|
|
|
|
Item_field **key_columns;
|
|
|
|
/* Number of elements in 'key_columns' (number of key parts). */
|
|
|
|
uint key_column_count;
|
|
|
|
/*
|
|
|
|
An expression, or sequence of expressions that forms the search key.
|
2010-03-09 11:14:06 +01:00
|
|
|
The search key is a sequence when it is Item_row. Each element of the
|
|
|
|
sequence is accessible via Item::element_index(int i).
|
2010-02-19 22:55:57 +01:00
|
|
|
*/
|
|
|
|
Item *search_key;
|
|
|
|
|
|
|
|
/* Value index related members. */
|
|
|
|
/*
|
|
|
|
The actual value index, consists of a sorted sequence of row numbers.
|
|
|
|
*/
|
|
|
|
rownum_t *key_buff;
|
|
|
|
/* Number of elements in key_buff. */
|
|
|
|
ha_rows key_buff_elements;
|
|
|
|
/* Current element in 'key_buff'. */
|
|
|
|
ha_rows cur_key_idx;
|
|
|
|
/*
|
|
|
|
Mapping from row numbers to row ids. The element row_num_to_rowid[i]
|
|
|
|
contains a buffer with the rowid for the row numbered 'i'.
|
|
|
|
The memory for this member is not maintanined by this class because
|
|
|
|
all Ordered_key indexes of the same table share the same mapping.
|
|
|
|
*/
|
|
|
|
uchar *row_num_to_rowid;
|
|
|
|
/*
|
|
|
|
A sequence of predicates to compare the search key with the corresponding
|
|
|
|
columns of a table row from the index.
|
|
|
|
*/
|
|
|
|
Item_func_lt **compare_pred;
|
|
|
|
|
|
|
|
/* Null index related members. */
|
|
|
|
MY_BITMAP null_key;
|
|
|
|
/* Count of NULLs per column. */
|
|
|
|
ha_rows null_count;
|
|
|
|
/* The row number that contains the first NULL in a column. */
|
2011-11-17 00:25:10 +01:00
|
|
|
rownum_t min_null_row;
|
2010-02-19 22:55:57 +01:00
|
|
|
/* The row number that contains the last NULL in a column. */
|
2011-11-17 00:25:10 +01:00
|
|
|
rownum_t max_null_row;
|
2010-02-19 22:55:57 +01:00
|
|
|
|
|
|
|
protected:
|
|
|
|
bool alloc_keys_buffers();
|
|
|
|
/*
|
|
|
|
Quick sort comparison function that compares two rows of the same table
|
|
|
|
indentfied with their row numbers.
|
|
|
|
*/
|
|
|
|
int cmp_keys_by_row_data(rownum_t a, rownum_t b);
|
|
|
|
static int cmp_keys_by_row_data_and_rownum(Ordered_key *key,
|
|
|
|
rownum_t* a, rownum_t* b);
|
|
|
|
|
|
|
|
int cmp_key_with_search_key(rownum_t row_num);
|
|
|
|
|
|
|
|
public:
|
2010-02-22 16:16:55 +01:00
|
|
|
Ordered_key(uint keyid_arg, TABLE *tbl_arg,
|
2010-02-19 22:55:57 +01:00
|
|
|
Item *search_key_arg, ha_rows null_count_arg,
|
|
|
|
ha_rows min_null_row_arg, ha_rows max_null_row_arg,
|
|
|
|
uchar *row_num_to_rowid_arg);
|
|
|
|
~Ordered_key();
|
|
|
|
void cleanup();
|
|
|
|
/* Initialize a multi-column index. */
|
|
|
|
bool init(MY_BITMAP *columns_to_index);
|
|
|
|
/* Initialize a single-column index. */
|
|
|
|
bool init(int col_idx);
|
|
|
|
|
|
|
|
uint get_column_count() { return key_column_count; }
|
2010-02-22 16:16:55 +01:00
|
|
|
uint get_keyid() { return keyid; }
|
2010-02-19 22:55:57 +01:00
|
|
|
uint get_field_idx(uint i)
|
|
|
|
{
|
|
|
|
DBUG_ASSERT(i < key_column_count);
|
|
|
|
return key_columns[i]->field->field_index;
|
|
|
|
}
|
2011-11-17 00:25:10 +01:00
|
|
|
rownum_t get_min_null_row() { return min_null_row; }
|
|
|
|
rownum_t get_max_null_row() { return max_null_row; }
|
|
|
|
MY_BITMAP * get_null_key() { return &null_key; }
|
|
|
|
ha_rows get_null_count() { return null_count; }
|
2010-03-09 11:14:06 +01:00
|
|
|
/*
|
|
|
|
Get the search key element that corresponds to the i-th key part of this
|
|
|
|
index.
|
|
|
|
*/
|
2010-02-19 22:55:57 +01:00
|
|
|
Item *get_search_key(uint i)
|
|
|
|
{
|
|
|
|
return search_key->element_index(key_columns[i]->field->field_index);
|
|
|
|
}
|
|
|
|
void add_key(rownum_t row_num)
|
|
|
|
{
|
|
|
|
/* The caller must know how many elements to add. */
|
|
|
|
DBUG_ASSERT(key_buff_elements && cur_key_idx < key_buff_elements);
|
|
|
|
key_buff[cur_key_idx]= row_num;
|
|
|
|
++cur_key_idx;
|
|
|
|
}
|
|
|
|
|
|
|
|
void sort_keys();
|
2010-02-22 16:16:55 +01:00
|
|
|
double null_selectivity();
|
2010-02-19 22:55:57 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
Position the current element at the first row that matches the key.
|
|
|
|
The key itself is propagated by evaluating the current value(s) of
|
|
|
|
this->search_key.
|
|
|
|
*/
|
|
|
|
bool lookup();
|
|
|
|
/* Move the current index cursor to the first key. */
|
|
|
|
void first()
|
|
|
|
{
|
|
|
|
DBUG_ASSERT(key_buff_elements);
|
|
|
|
cur_key_idx= 0;
|
|
|
|
}
|
|
|
|
/* TODO */
|
|
|
|
bool next_same();
|
|
|
|
/* Move the current index cursor to the next key. */
|
|
|
|
bool next()
|
|
|
|
{
|
|
|
|
DBUG_ASSERT(key_buff_elements);
|
|
|
|
if (cur_key_idx < key_buff_elements - 1)
|
|
|
|
{
|
|
|
|
++cur_key_idx;
|
|
|
|
return TRUE;
|
|
|
|
}
|
|
|
|
return FALSE;
|
|
|
|
};
|
|
|
|
/* Return the current index element. */
|
|
|
|
rownum_t current()
|
|
|
|
{
|
|
|
|
DBUG_ASSERT(key_buff_elements && cur_key_idx < key_buff_elements);
|
|
|
|
return key_buff[cur_key_idx];
|
|
|
|
}
|
|
|
|
|
|
|
|
void set_null(rownum_t row_num)
|
|
|
|
{
|
2011-02-18 23:31:01 +01:00
|
|
|
bitmap_set_bit(&null_key, (uint)row_num);
|
2010-02-19 22:55:57 +01:00
|
|
|
}
|
|
|
|
bool is_null(rownum_t row_num)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
Indexes consisting of only NULLs do not have a bitmap buffer at all.
|
|
|
|
Their only initialized member is 'n_bits', which is equal to the number
|
|
|
|
of temp table rows.
|
|
|
|
*/
|
|
|
|
if (null_count == tbl->file->stats.records)
|
|
|
|
{
|
|
|
|
DBUG_ASSERT(tbl->file->stats.records == null_key.n_bits);
|
|
|
|
return TRUE;
|
|
|
|
}
|
|
|
|
if (row_num > max_null_row || row_num < min_null_row)
|
|
|
|
return FALSE;
|
2011-02-18 23:31:01 +01:00
|
|
|
return bitmap_is_set(&null_key, (uint)row_num);
|
2010-02-19 22:55:57 +01:00
|
|
|
}
|
2010-02-22 16:16:55 +01:00
|
|
|
void print(String *str);
|
2010-02-19 22:55:57 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
|
2010-03-09 11:14:06 +01:00
|
|
|
class subselect_partial_match_engine : public subselect_engine
|
2010-02-19 22:55:57 +01:00
|
|
|
{
|
|
|
|
protected:
|
|
|
|
/* The temporary table that contains a materialized subquery. */
|
|
|
|
TABLE *tmp_table;
|
|
|
|
/*
|
|
|
|
The engine used to check whether an IN predicate is TRUE or not. If not
|
|
|
|
TRUE, then subselect_rowid_merge_engine further distinguishes between
|
|
|
|
FALSE and UNKNOWN.
|
|
|
|
*/
|
|
|
|
subselect_uniquesubquery_engine *lookup_engine;
|
2010-03-09 11:14:06 +01:00
|
|
|
/* A list of equalities between each pair of IN operands. */
|
|
|
|
List<Item> *equi_join_conds;
|
|
|
|
/*
|
2011-07-13 23:15:07 +02:00
|
|
|
True if there is an all NULL row in tmp_table. If so, then if there is
|
|
|
|
no complete match, there is a guaranteed partial match.
|
2010-03-09 11:14:06 +01:00
|
|
|
*/
|
2011-07-13 23:15:07 +02:00
|
|
|
bool has_covering_null_row;
|
|
|
|
|
|
|
|
/*
|
|
|
|
True if all nullable columns of tmp_table consist of only NULL values.
|
|
|
|
If so, then if there is a match in the non-null columns, there is a
|
|
|
|
guaranteed partial match.
|
|
|
|
*/
|
|
|
|
bool has_covering_null_columns;
|
2011-08-22 23:00:13 +02:00
|
|
|
uint count_columns_with_nulls;
|
2011-07-13 23:15:07 +02:00
|
|
|
|
2010-03-09 11:14:06 +01:00
|
|
|
protected:
|
|
|
|
virtual bool partial_match()= 0;
|
|
|
|
public:
|
2010-12-14 13:08:05 +01:00
|
|
|
subselect_partial_match_engine(THD *thd_arg,
|
|
|
|
subselect_uniquesubquery_engine *engine_arg,
|
2010-03-09 11:14:06 +01:00
|
|
|
TABLE *tmp_table_arg, Item_subselect *item_arg,
|
|
|
|
select_result_interceptor *result_arg,
|
|
|
|
List<Item> *equi_join_conds_arg,
|
2011-07-13 23:15:07 +02:00
|
|
|
bool has_covering_null_row_arg,
|
2011-08-22 23:00:13 +02:00
|
|
|
bool has_covering_null_columns_arg,
|
|
|
|
uint count_columns_with_nulls_arg);
|
2010-03-09 11:14:06 +01:00
|
|
|
int prepare() { return 0; }
|
|
|
|
int exec();
|
|
|
|
void fix_length_and_dec(Item_cache**) {}
|
|
|
|
uint cols() { /* TODO: what is the correct value? */ return 1; }
|
|
|
|
uint8 uncacheable() { return UNCACHEABLE_DEPENDENT; }
|
|
|
|
void exclude() {}
|
|
|
|
table_map upper_select_const_tables() { return 0; }
|
2011-05-04 17:08:58 +02:00
|
|
|
bool change_result(Item_subselect*,
|
|
|
|
select_result_interceptor*,
|
|
|
|
bool temp= FALSE)
|
2010-03-09 11:14:06 +01:00
|
|
|
{ DBUG_ASSERT(FALSE); return false; }
|
|
|
|
bool no_tables() { return false; }
|
|
|
|
bool no_rows()
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
TODO: It is completely unclear what is the semantics of this
|
|
|
|
method. The current result is computed so that the call to no_rows()
|
|
|
|
from Item_in_optimizer::val_int() sets Item_in_optimizer::null_value
|
|
|
|
correctly.
|
|
|
|
*/
|
|
|
|
return !(((Item_in_subselect *) item)->null_value);
|
|
|
|
}
|
|
|
|
void print(String*, enum_query_type);
|
|
|
|
|
|
|
|
friend void subselect_hash_sj_engine::cleanup();
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
class subselect_rowid_merge_engine: public subselect_partial_match_engine
|
|
|
|
{
|
|
|
|
protected:
|
2010-02-19 22:55:57 +01:00
|
|
|
/*
|
|
|
|
Mapping from row numbers to row ids. The rowids are stored sequentially
|
|
|
|
in the array - rowid[i] is located in row_num_to_rowid + i * rowid_length.
|
|
|
|
*/
|
|
|
|
uchar *row_num_to_rowid;
|
|
|
|
/*
|
|
|
|
A subset of all the keys for which there is a match for the same row.
|
|
|
|
Used during execution. Computed for each outer reference
|
|
|
|
*/
|
|
|
|
MY_BITMAP matching_keys;
|
|
|
|
/*
|
|
|
|
The columns of the outer reference that are NULL. Computed for each
|
|
|
|
outer reference.
|
|
|
|
*/
|
|
|
|
MY_BITMAP matching_outer_cols;
|
|
|
|
/*
|
|
|
|
Indexes of row numbers, sorted by <column_value, row_number>. If an
|
|
|
|
index may contain NULLs, the NULLs are stored efficiently in a bitmap.
|
|
|
|
|
|
|
|
The indexes are sorted by the selectivity of their NULL sub-indexes, the
|
|
|
|
one with the fewer NULLs is first. Thus, if there is any index on
|
|
|
|
non-NULL columns, it is contained in keys[0].
|
|
|
|
*/
|
|
|
|
Ordered_key **merge_keys;
|
2011-07-13 16:09:09 +02:00
|
|
|
/* The number of elements in merge_keys. */
|
|
|
|
uint merge_keys_count;
|
2011-11-17 00:25:10 +01:00
|
|
|
/* The NULL bitmaps of merge keys.*/
|
|
|
|
MY_BITMAP **null_bitmaps;
|
2010-02-19 22:55:57 +01:00
|
|
|
/*
|
|
|
|
An index on all non-NULL columns of 'tmp_table'. The index has the
|
|
|
|
logical form: <[v_i1 | ... | v_ik], rownum>. It allows to find the row
|
|
|
|
number where the columns c_i1,...,c1_k contain the values v_i1,...,v_ik.
|
2011-07-13 16:09:09 +02:00
|
|
|
If such an index exists, it is always the first element of 'merge_keys'.
|
2010-02-19 22:55:57 +01:00
|
|
|
*/
|
|
|
|
Ordered_key *non_null_key;
|
|
|
|
/*
|
|
|
|
Priority queue of Ordered_key indexes, one per NULLable column.
|
|
|
|
This queue is used by the partial match algorithm in method exec().
|
|
|
|
*/
|
|
|
|
QUEUE pq;
|
|
|
|
protected:
|
|
|
|
/*
|
2010-02-22 16:16:55 +01:00
|
|
|
Comparison function to compare keys in order of decreasing bitmap
|
2010-02-19 22:55:57 +01:00
|
|
|
selectivity.
|
|
|
|
*/
|
2010-02-22 16:16:55 +01:00
|
|
|
static int cmp_keys_by_null_selectivity(Ordered_key **k1, Ordered_key **k2);
|
2010-02-19 22:55:57 +01:00
|
|
|
/*
|
|
|
|
Comparison function used by the priority queue pq, the 'smaller' key
|
|
|
|
is the one with the smaller current row number.
|
|
|
|
*/
|
|
|
|
static int cmp_keys_by_cur_rownum(void *arg, uchar *k1, uchar *k2);
|
|
|
|
|
|
|
|
bool test_null_row(rownum_t row_num);
|
2011-11-17 00:25:10 +01:00
|
|
|
bool exists_complementing_null_row(MY_BITMAP *keys_to_complement);
|
2010-02-19 22:55:57 +01:00
|
|
|
bool partial_match();
|
|
|
|
public:
|
2010-12-14 13:08:05 +01:00
|
|
|
subselect_rowid_merge_engine(THD *thd_arg,
|
|
|
|
subselect_uniquesubquery_engine *engine_arg,
|
2011-07-13 16:09:09 +02:00
|
|
|
TABLE *tmp_table_arg, uint merge_keys_count_arg,
|
2011-07-13 23:15:07 +02:00
|
|
|
bool has_covering_null_row_arg,
|
|
|
|
bool has_covering_null_columns_arg,
|
2011-08-22 23:00:13 +02:00
|
|
|
uint count_columns_with_nulls_arg,
|
2010-02-19 22:55:57 +01:00
|
|
|
Item_subselect *item_arg,
|
2010-03-09 11:14:06 +01:00
|
|
|
select_result_interceptor *result_arg,
|
|
|
|
List<Item> *equi_join_conds_arg)
|
2010-12-14 13:08:05 +01:00
|
|
|
:subselect_partial_match_engine(thd_arg, engine_arg, tmp_table_arg,
|
|
|
|
item_arg, result_arg, equi_join_conds_arg,
|
2011-07-13 23:15:07 +02:00
|
|
|
has_covering_null_row_arg,
|
2011-08-22 23:00:13 +02:00
|
|
|
has_covering_null_columns_arg,
|
|
|
|
count_columns_with_nulls_arg),
|
2011-07-13 16:09:09 +02:00
|
|
|
merge_keys_count(merge_keys_count_arg), non_null_key(NULL)
|
2010-12-14 13:08:05 +01:00
|
|
|
{}
|
2010-02-19 22:55:57 +01:00
|
|
|
~subselect_rowid_merge_engine();
|
|
|
|
bool init(MY_BITMAP *non_null_key_parts, MY_BITMAP *partial_match_key_parts);
|
|
|
|
void cleanup();
|
2010-03-09 11:14:06 +01:00
|
|
|
virtual enum_engine_type engine_type() { return ROWID_MERGE_ENGINE; }
|
2010-02-19 22:55:57 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
|
2010-03-09 11:14:06 +01:00
|
|
|
class subselect_table_scan_engine: public subselect_partial_match_engine
|
2010-01-28 14:48:33 +01:00
|
|
|
{
|
|
|
|
protected:
|
2010-03-09 11:14:06 +01:00
|
|
|
bool partial_match();
|
2010-01-28 14:48:33 +01:00
|
|
|
public:
|
2010-12-14 13:08:05 +01:00
|
|
|
subselect_table_scan_engine(THD *thd_arg,
|
|
|
|
subselect_uniquesubquery_engine *engine_arg,
|
2010-03-09 11:14:06 +01:00
|
|
|
TABLE *tmp_table_arg, Item_subselect *item_arg,
|
|
|
|
select_result_interceptor *result_arg,
|
|
|
|
List<Item> *equi_join_conds_arg,
|
2011-07-13 23:15:07 +02:00
|
|
|
bool has_covering_null_row_arg,
|
2011-08-22 23:00:13 +02:00
|
|
|
bool has_covering_null_columns_arg,
|
|
|
|
uint count_columns_with_nulls_arg);
|
2010-01-28 14:48:33 +01:00
|
|
|
void cleanup();
|
2010-03-09 11:14:06 +01:00
|
|
|
virtual enum_engine_type engine_type() { return TABLE_SCAN_ENGINE; }
|
2010-01-28 14:48:33 +01:00
|
|
|
};
|
2009-09-23 23:32:31 +02:00
|
|
|
#endif /* ITEM_SUBSELECT_INCLUDED */
|