2009-09-23 23:32:31 +02:00
|
|
|
#ifndef PARTITION_ELEMENT_INCLUDED
|
|
|
|
#define PARTITION_ELEMENT_INCLUDED
|
|
|
|
|
2014-01-06 06:22:35 +01:00
|
|
|
/* Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
|
2006-02-16 17:38:33 +01:00
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
2006-12-27 02:23:51 +01:00
|
|
|
the Free Software Foundation; version 2 of the License.
|
2006-02-16 17:38:33 +01:00
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program; if not, write to the Free Software
|
2019-05-11 20:29:06 +02:00
|
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1335 USA */
|
2006-02-16 17:38:33 +01:00
|
|
|
|
2010-03-31 16:05:33 +02:00
|
|
|
#include "my_base.h" /* ha_rows */
|
|
|
|
#include "handler.h" /* UNDEF_NODEGROUP */
|
|
|
|
|
2006-02-16 17:38:33 +01:00
|
|
|
/**
|
|
|
|
* An enum and a struct to handle partitioning and subpartitioning.
|
|
|
|
*/
|
|
|
|
enum partition_type {
|
|
|
|
NOT_A_PARTITION= 0,
|
|
|
|
RANGE_PARTITION,
|
|
|
|
HASH_PARTITION,
|
2016-12-11 18:04:11 +01:00
|
|
|
LIST_PARTITION,
|
|
|
|
VERSIONING_PARTITION
|
2006-02-16 17:38:33 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
enum partition_state {
|
|
|
|
PART_NORMAL= 0,
|
|
|
|
PART_IS_DROPPED= 1,
|
|
|
|
PART_TO_BE_DROPPED= 2,
|
|
|
|
PART_TO_BE_ADDED= 3,
|
|
|
|
PART_TO_BE_REORGED= 4,
|
|
|
|
PART_REORGED_DROPPED= 5,
|
|
|
|
PART_CHANGED= 6,
|
|
|
|
PART_IS_CHANGED= 7,
|
2009-09-10 11:15:39 +02:00
|
|
|
PART_IS_ADDED= 8,
|
|
|
|
PART_ADMIN= 9
|
2006-02-16 17:38:33 +01:00
|
|
|
};
|
|
|
|
|
2009-09-15 17:07:52 +02:00
|
|
|
/*
|
|
|
|
This struct is used to keep track of column expressions as part
|
|
|
|
of the COLUMNS concept in conjunction with RANGE and LIST partitioning.
|
|
|
|
The value can be either of MINVALUE, MAXVALUE and an expression that
|
|
|
|
must be constant and evaluate to the same type as the column it
|
|
|
|
represents.
|
|
|
|
|
|
|
|
The data in this fixed in two steps. The parser will only fill in whether
|
|
|
|
it is a max_value or provide an expression. Filling in
|
|
|
|
column_value, part_info, partition_id, null_value is done by the
|
|
|
|
function fix_column_value_function. However the item tree needs
|
|
|
|
fixed also before writing it into the frm file (in add_column_list_values).
|
|
|
|
To distinguish between those two variants, fixed= 1 after the
|
|
|
|
fixing in add_column_list_values and fixed= 2 otherwise. This is
|
|
|
|
since the fixing in add_column_list_values isn't a complete fixing.
|
|
|
|
*/
|
|
|
|
|
|
|
|
typedef struct p_column_list_val
|
|
|
|
{
|
|
|
|
void* column_value;
|
|
|
|
Item* item_expression;
|
|
|
|
partition_info *part_info;
|
|
|
|
uint partition_id;
|
2016-08-29 22:29:12 +02:00
|
|
|
bool max_value; // MAXVALUE for RANGE type or DEFAULT value for LIST type
|
2009-09-15 17:07:52 +02:00
|
|
|
bool null_value;
|
|
|
|
char fixed;
|
|
|
|
} part_column_list_val;
|
|
|
|
|
|
|
|
|
2006-06-05 20:55:22 +02:00
|
|
|
/*
|
|
|
|
This struct is used to contain the value of an element
|
|
|
|
in the VALUES IN struct. It needs to keep knowledge of
|
|
|
|
whether it is a signed/unsigned value and whether it is
|
|
|
|
NULL or not.
|
|
|
|
*/
|
|
|
|
|
2006-04-18 04:51:34 +02:00
|
|
|
typedef struct p_elem_val
|
|
|
|
{
|
|
|
|
longlong value;
|
2009-10-16 16:16:06 +02:00
|
|
|
uint added_items;
|
2006-04-18 04:51:34 +02:00
|
|
|
bool null_value;
|
|
|
|
bool unsigned_flag;
|
2009-09-15 17:07:52 +02:00
|
|
|
part_column_list_val *col_val_array;
|
2006-04-18 04:51:34 +02:00
|
|
|
} part_elem_value;
|
|
|
|
|
WL 2826: Error handling of ALTER TABLE for partitioning
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
Fixed mysqlish method intro's
Fixed warning statements
5.1.7 was released still with partition states in clear text
Fixed io_size bug
Fixed bug in open that TRUNCATED before reading :)
file_entry => file_entry_buf
Don't open DDL log until first write call to DDL log
handler_type => handler_name
no => num
sql/ha_partition.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
sql/mysql_priv.h:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/mysqld.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/partition_element.h:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/partition_info.h:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/share/errmsg.txt:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/sql_base.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/sql_partition.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
Fixed mysqlish method intro's
Fixed warning statements
sql/sql_table.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
Fixed mysqlish method intro's
Fixed warning statements
Fixed io_size bug
Fixed bug in open that TRUNCATED before reading :)
file_entry => file_entry_buf
Don't open DDL log until first write call to DDL log
handler_type => handler_name
no => num
sql/table.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
Fixed mysqlish method intro's
Fixed warning statements
5.1.7 was released still with partition states in clear text
Fixed io_size bug
Fixed bug in open that TRUNCATED before reading :)
file_entry => file_entry_buf
Don't open DDL log until first write call to DDL log
handler_type => handler_name
no => num
2006-03-25 00:19:13 +01:00
|
|
|
struct st_ddl_log_memory_entry;
|
2006-03-22 06:17:22 +01:00
|
|
|
|
2016-12-31 16:33:26 +01:00
|
|
|
enum stat_trx_field
|
|
|
|
{
|
|
|
|
STAT_TRX_END= 0
|
|
|
|
};
|
|
|
|
|
|
|
|
class partition_element :public Sql_alloc
|
|
|
|
{
|
2006-02-16 17:38:33 +01:00
|
|
|
public:
|
2019-08-28 10:57:16 +02:00
|
|
|
enum elem_type_enum
|
2017-09-07 14:49:11 +02:00
|
|
|
{
|
|
|
|
CONVENTIONAL= 0,
|
2017-12-14 18:35:12 +01:00
|
|
|
CURRENT,
|
|
|
|
HISTORY
|
2017-09-07 14:49:11 +02:00
|
|
|
};
|
|
|
|
|
2006-02-16 17:38:33 +01:00
|
|
|
List<partition_element> subpartitions;
|
2006-04-18 04:51:34 +02:00
|
|
|
List<part_elem_value> list_val_list;
|
2006-08-24 00:12:42 +02:00
|
|
|
ha_rows part_max_rows;
|
|
|
|
ha_rows part_min_rows;
|
2006-04-18 04:51:34 +02:00
|
|
|
longlong range_value;
|
2017-04-23 18:39:57 +02:00
|
|
|
const char *partition_name;
|
|
|
|
const char *tablespace_name;
|
WL 2826: Error handling of ALTER TABLE for partitioning
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
Fixed mysqlish method intro's
Fixed warning statements
5.1.7 was released still with partition states in clear text
Fixed io_size bug
Fixed bug in open that TRUNCATED before reading :)
file_entry => file_entry_buf
Don't open DDL log until first write call to DDL log
handler_type => handler_name
no => num
sql/ha_partition.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
sql/mysql_priv.h:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/mysqld.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/partition_element.h:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/partition_info.h:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/share/errmsg.txt:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/sql_base.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
sql/sql_partition.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
Fixed mysqlish method intro's
Fixed warning statements
sql/sql_table.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
Fixed mysqlish method intro's
Fixed warning statements
Fixed io_size bug
Fixed bug in open that TRUNCATED before reading :)
file_entry => file_entry_buf
Don't open DDL log until first write call to DDL log
handler_type => handler_name
no => num
sql/table.cc:
Loads of review comments fixed
inactivate => deactivate
table log => ddl log
Commented on Error Inject Module added
Put various #defines into enums
Fixed abort_and_upgrade_lock, removed unnecessary parameter
Fixed mysqlish method intro's
Fixed warning statements
5.1.7 was released still with partition states in clear text
Fixed io_size bug
Fixed bug in open that TRUNCATED before reading :)
file_entry => file_entry_buf
Don't open DDL log until first write call to DDL log
handler_type => handler_name
no => num
2006-03-25 00:19:13 +01:00
|
|
|
struct st_ddl_log_memory_entry *log_entry;
|
2017-04-23 18:39:57 +02:00
|
|
|
const char* part_comment;
|
|
|
|
const char* data_file_name;
|
|
|
|
const char* index_file_name;
|
2006-02-16 17:38:33 +01:00
|
|
|
handlerton *engine_type;
|
2017-04-23 18:39:57 +02:00
|
|
|
LEX_CSTRING connect_string;
|
2006-02-16 17:38:33 +01:00
|
|
|
enum partition_state part_state;
|
|
|
|
uint16 nodegroup_id;
|
2006-03-07 12:25:08 +01:00
|
|
|
bool has_null_value;
|
Bug#14521864: MYSQL 5.1 TO 5.5 BUGS PARTITIONING
Due to an internal change in the server code in between 5.1 and 5.5
(wl#2649) the hash function used in KEY partitioning changed
for numeric and date/time columns (from binary hash calculation
to character based hash calculation).
Also enum/set changed from latin1 ci based hash calculation to
binary hash between 5.1 and 5.5. (bug#11759782).
These changes makes KEY [sub]partitioned tables on any of
the affected column types incompatible with 5.5 and above,
since the calculation of partition id differs.
Also since InnoDB asserts that a deleted row was previously
read (positioned), the server asserts on delete of a row that
is in the wrong partition.
The solution for this situation is:
1) The partitioning engine will check that delete/update will go to the
partition the row was read from and give an error otherwise, consisting
of the rows partitioning fields. This will avoid asserts in InnoDB and
also alert the user that there is a misplaced row. A detailed error
message will be given, including an entry to the error log consisting
of both table name, partition and row content (PK if exists, otherwise
all partitioning columns).
2) A new optional syntax for KEY () partitioning in 5.5 is allowed:
[SUB]PARTITION BY KEY [ALGORITHM = N] (list_of_cols)
Where N = 1 uses the same hashing as 5.1 (Numeric/date/time fields uses
binary hashing, ENUM/SET uses charset hashing) N = 2 uses the same
hashing as 5.5 (Numeric/date/time fields uses charset hashing,
ENUM/SET uses binary hashing). If not set on CREATE/ALTER it will
default to 2.
This new syntax should probably be ignored by NDB.
3) Since there is a demand for avoiding scanning through the full
table, during upgrade the ALTER TABLE t PARTITION BY ... command is
considered a no-op (only .frm change) if everything except ALGORITHM
is the same and ALGORITHM was not set before, which allows manually
upgrading such table by something like:
ALTER TABLE t PARTITION BY KEY ALGORITHM = 1 () or
ALTER TABLE t PARTITION BY KEY ALGORITHM = 2 ()
4) Enhanced partitioning with CHECK/REPAIR to also check for/repair
misplaced rows. (Also works for ALTER TABLE t CHECK/REPAIR PARTITION)
CHECK FOR UPGRADE:
If the .frm version is < 5.5.3
and uses KEY [sub]partitioning
and an affected column type
then it will fail with an message:
KEY () partitioning changed, please run:
ALTER TABLE `test`.`t1` PARTITION BY KEY ALGORITHM = 1 (a)
PARTITIONS 12
(i.e. current partitioning clause, with the addition of
ALGORITHM = 1)
CHECK without FOR UPGRADE:
if MEDIUM (default) or EXTENDED options are given:
Scan all rows and verify that it is in the correct partition.
Fail for the first misplaced row.
REPAIR:
if default or EXTENDED (i.e. not QUICK/USE_FRM):
Scan all rows and every misplaced row is moved into its correct
partitions.
5) Updated mysqlcheck (called by mysql_upgrade) to handle the
new output from CHECK FOR UPGRADE, to run the ALTER statement
instead of running REPAIR.
This will allow mysql_upgrade (or CHECK TABLE t FOR UPGRADE) to upgrade
a KEY [sub]partitioned table that has any affected field type
and a .frm version < 5.5.3 to ALGORITHM = 1 without rebuild.
Also notice that if the .frm has a version of >= 5.5.3 and ALGORITHM
is not set, it is not possible to know if it consists of rows from
5.1 or 5.5! In these cases I suggest that the user does:
(optional)
LOCK TABLE t WRITE;
SHOW CREATE TABLE t;
(verify that it has no ALGORITHM = N, and to be safe, I would suggest
backing up the .frm file, to be used if one need to change to another
ALGORITHM = N, without needing to rebuild/repair)
ALTER TABLE t <old partitioning clause, but with ALGORITHM = N>;
which should set the ALGORITHM to N (if the table has rows from
5.1 I would suggest N = 1, otherwise N = 2)
CHECK TABLE t;
(here one could use the backed up .frm instead and change to a new N
and run CHECK again and see if it passes)
and if there are misplaced rows:
REPAIR TABLE t;
(optional)
UNLOCK TABLES;
2013-01-30 17:51:52 +01:00
|
|
|
bool signed_flag; // Range value signed
|
|
|
|
bool max_value; // MAXVALUE range
|
2016-12-11 18:04:11 +01:00
|
|
|
uint32 id;
|
2016-12-31 16:33:26 +01:00
|
|
|
bool empty;
|
2019-08-28 10:57:16 +02:00
|
|
|
elem_type_enum type;
|
2006-02-28 22:07:14 +01:00
|
|
|
|
2006-02-16 17:38:33 +01:00
|
|
|
partition_element()
|
2006-04-18 04:51:34 +02:00
|
|
|
: part_max_rows(0), part_min_rows(0), range_value(0),
|
2006-06-14 15:12:07 +02:00
|
|
|
partition_name(NULL), tablespace_name(NULL),
|
|
|
|
log_entry(NULL), part_comment(NULL),
|
2006-02-16 17:38:33 +01:00
|
|
|
data_file_name(NULL), index_file_name(NULL),
|
2017-04-23 18:39:57 +02:00
|
|
|
engine_type(NULL), connect_string(null_clex_str), part_state(PART_NORMAL),
|
2006-04-18 04:51:34 +02:00
|
|
|
nodegroup_id(UNDEF_NODEGROUP), has_null_value(FALSE),
|
2016-12-11 18:04:11 +01:00
|
|
|
signed_flag(FALSE), max_value(FALSE),
|
2018-01-13 12:15:46 +01:00
|
|
|
id(UINT_MAX32),
|
2019-08-28 10:57:16 +02:00
|
|
|
empty(true),
|
|
|
|
type(CONVENTIONAL)
|
2016-12-31 16:33:26 +01:00
|
|
|
{}
|
2006-04-21 14:43:07 +02:00
|
|
|
partition_element(partition_element *part_elem)
|
2006-06-04 00:37:31 +02:00
|
|
|
: part_max_rows(part_elem->part_max_rows),
|
|
|
|
part_min_rows(part_elem->part_min_rows),
|
2007-04-13 19:23:02 +02:00
|
|
|
range_value(0), partition_name(NULL),
|
2006-06-04 00:37:31 +02:00
|
|
|
tablespace_name(part_elem->tablespace_name),
|
Fix all warnings given by UBSAN
The easiest way to compile and test the server with UBSAN is to run:
./BUILD/compile-pentium64-ubsan
and then run mysql-test-run.
After this commit, one should be able to run this without any UBSAN
warnings. There is still a few compiler warnings that should be fixed
at some point, but these do not expose any real bugs.
The 'special' cases where we disable, suppress or circumvent UBSAN are:
- ref10 source (as here we intentionally do some shifts that UBSAN
complains about.
- x86 version of optimized int#korr() methods. UBSAN do not like unaligned
memory access of integers. Fixed by using byte_order_generic.h when
compiling with UBSAN
- We use smaller thread stack with ASAN and UBSAN, which forced me to
disable a few tests that prints the thread stack size.
- Verifying class types does not work for shared libraries. I added
suppression in mysql-test-run.pl for this case.
- Added '#ifdef WITH_UBSAN' when using integer arithmetic where it is
safe to have overflows (two cases, in item_func.cc).
Things fixed:
- Don't left shift signed values
(byte_order_generic.h, mysqltest.c, item_sum.cc and many more)
- Don't assign not non existing values to enum variables.
- Ensure that bool and enum values are properly initialized in
constructors. This was needed as UBSAN checks that these types has
correct values when one copies an object.
(gcalc_tools.h, ha_partition.cc, item_sum.cc, partition_element.h ...)
- Ensure we do not called handler functions on unallocated objects or
deleted objects.
(events.cc, sql_acl.cc).
- Fixed bugs in Item_sp::Item_sp() where we did not call constructor
on Query_arena object.
- Fixed several cast of objects to an incompatible class!
(Item.cc, Item_buff.cc, item_timefunc.cc, opt_subselect.cc, sql_acl.cc,
sql_select.cc ...)
- Ensure we do not do integer arithmetic that causes over or underflows.
This includes also ++ and -- of integers.
(Item_func.cc, Item_strfunc.cc, item_timefunc.cc, sql_base.cc ...)
- Added JSON_VALUE_UNITIALIZED to json_value_types and ensure that
value_type is initialized to this instead of to -1, which is not a valid
enum value for json_value_types.
- Ensure we do not call memcpy() when second argument could be null.
- Fixed that Item_func_str::make_empty_result() creates an empty string
instead of a null string (safer as it ensures we do not do arithmetic
on null strings).
Other things:
- Changed struct st_position to an OBJECT and added an initialization
function to it to ensure that we do not copy or use uninitialized
members. The change to a class was also motived that we used "struct
st_position" and POSITION randomly trough the code which was
confusing.
- Notably big rewrite in sql_acl.cc to avoid using deleted objects.
- Changed in sql_partition to use '^' instead of '-'. This is safe as
the operator is either 0 or 0x8000000000000000ULL.
- Added check for select_nr < INT_MAX in JOIN::build_explain() to
avoid bug when get_select() could return NULL.
- Reordered elements in POSITION for better alignment.
- Changed sql_test.cc::print_plan() to use pointers instead of objects.
- Fixed bug in find_set() where could could execute '1 << -1'.
- Added variable have_sanitizer, used by mtr. (This variable was before
only in 10.5 and up). It can now have one of two values:
ASAN or UBSAN.
- Moved ~Archive_share() from ha_archive.cc to ha_archive.h and marked
it virtual. This was an effort to get UBSAN to work with loaded storage
engines. I kept the change as the new place is better.
- Added in CONNECT engine COLBLK::SetName(), to get around a wrong cast
in tabutil.cpp.
- Added HAVE_REPLICATION around usage of rgi_slave, to get embedded
server to compile with UBSAN. (Patch from Marko).
- Added #ifdef for powerpc64 to avoid a bug in old gcc versions related
to integer arithmetic.
Changes that should not be needed but had to be done to suppress warnings
from UBSAN:
- Added static_cast<<uint16_t>> around shift to get rid of a LOT of
compiler warnings when using UBSAN.
- Had to change some '/' of 2 base integers to shift to get rid of
some compile time warnings.
Reviewed by:
- Json changes: Alexey Botchkov
- Charset changes in ctype-uca.c: Alexander Barkov
- InnoDB changes & Embedded server: Marko Mäkelä
- sql_acl.cc changes: Vicențiu Ciorbaru
- build_explain() changes: Sergey Petrunia
2021-04-18 14:29:13 +02:00
|
|
|
log_entry(NULL),
|
2007-04-13 19:23:02 +02:00
|
|
|
part_comment(part_elem->part_comment),
|
2006-06-04 00:37:31 +02:00
|
|
|
data_file_name(part_elem->data_file_name),
|
|
|
|
index_file_name(part_elem->index_file_name),
|
|
|
|
engine_type(part_elem->engine_type),
|
2017-04-23 18:39:57 +02:00
|
|
|
connect_string(null_clex_str),
|
2006-06-04 00:37:31 +02:00
|
|
|
part_state(part_elem->part_state),
|
|
|
|
nodegroup_id(part_elem->nodegroup_id),
|
2016-12-11 18:04:11 +01:00
|
|
|
has_null_value(FALSE),
|
Fix all warnings given by UBSAN
The easiest way to compile and test the server with UBSAN is to run:
./BUILD/compile-pentium64-ubsan
and then run mysql-test-run.
After this commit, one should be able to run this without any UBSAN
warnings. There is still a few compiler warnings that should be fixed
at some point, but these do not expose any real bugs.
The 'special' cases where we disable, suppress or circumvent UBSAN are:
- ref10 source (as here we intentionally do some shifts that UBSAN
complains about.
- x86 version of optimized int#korr() methods. UBSAN do not like unaligned
memory access of integers. Fixed by using byte_order_generic.h when
compiling with UBSAN
- We use smaller thread stack with ASAN and UBSAN, which forced me to
disable a few tests that prints the thread stack size.
- Verifying class types does not work for shared libraries. I added
suppression in mysql-test-run.pl for this case.
- Added '#ifdef WITH_UBSAN' when using integer arithmetic where it is
safe to have overflows (two cases, in item_func.cc).
Things fixed:
- Don't left shift signed values
(byte_order_generic.h, mysqltest.c, item_sum.cc and many more)
- Don't assign not non existing values to enum variables.
- Ensure that bool and enum values are properly initialized in
constructors. This was needed as UBSAN checks that these types has
correct values when one copies an object.
(gcalc_tools.h, ha_partition.cc, item_sum.cc, partition_element.h ...)
- Ensure we do not called handler functions on unallocated objects or
deleted objects.
(events.cc, sql_acl.cc).
- Fixed bugs in Item_sp::Item_sp() where we did not call constructor
on Query_arena object.
- Fixed several cast of objects to an incompatible class!
(Item.cc, Item_buff.cc, item_timefunc.cc, opt_subselect.cc, sql_acl.cc,
sql_select.cc ...)
- Ensure we do not do integer arithmetic that causes over or underflows.
This includes also ++ and -- of integers.
(Item_func.cc, Item_strfunc.cc, item_timefunc.cc, sql_base.cc ...)
- Added JSON_VALUE_UNITIALIZED to json_value_types and ensure that
value_type is initialized to this instead of to -1, which is not a valid
enum value for json_value_types.
- Ensure we do not call memcpy() when second argument could be null.
- Fixed that Item_func_str::make_empty_result() creates an empty string
instead of a null string (safer as it ensures we do not do arithmetic
on null strings).
Other things:
- Changed struct st_position to an OBJECT and added an initialization
function to it to ensure that we do not copy or use uninitialized
members. The change to a class was also motived that we used "struct
st_position" and POSITION randomly trough the code which was
confusing.
- Notably big rewrite in sql_acl.cc to avoid using deleted objects.
- Changed in sql_partition to use '^' instead of '-'. This is safe as
the operator is either 0 or 0x8000000000000000ULL.
- Added check for select_nr < INT_MAX in JOIN::build_explain() to
avoid bug when get_select() could return NULL.
- Reordered elements in POSITION for better alignment.
- Changed sql_test.cc::print_plan() to use pointers instead of objects.
- Fixed bug in find_set() where could could execute '1 << -1'.
- Added variable have_sanitizer, used by mtr. (This variable was before
only in 10.5 and up). It can now have one of two values:
ASAN or UBSAN.
- Moved ~Archive_share() from ha_archive.cc to ha_archive.h and marked
it virtual. This was an effort to get UBSAN to work with loaded storage
engines. I kept the change as the new place is better.
- Added in CONNECT engine COLBLK::SetName(), to get around a wrong cast
in tabutil.cpp.
- Added HAVE_REPLICATION around usage of rgi_slave, to get embedded
server to compile with UBSAN. (Patch from Marko).
- Added #ifdef for powerpc64 to avoid a bug in old gcc versions related
to integer arithmetic.
Changes that should not be needed but had to be done to suppress warnings
from UBSAN:
- Added static_cast<<uint16_t>> around shift to get rid of a LOT of
compiler warnings when using UBSAN.
- Had to change some '/' of 2 base integers to shift to get rid of
some compile time warnings.
Reviewed by:
- Json changes: Alexey Botchkov
- Charset changes in ctype-uca.c: Alexander Barkov
- InnoDB changes & Embedded server: Marko Mäkelä
- sql_acl.cc changes: Vicențiu Ciorbaru
- build_explain() changes: Sergey Petrunia
2021-04-18 14:29:13 +02:00
|
|
|
signed_flag(part_elem->signed_flag),
|
|
|
|
max_value(part_elem->max_value),
|
2016-12-11 18:04:11 +01:00
|
|
|
id(part_elem->id),
|
2019-08-28 10:57:16 +02:00
|
|
|
empty(part_elem->empty),
|
|
|
|
type(CONVENTIONAL)
|
2016-12-31 16:33:26 +01:00
|
|
|
{}
|
2023-02-07 12:57:20 +01:00
|
|
|
~partition_element() = default;
|
2016-12-31 16:33:26 +01:00
|
|
|
|
|
|
|
part_column_list_val& get_col_val(uint idx)
|
2006-04-21 14:43:07 +02:00
|
|
|
{
|
2017-09-07 14:49:11 +02:00
|
|
|
part_elem_value *ev= list_val_list.head();
|
|
|
|
DBUG_ASSERT(ev);
|
|
|
|
DBUG_ASSERT(ev->col_val_array);
|
2016-12-31 16:33:26 +01:00
|
|
|
return ev->col_val_array[idx];
|
2006-04-21 14:43:07 +02:00
|
|
|
}
|
2006-02-16 17:38:33 +01:00
|
|
|
};
|
2009-09-23 23:32:31 +02:00
|
|
|
|
|
|
|
#endif /* PARTITION_ELEMENT_INCLUDED */
|