2022-06-29 16:57:22 +02:00
|
|
|
--source include/binlog_combinations.inc
|
|
|
|
--source include/have_innodb.inc
|
2023-02-15 17:26:32 +01:00
|
|
|
--source include/not_embedded.inc
|
2022-06-29 16:57:22 +02:00
|
|
|
|
2022-07-15 08:52:33 +02:00
|
|
|
--echo #
|
|
|
|
--echo # alter ignore cannot be done online
|
|
|
|
--echo #
|
|
|
|
create table t (a int);
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter ignore table t add primary key (a), algorithm=copy, lock=none;
|
|
|
|
drop table t;
|
|
|
|
|
2022-06-29 16:57:22 +02:00
|
|
|
--echo #
|
|
|
|
--echo # MDEV-28771 Assertion `table->in_use&&tdc->flushed' failed after ALTER
|
|
|
|
--echo #
|
|
|
|
|
|
|
|
create table t (a char(1));
|
|
|
|
insert into t values ('a'),('b');
|
|
|
|
select * from t join t as t2 join t as t3;
|
|
|
|
--error ER_TRUNCATED_WRONG_VALUE
|
|
|
|
alter table t modify a int;
|
|
|
|
select * from t;
|
|
|
|
drop table t;
|
|
|
|
|
|
|
|
create table t (c double precision key,c2 char,c3 year);
|
|
|
|
insert into t values (7,3,1);
|
|
|
|
--error ER_BAD_FIELD_ERROR
|
|
|
|
select a from t where a=all (select a from t where b=2 union select a from t where b=2);
|
|
|
|
insert into t values (3,1,1);
|
|
|
|
--error ER_TRUNCATED_WRONG_VALUE
|
|
|
|
alter table t change c c date,add key(c);
|
|
|
|
select * from t;
|
|
|
|
drop table t;
|
|
|
|
|
|
|
|
set sql_mode='';
|
|
|
|
create table t (c char unique,c2 int,stamp timestamp);
|
|
|
|
insert into t values (1,1,1),(2,2,2),(3,3,3),(4,4,4),(5,5,5);
|
|
|
|
--error ER_OPERAND_COLUMNS
|
|
|
|
update t set c=(select * from t) where c in (select * from t);
|
|
|
|
--error ER_DUP_ENTRY
|
|
|
|
alter table t modify c date;
|
|
|
|
select * from t;
|
|
|
|
drop table t;
|
|
|
|
set sql_mode=default;
|
2022-06-29 16:58:33 +02:00
|
|
|
|
|
|
|
--echo #
|
|
|
|
--echo # MDEV-28944 XA assertions failing in binlog_rollback and binlog_commit
|
|
|
|
--echo #
|
2023-05-13 20:55:08 +02:00
|
|
|
--disable_view_protocol
|
2022-06-29 16:58:33 +02:00
|
|
|
CREATE TABLE t (a INT) ENGINE=MyISAM;
|
|
|
|
INSERT INTO t VALUES (1);
|
|
|
|
|
|
|
|
--connect (con1,localhost,root,,test)
|
|
|
|
XA START 'xid';
|
|
|
|
SELECT * FROM t;
|
|
|
|
|
|
|
|
--connection default
|
|
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
|
|
ALTER TABLE t NOWAIT ADD KEY (a);
|
|
|
|
|
|
|
|
--connection con1
|
|
|
|
UPDATE t SET a = 2;
|
|
|
|
XA END 'xid';
|
|
|
|
XA COMMIT 'xid' ONE PHASE;
|
|
|
|
|
|
|
|
DROP TABLE t;
|
|
|
|
--disconnect con1
|
2022-10-21 14:08:26 +02:00
|
|
|
--connection default
|
2023-05-13 20:55:08 +02:00
|
|
|
--enable_view_protocol
|
2022-10-21 14:08:26 +02:00
|
|
|
|
|
|
|
--echo #
|
|
|
|
--echo # MDEV-29068 Cascade foreign key updates do not apply in online alter
|
|
|
|
--echo #
|
|
|
|
create table t1 (a int primary key) engine=InnoDB;
|
|
|
|
insert into t1 values (1),(2),(3);
|
|
|
|
create table t2 (b int, foreign key (b)
|
|
|
|
references t1 (a)
|
|
|
|
on update cascade) engine=InnoDB;
|
|
|
|
insert into t2 values (1),(2),(3);
|
|
|
|
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t2 add c int, algorithm=copy, lock=none;
|
|
|
|
alter table t2 add c int, algorithm=inplace, lock=none;
|
|
|
|
|
|
|
|
create or replace table t2 (b int, foreign key (b)
|
|
|
|
references t1 (a)
|
|
|
|
on delete set null) engine=InnoDB;
|
|
|
|
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t2 add c int, algorithm=copy, lock=none;
|
|
|
|
alter table t2 add c int, algorithm=inplace, lock=none;
|
|
|
|
|
|
|
|
create or replace table t2 (b int, foreign key (b)
|
|
|
|
references t1 (a)
|
|
|
|
on delete no action) engine=InnoDB;
|
|
|
|
|
|
|
|
insert into t2 values (1),(2),(3);
|
|
|
|
alter table t2 add c int, algorithm=copy, lock=none;
|
|
|
|
|
|
|
|
create or replace table t2 (b int, foreign key (b)
|
|
|
|
references t1 (a)
|
|
|
|
on update restrict) engine=InnoDB;
|
|
|
|
|
|
|
|
insert into t2 values (1),(2),(3);
|
|
|
|
alter table t2 add c int, algorithm=copy, lock=none;
|
|
|
|
drop table t2, t1;
|
|
|
|
|
|
|
|
create table t1 (a int primary key, b int unique) engine=InnoDB;
|
|
|
|
insert into t1 values (1, 1),(2, 2),(3, 3);
|
|
|
|
create table t2 (a int references t1 (a),
|
|
|
|
b int references t1 (b) on update cascade) engine=InnoDB;
|
|
|
|
insert into t2 values (1, 1),(2, 2);
|
|
|
|
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t2 add c int, algorithm=copy, lock=none;
|
|
|
|
alter table t2 add c int, algorithm=copy;
|
|
|
|
alter table t2 add d int, algorithm=inplace;
|
|
|
|
# Cleanup
|
|
|
|
drop table t2, t1;
|
2023-04-04 22:41:58 +02:00
|
|
|
|
|
|
|
--echo #
|
|
|
|
--echo # MDEV-30891 Assertion `!table->versioned(VERS_TRX_ID)' failed
|
|
|
|
--echo # in Write_rows_log_event::binlog_row_logging_function
|
|
|
|
--echo #
|
|
|
|
set system_versioning_alter_history= keep;
|
|
|
|
create table t1 (id int,
|
|
|
|
row_start bigint unsigned generated always as row start,
|
|
|
|
row_end bigint unsigned generated always as row end,
|
|
|
|
period for system_time (row_start, row_end))
|
|
|
|
engine=innodb with system versioning;
|
|
|
|
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t1 add c int, algorithm=copy, lock=none;
|
|
|
|
alter table t1 add c int, algorithm=inplace;
|
|
|
|
alter table t1 add d int, lock=none;
|
|
|
|
|
|
|
|
set system_versioning_alter_history= default;
|
|
|
|
drop table t1;
|
|
|
|
|
2023-07-04 20:16:31 +02:00
|
|
|
--echo #
|
|
|
|
--echo # MDEV-31058 ER_KEY_NOT_FOUND upon concurrent CHANGE column autoinc
|
|
|
|
--echo # and DML
|
|
|
|
--echo #
|
|
|
|
create table t (a serial, b int) engine=innodb;
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t drop a, modify b serial, algorithm=copy, lock=none;
|
|
|
|
|
|
|
|
set statement sql_mode= NO_AUTO_VALUE_ON_ZERO for
|
|
|
|
alter table t drop a, modify b serial, algorithm=copy, lock=none;
|
|
|
|
|
|
|
|
create or replace table t (a serial, b int) engine=innodb;
|
|
|
|
show create table t;
|
|
|
|
--echo # a is unique in the old table, but is shrunk in the new one.
|
|
|
|
--echo # Only unsafe approach is fine because of possible collisions.
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t modify a int, modify b serial, algorithm=copy, lock=none;
|
|
|
|
|
|
|
|
--echo #
|
|
|
|
--echo # Check that we treat autoinc columns correctly modify old autoinc is
|
|
|
|
--echo # fine, adding new autoinc for existed column is unsafe.
|
|
|
|
--echo #
|
|
|
|
create or replace table t (a serial) engine=innodb;
|
|
|
|
|
|
|
|
alter table t change a b serial, algorithm=copy, lock=none;
|
|
|
|
|
|
|
|
--echo # Shrinking the autoinc field is considered safe.
|
|
|
|
--echo # ER_WARN_DATA_OUT_OF_RANGE should be emitted otherwise.
|
|
|
|
alter table t change b b int auto_increment primary key,
|
|
|
|
algorithm=copy, lock=none;
|
|
|
|
|
|
|
|
alter table t add c int default(0), drop primary key, drop key a;
|
|
|
|
--echo # key `b` is still there
|
|
|
|
show create table t;
|
|
|
|
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t drop b, change c c serial, algorithm=copy, lock=none;
|
|
|
|
|
|
|
|
--echo # Check existed unique keys.
|
|
|
|
create or replace table t(a int, b int not null, c int not null, d int);
|
|
|
|
|
|
|
|
--echo # No unique in the old table;
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t add unique(b, c), modify d int auto_increment, add key(d),
|
|
|
|
algorithm=copy, lock=none;
|
|
|
|
|
|
|
|
alter table t add unique(a, b);
|
|
|
|
--echo # Unique in the old table has nulls;
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t modify d int auto_increment, add key(d),
|
|
|
|
algorithm=copy, lock=none;
|
|
|
|
|
|
|
|
alter table t add unique(b, c);
|
MDEV-30984 Online ALTER table is denied with non-informative error messages
Group all the checks in online_alter_check_supported().
There is now two groups of checks:
1. A technical availability of online, that is checked before open_tables,
and affects table_list->lock_type. It's supposed to be safe to make it
TL_READ even if COPY algorithm will fall back to not-online, since MDL is
SHARED_UPGRADEABLE anyway.
2. An 'online' availability for a COPY algorithm. It can be done as late as
just before the copy_data_between_tables call. The lock_type influence is
disclosed above, so the only other place it affects is
Alter_info::supports_lock, where `online` flag is only used to decide
whether to report the error at the inplace preparation stage. We'd want to
make that at the last resort, which is COPY preparation, if no algorithm is
chosen by the user. So it's event better now.
Some changes are required to the autoinc support detection, as the check
now happens after mysql_prepare_alter_table:
* alter_info->drop_list is empty
* instead, dropped columns are in tmp_set
* alter_info->create_list now has every field that's in the new table.
* the column definition's change.str will be nonnull whether the column
remains in the new table (vs whether it was changed, as before).
But it also has `field` field set.
* IF EXISTS doesn't have to be dealt anymore
This infers that the changes are now checked in more detail: a field's
definition shouldn't be changed, vs a field shouldn't be mentioned in
the CHANGE list, as it was before. This is reflected by the line 193 test.
2023-05-15 18:39:21 +02:00
|
|
|
--echo # Change unique's column;
|
2023-07-04 20:16:31 +02:00
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
MDEV-30984 Online ALTER table is denied with non-informative error messages
Group all the checks in online_alter_check_supported().
There is now two groups of checks:
1. A technical availability of online, that is checked before open_tables,
and affects table_list->lock_type. It's supposed to be safe to make it
TL_READ even if COPY algorithm will fall back to not-online, since MDL is
SHARED_UPGRADEABLE anyway.
2. An 'online' availability for a COPY algorithm. It can be done as late as
just before the copy_data_between_tables call. The lock_type influence is
disclosed above, so the only other place it affects is
Alter_info::supports_lock, where `online` flag is only used to decide
whether to report the error at the inplace preparation stage. We'd want to
make that at the last resort, which is COPY preparation, if no algorithm is
chosen by the user. So it's event better now.
Some changes are required to the autoinc support detection, as the check
now happens after mysql_prepare_alter_table:
* alter_info->drop_list is empty
* instead, dropped columns are in tmp_set
* alter_info->create_list now has every field that's in the new table.
* the column definition's change.str will be nonnull whether the column
remains in the new table (vs whether it was changed, as before).
But it also has `field` field set.
* IF EXISTS doesn't have to be dealt anymore
This infers that the changes are now checked in more detail: a field's
definition shouldn't be changed, vs a field shouldn't be mentioned in
the CHANGE list, as it was before. This is reflected by the line 193 test.
2023-05-15 18:39:21 +02:00
|
|
|
alter table t change b x bigint, modify d int auto_increment, add key(d),
|
2023-07-04 20:16:31 +02:00
|
|
|
algorithm=copy, lock=none;
|
|
|
|
|
MDEV-30984 Online ALTER table is denied with non-informative error messages
Group all the checks in online_alter_check_supported().
There is now two groups of checks:
1. A technical availability of online, that is checked before open_tables,
and affects table_list->lock_type. It's supposed to be safe to make it
TL_READ even if COPY algorithm will fall back to not-online, since MDL is
SHARED_UPGRADEABLE anyway.
2. An 'online' availability for a COPY algorithm. It can be done as late as
just before the copy_data_between_tables call. The lock_type influence is
disclosed above, so the only other place it affects is
Alter_info::supports_lock, where `online` flag is only used to decide
whether to report the error at the inplace preparation stage. We'd want to
make that at the last resort, which is COPY preparation, if no algorithm is
chosen by the user. So it's event better now.
Some changes are required to the autoinc support detection, as the check
now happens after mysql_prepare_alter_table:
* alter_info->drop_list is empty
* instead, dropped columns are in tmp_set
* alter_info->create_list now has every field that's in the new table.
* the column definition's change.str will be nonnull whether the column
remains in the new table (vs whether it was changed, as before).
But it also has `field` field set.
* IF EXISTS doesn't have to be dealt anymore
This infers that the changes are now checked in more detail: a field's
definition shouldn't be changed, vs a field shouldn't be mentioned in
the CHANGE list, as it was before. This is reflected by the line 193 test.
2023-05-15 18:39:21 +02:00
|
|
|
--echo # Finally good. Simple renames with a type unchanged will not affect
|
|
|
|
--echo # the result. Also NOT NULL -> NULL transform is fine.
|
|
|
|
alter table t modify d int auto_increment, add key(d),
|
|
|
|
change b x int null,
|
2023-07-04 20:16:31 +02:00
|
|
|
algorithm=copy, lock=none;
|
|
|
|
|
|
|
|
drop table t;
|
|
|
|
|
|
|
|
--echo # MDEV-31172 Server crash or ASAN errors in online_alter_check_autoinc
|
|
|
|
create table t (a int, b int, c char(8), key(a,b,c));
|
|
|
|
alter table t modify c int auto_increment key, algorithm=copy;
|
|
|
|
drop table t;
|
2023-07-04 20:14:27 +02:00
|
|
|
|
|
|
|
--echo # MDEV-31601 Some ALTER TABLE .. fail when they worked before, and with
|
|
|
|
--echo # a wrong error message
|
|
|
|
create table t (a int) engine=aria;
|
|
|
|
insert into t values (1),(2);
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED
|
|
|
|
alter table t algorithm=nocopy, order by a;
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED
|
|
|
|
alter table t engine=myisam, algorithm=inplace;
|
|
|
|
drop table t;
|
|
|
|
|
|
|
|
create temporary table t (f int);
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED
|
|
|
|
alter table t force, algorithm=instant;
|
|
|
|
drop table t;
|
2023-07-25 22:58:00 +02:00
|
|
|
|
|
|
|
create sequence s engine=MyISAM;
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table s engine=Aria, lock=none;
|
|
|
|
alter table s engine=Aria;
|
|
|
|
drop sequence s;
|
2023-07-27 13:26:32 +02:00
|
|
|
|
|
|
|
|
|
|
|
--echo # MDEV-31631 Adding auto-increment column to a table with history online
|
|
|
|
--echo # behaves differently from non-online
|
|
|
|
create sequence s;
|
|
|
|
create table t1(a int, x int NULL default(nextval(s)));
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t1 add b int default (nextval(s)), lock=none;
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t1 add b int primary key auto_increment, lock=none;
|
|
|
|
|
|
|
|
create table t2(a int, b int NULL default(nextval(s)));
|
|
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
|
|
alter table t2 modify b int not null default (nextval(s)), lock=none;
|
|
|
|
|
|
|
|
drop table t2;
|
|
|
|
drop table t1;
|
|
|
|
drop sequence s;
|
2024-02-03 06:40:06 +01:00
|
|
|
|
|
|
|
--echo #
|
|
|
|
--echo # MDEV-33348 ALTER TABLE lock waiting stages are indistinguishable
|
|
|
|
--echo #
|
2024-05-13 11:09:55 +02:00
|
|
|
--disable_view_protocol
|
|
|
|
--connect con2, localhost, root
|
2024-02-03 06:40:06 +01:00
|
|
|
|
2024-05-13 11:09:55 +02:00
|
|
|
create table t1 (a int);
|
2024-02-03 06:40:06 +01:00
|
|
|
insert t1 values (5);
|
|
|
|
|
2024-05-13 11:09:55 +02:00
|
|
|
start transaction;
|
2024-02-03 06:40:06 +01:00
|
|
|
select * from t1;
|
2024-05-13 11:09:55 +02:00
|
|
|
|
2024-02-03 06:40:06 +01:00
|
|
|
--connection default
|
|
|
|
--let $con= `select connection_id()`
|
|
|
|
send alter table t1 add b int NULL, algorithm= copy, lock= none;
|
|
|
|
|
|
|
|
--connection con2
|
2024-05-13 11:09:55 +02:00
|
|
|
evalp set @con= $con;
|
2024-02-03 06:40:06 +01:00
|
|
|
|
|
|
|
let $wait_condition= select stage = 4 and progress = 100
|
|
|
|
and state= "Waiting for table metadata lock"
|
|
|
|
from information_schema.processlist where id = @con;
|
|
|
|
--source include/wait_condition.inc
|
|
|
|
|
|
|
|
query_vertical select stage, state, info from information_schema.processlist where id = @con;
|
|
|
|
|
|
|
|
rollback;
|
|
|
|
|
|
|
|
--connection default
|
|
|
|
reap;
|
|
|
|
|
|
|
|
drop table t1;
|
|
|
|
--disconnect con2
|
2024-05-13 11:09:55 +02:00
|
|
|
--enable_view_protocol
|
2024-02-03 06:40:06 +01:00
|
|
|
|
2024-02-03 06:40:06 +01:00
|
|
|
|
|
|
|
--echo # MDEV-34164 Server crashes when executing OPTIMIZE or REPAIR TABLE for InnoDB temporary tables
|
|
|
|
create temporary table t1 (i int) engine=innodb;
|
|
|
|
create table t2 (i int) engine=aria ;
|
|
|
|
optimize table t1,t2;
|
|
|
|
drop table t1,t2;
|
|
|
|
|
|
|
|
create temporary table t1 (f int) engine=innodb;
|
|
|
|
create temporary table t2 (f int) engine=innodb;
|
|
|
|
optimize local table t1,t2;
|
|
|
|
drop table t1,t2;
|
|
|
|
|
|
|
|
set @save_sql_mode = @@sql_mode;
|
|
|
|
set sql_mode= '';
|
|
|
|
create temporary table t (c decimal zerofill,c2 int zerofill,c3 char binary,key(c)) engine=innodb;
|
|
|
|
insert into t values (1,1,1);
|
|
|
|
set session enforce_storage_engine=aria;
|
|
|
|
optimize no_write_to_binlog table t;
|
|
|
|
drop table t;
|
|
|
|
set sql_mode= @save_sql_mode;
|
|
|
|
|
2024-02-03 06:40:06 +01:00
|
|
|
--echo # End of 11.2 tests
|