2006-04-11 15:45:10 +02:00
/* Copyright (C) 2006 MySQL AB & MySQL Finland AB & TCX DataKonsult AB
This program is free software ; you can redistribute it and / or modify
it under the terms of the GNU General Public License as published by
2007-03-02 11:20:23 +01:00
the Free Software Foundation ; version 2 of the License .
2006-04-11 15:45:10 +02:00
This program is distributed in the hope that it will be useful ,
but WITHOUT ANY WARRANTY ; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the
GNU General Public License for more details .
You should have received a copy of the GNU General Public License
along with this program ; if not , write to the Free Software
Foundation , Inc . , 59 Temple Place , Suite 330 , Boston , MA 02111 - 1307 USA */
/* Describe, check and repair of MARIA tables */
2006-12-19 19:15:53 +01:00
/*
About checksum calculation .
There are two types of checksums . Table checksum and row checksum .
2007-07-02 19:45:15 +02:00
Row checksum is an additional uchar at the end of dynamic length
2006-12-19 19:15:53 +01:00
records . It must be calculated if the table is configured for them .
Otherwise they must not be used . The variable
MYISAM_SHARE : : calc_checksum determines if row checksums are used .
MI_INFO : : checksum is used as temporary storage during row handling .
For parallel repair we must assure that only one thread can use this
variable . There is no problem on the write side as this is done by one
thread only . But when checking a record after read this could go
wrong . But since all threads read through a common read buffer , it is
sufficient if only one thread checks it .
2007-07-02 19:45:15 +02:00
Table checksum is an eight uchar value in the header of the index file .
2006-12-19 19:15:53 +01:00
It can be calculated even if row checksums are not used . The variable
MI_CHECK : : glob_crc is calculated over all records .
MI_SORT_PARAM : : calc_checksum determines if this should be done . This
variable is not part of MI_CHECK because it must be set per thread for
parallel repair . The global glob_crc must be changed by one thread
only . And it is sufficient to calculate the checksum once only .
*/
2006-04-11 15:45:10 +02:00
# include "ma_ftdefs.h"
# include <myisamchk.h>
# include <stdarg.h>
# include <my_getopt.h>
# ifdef HAVE_SYS_VADVISE_H
# include <sys/vadvise.h>
# endif
# ifdef HAVE_SYS_MMAN_H
# include <sys/mman.h>
# endif
# include "ma_rt_index.h"
2007-01-18 20:38:14 +01:00
# include "ma_blockrec.h"
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
# include "trnman_public.h"
2006-04-11 15:45:10 +02:00
2007-01-18 20:38:14 +01:00
/* Functions defined in this file */
2006-04-11 15:45:10 +02:00
2007-01-18 20:38:14 +01:00
static int check_k_link ( HA_CHECK * param , MARIA_HA * info , my_off_t next_link ) ;
2006-04-11 15:45:10 +02:00
static int chk_index ( HA_CHECK * param , MARIA_HA * info , MARIA_KEYDEF * keyinfo ,
2007-07-02 19:45:15 +02:00
my_off_t page , uchar * buff , ha_rows * keys ,
2006-04-11 15:45:10 +02:00
ha_checksum * key_checksum , uint level ) ;
static uint isam_key_length ( MARIA_HA * info , MARIA_KEYDEF * keyinfo ) ;
static ha_checksum calc_checksum ( ha_rows count ) ;
2006-12-19 19:15:53 +01:00
static int writekeys ( MARIA_SORT_PARAM * sort_param ) ;
2007-01-18 20:38:14 +01:00
static int sort_one_index ( HA_CHECK * param , MARIA_HA * info ,
MARIA_KEYDEF * keyinfo ,
2006-04-11 15:45:10 +02:00
my_off_t pagepos , File new_file ) ;
2007-07-02 19:45:15 +02:00
static int sort_key_read ( MARIA_SORT_PARAM * sort_param , uchar * key ) ;
static int sort_maria_ft_key_read ( MARIA_SORT_PARAM * sort_param , uchar * key ) ;
2006-04-11 15:45:10 +02:00
static int sort_get_next_record ( MARIA_SORT_PARAM * sort_param ) ;
2007-01-18 20:38:14 +01:00
static int sort_key_cmp ( MARIA_SORT_PARAM * sort_param , const void * a ,
const void * b ) ;
static int sort_maria_ft_key_write ( MARIA_SORT_PARAM * sort_param ,
2007-07-02 19:45:15 +02:00
const uchar * a ) ;
static int sort_key_write ( MARIA_SORT_PARAM * sort_param , const uchar * a ) ;
2006-04-11 15:45:10 +02:00
static my_off_t get_record_for_key ( MARIA_HA * info , MARIA_KEYDEF * keyinfo ,
2007-07-02 19:45:15 +02:00
const uchar * key ) ;
2006-04-11 15:45:10 +02:00
static int sort_insert_key ( MARIA_SORT_PARAM * sort_param ,
reg1 SORT_KEY_BLOCKS * key_block ,
2007-07-02 19:45:15 +02:00
const uchar * key , my_off_t prev_block ) ;
2006-04-11 15:45:10 +02:00
static int sort_delete_record ( MARIA_SORT_PARAM * sort_param ) ;
/*static int _ma_flush_pending_blocks(HA_CHECK *param);*/
static SORT_KEY_BLOCKS * alloc_key_blocks ( HA_CHECK * param , uint blocks ,
uint buffer_length ) ;
2007-07-02 19:45:15 +02:00
static ha_checksum maria_byte_checksum ( const uchar * buf , uint length ) ;
2006-04-11 15:45:10 +02:00
static void set_data_file_type ( MARIA_SORT_INFO * sort_info , MARIA_SHARE * share ) ;
2007-01-18 20:38:14 +01:00
static void restore_data_file_type ( MARIA_SHARE * share ) ;
2007-07-01 15:20:57 +02:00
static void change_data_file_descriptor ( MARIA_HA * info , File new_file ) ;
static int _ma_safe_scan_block_record ( MARIA_SORT_INFO * sort_info ,
Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-maria
into a88-113-38-195.elisa-laajakaista.fi:/home/my/bk/mysql-maria.prod
BitKeeper/etc/ignore:
auto-union
include/maria.h:
Auto merged
include/my_base.h:
Auto merged
mysql-test/include/ps_conv.inc:
Auto merged
mysql-test/r/ps_2myisam.result:
Auto merged
mysql-test/r/ps_3innodb.result:
Auto merged
mysql-test/r/ps_4heap.result:
Auto merged
mysql-test/r/ps_5merge.result:
Auto merged
mysql-test/r/ps_7ndb.result:
Auto merged
mysys/Makefile.am:
Auto merged
mysys/mf_iocache.c:
Auto merged
mysys/mf_tempfile.c:
Auto merged
mysys/my_error.c:
Auto merged
mysys/my_init.c:
Auto merged
mysys/my_open.c:
Auto merged
sql/handler.cc:
Auto merged
sql/handler.h:
Auto merged
sql/lex.h:
Auto merged
sql/sql_show.cc:
Auto merged
sql/sql_yacc.yy:
Auto merged
sql/table.cc:
Auto merged
sql/table.h:
Auto merged
storage/maria/ha_maria.cc:
Auto merged
storage/maria/ha_maria.h:
Auto merged
storage/maria/ma_bitmap.c:
Auto merged
storage/maria/ma_blockrec.h:
Auto merged
storage/maria/ma_create.c:
Auto merged
storage/maria/ma_dynrec.c:
Auto merged
storage/maria/ma_loghandler.h:
Auto merged
storage/maria/ma_loghandler_lsn.h:
Auto merged
storage/maria/ma_open.c:
Auto merged
storage/maria/ma_pagecache.c:
Auto merged
storage/maria/ma_pagecache.h:
Auto merged
storage/maria/ma_test1.c:
Auto merged
storage/maria/ma_test2.c:
Auto merged
storage/maria/ma_update.c:
Auto merged
storage/maria/maria_chk.c:
Auto merged
storage/maria/unittest/ma_test_loghandler-t.c:
Auto merged
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
Auto merged
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
Auto merged
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
Auto merged
storage/myisam/ft_stopwords.c:
Auto merged
storage/myisam/mi_close.c:
Auto merged
support-files/compiler_warnings.supp:
Auto merged
mysys/mf_keycache.c:
Pulled from mysql-maria tree, manual merge.
mysys/my_handler.c:
Pulled from mysql-maria tree, manual merge.
mysys/my_symlink2.c:
Pulled from mysql-maria tree, manual merge.
sql/mysqld.cc:
Pulled from mysql-maria tree, manual merge.
sql/sql_table.cc:
Pulled from mysql-maria tree, manual merge.
storage/maria/ma_blockrec.c:
Pulled from mysql-maria tree, manual merge.
storage/maria/ma_check.c:
Pulled from mysql-maria tree, manual merge.
storage/maria/ma_close.c:
Pulled from mysql-maria tree, manual merge.
storage/maria/ma_loghandler.c:
Pulled from mysql-maria tree, manual merge.
storage/maria/maria_def.h:
Pulled from mysql-maria tree, manual merge.
2007-07-04 11:20:53 +02:00
MARIA_HA * info , uchar * record ) ;
2007-07-01 15:20:57 +02:00
static void copy_data_file_state ( MARIA_STATE_INFO * to ,
MARIA_STATE_INFO * from ) ;
Maria:
* Don't modify share->base.born_transactional; now it is a value carved
in stone at creation time. share->now_transactional is what can be
modified: it starts at born_transactional, can become false during
ALTER TABLE (when we want no logging), and restored later.
* Not resetting create_rename_lsn to 0 during delete_all or repair.
* when we temporarily disable transactionality, we also change
the page type to PAGECACHE_PLAIN_PAGE: it bypasses some work in the
page cache (optimization), and avoids assertions related to LSNs.
* Disable INSERT DELAYED for transactional tables, because
durability could not be guaranteed (insertion may even not happen)
mysys/mf_keycache.c:
comment
storage/maria/ha_maria.cc:
* a transactional table cannot do INSERT DELAYED
* ha_maria::save_transactional not needed anymore, as now instead
we don't modify MARIA_SHARE::MARIA_BASE_INFO::born_transactional
(born_transactional plays the role of save_transactional), and modify
MARIA_SHARE::now_transactional.
* REPAIR_TABLE log record is now logged by maria_repair()
* comment why we rely on born_transactional to know if we should
skipping a transaction.
* putting together two if()s which test for F_UNLCK
storage/maria/ha_maria.h:
ha_maria::save_transactional not needed anymore (moved to the C layer)
storage/maria/ma_blockrec.c:
* For the block record's code (writing/updating/deleting records),
all that counts is now_transactional, not born_transactional.
* As we now set the page type to PAGECACHE_PLAIN_PAGE for tables
which have now_transactional==FALSE, pagecache will not expect
a meaningful LSN for them in pagecache_unlock_by_link(), so
we can pass it LSN_IMPOSSIBLE.
storage/maria/ma_check.c:
* writing LOGREC_REPAIR_TABLE moves from ha_maria::repair()
to maria_repair(), sounds cleaner (less functions to export).
* when opening a table during REPAIR, don't use the realpath-ed name,
as this may fail if the table has symlinked files (maria_open()
would try to find the data and index file in the directory
of unique_file_name, it would fail if data and index files are in
different dirs); use the unresolved name, open_file_name, which is
the argument which was passed to the maria_open() which created 'info'.
storage/maria/ma_close.c:
assert that when a statement is done with a table, it cleans up
storage/maria/ma_create.c:
new name
storage/maria/ma_delete_all.c:
* using now_transactional
* no reason to reset create_rename_lsn during delete_all (a bug);
also no reason to do it during repair: it was put there because
a positive create_rename_lsn caused a call to check_and_set_lsn()
which asserted in DBUG_ASSERT(block->type == PAGECACHE_LSN_PAGE);
first solution was to use LSN_IMPOSSIBLE in _ma_unpin_all_pages() if
not transactional; but then in the case of ALTER TABLE, with
transactionality temporarily disabled, it asserted in
DBUG_ASSERT(LSN_VALID(lsn)) in pagecache_fwrite() (PAGECACHE_LSN_PAGE
page with zero LSN - bad). The additional solution is to use
PAGECACHE_PLAIN_PAGE when we disable transactionality temporarily: this
avoids checks on the LSN, and also bypasses (optimization) the "flush
log up to LSN" call when the pagecache flushes our page (in other
words, no WAL needed).
storage/maria/ma_delete_table.c:
use now_transactional
storage/maria/ma_locking.c:
assert that when a statement is done with a table, it cleans up.
storage/maria/ma_loghandler.c:
* now_transactional should be used to test if we want a log record.
* Assertions to make sure dummy_transaction_object is not spoilt
by its many users.
storage/maria/ma_open.c:
base.transactional -> base.born_transactional
storage/maria/ma_pagecache.c:
missing name for page's type. Comment for future.
storage/maria/ma_rename.c:
use now_transactional
storage/maria/maria_chk.c:
use born_transactional
storage/maria/maria_def.h:
MARIA_BASE_INFO::transactional renamed to born_transactional.
MARIA_SHARE::now_transactional introduced.
_ma_repair_write_log_record() is made local to ma_check.c.
Macros to temporarily disable, and re-enable, transactionality for a
table.
storage/maria/maria_read_log.c:
assertions and using the new macros. Adding a forgotten resetting
when we finally close all tables.
2007-07-03 15:20:41 +02:00
static int write_log_record_for_repair ( const HA_CHECK * param , MARIA_HA * info ) ;
2007-07-01 15:20:57 +02:00
2006-04-11 15:45:10 +02:00
2007-01-18 20:38:14 +01:00
void maria_chk_init ( HA_CHECK * param )
2006-04-11 15:45:10 +02:00
{
2007-07-02 19:45:15 +02:00
bzero ( ( uchar * ) param , sizeof ( * param ) ) ;
2006-04-11 15:45:10 +02:00
param - > opt_follow_links = 1 ;
param - > keys_in_use = ~ ( ulonglong ) 0 ;
param - > search_after_block = HA_OFFSET_ERROR ;
param - > auto_increment_value = 0 ;
param - > use_buffers = USE_BUFFER_INIT ;
param - > read_buffer_length = READ_BUFFER_INIT ;
param - > write_buffer_length = READ_BUFFER_INIT ;
param - > sort_buffer_length = SORT_BUFFER_INIT ;
param - > sort_key_blocks = BUFFERS_WHEN_SORTING ;
param - > tmpfile_createflag = O_RDWR | O_TRUNC | O_EXCL ;
param - > myf_rw = MYF ( MY_NABP | MY_WME | MY_WAIT_IF_FULL ) ;
param - > start_check_pos = 0 ;
param - > max_record_length = LONGLONG_MAX ;
2007-04-04 22:37:09 +02:00
param - > pagecache_block_size = KEY_CACHE_BLOCK_SIZE ;
2006-04-11 15:45:10 +02:00
param - > stats_method = MI_STATS_METHOD_NULLS_NOT_EQUAL ;
}
/* Check the status flags for the table */
int maria_chk_status ( HA_CHECK * param , register MARIA_HA * info )
{
MARIA_SHARE * share = info - > s ;
if ( maria_is_crashed_on_repair ( info ) )
_ma_check_print_warning ( param ,
" Table is marked as crashed and last repair failed " ) ;
else if ( maria_is_crashed ( info ) )
_ma_check_print_warning ( param ,
" Table is marked as crashed " ) ;
if ( share - > state . open_count ! = ( uint ) ( info - > s - > global_changed ? 1 : 0 ) )
{
/* Don't count this as a real warning, as check can correct this ! */
uint save = param - > warning_printed ;
_ma_check_print_warning ( param ,
share - > state . open_count = = 1 ?
" %d client is using or hasn't closed the table properly " :
" %d clients are using or haven't closed the table properly " ,
share - > state . open_count ) ;
/* If this will be fixed by the check, forget the warning */
if ( param - > testflag & T_UPDATE_STATE )
param - > warning_printed = save ;
}
return 0 ;
}
2007-04-05 13:38:05 +02:00
/*
Check delete links in row data
*/
2006-04-11 15:45:10 +02:00
int maria_chk_del ( HA_CHECK * param , register MARIA_HA * info , uint test_flag )
{
reg2 ha_rows i ;
uint delete_link_length ;
my_off_t empty , next_link , old_link ;
char buff [ 22 ] , buff2 [ 22 ] ;
DBUG_ENTER ( " maria_chk_del " ) ;
LINT_INIT ( old_link ) ;
2007-04-05 13:38:05 +02:00
if ( info - > s - > data_file_type = = BLOCK_RECORD )
DBUG_RETURN ( 0 ) ; /* No delete links here */
2006-04-11 15:45:10 +02:00
param - > record_checksum = 0 ;
delete_link_length = ( ( info - > s - > options & HA_OPTION_PACK_RECORD ) ? 20 :
info - > s - > rec_reflength + 1 ) ;
if ( ! ( test_flag & T_SILENT ) )
puts ( " - check record delete-chain " ) ;
next_link = info - > s - > state . dellink ;
if ( info - > state - > del = = 0 )
{
if ( test_flag & T_VERBOSE )
{
puts ( " No recordlinks " ) ;
}
}
else
{
if ( test_flag & T_VERBOSE )
printf ( " Recordlinks: " ) ;
empty = 0 ;
for ( i = info - > state - > del ; i > 0L & & next_link ! = HA_OFFSET_ERROR ; i - - )
{
if ( * _ma_killed_ptr ( param ) )
DBUG_RETURN ( 1 ) ;
if ( test_flag & T_VERBOSE )
printf ( " %9s " , llstr ( next_link , buff ) ) ;
if ( next_link > = info - > state - > data_file_length )
goto wrong ;
2007-04-04 22:37:09 +02:00
if ( my_pread ( info - > dfile . file , ( char * ) buff , delete_link_length ,
2006-04-11 15:45:10 +02:00
next_link , MYF ( MY_NABP ) ) )
{
if ( test_flag & T_VERBOSE ) puts ( " " ) ;
_ma_check_print_error ( param , " Can't read delete-link at filepos: %s " ,
llstr ( next_link , buff ) ) ;
DBUG_RETURN ( 1 ) ;
}
if ( * buff ! = ' \0 ' )
{
if ( test_flag & T_VERBOSE ) puts ( " " ) ;
_ma_check_print_error ( param , " Record at pos: %s is not remove-marked " ,
llstr ( next_link , buff ) ) ;
goto wrong ;
}
if ( info - > s - > options & HA_OPTION_PACK_RECORD )
{
my_off_t prev_link = mi_sizekorr ( buff + 12 ) ;
if ( empty & & prev_link ! = old_link )
{
if ( test_flag & T_VERBOSE ) puts ( " " ) ;
_ma_check_print_error ( param , " Deleted block at %s doesn't point back at previous delete link " , llstr ( next_link , buff2 ) ) ;
goto wrong ;
}
old_link = next_link ;
next_link = mi_sizekorr ( buff + 4 ) ;
empty + = mi_uint3korr ( buff + 1 ) ;
}
else
{
param - > record_checksum + = ( ha_checksum ) next_link ;
2007-01-18 20:38:14 +01:00
next_link = _ma_rec_pos ( info - > s , buff + 1 ) ;
2006-04-11 15:45:10 +02:00
empty + = info - > s - > base . pack_reclength ;
}
}
if ( test_flag & T_VERBOSE )
puts ( " \n " ) ;
if ( empty ! = info - > state - > empty )
{
_ma_check_print_warning ( param ,
" Found %s deleted space in delete link chain. Should be %s " ,
llstr ( empty , buff2 ) ,
llstr ( info - > state - > empty , buff ) ) ;
}
if ( next_link ! = HA_OFFSET_ERROR )
{
_ma_check_print_error ( param ,
" Found more than the expected %s deleted rows in delete link chain " ,
llstr ( info - > state - > del , buff ) ) ;
goto wrong ;
}
if ( i ! = 0 )
{
_ma_check_print_error ( param ,
" Found %s deleted rows in delete link chain. Should be %s " ,
llstr ( info - > state - > del - i , buff2 ) ,
llstr ( info - > state - > del , buff ) ) ;
goto wrong ;
}
}
DBUG_RETURN ( 0 ) ;
wrong :
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
if ( test_flag & T_VERBOSE ) puts ( " " ) ;
_ma_check_print_error ( param , " record delete-link-chain corrupted " ) ;
DBUG_RETURN ( 1 ) ;
} /* maria_chk_del */
/* Check delete links in index file */
2007-01-18 20:38:14 +01:00
static int check_k_link ( HA_CHECK * param , register MARIA_HA * info ,
my_off_t next_link )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
uint block_size = info - > s - > block_size ;
2006-04-11 15:45:10 +02:00
ha_rows records ;
2006-10-30 12:44:33 +01:00
char llbuff [ 21 ] , llbuff2 [ 21 ] , * buff ;
2006-04-11 15:45:10 +02:00
DBUG_ENTER ( " check_k_link " ) ;
records = ( ha_rows ) ( info - > state - > key_file_length / block_size ) ;
while ( next_link ! = HA_OFFSET_ERROR & & records > 0 )
{
if ( * _ma_killed_ptr ( param ) )
DBUG_RETURN ( 1 ) ;
if ( param - > testflag & T_VERBOSE )
printf ( " %16s " , llstr ( next_link , llbuff ) ) ;
2006-10-30 12:44:33 +01:00
/* Key blocks must lay within the key file length entirely. */
if ( next_link + block_size > info - > state - > key_file_length )
{
/* purecov: begin tested */
_ma_check_print_error ( param , " Invalid key block position: %s "
" key block size: %u file_length: %s " ,
llstr ( next_link , llbuff ) , block_size ,
llstr ( info - > state - > key_file_length , llbuff2 ) ) ;
DBUG_RETURN ( 1 ) ;
/* purecov: end */
}
2007-01-23 20:13:26 +01:00
/* Key blocks must be aligned at block_size */
if ( next_link & ( block_size - 1 ) )
2006-10-30 12:44:33 +01:00
{
/* purecov: begin tested */
_ma_check_print_error ( param , " Mis-aligned key block: %s "
" minimum key block length: %u " ,
2007-01-23 20:13:26 +01:00
llstr ( next_link , llbuff ) ,
block_size ) ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 1 ) ;
2006-10-30 12:44:33 +01:00
/* purecov: end */
}
2007-01-23 20:13:26 +01:00
2007-04-04 22:37:09 +02:00
DBUG_ASSERT ( info - > s - > pagecache - > block_size = = block_size ) ;
if ( ! ( buff = pagecache_read ( info - > s - > pagecache ,
& info - > s - > kfile , next_link / block_size ,
DFLT_INIT_HITS ,
2007-07-02 19:45:15 +02:00
( uchar * ) info - > buff ,
2007-04-04 22:37:09 +02:00
PAGECACHE_PLAIN_PAGE ,
PAGECACHE_LOCK_LEFT_UNLOCKED , 0 ) ) )
2006-10-30 12:44:33 +01:00
{
/* purecov: begin tested */
_ma_check_print_error ( param , " key cache read error for block: %s " ,
llstr ( next_link , llbuff ) ) ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 1 ) ;
2006-10-30 12:44:33 +01:00
/* purecov: end */
}
2006-04-11 15:45:10 +02:00
next_link = mi_sizekorr ( buff ) ;
records - - ;
param - > key_file_blocks + = block_size ;
}
if ( param - > testflag & T_VERBOSE )
{
if ( next_link ! = HA_OFFSET_ERROR )
printf ( " %16s \n " , llstr ( next_link , llbuff ) ) ;
else
puts ( " " ) ;
}
DBUG_RETURN ( next_link ! = HA_OFFSET_ERROR ) ;
} /* check_k_link */
/* Check sizes of files */
int maria_chk_size ( HA_CHECK * param , register MARIA_HA * info )
{
Fix for errors during:
"./mtr --mysqld=--default-storage-engine=maria mysqldump".
First problem was use of INSERT DELAYED and MERGE tables without
specifying that the tables to create should always be MyISAM.
After fixing this, no rows were returned by the final SELECT of the
"BUG 19025" portion of the test. Simplified problem was:
LOCK TABLES `t1` WRITE;
/*!40000 ALTER TABLE `t1` DISABLE KEYS */;
INSERT INTO `t1` VALUES ('bla',1000),('bla',1001),('bla',1002);
/*!40000 ALTER TABLE `t1` ENABLE KEYS */;
UNLOCK TABLES;
select * from t1;
The SELECT would find no rows. Reason: ENABLE KEYS does a maria_repair();
but data pages are still in the page cache and not on disk (because
they were not flushed because maria_lock_database(F_UNLCK) was
not called at the end of INSERT because under LOCK TABLES).
At start of maria_repair(), sort_info.filelength is set to the
physical size of the data file (=> too small because pages are in
cache and not on disk).
Then in sort_get_next_record(), when seeing end-of-file, this is done:
sort_param->max_pos= sort_info->filelength;
Further in maria_repair(), this is done:
info->state->data_file_length= sort_param.max_pos;
and so data_file_length is smaller (0) than reality (16384).
This makes SELECT think EOF is where it is not, and thus find
no rows.
This is fixed by flushing all data pages at the start of maria_repair()
(no performance problem is introduced as in common cases where
ALTER TABLE is not under LOCK TABLES, the previous statement did
this flush anyway).
Another reason to do this flush is that, if not doing it, old cached
pages might go down onto the repaired data file at a later point
and thus corrupt it (assume a REPAIR non-QUICK).
A similar bug is fixed:
LOCK TABLES WRITE; INSERT; CHECK TABLE;
reports "Size of datafile is: 0 Should be: 16384"
again because the physical size was read without a preliminary
page cache flush.
mysql-test/r/maria.result:
result update
mysql-test/r/mysqldump.result:
result update
mysql-test/t/maria.test:
adding test for fixed bug in LOCK TABLES + CHECK TABLE + block format.
Disabling portion which hits "incorrect key file" but still
letting it make the test fail (Monty to fix).
mysql-test/t/mysqldump.test:
in places where test expects engine to support INSERT DELAYED and
be includable in a MERGE table, i.e. be MyISAM, we explicitely
ask for MyISAM.
storage/maria/ma_check.c:
Before reading the data file's physical size with my_seek(MY_SEEK_END)
during maria_chk_size() and maria_repair(), we must flush this
data file, otherwise physical size is misleading and leads to
- CHECK TABLE finding the table corrupted ("size of datafile should be"
error)
- ALTER TABLE ENABLE KEYS losing rows (maria_repair()
setting data_file_length to a too small value => later SELECT does
not find rows though they are in the data file).
This fixes the "mysqldump.test" failure.
sort_info.filelength contains the physical size, re-using it.
2007-08-07 18:23:49 +02:00
int error ;
2006-04-11 15:45:10 +02:00
register my_off_t skr , size ;
char buff [ 22 ] , buff2 [ 22 ] ;
DBUG_ENTER ( " maria_chk_size " ) ;
2007-01-18 20:38:14 +01:00
if ( ! ( param - > testflag & T_SILENT ) )
puts ( " - check file-size " ) ;
2006-04-11 15:45:10 +02:00
Fix for errors during:
"./mtr --mysqld=--default-storage-engine=maria mysqldump".
First problem was use of INSERT DELAYED and MERGE tables without
specifying that the tables to create should always be MyISAM.
After fixing this, no rows were returned by the final SELECT of the
"BUG 19025" portion of the test. Simplified problem was:
LOCK TABLES `t1` WRITE;
/*!40000 ALTER TABLE `t1` DISABLE KEYS */;
INSERT INTO `t1` VALUES ('bla',1000),('bla',1001),('bla',1002);
/*!40000 ALTER TABLE `t1` ENABLE KEYS */;
UNLOCK TABLES;
select * from t1;
The SELECT would find no rows. Reason: ENABLE KEYS does a maria_repair();
but data pages are still in the page cache and not on disk (because
they were not flushed because maria_lock_database(F_UNLCK) was
not called at the end of INSERT because under LOCK TABLES).
At start of maria_repair(), sort_info.filelength is set to the
physical size of the data file (=> too small because pages are in
cache and not on disk).
Then in sort_get_next_record(), when seeing end-of-file, this is done:
sort_param->max_pos= sort_info->filelength;
Further in maria_repair(), this is done:
info->state->data_file_length= sort_param.max_pos;
and so data_file_length is smaller (0) than reality (16384).
This makes SELECT think EOF is where it is not, and thus find
no rows.
This is fixed by flushing all data pages at the start of maria_repair()
(no performance problem is introduced as in common cases where
ALTER TABLE is not under LOCK TABLES, the previous statement did
this flush anyway).
Another reason to do this flush is that, if not doing it, old cached
pages might go down onto the repaired data file at a later point
and thus corrupt it (assume a REPAIR non-QUICK).
A similar bug is fixed:
LOCK TABLES WRITE; INSERT; CHECK TABLE;
reports "Size of datafile is: 0 Should be: 16384"
again because the physical size was read without a preliminary
page cache flush.
mysql-test/r/maria.result:
result update
mysql-test/r/mysqldump.result:
result update
mysql-test/t/maria.test:
adding test for fixed bug in LOCK TABLES + CHECK TABLE + block format.
Disabling portion which hits "incorrect key file" but still
letting it make the test fail (Monty to fix).
mysql-test/t/mysqldump.test:
in places where test expects engine to support INSERT DELAYED and
be includable in a MERGE table, i.e. be MyISAM, we explicitely
ask for MyISAM.
storage/maria/ma_check.c:
Before reading the data file's physical size with my_seek(MY_SEEK_END)
during maria_chk_size() and maria_repair(), we must flush this
data file, otherwise physical size is misleading and leads to
- CHECK TABLE finding the table corrupted ("size of datafile should be"
error)
- ALTER TABLE ENABLE KEYS losing rows (maria_repair()
setting data_file_length to a too small value => later SELECT does
not find rows though they are in the data file).
This fixes the "mysqldump.test" failure.
sort_info.filelength contains the physical size, re-using it.
2007-08-07 18:23:49 +02:00
/*
The following is needed if called externally ( not from maria_chk ) .
To get a correct physical size we need to flush them .
*/
if ( ( error = _ma_flush_table_files ( info ,
MARIA_FLUSH_DATA | MARIA_FLUSH_INDEX ,
FLUSH_FORCE_WRITE , FLUSH_FORCE_WRITE ) ) )
_ma_check_print_error ( param , " Failed to flush data or index file " ) ;
2006-04-11 15:45:10 +02:00
2007-07-27 12:06:39 +02:00
size = my_seek ( info - > s - > kfile . file , 0L , MY_SEEK_END , MYF ( MY_THREADSAFE ) ) ;
2006-04-11 15:45:10 +02:00
if ( ( skr = ( my_off_t ) info - > state - > key_file_length ) ! = size )
{
/* Don't give error if file generated by mariapack */
if ( skr > size & & maria_is_any_key_active ( info - > s - > state . key_map ) )
{
error = 1 ;
_ma_check_print_error ( param ,
" Size of indexfile is: %-8s Should be: %s " ,
llstr ( size , buff ) , llstr ( skr , buff2 ) ) ;
}
2007-01-18 20:38:14 +01:00
else if ( ! ( param - > testflag & T_VERY_SILENT ) )
2006-04-11 15:45:10 +02:00
_ma_check_print_warning ( param ,
" Size of indexfile is: %-8s Should be: %s " ,
llstr ( size , buff ) , llstr ( skr , buff2 ) ) ;
}
if ( ! ( param - > testflag & T_VERY_SILENT ) & &
! ( info - > s - > options & HA_OPTION_COMPRESS_RECORD ) & &
ulonglong2double ( info - > state - > key_file_length ) >
ulonglong2double ( info - > s - > base . margin_key_file_length ) * 0.9 )
_ma_check_print_warning ( param , " Keyfile is almost full, %10s of %10s used " ,
llstr ( info - > state - > key_file_length , buff ) ,
llstr ( info - > s - > base . max_key_file_length - 1 , buff ) ) ;
2007-04-04 22:37:09 +02:00
size = my_seek ( info - > dfile . file , 0L , MY_SEEK_END , MYF ( 0 ) ) ;
2006-04-11 15:45:10 +02:00
skr = ( my_off_t ) info - > state - > data_file_length ;
if ( info - > s - > options & HA_OPTION_COMPRESS_RECORD )
skr + = MEMMAP_EXTRA_MARGIN ;
# ifdef USE_RELOC
if ( info - > data_file_type = = STATIC_RECORD & &
skr < ( my_off_t ) info - > s - > base . reloc * info - > s - > base . min_pack_length )
skr = ( my_off_t ) info - > s - > base . reloc * info - > s - > base . min_pack_length ;
# endif
if ( skr ! = size )
{
info - > state - > data_file_length = size ; /* Skip other errors */
if ( skr > size & & skr ! = size + MEMMAP_EXTRA_MARGIN )
{
error = 1 ;
_ma_check_print_error ( param , " Size of datafile is: %-9s Should be: %s " ,
llstr ( size , buff ) , llstr ( skr , buff2 ) ) ;
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
}
else
{
_ma_check_print_warning ( param ,
" Size of datafile is: %-9s Should be: %s " ,
llstr ( size , buff ) , llstr ( skr , buff2 ) ) ;
}
}
if ( ! ( param - > testflag & T_VERY_SILENT ) & &
! ( info - > s - > options & HA_OPTION_COMPRESS_RECORD ) & &
ulonglong2double ( info - > state - > data_file_length ) >
( ulonglong2double ( info - > s - > base . max_data_file_length ) * 0.9 ) )
_ma_check_print_warning ( param , " Datafile is almost full, %10s of %10s used " ,
llstr ( info - > state - > data_file_length , buff ) ,
llstr ( info - > s - > base . max_data_file_length - 1 , buff2 ) ) ;
DBUG_RETURN ( error ) ;
} /* maria_chk_size */
2007-01-18 20:38:14 +01:00
/* Check keys */
2006-04-11 15:45:10 +02:00
int maria_chk_key ( HA_CHECK * param , register MARIA_HA * info )
{
uint key , found_keys = 0 , full_text_keys = 0 , result = 0 ;
ha_rows keys ;
ha_checksum old_record_checksum , init_checksum ;
my_off_t all_keydata , all_totaldata , key_totlength , length ;
ulong * rec_per_key_part ;
MARIA_SHARE * share = info - > s ;
MARIA_KEYDEF * keyinfo ;
char buff [ 22 ] , buff2 [ 22 ] ;
DBUG_ENTER ( " maria_chk_key " ) ;
if ( ! ( param - > testflag & T_SILENT ) )
puts ( " - check key delete-chain " ) ;
param - > key_file_blocks = info - > s - > base . keystart ;
2007-01-18 20:38:14 +01:00
if ( check_k_link ( param , info , info - > s - > state . key_del ) )
{
if ( param - > testflag & T_VERBOSE ) puts ( " " ) ;
_ma_check_print_error ( param , " key delete-link-chain corrupted " ) ;
DBUG_RETURN ( - 1 ) ;
}
2006-04-11 15:45:10 +02:00
if ( ! ( param - > testflag & T_SILENT ) ) puts ( " - check index reference " ) ;
all_keydata = all_totaldata = key_totlength = 0 ;
old_record_checksum = 0 ;
init_checksum = param - > record_checksum ;
2007-01-18 20:38:14 +01:00
if ( share - > data_file_type = = STATIC_RECORD )
old_record_checksum = ( calc_checksum ( info - > state - > records +
info - > state - > del - 1 ) *
share - > base . pack_reclength ) ;
2006-04-11 15:45:10 +02:00
rec_per_key_part = param - > rec_per_key_part ;
for ( key = 0 , keyinfo = & share - > keyinfo [ 0 ] ; key < share - > base . keys ;
rec_per_key_part + = keyinfo - > keysegs , key + + , keyinfo + + )
{
param - > key_crc [ key ] = 0 ;
if ( ! maria_is_key_active ( share - > state . key_map , key ) )
{
/* Remember old statistics for key */
memcpy ( ( char * ) rec_per_key_part ,
( char * ) ( share - > state . rec_per_key_part +
( uint ) ( rec_per_key_part - param - > rec_per_key_part ) ) ,
keyinfo - > keysegs * sizeof ( * rec_per_key_part ) ) ;
continue ;
}
found_keys + + ;
param - > record_checksum = init_checksum ;
bzero ( ( char * ) & param - > unique_count , sizeof ( param - > unique_count ) ) ;
bzero ( ( char * ) & param - > notnull_count , sizeof ( param - > notnull_count ) ) ;
if ( ( ! ( param - > testflag & T_SILENT ) ) )
printf ( " - check data record references index: %d \n " , key + 1 ) ;
if ( keyinfo - > flag & HA_FULLTEXT )
full_text_keys + + ;
if ( share - > state . key_root [ key ] = = HA_OFFSET_ERROR & &
( info - > state - > records = = 0 | | keyinfo - > flag & HA_FULLTEXT ) )
goto do_stat ;
if ( ! _ma_fetch_keypage ( info , keyinfo , share - > state . key_root [ key ] ,
DFLT_INIT_HITS , info - > buff , 0 ) )
{
_ma_check_print_error ( param , " Can't read indexpage from filepos: %s " ,
llstr ( share - > state . key_root [ key ] , buff ) ) ;
if ( ! ( param - > testflag & T_INFO ) )
DBUG_RETURN ( - 1 ) ;
result = - 1 ;
continue ;
}
param - > key_file_blocks + = keyinfo - > block_length ;
keys = 0 ;
param - > keydata = param - > totaldata = 0 ;
param - > key_blocks = 0 ;
param - > max_level = 0 ;
if ( chk_index ( param , info , keyinfo , share - > state . key_root [ key ] , info - > buff ,
& keys , param - > key_crc + key , 1 ) )
DBUG_RETURN ( - 1 ) ;
if ( ! ( keyinfo - > flag & ( HA_FULLTEXT | HA_SPATIAL ) ) )
{
if ( keys ! = info - > state - > records )
{
_ma_check_print_error ( param , " Found %s keys of %s " , llstr ( keys , buff ) ,
llstr ( info - > state - > records , buff2 ) ) ;
if ( ! ( param - > testflag & T_INFO ) )
DBUG_RETURN ( - 1 ) ;
result = - 1 ;
continue ;
}
2007-01-18 20:38:14 +01:00
if ( ( found_keys - full_text_keys = = 1 & &
! ( share - > data_file_type = = STATIC_RECORD ) ) | |
( param - > testflag & T_DONT_CHECK_CHECKSUM ) )
old_record_checksum = param - > record_checksum ;
2006-04-11 15:45:10 +02:00
else if ( old_record_checksum ! = param - > record_checksum )
{
if ( key )
_ma_check_print_error ( param , " Key %u doesn't point at same records that key 1 " ,
key + 1 ) ;
else
_ma_check_print_error ( param , " Key 1 doesn't point at all records " ) ;
if ( ! ( param - > testflag & T_INFO ) )
DBUG_RETURN ( - 1 ) ;
result = - 1 ;
continue ;
}
}
if ( ( uint ) share - > base . auto_key - 1 = = key )
{
/* Check that auto_increment key is bigger than max key value */
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
ulonglong auto_increment ;
2006-04-11 15:45:10 +02:00
info - > lastinx = key ;
2007-01-18 20:38:14 +01:00
_ma_read_key_record ( info , info - > rec_buff , 0 ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
auto_increment = ma_retrieve_auto_increment ( info , info - > rec_buff ) ;
if ( auto_increment > info - > s - > state . auto_increment )
2006-04-11 15:45:10 +02:00
{
2006-08-29 11:30:35 +02:00
_ma_check_print_warning ( param , " Auto-increment value: %s is smaller "
" than max used value: %s " ,
llstr ( info - > s - > state . auto_increment , buff2 ) ,
llstr ( auto_increment , buff ) ) ;
2006-04-11 15:45:10 +02:00
}
if ( param - > testflag & T_AUTO_INC )
{
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
set_if_bigger ( info - > s - > state . auto_increment ,
auto_increment ) ;
set_if_bigger ( info - > s - > state . auto_increment ,
param - > auto_increment_value ) ;
2006-04-11 15:45:10 +02:00
}
/* Check that there isn't a row with auto_increment = 0 in the table */
maria_extra ( info , HA_EXTRA_KEYREAD , 0 ) ;
bzero ( info - > lastkey , keyinfo - > seg - > length ) ;
2007-07-02 19:45:15 +02:00
if ( ! maria_rkey ( info , info - > rec_buff , key , ( const uchar * ) info - > lastkey ,
2007-07-27 12:06:39 +02:00
( key_part_map ) 1 , HA_READ_KEY_EXACT ) )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
/* Don't count this as a real warning, as maria_chk can't correct it */
2006-04-11 15:45:10 +02:00
uint save = param - > warning_printed ;
2006-08-29 11:30:35 +02:00
_ma_check_print_warning ( param , " Found row where the auto_increment "
" column has the value 0 " ) ;
2006-04-11 15:45:10 +02:00
param - > warning_printed = save ;
}
maria_extra ( info , HA_EXTRA_NO_KEYREAD , 0 ) ;
}
length = ( my_off_t ) isam_key_length ( info , keyinfo ) * keys + param - > key_blocks * 2 ;
if ( param - > testflag & T_INFO & & param - > totaldata ! = 0L & & keys ! = 0L )
printf ( " Key: %2d: Keyblocks used: %3d%% Packed: %4d%% Max levels: %2d \n " ,
key + 1 ,
( int ) ( my_off_t2double ( param - > keydata ) * 100.0 / my_off_t2double ( param - > totaldata ) ) ,
( int ) ( ( my_off_t2double ( length ) - my_off_t2double ( param - > keydata ) ) * 100.0 /
my_off_t2double ( length ) ) ,
param - > max_level ) ;
all_keydata + = param - > keydata ; all_totaldata + = param - > totaldata ; key_totlength + = length ;
do_stat :
if ( param - > testflag & T_STATISTICS )
maria_update_key_parts ( keyinfo , rec_per_key_part , param - > unique_count ,
param - > stats_method = = MI_STATS_METHOD_IGNORE_NULLS ?
param - > notnull_count : NULL ,
( ulonglong ) info - > state - > records ) ;
}
if ( param - > testflag & T_INFO )
{
if ( all_totaldata ! = 0L & & found_keys > 0 )
printf ( " Total: Keyblocks used: %3d%% Packed: %4d%% \n \n " ,
( int ) ( my_off_t2double ( all_keydata ) * 100.0 /
my_off_t2double ( all_totaldata ) ) ,
( int ) ( ( my_off_t2double ( key_totlength ) -
my_off_t2double ( all_keydata ) ) * 100.0 /
my_off_t2double ( key_totlength ) ) ) ;
else if ( all_totaldata ! = 0L & & maria_is_any_key_active ( share - > state . key_map ) )
puts ( " " ) ;
}
if ( param - > key_file_blocks ! = info - > state - > key_file_length & &
param - > keys_in_use ! = ~ ( ulonglong ) 0 )
_ma_check_print_warning ( param , " Some data are unreferenced in keyfile " ) ;
if ( found_keys ! = full_text_keys )
param - > record_checksum = old_record_checksum - init_checksum ; /* Remove delete links */
else
param - > record_checksum = 0 ;
DBUG_RETURN ( result ) ;
} /* maria_chk_key */
2007-01-18 20:38:14 +01:00
static int chk_index_down ( HA_CHECK * param , MARIA_HA * info ,
MARIA_KEYDEF * keyinfo ,
2007-07-02 19:45:15 +02:00
my_off_t page , uchar * buff , ha_rows * keys ,
2007-01-18 20:38:14 +01:00
ha_checksum * key_checksum , uint level )
2006-04-11 15:45:10 +02:00
{
char llbuff [ 22 ] , llbuff2 [ 22 ] ;
2006-10-30 12:44:33 +01:00
DBUG_ENTER ( " chk_index_down " ) ;
2006-04-11 15:45:10 +02:00
2006-10-30 12:44:33 +01:00
/* Key blocks must lay within the key file length entirely. */
if ( page + keyinfo - > block_length > info - > state - > key_file_length )
{
/* purecov: begin tested */
/* Give it a chance to fit in the real file size. */
2007-07-27 12:06:39 +02:00
my_off_t max_length = my_seek ( info - > s - > kfile . file , 0L , MY_SEEK_END ,
MYF ( MY_THREADSAFE ) ) ;
2006-10-30 12:44:33 +01:00
_ma_check_print_error ( param , " Invalid key block position: %s "
" key block size: %u file_length: %s " ,
llstr ( page , llbuff ) , keyinfo - > block_length ,
llstr ( info - > state - > key_file_length , llbuff2 ) ) ;
if ( page + keyinfo - > block_length > max_length )
2006-04-11 15:45:10 +02:00
goto err ;
2007-01-23 20:13:26 +01:00
/* Fix the remembered key file length. */
2006-10-30 12:44:33 +01:00
info - > state - > key_file_length = ( max_length &
~ ( my_off_t ) ( keyinfo - > block_length - 1 ) ) ;
/* purecov: end */
2006-04-11 15:45:10 +02:00
}
2006-10-30 12:44:33 +01:00
2007-01-23 20:13:26 +01:00
/* Key blocks must be aligned at block length */
if ( page & ( info - > s - > block_size - 1 ) )
2006-10-30 12:44:33 +01:00
{
/* purecov: begin tested */
_ma_check_print_error ( param , " Mis-aligned key block: %s "
" minimum key block length: %u " ,
2007-01-23 20:13:26 +01:00
llstr ( page , llbuff ) , info - > s - > block_size ) ;
2006-10-30 12:44:33 +01:00
goto err ;
/* purecov: end */
}
2006-04-11 15:45:10 +02:00
if ( ! _ma_fetch_keypage ( info , keyinfo , page , DFLT_INIT_HITS , buff , 0 ) )
{
_ma_check_print_error ( param , " Can't read key from filepos: %s " ,
llstr ( page , llbuff ) ) ;
goto err ;
}
param - > key_file_blocks + = keyinfo - > block_length ;
if ( chk_index ( param , info , keyinfo , page , buff , keys , key_checksum , level ) )
goto err ;
2006-10-30 12:44:33 +01:00
DBUG_RETURN ( 0 ) ;
/* purecov: begin tested */
2006-04-11 15:45:10 +02:00
err :
2006-10-30 12:44:33 +01:00
DBUG_RETURN ( 1 ) ;
/* purecov: end */
2006-04-11 15:45:10 +02:00
}
/*
" Ignore NULLs " statistics collection method : process first index tuple .
SYNOPSIS
maria_collect_stats_nonulls_first ( )
keyseg IN Array of key part descriptions
notnull INOUT Array , notnull [ i ] = ( number of { keypart1 . . . keypart_i }
tuples that don ' t contain NULLs )
key IN Key values tuple
DESCRIPTION
Process the first index tuple - find out which prefix tuples don ' t
contain NULLs , and update the array of notnull counters accordingly .
*/
static
void maria_collect_stats_nonulls_first ( HA_KEYSEG * keyseg , ulonglong * notnull ,
2007-07-02 19:45:15 +02:00
const uchar * key )
2006-04-11 15:45:10 +02:00
{
uint first_null , kp ;
2007-01-18 20:38:14 +01:00
first_null = ha_find_null ( keyseg , ( uchar * ) key ) - keyseg ;
2006-04-11 15:45:10 +02:00
/*
All prefix tuples that don ' t include keypart_ { first_null } are not - null
tuples ( and all others aren ' t ) , increment counters for them .
*/
for ( kp = 0 ; kp < first_null ; kp + + )
notnull [ kp ] + + ;
}
/*
" Ignore NULLs " statistics collection method : process next index tuple .
SYNOPSIS
maria_collect_stats_nonulls_next ( )
keyseg IN Array of key part descriptions
notnull INOUT Array , notnull [ i ] = ( number of { keypart1 . . . keypart_i }
tuples that don ' t contain NULLs )
prev_key IN Previous key values tuple
last_key IN Next key values tuple
DESCRIPTION
Process the next index tuple :
1. Find out which prefix tuples of last_key don ' t contain NULLs , and
update the array of notnull counters accordingly .
2. Find the first keypart number where the prev_key and last_key tuples
are different ( A ) , or last_key has NULL value ( B ) , and return it , so the
caller can count number of unique tuples for each key prefix . We don ' t
need ( B ) to be counted , and that is compensated back in
maria_update_key_parts ( ) .
RETURN
1 + number of first keypart where values differ or last_key tuple has NULL
*/
static
int maria_collect_stats_nonulls_next ( HA_KEYSEG * keyseg , ulonglong * notnull ,
2007-07-02 19:45:15 +02:00
const uchar * prev_key ,
const uchar * last_key )
2006-04-11 15:45:10 +02:00
{
uint diffs [ 2 ] ;
uint first_null_seg , kp ;
HA_KEYSEG * seg ;
/*
Find the first keypart where values are different or either of them is
NULL . We get results in diffs array :
diffs [ 0 ] = 1 + number of first different keypart
diffs [ 1 ] = offset : ( last_key + diffs [ 1 ] ) points to first value in
last_key that is NULL or different from corresponding
value in prev_key .
*/
2007-01-18 20:38:14 +01:00
ha_key_cmp ( keyseg , ( uchar * ) prev_key , ( uchar * ) last_key , USE_WHOLE_KEY ,
2006-04-11 15:45:10 +02:00
SEARCH_FIND | SEARCH_NULL_ARE_NOT_EQUAL , diffs ) ;
seg = keyseg + diffs [ 0 ] - 1 ;
/* Find first NULL in last_key */
2007-01-18 20:38:14 +01:00
first_null_seg = ha_find_null ( seg , ( uchar * ) last_key + diffs [ 1 ] ) - keyseg ;
2006-04-11 15:45:10 +02:00
for ( kp = 0 ; kp < first_null_seg ; kp + + )
notnull [ kp ] + + ;
/*
Return 1 + number of first key part where values differ . Don ' t care if
these were NULLs and not . . . . We compensate for that in
maria_update_key_parts .
*/
return diffs [ 0 ] ;
}
/* Check if index is ok */
static int chk_index ( HA_CHECK * param , MARIA_HA * info , MARIA_KEYDEF * keyinfo ,
2007-07-02 19:45:15 +02:00
my_off_t page , uchar * buff , ha_rows * keys ,
2006-04-11 15:45:10 +02:00
ha_checksum * key_checksum , uint level )
{
int flag ;
uint used_length , comp_flag , nod_flag , key_length = 0 ;
2007-07-02 19:45:15 +02:00
uchar key [ HA_MAX_POSSIBLE_KEY_BUFF ] , * temp_buff , * keypos , * old_keypos , * endpos ;
2006-04-11 15:45:10 +02:00
my_off_t next_page , record ;
char llbuff [ 22 ] ;
uint diff_pos [ 2 ] ;
DBUG_ENTER ( " chk_index " ) ;
2007-07-02 19:45:15 +02:00
DBUG_DUMP ( " buff " , ( uchar * ) buff , maria_data_on_page ( buff ) ) ;
2006-04-11 15:45:10 +02:00
/* TODO: implement appropriate check for RTree keys */
if ( keyinfo - > flag & HA_SPATIAL )
DBUG_RETURN ( 0 ) ;
2007-07-02 19:45:15 +02:00
if ( ! ( temp_buff = ( uchar * ) my_alloca ( ( uint ) keyinfo - > block_length ) ) )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_error ( param , " Not enough memory for keyblock " ) ;
DBUG_RETURN ( - 1 ) ;
}
if ( keyinfo - > flag & HA_NOSAME )
comp_flag = SEARCH_FIND | SEARCH_UPDATE ; /* Not real duplicates */
else
comp_flag = SEARCH_SAME ; /* Keys in positionorder */
nod_flag = _ma_test_if_nod ( buff ) ;
2007-06-09 13:52:17 +02:00
used_length = maria_data_on_page ( buff ) ;
2006-04-11 15:45:10 +02:00
keypos = buff + 2 + nod_flag ;
endpos = buff + used_length ;
param - > keydata + = used_length ; param - > totaldata + = keyinfo - > block_length ; /* INFO */
param - > key_blocks + + ;
if ( level > param - > max_level )
param - > max_level = level ;
if ( used_length > keyinfo - > block_length )
{
_ma_check_print_error ( param , " Wrong pageinfo at page: %s " ,
llstr ( page , llbuff ) ) ;
goto err ;
}
for ( ; ; )
{
if ( * _ma_killed_ptr ( param ) )
goto err ;
2007-01-18 20:38:14 +01:00
memcpy ( info - > lastkey , key , key_length ) ;
info - > lastkey_length = key_length ;
2006-04-11 15:45:10 +02:00
if ( nod_flag )
{
next_page = _ma_kpos ( nod_flag , keypos ) ;
if ( chk_index_down ( param , info , keyinfo , next_page ,
temp_buff , keys , key_checksum , level + 1 ) )
goto err ;
}
old_keypos = keypos ;
if ( keypos > = endpos | |
( key_length = ( * keyinfo - > get_key ) ( keyinfo , nod_flag , & keypos , key ) ) = = 0 )
break ;
if ( keypos > endpos )
{
2007-01-18 20:38:14 +01:00
_ma_check_print_error ( param , " Wrong key block length at page: %s " ,
llstr ( page , llbuff ) ) ;
2006-04-11 15:45:10 +02:00
goto err ;
}
if ( ( * keys ) + + & &
2007-01-18 20:38:14 +01:00
( flag = ha_key_cmp ( keyinfo - > seg , ( uchar * ) info - > lastkey , ( uchar * ) key ,
key_length , comp_flag , diff_pos ) ) > = 0 )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
DBUG_DUMP ( " old " , info - > lastkey , info - > lastkey_length ) ;
DBUG_DUMP ( " new " , key , key_length ) ;
DBUG_DUMP ( " new_in_page " , old_keypos , ( uint ) ( keypos - old_keypos ) ) ;
2006-04-11 15:45:10 +02:00
if ( comp_flag & SEARCH_FIND & & flag = = 0 )
2007-01-18 20:38:14 +01:00
_ma_check_print_error ( param , " Found duplicated key at page %s " ,
llstr ( page , llbuff ) ) ;
2006-04-11 15:45:10 +02:00
else
2007-01-18 20:38:14 +01:00
_ma_check_print_error ( param , " Key in wrong position at page %s " ,
llstr ( page , llbuff ) ) ;
2006-04-11 15:45:10 +02:00
goto err ;
}
if ( param - > testflag & T_STATISTICS )
{
if ( * keys ! = 1L ) /* not first_key */
{
if ( param - > stats_method = = MI_STATS_METHOD_NULLS_NOT_EQUAL )
2007-01-18 20:38:14 +01:00
ha_key_cmp ( keyinfo - > seg , ( uchar * ) info - > lastkey , ( uchar * ) key ,
USE_WHOLE_KEY , SEARCH_FIND | SEARCH_NULL_ARE_NOT_EQUAL ,
2006-04-11 15:45:10 +02:00
diff_pos ) ;
else if ( param - > stats_method = = MI_STATS_METHOD_IGNORE_NULLS )
{
diff_pos [ 0 ] = maria_collect_stats_nonulls_next ( keyinfo - > seg ,
2007-01-18 20:38:14 +01:00
param - > notnull_count ,
info - > lastkey , key ) ;
2006-04-11 15:45:10 +02:00
}
param - > unique_count [ diff_pos [ 0 ] - 1 ] + + ;
}
else
{
if ( param - > stats_method = = MI_STATS_METHOD_IGNORE_NULLS )
maria_collect_stats_nonulls_first ( keyinfo - > seg , param - > notnull_count ,
key ) ;
}
}
2007-07-02 19:45:15 +02:00
( * key_checksum ) + = maria_byte_checksum ( ( uchar * ) key ,
2007-07-01 15:20:57 +02:00
key_length - info - > s - > rec_reflength ) ;
2006-04-11 15:45:10 +02:00
record = _ma_dpos ( info , 0 , key + key_length ) ;
if ( keyinfo - > flag & HA_FULLTEXT ) /* special handling for ft2 */
{
uint off ;
int subkeys ;
get_key_full_length_rdonly ( off , key ) ;
subkeys = ft_sintXkorr ( key + off ) ;
if ( subkeys < 0 )
{
ha_rows tmp_keys = 0 ;
if ( chk_index_down ( param , info , & info - > s - > ft2_keyinfo , record ,
temp_buff , & tmp_keys , key_checksum , 1 ) )
goto err ;
if ( tmp_keys + subkeys )
{
_ma_check_print_error ( param ,
" Number of words in the 2nd level tree "
" does not match the number in the header. "
" Parent word in on the page %s, offset %u " ,
llstr ( page , llbuff ) , ( uint ) ( old_keypos - buff ) ) ;
goto err ;
}
( * keys ) + = tmp_keys - 1 ;
continue ;
}
/* fall through */
}
if ( record > = info - > state - > data_file_length )
{
# ifndef DBUG_OFF
char llbuff2 [ 22 ] , llbuff3 [ 22 ] ;
# endif
_ma_check_print_error ( param , " Found key at page %s that points to record outside datafile " , llstr ( page , llbuff ) ) ;
DBUG_PRINT ( " test " , ( " page: %s record: %s filelength: %s " ,
llstr ( page , llbuff ) , llstr ( record , llbuff2 ) ,
llstr ( info - > state - > data_file_length , llbuff3 ) ) ) ;
2007-07-02 19:45:15 +02:00
DBUG_DUMP ( " key " , ( uchar * ) key , key_length ) ;
2006-04-11 15:45:10 +02:00
DBUG_DUMP ( " new_in_page " , ( char * ) old_keypos , ( uint ) ( keypos - old_keypos ) ) ;
goto err ;
}
2007-01-18 20:38:14 +01:00
param - > record_checksum + = ( ha_checksum ) record ;
2006-04-11 15:45:10 +02:00
}
if ( keypos ! = endpos )
{
_ma_check_print_error ( param , " Keyblock size at page %s is not correct. Block length: %d key length: %d " ,
llstr ( page , llbuff ) , used_length , ( keypos - buff ) ) ;
goto err ;
}
2007-07-02 19:45:15 +02:00
my_afree ( ( uchar * ) temp_buff ) ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 0 ) ;
err :
2007-07-02 19:45:15 +02:00
my_afree ( ( uchar * ) temp_buff ) ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 1 ) ;
} /* chk_index */
/* Calculate a checksum of 1+2+3+4...N = N*(N+1)/2 without overflow */
static ha_checksum calc_checksum ( ha_rows count )
{
ulonglong sum , a , b ;
DBUG_ENTER ( " calc_checksum " ) ;
sum = 0 ;
a = count ; b = count + 1 ;
if ( a & 1 )
b > > = 1 ;
else
a > > = 1 ;
while ( b )
{
if ( b & 1 )
sum + = a ;
a < < = 1 ; b > > = 1 ;
}
DBUG_PRINT ( " exit " , ( " sum: %lx " , ( ulong ) sum ) ) ;
DBUG_RETURN ( ( ha_checksum ) sum ) ;
} /* calc_checksum */
/* Calc length of key in normal isam */
static uint isam_key_length ( MARIA_HA * info , register MARIA_KEYDEF * keyinfo )
{
uint length ;
HA_KEYSEG * keyseg ;
DBUG_ENTER ( " isam_key_length " ) ;
length = info - > s - > rec_reflength ;
for ( keyseg = keyinfo - > seg ; keyseg - > type ; keyseg + + )
length + = keyseg - > length ;
DBUG_PRINT ( " exit " , ( " length: %d " , length ) ) ;
DBUG_RETURN ( length ) ;
} /* key_length */
2007-01-18 20:38:14 +01:00
static void record_pos_to_txt ( MARIA_HA * info , my_off_t recpos ,
char * buff )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
if ( info - > s - > data_file_type ! = BLOCK_RECORD )
llstr ( recpos , buff ) ;
else
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
my_off_t page = ma_recordpos_to_page ( recpos ) ;
2007-04-19 12:18:56 +02:00
uint row = ma_recordpos_to_dir_entry ( recpos ) ;
2007-01-18 20:38:14 +01:00
char * end = longlong10_to_str ( page , buff , 10 ) ;
* ( end + + ) = ' : ' ;
longlong10_to_str ( row , end , 10 ) ;
2006-04-11 15:45:10 +02:00
}
2007-01-18 20:38:14 +01:00
}
2006-04-11 15:45:10 +02:00
2007-01-18 20:38:14 +01:00
/*
Check that keys in records exist in index tree
SYNOPSIS
check_keys_in_record ( )
param Check paramenter
info Maria handler
extend Type of check ( extended or normal )
start_recpos Position to row
record Record buffer
NOTES
This function also calculates record checksum & number of rows
*/
static int check_keys_in_record ( HA_CHECK * param , MARIA_HA * info , int extend ,
2007-07-02 19:45:15 +02:00
my_off_t start_recpos , uchar * record )
2007-01-18 20:38:14 +01:00
{
MARIA_KEYDEF * keyinfo ;
char llbuff [ 22 + 4 ] ;
uint key ;
param - > tmp_record_checksum + = ( ha_checksum ) start_recpos ;
param - > records + + ;
if ( param - > testflag & T_WRITE_LOOP & & param - > records % WRITE_COUNT = = 0 )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
printf ( " %s \r " , llstr ( param - > records , llbuff ) ) ;
VOID ( fflush ( stdout ) ) ;
2006-04-11 15:45:10 +02:00
}
2007-01-18 20:38:14 +01:00
/* Check if keys match the record */
for ( key = 0 , keyinfo = info - > s - > keyinfo ; key < info - > s - > base . keys ;
key + + , keyinfo + + )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
if ( maria_is_key_active ( info - > s - > state . key_map , key ) )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
if ( ! ( keyinfo - > flag & HA_FULLTEXT ) )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
uint key_length = _ma_make_key ( info , key , info - > lastkey , record ,
start_recpos ) ;
if ( extend )
{
/* We don't need to lock the key tree here as we don't allow
concurrent threads when running maria_chk
*/
int search_result =
# ifdef HAVE_RTREE_KEYS
( keyinfo - > flag & HA_SPATIAL ) ?
maria_rtree_find_first ( info , key , info - > lastkey , key_length ,
MBR_EQUAL | MBR_DATA ) :
# endif
_ma_search ( info , keyinfo , info - > lastkey , key_length ,
SEARCH_SAME , info - > s - > state . key_root [ key ] ) ;
if ( search_result )
{
record_pos_to_txt ( info , start_recpos , llbuff ) ;
2007-01-23 20:13:26 +01:00
_ma_check_print_error ( param ,
" Record at: %14s "
" Can't find key for index: %2d " ,
llbuff , key + 1 ) ;
2007-01-18 20:38:14 +01:00
if ( param - > err_count + + > MAXERR | | ! ( param - > testflag & T_VERBOSE ) )
return - 1 ;
}
}
else
param - > tmp_key_crc [ key ] + =
2007-07-02 19:45:15 +02:00
maria_byte_checksum ( ( uchar * ) info - > lastkey , key_length ) ;
2006-04-11 15:45:10 +02:00
}
}
}
2007-01-18 20:38:14 +01:00
return 0 ;
}
2006-04-11 15:45:10 +02:00
2007-01-18 20:38:14 +01:00
/*
Functions to loop through all rows and check if they are ok
NOTES
One function for each record format
2006-04-11 15:45:10 +02:00
2007-01-18 20:38:14 +01:00
RESULT
0 ok
- 1 Interrupted by user
1 Error
*/
static int check_static_record ( HA_CHECK * param , MARIA_HA * info , int extend ,
2007-07-02 19:45:15 +02:00
uchar * record )
2007-01-18 20:38:14 +01:00
{
my_off_t start_recpos , pos ;
char llbuff [ 22 ] ;
pos = 0 ;
2006-04-11 15:45:10 +02:00
while ( pos < info - > state - > data_file_length )
{
if ( * _ma_killed_ptr ( param ) )
2007-01-18 20:38:14 +01:00
return - 1 ;
2007-07-02 19:45:15 +02:00
if ( my_b_read ( & param - > read_cache , ( uchar * ) record ,
2007-01-18 20:38:14 +01:00
info - > s - > base . pack_reclength ) )
{
_ma_check_print_error ( param ,
" got error: %d when reading datafile at position: %s " ,
my_errno , llstr ( pos , llbuff ) ) ;
return 1 ;
}
start_recpos = pos ;
pos + = info - > s - > base . pack_reclength ;
param - > splits + + ;
if ( * record = = ' \0 ' )
{
param - > del_blocks + + ;
param - > del_length + = info - > s - > base . pack_reclength ;
continue ; /* Record removed */
}
param - > glob_crc + = _ma_static_checksum ( info , record ) ;
param - > used + = info - > s - > base . pack_reclength ;
if ( check_keys_in_record ( param , info , extend , start_recpos , record ) )
return 1 ;
}
return 0 ;
}
static int check_dynamic_record ( HA_CHECK * param , MARIA_HA * info , int extend ,
2007-07-02 19:45:15 +02:00
uchar * record )
2007-01-18 20:38:14 +01:00
{
MARIA_BLOCK_INFO block_info ;
my_off_t start_recpos , start_block , pos ;
2007-07-02 19:45:15 +02:00
uchar * to ;
2007-01-18 20:38:14 +01:00
ulong left_length ;
uint b_type ;
char llbuff [ 22 ] , llbuff2 [ 22 ] , llbuff3 [ 22 ] ;
DBUG_ENTER ( " check_dynamic_record " ) ;
2007-01-26 12:32:02 +01:00
LINT_INIT ( left_length ) ;
LINT_INIT ( start_recpos ) ;
LINT_INIT ( to ) ;
2007-01-18 20:38:14 +01:00
pos = 0 ;
while ( pos < info - > state - > data_file_length )
{
my_bool got_error = 0 ;
int flag ;
if ( * _ma_killed_ptr ( param ) )
DBUG_RETURN ( - 1 ) ;
flag = block_info . second_read = 0 ;
block_info . next_filepos = pos ;
do
{
2007-07-02 19:45:15 +02:00
if ( _ma_read_cache ( & param - > read_cache , ( uchar * ) block_info . header ,
2007-01-18 20:38:14 +01:00
( start_block = block_info . next_filepos ) ,
sizeof ( block_info . header ) ,
( flag ? 0 : READING_NEXT ) | READING_HEADER ) )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
_ma_check_print_error ( param ,
2007-01-26 12:32:02 +01:00
" got error: %d when reading datafile at "
" position: %s " ,
2007-01-18 20:38:14 +01:00
my_errno , llstr ( start_block , llbuff ) ) ;
DBUG_RETURN ( 1 ) ;
2006-04-11 15:45:10 +02:00
}
2007-01-18 20:38:14 +01:00
if ( start_block & ( MARIA_DYN_ALIGN_SIZE - 1 ) )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
_ma_check_print_error ( param , " Wrong aligned block at %s " ,
llstr ( start_block , llbuff ) ) ;
DBUG_RETURN ( 1 ) ;
}
b_type = _ma_get_block_info ( & block_info , - 1 , start_block ) ;
if ( b_type & ( BLOCK_DELETED | BLOCK_ERROR | BLOCK_SYNC_ERROR |
BLOCK_FATAL_ERROR ) )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
if ( b_type & BLOCK_SYNC_ERROR )
{
if ( flag )
{
_ma_check_print_error ( param , " Unexpected byte: %d at link: %s " ,
( int ) block_info . header [ 0 ] ,
llstr ( start_block , llbuff ) ) ;
DBUG_RETURN ( 1 ) ;
}
pos = block_info . filepos + block_info . block_len ;
goto next ;
}
if ( b_type & BLOCK_DELETED )
{
if ( block_info . block_len < info - > s - > base . min_block_length )
{
_ma_check_print_error ( param ,
" Deleted block with impossible length %lu at %s " ,
block_info . block_len , llstr ( pos , llbuff ) ) ;
DBUG_RETURN ( 1 ) ;
}
if ( ( block_info . next_filepos ! = HA_OFFSET_ERROR & &
block_info . next_filepos > = info - > state - > data_file_length ) | |
( block_info . prev_filepos ! = HA_OFFSET_ERROR & &
block_info . prev_filepos > = info - > state - > data_file_length ) )
{
_ma_check_print_error ( param , " Delete link points outside datafile at %s " ,
llstr ( pos , llbuff ) ) ;
DBUG_RETURN ( 1 ) ;
}
param - > del_blocks + + ;
param - > del_length + = block_info . block_len ;
param - > splits + + ;
pos = block_info . filepos + block_info . block_len ;
goto next ;
}
_ma_check_print_error ( param , " Wrong bytesec: %d-%d-%d at linkstart: %s " ,
block_info . header [ 0 ] , block_info . header [ 1 ] ,
block_info . header [ 2 ] ,
llstr ( start_block , llbuff ) ) ;
DBUG_RETURN ( 1 ) ;
2006-04-11 15:45:10 +02:00
}
2007-01-18 20:38:14 +01:00
if ( info - > state - > data_file_length < block_info . filepos +
block_info . block_len )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
_ma_check_print_error ( param ,
" Recordlink that points outside datafile at %s " ,
llstr ( pos , llbuff ) ) ;
got_error = 1 ;
break ;
2006-04-11 15:45:10 +02:00
}
2007-01-18 20:38:14 +01:00
param - > splits + + ;
if ( ! flag + + ) /* First block */
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
start_recpos = pos ;
pos = block_info . filepos + block_info . block_len ;
if ( block_info . rec_len > ( uint ) info - > s - > base . max_pack_length )
{
_ma_check_print_error ( param , " Found too long record (%lu) at %s " ,
( ulong ) block_info . rec_len ,
llstr ( start_recpos , llbuff ) ) ;
got_error = 1 ;
break ;
}
if ( info - > s - > base . blobs )
{
if ( _ma_alloc_buffer ( & info - > rec_buff , & info - > rec_buff_size ,
block_info . rec_len +
info - > s - > base . extra_rec_buff_size ) )
{
_ma_check_print_error ( param ,
" Not enough memory (%lu) for blob at %s " ,
( ulong ) block_info . rec_len ,
llstr ( start_recpos , llbuff ) ) ;
got_error = 1 ;
break ;
}
}
to = info - > rec_buff ;
left_length = block_info . rec_len ;
}
if ( left_length < block_info . data_len )
{
_ma_check_print_error ( param , " Found too long record (%lu) at %s " ,
( ulong ) block_info . data_len ,
llstr ( start_recpos , llbuff ) ) ;
got_error = 1 ;
break ;
}
2007-07-02 19:45:15 +02:00
if ( _ma_read_cache ( & param - > read_cache , ( uchar * ) to , block_info . filepos ,
2007-01-18 20:38:14 +01:00
( uint ) block_info . data_len ,
flag = = 1 ? READING_NEXT : 0 ) )
{
_ma_check_print_error ( param ,
" got error: %d when reading datafile at position: %s " , my_errno , llstr ( block_info . filepos , llbuff ) ) ;
DBUG_RETURN ( 1 ) ;
}
to + = block_info . data_len ;
param - > link_used + = block_info . filepos - start_block ;
param - > used + = block_info . filepos - start_block + block_info . data_len ;
param - > empty + = block_info . block_len - block_info . data_len ;
left_length - = block_info . data_len ;
if ( left_length )
{
if ( b_type & BLOCK_LAST )
{
_ma_check_print_error ( param ,
" Wrong record length %s of %s at %s " ,
llstr ( block_info . rec_len - left_length , llbuff ) ,
llstr ( block_info . rec_len , llbuff2 ) ,
llstr ( start_recpos , llbuff3 ) ) ;
got_error = 1 ;
break ;
}
if ( info - > state - > data_file_length < block_info . next_filepos )
{
_ma_check_print_error ( param ,
" Found next-recordlink that points outside datafile at %s " ,
llstr ( block_info . filepos , llbuff ) ) ;
got_error = 1 ;
break ;
}
}
} while ( left_length ) ;
if ( ! got_error )
{
if ( _ma_rec_unpack ( info , record , info - > rec_buff , block_info . rec_len ) = =
MY_FILE_ERROR )
{
_ma_check_print_error ( param , " Found wrong record at %s " ,
llstr ( start_recpos , llbuff ) ) ;
got_error = 1 ;
2006-04-11 15:45:10 +02:00
}
else
2007-01-18 20:38:14 +01:00
{
2007-07-01 15:20:57 +02:00
ha_checksum checksum = 0 ;
if ( info - > s - > calc_checksum )
checksum = ( * info - > s - > calc_checksum ) ( info , record ) ;
2007-01-18 20:38:14 +01:00
if ( param - > testflag & ( T_EXTEND | T_MEDIUM | T_VERBOSE ) )
{
if ( _ma_rec_check ( info , record , info - > rec_buff , block_info . rec_len ,
2007-07-01 15:20:57 +02:00
test ( info - > s - > calc_checksum ) , checksum ) )
2007-01-18 20:38:14 +01:00
{
_ma_check_print_error ( param , " Found wrong packed record at %s " ,
llstr ( start_recpos , llbuff ) ) ;
got_error = 1 ;
}
}
2007-07-01 15:20:57 +02:00
param - > glob_crc + = checksum ;
2007-01-18 20:38:14 +01:00
}
if ( ! got_error )
{
if ( check_keys_in_record ( param , info , extend , start_recpos , record ) )
DBUG_RETURN ( 1 ) ;
2006-04-11 15:45:10 +02:00
}
else
2007-01-18 20:38:14 +01:00
{
if ( param - > err_count + + > MAXERR | | ! ( param - > testflag & T_VERBOSE ) )
DBUG_RETURN ( 1 ) ;
}
}
else if ( ! flag )
pos = block_info . filepos + block_info . block_len ;
next : ;
}
DBUG_RETURN ( 0 ) ;
}
static int check_compressed_record ( HA_CHECK * param , MARIA_HA * info , int extend ,
2007-07-02 19:45:15 +02:00
uchar * record )
2007-01-18 20:38:14 +01:00
{
my_off_t start_recpos , pos ;
char llbuff [ 22 ] ;
bool got_error = 0 ;
MARIA_BLOCK_INFO block_info ;
DBUG_ENTER ( " check_compressed_record " ) ;
pos = info - > s - > pack . header_length ; /* Skip header */
while ( pos < info - > state - > data_file_length )
{
if ( * _ma_killed_ptr ( param ) )
DBUG_RETURN ( - 1 ) ;
2007-07-02 19:45:15 +02:00
if ( _ma_read_cache ( & param - > read_cache , ( uchar * ) block_info . header , pos ,
2007-01-18 20:38:14 +01:00
info - > s - > pack . ref_length , READING_NEXT ) )
{
_ma_check_print_error ( param ,
" got error: %d when reading datafile at position: %s " ,
my_errno , llstr ( pos , llbuff ) ) ;
DBUG_RETURN ( 1 ) ;
}
start_recpos = pos ;
param - > splits + + ;
2007-01-23 20:13:26 +01:00
VOID ( _ma_pack_get_block_info ( info , & info - > bit_buff , & block_info ,
2007-01-26 12:32:02 +01:00
& info - > rec_buff , & info - > rec_buff_size , - 1 ,
start_recpos ) ) ;
2007-01-18 20:38:14 +01:00
pos = block_info . filepos + block_info . rec_len ;
if ( block_info . rec_len < ( uint ) info - > s - > min_pack_length | |
block_info . rec_len > ( uint ) info - > s - > max_pack_length )
{
_ma_check_print_error ( param ,
" Found block with wrong recordlength: %d at %s " ,
block_info . rec_len , llstr ( start_recpos , llbuff ) ) ;
got_error = 1 ;
goto end ;
}
2007-07-02 19:45:15 +02:00
if ( _ma_read_cache ( & param - > read_cache , ( uchar * ) info - > rec_buff ,
2007-01-18 20:38:14 +01:00
block_info . filepos , block_info . rec_len , READING_NEXT ) )
{
_ma_check_print_error ( param ,
" got error: %d when reading datafile at position: %s " ,
my_errno , llstr ( block_info . filepos , llbuff ) ) ;
DBUG_RETURN ( 1 ) ;
}
2007-01-23 20:13:26 +01:00
if ( _ma_pack_rec_unpack ( info , & info - > bit_buff , record ,
info - > rec_buff , block_info . rec_len ) )
2007-01-18 20:38:14 +01:00
{
_ma_check_print_error ( param , " Found wrong record at %s " ,
llstr ( start_recpos , llbuff ) ) ;
got_error = 1 ;
goto end ;
}
param - > glob_crc + = ( * info - > s - > calc_checksum ) ( info , record ) ;
param - > link_used + = ( block_info . filepos - start_recpos ) ;
param - > used + = ( pos - start_recpos ) ;
end :
2006-04-11 15:45:10 +02:00
if ( ! got_error )
{
2007-01-18 20:38:14 +01:00
if ( check_keys_in_record ( param , info , extend , start_recpos , record ) )
DBUG_RETURN ( 1 ) ;
}
else
{
got_error = 0 ; /* Reset for next loop */
if ( param - > err_count + + > MAXERR | | ! ( param - > testflag & T_VERBOSE ) )
DBUG_RETURN ( 1 ) ;
}
}
DBUG_RETURN ( 0 ) ;
}
/*
Check if layout on a page is ok
2007-04-19 12:18:56 +02:00
NOTES
This is for rows - in - block format .
2007-01-18 20:38:14 +01:00
*/
static int check_page_layout ( HA_CHECK * param , MARIA_HA * info ,
2007-07-02 19:45:15 +02:00
my_off_t page_pos , uchar * page ,
2007-01-18 20:38:14 +01:00
uint row_count , uint head_empty ,
uint * real_rows_found )
{
uint empty , last_row_end , row , first_dir_entry ;
2007-07-02 19:45:15 +02:00
uchar * dir_entry ;
2007-01-18 20:38:14 +01:00
char llbuff [ 22 ] ;
DBUG_ENTER ( " check_page_layout " ) ;
empty = 0 ;
last_row_end = PAGE_HEADER_SIZE ;
* real_rows_found = 0 ;
dir_entry = page + info - > s - > block_size - PAGE_SUFFIX_SIZE ;
first_dir_entry = info - > s - > block_size - row_count * DIR_ENTRY_SIZE ;
for ( row = 0 ; row < row_count ; row + + )
{
uint pos , length ;
dir_entry - = DIR_ENTRY_SIZE ;
pos = uint2korr ( dir_entry ) ;
if ( ! pos )
{
if ( row = = row_count - 1 )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
_ma_check_print_error ( param ,
" Page %9s: First entry in directory is 0 " ,
llstr ( page_pos , llbuff ) ) ;
if ( param - > err_count + + > MAXERR | | ! ( param - > testflag & T_VERBOSE ) )
DBUG_RETURN ( 1 ) ;
2006-04-11 15:45:10 +02:00
}
2007-01-18 20:38:14 +01:00
continue ; /* Deleted row */
}
( * real_rows_found ) + + ;
length = uint2korr ( dir_entry + 2 ) ;
param - > used + = length ;
if ( pos < last_row_end )
{
_ma_check_print_error ( param ,
" Page %9s: Row %3u overlapps with previous row " ,
llstr ( page_pos , llbuff ) , row ) ;
DBUG_RETURN ( 1 ) ;
}
empty + = ( pos - last_row_end ) ;
last_row_end = pos + length ;
if ( last_row_end > first_dir_entry )
{
_ma_check_print_error ( param ,
" Page %9s: Row %3u overlapps with directory " ,
llstr ( page_pos , llbuff ) , row ) ;
DBUG_RETURN ( 1 ) ;
}
}
empty + = ( first_dir_entry - last_row_end ) ;
if ( empty ! = head_empty )
{
_ma_check_print_error ( param ,
" Page %9s: Wrong empty size. Stored: %5u Actual: %5u " ,
llstr ( page_pos , llbuff ) , head_empty , empty ) ;
DBUG_RETURN ( param - > err_count + + > MAXERR | | ! ( param - > testflag & T_VERBOSE ) ) ;
}
DBUG_RETURN ( 0 ) ;
}
/*
Check all rows on head page
NOTES
2007-04-19 12:18:56 +02:00
This is for rows - in - block format .
2007-01-18 20:38:14 +01:00
Before this , we have already called check_page_layout ( ) , so
we know the block is logicaly correct ( even if the rows may not be that )
RETURN
0 ok
1 error
*/
2006-04-11 15:45:10 +02:00
2007-07-02 19:45:15 +02:00
static my_bool check_head_page ( HA_CHECK * param , MARIA_HA * info , uchar * record ,
int extend , my_off_t page_pos , uchar * page_buff ,
2007-01-18 20:38:14 +01:00
uint row_count )
{
2007-07-02 19:45:15 +02:00
uchar * dir_entry ;
2007-01-18 20:38:14 +01:00
uint row ;
char llbuff [ 22 ] , llbuff2 [ 22 ] ;
DBUG_ENTER ( " check_head_page " ) ;
dir_entry = page_buff + info - > s - > block_size - PAGE_SUFFIX_SIZE ;
for ( row = 0 ; row < row_count ; row + + )
{
uint pos , length , flag ;
dir_entry - = DIR_ENTRY_SIZE ;
pos = uint2korr ( dir_entry ) ;
if ( ! pos )
continue ;
length = uint2korr ( dir_entry + 2 ) ;
if ( length < info - > s - > base . min_block_length )
{
_ma_check_print_error ( param ,
" Page %9s: Row %3u is too short (%d bytes) " ,
llstr ( page_pos , llbuff ) , row , length ) ;
DBUG_RETURN ( 1 ) ;
}
flag = ( uint ) ( uchar ) page_buff [ pos ] ;
if ( flag & ~ ( ROW_FLAG_ALL ) )
_ma_check_print_error ( param ,
" Page %9s: Row %3u has wrong flag: %d " ,
llstr ( page_pos , llbuff ) , row , flag ) ;
DBUG_PRINT ( " info " , ( " rowid: %s page: %lu row: %u " ,
llstr ( ma_recordpos ( page_pos / info - > s - > block_size , row ) ,
llbuff ) ,
( ulong ) ( page_pos / info - > s - > block_size ) , row ) ) ;
if ( _ma_read_block_record2 ( info , record , page_buff + pos ,
page_buff + pos + length ) )
{
_ma_check_print_error ( param ,
" Page %9s: Row %3d is crashed " ,
llstr ( page_pos , llbuff ) , row ) ;
if ( param - > err_count + + > MAXERR | | ! ( param - > testflag & T_VERBOSE ) )
DBUG_RETURN ( 1 ) ;
continue ;
}
if ( info - > s - > calc_checksum )
{
2007-07-01 15:20:57 +02:00
ha_checksum checksum = ( * info - > s - > calc_checksum ) ( info , record ) ;
if ( info - > cur_row . checksum ! = ( checksum & 255 ) )
_ma_check_print_error ( param , " Page %9s: Row %3d has wrong checksum " ,
llstr ( page_pos , llbuff ) , row ) ;
param - > glob_crc + = checksum ;
2007-01-18 20:38:14 +01:00
}
if ( info - > cur_row . extents_count )
{
2007-07-02 19:45:15 +02:00
uchar * extents = info - > cur_row . extents ;
2007-01-18 20:38:14 +01:00
uint i ;
/* Check that bitmap has the right marker for the found extents */
for ( i = 0 ; i < info - > cur_row . extents_count ; i + + )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
uint page , page_count , page_type ;
page = uint5korr ( extents ) ;
page_count = uint2korr ( extents + 5 ) ;
extents + = ROW_EXTENT_SIZE ;
page_type = BLOB_PAGE ;
if ( page_count & TAIL_BIT )
{
page_count = 1 ;
page_type = TAIL_PAGE ;
}
for ( ; page_count - - ; page + + )
{
uint bitmap_pattern ;
if ( _ma_check_if_right_bitmap_type ( info , page_type , page ,
& bitmap_pattern ) )
{
_ma_check_print_error ( param ,
" Page %9s: Row: %3d has an extent with wrong information in bitmap: Page %9s Page_type: %d Bitmap: %d " ,
llstr ( page_pos , llbuff ) , row ,
llstr ( page * info - > s - > bitmap . block_size ,
llbuff2 ) ,
page_type ,
bitmap_pattern ) ;
if ( param - > err_count + + > MAXERR | | ! ( param - > testflag & T_VERBOSE ) )
DBUG_RETURN ( 1 ) ;
}
}
2006-04-11 15:45:10 +02:00
}
}
2007-01-18 20:38:14 +01:00
param - > full_page_count + = info - > cur_row . full_page_count ;
param - > tail_count + = info - > cur_row . tail_count ;
if ( check_keys_in_record ( param , info , extend ,
ma_recordpos ( page_pos / info - > s - > block_size , row ) ,
record ) )
DBUG_RETURN ( 1 ) ;
}
DBUG_RETURN ( 0 ) ;
}
2007-04-19 12:18:56 +02:00
/*
Check if rows - in - block data file is consistent
*/
2007-01-18 20:38:14 +01:00
static int check_block_record ( HA_CHECK * param , MARIA_HA * info , int extend ,
2007-07-02 19:45:15 +02:00
uchar * record )
2007-01-18 20:38:14 +01:00
{
my_off_t pos ;
2007-07-02 19:45:15 +02:00
uchar * page_buff , * bitmap_buff , * data ;
2007-01-18 20:38:14 +01:00
char llbuff [ 22 ] , llbuff2 [ 22 ] ;
uint block_size = info - > s - > block_size ;
ha_rows full_page_count , tail_count ;
my_bool full_dir ;
uint offset_page , offset ;
2006-04-11 15:45:10 +02:00
2007-07-01 15:20:57 +02:00
LINT_INIT ( full_dir ) ;
2007-01-18 20:38:14 +01:00
if ( _ma_scan_init_block_record ( info ) )
{
_ma_check_print_error ( param , " got error %d when initializing scan " ,
my_errno ) ;
return 1 ;
}
bitmap_buff = info - > scan . bitmap_buff ;
page_buff = info - > scan . page_buff ;
full_page_count = tail_count = 0 ;
param - > full_page_count = param - > tail_count = 0 ;
param - > used = param - > link_used = 0 ;
2006-04-11 15:45:10 +02:00
2007-01-18 20:38:14 +01:00
for ( pos = 0 ;
pos < info - > state - > data_file_length ;
pos + = block_size )
{
uint row_count , real_row_count , empty_space , page_type , bitmap_pattern ;
LINT_INIT ( row_count ) ;
LINT_INIT ( empty_space ) ;
if ( * _ma_killed_ptr ( param ) )
{
_ma_scan_end_block_record ( info ) ;
return - 1 ;
}
if ( ( ( pos / block_size ) % info - > s - > bitmap . pages_covered ) = = 0 )
{
/* Bitmap page */
2007-04-19 17:48:36 +02:00
if ( pagecache_read ( info - > s - > pagecache ,
& info - > dfile ,
( pos / block_size ) , 1 ,
bitmap_buff ,
PAGECACHE_PLAIN_PAGE ,
PAGECACHE_LOCK_LEFT_UNLOCKED , 0 ) = = 0 )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
_ma_check_print_error ( param ,
" Page %9s: Got error: %d when reading datafile " ,
my_errno , llstr ( pos , llbuff ) ) ;
goto err ;
2006-04-11 15:45:10 +02:00
}
2007-01-18 20:38:14 +01:00
param - > used + = block_size ;
param - > link_used + = block_size ;
continue ;
2006-04-11 15:45:10 +02:00
}
2007-01-18 20:38:14 +01:00
/* Skip pages marked as empty in bitmap */
offset_page = ( ( ( pos / block_size ) % info - > s - > bitmap . pages_covered ) - 1 ) * 3 ;
offset = offset_page & 7 ;
data = bitmap_buff + offset_page / 8 ;
bitmap_pattern = uint2korr ( data ) ;
param - > splits + + ;
if ( ! ( ( bitmap_pattern > > offset ) & 7 ) )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
param - > empty + = block_size ;
param - > del_blocks + + ;
continue ;
}
2007-04-19 17:48:36 +02:00
if ( pagecache_read ( info - > s - > pagecache ,
& info - > dfile ,
( pos / block_size ) , 1 ,
page_buff ,
2007-06-04 13:07:18 +02:00
info - > s - > page_type ,
2007-04-19 17:48:36 +02:00
PAGECACHE_LOCK_LEFT_UNLOCKED , 0 ) = = 0 )
2007-01-18 20:38:14 +01:00
{
_ma_check_print_error ( param ,
" Page %9s: Got error: %d when reading datafile " ,
my_errno , llstr ( pos , llbuff ) ) ;
goto err ;
}
page_type = page_buff [ PAGE_TYPE_OFFSET ] & PAGE_TYPE_MASK ;
if ( page_type = = UNALLOCATED_PAGE | | page_type > = MAX_PAGE_TYPE )
{
_ma_check_print_error ( param ,
" Page %9s: Found wrong page type %d \n " ,
llstr ( pos , llbuff ) , page_type ) ;
if ( param - > err_count + + > MAXERR | | ! ( param - > testflag & T_VERBOSE ) )
goto err ;
2007-07-01 15:20:57 +02:00
continue ;
2007-01-18 20:38:14 +01:00
}
switch ( ( enum en_page_type ) page_type ) {
case UNALLOCATED_PAGE :
case MAX_PAGE_TYPE :
2007-07-01 15:20:57 +02:00
DBUG_ASSERT ( 0 ) ; /* Impossible */
2007-01-18 20:38:14 +01:00
break ;
case HEAD_PAGE :
2007-04-19 12:18:56 +02:00
row_count = ( ( uchar * ) page_buff ) [ DIR_COUNT_OFFSET ] ;
2007-01-18 20:38:14 +01:00
empty_space = uint2korr ( page_buff + EMPTY_SPACE_OFFSET ) ;
param - > used + = ( PAGE_HEADER_SIZE + PAGE_SUFFIX_SIZE +
row_count * DIR_ENTRY_SIZE ) ;
param - > link_used + = ( PAGE_HEADER_SIZE + PAGE_SUFFIX_SIZE +
row_count * DIR_ENTRY_SIZE ) ;
full_dir = row_count = = MAX_ROWS_PER_PAGE ;
break ;
case TAIL_PAGE :
2007-04-19 12:18:56 +02:00
row_count = ( ( uchar * ) page_buff ) [ DIR_COUNT_OFFSET ] ;
2007-01-18 20:38:14 +01:00
empty_space = uint2korr ( page_buff + EMPTY_SPACE_OFFSET ) ;
param - > used + = ( PAGE_HEADER_SIZE + PAGE_SUFFIX_SIZE +
row_count * DIR_ENTRY_SIZE ) ;
param - > link_used + = ( PAGE_HEADER_SIZE + PAGE_SUFFIX_SIZE +
row_count * DIR_ENTRY_SIZE ) ;
full_dir = row_count = = MAX_ROWS_PER_PAGE ;
break ;
case BLOB_PAGE :
full_page_count + + ;
full_dir = 0 ;
empty_space = block_size ; /* for error reporting */
param - > link_used + = ( LSN_SIZE + PAGE_TYPE_SIZE ) ;
param - > used + = block_size ;
break ;
2006-04-11 15:45:10 +02:00
}
2007-01-18 20:38:14 +01:00
if ( _ma_check_bitmap_data ( info , page_type , pos / block_size ,
full_dir ? 0 : empty_space ,
& bitmap_pattern ) )
{
_ma_check_print_error ( param ,
" Page %9s: Wrong data in bitmap. Page_type: %d empty_space: %u Bitmap: %d " ,
llstr ( pos , llbuff ) , page_type , empty_space ,
bitmap_pattern ) ;
if ( param - > err_count + + > MAXERR | | ! ( param - > testflag & T_VERBOSE ) )
goto err ;
}
if ( ( enum en_page_type ) page_type = = BLOB_PAGE )
continue ;
param - > empty + = empty_space ;
if ( check_page_layout ( param , info , pos , page_buff , row_count ,
empty_space , & real_row_count ) )
goto err ;
if ( ( enum en_page_type ) page_type = = TAIL_PAGE )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
tail_count + = real_row_count ;
continue ;
2006-04-11 15:45:10 +02:00
}
2007-01-18 20:38:14 +01:00
if ( check_head_page ( param , info , record , extend , pos , page_buff ,
row_count ) )
goto err ;
2006-04-11 15:45:10 +02:00
}
2007-01-18 20:38:14 +01:00
_ma_scan_end_block_record ( info ) ;
if ( full_page_count ! = param - > full_page_count )
_ma_check_print_error ( param , " Full page count read through records was %s but we found %s pages while scanning table " ,
llstr ( param - > full_page_count , llbuff ) ,
llstr ( full_page_count , llbuff2 ) ) ;
if ( tail_count ! = param - > tail_count )
_ma_check_print_error ( param , " Tail count read through records was %s but we found %s tails while scanning table " ,
llstr ( param - > tail_count , llbuff ) ,
llstr ( tail_count , llbuff2 ) ) ;
/* Update splits to avoid warning */
info - > s - > state . split = param - > splits ;
info - > state - > del = param - > del_blocks ;
return param - > error_printed ! = 0 ;
err :
_ma_scan_end_block_record ( info ) ;
return 1 ;
}
2007-04-19 12:18:56 +02:00
/* Check that record-link is ok */
2007-01-18 20:38:14 +01:00
int maria_chk_data_link ( HA_CHECK * param , MARIA_HA * info , int extend )
{
int error ;
2007-07-02 19:45:15 +02:00
uchar * record ;
2007-01-18 20:38:14 +01:00
char llbuff [ 22 ] , llbuff2 [ 22 ] , llbuff3 [ 22 ] ;
DBUG_ENTER ( " maria_chk_data_link " ) ;
if ( ! ( param - > testflag & T_SILENT ) )
{
if ( extend )
puts ( " - check records and index references " ) ;
else
puts ( " - check record links " ) ;
}
2007-07-02 19:45:15 +02:00
if ( ! ( record = ( uchar * ) my_malloc ( info - > s - > base . pack_reclength , MYF ( 0 ) ) ) )
2007-01-18 20:38:14 +01:00
{
_ma_check_print_error ( param , " Not enough memory for record " ) ;
DBUG_RETURN ( - 1 ) ;
}
param - > records = param - > del_blocks = 0 ;
param - > used = param - > link_used = param - > splits = param - > del_length = 0 ;
param - > tmp_record_checksum = param - > glob_crc = 0 ;
param - > err_count = 0 ;
2007-01-26 12:32:02 +01:00
2007-01-18 20:38:14 +01:00
error = 0 ;
param - > empty = info - > s - > pack . header_length ;
bzero ( ( char * ) param - > tmp_key_crc ,
info - > s - > base . keys * sizeof ( param - > tmp_key_crc [ 0 ] ) ) ;
switch ( info - > s - > data_file_type ) {
case BLOCK_RECORD :
error = check_block_record ( param , info , extend , record ) ;
break ;
case STATIC_RECORD :
error = check_static_record ( param , info , extend , record ) ;
break ;
case DYNAMIC_RECORD :
error = check_dynamic_record ( param , info , extend , record ) ;
break ;
case COMPRESSED_RECORD :
error = check_compressed_record ( param , info , extend , record ) ;
break ;
} /* switch */
if ( error )
goto err ;
2006-04-11 15:45:10 +02:00
if ( param - > testflag & T_WRITE_LOOP )
{
VOID ( fputs ( " \r " , stdout ) ) ; VOID ( fflush ( stdout ) ) ;
}
2007-01-18 20:38:14 +01:00
if ( param - > records ! = info - > state - > records )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
_ma_check_print_error ( param ,
" Record-count is not ok; found %-10s Should be: %s " ,
llstr ( param - > records , llbuff ) ,
llstr ( info - > state - > records , llbuff2 ) ) ;
2006-04-11 15:45:10 +02:00
error = 1 ;
}
else if ( param - > record_checksum & &
2007-01-18 20:38:14 +01:00
param - > record_checksum ! = param - > tmp_record_checksum )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_error ( param ,
2007-01-18 20:38:14 +01:00
" Key pointers and record positions doesn't match " ) ;
2006-04-11 15:45:10 +02:00
error = 1 ;
}
else if ( param - > glob_crc ! = info - > state - > checksum & &
( info - > s - > options &
( HA_OPTION_CHECKSUM | HA_OPTION_COMPRESS_RECORD ) ) )
{
_ma_check_print_warning ( param ,
" Record checksum is not the same as checksum stored in the index file \n " ) ;
error = 1 ;
}
else if ( ! extend )
{
2007-01-18 20:38:14 +01:00
uint key ;
2006-04-11 15:45:10 +02:00
for ( key = 0 ; key < info - > s - > base . keys ; key + + )
{
2007-01-18 20:38:14 +01:00
if ( param - > tmp_key_crc [ key ] ! = param - > key_crc [ key ] & &
2006-04-11 15:45:10 +02:00
! ( info - > s - > keyinfo [ key ] . flag & ( HA_FULLTEXT | HA_SPATIAL ) ) )
{
_ma_check_print_error ( param , " Checksum for key: %2d doesn't match checksum for records " ,
key + 1 ) ;
error = 1 ;
}
}
}
2007-01-18 20:38:14 +01:00
if ( param - > del_length ! = info - > state - > empty )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_warning ( param ,
" Found %s deleted space. Should be %s " ,
2007-01-18 20:38:14 +01:00
llstr ( param - > del_length , llbuff2 ) ,
2006-04-11 15:45:10 +02:00
llstr ( info - > state - > empty , llbuff ) ) ;
}
2007-01-18 20:38:14 +01:00
if ( param - > used + param - > empty + param - > del_length ! =
info - > state - > data_file_length )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_warning ( param ,
2007-01-18 20:38:14 +01:00
" Found %s record data and %s unused data and %s deleted data " ,
llstr ( param - > used , llbuff ) ,
llstr ( param - > empty , llbuff2 ) ,
llstr ( param - > del_length , llbuff3 ) ) ;
2006-04-11 15:45:10 +02:00
_ma_check_print_warning ( param ,
2007-01-18 20:38:14 +01:00
" Total %s Should be: %s " ,
llstr ( ( param - > used + param - > empty + param - > del_length ) ,
llbuff ) ,
2006-04-11 15:45:10 +02:00
llstr ( info - > state - > data_file_length , llbuff2 ) ) ;
}
2007-01-18 20:38:14 +01:00
if ( param - > del_blocks ! = info - > state - > del )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_warning ( param ,
" Found %10s deleted blocks Should be: %s " ,
2007-01-18 20:38:14 +01:00
llstr ( param - > del_blocks , llbuff ) ,
2006-04-11 15:45:10 +02:00
llstr ( info - > state - > del , llbuff2 ) ) ;
}
2007-01-18 20:38:14 +01:00
if ( param - > splits ! = info - > s - > state . split )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_warning ( param ,
" Found %10s parts Should be: %s parts " ,
2007-01-18 20:38:14 +01:00
llstr ( param - > splits , llbuff ) ,
2006-04-11 15:45:10 +02:00
llstr ( info - > s - > state . split , llbuff2 ) ) ;
}
if ( param - > testflag & T_INFO )
{
if ( param - > warning_printed | | param - > error_printed )
puts ( " " ) ;
2007-01-18 20:38:14 +01:00
if ( param - > used ! = 0 & & ! param - > error_printed )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
if ( param - > records )
{
printf ( " Records:%18s M.recordlength:%9lu Packed:%14.0f%% \n " ,
llstr ( param - > records , llbuff ) ,
( long ) ( ( param - > used - param - > link_used ) / param - > records ) ,
( info - > s - > base . blobs ? 0.0 :
( ulonglong2double ( ( ulonglong ) info - > s - > base . reclength *
param - > records ) -
my_off_t2double ( param - > used ) ) /
ulonglong2double ( ( ulonglong ) info - > s - > base . reclength *
param - > records ) * 100.0 ) ) ;
printf ( " Recordspace used:%9.0f%% Empty space:%12d%% Blocks/Record: %6.2f \n " ,
( ulonglong2double ( param - > used - param - > link_used ) /
ulonglong2double ( param - > used - param - > link_used + param - > empty ) * 100.0 ) ,
( ! param - > records ? 100 :
( int ) ( ulonglong2double ( param - > del_length + param - > empty ) /
my_off_t2double ( param - > used ) * 100.0 ) ) ,
ulonglong2double ( param - > splits - param - > del_blocks ) /
param - > records ) ;
}
else
printf ( " Records:%18s \n " , " 0 " ) ;
2006-04-11 15:45:10 +02:00
}
printf ( " Record blocks:%12s Delete blocks:%10s \n " ,
2007-01-18 20:38:14 +01:00
llstr ( param - > splits - param - > del_blocks , llbuff ) ,
llstr ( param - > del_blocks , llbuff2 ) ) ;
2006-04-11 15:45:10 +02:00
printf ( " Record data: %12s Deleted data: %10s \n " ,
2007-01-18 20:38:14 +01:00
llstr ( param - > used - param - > link_used , llbuff ) ,
llstr ( param - > del_length , llbuff2 ) ) ;
2006-04-11 15:45:10 +02:00
printf ( " Lost space: %12s Linkdata: %10s \n " ,
2007-01-18 20:38:14 +01:00
llstr ( param - > empty , llbuff ) , llstr ( param - > link_used , llbuff2 ) ) ;
2006-04-11 15:45:10 +02:00
}
2007-07-02 19:45:15 +02:00
my_free ( ( uchar * ) record , MYF ( 0 ) ) ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( error ) ;
2007-01-18 20:38:14 +01:00
2006-04-11 15:45:10 +02:00
err :
2007-07-02 19:45:15 +02:00
my_free ( ( uchar * ) record , MYF ( 0 ) ) ;
2006-04-11 15:45:10 +02:00
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
DBUG_RETURN ( 1 ) ;
} /* maria_chk_data_link */
2007-07-01 15:20:57 +02:00
/*
Recover old table by reading each record and writing all keys
NOTES
2007-07-04 16:01:00 +02:00
Save new datafile - name in temp_filename .
We overwrite the index file as we go ( writekeys ( ) for example ) , so if we
crash during this the table is unusable and user ( or Recovery in the
future ) must repeat the REPAIR / OPTIMIZE operation . We could use a
temporary index file in the future ( drawback : more disk space ) .
2007-07-01 15:20:57 +02:00
IMPLEMENTATION ( for hard repair with block format )
- Create new , unrelated MARIA_HA of the table
- Create new datafile and associate it with new handler
- Reset all statistic information in new handler
- Copy all data to new handler with normal write operations
- Move state of new handler to old handler
- Close new handler
- Close data file in old handler
- Rename old data file to new data file .
- Reopen data file in old handler
*/
2006-04-11 15:45:10 +02:00
int maria_repair ( HA_CHECK * param , register MARIA_HA * info ,
2007-07-02 19:45:15 +02:00
char * name , int rep_quick )
2006-04-11 15:45:10 +02:00
{
2007-07-01 15:20:57 +02:00
int error , got_error = 1 ;
2006-04-11 15:45:10 +02:00
uint i ;
ha_rows start_records , new_header_length ;
my_off_t del ;
File new_file ;
MARIA_SHARE * share = info - > s ;
char llbuff [ 22 ] , llbuff2 [ 22 ] ;
MARIA_SORT_INFO sort_info ;
MARIA_SORT_PARAM sort_param ;
2007-07-01 15:20:57 +02:00
my_bool block_record , scan_inited = 0 ;
enum data_file_type org_data_file_type = info - > s - > data_file_type ;
Maria:
* Don't modify share->base.born_transactional; now it is a value carved
in stone at creation time. share->now_transactional is what can be
modified: it starts at born_transactional, can become false during
ALTER TABLE (when we want no logging), and restored later.
* Not resetting create_rename_lsn to 0 during delete_all or repair.
* when we temporarily disable transactionality, we also change
the page type to PAGECACHE_PLAIN_PAGE: it bypasses some work in the
page cache (optimization), and avoids assertions related to LSNs.
* Disable INSERT DELAYED for transactional tables, because
durability could not be guaranteed (insertion may even not happen)
mysys/mf_keycache.c:
comment
storage/maria/ha_maria.cc:
* a transactional table cannot do INSERT DELAYED
* ha_maria::save_transactional not needed anymore, as now instead
we don't modify MARIA_SHARE::MARIA_BASE_INFO::born_transactional
(born_transactional plays the role of save_transactional), and modify
MARIA_SHARE::now_transactional.
* REPAIR_TABLE log record is now logged by maria_repair()
* comment why we rely on born_transactional to know if we should
skipping a transaction.
* putting together two if()s which test for F_UNLCK
storage/maria/ha_maria.h:
ha_maria::save_transactional not needed anymore (moved to the C layer)
storage/maria/ma_blockrec.c:
* For the block record's code (writing/updating/deleting records),
all that counts is now_transactional, not born_transactional.
* As we now set the page type to PAGECACHE_PLAIN_PAGE for tables
which have now_transactional==FALSE, pagecache will not expect
a meaningful LSN for them in pagecache_unlock_by_link(), so
we can pass it LSN_IMPOSSIBLE.
storage/maria/ma_check.c:
* writing LOGREC_REPAIR_TABLE moves from ha_maria::repair()
to maria_repair(), sounds cleaner (less functions to export).
* when opening a table during REPAIR, don't use the realpath-ed name,
as this may fail if the table has symlinked files (maria_open()
would try to find the data and index file in the directory
of unique_file_name, it would fail if data and index files are in
different dirs); use the unresolved name, open_file_name, which is
the argument which was passed to the maria_open() which created 'info'.
storage/maria/ma_close.c:
assert that when a statement is done with a table, it cleans up
storage/maria/ma_create.c:
new name
storage/maria/ma_delete_all.c:
* using now_transactional
* no reason to reset create_rename_lsn during delete_all (a bug);
also no reason to do it during repair: it was put there because
a positive create_rename_lsn caused a call to check_and_set_lsn()
which asserted in DBUG_ASSERT(block->type == PAGECACHE_LSN_PAGE);
first solution was to use LSN_IMPOSSIBLE in _ma_unpin_all_pages() if
not transactional; but then in the case of ALTER TABLE, with
transactionality temporarily disabled, it asserted in
DBUG_ASSERT(LSN_VALID(lsn)) in pagecache_fwrite() (PAGECACHE_LSN_PAGE
page with zero LSN - bad). The additional solution is to use
PAGECACHE_PLAIN_PAGE when we disable transactionality temporarily: this
avoids checks on the LSN, and also bypasses (optimization) the "flush
log up to LSN" call when the pagecache flushes our page (in other
words, no WAL needed).
storage/maria/ma_delete_table.c:
use now_transactional
storage/maria/ma_locking.c:
assert that when a statement is done with a table, it cleans up.
storage/maria/ma_loghandler.c:
* now_transactional should be used to test if we want a log record.
* Assertions to make sure dummy_transaction_object is not spoilt
by its many users.
storage/maria/ma_open.c:
base.transactional -> base.born_transactional
storage/maria/ma_pagecache.c:
missing name for page's type. Comment for future.
storage/maria/ma_rename.c:
use now_transactional
storage/maria/maria_chk.c:
use born_transactional
storage/maria/maria_def.h:
MARIA_BASE_INFO::transactional renamed to born_transactional.
MARIA_SHARE::now_transactional introduced.
_ma_repair_write_log_record() is made local to ma_check.c.
Macros to temporarily disable, and re-enable, transactionality for a
table.
storage/maria/maria_read_log.c:
assertions and using the new macros. Adding a forgotten resetting
when we finally close all tables.
2007-07-03 15:20:41 +02:00
myf sync_dir = ( ( share - > now_transactional & & ! share - > temporary ) ?
MY_SYNC_DIR : 0 ) ;
2006-04-11 15:45:10 +02:00
DBUG_ENTER ( " maria_repair " ) ;
bzero ( ( char * ) & sort_info , sizeof ( sort_info ) ) ;
bzero ( ( char * ) & sort_param , sizeof ( sort_param ) ) ;
start_records = info - > state - > records ;
new_header_length = ( param - > testflag & T_UNPACK ) ? 0L :
share - > pack . header_length ;
new_file = - 1 ;
sort_param . sort_info = & sort_info ;
2007-07-01 15:20:57 +02:00
block_record = org_data_file_type = = BLOCK_RECORD ;
sort_info . info = sort_info . new_info = info ;
bzero ( & info - > rec_cache , sizeof ( info - > rec_cache ) ) ;
2006-04-11 15:45:10 +02:00
if ( ! ( param - > testflag & T_SILENT ) )
{
printf ( " - recovering (with keycache) MARIA-table '%s' \n " , name ) ;
printf ( " Data records: %s \n " , llstr ( info - > state - > records , llbuff ) ) ;
}
param - > testflag | = T_REP ; /* for easy checking */
if ( info - > s - > options & ( HA_OPTION_CHECKSUM | HA_OPTION_COMPRESS_RECORD ) )
param - > testflag | = T_CALC_CHECKSUM ;
Fix for errors during:
"./mtr --mysqld=--default-storage-engine=maria mysqldump".
First problem was use of INSERT DELAYED and MERGE tables without
specifying that the tables to create should always be MyISAM.
After fixing this, no rows were returned by the final SELECT of the
"BUG 19025" portion of the test. Simplified problem was:
LOCK TABLES `t1` WRITE;
/*!40000 ALTER TABLE `t1` DISABLE KEYS */;
INSERT INTO `t1` VALUES ('bla',1000),('bla',1001),('bla',1002);
/*!40000 ALTER TABLE `t1` ENABLE KEYS */;
UNLOCK TABLES;
select * from t1;
The SELECT would find no rows. Reason: ENABLE KEYS does a maria_repair();
but data pages are still in the page cache and not on disk (because
they were not flushed because maria_lock_database(F_UNLCK) was
not called at the end of INSERT because under LOCK TABLES).
At start of maria_repair(), sort_info.filelength is set to the
physical size of the data file (=> too small because pages are in
cache and not on disk).
Then in sort_get_next_record(), when seeing end-of-file, this is done:
sort_param->max_pos= sort_info->filelength;
Further in maria_repair(), this is done:
info->state->data_file_length= sort_param.max_pos;
and so data_file_length is smaller (0) than reality (16384).
This makes SELECT think EOF is where it is not, and thus find
no rows.
This is fixed by flushing all data pages at the start of maria_repair()
(no performance problem is introduced as in common cases where
ALTER TABLE is not under LOCK TABLES, the previous statement did
this flush anyway).
Another reason to do this flush is that, if not doing it, old cached
pages might go down onto the repaired data file at a later point
and thus corrupt it (assume a REPAIR non-QUICK).
A similar bug is fixed:
LOCK TABLES WRITE; INSERT; CHECK TABLE;
reports "Size of datafile is: 0 Should be: 16384"
again because the physical size was read without a preliminary
page cache flush.
mysql-test/r/maria.result:
result update
mysql-test/r/mysqldump.result:
result update
mysql-test/t/maria.test:
adding test for fixed bug in LOCK TABLES + CHECK TABLE + block format.
Disabling portion which hits "incorrect key file" but still
letting it make the test fail (Monty to fix).
mysql-test/t/mysqldump.test:
in places where test expects engine to support INSERT DELAYED and
be includable in a MERGE table, i.e. be MyISAM, we explicitely
ask for MyISAM.
storage/maria/ma_check.c:
Before reading the data file's physical size with my_seek(MY_SEEK_END)
during maria_chk_size() and maria_repair(), we must flush this
data file, otherwise physical size is misleading and leads to
- CHECK TABLE finding the table corrupted ("size of datafile should be"
error)
- ALTER TABLE ENABLE KEYS losing rows (maria_repair()
setting data_file_length to a too small value => later SELECT does
not find rows though they are in the data file).
This fixes the "mysqldump.test" failure.
sort_info.filelength contains the physical size, re-using it.
2007-08-07 18:23:49 +02:00
/*
The physical size of the data file is sometimes used during repair ( see
sort_info . filelength further below ) ; we need to flush to have it exact .
*/
if ( _ma_flush_table_files ( info , MARIA_FLUSH_DATA , FLUSH_FORCE_WRITE ,
FLUSH_KEEP ) )
goto err ;
2006-04-11 15:45:10 +02:00
if ( ! rep_quick )
{
/* Get real path for data file */
2007-01-18 20:38:14 +01:00
if ( ( new_file = my_create ( fn_format ( param - > temp_filename ,
share - > data_file_name , " " ,
DATA_TMP_EXT , 2 + 4 ) ,
0 , param - > tmpfile_createflag ,
MYF ( 0 ) ) ) < 0 )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_error ( param , " Can't create new tempfile: '%s' " ,
param - > temp_filename ) ;
goto err ;
}
2006-10-11 18:30:16 +02:00
if ( new_header_length & &
2007-04-04 22:37:09 +02:00
maria_filecopy ( param , new_file , info - > dfile . file , 0L ,
new_header_length , " datafile-header " ) )
2006-04-11 15:45:10 +02:00
goto err ;
info - > s - > state . dellink = HA_OFFSET_ERROR ;
2007-07-01 15:20:57 +02:00
info - > rec_cache . file = new_file ;
if ( share - > data_file_type = = BLOCK_RECORD | |
( ( param - > testflag & T_UNPACK ) & &
share - > state . header . org_data_file_type = = BLOCK_RECORD ) )
{
MARIA_HA * new_info ;
Maria:
* Don't modify share->base.born_transactional; now it is a value carved
in stone at creation time. share->now_transactional is what can be
modified: it starts at born_transactional, can become false during
ALTER TABLE (when we want no logging), and restored later.
* Not resetting create_rename_lsn to 0 during delete_all or repair.
* when we temporarily disable transactionality, we also change
the page type to PAGECACHE_PLAIN_PAGE: it bypasses some work in the
page cache (optimization), and avoids assertions related to LSNs.
* Disable INSERT DELAYED for transactional tables, because
durability could not be guaranteed (insertion may even not happen)
mysys/mf_keycache.c:
comment
storage/maria/ha_maria.cc:
* a transactional table cannot do INSERT DELAYED
* ha_maria::save_transactional not needed anymore, as now instead
we don't modify MARIA_SHARE::MARIA_BASE_INFO::born_transactional
(born_transactional plays the role of save_transactional), and modify
MARIA_SHARE::now_transactional.
* REPAIR_TABLE log record is now logged by maria_repair()
* comment why we rely on born_transactional to know if we should
skipping a transaction.
* putting together two if()s which test for F_UNLCK
storage/maria/ha_maria.h:
ha_maria::save_transactional not needed anymore (moved to the C layer)
storage/maria/ma_blockrec.c:
* For the block record's code (writing/updating/deleting records),
all that counts is now_transactional, not born_transactional.
* As we now set the page type to PAGECACHE_PLAIN_PAGE for tables
which have now_transactional==FALSE, pagecache will not expect
a meaningful LSN for them in pagecache_unlock_by_link(), so
we can pass it LSN_IMPOSSIBLE.
storage/maria/ma_check.c:
* writing LOGREC_REPAIR_TABLE moves from ha_maria::repair()
to maria_repair(), sounds cleaner (less functions to export).
* when opening a table during REPAIR, don't use the realpath-ed name,
as this may fail if the table has symlinked files (maria_open()
would try to find the data and index file in the directory
of unique_file_name, it would fail if data and index files are in
different dirs); use the unresolved name, open_file_name, which is
the argument which was passed to the maria_open() which created 'info'.
storage/maria/ma_close.c:
assert that when a statement is done with a table, it cleans up
storage/maria/ma_create.c:
new name
storage/maria/ma_delete_all.c:
* using now_transactional
* no reason to reset create_rename_lsn during delete_all (a bug);
also no reason to do it during repair: it was put there because
a positive create_rename_lsn caused a call to check_and_set_lsn()
which asserted in DBUG_ASSERT(block->type == PAGECACHE_LSN_PAGE);
first solution was to use LSN_IMPOSSIBLE in _ma_unpin_all_pages() if
not transactional; but then in the case of ALTER TABLE, with
transactionality temporarily disabled, it asserted in
DBUG_ASSERT(LSN_VALID(lsn)) in pagecache_fwrite() (PAGECACHE_LSN_PAGE
page with zero LSN - bad). The additional solution is to use
PAGECACHE_PLAIN_PAGE when we disable transactionality temporarily: this
avoids checks on the LSN, and also bypasses (optimization) the "flush
log up to LSN" call when the pagecache flushes our page (in other
words, no WAL needed).
storage/maria/ma_delete_table.c:
use now_transactional
storage/maria/ma_locking.c:
assert that when a statement is done with a table, it cleans up.
storage/maria/ma_loghandler.c:
* now_transactional should be used to test if we want a log record.
* Assertions to make sure dummy_transaction_object is not spoilt
by its many users.
storage/maria/ma_open.c:
base.transactional -> base.born_transactional
storage/maria/ma_pagecache.c:
missing name for page's type. Comment for future.
storage/maria/ma_rename.c:
use now_transactional
storage/maria/maria_chk.c:
use born_transactional
storage/maria/maria_def.h:
MARIA_BASE_INFO::transactional renamed to born_transactional.
MARIA_SHARE::now_transactional introduced.
_ma_repair_write_log_record() is made local to ma_check.c.
Macros to temporarily disable, and re-enable, transactionality for a
table.
storage/maria/maria_read_log.c:
assertions and using the new macros. Adding a forgotten resetting
when we finally close all tables.
2007-07-03 15:20:41 +02:00
/**
@ todo RECOVERY it ' s a bit worrying to have two MARIA_SHARE on the
same index file :
- Checkpoint will see them as two tables
- are we sure that new_info never flushes an in - progress state
to the index file ? And how to prevent Checkpoint from doing that ?
- in the close future maria_close ( ) will write the state . . .
*/
if ( ! ( sort_info . new_info = maria_open ( info - > s - > open_file_name , O_RDWR ,
2007-07-01 15:20:57 +02:00
HA_OPEN_COPY | HA_OPEN_FOR_REPAIR ) ) )
goto err ;
new_info = sort_info . new_info ;
change_data_file_descriptor ( new_info , new_file ) ;
maria_lock_database ( new_info , F_EXTRA_LCK ) ;
if ( ( param - > testflag & T_UNPACK ) & &
share - > data_file_type = = COMPRESSED_RECORD )
{
( * new_info - > s - > once_end ) ( new_info - > s ) ;
( * new_info - > s - > end ) ( new_info ) ;
restore_data_file_type ( new_info - > s ) ;
_ma_setup_functions ( new_info - > s ) ;
if ( ( * new_info - > s - > once_init ) ( new_info - > s , new_file ) | |
( * new_info - > s - > init ) ( new_info ) )
goto err ;
}
_ma_reset_status ( sort_info . new_info ) ;
2007-08-08 22:27:01 +02:00
# ifdef ASK_MONTY /* cf maria_create() */
/*
without this call , a REPAIR on an empty table leaves the data file of
size 0 , which sounds reasonable .
*/
2007-07-01 15:20:57 +02:00
if ( _ma_initialize_data_file ( sort_info . new_info - > s , new_file ) )
goto err ;
2007-08-08 22:27:01 +02:00
# endif
2007-07-01 15:20:57 +02:00
block_record = 1 ;
}
}
if ( org_data_file_type ! = BLOCK_RECORD )
{
/* We need a read buffer to read rows in big blocks */
if ( init_io_cache ( & param - > read_cache , info - > dfile . file ,
( uint ) param - > read_buffer_length ,
READ_CACHE , share - > pack . header_length , 1 , MYF ( MY_WME ) ) )
goto err ;
2006-04-11 15:45:10 +02:00
}
2007-07-01 15:20:57 +02:00
if ( sort_info . new_info - > s - > data_file_type ! = BLOCK_RECORD )
{
/* When writing to not block records, we need a write buffer */
if ( ! rep_quick )
if ( init_io_cache ( & info - > rec_cache , new_file ,
( uint ) param - > write_buffer_length ,
WRITE_CACHE , new_header_length , 1 ,
MYF ( MY_WME | MY_WAIT_IF_FULL ) ) )
goto err ;
info - > opt_flag | = WRITE_CACHE_USED ;
}
else
{
scan_inited = 1 ;
if ( maria_scan_init ( sort_info . info ) )
goto err ;
}
2007-07-04 11:39:19 +02:00
if ( ! ( sort_param . record = ( uchar * ) my_malloc ( ( uint ) share - > base . pack_reclength ,
2007-07-01 15:20:57 +02:00
MYF ( 0 ) ) ) | |
_ma_alloc_buffer ( & sort_param . rec_buff , & sort_param . rec_buff_size ,
info - > s - > base . default_rec_buff_size ) )
{
_ma_check_print_error ( param , " Not enough memory for extra record " ) ;
goto err ;
2006-04-11 15:45:10 +02:00
}
2007-07-01 15:20:57 +02:00
2006-04-11 15:45:10 +02:00
sort_info . param = param ;
sort_param . read_cache = param - > read_cache ;
sort_param . pos = sort_param . max_pos = share - > pack . header_length ;
sort_param . filepos = new_header_length ;
param - > read_cache . end_of_file = sort_info . filelength =
2007-04-04 22:37:09 +02:00
my_seek ( info - > dfile . file , 0L , MY_SEEK_END , MYF ( 0 ) ) ;
2006-04-11 15:45:10 +02:00
sort_info . dupp = 0 ;
sort_param . fix_datafile = ( my_bool ) ( ! rep_quick ) ;
sort_param . master = 1 ;
sort_info . max_records = ~ ( ha_rows ) 0 ;
set_data_file_type ( & sort_info , share ) ;
del = info - > state - > del ;
info - > state - > records = info - > state - > del = share - > state . split = 0 ;
info - > state - > empty = 0 ;
param - > glob_crc = 0 ;
if ( param - > testflag & T_CALC_CHECKSUM )
2006-12-19 19:15:53 +01:00
sort_param . calc_checksum = 1 ;
2006-04-11 15:45:10 +02:00
info - > update = ( short ) ( HA_STATE_CHANGED | HA_STATE_ROW_CHANGED ) ;
/*
Clear all keys . Note that all key blocks allocated until now remain
" dead " parts of the key file . ( Bug # 4692 )
*/
for ( i = 0 ; i < info - > s - > base . keys ; i + + )
share - > state . key_root [ i ] = HA_OFFSET_ERROR ;
/* Drop the delete chain. */
2007-01-18 20:38:14 +01:00
share - > state . key_del = HA_OFFSET_ERROR ;
2006-04-11 15:45:10 +02:00
/*
If requested , activate ( enable ) all keys in key_map . In this case ,
all indexes will be ( re - ) built .
*/
if ( param - > testflag & T_CREATE_MISSING_KEYS )
maria_set_all_keys_active ( share - > state . key_map , share - > base . keys ) ;
info - > state - > key_file_length = share - > base . keystart ;
maria_lock_memory ( param ) ; /* Everything is alloced */
2007-07-01 15:20:57 +02:00
sort_info . org_data_file_type = info - > s - > data_file_type ;
2006-04-11 15:45:10 +02:00
/* Re-create all keys, which are set in key_map. */
while ( ! ( error = sort_get_next_record ( & sort_param ) ) )
{
2007-07-01 15:20:57 +02:00
if ( block_record & & _ma_sort_write_record ( & sort_param ) )
goto err ;
2006-12-19 19:15:53 +01:00
if ( writekeys ( & sort_param ) )
2006-04-11 15:45:10 +02:00
{
if ( my_errno ! = HA_ERR_FOUND_DUPP_KEY )
goto err ;
2007-07-02 19:45:15 +02:00
DBUG_DUMP ( " record " , ( uchar * ) sort_param . record , share - > base . pack_reclength ) ;
2006-04-11 15:45:10 +02:00
_ma_check_print_info ( param , " Duplicate key %2d for record at %10s against new record at %10s " ,
info - > errkey + 1 ,
llstr ( sort_param . start_recpos , llbuff ) ,
2007-01-18 20:38:14 +01:00
llstr ( info - > dup_key_pos , llbuff2 ) ) ;
2006-04-11 15:45:10 +02:00
if ( param - > testflag & T_VERBOSE )
{
VOID ( _ma_make_key ( info , ( uint ) info - > errkey , info - > lastkey ,
sort_param . record , 0L ) ) ;
_ma_print_key ( stdout , share - > keyinfo [ info - > errkey ] . seg , info - > lastkey ,
USE_WHOLE_KEY ) ;
}
sort_info . dupp + + ;
if ( ( param - > testflag & ( T_FORCE_UNIQUENESS | T_QUICK ) ) = = T_QUICK )
{
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
param - > error_printed = 1 ;
goto err ;
}
continue ;
}
2007-07-01 15:20:57 +02:00
if ( ! block_record & & _ma_sort_write_record ( & sort_param ) )
2006-04-11 15:45:10 +02:00
goto err ;
}
if ( error > 0 | | maria_write_data_suffix ( & sort_info , ( my_bool ) ! rep_quick ) | |
flush_io_cache ( & info - > rec_cache ) | | param - > read_cache . error < 0 )
goto err ;
if ( param - > testflag & T_WRITE_LOOP )
{
VOID ( fputs ( " \r " , stdout ) ) ; VOID ( fflush ( stdout ) ) ;
}
2007-04-04 22:37:09 +02:00
if ( my_chsize ( share - > kfile . file , info - > state - > key_file_length , 0 , MYF ( 0 ) ) )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_warning ( param ,
" Can't change size of indexfile, error: %d " ,
my_errno ) ;
goto err ;
}
if ( rep_quick & & del + sort_info . dupp ! = info - > state - > del )
{
_ma_check_print_error ( param , " Couldn't fix table with quick recovery: Found wrong number of deleted records " ) ;
_ma_check_print_error ( param , " Run recovery again without -q " ) ;
param - > retry_repair = 1 ;
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
goto err ;
}
2007-07-01 15:20:57 +02:00
2006-04-11 15:45:10 +02:00
if ( param - > testflag & T_SAFE_REPAIR )
{
/* Don't repair if we loosed more than one row */
2007-07-01 15:20:57 +02:00
if ( sort_info . new_info - > state - > records + 1 < start_records )
2006-04-11 15:45:10 +02:00
{
info - > state - > records = start_records ;
goto err ;
}
}
if ( ! rep_quick )
{
2007-07-01 15:20:57 +02:00
if ( sort_info . new_info ! = sort_info . info )
{
MARIA_STATE_INFO save_state = sort_info . new_info - > s - > state ;
if ( maria_close ( sort_info . new_info ) )
{
_ma_check_print_error ( param , " Got error %d on close " , my_errno ) ;
goto err ;
}
copy_data_file_state ( & info - > s - > state , & save_state ) ;
new_file = - 1 ;
}
else
info - > state - > data_file_length = sort_param . filepos ;
2006-04-11 15:45:10 +02:00
share - > state . version = ( ulong ) time ( ( time_t * ) 0 ) ; /* Force reopen */
2007-07-01 15:20:57 +02:00
/* Replace the actual file with the temporary file */
if ( new_file > = 0 )
my_close ( new_file , MYF ( MY_WME ) ) ;
Fix for
./mtr --mysqld=--default-storage-engine=maria --mem ps:
I got "can't sync on file UNOPENED" among the messages of REPAIR TABLE;
due to a missing setting of bitmap.file.file to -1.
Maria had two names "Maria" and "MARIA", using one now: "MARIA".
storage/maria/ha_maria.cc:
plug.in uses "MARIA". Some code apparently picks the name from
plug.in (SHOW CREATE TABLE, run ps.test on Maria tables), other from
mysql_declare_plugin (SHOW CREATE TABLE on partitioned tables, run
partition.test with Maria tables), better make names identical.
storage/maria/ma_check.c:
running ps.test on Maria tables I got "can't sync on file UNOPENED"
among the messages of REPAIR TABLE. That was due to maria_repair()
closing the data file, setting info->dfile.file to -1 to prevent
a wrong double close, but forgetting to also set
info->s->bitmap.file.file to -1; it left it unchanged and so,
when close_thread_tables() closed the old version of the repaired
table, _ma_once_end_block_record() tried to fsync the closed
descriptor, resulting in a message.
Basically, when setting info->dfile.file to something it's always
safe and recommended to set bitmap.file.file to the same value
as it's just a copy of the same descriptor see _ma_bitmap_init().
Using change_data_file_descriptor() for that.
Changing that function to use MY_WME as it looks safe.
storage/maria/ma_close.c:
no need to make the index file durable if table is not transactional
2007-08-08 18:59:57 +02:00
new_file = - 1 ;
change_data_file_descriptor ( info , - 1 ) ;
2007-07-01 15:20:57 +02:00
if ( maria_change_to_newfile ( share - > data_file_name , MARIA_NAME_DEXT ,
DATA_TMP_EXT ,
( param - > testflag & T_BACKUP_DATA ?
2007-07-01 15:48:57 +02:00
MYF ( MY_REDEL_MAKE_BACKUP ) : MYF ( 0 ) ) |
sync_dir ) | |
2007-07-01 15:20:57 +02:00
_ma_open_datafile ( info , share , - 1 ) )
{
goto err ;
}
2006-04-11 15:45:10 +02:00
}
else
{
2007-07-01 15:20:57 +02:00
info - > state - > data_file_length = sort_param . max_pos ;
2006-04-11 15:45:10 +02:00
}
if ( param - > testflag & T_CALC_CHECKSUM )
2007-07-01 15:20:57 +02:00
info - > state - > checksum = param - > glob_crc ;
2006-04-11 15:45:10 +02:00
if ( ! ( param - > testflag & T_SILENT ) )
{
if ( start_records ! = info - > state - > records )
printf ( " Data records: %s \n " , llstr ( info - > state - > records , llbuff ) ) ;
if ( sort_info . dupp )
_ma_check_print_warning ( param ,
" %s records have been removed " ,
llstr ( sort_info . dupp , llbuff ) ) ;
}
Maria:
* Don't modify share->base.born_transactional; now it is a value carved
in stone at creation time. share->now_transactional is what can be
modified: it starts at born_transactional, can become false during
ALTER TABLE (when we want no logging), and restored later.
* Not resetting create_rename_lsn to 0 during delete_all or repair.
* when we temporarily disable transactionality, we also change
the page type to PAGECACHE_PLAIN_PAGE: it bypasses some work in the
page cache (optimization), and avoids assertions related to LSNs.
* Disable INSERT DELAYED for transactional tables, because
durability could not be guaranteed (insertion may even not happen)
mysys/mf_keycache.c:
comment
storage/maria/ha_maria.cc:
* a transactional table cannot do INSERT DELAYED
* ha_maria::save_transactional not needed anymore, as now instead
we don't modify MARIA_SHARE::MARIA_BASE_INFO::born_transactional
(born_transactional plays the role of save_transactional), and modify
MARIA_SHARE::now_transactional.
* REPAIR_TABLE log record is now logged by maria_repair()
* comment why we rely on born_transactional to know if we should
skipping a transaction.
* putting together two if()s which test for F_UNLCK
storage/maria/ha_maria.h:
ha_maria::save_transactional not needed anymore (moved to the C layer)
storage/maria/ma_blockrec.c:
* For the block record's code (writing/updating/deleting records),
all that counts is now_transactional, not born_transactional.
* As we now set the page type to PAGECACHE_PLAIN_PAGE for tables
which have now_transactional==FALSE, pagecache will not expect
a meaningful LSN for them in pagecache_unlock_by_link(), so
we can pass it LSN_IMPOSSIBLE.
storage/maria/ma_check.c:
* writing LOGREC_REPAIR_TABLE moves from ha_maria::repair()
to maria_repair(), sounds cleaner (less functions to export).
* when opening a table during REPAIR, don't use the realpath-ed name,
as this may fail if the table has symlinked files (maria_open()
would try to find the data and index file in the directory
of unique_file_name, it would fail if data and index files are in
different dirs); use the unresolved name, open_file_name, which is
the argument which was passed to the maria_open() which created 'info'.
storage/maria/ma_close.c:
assert that when a statement is done with a table, it cleans up
storage/maria/ma_create.c:
new name
storage/maria/ma_delete_all.c:
* using now_transactional
* no reason to reset create_rename_lsn during delete_all (a bug);
also no reason to do it during repair: it was put there because
a positive create_rename_lsn caused a call to check_and_set_lsn()
which asserted in DBUG_ASSERT(block->type == PAGECACHE_LSN_PAGE);
first solution was to use LSN_IMPOSSIBLE in _ma_unpin_all_pages() if
not transactional; but then in the case of ALTER TABLE, with
transactionality temporarily disabled, it asserted in
DBUG_ASSERT(LSN_VALID(lsn)) in pagecache_fwrite() (PAGECACHE_LSN_PAGE
page with zero LSN - bad). The additional solution is to use
PAGECACHE_PLAIN_PAGE when we disable transactionality temporarily: this
avoids checks on the LSN, and also bypasses (optimization) the "flush
log up to LSN" call when the pagecache flushes our page (in other
words, no WAL needed).
storage/maria/ma_delete_table.c:
use now_transactional
storage/maria/ma_locking.c:
assert that when a statement is done with a table, it cleans up.
storage/maria/ma_loghandler.c:
* now_transactional should be used to test if we want a log record.
* Assertions to make sure dummy_transaction_object is not spoilt
by its many users.
storage/maria/ma_open.c:
base.transactional -> base.born_transactional
storage/maria/ma_pagecache.c:
missing name for page's type. Comment for future.
storage/maria/ma_rename.c:
use now_transactional
storage/maria/maria_chk.c:
use born_transactional
storage/maria/maria_def.h:
MARIA_BASE_INFO::transactional renamed to born_transactional.
MARIA_SHARE::now_transactional introduced.
_ma_repair_write_log_record() is made local to ma_check.c.
Macros to temporarily disable, and re-enable, transactionality for a
table.
storage/maria/maria_read_log.c:
assertions and using the new macros. Adding a forgotten resetting
when we finally close all tables.
2007-07-03 15:20:41 +02:00
got_error = sync_dir ? write_log_record_for_repair ( param , info ) : 0 ;
2006-04-11 15:45:10 +02:00
/* If invoked by external program that uses thr_lock */
if ( & share - > state . state ! = info - > state )
memcpy ( & share - > state . state , info - > state , sizeof ( * info - > state ) ) ;
err :
2007-07-01 15:20:57 +02:00
if ( scan_inited )
maria_scan_end ( sort_info . info ) ;
2006-04-11 15:45:10 +02:00
if ( got_error )
{
if ( ! param - > error_printed )
_ma_check_print_error ( param , " %d for record at pos %s " , my_errno ,
llstr ( sort_param . start_recpos , llbuff ) ) ;
2007-07-01 15:20:57 +02:00
if ( sort_info . new_info & & sort_info . new_info ! = sort_info . info )
{
2007-08-09 10:51:15 +02:00
# ifdef ASK_MONTY
/*
grepping for " dfile.file= "
shows several places ( ma_check . c , ma_panic . c , ma_extra . c ) where we
modify dfile . file without modifying share - > bitmap . file . file ; those
sound like bugs because the two variables are normally copies of each
other in BLOCK_RECORD ( and in other record formats it does not hurt to
change the unused share - > bitmap . file . file ) .
It does matter , because if we close dfile . file , set dfile . file to - 1 ,
but leave bitmap . file . file to its positive value , maria_close ( ) will
close a file which it is not allowed to ( maybe even a file in another
engine or mysqld ! ) .
*/
# endif
2007-07-01 15:20:57 +02:00
sort_info . new_info - > dfile . file = - 1 ;
maria_close ( sort_info . new_info ) ;
}
2006-04-11 15:45:10 +02:00
if ( new_file > = 0 )
{
VOID ( my_close ( new_file , MYF ( 0 ) ) ) ;
2007-01-18 20:38:14 +01:00
VOID ( my_delete ( param - > temp_filename , MYF ( MY_WME ) ) ) ;
2006-04-11 15:45:10 +02:00
info - > rec_cache . file = - 1 ; /* don't flush data to new_file, it's closed */
}
maria_mark_crashed_on_repair ( info ) ;
}
2007-01-18 20:38:14 +01:00
my_free ( sort_param . rec_buff , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
2006-04-11 15:45:10 +02:00
my_free ( sort_param . record , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
my_free ( sort_info . buff , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
VOID ( end_io_cache ( & param - > read_cache ) ) ;
info - > opt_flag & = ~ ( READ_CACHE_USED | WRITE_CACHE_USED ) ;
VOID ( end_io_cache ( & info - > rec_cache ) ) ;
2007-04-04 22:37:09 +02:00
got_error | = _ma_flush_blocks ( param , share - > pagecache , & share - > kfile ) ;
2007-01-18 20:38:14 +01:00
if ( ! got_error & & ( param - > testflag & T_UNPACK ) )
restore_data_file_type ( share ) ;
2006-04-11 15:45:10 +02:00
share - > state . changed | = ( STATE_NOT_OPTIMIZED_KEYS | STATE_NOT_SORTED_PAGES |
STATE_NOT_ANALYZED ) ;
2007-04-05 13:38:05 +02:00
share - > state . changed & = ~ STATE_NOT_OPTIMIZED_ROWS ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( got_error ) ;
}
2007-01-23 20:13:26 +01:00
/* Uppdate keyfile when doing repair */
2006-04-11 15:45:10 +02:00
2006-12-19 19:15:53 +01:00
static int writekeys ( MARIA_SORT_PARAM * sort_param )
2006-04-11 15:45:10 +02:00
{
register uint i ;
2007-07-02 19:45:15 +02:00
uchar * key ;
2006-12-19 19:15:53 +01:00
MARIA_HA * info = sort_param - > sort_info - > info ;
2007-07-02 19:45:15 +02:00
uchar * buff = sort_param - > record ;
2006-12-19 19:15:53 +01:00
my_off_t filepos = sort_param - > filepos ;
2006-04-11 15:45:10 +02:00
DBUG_ENTER ( " writekeys " ) ;
2007-01-18 20:38:14 +01:00
key = info - > lastkey + info - > s - > base . max_key_length ;
2006-04-11 15:45:10 +02:00
for ( i = 0 ; i < info - > s - > base . keys ; i + + )
{
if ( maria_is_key_active ( info - > s - > state . key_map , i ) )
{
if ( info - > s - > keyinfo [ i ] . flag & HA_FULLTEXT )
{
if ( _ma_ft_add ( info , i , ( char * ) key , buff , filepos ) )
goto err ;
}
# ifdef HAVE_SPATIAL
else if ( info - > s - > keyinfo [ i ] . flag & HA_SPATIAL )
{
uint key_length = _ma_make_key ( info , i , key , buff , filepos ) ;
if ( maria_rtree_insert ( info , i , key , key_length ) )
goto err ;
}
# endif /*HAVE_SPATIAL*/
else
{
uint key_length = _ma_make_key ( info , i , key , buff , filepos ) ;
if ( _ma_ck_write ( info , i , key , key_length ) )
goto err ;
}
}
}
DBUG_RETURN ( 0 ) ;
err :
if ( my_errno = = HA_ERR_FOUND_DUPP_KEY )
{
info - > errkey = ( int ) i ; /* This key was found */
while ( i - - > 0 )
{
if ( maria_is_key_active ( info - > s - > state . key_map , i ) )
{
if ( info - > s - > keyinfo [ i ] . flag & HA_FULLTEXT )
{
if ( _ma_ft_del ( info , i , ( char * ) key , buff , filepos ) )
break ;
}
else
{
uint key_length = _ma_make_key ( info , i , key , buff , filepos ) ;
if ( _ma_ck_delete ( info , i , key , key_length ) )
break ;
}
}
}
}
/* Remove checksum that was added to glob_crc in sort_get_next_record */
2006-12-19 19:15:53 +01:00
if ( sort_param - > calc_checksum )
2007-01-26 12:32:02 +01:00
sort_param - > sort_info - > param - > glob_crc - = info - > cur_row . checksum ;
2006-04-11 15:45:10 +02:00
DBUG_PRINT ( " error " , ( " errno: %d " , my_errno ) ) ;
DBUG_RETURN ( - 1 ) ;
} /* writekeys */
/* Change all key-pointers that points to a records */
2007-07-02 19:45:15 +02:00
int maria_movepoint ( register MARIA_HA * info , uchar * record ,
2007-01-18 20:38:14 +01:00
MARIA_RECORD_POS oldpos , MARIA_RECORD_POS newpos ,
uint prot_key )
2006-04-11 15:45:10 +02:00
{
register uint i ;
2007-07-02 19:45:15 +02:00
uchar * key ;
2006-04-11 15:45:10 +02:00
uint key_length ;
DBUG_ENTER ( " maria_movepoint " ) ;
2007-01-18 20:38:14 +01:00
key = info - > lastkey + info - > s - > base . max_key_length ;
2006-04-11 15:45:10 +02:00
for ( i = 0 ; i < info - > s - > base . keys ; i + + )
{
if ( i ! = prot_key & & maria_is_key_active ( info - > s - > state . key_map , i ) )
{
key_length = _ma_make_key ( info , i , key , record , oldpos ) ;
if ( info - > s - > keyinfo [ i ] . flag & HA_NOSAME )
{ /* Change pointer direct */
uint nod_flag ;
MARIA_KEYDEF * keyinfo ;
keyinfo = info - > s - > keyinfo + i ;
if ( _ma_search ( info , keyinfo , key , USE_WHOLE_KEY ,
( uint ) ( SEARCH_SAME | SEARCH_SAVE_BUFF ) ,
info - > s - > state . key_root [ i ] ) )
DBUG_RETURN ( - 1 ) ;
nod_flag = _ma_test_if_nod ( info - > buff ) ;
_ma_dpointer ( info , info - > int_keypos - nod_flag -
info - > s - > rec_reflength , newpos ) ;
if ( _ma_write_keypage ( info , keyinfo , info - > last_keypage ,
DFLT_INIT_HITS , info - > buff ) )
DBUG_RETURN ( - 1 ) ;
}
else
{ /* Change old key to new */
if ( _ma_ck_delete ( info , i , key , key_length ) )
DBUG_RETURN ( - 1 ) ;
key_length = _ma_make_key ( info , i , key , record , newpos ) ;
if ( _ma_ck_write ( info , i , key , key_length ) )
DBUG_RETURN ( - 1 ) ;
}
}
}
DBUG_RETURN ( 0 ) ;
} /* maria_movepoint */
/* Tell system that we want all memory for our cache */
void maria_lock_memory ( HA_CHECK * param __attribute__ ( ( unused ) ) )
{
# ifdef SUN_OS /* Key-cacheing thrases on sun 4.1 */
if ( param - > opt_maria_lock_memory )
{
int success = mlockall ( MCL_CURRENT ) ; /* or plock(DATLOCK); */
if ( geteuid ( ) = = 0 & & success ! = 0 )
_ma_check_print_warning ( param ,
" Failed to lock memory. errno %d " , my_errno ) ;
}
# endif
} /* maria_lock_memory */
/* Flush all changed blocks to disk */
2007-04-04 22:37:09 +02:00
int _ma_flush_blocks ( HA_CHECK * param , PAGECACHE * pagecache ,
PAGECACHE_FILE * file )
2006-04-11 15:45:10 +02:00
{
2007-04-04 22:37:09 +02:00
if ( flush_pagecache_blocks ( pagecache , file , FLUSH_RELEASE ) )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_error ( param , " %d when trying to write bufferts " , my_errno ) ;
return ( 1 ) ;
}
return 0 ;
} /* _ma_flush_blocks */
/* Sort index for more efficent reads */
2007-07-02 19:45:15 +02:00
int maria_sort_index ( HA_CHECK * param , register MARIA_HA * info , char * name )
2006-04-11 15:45:10 +02:00
{
reg2 uint key ;
reg1 MARIA_KEYDEF * keyinfo ;
File new_file ;
my_off_t index_pos [ HA_MAX_POSSIBLE_KEY ] ;
uint r_locks , w_locks ;
int old_lock ;
MARIA_SHARE * share = info - > s ;
MARIA_STATE_INFO old_state ;
Maria:
* Don't modify share->base.born_transactional; now it is a value carved
in stone at creation time. share->now_transactional is what can be
modified: it starts at born_transactional, can become false during
ALTER TABLE (when we want no logging), and restored later.
* Not resetting create_rename_lsn to 0 during delete_all or repair.
* when we temporarily disable transactionality, we also change
the page type to PAGECACHE_PLAIN_PAGE: it bypasses some work in the
page cache (optimization), and avoids assertions related to LSNs.
* Disable INSERT DELAYED for transactional tables, because
durability could not be guaranteed (insertion may even not happen)
mysys/mf_keycache.c:
comment
storage/maria/ha_maria.cc:
* a transactional table cannot do INSERT DELAYED
* ha_maria::save_transactional not needed anymore, as now instead
we don't modify MARIA_SHARE::MARIA_BASE_INFO::born_transactional
(born_transactional plays the role of save_transactional), and modify
MARIA_SHARE::now_transactional.
* REPAIR_TABLE log record is now logged by maria_repair()
* comment why we rely on born_transactional to know if we should
skipping a transaction.
* putting together two if()s which test for F_UNLCK
storage/maria/ha_maria.h:
ha_maria::save_transactional not needed anymore (moved to the C layer)
storage/maria/ma_blockrec.c:
* For the block record's code (writing/updating/deleting records),
all that counts is now_transactional, not born_transactional.
* As we now set the page type to PAGECACHE_PLAIN_PAGE for tables
which have now_transactional==FALSE, pagecache will not expect
a meaningful LSN for them in pagecache_unlock_by_link(), so
we can pass it LSN_IMPOSSIBLE.
storage/maria/ma_check.c:
* writing LOGREC_REPAIR_TABLE moves from ha_maria::repair()
to maria_repair(), sounds cleaner (less functions to export).
* when opening a table during REPAIR, don't use the realpath-ed name,
as this may fail if the table has symlinked files (maria_open()
would try to find the data and index file in the directory
of unique_file_name, it would fail if data and index files are in
different dirs); use the unresolved name, open_file_name, which is
the argument which was passed to the maria_open() which created 'info'.
storage/maria/ma_close.c:
assert that when a statement is done with a table, it cleans up
storage/maria/ma_create.c:
new name
storage/maria/ma_delete_all.c:
* using now_transactional
* no reason to reset create_rename_lsn during delete_all (a bug);
also no reason to do it during repair: it was put there because
a positive create_rename_lsn caused a call to check_and_set_lsn()
which asserted in DBUG_ASSERT(block->type == PAGECACHE_LSN_PAGE);
first solution was to use LSN_IMPOSSIBLE in _ma_unpin_all_pages() if
not transactional; but then in the case of ALTER TABLE, with
transactionality temporarily disabled, it asserted in
DBUG_ASSERT(LSN_VALID(lsn)) in pagecache_fwrite() (PAGECACHE_LSN_PAGE
page with zero LSN - bad). The additional solution is to use
PAGECACHE_PLAIN_PAGE when we disable transactionality temporarily: this
avoids checks on the LSN, and also bypasses (optimization) the "flush
log up to LSN" call when the pagecache flushes our page (in other
words, no WAL needed).
storage/maria/ma_delete_table.c:
use now_transactional
storage/maria/ma_locking.c:
assert that when a statement is done with a table, it cleans up.
storage/maria/ma_loghandler.c:
* now_transactional should be used to test if we want a log record.
* Assertions to make sure dummy_transaction_object is not spoilt
by its many users.
storage/maria/ma_open.c:
base.transactional -> base.born_transactional
storage/maria/ma_pagecache.c:
missing name for page's type. Comment for future.
storage/maria/ma_rename.c:
use now_transactional
storage/maria/maria_chk.c:
use born_transactional
storage/maria/maria_def.h:
MARIA_BASE_INFO::transactional renamed to born_transactional.
MARIA_SHARE::now_transactional introduced.
_ma_repair_write_log_record() is made local to ma_check.c.
Macros to temporarily disable, and re-enable, transactionality for a
table.
storage/maria/maria_read_log.c:
assertions and using the new macros. Adding a forgotten resetting
when we finally close all tables.
2007-07-03 15:20:41 +02:00
myf sync_dir = ( share - > now_transactional & & ! share - > temporary ) ?
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
MY_SYNC_DIR : 0 ;
2006-04-11 15:45:10 +02:00
DBUG_ENTER ( " maria_sort_index " ) ;
2007-03-01 18:23:58 +01:00
/* cannot sort index files with R-tree indexes */
for ( key = 0 , keyinfo = & share - > keyinfo [ 0 ] ; key < share - > base . keys ;
key + + , keyinfo + + )
if ( keyinfo - > key_alg = = HA_KEY_ALG_RTREE )
DBUG_RETURN ( 0 ) ;
2006-04-11 15:45:10 +02:00
if ( ! ( param - > testflag & T_SILENT ) )
printf ( " - Sorting index for MARIA-table '%s' \n " , name ) ;
/* Get real path for index file */
fn_format ( param - > temp_filename , name , " " , MARIA_NAME_IEXT , 2 + 4 + 32 ) ;
if ( ( new_file = my_create ( fn_format ( param - > temp_filename , param - > temp_filename ,
" " , INDEX_TMP_EXT , 2 + 4 ) ,
0 , param - > tmpfile_createflag , MYF ( 0 ) ) ) < = 0 )
{
_ma_check_print_error ( param , " Can't create new tempfile: '%s' " ,
param - > temp_filename ) ;
DBUG_RETURN ( - 1 ) ;
}
2007-04-04 22:37:09 +02:00
if ( maria_filecopy ( param , new_file , share - > kfile . file , 0L ,
2007-01-23 20:13:26 +01:00
( ulong ) share - > base . keystart , " headerblock " ) )
2006-04-11 15:45:10 +02:00
goto err ;
param - > new_file_pos = share - > base . keystart ;
for ( key = 0 , keyinfo = & share - > keyinfo [ 0 ] ; key < share - > base . keys ;
key + + , keyinfo + + )
{
if ( ! maria_is_key_active ( info - > s - > state . key_map , key ) )
continue ;
if ( share - > state . key_root [ key ] ! = HA_OFFSET_ERROR )
{
index_pos [ key ] = param - > new_file_pos ; /* Write first block here */
if ( sort_one_index ( param , info , keyinfo , share - > state . key_root [ key ] ,
new_file ) )
goto err ;
}
else
index_pos [ key ] = HA_OFFSET_ERROR ; /* No blocks */
}
2007-01-18 20:38:14 +01:00
/* Flush key cache for this file if we are calling this outside maria_chk */
2007-04-04 22:37:09 +02:00
flush_pagecache_blocks ( share - > pagecache , & share - > kfile ,
FLUSH_IGNORE_CHANGED ) ;
2006-04-11 15:45:10 +02:00
share - > state . version = ( ulong ) time ( ( time_t * ) 0 ) ;
old_state = share - > state ; /* save state if not stored */
r_locks = share - > r_locks ;
w_locks = share - > w_locks ;
old_lock = info - > lock_type ;
/* Put same locks as old file */
share - > r_locks = share - > w_locks = share - > tot_locks = 0 ;
( void ) _ma_writeinfo ( info , WRITEINFO_UPDATE_KEYFILE ) ;
2007-04-04 22:37:09 +02:00
VOID ( my_close ( share - > kfile . file , MYF ( MY_WME ) ) ) ;
share - > kfile . file = - 1 ;
2006-04-11 15:45:10 +02:00
VOID ( my_close ( new_file , MYF ( MY_WME ) ) ) ;
2007-01-18 20:38:14 +01:00
if ( maria_change_to_newfile ( share - > index_file_name , MARIA_NAME_IEXT ,
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
INDEX_TMP_EXT , sync_dir ) | |
2006-04-11 15:45:10 +02:00
_ma_open_keyfile ( share ) )
goto err2 ;
info - > lock_type = F_UNLCK ; /* Force maria_readinfo to lock */
_ma_readinfo ( info , F_WRLCK , 0 ) ; /* Will lock the table */
info - > lock_type = old_lock ;
share - > r_locks = r_locks ;
share - > w_locks = w_locks ;
share - > tot_locks = r_locks + w_locks ;
share - > state = old_state ; /* Restore old state */
info - > state - > key_file_length = param - > new_file_pos ;
info - > update = ( short ) ( HA_STATE_CHANGED | HA_STATE_ROW_CHANGED ) ;
for ( key = 0 ; key < info - > s - > base . keys ; key + + )
info - > s - > state . key_root [ key ] = index_pos [ key ] ;
2007-01-18 20:38:14 +01:00
info - > s - > state . key_del = HA_OFFSET_ERROR ;
2006-04-11 15:45:10 +02:00
info - > s - > state . changed & = ~ STATE_NOT_SORTED_PAGES ;
DBUG_RETURN ( 0 ) ;
err :
VOID ( my_close ( new_file , MYF ( MY_WME ) ) ) ;
err2 :
VOID ( my_delete ( param - > temp_filename , MYF ( MY_WME ) ) ) ;
DBUG_RETURN ( - 1 ) ;
} /* maria_sort_index */
/* Sort records recursive using one index */
2007-01-18 20:38:14 +01:00
static int sort_one_index ( HA_CHECK * param , MARIA_HA * info ,
MARIA_KEYDEF * keyinfo ,
2006-04-11 15:45:10 +02:00
my_off_t pagepos , File new_file )
{
uint length , nod_flag , used_length , key_length ;
2007-07-02 19:45:15 +02:00
uchar * buff , * keypos , * endpos ;
uchar key [ HA_MAX_POSSIBLE_KEY_BUFF ] ;
2006-04-11 15:45:10 +02:00
my_off_t new_page_pos , next_page ;
char llbuff [ 22 ] ;
DBUG_ENTER ( " sort_one_index " ) ;
2007-03-01 18:23:58 +01:00
/* cannot walk over R-tree indices */
DBUG_ASSERT ( keyinfo - > key_alg ! = HA_KEY_ALG_RTREE ) ;
2006-04-11 15:45:10 +02:00
new_page_pos = param - > new_file_pos ;
param - > new_file_pos + = keyinfo - > block_length ;
2007-07-02 19:45:15 +02:00
if ( ! ( buff = ( uchar * ) my_alloca ( ( uint ) keyinfo - > block_length ) ) )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_error ( param , " Not enough memory for key block " ) ;
DBUG_RETURN ( - 1 ) ;
}
if ( ! _ma_fetch_keypage ( info , keyinfo , pagepos , DFLT_INIT_HITS , buff , 0 ) )
{
_ma_check_print_error ( param , " Can't read key block from filepos: %s " ,
llstr ( pagepos , llbuff ) ) ;
goto err ;
}
if ( ( nod_flag = _ma_test_if_nod ( buff ) ) | | keyinfo - > flag & HA_FULLTEXT )
{
2007-06-09 13:52:17 +02:00
used_length = maria_data_on_page ( buff ) ;
2006-04-11 15:45:10 +02:00
keypos = buff + 2 + nod_flag ;
endpos = buff + used_length ;
for ( ; ; )
{
if ( nod_flag )
{
next_page = _ma_kpos ( nod_flag , keypos ) ;
/* Save new pos */
_ma_kpointer ( info , keypos - nod_flag , param - > new_file_pos ) ;
if ( sort_one_index ( param , info , keyinfo , next_page , new_file ) )
{
DBUG_PRINT ( " error " ,
( " From page: %ld, keyoffset: %lu used_length: %d " ,
( ulong ) pagepos , ( ulong ) ( keypos - buff ) ,
( int ) used_length ) ) ;
2007-07-02 19:45:15 +02:00
DBUG_DUMP ( " buff " , ( uchar * ) buff , used_length ) ;
2006-04-11 15:45:10 +02:00
goto err ;
}
}
if ( keypos > = endpos | |
( key_length = ( * keyinfo - > get_key ) ( keyinfo , nod_flag , & keypos , key ) ) = = 0 )
break ;
DBUG_ASSERT ( keypos < = endpos ) ;
if ( keyinfo - > flag & HA_FULLTEXT )
{
uint off ;
int subkeys ;
get_key_full_length_rdonly ( off , key ) ;
subkeys = ft_sintXkorr ( key + off ) ;
if ( subkeys < 0 )
{
next_page = _ma_dpos ( info , 0 , key + key_length ) ;
_ma_dpointer ( info , keypos - nod_flag - info - > s - > rec_reflength ,
param - > new_file_pos ) ; /* Save new pos */
if ( sort_one_index ( param , info , & info - > s - > ft2_keyinfo ,
next_page , new_file ) )
goto err ;
}
}
}
}
/* Fill block with zero and write it to the new index file */
2007-06-09 13:52:17 +02:00
length = maria_data_on_page ( buff ) ;
2007-07-02 19:45:15 +02:00
bzero ( ( uchar * ) buff + length , keyinfo - > block_length - length ) ;
if ( my_pwrite ( new_file , ( uchar * ) buff , ( uint ) keyinfo - > block_length ,
2006-04-11 15:45:10 +02:00
new_page_pos , MYF ( MY_NABP | MY_WAIT_IF_FULL ) ) )
{
_ma_check_print_error ( param , " Can't write indexblock, error: %d " , my_errno ) ;
goto err ;
}
2007-07-02 19:45:15 +02:00
my_afree ( ( uchar * ) buff ) ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 0 ) ;
err :
2007-07-02 19:45:15 +02:00
my_afree ( ( uchar * ) buff ) ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 1 ) ;
} /* sort_one_index */
/*
Let temporary file replace old file .
This assumes that the new file was created in the same
directory as given by realpath ( filename ) .
This will ensure that any symlinks that are used will still work .
Copy stats from old file to new file , deletes orignal and
changes new file name to old file name
*/
int maria_change_to_newfile ( const char * filename , const char * old_ext ,
2007-01-18 20:38:14 +01:00
const char * new_ext , myf MyFlags )
2006-04-11 15:45:10 +02:00
{
char old_filename [ FN_REFLEN ] , new_filename [ FN_REFLEN ] ;
# ifdef USE_RAID
if ( raid_chunks )
return my_raid_redel ( fn_format ( old_filename , filename , " " , old_ext , 2 + 4 ) ,
fn_format ( new_filename , filename , " " , new_ext , 2 + 4 ) ,
raid_chunks ,
MYF ( MY_WME | MY_LINK_WARNING | MyFlags ) ) ;
# endif
/* Get real path to filename */
( void ) fn_format ( old_filename , filename , " " , old_ext , 2 + 4 + 32 ) ;
return my_redel ( old_filename ,
fn_format ( new_filename , old_filename , " " , new_ext , 2 + 4 ) ,
MYF ( MY_WME | MY_LINK_WARNING | MyFlags ) ) ;
} /* maria_change_to_newfile */
2006-05-05 20:32:02 +02:00
/* Copy a block between two files */
2006-04-11 15:45:10 +02:00
int maria_filecopy ( HA_CHECK * param , File to , File from , my_off_t start ,
my_off_t length , const char * type )
{
char tmp_buff [ IO_SIZE ] , * buff ;
ulong buff_length ;
DBUG_ENTER ( " maria_filecopy " ) ;
buff_length = ( ulong ) min ( param - > write_buffer_length , length ) ;
if ( ! ( buff = my_malloc ( buff_length , MYF ( 0 ) ) ) )
{
buff = tmp_buff ; buff_length = IO_SIZE ;
}
VOID ( my_seek ( from , start , MY_SEEK_SET , MYF ( 0 ) ) ) ;
while ( length > buff_length )
{
2007-07-02 19:45:15 +02:00
if ( my_read ( from , ( uchar * ) buff , buff_length , MYF ( MY_NABP ) ) | |
my_write ( to , ( uchar * ) buff , buff_length , param - > myf_rw ) )
2006-04-11 15:45:10 +02:00
goto err ;
length - = buff_length ;
}
2007-07-02 19:45:15 +02:00
if ( my_read ( from , ( uchar * ) buff , ( uint ) length , MYF ( MY_NABP ) ) | |
my_write ( to , ( uchar * ) buff , ( uint ) length , param - > myf_rw ) )
2006-04-11 15:45:10 +02:00
goto err ;
if ( buff ! = tmp_buff )
my_free ( buff , MYF ( 0 ) ) ;
DBUG_RETURN ( 0 ) ;
err :
if ( buff ! = tmp_buff )
my_free ( buff , MYF ( 0 ) ) ;
_ma_check_print_error ( param , " Can't copy %s to tempfile, error %d " ,
type , my_errno ) ;
DBUG_RETURN ( 1 ) ;
}
/*
Repair table or given index using sorting
SYNOPSIS
maria_repair_by_sort ( )
param Repair parameters
info MARIA handler to repair
name Name of table ( for warnings )
rep_quick set to < > 0 if we should not change data file
RESULT
0 ok
< > 0 Error
*/
int maria_repair_by_sort ( HA_CHECK * param , register MARIA_HA * info ,
2007-01-18 20:38:14 +01:00
const char * name , int rep_quick )
2006-04-11 15:45:10 +02:00
{
int got_error ;
uint i ;
ulong length ;
ha_rows start_records ;
2007-07-01 15:20:57 +02:00
my_off_t new_header_length , org_header_length , del ;
2006-04-11 15:45:10 +02:00
File new_file ;
MARIA_SORT_PARAM sort_param ;
MARIA_SHARE * share = info - > s ;
HA_KEYSEG * keyseg ;
ulong * rec_per_key_part ;
char llbuff [ 22 ] ;
MARIA_SORT_INFO sort_info ;
ulonglong key_map = share - > state . key_map ;
Maria:
* Don't modify share->base.born_transactional; now it is a value carved
in stone at creation time. share->now_transactional is what can be
modified: it starts at born_transactional, can become false during
ALTER TABLE (when we want no logging), and restored later.
* Not resetting create_rename_lsn to 0 during delete_all or repair.
* when we temporarily disable transactionality, we also change
the page type to PAGECACHE_PLAIN_PAGE: it bypasses some work in the
page cache (optimization), and avoids assertions related to LSNs.
* Disable INSERT DELAYED for transactional tables, because
durability could not be guaranteed (insertion may even not happen)
mysys/mf_keycache.c:
comment
storage/maria/ha_maria.cc:
* a transactional table cannot do INSERT DELAYED
* ha_maria::save_transactional not needed anymore, as now instead
we don't modify MARIA_SHARE::MARIA_BASE_INFO::born_transactional
(born_transactional plays the role of save_transactional), and modify
MARIA_SHARE::now_transactional.
* REPAIR_TABLE log record is now logged by maria_repair()
* comment why we rely on born_transactional to know if we should
skipping a transaction.
* putting together two if()s which test for F_UNLCK
storage/maria/ha_maria.h:
ha_maria::save_transactional not needed anymore (moved to the C layer)
storage/maria/ma_blockrec.c:
* For the block record's code (writing/updating/deleting records),
all that counts is now_transactional, not born_transactional.
* As we now set the page type to PAGECACHE_PLAIN_PAGE for tables
which have now_transactional==FALSE, pagecache will not expect
a meaningful LSN for them in pagecache_unlock_by_link(), so
we can pass it LSN_IMPOSSIBLE.
storage/maria/ma_check.c:
* writing LOGREC_REPAIR_TABLE moves from ha_maria::repair()
to maria_repair(), sounds cleaner (less functions to export).
* when opening a table during REPAIR, don't use the realpath-ed name,
as this may fail if the table has symlinked files (maria_open()
would try to find the data and index file in the directory
of unique_file_name, it would fail if data and index files are in
different dirs); use the unresolved name, open_file_name, which is
the argument which was passed to the maria_open() which created 'info'.
storage/maria/ma_close.c:
assert that when a statement is done with a table, it cleans up
storage/maria/ma_create.c:
new name
storage/maria/ma_delete_all.c:
* using now_transactional
* no reason to reset create_rename_lsn during delete_all (a bug);
also no reason to do it during repair: it was put there because
a positive create_rename_lsn caused a call to check_and_set_lsn()
which asserted in DBUG_ASSERT(block->type == PAGECACHE_LSN_PAGE);
first solution was to use LSN_IMPOSSIBLE in _ma_unpin_all_pages() if
not transactional; but then in the case of ALTER TABLE, with
transactionality temporarily disabled, it asserted in
DBUG_ASSERT(LSN_VALID(lsn)) in pagecache_fwrite() (PAGECACHE_LSN_PAGE
page with zero LSN - bad). The additional solution is to use
PAGECACHE_PLAIN_PAGE when we disable transactionality temporarily: this
avoids checks on the LSN, and also bypasses (optimization) the "flush
log up to LSN" call when the pagecache flushes our page (in other
words, no WAL needed).
storage/maria/ma_delete_table.c:
use now_transactional
storage/maria/ma_locking.c:
assert that when a statement is done with a table, it cleans up.
storage/maria/ma_loghandler.c:
* now_transactional should be used to test if we want a log record.
* Assertions to make sure dummy_transaction_object is not spoilt
by its many users.
storage/maria/ma_open.c:
base.transactional -> base.born_transactional
storage/maria/ma_pagecache.c:
missing name for page's type. Comment for future.
storage/maria/ma_rename.c:
use now_transactional
storage/maria/maria_chk.c:
use born_transactional
storage/maria/maria_def.h:
MARIA_BASE_INFO::transactional renamed to born_transactional.
MARIA_SHARE::now_transactional introduced.
_ma_repair_write_log_record() is made local to ma_check.c.
Macros to temporarily disable, and re-enable, transactionality for a
table.
storage/maria/maria_read_log.c:
assertions and using the new macros. Adding a forgotten resetting
when we finally close all tables.
2007-07-03 15:20:41 +02:00
myf sync_dir = ( ( share - > now_transactional & & ! share - > temporary ) ?
2007-07-01 15:48:57 +02:00
MY_SYNC_DIR : 0 ) ;
2006-04-11 15:45:10 +02:00
DBUG_ENTER ( " maria_repair_by_sort " ) ;
2007-07-01 15:20:57 +02:00
bzero ( ( char * ) & sort_info , sizeof ( sort_info ) ) ;
bzero ( ( char * ) & sort_param , sizeof ( sort_param ) ) ;
2006-04-11 15:45:10 +02:00
start_records = info - > state - > records ;
got_error = 1 ;
new_file = - 1 ;
2007-07-01 15:20:57 +02:00
org_header_length = share - > pack . header_length ;
new_header_length = ( param - > testflag & T_UNPACK ) ? 0 : org_header_length ;
2006-04-11 15:45:10 +02:00
if ( ! ( param - > testflag & T_SILENT ) )
{
printf ( " - recovering (with sort) MARIA-table '%s' \n " , name ) ;
printf ( " Data records: %s \n " , llstr ( start_records , llbuff ) ) ;
}
param - > testflag | = T_REP ; /* for easy checking */
if ( info - > s - > options & ( HA_OPTION_CHECKSUM | HA_OPTION_COMPRESS_RECORD ) )
param - > testflag | = T_CALC_CHECKSUM ;
2007-08-08 11:36:41 +02:00
if ( _ma_flush_table_files ( info , MARIA_FLUSH_DATA , FLUSH_FORCE_WRITE ,
FLUSH_KEEP ) )
goto err ;
2006-04-11 15:45:10 +02:00
if ( ! ( sort_info . key_block =
alloc_key_blocks ( param ,
( uint ) param - > sort_key_blocks ,
2007-07-01 15:20:57 +02:00
share - > base . max_key_block_length ) ) | |
init_io_cache ( & param - > read_cache , info - > dfile . file ,
( uint ) param - > read_buffer_length ,
READ_CACHE , org_header_length , 1 , MYF ( MY_WME ) ) | |
2006-04-11 15:45:10 +02:00
( ! rep_quick & &
2007-04-04 22:37:09 +02:00
init_io_cache ( & info - > rec_cache , info - > dfile . file ,
2006-04-11 15:45:10 +02:00
( uint ) param - > write_buffer_length ,
WRITE_CACHE , new_header_length , 1 ,
MYF ( MY_WME | MY_WAIT_IF_FULL ) & param - > myf_rw ) ) )
goto err ;
sort_info . key_block_end = sort_info . key_block + param - > sort_key_blocks ;
info - > opt_flag | = WRITE_CACHE_USED ;
2007-04-04 22:37:09 +02:00
info - > rec_cache . file = info - > dfile . file ; /* for sort_delete_record */
2007-07-01 15:20:57 +02:00
sort_info . org_data_file_type = info - > s - > data_file_type ;
2006-04-11 15:45:10 +02:00
2007-07-02 19:45:15 +02:00
if ( ! ( sort_param . record = ( uchar * ) my_malloc ( ( uint ) share - > base . pack_reclength ,
2006-04-11 15:45:10 +02:00
MYF ( 0 ) ) ) | |
2007-01-18 20:38:14 +01:00
_ma_alloc_buffer ( & sort_param . rec_buff , & sort_param . rec_buff_size ,
info - > s - > base . default_rec_buff_size ) )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_error ( param , " Not enough memory for extra record " ) ;
goto err ;
}
if ( ! rep_quick )
{
/* Get real path for data file */
2007-01-18 20:38:14 +01:00
if ( ( new_file = my_create ( fn_format ( param - > temp_filename ,
share - > data_file_name , " " ,
DATA_TMP_EXT , 2 + 4 ) ,
0 , param - > tmpfile_createflag ,
MYF ( 0 ) ) ) < 0 )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_error ( param , " Can't create new tempfile: '%s' " ,
param - > temp_filename ) ;
goto err ;
}
2006-10-11 18:30:16 +02:00
if ( new_header_length & &
2007-04-04 22:37:09 +02:00
maria_filecopy ( param , new_file , info - > dfile . file , 0L ,
new_header_length , " datafile-header " ) )
2006-04-11 15:45:10 +02:00
goto err ;
if ( param - > testflag & T_UNPACK )
2007-01-18 20:38:14 +01:00
restore_data_file_type ( share ) ;
2006-04-11 15:45:10 +02:00
share - > state . dellink = HA_OFFSET_ERROR ;
info - > rec_cache . file = new_file ;
}
info - > update = ( short ) ( HA_STATE_CHANGED | HA_STATE_ROW_CHANGED ) ;
if ( ! ( param - > testflag & T_CREATE_MISSING_KEYS ) )
{
/*
Flush key cache for this file if we are calling this outside
2007-01-18 20:38:14 +01:00
maria_chk
2006-04-11 15:45:10 +02:00
*/
2007-04-04 22:37:09 +02:00
flush_pagecache_blocks ( share - > pagecache , & share - > kfile ,
FLUSH_IGNORE_CHANGED ) ;
2006-04-11 15:45:10 +02:00
/* Clear the pointers to the given rows */
for ( i = 0 ; i < share - > base . keys ; i + + )
share - > state . key_root [ i ] = HA_OFFSET_ERROR ;
2007-01-18 20:38:14 +01:00
share - > state . key_del = HA_OFFSET_ERROR ;
2006-04-11 15:45:10 +02:00
info - > state - > key_file_length = share - > base . keystart ;
}
else
{
2007-04-04 22:37:09 +02:00
if ( flush_pagecache_blocks ( share - > pagecache , & share - > kfile ,
FLUSH_FORCE_WRITE ) )
2006-04-11 15:45:10 +02:00
goto err ;
key_map = ~ key_map ; /* Create the missing keys */
}
2007-07-01 15:20:57 +02:00
sort_info . info = sort_info . new_info = info ;
sort_info . param = param ;
2006-04-11 15:45:10 +02:00
set_data_file_type ( & sort_info , share ) ;
sort_param . filepos = new_header_length ;
sort_info . dupp = 0 ;
sort_info . buff = 0 ;
param - > read_cache . end_of_file = sort_info . filelength =
my_seek ( param - > read_cache . file , 0L , MY_SEEK_END , MYF ( 0 ) ) ;
sort_param . wordlist = NULL ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
init_alloc_root ( & sort_param . wordroot , FTPARSER_MEMROOT_ALLOC_SIZE , 0 ) ;
2006-04-11 15:45:10 +02:00
2007-07-01 15:20:57 +02:00
if ( sort_info . org_data_file_type = = DYNAMIC_RECORD )
2006-04-11 15:45:10 +02:00
length = max ( share - > base . min_pack_length + 1 , share - > base . min_block_length ) ;
2007-07-01 15:20:57 +02:00
else if ( sort_info . org_data_file_type = = COMPRESSED_RECORD )
2006-04-11 15:45:10 +02:00
length = share - > base . min_block_length ;
else
length = share - > base . pack_reclength ;
sort_info . max_records =
( ( param - > testflag & T_CREATE_MISSING_KEYS ) ? info - > state - > records :
( ha_rows ) ( sort_info . filelength / length + 1 ) ) ;
sort_param . key_cmp = sort_key_cmp ;
sort_param . lock_in_memory = maria_lock_memory ;
sort_param . tmpdir = param - > tmpdir ;
sort_param . sort_info = & sort_info ;
sort_param . fix_datafile = ( my_bool ) ( ! rep_quick ) ;
sort_param . master = 1 ;
del = info - > state - > del ;
param - > glob_crc = 0 ;
if ( param - > testflag & T_CALC_CHECKSUM )
2006-12-19 19:15:53 +01:00
sort_param . calc_checksum = 1 ;
2006-04-11 15:45:10 +02:00
rec_per_key_part = param - > rec_per_key_part ;
for ( sort_param . key = 0 ; sort_param . key < share - > base . keys ;
rec_per_key_part + = sort_param . keyinfo - > keysegs , sort_param . key + + )
{
sort_param . read_cache = param - > read_cache ;
sort_param . keyinfo = share - > keyinfo + sort_param . key ;
sort_param . seg = sort_param . keyinfo - > seg ;
if ( ! maria_is_key_active ( key_map , sort_param . key ) )
{
/* Remember old statistics for key */
memcpy ( ( char * ) rec_per_key_part ,
( char * ) ( share - > state . rec_per_key_part +
( uint ) ( rec_per_key_part - param - > rec_per_key_part ) ) ,
sort_param . keyinfo - > keysegs * sizeof ( * rec_per_key_part ) ) ;
continue ;
}
if ( ( ! ( param - > testflag & T_SILENT ) ) )
printf ( " - Fixing index %d \n " , sort_param . key + 1 ) ;
2007-07-01 15:20:57 +02:00
sort_param . max_pos = sort_param . pos = org_header_length ;
2006-04-11 15:45:10 +02:00
keyseg = sort_param . seg ;
bzero ( ( char * ) sort_param . unique , sizeof ( sort_param . unique ) ) ;
sort_param . key_length = share - > rec_reflength ;
for ( i = 0 ; keyseg [ i ] . type ! = HA_KEYTYPE_END ; i + + )
{
sort_param . key_length + = keyseg [ i ] . length ;
if ( keyseg [ i ] . flag & HA_SPACE_PACK )
sort_param . key_length + = get_pack_length ( keyseg [ i ] . length ) ;
if ( keyseg [ i ] . flag & ( HA_BLOB_PART | HA_VAR_LENGTH_PART ) )
sort_param . key_length + = 2 + test ( keyseg [ i ] . length > = 127 ) ;
if ( keyseg [ i ] . flag & HA_NULL_PART )
sort_param . key_length + + ;
}
info - > state - > records = info - > state - > del = share - > state . split = 0 ;
info - > state - > empty = 0 ;
if ( sort_param . keyinfo - > flag & HA_FULLTEXT )
{
uint ft_max_word_len_for_sort = FT_MAX_WORD_LEN_FOR_SORT *
sort_param . keyinfo - > seg - > charset - > mbmaxlen ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
sort_param . key_length + = ft_max_word_len_for_sort - HA_FT_MAXBYTELEN ;
/*
fulltext indexes may have much more entries than the
number of rows in the table . We estimate the number here .
Note , built - in parser is always nr . 0 - see ftparser_call_initializer ( )
*/
if ( sort_param . keyinfo - > ftparser_nr = = 0 )
{
/*
for built - in parser the number of generated index entries
cannot be larger than the size of the data file divided
by the minimal word ' s length
*/
sort_info . max_records =
( ha_rows ) ( sort_info . filelength / ft_min_word_len + 1 ) ;
}
else
{
/*
for external plugin parser we cannot tell anything at all : (
so , we ' ll use all the sort memory and start from ~ 10 buffpeks .
( see _create_index_by_sort )
*/
sort_info . max_records =
10 * param - > sort_buffer_length / sort_param . key_length ;
}
2006-04-11 15:45:10 +02:00
2007-01-18 20:38:14 +01:00
sort_param . key_read = sort_maria_ft_key_read ;
sort_param . key_write = sort_maria_ft_key_write ;
2006-04-11 15:45:10 +02:00
}
else
{
2007-01-18 20:38:14 +01:00
sort_param . key_read = sort_key_read ;
sort_param . key_write = sort_key_write ;
2006-04-11 15:45:10 +02:00
}
if ( _ma_create_index_by_sort ( & sort_param ,
( my_bool ) ( ! ( param - > testflag & T_VERBOSE ) ) ,
( uint ) param - > sort_buffer_length ) )
{
param - > retry_repair = 1 ;
goto err ;
}
2006-12-19 19:15:53 +01:00
/* No need to calculate checksum again. */
sort_param . calc_checksum = 0 ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
free_root ( & sort_param . wordroot , MYF ( 0 ) ) ;
2006-04-11 15:45:10 +02:00
/* Set for next loop */
sort_info . max_records = ( ha_rows ) info - > state - > records ;
if ( param - > testflag & T_STATISTICS )
maria_update_key_parts ( sort_param . keyinfo , rec_per_key_part , sort_param . unique ,
param - > stats_method = = MI_STATS_METHOD_IGNORE_NULLS ?
sort_param . notnull : NULL , ( ulonglong ) info - > state - > records ) ;
maria_set_key_active ( share - > state . key_map , sort_param . key ) ;
if ( sort_param . fix_datafile )
{
param - > read_cache . end_of_file = sort_param . filepos ;
if ( maria_write_data_suffix ( & sort_info , 1 ) | | end_io_cache ( & info - > rec_cache ) )
goto err ;
if ( param - > testflag & T_SAFE_REPAIR )
{
/* Don't repair if we loosed more than one row */
if ( info - > state - > records + 1 < start_records )
{
info - > state - > records = start_records ;
goto err ;
}
}
share - > state . state . data_file_length = info - > state - > data_file_length =
sort_param . filepos ;
/* Only whole records */
share - > state . version = ( ulong ) time ( ( time_t * ) 0 ) ;
2007-04-04 22:37:09 +02:00
my_close ( info - > dfile . file , MYF ( 0 ) ) ;
info - > dfile . file = new_file ;
2007-07-01 15:20:57 +02:00
share - > data_file_type = sort_info . new_data_file_type ;
org_header_length = ( ulong ) new_header_length ;
sort_info . org_data_file_type = info - > s - > data_file_type ;
2006-04-11 15:45:10 +02:00
sort_param . fix_datafile = 0 ;
}
else
info - > state - > data_file_length = sort_param . max_pos ;
2007-04-04 22:37:09 +02:00
param - > read_cache . file = info - > dfile . file ; /* re-init read cache */
2006-04-11 15:45:10 +02:00
reinit_io_cache ( & param - > read_cache , READ_CACHE , share - > pack . header_length ,
1 , 1 ) ;
}
if ( param - > testflag & T_WRITE_LOOP )
{
VOID ( fputs ( " \r " , stdout ) ) ; VOID ( fflush ( stdout ) ) ;
}
if ( rep_quick & & del + sort_info . dupp ! = info - > state - > del )
{
_ma_check_print_error ( param , " Couldn't fix table with quick recovery: Found wrong number of deleted records " ) ;
_ma_check_print_error ( param , " Run recovery again without -q " ) ;
got_error = 1 ;
param - > retry_repair = 1 ;
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
goto err ;
}
if ( rep_quick & T_FORCE_UNIQUENESS )
{
2007-07-01 15:20:57 +02:00
my_off_t skr = ( info - > state - > data_file_length +
( sort_info . org_data_file_type = = COMPRESSED_RECORD ) ?
MEMMAP_EXTRA_MARGIN : 0 ) ;
2006-04-11 15:45:10 +02:00
# ifdef USE_RELOC
2007-07-01 15:20:57 +02:00
if ( sort_info . org_data_file_type = = STATIC_RECORD & &
2006-04-11 15:45:10 +02:00
skr < share - > base . reloc * share - > base . min_pack_length )
skr = share - > base . reloc * share - > base . min_pack_length ;
# endif
2007-01-18 20:38:14 +01:00
if ( skr ! = sort_info . filelength )
2007-04-04 22:37:09 +02:00
if ( my_chsize ( info - > dfile . file , skr , 0 , MYF ( 0 ) ) )
2006-04-11 15:45:10 +02:00
_ma_check_print_warning ( param ,
" Can't change size of datafile, error: %d " ,
my_errno ) ;
}
if ( param - > testflag & T_CALC_CHECKSUM )
info - > state - > checksum = param - > glob_crc ;
2007-04-04 22:37:09 +02:00
if ( my_chsize ( share - > kfile . file , info - > state - > key_file_length , 0 , MYF ( 0 ) ) )
2006-04-11 15:45:10 +02:00
_ma_check_print_warning ( param ,
" Can't change size of indexfile, error: %d " ,
my_errno ) ;
if ( ! ( param - > testflag & T_SILENT ) )
{
if ( start_records ! = info - > state - > records )
printf ( " Data records: %s \n " , llstr ( info - > state - > records , llbuff ) ) ;
if ( sort_info . dupp )
_ma_check_print_warning ( param ,
" %s records have been removed " ,
llstr ( sort_info . dupp , llbuff ) ) ;
}
got_error = 0 ;
if ( & share - > state . state ! = info - > state )
memcpy ( & share - > state . state , info - > state , sizeof ( * info - > state ) ) ;
err :
2007-04-04 22:37:09 +02:00
got_error | = _ma_flush_blocks ( param , share - > pagecache , & share - > kfile ) ;
2006-04-11 15:45:10 +02:00
VOID ( end_io_cache ( & info - > rec_cache ) ) ;
if ( ! got_error )
{
/* Replace the actual file with the temporary file */
if ( new_file > = 0 )
{
my_close ( new_file , MYF ( 0 ) ) ;
2007-04-04 22:37:09 +02:00
info - > dfile . file = new_file = - 1 ;
2006-04-11 15:45:10 +02:00
if ( maria_change_to_newfile ( share - > data_file_name , MARIA_NAME_DEXT ,
2007-01-18 20:38:14 +01:00
DATA_TMP_EXT ,
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
MYF ( ( param - > testflag & T_BACKUP_DATA ?
MY_REDEL_MAKE_BACKUP : 0 ) |
sync_dir ) ) | |
2006-04-11 15:45:10 +02:00
_ma_open_datafile ( info , share , - 1 ) )
got_error = 1 ;
}
}
if ( got_error )
{
if ( ! param - > error_printed )
_ma_check_print_error ( param , " %d when fixing table " , my_errno ) ;
if ( new_file > = 0 )
{
VOID ( my_close ( new_file , MYF ( 0 ) ) ) ;
2007-01-18 20:38:14 +01:00
VOID ( my_delete ( param - > temp_filename , MYF ( MY_WME ) ) ) ;
2007-04-04 22:37:09 +02:00
if ( info - > dfile . file = = new_file )
info - > dfile . file = - 1 ;
2006-04-11 15:45:10 +02:00
}
maria_mark_crashed_on_repair ( info ) ;
}
else if ( key_map = = share - > state . key_map )
share - > state . changed & = ~ STATE_NOT_OPTIMIZED_KEYS ;
2007-04-05 13:38:05 +02:00
share - > state . changed | = STATE_NOT_SORTED_PAGES ;
share - > state . changed & = ~ STATE_NOT_OPTIMIZED_ROWS ;
2006-04-11 15:45:10 +02:00
2007-01-18 20:38:14 +01:00
my_free ( sort_param . rec_buff , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
2006-04-11 15:45:10 +02:00
my_free ( sort_param . record , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
2007-07-02 19:45:15 +02:00
my_free ( ( uchar * ) sort_info . key_block , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
my_free ( ( uchar * ) sort_info . ft_buf , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
2006-04-11 15:45:10 +02:00
my_free ( sort_info . buff , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
VOID ( end_io_cache ( & param - > read_cache ) ) ;
info - > opt_flag & = ~ ( READ_CACHE_USED | WRITE_CACHE_USED ) ;
if ( ! got_error & & ( param - > testflag & T_UNPACK ) )
2007-01-18 20:38:14 +01:00
restore_data_file_type ( share ) ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( got_error ) ;
}
/*
Threaded repair of table using sorting
SYNOPSIS
maria_repair_parallel ( )
param Repair parameters
info MARIA handler to repair
name Name of table ( for warnings )
rep_quick set to < > 0 if we should not change data file
DESCRIPTION
Same as maria_repair_by_sort but do it multithreaded
Each key is handled by a separate thread .
TODO : make a number of threads a parameter
2006-12-19 19:15:53 +01:00
In parallel repair we use one thread per index . There are two modes :
Quick
Only the indexes are rebuilt . All threads share a read buffer .
Every thread that needs fresh data in the buffer enters the shared
cache lock . The last thread joining the lock reads the buffer from
the data file and wakes all other threads .
Non - quick
The data file is rebuilt and all indexes are rebuilt to point to
the new record positions . One thread is the master thread . It
reads from the old data file and writes to the new data file . It
also creates one of the indexes . The other threads read from a
buffer which is filled by the master . If they need fresh data ,
they enter the shared cache lock . If the masters write buffer is
full , it flushes it to the new data file and enters the shared
cache lock too . When all threads joined in the lock , the master
copies its write buffer to the read buffer for the other threads
and wakes them .
2006-04-11 15:45:10 +02:00
RESULT
0 ok
< > 0 Error
*/
int maria_repair_parallel ( HA_CHECK * param , register MARIA_HA * info ,
const char * name , int rep_quick )
{
# ifndef THREAD
return maria_repair_by_sort ( param , info , name , rep_quick ) ;
# else
int got_error ;
uint i , key , total_key_length , istep ;
ulong rec_length ;
ha_rows start_records ;
my_off_t new_header_length , del ;
File new_file ;
MARIA_SORT_PARAM * sort_param = 0 ;
MARIA_SHARE * share = info - > s ;
ulong * rec_per_key_part ;
HA_KEYSEG * keyseg ;
char llbuff [ 22 ] ;
2006-12-19 19:15:53 +01:00
IO_CACHE new_data_cache ; /* For non-quick repair. */
2006-04-11 15:45:10 +02:00
IO_CACHE_SHARE io_share ;
MARIA_SORT_INFO sort_info ;
ulonglong key_map = share - > state . key_map ;
pthread_attr_t thr_attr ;
Maria:
* Don't modify share->base.born_transactional; now it is a value carved
in stone at creation time. share->now_transactional is what can be
modified: it starts at born_transactional, can become false during
ALTER TABLE (when we want no logging), and restored later.
* Not resetting create_rename_lsn to 0 during delete_all or repair.
* when we temporarily disable transactionality, we also change
the page type to PAGECACHE_PLAIN_PAGE: it bypasses some work in the
page cache (optimization), and avoids assertions related to LSNs.
* Disable INSERT DELAYED for transactional tables, because
durability could not be guaranteed (insertion may even not happen)
mysys/mf_keycache.c:
comment
storage/maria/ha_maria.cc:
* a transactional table cannot do INSERT DELAYED
* ha_maria::save_transactional not needed anymore, as now instead
we don't modify MARIA_SHARE::MARIA_BASE_INFO::born_transactional
(born_transactional plays the role of save_transactional), and modify
MARIA_SHARE::now_transactional.
* REPAIR_TABLE log record is now logged by maria_repair()
* comment why we rely on born_transactional to know if we should
skipping a transaction.
* putting together two if()s which test for F_UNLCK
storage/maria/ha_maria.h:
ha_maria::save_transactional not needed anymore (moved to the C layer)
storage/maria/ma_blockrec.c:
* For the block record's code (writing/updating/deleting records),
all that counts is now_transactional, not born_transactional.
* As we now set the page type to PAGECACHE_PLAIN_PAGE for tables
which have now_transactional==FALSE, pagecache will not expect
a meaningful LSN for them in pagecache_unlock_by_link(), so
we can pass it LSN_IMPOSSIBLE.
storage/maria/ma_check.c:
* writing LOGREC_REPAIR_TABLE moves from ha_maria::repair()
to maria_repair(), sounds cleaner (less functions to export).
* when opening a table during REPAIR, don't use the realpath-ed name,
as this may fail if the table has symlinked files (maria_open()
would try to find the data and index file in the directory
of unique_file_name, it would fail if data and index files are in
different dirs); use the unresolved name, open_file_name, which is
the argument which was passed to the maria_open() which created 'info'.
storage/maria/ma_close.c:
assert that when a statement is done with a table, it cleans up
storage/maria/ma_create.c:
new name
storage/maria/ma_delete_all.c:
* using now_transactional
* no reason to reset create_rename_lsn during delete_all (a bug);
also no reason to do it during repair: it was put there because
a positive create_rename_lsn caused a call to check_and_set_lsn()
which asserted in DBUG_ASSERT(block->type == PAGECACHE_LSN_PAGE);
first solution was to use LSN_IMPOSSIBLE in _ma_unpin_all_pages() if
not transactional; but then in the case of ALTER TABLE, with
transactionality temporarily disabled, it asserted in
DBUG_ASSERT(LSN_VALID(lsn)) in pagecache_fwrite() (PAGECACHE_LSN_PAGE
page with zero LSN - bad). The additional solution is to use
PAGECACHE_PLAIN_PAGE when we disable transactionality temporarily: this
avoids checks on the LSN, and also bypasses (optimization) the "flush
log up to LSN" call when the pagecache flushes our page (in other
words, no WAL needed).
storage/maria/ma_delete_table.c:
use now_transactional
storage/maria/ma_locking.c:
assert that when a statement is done with a table, it cleans up.
storage/maria/ma_loghandler.c:
* now_transactional should be used to test if we want a log record.
* Assertions to make sure dummy_transaction_object is not spoilt
by its many users.
storage/maria/ma_open.c:
base.transactional -> base.born_transactional
storage/maria/ma_pagecache.c:
missing name for page's type. Comment for future.
storage/maria/ma_rename.c:
use now_transactional
storage/maria/maria_chk.c:
use born_transactional
storage/maria/maria_def.h:
MARIA_BASE_INFO::transactional renamed to born_transactional.
MARIA_SHARE::now_transactional introduced.
_ma_repair_write_log_record() is made local to ma_check.c.
Macros to temporarily disable, and re-enable, transactionality for a
table.
storage/maria/maria_read_log.c:
assertions and using the new macros. Adding a forgotten resetting
when we finally close all tables.
2007-07-03 15:20:41 +02:00
myf sync_dir = ( share - > now_transactional & & ! share - > temporary ) ?
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
MY_SYNC_DIR : 0 ;
2006-04-11 15:45:10 +02:00
DBUG_ENTER ( " maria_repair_parallel " ) ;
start_records = info - > state - > records ;
got_error = 1 ;
new_file = - 1 ;
new_header_length = ( param - > testflag & T_UNPACK ) ? 0 :
share - > pack . header_length ;
if ( ! ( param - > testflag & T_SILENT ) )
{
printf ( " - parallel recovering (with sort) MARIA-table '%s' \n " , name ) ;
printf ( " Data records: %s \n " , llstr ( start_records , llbuff ) ) ;
}
param - > testflag | = T_REP ; /* for easy checking */
if ( info - > s - > options & ( HA_OPTION_CHECKSUM | HA_OPTION_COMPRESS_RECORD ) )
param - > testflag | = T_CALC_CHECKSUM ;
2007-08-08 11:36:41 +02:00
if ( _ma_flush_table_files ( info , MARIA_FLUSH_DATA , FLUSH_FORCE_WRITE ,
FLUSH_KEEP ) )
goto err ;
2006-12-19 19:15:53 +01:00
/*
Quick repair ( not touching data file , rebuilding indexes ) :
{
2007-04-04 22:37:09 +02:00
Read cache is ( MI_CHECK * param ) - > read_cache using info - > dfile . file .
2006-12-19 19:15:53 +01:00
}
Non - quick repair ( rebuilding data file and indexes ) :
{
Master thread :
2007-04-04 22:37:09 +02:00
Read cache is ( MI_CHECK * param ) - > read_cache using info - > dfile . file .
2006-12-19 19:15:53 +01:00
Write cache is ( MI_INFO * info ) - > rec_cache using new_file .
Slave threads :
Read cache is new_data_cache synced to master rec_cache .
The final assignment of the filedescriptor for rec_cache is done
after the cache creation .
Don ' t check file size on new_data_cache , as the resulting file size
is not known yet .
As rec_cache and new_data_cache are synced , write_buffer_length is
used for the read cache ' new_data_cache ' . Both start at the same
position ' new_header_length ' .
}
*/
DBUG_PRINT ( " info " , ( " is quick repair: %d " , rep_quick ) ) ;
2006-04-11 15:45:10 +02:00
bzero ( ( char * ) & sort_info , sizeof ( sort_info ) ) ;
2006-12-19 19:15:53 +01:00
/* Initialize pthread structures before goto err. */
pthread_mutex_init ( & sort_info . mutex , MY_MUTEX_INIT_FAST ) ;
pthread_cond_init ( & sort_info . cond , 0 ) ;
2007-07-01 15:20:57 +02:00
sort_info . org_data_file_type = info - > s - > data_file_type ;
2006-04-11 15:45:10 +02:00
if ( ! ( sort_info . key_block =
2006-12-19 19:15:53 +01:00
alloc_key_blocks ( param , ( uint ) param - > sort_key_blocks ,
share - > base . max_key_block_length ) ) | |
2007-04-04 22:37:09 +02:00
init_io_cache ( & param - > read_cache , info - > dfile . file ,
2006-12-19 19:15:53 +01:00
( uint ) param - > read_buffer_length ,
READ_CACHE , share - > pack . header_length , 1 , MYF ( MY_WME ) ) | |
( ! rep_quick & &
2007-04-04 22:37:09 +02:00
( init_io_cache ( & info - > rec_cache , info - > dfile . file ,
2006-12-19 19:15:53 +01:00
( uint ) param - > write_buffer_length ,
WRITE_CACHE , new_header_length , 1 ,
MYF ( MY_WME | MY_WAIT_IF_FULL ) & param - > myf_rw ) | |
init_io_cache ( & new_data_cache , - 1 ,
( uint ) param - > write_buffer_length ,
READ_CACHE , new_header_length , 1 ,
MYF ( MY_WME | MY_DONT_CHECK_FILESIZE ) ) ) ) )
2006-04-11 15:45:10 +02:00
goto err ;
sort_info . key_block_end = sort_info . key_block + param - > sort_key_blocks ;
info - > opt_flag | = WRITE_CACHE_USED ;
2007-04-04 22:37:09 +02:00
info - > rec_cache . file = info - > dfile . file ; /* for sort_delete_record */
2006-04-11 15:45:10 +02:00
if ( ! rep_quick )
{
/* Get real path for data file */
2007-01-18 20:38:14 +01:00
if ( ( new_file = my_create ( fn_format ( param - > temp_filename ,
share - > data_file_name , " " ,
DATA_TMP_EXT ,
2 + 4 ) ,
0 , param - > tmpfile_createflag ,
MYF ( 0 ) ) ) < 0 )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_error ( param , " Can't create new tempfile: '%s' " ,
param - > temp_filename ) ;
goto err ;
}
2007-01-26 12:32:02 +01:00
if ( new_header_length & &
2007-04-04 22:37:09 +02:00
maria_filecopy ( param , new_file , info - > dfile . file , 0L , new_header_length ,
2007-01-26 12:32:02 +01:00
" datafile-header " ) )
2006-04-11 15:45:10 +02:00
goto err ;
if ( param - > testflag & T_UNPACK )
2007-01-18 20:38:14 +01:00
restore_data_file_type ( share ) ;
2006-04-11 15:45:10 +02:00
share - > state . dellink = HA_OFFSET_ERROR ;
info - > rec_cache . file = new_file ;
}
info - > update = ( short ) ( HA_STATE_CHANGED | HA_STATE_ROW_CHANGED ) ;
if ( ! ( param - > testflag & T_CREATE_MISSING_KEYS ) )
{
/*
Flush key cache for this file if we are calling this outside
2007-01-18 20:38:14 +01:00
maria_chk
2006-04-11 15:45:10 +02:00
*/
2007-04-04 22:37:09 +02:00
flush_pagecache_blocks ( share - > pagecache , & share - > kfile ,
FLUSH_IGNORE_CHANGED ) ;
2006-04-11 15:45:10 +02:00
/* Clear the pointers to the given rows */
for ( i = 0 ; i < share - > base . keys ; i + + )
share - > state . key_root [ i ] = HA_OFFSET_ERROR ;
2007-01-18 20:38:14 +01:00
share - > state . key_del = HA_OFFSET_ERROR ;
2006-04-11 15:45:10 +02:00
info - > state - > key_file_length = share - > base . keystart ;
}
else
{
2007-04-04 22:37:09 +02:00
if ( flush_pagecache_blocks ( share - > pagecache , & share - > kfile ,
FLUSH_FORCE_WRITE ) )
2006-04-11 15:45:10 +02:00
goto err ;
key_map = ~ key_map ; /* Create the missing keys */
}
2007-07-01 15:20:57 +02:00
sort_info . info = sort_info . new_info = info ;
sort_info . param = param ;
2006-04-11 15:45:10 +02:00
set_data_file_type ( & sort_info , share ) ;
sort_info . dupp = 0 ;
sort_info . buff = 0 ;
param - > read_cache . end_of_file = sort_info . filelength =
my_seek ( param - > read_cache . file , 0L , MY_SEEK_END , MYF ( 0 ) ) ;
2007-07-01 15:20:57 +02:00
if ( sort_info . org_data_file_type = = DYNAMIC_RECORD )
2006-04-11 15:45:10 +02:00
rec_length = max ( share - > base . min_pack_length + 1 , share - > base . min_block_length ) ;
2007-07-01 15:20:57 +02:00
else if ( sort_info . org_data_file_type = = COMPRESSED_RECORD )
2006-04-11 15:45:10 +02:00
rec_length = share - > base . min_block_length ;
else
rec_length = share - > base . pack_reclength ;
/*
+ 1 below is required hack for parallel repair mode .
The info - > state - > records value , that is compared later
to sort_info . max_records and cannot exceed it , is
increased in sort_key_write . In maria_repair_by_sort , sort_key_write
is called after sort_key_read , where the comparison is performed ,
but in parallel mode master thread can call sort_key_write
before some other repair thread calls sort_key_read .
Furthermore I ' m not even sure + 1 would be enough .
May be sort_info . max_records shold be always set to max value in
parallel mode .
*/
sort_info . max_records =
( ( param - > testflag & T_CREATE_MISSING_KEYS ) ? info - > state - > records + 1 :
( ha_rows ) ( sort_info . filelength / rec_length + 1 ) ) ;
del = info - > state - > del ;
param - > glob_crc = 0 ;
if ( ! ( sort_param = ( MARIA_SORT_PARAM * )
my_malloc ( ( uint ) share - > base . keys *
( sizeof ( MARIA_SORT_PARAM ) + share - > base . pack_reclength ) ,
MYF ( MY_ZEROFILL ) ) ) )
{
_ma_check_print_error ( param , " Not enough memory for key! " ) ;
goto err ;
}
total_key_length = 0 ;
rec_per_key_part = param - > rec_per_key_part ;
info - > state - > records = info - > state - > del = share - > state . split = 0 ;
info - > state - > empty = 0 ;
for ( i = key = 0 , istep = 1 ; key < share - > base . keys ;
rec_per_key_part + = sort_param [ i ] . keyinfo - > keysegs , i + = istep , key + + )
{
sort_param [ i ] . key = key ;
sort_param [ i ] . keyinfo = share - > keyinfo + key ;
sort_param [ i ] . seg = sort_param [ i ] . keyinfo - > seg ;
if ( ! maria_is_key_active ( key_map , key ) )
{
/* Remember old statistics for key */
memcpy ( ( char * ) rec_per_key_part ,
( char * ) ( share - > state . rec_per_key_part +
( uint ) ( rec_per_key_part - param - > rec_per_key_part ) ) ,
sort_param [ i ] . keyinfo - > keysegs * sizeof ( * rec_per_key_part ) ) ;
istep = 0 ;
continue ;
}
istep = 1 ;
if ( ( ! ( param - > testflag & T_SILENT ) ) )
printf ( " - Fixing index %d \n " , key + 1 ) ;
if ( sort_param [ i ] . keyinfo - > flag & HA_FULLTEXT )
{
sort_param [ i ] . key_read = sort_maria_ft_key_read ;
sort_param [ i ] . key_write = sort_maria_ft_key_write ;
}
else
{
sort_param [ i ] . key_read = sort_key_read ;
sort_param [ i ] . key_write = sort_key_write ;
}
sort_param [ i ] . key_cmp = sort_key_cmp ;
sort_param [ i ] . lock_in_memory = maria_lock_memory ;
sort_param [ i ] . tmpdir = param - > tmpdir ;
sort_param [ i ] . sort_info = & sort_info ;
sort_param [ i ] . master = 0 ;
sort_param [ i ] . fix_datafile = 0 ;
2006-12-19 19:15:53 +01:00
sort_param [ i ] . calc_checksum = 0 ;
2006-04-11 15:45:10 +02:00
sort_param [ i ] . filepos = new_header_length ;
sort_param [ i ] . max_pos = sort_param [ i ] . pos = share - > pack . header_length ;
sort_param [ i ] . record = ( ( ( char * ) ( sort_param + share - > base . keys ) ) +
( share - > base . pack_reclength * i ) ) ;
2007-01-18 20:38:14 +01:00
if ( _ma_alloc_buffer ( & sort_param [ i ] . rec_buff , & sort_param [ i ] . rec_buff_size ,
share - > base . default_rec_buff_size ) )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_error ( param , " Not enough memory! " ) ;
goto err ;
}
sort_param [ i ] . key_length = share - > rec_reflength ;
for ( keyseg = sort_param [ i ] . seg ; keyseg - > type ! = HA_KEYTYPE_END ;
keyseg + + )
{
sort_param [ i ] . key_length + = keyseg - > length ;
if ( keyseg - > flag & HA_SPACE_PACK )
sort_param [ i ] . key_length + = get_pack_length ( keyseg - > length ) ;
if ( keyseg - > flag & ( HA_BLOB_PART | HA_VAR_LENGTH_PART ) )
sort_param [ i ] . key_length + = 2 + test ( keyseg - > length > = 127 ) ;
if ( keyseg - > flag & HA_NULL_PART )
sort_param [ i ] . key_length + + ;
}
total_key_length + = sort_param [ i ] . key_length ;
if ( sort_param [ i ] . keyinfo - > flag & HA_FULLTEXT )
{
uint ft_max_word_len_for_sort = FT_MAX_WORD_LEN_FOR_SORT *
sort_param [ i ] . keyinfo - > seg - > charset - > mbmaxlen ;
sort_param [ i ] . key_length + = ft_max_word_len_for_sort - HA_FT_MAXBYTELEN ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
init_alloc_root ( & sort_param [ i ] . wordroot , FTPARSER_MEMROOT_ALLOC_SIZE , 0 ) ;
2006-04-11 15:45:10 +02:00
}
}
sort_info . total_keys = i ;
sort_param [ 0 ] . master = 1 ;
sort_param [ 0 ] . fix_datafile = ( my_bool ) ( ! rep_quick ) ;
2006-12-19 19:15:53 +01:00
sort_param [ 0 ] . calc_checksum = test ( param - > testflag & T_CALC_CHECKSUM ) ;
2006-04-11 15:45:10 +02:00
sort_info . got_error = 0 ;
pthread_mutex_lock ( & sort_info . mutex ) ;
2006-12-19 19:15:53 +01:00
/*
Initialize the I / O cache share for use with the read caches and , in
case of non - quick repair , the write cache . When all threads join on
the cache lock , the writer copies the write cache contents to the
read caches .
*/
if ( i > 1 )
{
if ( rep_quick )
init_io_cache_share ( & param - > read_cache , & io_share , NULL , i ) ;
else
init_io_cache_share ( & new_data_cache , & io_share , & info - > rec_cache , i ) ;
}
else
io_share . total_threads = 0 ; /* share not used */
2006-04-11 15:45:10 +02:00
( void ) pthread_attr_init ( & thr_attr ) ;
( void ) pthread_attr_setdetachstate ( & thr_attr , PTHREAD_CREATE_DETACHED ) ;
for ( i = 0 ; i < sort_info . total_keys ; i + + )
{
2006-12-19 19:15:53 +01:00
/*
Copy the properly initialized IO_CACHE structure so that every
thread has its own copy . In quick mode param - > read_cache is shared
for use by all threads . In non - quick mode all threads but the
first copy the shared new_data_cache , which is synchronized to the
write cache of the first thread . The first thread copies
param - > read_cache , which is not shared .
*/
sort_param [ i ] . read_cache = ( ( rep_quick | | ! i ) ? param - > read_cache :
new_data_cache ) ;
DBUG_PRINT ( " io_cache_share " , ( " thread: %u read_cache: 0x%lx " ,
i , ( long ) & sort_param [ i ] . read_cache ) ) ;
2006-04-11 15:45:10 +02:00
/*
two approaches : the same amount of memory for each thread
or the memory for the same number of keys for each thread . . .
In the second one all the threads will fill their sort_buffers
( and call write_keys ) at the same time , putting more stress on i / o .
*/
sort_param [ i ] . sortbuff_size =
# ifndef USING_SECOND_APPROACH
param - > sort_buffer_length / sort_info . total_keys ;
# else
param - > sort_buffer_length * sort_param [ i ] . key_length / total_key_length ;
# endif
if ( pthread_create ( & sort_param [ i ] . thr , & thr_attr ,
_ma_thr_find_all_keys ,
( void * ) ( sort_param + i ) ) )
{
_ma_check_print_error ( param , " Cannot start a repair thread " ) ;
2006-12-19 19:15:53 +01:00
/* Cleanup: Detach from the share. Avoid others to be blocked. */
if ( io_share . total_threads )
remove_io_thread ( & sort_param [ i ] . read_cache ) ;
DBUG_PRINT ( " error " , ( " Cannot start a repair thread " ) ) ;
2006-04-11 15:45:10 +02:00
sort_info . got_error = 1 ;
}
else
sort_info . threads_running + + ;
}
( void ) pthread_attr_destroy ( & thr_attr ) ;
/* waiting for all threads to finish */
while ( sort_info . threads_running )
pthread_cond_wait ( & sort_info . cond , & sort_info . mutex ) ;
pthread_mutex_unlock ( & sort_info . mutex ) ;
if ( ( got_error = _ma_thr_write_keys ( sort_param ) ) )
{
param - > retry_repair = 1 ;
goto err ;
}
got_error = 1 ; /* Assume the following may go wrong */
if ( sort_param [ 0 ] . fix_datafile )
{
2006-12-19 19:15:53 +01:00
/*
Append some nuls to the end of a memory mapped file . Destroy the
write cache . The master thread did already detach from the share
by remove_io_thread ( ) in sort . c : thr_find_all_keys ( ) .
*/
2006-04-11 15:45:10 +02:00
if ( maria_write_data_suffix ( & sort_info , 1 ) | | end_io_cache ( & info - > rec_cache ) )
goto err ;
if ( param - > testflag & T_SAFE_REPAIR )
{
/* Don't repair if we loosed more than one row */
if ( info - > state - > records + 1 < start_records )
{
info - > state - > records = start_records ;
goto err ;
}
}
share - > state . state . data_file_length = info - > state - > data_file_length =
sort_param - > filepos ;
/* Only whole records */
share - > state . version = ( ulong ) time ( ( time_t * ) 0 ) ;
2006-12-19 19:15:53 +01:00
/*
Exchange the data file descriptor of the table , so that we use the
new file from now on .
*/
2007-04-04 22:37:09 +02:00
my_close ( info - > dfile . file , MYF ( 0 ) ) ;
info - > dfile . file = new_file ;
2006-04-11 15:45:10 +02:00
share - > pack . header_length = ( ulong ) new_header_length ;
}
else
info - > state - > data_file_length = sort_param - > max_pos ;
if ( rep_quick & & del + sort_info . dupp ! = info - > state - > del )
{
_ma_check_print_error ( param , " Couldn't fix table with quick recovery: Found wrong number of deleted records " ) ;
_ma_check_print_error ( param , " Run recovery again without -q " ) ;
param - > retry_repair = 1 ;
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
goto err ;
}
if ( rep_quick & T_FORCE_UNIQUENESS )
{
2007-07-01 15:20:57 +02:00
my_off_t skr = ( info - > state - > data_file_length +
( sort_info . org_data_file_type = = COMPRESSED_RECORD ) ?
MEMMAP_EXTRA_MARGIN : 0 ) ;
2006-04-11 15:45:10 +02:00
# ifdef USE_RELOC
2007-07-01 15:20:57 +02:00
if ( sort_info . org_data_file_type = = STATIC_RECORD & &
2006-04-11 15:45:10 +02:00
skr < share - > base . reloc * share - > base . min_pack_length )
skr = share - > base . reloc * share - > base . min_pack_length ;
# endif
2007-01-18 20:38:14 +01:00
if ( skr ! = sort_info . filelength )
2007-04-04 22:37:09 +02:00
if ( my_chsize ( info - > dfile . file , skr , 0 , MYF ( 0 ) ) )
2006-04-11 15:45:10 +02:00
_ma_check_print_warning ( param ,
" Can't change size of datafile, error: %d " ,
my_errno ) ;
}
if ( param - > testflag & T_CALC_CHECKSUM )
info - > state - > checksum = param - > glob_crc ;
2007-04-04 22:37:09 +02:00
if ( my_chsize ( share - > kfile . file , info - > state - > key_file_length , 0 , MYF ( 0 ) ) )
2006-04-11 15:45:10 +02:00
_ma_check_print_warning ( param ,
" Can't change size of indexfile, error: %d " , my_errno ) ;
if ( ! ( param - > testflag & T_SILENT ) )
{
if ( start_records ! = info - > state - > records )
printf ( " Data records: %s \n " , llstr ( info - > state - > records , llbuff ) ) ;
if ( sort_info . dupp )
_ma_check_print_warning ( param ,
" %s records have been removed " ,
llstr ( sort_info . dupp , llbuff ) ) ;
}
got_error = 0 ;
if ( & share - > state . state ! = info - > state )
memcpy ( & share - > state . state , info - > state , sizeof ( * info - > state ) ) ;
err :
2007-04-04 22:37:09 +02:00
got_error | = _ma_flush_blocks ( param , share - > pagecache , & share - > kfile ) ;
2006-12-19 19:15:53 +01:00
/*
Destroy the write cache . The master thread did already detach from
the share by remove_io_thread ( ) or it was not yet started ( if the
error happend before creating the thread ) .
*/
2006-04-11 15:45:10 +02:00
VOID ( end_io_cache ( & info - > rec_cache ) ) ;
2006-12-19 19:15:53 +01:00
/*
Destroy the new data cache in case of non - quick repair . All slave
threads did either detach from the share by remove_io_thread ( )
already or they were not yet started ( if the error happend before
creating the threads ) .
*/
if ( ! rep_quick )
VOID ( end_io_cache ( & new_data_cache ) ) ;
2006-04-11 15:45:10 +02:00
if ( ! got_error )
{
/* Replace the actual file with the temporary file */
if ( new_file > = 0 )
{
my_close ( new_file , MYF ( 0 ) ) ;
2007-04-04 22:37:09 +02:00
info - > dfile . file = new_file = - 1 ;
2006-04-11 15:45:10 +02:00
if ( maria_change_to_newfile ( share - > data_file_name , MARIA_NAME_DEXT ,
2007-01-18 20:38:14 +01:00
DATA_TMP_EXT ,
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
MYF ( ( param - > testflag & T_BACKUP_DATA ?
MY_REDEL_MAKE_BACKUP : 0 ) |
sync_dir ) ) | |
2006-04-11 15:45:10 +02:00
_ma_open_datafile ( info , share , - 1 ) )
got_error = 1 ;
}
}
if ( got_error )
{
if ( ! param - > error_printed )
_ma_check_print_error ( param , " %d when fixing table " , my_errno ) ;
if ( new_file > = 0 )
{
VOID ( my_close ( new_file , MYF ( 0 ) ) ) ;
2007-01-18 20:38:14 +01:00
VOID ( my_delete ( param - > temp_filename , MYF ( MY_WME ) ) ) ;
2007-04-04 22:37:09 +02:00
if ( info - > dfile . file = = new_file )
info - > dfile . file = - 1 ;
2006-04-11 15:45:10 +02:00
}
maria_mark_crashed_on_repair ( info ) ;
}
else if ( key_map = = share - > state . key_map )
share - > state . changed & = ~ STATE_NOT_OPTIMIZED_KEYS ;
2007-04-05 13:38:05 +02:00
share - > state . changed | = STATE_NOT_SORTED_PAGES ;
share - > state . changed & = ~ STATE_NOT_OPTIMIZED_ROWS ;
2006-04-11 15:45:10 +02:00
pthread_cond_destroy ( & sort_info . cond ) ;
pthread_mutex_destroy ( & sort_info . mutex ) ;
2007-07-02 19:45:15 +02:00
my_free ( ( uchar * ) sort_info . ft_buf , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
my_free ( ( uchar * ) sort_info . key_block , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
my_free ( ( uchar * ) sort_param , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
2006-04-11 15:45:10 +02:00
my_free ( sort_info . buff , MYF ( MY_ALLOW_ZERO_PTR ) ) ;
VOID ( end_io_cache ( & param - > read_cache ) ) ;
info - > opt_flag & = ~ ( READ_CACHE_USED | WRITE_CACHE_USED ) ;
if ( ! got_error & & ( param - > testflag & T_UNPACK ) )
2007-01-18 20:38:14 +01:00
restore_data_file_type ( share ) ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( got_error ) ;
# endif /* THREAD */
}
/* Read next record and return next key */
2007-07-02 19:45:15 +02:00
static int sort_key_read ( MARIA_SORT_PARAM * sort_param , uchar * key )
2006-04-11 15:45:10 +02:00
{
int error ;
2007-01-18 20:38:14 +01:00
MARIA_SORT_INFO * sort_info = sort_param - > sort_info ;
MARIA_HA * info = sort_info - > info ;
2006-04-11 15:45:10 +02:00
DBUG_ENTER ( " sort_key_read " ) ;
if ( ( error = sort_get_next_record ( sort_param ) ) )
DBUG_RETURN ( error ) ;
if ( info - > state - > records = = sort_info - > max_records )
{
_ma_check_print_error ( sort_info - > param ,
" Key %d - Found too many records; Can't continue " ,
sort_param - > key + 1 ) ;
DBUG_RETURN ( 1 ) ;
}
sort_param - > real_key_length =
( info - > s - > rec_reflength +
2007-01-18 20:38:14 +01:00
_ma_make_key ( info , sort_param - > key , key ,
2006-04-11 15:45:10 +02:00
sort_param - > record , sort_param - > filepos ) ) ;
# ifdef HAVE_purify
bzero ( key + sort_param - > real_key_length ,
( sort_param - > key_length - sort_param - > real_key_length ) ) ;
# endif
DBUG_RETURN ( _ma_sort_write_record ( sort_param ) ) ;
} /* sort_key_read */
2007-01-18 20:38:14 +01:00
2007-07-02 19:45:15 +02:00
static int sort_maria_ft_key_read ( MARIA_SORT_PARAM * sort_param , uchar * key )
2006-04-11 15:45:10 +02:00
{
int error ;
MARIA_SORT_INFO * sort_info = sort_param - > sort_info ;
MARIA_HA * info = sort_info - > info ;
FT_WORD * wptr = 0 ;
DBUG_ENTER ( " sort_maria_ft_key_read " ) ;
if ( ! sort_param - > wordlist )
{
for ( ; ; )
{
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
free_root ( & sort_param - > wordroot , MYF ( MY_MARK_BLOCKS_FREE ) ) ;
2006-04-11 15:45:10 +02:00
if ( ( error = sort_get_next_record ( sort_param ) ) )
DBUG_RETURN ( error ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
if ( ! ( wptr = _ma_ft_parserecord ( info , sort_param - > key , sort_param - > record ,
& sort_param - > wordroot ) ) )
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 1 ) ;
if ( wptr - > pos )
break ;
error = _ma_sort_write_record ( sort_param ) ;
}
sort_param - > wordptr = sort_param - > wordlist = wptr ;
}
else
{
error = 0 ;
wptr = ( FT_WORD * ) ( sort_param - > wordptr ) ;
}
sort_param - > real_key_length = ( info - > s - > rec_reflength +
_ma_ft_make_key ( info , sort_param - > key ,
2007-01-18 20:38:14 +01:00
key , wptr + + ,
sort_param - > filepos ) ) ;
2006-04-11 15:45:10 +02:00
# ifdef HAVE_purify
if ( sort_param - > key_length > sort_param - > real_key_length )
bzero ( key + sort_param - > real_key_length ,
( sort_param - > key_length - sort_param - > real_key_length ) ) ;
# endif
if ( ! wptr - > pos )
{
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
free_root ( & sort_param - > wordroot , MYF ( MY_MARK_BLOCKS_FREE ) ) ;
2006-04-11 15:45:10 +02:00
sort_param - > wordlist = 0 ;
error = _ma_sort_write_record ( sort_param ) ;
}
else
sort_param - > wordptr = ( void * ) wptr ;
DBUG_RETURN ( error ) ;
} /* sort_maria_ft_key_read */
2006-12-19 19:15:53 +01:00
/*
Read next record from file using parameters in sort_info .
SYNOPSIS
sort_get_next_record ( )
sort_param Information about and for the sort process
2007-07-01 15:20:57 +02:00
NOTES
2006-12-19 19:15:53 +01:00
Dynamic Records With Non - Quick Parallel Repair
2007-07-01 15:20:57 +02:00
For non - quick parallel repair we use a synchronized read / write
cache . This means that one thread is the master who fixes the data
file by reading each record from the old data file and writing it
to the new data file . By doing this the records in the new data
file are written contiguously . Whenever the write buffer is full ,
it is copied to the read buffer . The slaves read from the read
buffer , which is not associated with a file . Thus read_cache . file
is - 1. When using _mi_read_cache ( ) , the slaves must always set
flag to READING_NEXT so that the function never tries to read from
file . This is safe because the records are contiguous . There is no
need to read outside the cache . This condition is evaluated in the
variable ' parallel_flag ' for quick reference . read_cache . file must
be > = 0 in every other case .
2006-12-19 19:15:53 +01:00
RETURN
- 1 end of file
0 ok
2007-07-01 15:20:57 +02:00
sort_param - > filepos points to record position .
sort_param - > record contains record
2006-12-19 19:15:53 +01:00
> 0 error
*/
2006-04-11 15:45:10 +02:00
static int sort_get_next_record ( MARIA_SORT_PARAM * sort_param )
{
int searching ;
2006-12-19 19:15:53 +01:00
int parallel_flag ;
2006-04-11 15:45:10 +02:00
uint found_record , b_type , left_length ;
my_off_t pos ;
MARIA_BLOCK_INFO block_info ;
MARIA_SORT_INFO * sort_info = sort_param - > sort_info ;
HA_CHECK * param = sort_info - > param ;
MARIA_HA * info = sort_info - > info ;
MARIA_SHARE * share = info - > s ;
char llbuff [ 22 ] , llbuff2 [ 22 ] ;
DBUG_ENTER ( " sort_get_next_record " ) ;
if ( * _ma_killed_ptr ( param ) )
DBUG_RETURN ( 1 ) ;
2007-07-01 15:20:57 +02:00
switch ( sort_info - > org_data_file_type ) {
2007-01-18 20:38:14 +01:00
case BLOCK_RECORD :
2007-07-01 15:20:57 +02:00
{
for ( ; ; )
{
int flag ;
if ( info ! = sort_info - > new_info )
{
/* Safe scanning */
flag = _ma_safe_scan_block_record ( sort_info , info ,
sort_param - > record ) ;
}
else
{
Fix for three bugs:
number 1: "./mtr --mysqld=--default-storage-engine=maria backup"
restored no rows (forgot to flush data pages before my_copy(),
and also the maria_repair() used by ha_maria::restore() needed
a correct data_file_length to not miss rows). [note that BACKUP
TABLE will be removed anyway in 5.2]
number 2: "./mtr --mysqld=--default-storage-engine=maria bootstrap"
caused segfault (uninitialized variable)
number 3: "./mtr --mysqld=--default-storage-engine=maria check"
showed warning in CHECK TABLE (maria_create() created a non-empty
data file with data_file_length==0).
storage/maria/ha_maria.cc:
in ha_maria::backup, need to flush the data file before copying it,
otherwise data misses from the copy (bug 1)
storage/maria/ma_bitmap.c:
when allocating data at the end of the bitmap, best_data is at "end",
should not be left to 0 (bug 2)
storage/maria/ma_check.c:
_ma_scan_block_record() is used in QUICK repair. It relies on
data_file_length. RESTORE TABLE mixes the MAI of an empty table
(so, data_file_length==0) with an non-empty MAD, and does a
QUICK repair; that got fooled (thought it had hit EOF immediately,
so found no records) (bug 1)
storage/maria/ma_create.c:
At the end of maria_create() we have, in the index file,
data_file_length==0, while the data file has a bitmap page (8192).
This inconsistency makes CHECK TABLE rightly complain.
Fixed by not creating a first bitmap page during maria_create()
(also saves disk space) (bug 3) Question for Monty.
storage/maria/ma_extra.c:
A function to flush the data and index files before one can
use OS syscalls (reads, writes) on those files. For example,
ha_maria::backup() does a my_copy() of the data file and so
all cached pieces of this file must be sent to the OS (bug 1)
This function will have to be used elsewhere in Maria, several places
have not been updated when we added pagecache-ing of the data file
(they still only flush the index file), they are probable bugs.
storage/maria/maria_def.h:
new function. Needs to be visible from ha_maria::backup.
2007-08-07 16:06:42 +02:00
/*
Scan on clean table .
It requires a reliable data_file_length so we set it .
*/
Fix for errors during:
"./mtr --mysqld=--default-storage-engine=maria mysqldump".
First problem was use of INSERT DELAYED and MERGE tables without
specifying that the tables to create should always be MyISAM.
After fixing this, no rows were returned by the final SELECT of the
"BUG 19025" portion of the test. Simplified problem was:
LOCK TABLES `t1` WRITE;
/*!40000 ALTER TABLE `t1` DISABLE KEYS */;
INSERT INTO `t1` VALUES ('bla',1000),('bla',1001),('bla',1002);
/*!40000 ALTER TABLE `t1` ENABLE KEYS */;
UNLOCK TABLES;
select * from t1;
The SELECT would find no rows. Reason: ENABLE KEYS does a maria_repair();
but data pages are still in the page cache and not on disk (because
they were not flushed because maria_lock_database(F_UNLCK) was
not called at the end of INSERT because under LOCK TABLES).
At start of maria_repair(), sort_info.filelength is set to the
physical size of the data file (=> too small because pages are in
cache and not on disk).
Then in sort_get_next_record(), when seeing end-of-file, this is done:
sort_param->max_pos= sort_info->filelength;
Further in maria_repair(), this is done:
info->state->data_file_length= sort_param.max_pos;
and so data_file_length is smaller (0) than reality (16384).
This makes SELECT think EOF is where it is not, and thus find
no rows.
This is fixed by flushing all data pages at the start of maria_repair()
(no performance problem is introduced as in common cases where
ALTER TABLE is not under LOCK TABLES, the previous statement did
this flush anyway).
Another reason to do this flush is that, if not doing it, old cached
pages might go down onto the repaired data file at a later point
and thus corrupt it (assume a REPAIR non-QUICK).
A similar bug is fixed:
LOCK TABLES WRITE; INSERT; CHECK TABLE;
reports "Size of datafile is: 0 Should be: 16384"
again because the physical size was read without a preliminary
page cache flush.
mysql-test/r/maria.result:
result update
mysql-test/r/mysqldump.result:
result update
mysql-test/t/maria.test:
adding test for fixed bug in LOCK TABLES + CHECK TABLE + block format.
Disabling portion which hits "incorrect key file" but still
letting it make the test fail (Monty to fix).
mysql-test/t/mysqldump.test:
in places where test expects engine to support INSERT DELAYED and
be includable in a MERGE table, i.e. be MyISAM, we explicitely
ask for MyISAM.
storage/maria/ma_check.c:
Before reading the data file's physical size with my_seek(MY_SEEK_END)
during maria_chk_size() and maria_repair(), we must flush this
data file, otherwise physical size is misleading and leads to
- CHECK TABLE finding the table corrupted ("size of datafile should be"
error)
- ALTER TABLE ENABLE KEYS losing rows (maria_repair()
setting data_file_length to a too small value => later SELECT does
not find rows though they are in the data file).
This fixes the "mysqldump.test" failure.
sort_info.filelength contains the physical size, re-using it.
2007-08-07 18:23:49 +02:00
info - > state - > data_file_length = sort_info - > filelength ;
2007-07-01 15:20:57 +02:00
flag = _ma_scan_block_record ( info , sort_param - > record ,
info - > cur_row . nextpos , 1 ) ;
}
if ( ! flag )
{
if ( sort_param - > calc_checksum )
{
ha_checksum checksum ;
checksum = ( * info - > s - > calc_check_checksum ) ( info , sort_param - > record ) ;
if ( info - > s - > calc_checksum & &
info - > cur_row . checksum ! = ( checksum & 255 ) )
{
if ( param - > testflag & T_VERBOSE )
{
char llbuff [ 22 ] ;
record_pos_to_txt ( info , sort_param - > filepos , llbuff ) ;
_ma_check_print_info ( param ,
" Found record with wrong checksum at %s " ,
llbuff ) ;
}
continue ;
}
info - > cur_row . checksum = checksum ;
param - > glob_crc + = checksum ;
}
sort_param - > filepos = info - > cur_row . lastpos ;
DBUG_RETURN ( 0 ) ;
}
if ( flag = = HA_ERR_END_OF_FILE )
{
sort_param - > max_pos = sort_info - > filelength ;
DBUG_RETURN ( - 1 ) ;
}
/* Retry only if wrong record, not if disk error */
if ( flag ! = HA_ERR_WRONG_IN_RECORD )
DBUG_RETURN ( flag ) ;
}
2007-01-18 20:38:14 +01:00
break ;
2007-07-01 15:20:57 +02:00
}
2006-04-11 15:45:10 +02:00
case STATIC_RECORD :
for ( ; ; )
{
if ( my_b_read ( & sort_param - > read_cache , sort_param - > record ,
share - > base . pack_reclength ) )
{
if ( sort_param - > read_cache . error )
param - > out_flag | = O_DATA_LOST ;
param - > retry_repair = 1 ;
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
DBUG_RETURN ( - 1 ) ;
}
sort_param - > start_recpos = sort_param - > pos ;
if ( ! sort_param - > fix_datafile )
{
sort_param - > filepos = sort_param - > pos ;
if ( sort_param - > master )
share - > state . split + + ;
}
sort_param - > max_pos = ( sort_param - > pos + = share - > base . pack_reclength ) ;
if ( * sort_param - > record )
{
2006-12-19 19:15:53 +01:00
if ( sort_param - > calc_checksum )
2007-01-18 20:38:14 +01:00
param - > glob_crc + = ( info - > cur_row . checksum =
2006-04-11 15:45:10 +02:00
_ma_static_checksum ( info , sort_param - > record ) ) ;
DBUG_RETURN ( 0 ) ;
}
if ( ! sort_param - > fix_datafile & & sort_param - > master )
{
info - > state - > del + + ;
info - > state - > empty + = share - > base . pack_reclength ;
}
}
case DYNAMIC_RECORD :
2007-04-19 17:48:36 +02:00
{
2007-07-02 19:45:15 +02:00
uchar * to ;
2006-04-11 15:45:10 +02:00
LINT_INIT ( to ) ;
2007-07-01 15:20:57 +02:00
ha_checksum checksum = 0 ;
2006-04-11 15:45:10 +02:00
pos = sort_param - > pos ;
searching = ( sort_param - > fix_datafile & & ( param - > testflag & T_EXTEND ) ) ;
2006-12-19 19:15:53 +01:00
parallel_flag = ( sort_param - > read_cache . file < 0 ) ? READING_NEXT : 0 ;
2006-04-11 15:45:10 +02:00
for ( ; ; )
{
found_record = block_info . second_read = 0 ;
left_length = 1 ;
if ( searching )
{
pos = MY_ALIGN ( pos , MARIA_DYN_ALIGN_SIZE ) ;
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
sort_param - > start_recpos = pos ;
}
do
{
if ( pos > sort_param - > max_pos )
sort_param - > max_pos = pos ;
if ( pos & ( MARIA_DYN_ALIGN_SIZE - 1 ) )
{
if ( ( param - > testflag & T_VERBOSE ) | | searching = = 0 )
_ma_check_print_info ( param , " Wrong aligned block at %s " ,
llstr ( pos , llbuff ) ) ;
if ( searching )
goto try_next ;
}
if ( found_record & & pos = = param - > search_after_block )
_ma_check_print_info ( param , " Block: %s used by record at %s " ,
llstr ( param - > search_after_block , llbuff ) ,
llstr ( sort_param - > start_recpos , llbuff2 ) ) ;
if ( _ma_read_cache ( & sort_param - > read_cache ,
2007-07-02 19:45:15 +02:00
( uchar * ) block_info . header , pos ,
2006-04-11 15:45:10 +02:00
MARIA_BLOCK_INFO_HEADER_LENGTH ,
( ! found_record ? READING_NEXT : 0 ) |
2006-12-19 19:15:53 +01:00
parallel_flag | READING_HEADER ) )
2006-04-11 15:45:10 +02:00
{
if ( found_record )
{
_ma_check_print_info ( param ,
" Can't read whole record at %s (errno: %d) " ,
llstr ( sort_param - > start_recpos , llbuff ) , errno ) ;
goto try_next ;
}
DBUG_RETURN ( - 1 ) ;
}
if ( searching & & ! sort_param - > fix_datafile )
{
param - > error_printed = 1 ;
param - > retry_repair = 1 ;
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
DBUG_RETURN ( 1 ) ; /* Something wrong with data */
}
b_type = _ma_get_block_info ( & block_info , - 1 , pos ) ;
if ( ( b_type & ( BLOCK_ERROR | BLOCK_FATAL_ERROR ) ) | |
( ( b_type & BLOCK_FIRST ) & &
( block_info . rec_len < ( uint ) share - > base . min_pack_length | |
block_info . rec_len > ( uint ) share - > base . max_pack_length ) ) )
{
uint i ;
if ( param - > testflag & T_VERBOSE | | searching = = 0 )
_ma_check_print_info ( param ,
" Wrong bytesec: %3d-%3d-%3d at %10s; Skipped " ,
block_info . header [ 0 ] , block_info . header [ 1 ] ,
block_info . header [ 2 ] , llstr ( pos , llbuff ) ) ;
if ( found_record )
goto try_next ;
block_info . second_read = 0 ;
searching = 1 ;
/* Search after block in read header string */
for ( i = MARIA_DYN_ALIGN_SIZE ;
i < MARIA_BLOCK_INFO_HEADER_LENGTH ;
i + = MARIA_DYN_ALIGN_SIZE )
if ( block_info . header [ i ] > = 1 & &
block_info . header [ i ] < = MARIA_MAX_DYN_HEADER_BYTE )
break ;
pos + = ( ulong ) i ;
sort_param - > start_recpos = pos ;
continue ;
}
if ( b_type & BLOCK_DELETED )
{
bool error = 0 ;
if ( block_info . block_len + ( uint ) ( block_info . filepos - pos ) <
share - > base . min_block_length )
{
if ( ! searching )
_ma_check_print_info ( param ,
" Deleted block with impossible length %u at %s " ,
block_info . block_len , llstr ( pos , llbuff ) ) ;
error = 1 ;
}
else
{
if ( ( block_info . next_filepos ! = HA_OFFSET_ERROR & &
block_info . next_filepos > =
info - > state - > data_file_length ) | |
( block_info . prev_filepos ! = HA_OFFSET_ERROR & &
block_info . prev_filepos > = info - > state - > data_file_length ) )
{
if ( ! searching )
_ma_check_print_info ( param ,
" Delete link points outside datafile at %s " ,
llstr ( pos , llbuff ) ) ;
error = 1 ;
}
}
if ( error )
{
if ( found_record )
goto try_next ;
searching = 1 ;
pos + = MARIA_DYN_ALIGN_SIZE ;
sort_param - > start_recpos = pos ;
block_info . second_read = 0 ;
continue ;
}
}
else
{
if ( block_info . block_len + ( uint ) ( block_info . filepos - pos ) <
share - > base . min_block_length | |
block_info . block_len > ( uint ) share - > base . max_pack_length +
MARIA_SPLIT_LENGTH )
{
if ( ! searching )
_ma_check_print_info ( param ,
" Found block with impossible length %u at %s; Skipped " ,
block_info . block_len + ( uint ) ( block_info . filepos - pos ) ,
llstr ( pos , llbuff ) ) ;
if ( found_record )
goto try_next ;
searching = 1 ;
pos + = MARIA_DYN_ALIGN_SIZE ;
sort_param - > start_recpos = pos ;
block_info . second_read = 0 ;
continue ;
}
}
if ( b_type & ( BLOCK_DELETED | BLOCK_SYNC_ERROR ) )
{
if ( ! sort_param - > fix_datafile & & sort_param - > master & &
( b_type & BLOCK_DELETED ) )
{
info - > state - > empty + = block_info . block_len ;
info - > state - > del + + ;
share - > state . split + + ;
}
if ( found_record )
goto try_next ;
if ( searching )
{
pos + = MARIA_DYN_ALIGN_SIZE ;
sort_param - > start_recpos = pos ;
}
else
pos = block_info . filepos + block_info . block_len ;
block_info . second_read = 0 ;
continue ;
}
if ( ! sort_param - > fix_datafile & & sort_param - > master )
share - > state . split + + ;
if ( ! found_record + + )
{
sort_param - > find_length = left_length = block_info . rec_len ;
sort_param - > start_recpos = pos ;
if ( ! sort_param - > fix_datafile )
sort_param - > filepos = sort_param - > start_recpos ;
if ( sort_param - > fix_datafile & & ( param - > testflag & T_EXTEND ) )
sort_param - > pos = block_info . filepos + 1 ;
else
sort_param - > pos = block_info . filepos + block_info . block_len ;
if ( share - > base . blobs )
{
2007-01-18 20:38:14 +01:00
if ( _ma_alloc_buffer ( & sort_param - > rec_buff ,
& sort_param - > rec_buff_size ,
block_info . rec_len +
info - > s - > base . extra_rec_buff_size ) )
2006-04-11 15:45:10 +02:00
{
if ( param - > max_record_length > = block_info . rec_len )
{
_ma_check_print_error ( param , " Not enough memory for blob at %s (need %lu) " ,
llstr ( sort_param - > start_recpos , llbuff ) ,
( ulong ) block_info . rec_len ) ;
DBUG_RETURN ( 1 ) ;
}
else
{
_ma_check_print_info ( param , " Not enough memory for blob at %s (need %lu); Row skipped " ,
llstr ( sort_param - > start_recpos , llbuff ) ,
( ulong ) block_info . rec_len ) ;
goto try_next ;
}
}
}
2007-01-18 20:38:14 +01:00
to = sort_param - > rec_buff ;
2006-04-11 15:45:10 +02:00
}
if ( left_length < block_info . data_len | | ! block_info . data_len )
{
_ma_check_print_info ( param ,
2007-01-26 12:32:02 +01:00
" Found block with too small length at %s; "
" Skipped " ,
llstr ( sort_param - > start_recpos , llbuff ) ) ;
2006-04-11 15:45:10 +02:00
goto try_next ;
}
if ( block_info . filepos + block_info . data_len >
sort_param - > read_cache . end_of_file )
{
_ma_check_print_info ( param ,
2007-01-26 12:32:02 +01:00
" Found block that points outside data file "
" at %s " ,
llstr ( sort_param - > start_recpos , llbuff ) ) ;
2006-04-11 15:45:10 +02:00
goto try_next ;
}
2006-12-19 19:15:53 +01:00
/*
Copy information that is already read . Avoid accessing data
below the cache start . This could happen if the header
streched over the end of the previous buffer contents .
*/
{
uint header_len = ( uint ) ( block_info . filepos - pos ) ;
uint prefetch_len = ( MARIA_BLOCK_INFO_HEADER_LENGTH - header_len ) ;
if ( prefetch_len > block_info . data_len )
prefetch_len = block_info . data_len ;
if ( prefetch_len )
{
memcpy ( to , block_info . header + header_len , prefetch_len ) ;
block_info . filepos + = prefetch_len ;
block_info . data_len - = prefetch_len ;
left_length - = prefetch_len ;
to + = prefetch_len ;
}
}
if ( block_info . data_len & &
_ma_read_cache ( & sort_param - > read_cache , to , block_info . filepos ,
block_info . data_len ,
( found_record = = 1 ? READING_NEXT : 0 ) |
parallel_flag ) )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_info ( param ,
" Read error for block at: %s (error: %d); Skipped " ,
llstr ( block_info . filepos , llbuff ) , my_errno ) ;
goto try_next ;
}
left_length - = block_info . data_len ;
to + = block_info . data_len ;
pos = block_info . next_filepos ;
if ( pos = = HA_OFFSET_ERROR & & left_length )
{
_ma_check_print_info ( param , " Wrong block with wrong total length starting at %s " ,
llstr ( sort_param - > start_recpos , llbuff ) ) ;
goto try_next ;
}
if ( pos + MARIA_BLOCK_INFO_HEADER_LENGTH > sort_param - > read_cache . end_of_file )
{
_ma_check_print_info ( param , " Found link that points at %s (outside data file) at %s " ,
llstr ( pos , llbuff2 ) ,
llstr ( sort_param - > start_recpos , llbuff ) ) ;
goto try_next ;
}
} while ( left_length ) ;
if ( _ma_rec_unpack ( info , sort_param - > record , sort_param - > rec_buff ,
sort_param - > find_length ) ! = MY_FILE_ERROR )
{
if ( sort_param - > read_cache . error < 0 )
DBUG_RETURN ( 1 ) ;
2006-12-19 19:15:53 +01:00
if ( sort_param - > calc_checksum )
2007-07-01 15:20:57 +02:00
checksum = ( info - > s - > calc_check_checksum ) ( info , sort_param - > record ) ;
2006-04-11 15:45:10 +02:00
if ( ( param - > testflag & ( T_EXTEND | T_REP ) ) | | searching )
{
if ( _ma_rec_check ( info , sort_param - > record , sort_param - > rec_buff ,
sort_param - > find_length ,
( param - > testflag & T_QUICK ) & &
2006-12-19 19:15:53 +01:00
sort_param - > calc_checksum & &
2007-07-01 15:20:57 +02:00
test ( info - > s - > calc_checksum ) , checksum ) )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_info ( param , " Found wrong packed record at %s " ,
llstr ( sort_param - > start_recpos , llbuff ) ) ;
goto try_next ;
}
}
2006-12-19 19:15:53 +01:00
if ( sort_param - > calc_checksum )
2007-07-01 15:20:57 +02:00
param - > glob_crc + = checksum ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 0 ) ;
}
if ( ! searching )
_ma_check_print_info ( param , " Key %d - Found wrong stored record at %s " ,
sort_param - > key + 1 ,
llstr ( sort_param - > start_recpos , llbuff ) ) ;
try_next :
pos = ( sort_param - > start_recpos + = MARIA_DYN_ALIGN_SIZE ) ;
searching = 1 ;
}
2007-04-19 17:48:36 +02:00
}
2006-04-11 15:45:10 +02:00
case COMPRESSED_RECORD :
for ( searching = 0 ; ; searching = 1 , sort_param - > pos + + )
{
2007-07-02 19:45:15 +02:00
if ( _ma_read_cache ( & sort_param - > read_cache , ( uchar * ) block_info . header ,
2006-04-11 15:45:10 +02:00
sort_param - > pos ,
share - > pack . ref_length , READING_NEXT ) )
DBUG_RETURN ( - 1 ) ;
if ( searching & & ! sort_param - > fix_datafile )
{
param - > error_printed = 1 ;
param - > retry_repair = 1 ;
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
DBUG_RETURN ( 1 ) ; /* Something wrong with data */
}
sort_param - > start_recpos = sort_param - > pos ;
2006-12-19 19:15:53 +01:00
if ( _ma_pack_get_block_info ( info , & sort_param - > bit_buff , & block_info ,
2007-01-26 12:32:02 +01:00
& sort_param - > rec_buff ,
& sort_param - > rec_buff_size , - 1 ,
sort_param - > pos ) )
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( - 1 ) ;
if ( ! block_info . rec_len & &
sort_param - > pos + MEMMAP_EXTRA_MARGIN = =
sort_param - > read_cache . end_of_file )
DBUG_RETURN ( - 1 ) ;
if ( block_info . rec_len < ( uint ) share - > min_pack_length | |
block_info . rec_len > ( uint ) share - > max_pack_length )
{
if ( ! searching )
_ma_check_print_info ( param , " Found block with wrong recordlength: %d at %s \n " ,
block_info . rec_len ,
llstr ( sort_param - > pos , llbuff ) ) ;
continue ;
}
2007-07-02 19:45:15 +02:00
if ( _ma_read_cache ( & sort_param - > read_cache , ( uchar * ) sort_param - > rec_buff ,
2006-04-11 15:45:10 +02:00
block_info . filepos , block_info . rec_len ,
READING_NEXT ) )
{
if ( ! searching )
_ma_check_print_info ( param , " Couldn't read whole record from %s " ,
llstr ( sort_param - > pos , llbuff ) ) ;
continue ;
}
2006-12-19 19:15:53 +01:00
if ( _ma_pack_rec_unpack ( info , & sort_param - > bit_buff , sort_param - > record ,
sort_param - > rec_buff , block_info . rec_len ) )
2006-04-11 15:45:10 +02:00
{
if ( ! searching )
_ma_check_print_info ( param , " Found wrong record at %s " ,
llstr ( sort_param - > pos , llbuff ) ) ;
continue ;
}
if ( ! sort_param - > fix_datafile )
{
sort_param - > filepos = sort_param - > pos ;
if ( sort_param - > master )
share - > state . split + + ;
}
sort_param - > max_pos = ( sort_param - > pos = block_info . filepos +
block_info . rec_len ) ;
info - > packed_length = block_info . rec_len ;
2007-01-18 20:38:14 +01:00
2006-12-19 19:15:53 +01:00
if ( sort_param - > calc_checksum )
2007-01-18 20:38:14 +01:00
{
2007-07-01 15:20:57 +02:00
info - > cur_row . checksum = ( * info - > s - > calc_check_checksum ) ( info ,
sort_param - >
record ) ;
2007-01-18 20:38:14 +01:00
param - > glob_crc + = info - > cur_row . checksum ;
}
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 0 ) ;
}
}
DBUG_RETURN ( 1 ) ; /* Impossible */
}
2006-12-19 19:15:53 +01:00
/*
Write record to new file .
SYNOPSIS
_ma_sort_write_record ( )
sort_param Sort parameters .
NOTE
This is only called by a master thread if parallel repair is used .
RETURN
0 OK
1 Error
*/
2006-04-11 15:45:10 +02:00
int _ma_sort_write_record ( MARIA_SORT_PARAM * sort_param )
{
int flag ;
uint length ;
ulong block_length , reclength ;
2007-07-02 19:45:15 +02:00
uchar * from ;
uchar block_buff [ 8 ] ;
2006-04-11 15:45:10 +02:00
MARIA_SORT_INFO * sort_info = sort_param - > sort_info ;
2007-07-01 15:20:57 +02:00
HA_CHECK * param = sort_info - > param ;
MARIA_HA * info = sort_info - > new_info ;
2006-04-11 15:45:10 +02:00
MARIA_SHARE * share = info - > s ;
DBUG_ENTER ( " _ma_sort_write_record " ) ;
if ( sort_param - > fix_datafile )
{
switch ( sort_info - > new_data_file_type ) {
2007-01-18 20:38:14 +01:00
case BLOCK_RECORD :
2007-07-01 15:20:57 +02:00
if ( ( sort_param - > filepos = ( * share - > write_record_init ) ( info ,
sort_param - >
record ) ) = =
HA_OFFSET_ERROR )
DBUG_RETURN ( 1 ) ;
2007-01-18 20:38:14 +01:00
break ;
2006-04-11 15:45:10 +02:00
case STATIC_RECORD :
if ( my_b_write ( & info - > rec_cache , sort_param - > record ,
share - > base . pack_reclength ) )
{
_ma_check_print_error ( param , " %d when writing to datafile " , my_errno ) ;
DBUG_RETURN ( 1 ) ;
}
sort_param - > filepos + = share - > base . pack_reclength ;
info - > s - > state . split + + ;
break ;
case DYNAMIC_RECORD :
if ( ! info - > blobs )
from = sort_param - > rec_buff ;
else
{
/* must be sure that local buffer is big enough */
reclength = info - > s - > base . pack_reclength +
_ma_calc_total_blob_length ( info , sort_param - > record ) +
ALIGN_SIZE ( MARIA_MAX_DYN_BLOCK_HEADER ) + MARIA_SPLIT_LENGTH +
MARIA_DYN_DELETE_BLOCK_HEADER ;
if ( sort_info - > buff_length < reclength )
{
if ( ! ( sort_info - > buff = my_realloc ( sort_info - > buff , ( uint ) reclength ,
MYF ( MY_FREE_ON_ERROR |
MY_ALLOW_ZERO_PTR ) ) ) )
DBUG_RETURN ( 1 ) ;
sort_info - > buff_length = reclength ;
}
from = sort_info - > buff + ALIGN_SIZE ( MARIA_MAX_DYN_BLOCK_HEADER ) ;
}
2007-01-23 20:13:26 +01:00
/* We can use info->checksum here as only one thread calls this */
2007-07-01 15:20:57 +02:00
info - > cur_row . checksum = ( * info - > s - > calc_check_checksum ) ( info ,
sort_param - >
record ) ;
2006-04-11 15:45:10 +02:00
reclength = _ma_rec_pack ( info , from , sort_param - > record ) ;
flag = 0 ;
do
{
block_length = reclength + 3 + test ( reclength > = ( 65520 - 3 ) ) ;
if ( block_length < share - > base . min_block_length )
block_length = share - > base . min_block_length ;
info - > update | = HA_STATE_WRITE_AT_END ;
block_length = MY_ALIGN ( block_length , MARIA_DYN_ALIGN_SIZE ) ;
if ( block_length > MARIA_MAX_BLOCK_LENGTH )
block_length = MARIA_MAX_BLOCK_LENGTH ;
if ( _ma_write_part_record ( info , 0L , block_length ,
sort_param - > filepos + block_length ,
& from , & reclength , & flag ) )
{
_ma_check_print_error ( param , " %d when writing to datafile " , my_errno ) ;
DBUG_RETURN ( 1 ) ;
}
sort_param - > filepos + = block_length ;
info - > s - > state . split + + ;
} while ( reclength ) ;
break ;
case COMPRESSED_RECORD :
reclength = info - > packed_length ;
length = _ma_save_pack_length ( ( uint ) share - > pack . version , block_buff ,
reclength ) ;
if ( info - > s - > base . blobs )
length + = _ma_save_pack_length ( ( uint ) share - > pack . version ,
block_buff + length , info - > blob_length ) ;
if ( my_b_write ( & info - > rec_cache , block_buff , length ) | |
2007-07-02 19:45:15 +02:00
my_b_write ( & info - > rec_cache , ( uchar * ) sort_param - > rec_buff , reclength ) )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_error ( param , " %d when writing to datafile " , my_errno ) ;
DBUG_RETURN ( 1 ) ;
}
sort_param - > filepos + = reclength + length ;
info - > s - > state . split + + ;
break ;
}
}
if ( sort_param - > master )
{
info - > state - > records + + ;
if ( ( param - > testflag & T_WRITE_LOOP ) & &
( info - > state - > records % WRITE_COUNT ) = = 0 )
{
char llbuff [ 22 ] ;
printf ( " %s \r " , llstr ( info - > state - > records , llbuff ) ) ;
VOID ( fflush ( stdout ) ) ;
}
}
DBUG_RETURN ( 0 ) ;
} /* _ma_sort_write_record */
2007-07-01 15:20:57 +02:00
/* Compare two keys from _ma_create_index_by_sort */
2006-04-11 15:45:10 +02:00
static int sort_key_cmp ( MARIA_SORT_PARAM * sort_param , const void * a ,
const void * b )
{
uint not_used [ 2 ] ;
return ( ha_key_cmp ( sort_param - > seg , * ( ( uchar * * ) a ) , * ( ( uchar * * ) b ) ,
USE_WHOLE_KEY , SEARCH_SAME , not_used ) ) ;
} /* sort_key_cmp */
2007-07-02 19:45:15 +02:00
static int sort_key_write ( MARIA_SORT_PARAM * sort_param , const uchar * a )
2006-04-11 15:45:10 +02:00
{
uint diff_pos [ 2 ] ;
char llbuff [ 22 ] , llbuff2 [ 22 ] ;
MARIA_SORT_INFO * sort_info = sort_param - > sort_info ;
HA_CHECK * param = sort_info - > param ;
int cmp ;
if ( sort_info - > key_block - > inited )
{
2007-01-18 20:38:14 +01:00
cmp = ha_key_cmp ( sort_param - > seg , ( uchar * ) sort_info - > key_block - > lastkey ,
2006-04-11 15:45:10 +02:00
( uchar * ) a , USE_WHOLE_KEY , SEARCH_FIND | SEARCH_UPDATE ,
diff_pos ) ;
if ( param - > stats_method = = MI_STATS_METHOD_NULLS_NOT_EQUAL )
2007-01-18 20:38:14 +01:00
ha_key_cmp ( sort_param - > seg , ( uchar * ) sort_info - > key_block - > lastkey ,
2006-04-11 15:45:10 +02:00
( uchar * ) a , USE_WHOLE_KEY ,
SEARCH_FIND | SEARCH_NULL_ARE_NOT_EQUAL , diff_pos ) ;
else if ( param - > stats_method = = MI_STATS_METHOD_IGNORE_NULLS )
{
diff_pos [ 0 ] = maria_collect_stats_nonulls_next ( sort_param - > seg ,
sort_param - > notnull ,
sort_info - > key_block - > lastkey ,
2007-01-18 20:38:14 +01:00
a ) ;
2006-04-11 15:45:10 +02:00
}
sort_param - > unique [ diff_pos [ 0 ] - 1 ] + + ;
}
else
{
cmp = - 1 ;
if ( param - > stats_method = = MI_STATS_METHOD_IGNORE_NULLS )
maria_collect_stats_nonulls_first ( sort_param - > seg , sort_param - > notnull ,
2007-01-18 20:38:14 +01:00
a ) ;
2006-04-11 15:45:10 +02:00
}
if ( ( sort_param - > keyinfo - > flag & HA_NOSAME ) & & cmp = = 0 )
{
sort_info - > dupp + + ;
2007-01-18 20:38:14 +01:00
sort_info - > info - > cur_row . lastpos = get_record_for_key ( sort_info - > info ,
sort_param - > keyinfo ,
a ) ;
2006-04-11 15:45:10 +02:00
_ma_check_print_warning ( param ,
" Duplicate key for record at %10s against record at %10s " ,
2007-01-18 20:38:14 +01:00
llstr ( sort_info - > info - > cur_row . lastpos , llbuff ) ,
2006-04-11 15:45:10 +02:00
llstr ( get_record_for_key ( sort_info - > info ,
sort_param - > keyinfo ,
sort_info - > key_block - >
lastkey ) ,
llbuff2 ) ) ;
param - > testflag | = T_RETRY_WITHOUT_QUICK ;
if ( sort_info - > param - > testflag & T_VERBOSE )
2007-01-18 20:38:14 +01:00
_ma_print_key ( stdout , sort_param - > seg , a , USE_WHOLE_KEY ) ;
2006-04-11 15:45:10 +02:00
return ( sort_delete_record ( sort_param ) ) ;
}
# ifndef DBUG_OFF
if ( cmp > 0 )
{
_ma_check_print_error ( param ,
" Internal error: Keys are not in order from sort " ) ;
return ( 1 ) ;
}
# endif
2007-01-18 20:38:14 +01:00
return ( sort_insert_key ( sort_param , sort_info - > key_block ,
a , HA_OFFSET_ERROR ) ) ;
2006-04-11 15:45:10 +02:00
} /* sort_key_write */
2007-01-18 20:38:14 +01:00
2006-04-11 15:45:10 +02:00
int _ma_sort_ft_buf_flush ( MARIA_SORT_PARAM * sort_param )
{
MARIA_SORT_INFO * sort_info = sort_param - > sort_info ;
SORT_KEY_BLOCKS * key_block = sort_info - > key_block ;
MARIA_SHARE * share = sort_info - > info - > s ;
uint val_off , val_len ;
int error ;
SORT_FT_BUF * maria_ft_buf = sort_info - > ft_buf ;
2007-07-02 19:45:15 +02:00
uchar * from , * to ;
2006-04-11 15:45:10 +02:00
val_len = share - > ft2_keyinfo . keylength ;
get_key_full_length_rdonly ( val_off , maria_ft_buf - > lastkey ) ;
2007-01-18 20:38:14 +01:00
to = maria_ft_buf - > lastkey + val_off ;
2006-04-11 15:45:10 +02:00
if ( maria_ft_buf - > buf )
{
/* flushing first-level tree */
2007-01-18 20:38:14 +01:00
error = sort_insert_key ( sort_param , key_block , maria_ft_buf - > lastkey ,
HA_OFFSET_ERROR ) ;
2006-04-11 15:45:10 +02:00
for ( from = to + val_len ;
! error & & from < maria_ft_buf - > buf ;
from + = val_len )
{
memcpy ( to , from , val_len ) ;
2007-01-18 20:38:14 +01:00
error = sort_insert_key ( sort_param , key_block , maria_ft_buf - > lastkey ,
HA_OFFSET_ERROR ) ;
2006-04-11 15:45:10 +02:00
}
return error ;
}
/* flushing second-level tree keyblocks */
error = _ma_flush_pending_blocks ( sort_param ) ;
/* updating lastkey with second-level tree info */
ft_intXstore ( maria_ft_buf - > lastkey + val_off , - maria_ft_buf - > count ) ;
_ma_dpointer ( sort_info - > info , maria_ft_buf - > lastkey + val_off + HA_FT_WLEN ,
share - > state . key_root [ sort_param - > key ] ) ;
/* restoring first level tree data in sort_info/sort_param */
sort_info - > key_block = sort_info - > key_block_end - sort_info - > param - > sort_key_blocks ;
sort_param - > keyinfo = share - > keyinfo + sort_param - > key ;
share - > state . key_root [ sort_param - > key ] = HA_OFFSET_ERROR ;
/* writing lastkey in first-level tree */
return error ? error :
sort_insert_key ( sort_param , sort_info - > key_block ,
maria_ft_buf - > lastkey , HA_OFFSET_ERROR ) ;
}
2007-01-18 20:38:14 +01:00
static int sort_maria_ft_key_write ( MARIA_SORT_PARAM * sort_param ,
2007-07-02 19:45:15 +02:00
const uchar * a )
2006-04-11 15:45:10 +02:00
{
uint a_len , val_off , val_len , error ;
MARIA_SORT_INFO * sort_info = sort_param - > sort_info ;
SORT_FT_BUF * ft_buf = sort_info - > ft_buf ;
SORT_KEY_BLOCKS * key_block = sort_info - > key_block ;
val_len = HA_FT_WLEN + sort_info - > info - > s - > base . rec_reflength ;
get_key_full_length_rdonly ( a_len , ( uchar * ) a ) ;
if ( ! ft_buf )
{
/*
use two - level tree only if key_reflength fits in rec_reflength place
and row format is NOT static - for _ma_dpointer not to garble offsets
*/
if ( ( sort_info - > info - > s - > base . key_reflength < =
sort_info - > info - > s - > base . rec_reflength ) & &
( sort_info - > info - > s - > options &
( HA_OPTION_PACK_RECORD | HA_OPTION_COMPRESS_RECORD ) ) )
ft_buf = ( SORT_FT_BUF * ) my_malloc ( sort_param - > keyinfo - > block_length +
sizeof ( SORT_FT_BUF ) , MYF ( MY_WME ) ) ;
if ( ! ft_buf )
{
sort_param - > key_write = sort_key_write ;
return sort_key_write ( sort_param , a ) ;
}
sort_info - > ft_buf = ft_buf ;
goto word_init_ft_buf ; /* no need to duplicate the code */
}
get_key_full_length_rdonly ( val_off , ft_buf - > lastkey ) ;
if ( ha_compare_text ( sort_param - > seg - > charset ,
( ( uchar * ) a ) + 1 , a_len - 1 ,
2007-01-18 20:38:14 +01:00
( uchar * ) ft_buf - > lastkey + 1 , val_off - 1 , 0 , 0 ) = = 0 )
2006-04-11 15:45:10 +02:00
{
2007-07-02 19:45:15 +02:00
uchar * p ;
2006-04-11 15:45:10 +02:00
if ( ! ft_buf - > buf ) /* store in second-level tree */
{
ft_buf - > count + + ;
return sort_insert_key ( sort_param , key_block ,
2007-01-18 20:38:14 +01:00
a + a_len , HA_OFFSET_ERROR ) ;
2006-04-11 15:45:10 +02:00
}
/* storing the key in the buffer. */
memcpy ( ft_buf - > buf , ( char * ) a + a_len , val_len ) ;
ft_buf - > buf + = val_len ;
if ( ft_buf - > buf < ft_buf - > end )
return 0 ;
/* converting to two-level tree */
p = ft_buf - > lastkey + val_off ;
while ( key_block - > inited )
key_block + + ;
sort_info - > key_block = key_block ;
sort_param - > keyinfo = & sort_info - > info - > s - > ft2_keyinfo ;
ft_buf - > count = ( ft_buf - > buf - p ) / val_len ;
/* flushing buffer to second-level tree */
for ( error = 0 ; ! error & & p < ft_buf - > buf ; p + = val_len )
error = sort_insert_key ( sort_param , key_block , p , HA_OFFSET_ERROR ) ;
ft_buf - > buf = 0 ;
return error ;
}
/* flushing buffer */
if ( ( error = _ma_sort_ft_buf_flush ( sort_param ) ) )
return error ;
word_init_ft_buf :
a_len + = val_len ;
memcpy ( ft_buf - > lastkey , a , a_len ) ;
ft_buf - > buf = ft_buf - > lastkey + a_len ;
/*
32 is just a safety margin here
( at least max ( val_len , sizeof ( nod_flag ) ) should be there ) .
May be better performance could be achieved if we ' d put
( sort_info - > keyinfo - > block_length - 32 ) / XXX
instead .
TODO : benchmark the best value for XXX .
*/
ft_buf - > end = ft_buf - > lastkey + ( sort_param - > keyinfo - > block_length - 32 ) ;
return 0 ;
} /* sort_maria_ft_key_write */
/* get pointer to record from a key */
static my_off_t get_record_for_key ( MARIA_HA * info , MARIA_KEYDEF * keyinfo ,
2007-07-02 19:45:15 +02:00
const uchar * key )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
return _ma_dpos ( info , 0 , key + _ma_keylength ( keyinfo , key ) ) ;
2006-04-11 15:45:10 +02:00
} /* get_record_for_key */
/* Insert a key in sort-key-blocks */
static int sort_insert_key ( MARIA_SORT_PARAM * sort_param ,
2007-01-18 20:38:14 +01:00
register SORT_KEY_BLOCKS * key_block ,
2007-07-02 19:45:15 +02:00
const uchar * key ,
2006-04-11 15:45:10 +02:00
my_off_t prev_block )
{
uint a_length , t_length , nod_flag ;
my_off_t filepos , key_file_length ;
2007-07-02 19:45:15 +02:00
uchar * anc_buff , * lastkey ;
2006-04-11 15:45:10 +02:00
MARIA_KEY_PARAM s_temp ;
MARIA_HA * info ;
MARIA_KEYDEF * keyinfo = sort_param - > keyinfo ;
MARIA_SORT_INFO * sort_info = sort_param - > sort_info ;
HA_CHECK * param = sort_info - > param ;
DBUG_ENTER ( " sort_insert_key " ) ;
2007-01-18 20:38:14 +01:00
anc_buff = key_block - > buff ;
2006-04-11 15:45:10 +02:00
info = sort_info - > info ;
lastkey = key_block - > lastkey ;
nod_flag = ( key_block = = sort_info - > key_block ? 0 :
info - > s - > base . key_reflength ) ;
if ( ! key_block - > inited )
{
key_block - > inited = 1 ;
if ( key_block = = sort_info - > key_block_end )
{
_ma_check_print_error ( param , " To many key-block-levels; Try increasing sort_key_blocks " ) ;
DBUG_RETURN ( 1 ) ;
}
a_length = 2 + nod_flag ;
key_block - > end_pos = anc_buff + 2 ;
lastkey = 0 ; /* No previous key in block */
}
else
2007-06-09 13:52:17 +02:00
a_length = maria_data_on_page ( anc_buff ) ;
2006-04-11 15:45:10 +02:00
/* Save pointer to previous block */
if ( nod_flag )
_ma_kpointer ( info , key_block - > end_pos , prev_block ) ;
t_length = ( * keyinfo - > pack_key ) ( keyinfo , nod_flag ,
2007-07-02 19:45:15 +02:00
( uchar * ) 0 , lastkey , lastkey , key ,
2006-04-11 15:45:10 +02:00
& s_temp ) ;
( * keyinfo - > store_key ) ( keyinfo , key_block - > end_pos + nod_flag , & s_temp ) ;
a_length + = t_length ;
maria_putint ( anc_buff , a_length , nod_flag ) ;
key_block - > end_pos + = t_length ;
if ( a_length < = keyinfo - > block_length )
{
2007-01-18 20:38:14 +01:00
VOID ( _ma_move_key ( keyinfo , key_block - > lastkey , key ) ) ;
2006-04-11 15:45:10 +02:00
key_block - > last_length = a_length - t_length ;
DBUG_RETURN ( 0 ) ;
}
/* Fill block with end-zero and write filled block */
maria_putint ( anc_buff , key_block - > last_length , nod_flag ) ;
2007-01-18 20:38:14 +01:00
bzero ( anc_buff + key_block - > last_length ,
2006-04-11 15:45:10 +02:00
keyinfo - > block_length - key_block - > last_length ) ;
key_file_length = info - > state - > key_file_length ;
if ( ( filepos = _ma_new ( info , keyinfo , DFLT_INIT_HITS ) ) = = HA_OFFSET_ERROR )
DBUG_RETURN ( 1 ) ;
/* If we read the page from the key cache, we have to write it back to it */
if ( key_file_length = = info - > state - > key_file_length )
{
if ( _ma_write_keypage ( info , keyinfo , filepos , DFLT_INIT_HITS , anc_buff ) )
DBUG_RETURN ( 1 ) ;
}
2007-04-04 22:37:09 +02:00
else if ( my_pwrite ( info - > s - > kfile . file , anc_buff ,
2006-04-11 15:45:10 +02:00
( uint ) keyinfo - > block_length , filepos , param - > myf_rw ) )
DBUG_RETURN ( 1 ) ;
2007-06-09 13:52:17 +02:00
DBUG_DUMP ( " buff " , anc_buff , maria_data_on_page ( anc_buff ) ) ;
2006-04-11 15:45:10 +02:00
/* Write separator-key to block in next level */
if ( sort_insert_key ( sort_param , key_block + 1 , key_block - > lastkey , filepos ) )
DBUG_RETURN ( 1 ) ;
/* clear old block and write new key in it */
key_block - > inited = 0 ;
DBUG_RETURN ( sort_insert_key ( sort_param , key_block , key , prev_block ) ) ;
} /* sort_insert_key */
/* Delete record when we found a duplicated key */
static int sort_delete_record ( MARIA_SORT_PARAM * sort_param )
{
uint i ;
int old_file , error ;
2007-07-02 19:45:15 +02:00
uchar * key ;
2006-04-11 15:45:10 +02:00
MARIA_SORT_INFO * sort_info = sort_param - > sort_info ;
HA_CHECK * param = sort_info - > param ;
MARIA_HA * info = sort_info - > info ;
DBUG_ENTER ( " sort_delete_record " ) ;
if ( ( param - > testflag & ( T_FORCE_UNIQUENESS | T_QUICK ) ) = = T_QUICK )
{
_ma_check_print_error ( param ,
" Quick-recover aborted; Run recovery without switch -q or with switch -qq " ) ;
DBUG_RETURN ( 1 ) ;
}
if ( info - > s - > options & HA_OPTION_COMPRESS_RECORD )
{
_ma_check_print_error ( param ,
2007-01-18 20:38:14 +01:00
" Recover aborted; Can't run standard recovery on compressed tables with errors in data-file. Use switch 'maria_chk --safe-recover' to fix it \n " , stderr ) ; ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 1 ) ;
}
2007-04-04 22:37:09 +02:00
old_file = info - > dfile . file ;
info - > dfile . file = info - > rec_cache . file ;
2006-04-11 15:45:10 +02:00
if ( sort_info - > current_key )
{
2007-01-18 20:38:14 +01:00
key = info - > lastkey + info - > s - > base . max_key_length ;
if ( ( error = ( * info - > s - > read_record ) ( info , sort_param - > record ,
info - > cur_row . lastpos ) ) & &
2006-04-11 15:45:10 +02:00
error ! = HA_ERR_RECORD_DELETED )
{
_ma_check_print_error ( param , " Can't read record to be removed " ) ;
2007-04-04 22:37:09 +02:00
info - > dfile . file = old_file ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 1 ) ;
}
for ( i = 0 ; i < sort_info - > current_key ; i + + )
{
2007-01-18 20:38:14 +01:00
uint key_length = _ma_make_key ( info , i , key , sort_param - > record ,
info - > cur_row . lastpos ) ;
if ( _ma_ck_delete ( info , i , key , key_length ) )
2006-04-11 15:45:10 +02:00
{
2007-01-18 20:38:14 +01:00
_ma_check_print_error ( param ,
" Can't delete key %d from record to be removed " ,
i + 1 ) ;
2007-04-04 22:37:09 +02:00
info - > dfile . file = old_file ;
2006-04-11 15:45:10 +02:00
DBUG_RETURN ( 1 ) ;
}
}
2006-12-19 19:15:53 +01:00
if ( sort_param - > calc_checksum )
2007-07-01 15:20:57 +02:00
param - > glob_crc - = ( * info - > s - > calc_check_checksum ) ( info ,
sort_param - > record ) ;
2006-04-11 15:45:10 +02:00
}
This patch is a collection of patches from from Sanja, Sergei and Monty.
Added logging and pinning of pages to block format.
Integration of transaction manager, log handler.
Better page cache intergration
Split trnman.h into two files, so that we don't have to include my_atomic.h into C++ programs.
Renaming of structures, more comments, more debugging etc.
Fixed problem with small head block + long varchar.
Added extra argument to delete_record() and update_record() (needed for UNDO logging)
Small changes to interface of pagecache and log handler.
Change initialization of log_record_type_descriptors to not be depending on enum order.
Use array of LEX_STRING's to send data to log handler
Added 'dummy' transaction option to MARIA_INFO so that we can always assume 'trn' exists.
include/lf.h:
Interface fixes
Rename of structures
(Patch from Sergei via Sanja)
include/my_atomic.h:
More comments
include/my_global.h:
Added MY_ERRPTR
include/pagecache.h:
Added undo LSN when unlocking pages
mysql-test/r/maria.result:
Updated results
mysql-test/t/maria.test:
Added autocommit around lock tables
(Patch from Sanja)
mysys/lf_alloc-pin.c:
Post-review fixes, simple optimizations
More comments
Struct slot renames
Check amount of memory on stack
(Patch from Sergei)
mysys/lf_dynarray.c:
More comments
mysys/lf_hash.c:
More comments
After review fixes
(Patch from Sergei)
storage/maria/ha_maria.cc:
Split trnman.h into two files, so that we don't have to include my_atomic.h into the .cc program.
(Temporary fix to avoid bug in gcc)
Move out all deferencing of the transaction structure.
Transaction manager integrated (Patch from Sergei)
storage/maria/ha_maria.h:
Added prototype for start_stmt()
storage/maria/lockman.c:
Function call rename
storage/maria/ma_bitmap.c:
Mark deleted pages free from page cache
storage/maria/ma_blockrec.c:
Offset -> rownr
More debugging
Fixed problem with small head block + long varchar
Added logging of changed pages
Added logging of undo (Including only loggging of changed fields in case of update)
Added pinning/unpinning of all changed pages
More comments
Added free_full_pages() as the same code was used in several places.
fill_rows_parts() renamed as fill_insert_undo_parts()
offset -> rownr
Added some optimization of not transactional tables
_ma_update_block_record() has new parameter, as we need original row to do efficent undo for update
storage/maria/ma_blockrec.h:
Added ROW_EXTENTS_ON_STACK
Changed prototype for update and delete of row
storage/maria/ma_check.c:
Added original row to delete_record() call
storage/maria/ma_control_file.h:
Added ifdefs for C++
storage/maria/ma_delete.c:
Added original row to delete_record() call
(Needed for efficent undo logging)
storage/maria/ma_dynrec.c:
Added extra argument to delete_record() and update_record()
Removed not used variable
storage/maria/ma_init.c:
Initialize log handler
storage/maria/ma_loghandler.c:
Removed not used variable
Change initialization of log_record_type_descriptors to not be depending on enum order
Use array of LEX_STRING's to send data to log handler
storage/maria/ma_loghandler.h:
New defines
Use array of LEX_STRING's to send data to log handler
storage/maria/ma_open.c:
Added 'dummy' transaction option to MARIA_INFO so that we can always assume 'trn' exists.
Store in MARIA_SHARE->page_type if pages will have up to date LSN's
storage/maria/ma_pagecache.c:
Don't decrease number of readers when using pagecache_write()/pagecache_read()
In pagecache_write() decrement request count if page was left pinned
Added pagecache_delete_pages()
Removed some casts
Make trace output consistent with rest of code
Simplify calling of DBUG_ASSERT(0)
Only update LSN if the LSN is bigger than what's already on the page
Added LSN parameter pagecache_unpin_page(), pagecache_unpin(), and pagecache_unlock()
(Part of patch from Sanja)
storage/maria/ma_static.c:
Added 'dummy' transaction option to MARIA_INFO so that we can always assume 'trn' exists.
Added default page cache
storage/maria/ma_statrec.c:
Added extra argument to delete_record() and update_record()
storage/maria/ma_test1.c:
Added option -T for transactions
storage/maria/ma_test2.c:
Added option -T for transactions
storage/maria/ma_test_all.sh:
Test with transactions
storage/maria/ma_update.c:
Changed prototype for update of row
storage/maria/maria_def.h:
Changed prototype for update & delete of row as block records need to access the old row
Store in MARIA_SHARE->page_type if pages will have up to date LSN's
Added MARIA_MAX_TREE_LEVELS to allow us to calculate the number of possible pinned pages we may need.
Removed not used 'empty_bits_buffer'
Added pointer to transaction object
Added array for pinned pages
Added log_row_parts array for logging of field data.
Added MARIA_PINNED_PAGE to store pinned pages
storage/maria/trnman.c:
Added accessor functions to transaction object
Added missing DBUG_RETURN()
More debugging
More comments
Changed // comment of code to #ifdef NOT_USED
Transaction manager integrated.
Post review fixes
Part of patch originally from Sergei
storage/maria/trnman.h:
Split trnman.h into two files, so that we don't have to include my_atomic.h into the .cc program.
(Temporary fix to avoid bug in gcc)
storage/maria/unittest/ma_pagecache_single.c:
Added missing argument
Added SKIP_BIG_TESTS
(Patch from Sanja)
storage/maria/unittest/ma_test_loghandler-t.c:
Test logging with new LEX_STRING parameter
(Patch from Sanja)
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
Test logging with new LEX_STRING parameter
(Patch from Sanja)
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
Test logging with new LEX_STRING parameter
(Patch from Sanja)
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
Test logging with new LEX_STRING parameter
(Patch from Sanja)
storage/maria/unittest/trnman-t.c:
Stack overflow detection
(Patch from Sergei)
unittest/unit.pl:
Command-line options --big and --verbose
(Patch from Sergei)
unittest/mytap/tap.c:
Detect --big
(Patch from Sergei)
unittest/mytap/tap.h:
Skip_big_tests and SKIP_BIG_TESTS
(Patch from Sergei)
storage/maria/trnman_public.h:
New BitKeeper file ``storage/maria/trnman_public.h''
2007-05-29 19:13:56 +02:00
error = ( flush_io_cache ( & info - > rec_cache ) | |
( * info - > s - > delete_record ) ( info , sort_param - > record ) ) ;
2007-04-04 22:37:09 +02:00
info - > dfile . file = old_file ; /* restore actual value */
2006-04-11 15:45:10 +02:00
info - > state - > records - - ;
DBUG_RETURN ( error ) ;
} /* sort_delete_record */
2007-07-01 15:20:57 +02:00
/* Fix all pending blocks and flush everything to disk */
2006-04-11 15:45:10 +02:00
int _ma_flush_pending_blocks ( MARIA_SORT_PARAM * sort_param )
{
uint nod_flag , length ;
my_off_t filepos , key_file_length ;
SORT_KEY_BLOCKS * key_block ;
MARIA_SORT_INFO * sort_info = sort_param - > sort_info ;
myf myf_rw = sort_info - > param - > myf_rw ;
MARIA_HA * info = sort_info - > info ;
MARIA_KEYDEF * keyinfo = sort_param - > keyinfo ;
DBUG_ENTER ( " _ma_flush_pending_blocks " ) ;
filepos = HA_OFFSET_ERROR ; /* if empty file */
nod_flag = 0 ;
for ( key_block = sort_info - > key_block ; key_block - > inited ; key_block + + )
{
key_block - > inited = 0 ;
2007-06-09 13:52:17 +02:00
length = maria_data_on_page ( key_block - > buff ) ;
2006-04-11 15:45:10 +02:00
if ( nod_flag )
_ma_kpointer ( info , key_block - > end_pos , filepos ) ;
key_file_length = info - > state - > key_file_length ;
2007-01-18 20:38:14 +01:00
bzero ( key_block - > buff + length , keyinfo - > block_length - length ) ;
2006-04-11 15:45:10 +02:00
if ( ( filepos = _ma_new ( info , keyinfo , DFLT_INIT_HITS ) ) = = HA_OFFSET_ERROR )
DBUG_RETURN ( 1 ) ;
/* If we read the page from the key cache, we have to write it back */
if ( key_file_length = = info - > state - > key_file_length )
{
if ( _ma_write_keypage ( info , keyinfo , filepos ,
DFLT_INIT_HITS , key_block - > buff ) )
DBUG_RETURN ( 1 ) ;
}
2007-04-04 22:37:09 +02:00
else if ( my_pwrite ( info - > s - > kfile . file , key_block - > buff ,
2006-04-11 15:45:10 +02:00
( uint ) keyinfo - > block_length , filepos , myf_rw ) )
DBUG_RETURN ( 1 ) ;
2007-01-18 20:38:14 +01:00
DBUG_DUMP ( " buff " , key_block - > buff , length ) ;
2006-04-11 15:45:10 +02:00
nod_flag = 1 ;
}
info - > s - > state . key_root [ sort_param - > key ] = filepos ; /* Last is root for tree */
DBUG_RETURN ( 0 ) ;
} /* _ma_flush_pending_blocks */
/* alloc space and pointers for key_blocks */
static SORT_KEY_BLOCKS * alloc_key_blocks ( HA_CHECK * param , uint blocks ,
uint buffer_length )
{
reg1 uint i ;
SORT_KEY_BLOCKS * block ;
DBUG_ENTER ( " alloc_key_blocks " ) ;
2007-01-18 20:38:14 +01:00
if ( ! ( block = ( SORT_KEY_BLOCKS * ) my_malloc ( ( sizeof ( SORT_KEY_BLOCKS ) +
buffer_length + IO_SIZE ) * blocks ,
MYF ( 0 ) ) ) )
2006-04-11 15:45:10 +02:00
{
_ma_check_print_error ( param , " Not enough memory for sort-key-blocks " ) ;
return ( 0 ) ;
}
for ( i = 0 ; i < blocks ; i + + )
{
block [ i ] . inited = 0 ;
2007-07-02 19:45:15 +02:00
block [ i ] . buff = ( uchar * ) ( block + blocks ) + ( buffer_length + IO_SIZE ) * i ;
2006-04-11 15:45:10 +02:00
}
DBUG_RETURN ( block ) ;
} /* alloc_key_blocks */
/* Check if file is almost full */
int maria_test_if_almost_full ( MARIA_HA * info )
{
if ( info - > s - > options & HA_OPTION_COMPRESS_RECORD )
return 0 ;
2007-07-27 12:06:39 +02:00
return my_seek ( info - > s - > kfile . file , 0L , MY_SEEK_END ,
MYF ( MY_THREADSAFE ) ) / 10 * 9 >
( my_off_t ) info - > s - > base . max_key_file_length | |
my_seek ( info - > dfile . file , 0L , MY_SEEK_END , MYF ( 0 ) ) / 10 * 9 >
( my_off_t ) info - > s - > base . max_data_file_length ;
2006-04-11 15:45:10 +02:00
}
/* Recreate table with bigger more alloced record-data */
int maria_recreate_table ( HA_CHECK * param , MARIA_HA * * org_info , char * filename )
{
int error ;
MARIA_HA info ;
MARIA_SHARE share ;
MARIA_KEYDEF * keyinfo , * key , * key_end ;
HA_KEYSEG * keysegs , * keyseg ;
2007-04-19 12:18:56 +02:00
MARIA_COLUMNDEF * columndef , * column , * end ;
2006-04-11 15:45:10 +02:00
MARIA_UNIQUEDEF * uniquedef , * u_ptr , * u_end ;
MARIA_STATUS_INFO status_info ;
uint unpack , key_parts ;
ha_rows max_records ;
ulonglong file_length , tmp_length ;
MARIA_CREATE_INFO create_info ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
DBUG_ENTER ( " maria_recreate_table " ) ;
2006-04-11 15:45:10 +02:00
error = 1 ; /* Default error */
info = * * org_info ;
status_info = ( * org_info ) - > state [ 0 ] ;
info . state = & status_info ;
share = * ( * org_info ) - > s ;
unpack = ( share . options & HA_OPTION_COMPRESS_RECORD ) & &
( param - > testflag & T_UNPACK ) ;
2007-01-18 20:38:14 +01:00
if ( ! ( keyinfo = ( MARIA_KEYDEF * ) my_alloca ( sizeof ( MARIA_KEYDEF ) *
share . base . keys ) ) )
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
DBUG_RETURN ( 0 ) ;
2007-07-02 19:45:15 +02:00
memcpy ( ( uchar * ) keyinfo , ( uchar * ) share . keyinfo ,
2006-04-11 15:45:10 +02:00
( size_t ) ( sizeof ( MARIA_KEYDEF ) * share . base . keys ) ) ;
key_parts = share . base . all_key_parts ;
if ( ! ( keysegs = ( HA_KEYSEG * ) my_alloca ( sizeof ( HA_KEYSEG ) *
( key_parts + share . base . keys ) ) ) )
{
2007-07-02 19:45:15 +02:00
my_afree ( ( uchar * ) keyinfo ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
DBUG_RETURN ( 1 ) ;
2006-04-11 15:45:10 +02:00
}
2007-04-19 12:18:56 +02:00
if ( ! ( columndef = ( MARIA_COLUMNDEF * )
2006-04-11 15:45:10 +02:00
my_alloca ( sizeof ( MARIA_COLUMNDEF ) * ( share . base . fields + 1 ) ) ) )
{
2007-07-02 19:45:15 +02:00
my_afree ( ( uchar * ) keyinfo ) ;
my_afree ( ( uchar * ) keysegs ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
DBUG_RETURN ( 1 ) ;
2006-04-11 15:45:10 +02:00
}
if ( ! ( uniquedef = ( MARIA_UNIQUEDEF * )
my_alloca ( sizeof ( MARIA_UNIQUEDEF ) * ( share . state . header . uniques + 1 ) ) ) )
{
2007-07-02 19:45:15 +02:00
my_afree ( ( uchar * ) columndef ) ;
my_afree ( ( uchar * ) keyinfo ) ;
my_afree ( ( uchar * ) keysegs ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
DBUG_RETURN ( 1 ) ;
2006-04-11 15:45:10 +02:00
}
/* Copy the column definitions */
2007-07-02 19:45:15 +02:00
memcpy ( ( uchar * ) columndef , ( uchar * ) share . columndef ,
2006-04-11 15:45:10 +02:00
( size_t ) ( sizeof ( MARIA_COLUMNDEF ) * ( share . base . fields + 1 ) ) ) ;
2007-04-19 12:18:56 +02:00
for ( column = columndef , end = columndef + share . base . fields ;
column ! = end ;
column + + )
2006-04-11 15:45:10 +02:00
{
if ( unpack & & ! ( share . options & HA_OPTION_PACK_RECORD ) & &
2007-04-19 12:18:56 +02:00
column - > type ! = FIELD_BLOB & &
column - > type ! = FIELD_VARCHAR & &
column - > type ! = FIELD_CHECK )
column - > type = ( int ) FIELD_NORMAL ;
2006-04-11 15:45:10 +02:00
}
/* Change the new key to point at the saved key segments */
2007-07-02 19:45:15 +02:00
memcpy ( ( uchar * ) keysegs , ( uchar * ) share . keyparts ,
2006-04-11 15:45:10 +02:00
( size_t ) ( sizeof ( HA_KEYSEG ) * ( key_parts + share . base . keys +
share . state . header . uniques ) ) ) ;
keyseg = keysegs ;
for ( key = keyinfo , key_end = keyinfo + share . base . keys ; key ! = key_end ; key + + )
{
key - > seg = keyseg ;
for ( ; keyseg - > type ; keyseg + + )
{
if ( param - > language )
keyseg - > language = param - > language ; /* change language */
}
keyseg + + ; /* Skip end pointer */
}
2007-01-18 20:38:14 +01:00
/*
Copy the unique definitions and change them to point at the new key
segments
*/
2007-07-02 19:45:15 +02:00
memcpy ( ( uchar * ) uniquedef , ( uchar * ) share . uniqueinfo ,
2006-04-11 15:45:10 +02:00
( size_t ) ( sizeof ( MARIA_UNIQUEDEF ) * ( share . state . header . uniques ) ) ) ;
for ( u_ptr = uniquedef , u_end = uniquedef + share . state . header . uniques ;
u_ptr ! = u_end ; u_ptr + + )
{
u_ptr - > seg = keyseg ;
keyseg + = u_ptr - > keysegs + 1 ;
}
if ( share . options & HA_OPTION_COMPRESS_RECORD )
share . base . records = max_records = info . state - > records ;
else if ( share . base . min_pack_length )
2007-04-04 22:37:09 +02:00
max_records = ( ha_rows ) ( my_seek ( info . dfile . file , 0L , MY_SEEK_END ,
MYF ( 0 ) ) /
2006-04-11 15:45:10 +02:00
( ulong ) share . base . min_pack_length ) ;
else
max_records = 0 ;
2007-01-18 20:38:14 +01:00
unpack = ( share . data_file_type = = COMPRESSED_RECORD ) & &
2006-04-11 15:45:10 +02:00
( param - > testflag & T_UNPACK ) ;
share . options & = ~ HA_OPTION_TEMP_COMPRESS_RECORD ;
2007-04-04 22:37:09 +02:00
file_length = ( ulonglong ) my_seek ( info . dfile . file , 0L , MY_SEEK_END , MYF ( 0 ) ) ;
2006-04-11 15:45:10 +02:00
tmp_length = file_length + file_length / 10 ;
set_if_bigger ( file_length , param - > max_data_file_length ) ;
set_if_bigger ( file_length , tmp_length ) ;
set_if_bigger ( file_length , ( ulonglong ) share . base . max_data_file_length ) ;
VOID ( maria_close ( * org_info ) ) ;
bzero ( ( char * ) & create_info , sizeof ( create_info ) ) ;
create_info . max_rows = max ( max_records , share . base . records ) ;
create_info . reloc_rows = share . base . reloc ;
create_info . old_options = ( share . options |
( unpack ? HA_OPTION_TEMP_COMPRESS_RECORD : 0 ) ) ;
create_info . data_file_length = file_length ;
create_info . auto_increment = share . state . auto_increment ;
create_info . language = ( param - > language ? param - > language :
share . state . header . language ) ;
create_info . key_file_length = status_info . key_file_length ;
2007-01-18 20:38:14 +01:00
create_info . org_data_file_type = ( ( enum data_file_type )
share . state . header . org_data_file_type ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
/*
Allow for creating an auto_increment key . This has an effect only if
an auto_increment key exists in the original table .
*/
create_info . with_auto_increment = TRUE ;
2007-01-18 20:38:14 +01:00
create_info . null_bytes = share . base . null_bytes ;
/*
We don ' t have to handle symlinks here because we are using
HA_DONT_TOUCH_DATA
*/
if ( maria_create ( filename , share . data_file_type ,
share . base . keys - share . state . header . uniques ,
2007-04-19 12:18:56 +02:00
keyinfo , share . base . fields , columndef ,
2007-01-18 20:38:14 +01:00
share . state . header . uniques , uniquedef ,
& create_info ,
HA_DONT_TOUCH_DATA ) )
{
_ma_check_print_error ( param ,
" Got error %d when trying to recreate indexfile " ,
my_errno ) ;
2006-04-11 15:45:10 +02:00
goto end ;
}
* org_info = maria_open ( filename , O_RDWR ,
( param - > testflag & T_WAIT_FOREVER ) ? HA_OPEN_WAIT_IF_LOCKED :
( param - > testflag & T_DESCRIPT ) ? HA_OPEN_IGNORE_IF_LOCKED :
HA_OPEN_ABORT_IF_LOCKED ) ;
if ( ! * org_info )
{
2007-01-18 20:38:14 +01:00
_ma_check_print_error ( param ,
" Got error %d when trying to open re-created indexfile " ,
my_errno ) ;
2006-04-11 15:45:10 +02:00
goto end ;
}
/* We are modifing */
( * org_info ) - > s - > options & = ~ HA_OPTION_READ_ONLY_DATA ;
VOID ( _ma_readinfo ( * org_info , F_WRLCK , 0 ) ) ;
( * org_info ) - > state - > records = info . state - > records ;
if ( share . state . create_time )
( * org_info ) - > s - > state . create_time = share . state . create_time ;
( * org_info ) - > s - > state . unique = ( * org_info ) - > this_unique =
share . state . unique ;
( * org_info ) - > state - > checksum = info . state - > checksum ;
( * org_info ) - > state - > del = info . state - > del ;
( * org_info ) - > s - > state . dellink = share . state . dellink ;
( * org_info ) - > state - > empty = info . state - > empty ;
( * org_info ) - > state - > data_file_length = info . state - > data_file_length ;
if ( maria_update_state_info ( param , * org_info , UPDATE_TIME | UPDATE_STAT |
UPDATE_OPEN_COUNT ) )
goto end ;
error = 0 ;
end :
2007-07-02 19:45:15 +02:00
my_afree ( ( uchar * ) uniquedef ) ;
my_afree ( ( uchar * ) keyinfo ) ;
my_afree ( ( uchar * ) columndef ) ;
my_afree ( ( uchar * ) keysegs ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
DBUG_RETURN ( error ) ;
2006-04-11 15:45:10 +02:00
}
/* write suffix to data file if neaded */
int maria_write_data_suffix ( MARIA_SORT_INFO * sort_info , my_bool fix_datafile )
{
2007-07-01 15:20:57 +02:00
MARIA_HA * info = sort_info - > new_info ;
2006-04-11 15:45:10 +02:00
2007-07-01 15:20:57 +02:00
if ( info - > s - > data_file_type = = COMPRESSED_RECORD & & fix_datafile )
2006-04-11 15:45:10 +02:00
{
char buff [ MEMMAP_EXTRA_MARGIN ] ;
bzero ( buff , sizeof ( buff ) ) ;
if ( my_b_write ( & info - > rec_cache , buff , sizeof ( buff ) ) )
{
_ma_check_print_error ( sort_info - > param ,
" %d when writing to datafile " , my_errno ) ;
return 1 ;
}
sort_info - > param - > read_cache . end_of_file + = sizeof ( buff ) ;
}
return 0 ;
}
2007-01-18 20:38:14 +01:00
/* Update state and maria_chk time of indexfile */
2006-04-11 15:45:10 +02:00
int maria_update_state_info ( HA_CHECK * param , MARIA_HA * info , uint update )
{
MARIA_SHARE * share = info - > s ;
if ( update & UPDATE_OPEN_COUNT )
{
share - > state . open_count = 0 ;
share - > global_changed = 0 ;
}
if ( update & UPDATE_STAT )
{
uint i , key_parts = mi_uint2korr ( share - > state . header . key_parts ) ;
share - > state . rec_per_key_rows = info - > state - > records ;
share - > state . changed & = ~ STATE_NOT_ANALYZED ;
if ( info - > state - > records )
{
for ( i = 0 ; i < key_parts ; i + + )
{
if ( ! ( share - > state . rec_per_key_part [ i ] = param - > rec_per_key_part [ i ] ) )
share - > state . changed | = STATE_NOT_ANALYZED ;
}
}
}
if ( update & ( UPDATE_STAT | UPDATE_SORT | UPDATE_TIME | UPDATE_AUTO_INC ) )
{
if ( update & UPDATE_TIME )
{
share - > state . check_time = ( long ) time ( ( time_t * ) 0 ) ;
if ( ! share - > state . create_time )
share - > state . create_time = share - > state . check_time ;
}
/*
When tables are locked we haven ' t synched the share state and the
real state for a while so we better do it here before synching
the share state to disk . Only when table is write locked is it
necessary to perform this synch .
*/
if ( info - > lock_type = = F_WRLCK )
share - > state . state = * info - > state ;
2007-04-04 22:37:09 +02:00
if ( _ma_state_info_write ( share - > kfile . file , & share - > state , 1 + 2 ) )
2006-04-11 15:45:10 +02:00
goto err ;
share - > changed = 0 ;
}
{ /* Force update of status */
int error ;
uint r_locks = share - > r_locks , w_locks = share - > w_locks ;
share - > r_locks = share - > w_locks = share - > tot_locks = 0 ;
error = _ma_writeinfo ( info , WRITEINFO_NO_UNLOCK ) ;
share - > r_locks = r_locks ;
share - > w_locks = w_locks ;
share - > tot_locks = r_locks + w_locks ;
if ( ! error )
return 0 ;
}
err :
_ma_check_print_error ( param , " %d when updating keyfile " , my_errno ) ;
return 1 ;
}
/*
Update auto increment value for a table
When setting the ' repair_only ' flag we only want to change the
old auto_increment value if its wrong ( smaller than some given key ) .
The reason is that we shouldn ' t change the auto_increment value
for a table without good reason when only doing a repair ; If the
user have inserted and deleted rows , the auto_increment value
may be bigger than the biggest current row and this is ok .
If repair_only is not set , we will update the flag to the value in
param - > auto_increment is bigger than the biggest key .
*/
void _ma_update_auto_increment_key ( HA_CHECK * param , MARIA_HA * info ,
my_bool repair_only )
{
2007-07-02 19:45:15 +02:00
uchar * record ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
DBUG_ENTER ( " update_auto_increment_key " ) ;
2006-04-11 15:45:10 +02:00
if ( ! info - > s - > base . auto_key | |
! maria_is_key_active ( info - > s - > state . key_map , info - > s - > base . auto_key - 1 ) )
{
if ( ! ( param - > testflag & T_VERY_SILENT ) )
_ma_check_print_info ( param ,
" Table: %s doesn't have an auto increment key \n " ,
param - > isam_file_name ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
DBUG_VOID_RETURN ;
2006-04-11 15:45:10 +02:00
}
if ( ! ( param - > testflag & T_SILENT ) & &
! ( param - > testflag & T_REP ) )
printf ( " Updating MARIA file: %s \n " , param - > isam_file_name ) ;
/*
We have to use an allocated buffer instead of info - > rec_buff as
_ma_put_key_in_record ( ) may use info - > rec_buff
*/
2007-07-02 19:45:15 +02:00
if ( ! ( record = ( uchar * ) my_malloc ( ( uint ) info - > s - > base . pack_reclength ,
2006-04-11 15:45:10 +02:00
MYF ( 0 ) ) ) )
{
_ma_check_print_error ( param , " Not enough memory for extra record " ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
DBUG_VOID_RETURN ;
2006-04-11 15:45:10 +02:00
}
maria_extra ( info , HA_EXTRA_KEYREAD , 0 ) ;
if ( maria_rlast ( info , record , info - > s - > base . auto_key - 1 ) )
{
if ( my_errno ! = HA_ERR_END_OF_FILE )
{
maria_extra ( info , HA_EXTRA_NO_KEYREAD , 0 ) ;
my_free ( ( char * ) record , MYF ( 0 ) ) ;
_ma_check_print_error ( param , " %d when reading last record " , my_errno ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
DBUG_VOID_RETURN ;
2006-04-11 15:45:10 +02:00
}
if ( ! repair_only )
info - > s - > state . auto_increment = param - > auto_increment_value ;
}
else
{
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
ulonglong auto_increment = ma_retrieve_auto_increment ( info , record ) ;
2006-04-11 15:45:10 +02:00
set_if_bigger ( info - > s - > state . auto_increment , auto_increment ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
if ( ! repair_only )
set_if_bigger ( info - > s - > state . auto_increment , param - > auto_increment_value ) ;
2006-04-11 15:45:10 +02:00
}
maria_extra ( info , HA_EXTRA_NO_KEYREAD , 0 ) ;
my_free ( ( char * ) record , MYF ( 0 ) ) ;
maria_update_state_info ( param , info , UPDATE_AUTO_INC ) ;
Completion of merge of mysql-5.1 into mysql-maria.
Manually imported changes done to MyISAM (include/myisam.h,
storage/myisam/*, sql/ha_myisam.*, mysql-test/t/myisam.test,
mysql-test/t/ps_2myisam.test) the last
months into Maria (tedious, should do it more frequently in the
future), including those not done at the previous 5.1->Maria merge
(please in the future don't forget to apply MyISAM changes to Maria
when you merge 5.1 into Maria).
Note: I didn't try to import anything which could be MyISAM-related
in other tests of mysql-test (I didn't want to dig in all csets),
but as QA is working to make most tests re-usable for other engines
(Falcon), it is likely that we'll benefit from this and just have
to set engine=Maria somewhere to run those tests on Maria.
func_group and partition tests fail but they already do in main 5.1
on my machine. No Valgrind error in t/*maria*.test.
Monty: please see the commit comment of maria.result and check.
BitKeeper/deleted/.del-ha_maria.m4:
Delete: config/ac-macros/ha_maria.m4
configure.in:
fix for the new way of enabling engines
include/maria.h:
importing changes done to MyISAM the last months into Maria
include/my_handler.h:
importing changes done to MyISAM the last months into Maria
include/myisam.h:
importing changes done to MyISAM the last months into Maria
mysql-test/r/maria.result:
identical to myisam.result, except the engine name in some places
AND in the line testing key_block_size=1000000000000000000:
Maria gives a key block size of 8192 while MyISAM gives 4096;
is it explainable by the difference between MARIA_KEY_BLOCK_LENGTH
and the same constant in MyISAM? Monty?
mysql-test/r/ps_maria.result:
identical to ps_2myisam.result (except the engine name in some places)
mysql-test/t/maria.test:
instead of engine=maria everywhere, I use @@storage_engine (reduces
the diff with myisam.test).
importing changes done to MyISAM the last months into Maria
mysys/my_handler.c:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.cc:
importing changes done to MyISAM the last months into Maria
sql/ha_maria.h:
importing changes done to MyISAM the last months into Maria
sql/mysqld.cc:
unneeded
storage/maria/Makefile.am:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_check.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_create.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_delete_table.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_dynrec.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_extra.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_boolean_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_eval.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_nlq_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_parser.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ft_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_ftdefs.h:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_key.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_open.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_page.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rkey.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rsamepos.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_index.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_rt_mbr.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_search.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_sort.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test1.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test2.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_test3.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_update.c:
importing changes done to MyISAM the last months into Maria
storage/maria/ma_write.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_chk.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_def.h:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_ftdump.c:
importing changes done to MyISAM the last months into Maria
storage/maria/maria_pack.c:
importing changes done to MyISAM the last months into Maria
2006-08-10 16:36:54 +02:00
DBUG_VOID_RETURN ;
2006-04-11 15:45:10 +02:00
}
/*
Update statistics for each part of an index
SYNOPSIS
maria_update_key_parts ( )
keyinfo IN Index information ( only key - > keysegs used )
rec_per_key_part OUT Store statistics here
unique IN Array of ( # distinct tuples )
notnull_tuples IN Array of ( # tuples ) , or NULL
records Number of records in the table
DESCRIPTION
This function is called produce index statistics values from unique and
notnull_tuples arrays after these arrays were produced with sequential
index scan ( the scan is done in two places : chk_index ( ) and
sort_key_write ( ) ) .
This function handles all 3 index statistics collection methods .
Unique is an array :
unique [ 0 ] = ( # different values of { keypart1 } ) - 1
unique [ 1 ] = ( # different values of { keypart1 , keypart2 } tuple ) - unique [ 0 ] - 1
. . .
For MI_STATS_METHOD_IGNORE_NULLS method , notnull_tuples is an array too :
notnull_tuples [ 0 ] = ( # of { keypart1 } tuples such that keypart1 is not NULL )
notnull_tuples [ 1 ] = ( # of { keypart1 , keypart2 } tuples such that all
keypart { i } are not NULL )
. . .
For all other statistics collection methods notnull_tuples = = NULL .
Output is an array :
rec_per_key_part [ k ] =
= E ( # records in the table such that keypart_1 = c_1 AND . . . AND
keypart_k = c_k for arbitrary constants c_1 . . . c_k )
= { assuming that values have uniform distribution and index contains all
tuples from the domain ( or that { c_1 , . . . , c_k } tuple is choosen from
index tuples }
= # tuples - in - the - index / # distinct - tuples - in - the - index .
The # tuples - in - the - index and # distinct - tuples - in - the - index have different
meaning depending on which statistics collection method is used :
MI_STATS_METHOD_ * how are nulls compared ? which tuples are counted ?
NULLS_EQUAL NULL = = NULL all tuples in table
NULLS_NOT_EQUAL NULL ! = NULL all tuples in table
IGNORE_NULLS n / a tuples that don ' t have NULLs
*/
void maria_update_key_parts ( MARIA_KEYDEF * keyinfo , ulong * rec_per_key_part ,
ulonglong * unique , ulonglong * notnull ,
ulonglong records )
{
ulonglong count = 0 , tmp , unique_tuples ;
ulonglong tuples = records ;
uint parts ;
for ( parts = 0 ; parts < keyinfo - > keysegs ; parts + + )
{
count + = unique [ parts ] ;
unique_tuples = count + 1 ;
if ( notnull )
{
tuples = notnull [ parts ] ;
/*
# (unique_tuples not counting tuples with NULLs) =
# (unique_tuples counting tuples with NULLs as different) -
# (tuples with NULLs)
*/
unique_tuples - = ( records - notnull [ parts ] ) ;
}
if ( unique_tuples = = 0 )
tmp = 1 ;
else if ( count = = 0 )
tmp = tuples ; /* 1 unique tuple */
else
tmp = ( tuples + unique_tuples / 2 ) / unique_tuples ;
/*
for some weird keys ( e . g . FULLTEXT ) tmp can be < 1 here .
let ' s ensure it is not
*/
set_if_bigger ( tmp , 1 ) ;
if ( tmp > = ( ulonglong ) ~ ( ulong ) 0 )
tmp = ( ulonglong ) ~ ( ulong ) 0 ;
* rec_per_key_part = ( ulong ) tmp ;
rec_per_key_part + + ;
}
}
2007-07-02 19:45:15 +02:00
static ha_checksum maria_byte_checksum ( const uchar * buf , uint length )
2006-04-11 15:45:10 +02:00
{
ha_checksum crc ;
2007-07-02 19:45:15 +02:00
const uchar * end = buf + length ;
2006-04-11 15:45:10 +02:00
for ( crc = 0 ; buf ! = end ; buf + + )
crc = ( ( crc < < 1 ) + * ( ( uchar * ) buf ) ) +
test ( crc & ( ( ( ha_checksum ) 1 ) < < ( 8 * sizeof ( ha_checksum ) - 1 ) ) ) ;
return crc ;
}
static my_bool maria_too_big_key_for_sort ( MARIA_KEYDEF * key , ha_rows rows )
{
uint key_maxlength = key - > maxlength ;
if ( key - > flag & HA_FULLTEXT )
{
uint ft_max_word_len_for_sort = FT_MAX_WORD_LEN_FOR_SORT *
key - > seg - > charset - > mbmaxlen ;
key_maxlength + = ft_max_word_len_for_sort - HA_FT_MAXBYTELEN ;
}
return ( key - > flag & HA_SPATIAL ) | |
( key - > flag & ( HA_BINARY_PACK_KEY | HA_VAR_LENGTH_KEY | HA_FULLTEXT ) & &
( ( ulonglong ) rows * key_maxlength >
( ulonglong ) maria_max_temp_length ) ) ;
}
/*
Deactivate all not unique index that can be recreated fast
These include packed keys on which sorting will use more temporary
space than the max allowed file length or for which the unpacked keys
will take much more space than packed keys .
Note that ' rows ' may be zero for the case when we don ' t know how many
rows we will put into the file .
*/
void maria_disable_non_unique_index ( MARIA_HA * info , ha_rows rows )
{
MARIA_SHARE * share = info - > s ;
MARIA_KEYDEF * key = share - > keyinfo ;
uint i ;
DBUG_ASSERT ( info - > state - > records = = 0 & &
( ! rows | | rows > = MARIA_MIN_ROWS_TO_DISABLE_INDEXES ) ) ;
for ( i = 0 ; i < share - > base . keys ; i + + , key + + )
{
if ( ! ( key - > flag & ( HA_NOSAME | HA_SPATIAL | HA_AUTO_KEY ) ) & &
! maria_too_big_key_for_sort ( key , rows ) & & info - > s - > base . auto_key ! = i + 1 )
{
maria_clear_key_active ( share - > state . key_map , i ) ;
info - > update | = HA_STATE_CHANGED ;
}
}
}
/*
Return TRUE if we can use repair by sorting
One can set the force argument to force to use sorting
even if the temporary file would be quite big !
*/
my_bool maria_test_if_sort_rep ( MARIA_HA * info , ha_rows rows ,
ulonglong key_map , my_bool force )
{
MARIA_SHARE * share = info - > s ;
MARIA_KEYDEF * key = share - > keyinfo ;
uint i ;
/*
maria_repair_by_sort only works if we have at least one key . If we don ' t
have any keys , we should use the normal repair .
*/
if ( ! maria_is_any_key_active ( key_map ) )
return FALSE ; /* Can't use sort */
2007-07-01 15:20:57 +02:00
/* QQ: Remove this when maria_repair_by_sort() works with block format */
if ( info - > s - > data_file_type = = BLOCK_RECORD )
return FALSE ;
2006-04-11 15:45:10 +02:00
for ( i = 0 ; i < share - > base . keys ; i + + , key + + )
{
if ( ! force & & maria_too_big_key_for_sort ( key , rows ) )
return FALSE ;
}
return TRUE ;
}
static void
set_data_file_type ( MARIA_SORT_INFO * sort_info , MARIA_SHARE * share )
{
if ( ( sort_info - > new_data_file_type = share - > data_file_type ) = =
COMPRESSED_RECORD & & sort_info - > param - > testflag & T_UNPACK )
{
MARIA_SHARE tmp ;
2007-01-18 20:38:14 +01:00
sort_info - > new_data_file_type = share - > state . header . org_data_file_type ;
2006-04-11 15:45:10 +02:00
/* Set delete_function for sort_delete_record() */
2007-07-01 15:20:57 +02:00
tmp = * share ;
tmp . state . header . data_file_type = tmp . state . header . org_data_file_type ;
2006-04-11 15:45:10 +02:00
tmp . options = ~ HA_OPTION_COMPRESS_RECORD ;
_ma_setup_functions ( & tmp ) ;
share - > delete_record = tmp . delete_record ;
}
}
2007-01-18 20:38:14 +01:00
static void restore_data_file_type ( MARIA_SHARE * share )
{
share - > options & = ~ HA_OPTION_COMPRESS_RECORD ;
mi_int2store ( share - > state . header . options , share - > options ) ;
share - > state . header . data_file_type =
share - > state . header . org_data_file_type ;
2007-07-01 15:20:57 +02:00
share - > data_file_type = share - > state . header . data_file_type ;
2007-01-18 20:38:14 +01:00
share - > pack . header_length = 0 ;
}
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
2007-07-01 15:20:57 +02:00
static void change_data_file_descriptor ( MARIA_HA * info , File new_file )
{
Fix for
./mtr --mysqld=--default-storage-engine=maria --mem ps:
I got "can't sync on file UNOPENED" among the messages of REPAIR TABLE;
due to a missing setting of bitmap.file.file to -1.
Maria had two names "Maria" and "MARIA", using one now: "MARIA".
storage/maria/ha_maria.cc:
plug.in uses "MARIA". Some code apparently picks the name from
plug.in (SHOW CREATE TABLE, run ps.test on Maria tables), other from
mysql_declare_plugin (SHOW CREATE TABLE on partitioned tables, run
partition.test with Maria tables), better make names identical.
storage/maria/ma_check.c:
running ps.test on Maria tables I got "can't sync on file UNOPENED"
among the messages of REPAIR TABLE. That was due to maria_repair()
closing the data file, setting info->dfile.file to -1 to prevent
a wrong double close, but forgetting to also set
info->s->bitmap.file.file to -1; it left it unchanged and so,
when close_thread_tables() closed the old version of the repaired
table, _ma_once_end_block_record() tried to fsync the closed
descriptor, resulting in a message.
Basically, when setting info->dfile.file to something it's always
safe and recommended to set bitmap.file.file to the same value
as it's just a copy of the same descriptor see _ma_bitmap_init().
Using change_data_file_descriptor() for that.
Changing that function to use MY_WME as it looks safe.
storage/maria/ma_close.c:
no need to make the index file durable if table is not transactional
2007-08-08 18:59:57 +02:00
my_close ( info - > dfile . file , MYF ( MY_WME ) ) ;
2007-07-01 15:20:57 +02:00
info - > dfile . file = info - > s - > bitmap . file . file = new_file ;
}
/*
Copy all states that has to do with the data file
NOTES
This is done to copy the state from the data file generated from
repair to the original handler
*/
static void copy_data_file_state ( MARIA_STATE_INFO * to ,
MARIA_STATE_INFO * from )
{
to - > state . records = from - > state . records ;
to - > state . del = from - > state . del ;
to - > state . empty = from - > state . empty ;
to - > state . data_file_length = from - > state . data_file_length ;
to - > split = from - > split ;
to - > dellink = from - > dellink ;
to - > first_bitmap_with_space = from - > first_bitmap_with_space ;
}
/*
Read ' safely ' next record while scanning table .
SYNOPSIS
_ma_safe_scan_block_record ( )
info Maria handler
record Store found here
NOTES
- One must have called mi_scan ( ) before this
Differences compared to _ma_scan_block_records ( ) are :
- We read all blocks , not only blocks marked by the bitmap to be safe
- In case of errors , next read will read next record .
- More sanity checks
RETURN
0 ok
HA_ERR_END_OF_FILE End of file
# error number
*/
static int _ma_safe_scan_block_record ( MARIA_SORT_INFO * sort_info ,
2007-07-04 11:39:19 +02:00
MARIA_HA * info , uchar * record )
2007-07-01 15:20:57 +02:00
{
uint record_pos = info - > cur_row . nextpos ;
ulonglong page = sort_info - > page ;
DBUG_ENTER ( " _ma_safe_scan_block_record " ) ;
for ( ; ; )
{
/* Find next row in current page */
if ( likely ( record_pos < info - > scan . number_of_rows ) )
{
uint length , offset ;
2007-07-04 11:39:19 +02:00
uchar * data , * end_of_data ;
2007-07-01 15:20:57 +02:00
char llbuff [ 22 ] ;
while ( ! ( offset = uint2korr ( info - > scan . dir ) ) )
{
info - > scan . dir - = DIR_ENTRY_SIZE ;
record_pos + + ;
if ( info - > scan . dir < info - > scan . dir_end )
{
_ma_check_print_info ( sort_info - > param ,
" Wrong directory on page: %s " ,
llstr ( page , llbuff ) ) ;
goto read_next_page ;
}
}
/* found row */
info - > cur_row . lastpos = info - > scan . row_base_page + record_pos ;
info - > cur_row . nextpos = record_pos + 1 ;
data = info - > scan . page_buff + offset ;
length = uint2korr ( info - > scan . dir + 2 ) ;
end_of_data = data + length ;
info - > scan . dir - = DIR_ENTRY_SIZE ; /* Point to previous row */
if ( end_of_data > info - > scan . dir_end | |
offset < PAGE_HEADER_SIZE | | length < info - > s - > base . min_block_length )
{
_ma_check_print_info ( sort_info - > param ,
" Wrong directory entry %3u at page %s " ,
record_pos , llstr ( page , llbuff ) ) ;
record_pos + + ;
continue ;
}
else
{
DBUG_PRINT ( " info " , ( " rowid: %lu " , ( ulong ) info - > cur_row . lastpos ) ) ;
DBUG_RETURN ( _ma_read_block_record2 ( info , record , data , end_of_data ) ) ;
}
}
read_next_page :
/* Read until we find next head page */
for ( ; ; )
{
uint page_type ;
char llbuff [ 22 ] ;
sort_info - > page + + ; /* In case of errors */
page + + ;
if ( ! ( page % info - > s - > bitmap . pages_covered ) )
page + + ; /* Skip bitmap */
if ( ( page + 1 ) * info - > s - > block_size > sort_info - > filelength )
DBUG_RETURN ( HA_ERR_END_OF_FILE ) ;
if ( ! ( pagecache_read ( info - > s - > pagecache ,
& info - > dfile ,
page , 0 , info - > scan . page_buff ,
PAGECACHE_READ_UNKNOWN_PAGE ,
PAGECACHE_LOCK_LEFT_UNLOCKED , 0 ) ) )
DBUG_RETURN ( my_errno ) ;
page_type = ( info - > scan . page_buff [ PAGE_TYPE_OFFSET ] &
PAGE_TYPE_MASK ) ;
if ( page_type = = HEAD_PAGE )
{
if ( ( info - > scan . number_of_rows =
( uint ) ( uchar ) info - > scan . page_buff [ DIR_COUNT_OFFSET ] ) ! = 0 )
break ;
_ma_check_print_info ( sort_info - > param ,
" Wrong head page at %s " ,
llstr ( page * info - > s - > block_size , llbuff ) ) ;
}
else if ( page_type > = MAX_PAGE_TYPE )
{
_ma_check_print_info ( sort_info - > param ,
" Found wrong page type: %d at %s " ,
page_type , llstr ( page * info - > s - > block_size ,
llbuff ) ) ;
}
}
/* New head page */
info - > scan . dir = ( info - > scan . page_buff + info - > s - > block_size -
PAGE_SUFFIX_SIZE - DIR_ENTRY_SIZE ) ;
info - > scan . dir_end = ( info - > scan . dir -
( info - > scan . number_of_rows - 1 ) *
DIR_ENTRY_SIZE ) ;
info - > scan . row_base_page = ma_recordpos ( page , 0 ) ;
record_pos = 0 ;
}
}
2007-07-01 15:48:57 +02:00
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
/**
@ brief Writes a LOGREC_REPAIR_TABLE record and updates create_rename_lsn
REPAIR / OPTIMIZE have replaced the data / index file with a new file
and so , in this scenario :
@ verbatim
CHECKPOINT - REDO_INSERT - COMMIT - . . . - REPAIR - . . . - crash
@ endverbatim
we do not want Recovery to apply the REDO_INSERT to the table , as it would
then possibly wrongly extend the table . By updating create_rename_lsn at
the end of REPAIR , we know that REDO_INSERT will be skipped .
@ param param description of the REPAIR operation
@ param info table
@ return Operation status
@ retval 0 ok
@ retval 1 error ( disk problem )
*/
Maria:
* Don't modify share->base.born_transactional; now it is a value carved
in stone at creation time. share->now_transactional is what can be
modified: it starts at born_transactional, can become false during
ALTER TABLE (when we want no logging), and restored later.
* Not resetting create_rename_lsn to 0 during delete_all or repair.
* when we temporarily disable transactionality, we also change
the page type to PAGECACHE_PLAIN_PAGE: it bypasses some work in the
page cache (optimization), and avoids assertions related to LSNs.
* Disable INSERT DELAYED for transactional tables, because
durability could not be guaranteed (insertion may even not happen)
mysys/mf_keycache.c:
comment
storage/maria/ha_maria.cc:
* a transactional table cannot do INSERT DELAYED
* ha_maria::save_transactional not needed anymore, as now instead
we don't modify MARIA_SHARE::MARIA_BASE_INFO::born_transactional
(born_transactional plays the role of save_transactional), and modify
MARIA_SHARE::now_transactional.
* REPAIR_TABLE log record is now logged by maria_repair()
* comment why we rely on born_transactional to know if we should
skipping a transaction.
* putting together two if()s which test for F_UNLCK
storage/maria/ha_maria.h:
ha_maria::save_transactional not needed anymore (moved to the C layer)
storage/maria/ma_blockrec.c:
* For the block record's code (writing/updating/deleting records),
all that counts is now_transactional, not born_transactional.
* As we now set the page type to PAGECACHE_PLAIN_PAGE for tables
which have now_transactional==FALSE, pagecache will not expect
a meaningful LSN for them in pagecache_unlock_by_link(), so
we can pass it LSN_IMPOSSIBLE.
storage/maria/ma_check.c:
* writing LOGREC_REPAIR_TABLE moves from ha_maria::repair()
to maria_repair(), sounds cleaner (less functions to export).
* when opening a table during REPAIR, don't use the realpath-ed name,
as this may fail if the table has symlinked files (maria_open()
would try to find the data and index file in the directory
of unique_file_name, it would fail if data and index files are in
different dirs); use the unresolved name, open_file_name, which is
the argument which was passed to the maria_open() which created 'info'.
storage/maria/ma_close.c:
assert that when a statement is done with a table, it cleans up
storage/maria/ma_create.c:
new name
storage/maria/ma_delete_all.c:
* using now_transactional
* no reason to reset create_rename_lsn during delete_all (a bug);
also no reason to do it during repair: it was put there because
a positive create_rename_lsn caused a call to check_and_set_lsn()
which asserted in DBUG_ASSERT(block->type == PAGECACHE_LSN_PAGE);
first solution was to use LSN_IMPOSSIBLE in _ma_unpin_all_pages() if
not transactional; but then in the case of ALTER TABLE, with
transactionality temporarily disabled, it asserted in
DBUG_ASSERT(LSN_VALID(lsn)) in pagecache_fwrite() (PAGECACHE_LSN_PAGE
page with zero LSN - bad). The additional solution is to use
PAGECACHE_PLAIN_PAGE when we disable transactionality temporarily: this
avoids checks on the LSN, and also bypasses (optimization) the "flush
log up to LSN" call when the pagecache flushes our page (in other
words, no WAL needed).
storage/maria/ma_delete_table.c:
use now_transactional
storage/maria/ma_locking.c:
assert that when a statement is done with a table, it cleans up.
storage/maria/ma_loghandler.c:
* now_transactional should be used to test if we want a log record.
* Assertions to make sure dummy_transaction_object is not spoilt
by its many users.
storage/maria/ma_open.c:
base.transactional -> base.born_transactional
storage/maria/ma_pagecache.c:
missing name for page's type. Comment for future.
storage/maria/ma_rename.c:
use now_transactional
storage/maria/maria_chk.c:
use born_transactional
storage/maria/maria_def.h:
MARIA_BASE_INFO::transactional renamed to born_transactional.
MARIA_SHARE::now_transactional introduced.
_ma_repair_write_log_record() is made local to ma_check.c.
Macros to temporarily disable, and re-enable, transactionality for a
table.
storage/maria/maria_read_log.c:
assertions and using the new macros. Adding a forgotten resetting
when we finally close all tables.
2007-07-03 15:20:41 +02:00
static int write_log_record_for_repair ( const HA_CHECK * param , MARIA_HA * info )
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
{
MARIA_SHARE * share = info - > s ;
Maria:
* Don't modify share->base.born_transactional; now it is a value carved
in stone at creation time. share->now_transactional is what can be
modified: it starts at born_transactional, can become false during
ALTER TABLE (when we want no logging), and restored later.
* Not resetting create_rename_lsn to 0 during delete_all or repair.
* when we temporarily disable transactionality, we also change
the page type to PAGECACHE_PLAIN_PAGE: it bypasses some work in the
page cache (optimization), and avoids assertions related to LSNs.
* Disable INSERT DELAYED for transactional tables, because
durability could not be guaranteed (insertion may even not happen)
mysys/mf_keycache.c:
comment
storage/maria/ha_maria.cc:
* a transactional table cannot do INSERT DELAYED
* ha_maria::save_transactional not needed anymore, as now instead
we don't modify MARIA_SHARE::MARIA_BASE_INFO::born_transactional
(born_transactional plays the role of save_transactional), and modify
MARIA_SHARE::now_transactional.
* REPAIR_TABLE log record is now logged by maria_repair()
* comment why we rely on born_transactional to know if we should
skipping a transaction.
* putting together two if()s which test for F_UNLCK
storage/maria/ha_maria.h:
ha_maria::save_transactional not needed anymore (moved to the C layer)
storage/maria/ma_blockrec.c:
* For the block record's code (writing/updating/deleting records),
all that counts is now_transactional, not born_transactional.
* As we now set the page type to PAGECACHE_PLAIN_PAGE for tables
which have now_transactional==FALSE, pagecache will not expect
a meaningful LSN for them in pagecache_unlock_by_link(), so
we can pass it LSN_IMPOSSIBLE.
storage/maria/ma_check.c:
* writing LOGREC_REPAIR_TABLE moves from ha_maria::repair()
to maria_repair(), sounds cleaner (less functions to export).
* when opening a table during REPAIR, don't use the realpath-ed name,
as this may fail if the table has symlinked files (maria_open()
would try to find the data and index file in the directory
of unique_file_name, it would fail if data and index files are in
different dirs); use the unresolved name, open_file_name, which is
the argument which was passed to the maria_open() which created 'info'.
storage/maria/ma_close.c:
assert that when a statement is done with a table, it cleans up
storage/maria/ma_create.c:
new name
storage/maria/ma_delete_all.c:
* using now_transactional
* no reason to reset create_rename_lsn during delete_all (a bug);
also no reason to do it during repair: it was put there because
a positive create_rename_lsn caused a call to check_and_set_lsn()
which asserted in DBUG_ASSERT(block->type == PAGECACHE_LSN_PAGE);
first solution was to use LSN_IMPOSSIBLE in _ma_unpin_all_pages() if
not transactional; but then in the case of ALTER TABLE, with
transactionality temporarily disabled, it asserted in
DBUG_ASSERT(LSN_VALID(lsn)) in pagecache_fwrite() (PAGECACHE_LSN_PAGE
page with zero LSN - bad). The additional solution is to use
PAGECACHE_PLAIN_PAGE when we disable transactionality temporarily: this
avoids checks on the LSN, and also bypasses (optimization) the "flush
log up to LSN" call when the pagecache flushes our page (in other
words, no WAL needed).
storage/maria/ma_delete_table.c:
use now_transactional
storage/maria/ma_locking.c:
assert that when a statement is done with a table, it cleans up.
storage/maria/ma_loghandler.c:
* now_transactional should be used to test if we want a log record.
* Assertions to make sure dummy_transaction_object is not spoilt
by its many users.
storage/maria/ma_open.c:
base.transactional -> base.born_transactional
storage/maria/ma_pagecache.c:
missing name for page's type. Comment for future.
storage/maria/ma_rename.c:
use now_transactional
storage/maria/maria_chk.c:
use born_transactional
storage/maria/maria_def.h:
MARIA_BASE_INFO::transactional renamed to born_transactional.
MARIA_SHARE::now_transactional introduced.
_ma_repair_write_log_record() is made local to ma_check.c.
Macros to temporarily disable, and re-enable, transactionality for a
table.
storage/maria/maria_read_log.c:
assertions and using the new macros. Adding a forgotten resetting
when we finally close all tables.
2007-07-03 15:20:41 +02:00
if ( translog_inited ) /* test it in case this is maria_chk */
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
{
2007-06-28 14:01:57 +02:00
/*
For now this record is only informative . It could serve when applying
logs to a backup , but that needs more thought . Assume table became
corrupted . It is repaired , then some writes happen to it .
Later we restore an old backup , and want to apply this REDO_REPAIR_TABLE
record . For it to give the same result as originally , the table should
be corrupted the same way , so applying previous REDOs should produce the
same corruption ; that ' s really not guaranteed ( different execution paths
in execution of REDOs vs runtime code so not same bugs hit , temporary
hardware issues not repeatable etc ) . Corruption may not be repeatable .
A reasonable solution is to execute the REDO_REPAIR_TABLE record and
check if the checksum of the resulting table matches what it was at the
end of the original repair ( should be stored in log record ) ; or execute
the REDO_REPAIR_TABLE if the checksum of the table - before - repair matches
was it was at the start of the original repair ( should be stored in log
record ) .
*/
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
LEX_STRING log_array [ TRANSLOG_INTERNAL_PARTS + 1 ] ;
uchar log_data [ LSN_STORE_SIZE ] ;
compile_time_assert ( LSN_STORE_SIZE > = ( FILEID_STORE_SIZE + 4 ) ) ;
log_array [ TRANSLOG_INTERNAL_PARTS + 0 ] . str = ( char * ) log_data ;
log_array [ TRANSLOG_INTERNAL_PARTS + 0 ] . length = FILEID_STORE_SIZE + 4 ;
/*
testflag gives an idea of what REPAIR did ( in particular T_QUICK
or not : did it touch the data file or not ? ) .
*/
int4store ( log_data + FILEID_STORE_SIZE , param - > testflag ) ;
if ( unlikely ( translog_write_record ( & share - > state . create_rename_lsn ,
LOGREC_REDO_REPAIR_TABLE ,
2007-08-01 15:52:57 +02:00
& dummy_transaction_object , info ,
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
log_array [ TRANSLOG_INTERNAL_PARTS +
0 ] . length ,
sizeof ( log_array ) / sizeof ( log_array [ 0 ] ) ,
2007-06-28 14:01:57 +02:00
log_array , log_data ) | |
translog_flush ( share - > state . create_rename_lsn ) ) )
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
return 1 ;
/*
But this piece is really needed , to have the new table ' s content durable
and to not apply old REDOs to the new table . The table ' s existence was
made durable earlier ( MY_SYNC_DIR passed to maria_change_to_newfile ( ) ) .
*/
DBUG_ASSERT ( info - > dfile . file > = 0 ) ;
2007-07-01 15:48:57 +02:00
return ( _ma_update_create_rename_lsn_on_disk ( share , FALSE ) | |
- WL#3239 "log CREATE TABLE in Maria"
- WL#3240 "log DROP TABLE in Maria"
- similarly, log RENAME TABLE, REPAIR/OPTIMIZE TABLE, and
DELETE no_WHERE_clause (== the DELETE which just truncates the files)
- create_rename_lsn added to MARIA_SHARE's state
- all these operations (except DROP TABLE) also update the table's
create_rename_lsn, which is needed for the correctness of
Recovery (see function comment of _ma_repair_write_log_record()
in ma_check.c)
- write a COMMIT record when transaction commits.
- don't log REDOs/UNDOs if this is an internal temporary table
like inside ALTER TABLE (I expect this to be a big win). There was
already no logging for user-created "CREATE TEMPORARY" tables.
- don't fsync files/directories if the table is not transactional
- in translog_write_record(), autogenerate a 2-byte-id for the table
and log the "id->name" pair (LOGREC_FILE_ID); log
LOGREC_LONG_TRANSACTION_ID; automatically store
the table's 2-byte-id in any log record.
- preparations for Checkpoint: translog_get_horizon(); pausing Checkpoint
when some dirty pages are unknown; capturing trn->rec_lsn,
trn->first_undo_lsn for Checkpoint and log's low-water-mark computing.
- assertions, comments.
storage/maria/Makefile.am:
more files to build
storage/maria/ha_maria.cc:
- logging a REPAIR log record if REPAIR/OPTIMIZE was successful.
- ha_maria::data_file_type does not have to be set in every info()
call, just do it once in open().
- if caller said that transactionality can be disabled (like if
caller is ALTER TABLE) i.e. thd->transaction.on==FALSE, then we
temporarily disable transactionality of the table in external_lock();
that will ensure that no REDOs/UNDOs are logged for this possibly
massive write operation (they are not needed, as if any write fails,
the table will be dropped). We re-enable in external_lock(F_UNLCK),
which in ALTER TABLE happens before the tmp table replaces the original
one (which is good, as thus the final table will have a REDO RENAME
and a correct create_rename_lsn).
- when we commit we also have to write a log record, so
trnman_commit_trn() calls become ma_commit() calls
- at end of engine's initialization, we are potentially entering a
multi-threaded dangerous world (clients are going to be accepted)
and so some assertions of mutex-owning become enforceable, for that
we set maria_multi_threaded=TRUE (see ma_control_file.c)
storage/maria/ha_maria.h:
new member ha_maria::save_transactional (see also ha_maria.cc)
storage/maria/ma_blockrec.c:
- fixing comments according to discussion with Monty
- if a table is transactional but temporarily non-transactional
(like in ALTER TABLE), we need to give a sensible LSN to the pages
(and, if we give 0, pagecache asserts).
- translog_write_record() now takes care of storing the share's
2-byte-id in the log record
storage/maria/ma_blockrec.h:
fixing comment according to discussion with Monty
storage/maria/ma_check.c:
When REPAIR/OPTIMIZE modify the data/index file, if this is a
transactional table, they must sync it; if they remove files or rename
files, they must sync the directory, so that everything is durable.
This is just applying to REPAIR/OPTIMIZE the logic already implemented
in CREATE/DROP/RENAME a few months ago.
Adding a function to write a LOGREC_REPAIR_TABLE at end of
REPAIR/OPTIMIZE (called only by ha_maria, not by maria_chk), and
to update the table's create_rename_lsn.
storage/maria/ma_close.c:
fix for a future bug
storage/maria/ma_control_file.c:
ensuring that if Maria is running in multi-threaded mode, anybody
wanting to write to the control file and update
last_checkpoint_lsn/last_logno owns the log's lock.
storage/maria/ma_control_file.h:
see ma_control_file.c
storage/maria/ma_create.c:
when creating a table:
- sync it and its directory only if this is a transactional table
and there is a log (no point in syncing in maria_chk)
- decouple the two uses of linkname/linkname_ptr (for index file and
for data file) into more variables, as we need to know all links
until the moment we write the LOGREC_CREATE_TABLE.
- set share.data_file_type early so that _ma_initialize_data_file()
knows it (Monty's bugfix so that a table always has at least a bitmap
page when it is created; so data-file is not 0 bytes anymore).
- log a LOGREC_CREATE_TABLE; it contains the bytes which we have
just written to the index file's header. Update table's
create_rename_lsn.
- syncing of kfile had been bugified in a previous merge, correcting
- syncing of dfile is now needed as it's not empty anymore
- in _ma_initialize_data_file(), use share's block_size and not the
global one. This is a gratuitous change, both variables are equal,
just that I find it more future-proof to use share-bound variable
rather than global one.
storage/maria/ma_delete_all.c:
log a LOGREC_DELETE_ALL record when doing ma_delete_all_rows();
update create_rename_lsn then.
storage/maria/ma_delete_table.c:
- logging LOGREC_DROP_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- we need to sync directories only if the table is transactional
storage/maria/ma_extra.c:
questions
storage/maria/ma_init.c:
when maria_end() is called, engine is not multithreaded
storage/maria/ma_loghandler.c:
- translog_inited has to be visible to ma_create() (see how it is used
in ma_create())
- checkpoint record will be a single record, not three
- no REDO for TRUNCATE (TRUNCATE calls ma_create() internally so will
log a REDO_CREATE)
- adding REDO for DELETE no_WHERE_clause (fast DELETE of all rows by
truncating the files), REPAIR.
- MY_WAIT_IF_FULL to wait&retry if a log write hits a full disk
- in translog_write_record(), if MARIA_SHARE does not yet have a
2-byte-id, generate one for it and log LOGREC_FILE_ID; automatically
store this short id into log records.
- in translog_write_record(), if transaction has not logged its
long trid, log LOGREC_LONG_TRANSACTION_ID.
- For Checkpoint, we need to know the current end-of-log: adding
translog_get_horizon().
- For Control File, adding an assertion that the thread owns the
log's lock (control file is protected by this lock)
storage/maria/ma_loghandler.h:
Changes in log records (see ma_loghandler.c).
new prototypes, new functions.
storage/maria/ma_loghandler_lsn.h:
adding a type LSN_WITH_FLAGS especially for TRN::first_undo_lsn,
where the most significant byte is used for flags.
storage/maria/ma_open.c:
storing the create_rename_lsn in the index file's header (in the
state, precisely) and retrieving it from there.
storage/maria/ma_pagecache.c:
- my set_if_bigger was wrong, correcting it
- if the first_in_switch list is not empty, it means that
changed_blocks misses some dirty pages, so Checkpoint cannot run and
needs to wait. A variable missing_blocks_in_changed_list is added to
tell that (should it be named missing_blocks_in_changed_blocks?)
- pagecache_collect_changed_blocks_with_lsn() now also tells the
minimum rec_lsn (needed for low-water mark computation).
storage/maria/ma_pagecache.h:
see ma_pagecache.c
storage/maria/ma_panic.c:
comment
storage/maria/ma_range.c:
comment
storage/maria/ma_rename.c:
- logging LOGREC_RENAME_TABLE; knowing if this is needed, requires
knowing if the table is transactional, which requires opening the
table.
- update create_rename_lsn
- we need to sync directories only if the table is transactional
storage/maria/ma_static.c:
comment
storage/maria/ma_test_all.sh:
- tip for Valgrind-ing ma_test_all
- do "export maria_path=somepath" before calling ma_test_all,
if you want to run ma_test_all out of storage/maria (useful
to have parallel runs, like one normal and one Valgrind, they
must not use the same tables so need to run in different directories)
storage/maria/maria_def.h:
- state now contains, in memory and on disk, the create_rename_lsn
- share now contains a 2-byte-id
storage/maria/trnman.c:
preparations for Checkpoint: capture trn->rec_lsn, trn->first_undo_lsn;
minimum first_undo_lsn needed to know log's low-water-mark
storage/maria/trnman.h:
using most significant byte of first_undo_lsn to hold miscellaneous
flags, for now TRANSACTION_LOGGED_LONG_ID.
dummy_transaction_object is already declared in ma_static.c.
storage/maria/trnman_public.h:
dummy_transaction_object was declared in all files including
trnman_public.h, while in fact it's a single object.
new prototype
storage/maria/unittest/ma_test_loghandler-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multigroup-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_multithread-t.c:
update for new prototype
storage/maria/unittest/ma_test_loghandler_pagecache-t.c:
update for new prototype
storage/maria/ma_commit.c:
function which wraps:
- writing a LOGREC_COMMIT record (==commit on disk)
- calling trnman_commit_trn() (=commit in memory)
storage/maria/ma_commit.h:
new header file
.tree-is-private:
this file is now needed to keep our tree private (don't push it
to public trees). When 5.1 is merged into mysql-maria, we can abandon
our maria-specific post-commit trigger; .tree_is_private will take
care of keeping commit mails private. Don't push this file to public
trees.
2007-06-22 14:49:37 +02:00
_ma_sync_table_files ( info ) ) ;
}
return 0 ;
}