2004-07-16 00:15:55 +02:00
|
|
|
/* Copyright (C) 2004 MySQL AB
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
2006-12-23 20:17:15 +01:00
|
|
|
the Free Software Foundation; version 2 of the License.
|
2004-07-16 00:15:55 +02:00
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program; if not, write to the Free Software
|
|
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
|
|
*/
|
|
|
|
|
2006-03-10 01:44:08 +01:00
|
|
|
#define MYSQL_LEX 1
|
2004-07-16 00:15:55 +02:00
|
|
|
#include "mysql_priv.h"
|
|
|
|
#include "sql_select.h"
|
|
|
|
#include "parse_file.h"
|
2004-07-16 14:20:51 +02:00
|
|
|
#include "sp.h"
|
2005-03-04 14:35:28 +01:00
|
|
|
#include "sp_head.h"
|
2005-07-06 18:00:17 +02:00
|
|
|
#include "sp_cache.h"
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2004-10-28 18:37:25 +02:00
|
|
|
#define MD5_BUFF_LENGTH 33
|
|
|
|
|
2006-08-17 18:13:45 +02:00
|
|
|
const LEX_STRING view_type= { C_STRING_WITH_LEN("VIEW") };
|
2005-07-31 11:49:55 +02:00
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
static int mysql_register_view(THD *thd, TABLE_LIST *view,
|
|
|
|
enum_view_create_mode mode);
|
|
|
|
|
2004-10-07 11:13:42 +02:00
|
|
|
const char *updatable_views_with_limit_names[]= { "NO", "YES", NullS };
|
|
|
|
TYPELIB updatable_views_with_limit_typelib=
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-10-07 11:13:42 +02:00
|
|
|
array_elements(updatable_views_with_limit_names)-1, "",
|
2004-11-03 11:39:38 +01:00
|
|
|
updatable_views_with_limit_names,
|
|
|
|
0
|
2004-07-16 00:15:55 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
|
2005-06-21 19:30:48 +02:00
|
|
|
/*
|
|
|
|
Make a unique name for an anonymous view column
|
|
|
|
SYNOPSIS
|
|
|
|
target reference to the item for which a new name has to be made
|
|
|
|
item_list list of items within which we should check uniqueness of
|
|
|
|
the created name
|
|
|
|
last_element the last element of the list above
|
|
|
|
|
|
|
|
NOTE
|
|
|
|
Unique names are generated by adding 'My_exp_' to the old name of the
|
|
|
|
column. In case the name that was created this way already exists, we
|
|
|
|
add a numeric postfix to its end (i.e. "1") and increase the number
|
|
|
|
until the name becomes unique. If the generated name is longer than
|
|
|
|
NAME_LEN, it is truncated.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void make_unique_view_field_name(Item *target,
|
|
|
|
List<Item> &item_list,
|
|
|
|
Item *last_element)
|
|
|
|
{
|
|
|
|
char *name= (target->orig_name ?
|
|
|
|
target->orig_name :
|
|
|
|
target->name);
|
2005-07-04 02:42:33 +02:00
|
|
|
uint name_len, attempt;
|
2005-06-21 19:30:48 +02:00
|
|
|
char buff[NAME_LEN+1];
|
2005-07-04 02:42:33 +02:00
|
|
|
List_iterator_fast<Item> itc(item_list);
|
|
|
|
|
|
|
|
for (attempt= 0;; attempt++)
|
2005-06-21 19:30:48 +02:00
|
|
|
{
|
|
|
|
Item *check;
|
|
|
|
bool ok= TRUE;
|
|
|
|
|
|
|
|
if (attempt)
|
|
|
|
name_len= my_snprintf(buff, NAME_LEN, "My_exp_%d_%s", attempt, name);
|
|
|
|
else
|
|
|
|
name_len= my_snprintf(buff, NAME_LEN, "My_exp_%s", name);
|
|
|
|
|
|
|
|
do
|
|
|
|
{
|
|
|
|
check= itc++;
|
|
|
|
if (check != target &&
|
|
|
|
my_strcasecmp(system_charset_info, buff, check->name) == 0)
|
|
|
|
{
|
|
|
|
ok= FALSE;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
} while (check != last_element);
|
|
|
|
if (ok)
|
|
|
|
break;
|
2005-07-04 02:42:33 +02:00
|
|
|
itc.rewind();
|
2005-06-21 19:30:48 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
target->orig_name= target->name;
|
|
|
|
target->set_name(buff, name_len, system_charset_info);
|
|
|
|
}
|
|
|
|
|
2005-08-10 15:45:00 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
Check if items with same names are present in list and possibly
|
|
|
|
generate unique names for them.
|
|
|
|
|
|
|
|
SYNOPSIS
|
|
|
|
item_list list of Items which should be checked for duplicates
|
|
|
|
gen_unique_view_name flag: generate unique name or return with error when
|
|
|
|
duplicate names are found.
|
|
|
|
|
|
|
|
DESCRIPTION
|
|
|
|
This function is used on view creation and preparation of derived tables.
|
|
|
|
It checks item_list for items with duplicate names. If it founds two
|
|
|
|
items with same name and conversion to unique names isn't allowed, or
|
|
|
|
names for both items are set by user - function fails.
|
|
|
|
Otherwise it generates unique name for one item with autogenerated name
|
|
|
|
using make_unique_view_field_name()
|
|
|
|
|
|
|
|
RETURN VALUE
|
|
|
|
FALSE no duplicate names found, or they are converted to unique ones
|
|
|
|
TRUE duplicate names are found and they can't be converted or conversion
|
|
|
|
isn't allowed
|
|
|
|
*/
|
|
|
|
|
|
|
|
bool check_duplicate_names(List<Item> &item_list, bool gen_unique_view_name)
|
|
|
|
{
|
2005-08-18 02:12:42 +02:00
|
|
|
Item *item;
|
|
|
|
List_iterator_fast<Item> it(item_list);
|
|
|
|
List_iterator_fast<Item> itc(item_list);
|
2005-08-10 15:45:00 +02:00
|
|
|
DBUG_ENTER("check_duplicate_names");
|
2005-08-18 02:12:42 +02:00
|
|
|
|
|
|
|
while ((item= it++))
|
2005-08-10 15:45:00 +02:00
|
|
|
{
|
2005-08-18 02:12:42 +02:00
|
|
|
Item *check;
|
|
|
|
/* treat underlying fields like set by user names */
|
|
|
|
if (item->real_item()->type() == Item::FIELD_ITEM)
|
|
|
|
item->is_autogenerated_name= FALSE;
|
|
|
|
itc.rewind();
|
|
|
|
while ((check= itc++) && check != item)
|
2005-08-10 15:45:00 +02:00
|
|
|
{
|
2005-08-18 02:12:42 +02:00
|
|
|
if (my_strcasecmp(system_charset_info, item->name, check->name) == 0)
|
2005-08-10 15:45:00 +02:00
|
|
|
{
|
2005-08-18 02:12:42 +02:00
|
|
|
if (!gen_unique_view_name)
|
|
|
|
goto err;
|
|
|
|
if (item->is_autogenerated_name)
|
|
|
|
make_unique_view_field_name(item, item_list, item);
|
|
|
|
else if (check->is_autogenerated_name)
|
|
|
|
make_unique_view_field_name(check, item_list, item);
|
|
|
|
else
|
|
|
|
goto err;
|
2005-08-10 15:45:00 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
DBUG_RETURN(FALSE);
|
2005-08-18 02:12:42 +02:00
|
|
|
|
|
|
|
err:
|
|
|
|
my_error(ER_DUP_FIELDNAME, MYF(0), item->name);
|
|
|
|
DBUG_RETURN(TRUE);
|
2005-08-10 15:45:00 +02:00
|
|
|
}
|
|
|
|
|
2006-07-31 16:33:37 +02:00
|
|
|
/*
|
|
|
|
Fill defined view parts
|
|
|
|
|
|
|
|
SYNOPSIS
|
|
|
|
fill_defined_view_parts()
|
|
|
|
thd current thread.
|
|
|
|
view view to operate on
|
|
|
|
|
|
|
|
DESCRIPTION
|
|
|
|
This function will initialize the parts of the view
|
|
|
|
definition that are not specified in ALTER VIEW
|
|
|
|
to their values from CREATE VIEW.
|
|
|
|
The view must be opened to get its definition.
|
|
|
|
We use a copy of the view when opening because we want
|
|
|
|
to preserve the original view instance.
|
|
|
|
|
|
|
|
RETURN VALUE
|
|
|
|
TRUE can't open table
|
|
|
|
FALSE success
|
|
|
|
*/
|
|
|
|
static bool
|
|
|
|
fill_defined_view_parts (THD *thd, TABLE_LIST *view)
|
|
|
|
{
|
|
|
|
LEX *lex= thd->lex;
|
|
|
|
bool not_used;
|
|
|
|
TABLE_LIST decoy;
|
|
|
|
|
|
|
|
memcpy (&decoy, view, sizeof (TABLE_LIST));
|
2006-08-08 22:05:42 +02:00
|
|
|
if (!open_table(thd, &decoy, thd->mem_root, ¬_used, OPEN_VIEW_NO_PARSE) &&
|
2006-07-31 16:33:37 +02:00
|
|
|
!decoy.view)
|
|
|
|
{
|
2006-08-06 22:06:03 +02:00
|
|
|
/* It's a table */
|
2006-07-31 16:33:37 +02:00
|
|
|
return TRUE;
|
|
|
|
}
|
2006-08-06 22:06:03 +02:00
|
|
|
|
2006-07-31 16:33:37 +02:00
|
|
|
if (!lex->definer)
|
|
|
|
{
|
|
|
|
view->definer.host= decoy.definer.host;
|
|
|
|
view->definer.user= decoy.definer.user;
|
|
|
|
lex->definer= &view->definer;
|
|
|
|
}
|
|
|
|
if (lex->create_view_algorithm == VIEW_ALGORITHM_UNDEFINED)
|
2006-11-30 02:40:42 +01:00
|
|
|
lex->create_view_algorithm= (uint8) decoy.algorithm;
|
2006-07-31 16:33:37 +02:00
|
|
|
if (lex->create_view_suid == VIEW_SUID_DEFAULT)
|
|
|
|
lex->create_view_suid= decoy.view_suid ?
|
|
|
|
VIEW_SUID_DEFINER : VIEW_SUID_INVOKER;
|
|
|
|
|
|
|
|
return FALSE;
|
|
|
|
}
|
|
|
|
|
2005-08-10 15:45:00 +02:00
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
/*
|
|
|
|
Creating/altering VIEW procedure
|
|
|
|
|
|
|
|
SYNOPSIS
|
|
|
|
mysql_create_view()
|
|
|
|
thd - thread handler
|
2006-10-03 19:38:25 +02:00
|
|
|
views - views to create
|
2004-07-16 00:15:55 +02:00
|
|
|
mode - VIEW_CREATE_NEW, VIEW_ALTER, VIEW_CREATE_OR_REPLACE
|
|
|
|
|
|
|
|
RETURN VALUE
|
2004-10-20 03:04:37 +02:00
|
|
|
FALSE OK
|
|
|
|
TRUE Error
|
2004-07-16 00:15:55 +02:00
|
|
|
*/
|
2004-09-11 22:52:55 +02:00
|
|
|
|
2006-10-03 19:38:25 +02:00
|
|
|
bool mysql_create_view(THD *thd, TABLE_LIST *views,
|
2004-10-20 03:04:37 +02:00
|
|
|
enum_view_create_mode mode)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
|
|
|
LEX *lex= thd->lex;
|
|
|
|
bool link_to_local;
|
|
|
|
/* first table in list is target VIEW name => cut off it */
|
|
|
|
TABLE_LIST *view= lex->unlink_first_table(&link_to_local);
|
|
|
|
TABLE_LIST *tables= lex->query_tables;
|
2004-07-16 22:44:14 +02:00
|
|
|
TABLE_LIST *tbl;
|
2004-11-17 13:17:09 +01:00
|
|
|
SELECT_LEX *select_lex= &lex->select_lex;
|
|
|
|
#ifndef NO_EMBEDDED_ACCESS_CHECKS
|
|
|
|
SELECT_LEX *sl;
|
|
|
|
#endif
|
2004-07-16 00:15:55 +02:00
|
|
|
SELECT_LEX_UNIT *unit= &lex->unit;
|
2004-10-20 03:04:37 +02:00
|
|
|
bool res= FALSE;
|
2004-07-16 00:15:55 +02:00
|
|
|
DBUG_ENTER("mysql_create_view");
|
|
|
|
|
2006-10-12 16:02:57 +02:00
|
|
|
/* This is ensured in the parser. */
|
|
|
|
DBUG_ASSERT(!lex->proc_list.first && !lex->result &&
|
|
|
|
!lex->param_list.elements && !lex->derived_tables);
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2005-07-06 18:00:17 +02:00
|
|
|
if (mode != VIEW_CREATE_NEW)
|
2006-07-31 16:33:37 +02:00
|
|
|
{
|
|
|
|
if (mode == VIEW_ALTER &&
|
|
|
|
fill_defined_view_parts(thd, view))
|
|
|
|
{
|
|
|
|
res= TRUE;
|
|
|
|
goto err;
|
|
|
|
}
|
2005-07-06 18:00:17 +02:00
|
|
|
sp_cache_invalidate();
|
2006-07-31 16:33:37 +02:00
|
|
|
}
|
2005-07-06 18:00:17 +02:00
|
|
|
|
2006-03-01 12:13:07 +01:00
|
|
|
if (!lex->definer)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
DEFINER-clause is missing; we have to create default definer in
|
|
|
|
persistent arena to be PS/SP friendly.
|
|
|
|
*/
|
|
|
|
|
|
|
|
Query_arena original_arena;
|
|
|
|
Query_arena *ps_arena = thd->activate_stmt_arena_if_needed(&original_arena);
|
|
|
|
|
|
|
|
if (!(lex->definer= create_default_definer(thd)))
|
|
|
|
res= TRUE;
|
|
|
|
|
|
|
|
if (ps_arena)
|
|
|
|
thd->restore_active_arena(ps_arena, &original_arena);
|
|
|
|
|
|
|
|
if (res)
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
#ifndef NO_EMBEDDED_ACCESS_CHECKS
|
2005-09-14 09:53:09 +02:00
|
|
|
/*
|
|
|
|
check definer of view:
|
|
|
|
- same as current user
|
|
|
|
- current user has SUPER_ACL
|
|
|
|
*/
|
2005-11-10 20:25:03 +01:00
|
|
|
if (strcmp(lex->definer->user.str,
|
2005-09-15 21:29:07 +02:00
|
|
|
thd->security_ctx->priv_user) != 0 ||
|
2005-09-14 09:53:09 +02:00
|
|
|
my_strcasecmp(system_charset_info,
|
2005-11-10 20:25:03 +01:00
|
|
|
lex->definer->host.str,
|
2005-09-15 21:29:07 +02:00
|
|
|
thd->security_ctx->priv_host) != 0)
|
2005-09-14 09:53:09 +02:00
|
|
|
{
|
2005-09-15 21:29:07 +02:00
|
|
|
if (!(thd->security_ctx->master_access & SUPER_ACL))
|
2005-09-14 09:53:09 +02:00
|
|
|
{
|
2005-11-10 20:25:03 +01:00
|
|
|
my_error(ER_SPECIFIC_ACCESS_DENIED_ERROR, MYF(0), "SUPER");
|
2005-09-14 09:53:09 +02:00
|
|
|
res= TRUE;
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
2005-11-10 20:25:03 +01:00
|
|
|
if (!is_acl_user(lex->definer->host.str,
|
|
|
|
lex->definer->user.str))
|
2005-09-14 09:53:09 +02:00
|
|
|
{
|
|
|
|
push_warning_printf(thd, MYSQL_ERROR::WARN_LEVEL_NOTE,
|
|
|
|
ER_NO_SUCH_USER,
|
|
|
|
ER(ER_NO_SUCH_USER),
|
2005-11-10 20:25:03 +01:00
|
|
|
lex->definer->user.str,
|
|
|
|
lex->definer->host.str);
|
2005-09-14 09:53:09 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2004-10-07 00:45:06 +02:00
|
|
|
/*
|
|
|
|
Privilege check for view creation:
|
2005-04-02 17:45:44 +02:00
|
|
|
- user has CREATE VIEW privilege on view table
|
|
|
|
- user has DROP privilege in case of ALTER VIEW or CREATE OR REPLACE
|
2004-10-07 14:43:04 +02:00
|
|
|
VIEW
|
2005-04-02 17:45:44 +02:00
|
|
|
- user has some (SELECT/UPDATE/INSERT/DELETE) privileges on columns of
|
2004-10-07 00:45:06 +02:00
|
|
|
underlying tables used on top of SELECT list (because it can be
|
|
|
|
(theoretically) updated, so it is enough to have UPDATE privilege on
|
|
|
|
them, for example)
|
2005-04-02 17:45:44 +02:00
|
|
|
- user has SELECT privilege on columns used in expressions of VIEW select
|
2004-10-07 00:45:06 +02:00
|
|
|
- for columns of underly tables used on top of SELECT list also will be
|
|
|
|
checked that we have not more privileges on correspondent column of view
|
|
|
|
table (i.e. user will not get some privileges by view creation)
|
|
|
|
*/
|
2004-10-07 14:43:04 +02:00
|
|
|
if ((check_access(thd, CREATE_VIEW_ACL, view->db, &view->grant.privilege,
|
2005-09-13 13:07:38 +02:00
|
|
|
0, 0, is_schema_db(view->db)) ||
|
2004-10-07 14:43:04 +02:00
|
|
|
grant_option && check_grant(thd, CREATE_VIEW_ACL, view, 0, 1, 0)) ||
|
|
|
|
(mode != VIEW_CREATE_NEW &&
|
2005-04-02 17:05:00 +02:00
|
|
|
(check_access(thd, DROP_ACL, view->db, &view->grant.privilege,
|
2005-09-13 13:07:38 +02:00
|
|
|
0, 0, is_schema_db(view->db)) ||
|
2005-04-02 17:05:00 +02:00
|
|
|
grant_option && check_grant(thd, DROP_ACL, view, 0, 1, 0))))
|
2005-08-17 21:42:53 +02:00
|
|
|
{
|
|
|
|
res= TRUE;
|
|
|
|
goto err;
|
|
|
|
}
|
2004-08-24 18:50:16 +02:00
|
|
|
for (sl= select_lex; sl; sl= sl->next_select())
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-08-24 18:50:16 +02:00
|
|
|
for (tbl= sl->get_table_list(); tbl; tbl= tbl->next_local)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-08-24 18:50:16 +02:00
|
|
|
/*
|
2004-10-07 00:45:06 +02:00
|
|
|
Ensure that we have some privileges on this table, more strict check
|
2004-08-24 18:50:16 +02:00
|
|
|
will be done on column level after preparation,
|
|
|
|
*/
|
2004-09-03 21:38:45 +02:00
|
|
|
if (check_some_access(thd, VIEW_ANY_ACL, tbl))
|
2004-08-24 18:50:16 +02:00
|
|
|
{
|
2004-11-13 18:35:51 +01:00
|
|
|
my_error(ER_TABLEACCESS_DENIED_ERROR, MYF(0),
|
2005-09-15 21:29:07 +02:00
|
|
|
"ANY", thd->security_ctx->priv_user,
|
|
|
|
thd->security_ctx->priv_host, tbl->table_name);
|
2005-08-17 21:42:53 +02:00
|
|
|
res= TRUE;
|
|
|
|
goto err;
|
2004-08-24 18:50:16 +02:00
|
|
|
}
|
2004-10-07 00:45:06 +02:00
|
|
|
/*
|
|
|
|
Mark this table as a table which will be checked after the prepare
|
|
|
|
phase
|
|
|
|
*/
|
2004-08-24 18:50:16 +02:00
|
|
|
tbl->table_in_first_from_clause= 1;
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2004-08-24 18:50:16 +02:00
|
|
|
/*
|
2004-10-07 00:45:06 +02:00
|
|
|
We need to check only SELECT_ACL for all normal fields, fields for
|
|
|
|
which we need "any" (SELECT/UPDATE/INSERT/DELETE) privilege will be
|
|
|
|
checked later
|
2004-08-24 18:50:16 +02:00
|
|
|
*/
|
|
|
|
tbl->grant.want_privilege= SELECT_ACL;
|
|
|
|
/*
|
2004-10-07 00:45:06 +02:00
|
|
|
Make sure that all rights are loaded to the TABLE::grant field.
|
2004-08-24 18:50:16 +02:00
|
|
|
|
2005-01-06 12:00:13 +01:00
|
|
|
tbl->table_name will be correct name of table because VIEWs are
|
2004-08-24 18:50:16 +02:00
|
|
|
not opened yet.
|
|
|
|
*/
|
|
|
|
fill_effective_table_privileges(thd, &tbl->grant, tbl->db,
|
2005-01-06 12:00:13 +01:00
|
|
|
tbl->table_name);
|
2004-08-24 18:50:16 +02:00
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if (&lex->select_lex != lex->all_selects_list)
|
|
|
|
{
|
|
|
|
/* check tables of subqueries */
|
2004-07-16 22:44:14 +02:00
|
|
|
for (tbl= tables; tbl; tbl= tbl->next_global)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
|
|
|
if (!tbl->table_in_first_from_clause)
|
|
|
|
{
|
|
|
|
if (check_access(thd, SELECT_ACL, tbl->db,
|
2005-09-13 13:07:38 +02:00
|
|
|
&tbl->grant.privilege, 0, 0, test(tbl->schema_table)) ||
|
2004-07-16 00:15:55 +02:00
|
|
|
grant_option && check_grant(thd, SELECT_ACL, tbl, 0, 1, 0))
|
|
|
|
{
|
2004-10-20 03:04:37 +02:00
|
|
|
res= TRUE;
|
2004-07-16 00:15:55 +02:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
/*
|
2004-10-07 00:45:06 +02:00
|
|
|
Mark fields for special privilege check ("any" privilege)
|
2004-07-16 00:15:55 +02:00
|
|
|
*/
|
2004-08-24 18:50:16 +02:00
|
|
|
for (sl= select_lex; sl; sl= sl->next_select())
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-08-24 18:50:16 +02:00
|
|
|
List_iterator_fast<Item> it(sl->item_list);
|
2004-07-16 00:15:55 +02:00
|
|
|
Item *item;
|
|
|
|
while ((item= it++))
|
|
|
|
{
|
2004-09-16 22:45:20 +02:00
|
|
|
Item_field *field;
|
|
|
|
if ((field= item->filed_for_view_update()))
|
|
|
|
field->any_privileges= 1;
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2004-10-20 03:04:37 +02:00
|
|
|
if (open_and_lock_tables(thd, tables))
|
2005-08-17 21:42:53 +02:00
|
|
|
{
|
|
|
|
res= TRUE;
|
|
|
|
goto err;
|
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2004-10-07 14:43:04 +02:00
|
|
|
/*
|
|
|
|
check that tables are not temporary and this VIEW do not used in query
|
2005-08-18 07:19:12 +02:00
|
|
|
(it is possible with ALTERing VIEW).
|
|
|
|
open_and_lock_tables can change the value of tables,
|
|
|
|
e.g. it may happen if before the function call tables was equal to 0.
|
|
|
|
*/
|
2005-08-22 00:13:37 +02:00
|
|
|
for (tbl= lex->query_tables; tbl; tbl= tbl->next_global)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-10-07 14:43:04 +02:00
|
|
|
/* is this table view and the same view which we creates now? */
|
|
|
|
if (tbl->view &&
|
|
|
|
strcmp(tbl->view_db.str, view->db) == 0 &&
|
2005-01-06 12:00:13 +01:00
|
|
|
strcmp(tbl->view_name.str, view->table_name) == 0)
|
2004-10-07 14:43:04 +02:00
|
|
|
{
|
|
|
|
my_error(ER_NO_SUCH_TABLE, MYF(0), tbl->view_db.str, tbl->view_name.str);
|
2004-10-20 03:04:37 +02:00
|
|
|
res= TRUE;
|
2004-10-07 14:43:04 +02:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
/*
|
2005-12-01 11:15:48 +01:00
|
|
|
tbl->table can be NULL when tbl is a placeholder for a view
|
|
|
|
that is indirectly referenced via a stored function from the
|
|
|
|
view being created. We don't check these indirectly
|
|
|
|
referenced views in CREATE VIEW so they don't have table
|
|
|
|
object.
|
2004-07-16 00:15:55 +02:00
|
|
|
*/
|
2005-12-01 11:15:48 +01:00
|
|
|
if (tbl->table)
|
|
|
|
{
|
|
|
|
/* is this table temporary and is not view? */
|
|
|
|
if (tbl->table->s->tmp_table != NO_TMP_TABLE && !tbl->view &&
|
|
|
|
!tbl->schema_table)
|
|
|
|
{
|
|
|
|
my_error(ER_VIEW_SELECT_TMPTABLE, MYF(0), tbl->alias);
|
|
|
|
res= TRUE;
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
/*
|
|
|
|
Copy the privileges of the underlying VIEWs which were filled by
|
|
|
|
fill_effective_table_privileges
|
|
|
|
(they were not copied at derived tables processing)
|
|
|
|
*/
|
|
|
|
tbl->table->grant.privilege= tbl->grant.privilege;
|
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
|
2004-10-07 00:45:06 +02:00
|
|
|
/* prepare select to resolve all fields */
|
2004-07-16 00:15:55 +02:00
|
|
|
lex->view_prepare_mode= 1;
|
2005-09-22 00:11:21 +02:00
|
|
|
if (unit->prepare(thd, 0, 0))
|
2004-08-23 11:38:55 +02:00
|
|
|
{
|
|
|
|
/*
|
|
|
|
some errors from prepare are reported to user, if is not then
|
|
|
|
it will be checked after err: label
|
|
|
|
*/
|
2004-10-20 03:04:37 +02:00
|
|
|
res= TRUE;
|
2004-07-16 00:15:55 +02:00
|
|
|
goto err;
|
2004-08-23 11:38:55 +02:00
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
|
|
|
|
/* view list (list of view fields names) */
|
|
|
|
if (lex->view_list.elements)
|
|
|
|
{
|
|
|
|
List_iterator_fast<Item> it(select_lex->item_list);
|
|
|
|
List_iterator_fast<LEX_STRING> nm(lex->view_list);
|
|
|
|
Item *item;
|
|
|
|
LEX_STRING *name;
|
2004-09-03 20:43:04 +02:00
|
|
|
|
|
|
|
if (lex->view_list.elements != select_lex->item_list.elements)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-09-03 20:43:04 +02:00
|
|
|
my_message(ER_VIEW_WRONG_LIST, ER(ER_VIEW_WRONG_LIST), MYF(0));
|
2005-09-14 09:53:09 +02:00
|
|
|
res= TRUE;
|
2004-09-03 20:43:04 +02:00
|
|
|
goto err;
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
2004-09-03 20:43:04 +02:00
|
|
|
while ((item= it++, name= nm++))
|
2005-06-21 19:30:48 +02:00
|
|
|
{
|
2004-09-03 20:43:04 +02:00
|
|
|
item->set_name(name->str, name->length, system_charset_info);
|
2005-06-21 19:30:48 +02:00
|
|
|
item->is_autogenerated_name= FALSE;
|
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
|
2005-08-10 15:45:00 +02:00
|
|
|
if (check_duplicate_names(select_lex->item_list, 1))
|
2005-08-17 21:42:53 +02:00
|
|
|
{
|
|
|
|
res= TRUE;
|
|
|
|
goto err;
|
|
|
|
}
|
2004-07-21 11:14:45 +02:00
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
#ifndef NO_EMBEDDED_ACCESS_CHECKS
|
|
|
|
/*
|
2004-10-07 00:45:06 +02:00
|
|
|
Compare/check grants on view with grants of underlying tables
|
2004-07-16 00:15:55 +02:00
|
|
|
*/
|
2004-08-24 18:50:16 +02:00
|
|
|
for (sl= select_lex; sl; sl= sl->next_select())
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
A fix and a test case for
Bug#19022 "Memory bug when switching db during trigger execution"
Bug#17199 "Problem when view calls function from another database."
Bug#18444 "Fully qualified stored function names don't work correctly in
SELECT statements"
Documentation note: this patch introduces a change in behaviour of prepared
statements.
This patch adds a few new invariants with regard to how THD::db should
be used. These invariants should be preserved in future:
- one should never refer to THD::db by pointer and always make a deep copy
(strmake, strdup)
- one should never compare two databases by pointer, but use strncmp or
my_strncasecmp
- TABLE_LIST object table->db should be always initialized in the parser or
by creator of the object.
For prepared statements it means that if the current database is changed
after a statement is prepared, the database that was current at prepare
remains active. This also means that you can not prepare a statement that
implicitly refers to the current database if the latter is not set.
This is not documented, and therefore needs documentation. This is NOT a
change in behavior for almost all SQL statements except:
- ALTER TABLE t1 RENAME t2
- OPTIMIZE TABLE t1
- ANALYZE TABLE t1
- TRUNCATE TABLE t1 --
until this patch t1 or t2 could be evaluated at the first execution of
prepared statement.
CURRENT_DATABASE() still works OK and is evaluated at every execution
of prepared statement.
Note, that in stored routines this is not an issue as the default
database is the database of the stored procedure and "use" statement
is prohibited in stored routines.
This patch makes obsolete the use of check_db_used (it was never used in the
old code too) and all other places that check for table->db and assign it
from THD::db if it's NULL, except the parser.
How this patch was created: THD::{db,db_length} were replaced with a
LEX_STRING, THD::db. All the places that refer to THD::{db,db_length} were
manually checked and:
- if the place uses thd->db by pointer, it was fixed to make a deep copy
- if a place compared two db pointers, it was fixed to compare them by value
(via strcmp/my_strcasecmp, whatever was approproate)
Then this intermediate patch was used to write a smaller patch that does the
same thing but without a rename.
TODO in 5.1:
- remove check_db_used
- deploy THD::set_db in mysql_change_db
See also comments to individual files.
2006-06-26 22:47:52 +02:00
|
|
|
DBUG_ASSERT(view->db); /* Must be set in the parser */
|
2004-08-24 18:50:16 +02:00
|
|
|
List_iterator_fast<Item> it(sl->item_list);
|
2004-07-16 00:15:55 +02:00
|
|
|
Item *item;
|
A fix and a test case for
Bug#19022 "Memory bug when switching db during trigger execution"
Bug#17199 "Problem when view calls function from another database."
Bug#18444 "Fully qualified stored function names don't work correctly in
SELECT statements"
Documentation note: this patch introduces a change in behaviour of prepared
statements.
This patch adds a few new invariants with regard to how THD::db should
be used. These invariants should be preserved in future:
- one should never refer to THD::db by pointer and always make a deep copy
(strmake, strdup)
- one should never compare two databases by pointer, but use strncmp or
my_strncasecmp
- TABLE_LIST object table->db should be always initialized in the parser or
by creator of the object.
For prepared statements it means that if the current database is changed
after a statement is prepared, the database that was current at prepare
remains active. This also means that you can not prepare a statement that
implicitly refers to the current database if the latter is not set.
This is not documented, and therefore needs documentation. This is NOT a
change in behavior for almost all SQL statements except:
- ALTER TABLE t1 RENAME t2
- OPTIMIZE TABLE t1
- ANALYZE TABLE t1
- TRUNCATE TABLE t1 --
until this patch t1 or t2 could be evaluated at the first execution of
prepared statement.
CURRENT_DATABASE() still works OK and is evaluated at every execution
of prepared statement.
Note, that in stored routines this is not an issue as the default
database is the database of the stored procedure and "use" statement
is prohibited in stored routines.
This patch makes obsolete the use of check_db_used (it was never used in the
old code too) and all other places that check for table->db and assign it
from THD::db if it's NULL, except the parser.
How this patch was created: THD::{db,db_length} were replaced with a
LEX_STRING, THD::db. All the places that refer to THD::{db,db_length} were
manually checked and:
- if the place uses thd->db by pointer, it was fixed to make a deep copy
- if a place compared two db pointers, it was fixed to compare them by value
(via strcmp/my_strcasecmp, whatever was approproate)
Then this intermediate patch was used to write a smaller patch that does the
same thing but without a rename.
TODO in 5.1:
- remove check_db_used
- deploy THD::set_db in mysql_change_db
See also comments to individual files.
2006-06-26 22:47:52 +02:00
|
|
|
fill_effective_table_privileges(thd, &view->grant, view->db,
|
2005-01-06 12:00:13 +01:00
|
|
|
view->table_name);
|
2004-09-03 20:43:04 +02:00
|
|
|
while ((item= it++))
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-09-16 22:45:20 +02:00
|
|
|
Item_field *fld;
|
A fix and a test case for
Bug#19022 "Memory bug when switching db during trigger execution"
Bug#17199 "Problem when view calls function from another database."
Bug#18444 "Fully qualified stored function names don't work correctly in
SELECT statements"
Documentation note: this patch introduces a change in behaviour of prepared
statements.
This patch adds a few new invariants with regard to how THD::db should
be used. These invariants should be preserved in future:
- one should never refer to THD::db by pointer and always make a deep copy
(strmake, strdup)
- one should never compare two databases by pointer, but use strncmp or
my_strncasecmp
- TABLE_LIST object table->db should be always initialized in the parser or
by creator of the object.
For prepared statements it means that if the current database is changed
after a statement is prepared, the database that was current at prepare
remains active. This also means that you can not prepare a statement that
implicitly refers to the current database if the latter is not set.
This is not documented, and therefore needs documentation. This is NOT a
change in behavior for almost all SQL statements except:
- ALTER TABLE t1 RENAME t2
- OPTIMIZE TABLE t1
- ANALYZE TABLE t1
- TRUNCATE TABLE t1 --
until this patch t1 or t2 could be evaluated at the first execution of
prepared statement.
CURRENT_DATABASE() still works OK and is evaluated at every execution
of prepared statement.
Note, that in stored routines this is not an issue as the default
database is the database of the stored procedure and "use" statement
is prohibited in stored routines.
This patch makes obsolete the use of check_db_used (it was never used in the
old code too) and all other places that check for table->db and assign it
from THD::db if it's NULL, except the parser.
How this patch was created: THD::{db,db_length} were replaced with a
LEX_STRING, THD::db. All the places that refer to THD::{db,db_length} were
manually checked and:
- if the place uses thd->db by pointer, it was fixed to make a deep copy
- if a place compared two db pointers, it was fixed to compare them by value
(via strcmp/my_strcasecmp, whatever was approproate)
Then this intermediate patch was used to write a smaller patch that does the
same thing but without a rename.
TODO in 5.1:
- remove check_db_used
- deploy THD::set_db in mysql_change_db
See also comments to individual files.
2006-06-26 22:47:52 +02:00
|
|
|
uint priv= (get_column_grant(thd, &view->grant, view->db,
|
2005-01-06 12:00:13 +01:00
|
|
|
view->table_name, item->name) &
|
2004-07-16 00:15:55 +02:00
|
|
|
VIEW_ANY_ACL);
|
2004-09-16 22:45:20 +02:00
|
|
|
if ((fld= item->filed_for_view_update()))
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
|
|
|
/*
|
2004-10-07 00:45:06 +02:00
|
|
|
Do we have more privileges on view field then underlying table field?
|
2004-07-16 00:15:55 +02:00
|
|
|
*/
|
2005-01-06 12:00:13 +01:00
|
|
|
if (!fld->field->table->s->tmp_table && (~fld->have_privileges & priv))
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
|
|
|
/* VIEW column has more privileges */
|
2004-11-13 18:35:51 +01:00
|
|
|
my_error(ER_COLUMNACCESS_DENIED_ERROR, MYF(0),
|
2005-09-15 21:29:07 +02:00
|
|
|
"create view", thd->security_ctx->priv_user,
|
|
|
|
thd->security_ctx->priv_host, item->name,
|
2005-01-06 12:00:13 +01:00
|
|
|
view->table_name);
|
2005-08-17 21:42:53 +02:00
|
|
|
res= TRUE;
|
|
|
|
goto err;
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2004-09-09 05:59:26 +02:00
|
|
|
if (wait_if_global_read_lock(thd, 0, 0))
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-10-20 03:04:37 +02:00
|
|
|
res= TRUE;
|
2004-07-16 00:15:55 +02:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
VOID(pthread_mutex_lock(&LOCK_open));
|
2004-09-03 20:43:04 +02:00
|
|
|
res= mysql_register_view(thd, view, mode);
|
2006-10-03 19:38:25 +02:00
|
|
|
|
|
|
|
if (mysql_bin_log.is_open())
|
|
|
|
{
|
|
|
|
String buff;
|
|
|
|
const LEX_STRING command[3]=
|
2006-10-11 22:49:59 +02:00
|
|
|
{{ C_STRING_WITH_LEN("CREATE ") },
|
|
|
|
{ C_STRING_WITH_LEN("ALTER ") },
|
|
|
|
{ C_STRING_WITH_LEN("CREATE OR REPLACE ") }};
|
2006-10-03 19:38:25 +02:00
|
|
|
|
|
|
|
buff.append(command[thd->lex->create_view_mode].str,
|
|
|
|
command[thd->lex->create_view_mode].length);
|
|
|
|
view_store_options(thd, views, &buff);
|
|
|
|
buff.append(STRING_WITH_LEN("VIEW "));
|
|
|
|
/* Test if user supplied a db (ie: we did not use thd->db) */
|
|
|
|
if (views->db && views->db[0] &&
|
|
|
|
(thd->db == NULL || strcmp(views->db, thd->db)))
|
|
|
|
{
|
|
|
|
append_identifier(thd, &buff, views->db,
|
|
|
|
views->db_length);
|
|
|
|
buff.append('.');
|
|
|
|
}
|
|
|
|
append_identifier(thd, &buff, views->table_name,
|
|
|
|
views->table_name_length);
|
2006-10-11 22:49:59 +02:00
|
|
|
if (lex->view_list.elements)
|
|
|
|
{
|
|
|
|
List_iterator_fast<LEX_STRING> names(lex->view_list);
|
|
|
|
LEX_STRING *name;
|
|
|
|
int i;
|
|
|
|
|
2006-11-07 14:25:57 +01:00
|
|
|
for (i= 0; (name= names++); i++)
|
2006-10-11 22:49:59 +02:00
|
|
|
{
|
|
|
|
buff.append(i ? ", " : "(");
|
|
|
|
append_identifier(thd, &buff, name->str, name->length);
|
|
|
|
}
|
|
|
|
buff.append(')');
|
|
|
|
}
|
2006-10-03 19:38:25 +02:00
|
|
|
buff.append(STRING_WITH_LEN(" AS "));
|
|
|
|
buff.append(views->source.str, views->source.length);
|
|
|
|
|
2006-10-11 22:49:59 +02:00
|
|
|
thd->binlog_query(THD::STMT_QUERY_TYPE,
|
|
|
|
buff.ptr(), buff.length(), FALSE, FALSE);
|
2006-10-03 19:38:25 +02:00
|
|
|
}
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
VOID(pthread_mutex_unlock(&LOCK_open));
|
2005-01-27 13:21:37 +01:00
|
|
|
if (view->revision != 1)
|
|
|
|
query_cache_invalidate3(thd, view, 0);
|
2004-07-16 00:15:55 +02:00
|
|
|
start_waiting_global_read_lock(thd);
|
2004-09-03 20:43:04 +02:00
|
|
|
if (res)
|
|
|
|
goto err;
|
2004-07-16 00:15:55 +02:00
|
|
|
|
|
|
|
send_ok(thd);
|
|
|
|
lex->link_first_table_back(view, link_to_local);
|
2004-12-06 16:15:54 +01:00
|
|
|
DBUG_RETURN(0);
|
2004-07-16 00:15:55 +02:00
|
|
|
|
|
|
|
err:
|
|
|
|
thd->proc_info= "end";
|
|
|
|
lex->link_first_table_back(view, link_to_local);
|
|
|
|
unit->cleanup();
|
2004-10-20 03:04:37 +02:00
|
|
|
DBUG_RETURN(res || thd->net.report_error);
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2004-09-01 21:48:59 +02:00
|
|
|
/* index of revision number in following table */
|
2005-09-14 09:53:09 +02:00
|
|
|
static const int revision_number_position= 8;
|
2004-09-01 21:48:59 +02:00
|
|
|
/* index of last required parameter for making view */
|
2005-09-14 09:53:09 +02:00
|
|
|
static const int required_view_parameters= 10;
|
2005-09-16 17:13:21 +02:00
|
|
|
/* number of backups */
|
|
|
|
static const int num_view_backups= 3;
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2004-09-03 20:43:04 +02:00
|
|
|
/*
|
|
|
|
table of VIEW .frm field descriptors
|
|
|
|
|
|
|
|
Note that one should NOT change the order for this, as it's used by
|
|
|
|
parse()
|
|
|
|
*/
|
2004-07-16 00:15:55 +02:00
|
|
|
static File_option view_parameters[]=
|
2006-08-17 18:13:45 +02:00
|
|
|
{{{ C_STRING_WITH_LEN("query")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, query),
|
2005-11-11 18:03:32 +01:00
|
|
|
FILE_OPTIONS_ESTRING},
|
2006-08-17 18:13:45 +02:00
|
|
|
{{ C_STRING_WITH_LEN("md5")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, md5),
|
2005-09-14 09:53:09 +02:00
|
|
|
FILE_OPTIONS_STRING},
|
2006-08-17 18:13:45 +02:00
|
|
|
{{ C_STRING_WITH_LEN("updatable")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, updatable_view),
|
2005-09-14 09:53:09 +02:00
|
|
|
FILE_OPTIONS_ULONGLONG},
|
2006-08-17 18:13:45 +02:00
|
|
|
{{ C_STRING_WITH_LEN("algorithm")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, algorithm),
|
2005-09-14 09:53:09 +02:00
|
|
|
FILE_OPTIONS_ULONGLONG},
|
2006-08-17 18:13:45 +02:00
|
|
|
{{ C_STRING_WITH_LEN("definer_user")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, definer.user),
|
2004-07-16 00:15:55 +02:00
|
|
|
FILE_OPTIONS_STRING},
|
2006-08-17 18:13:45 +02:00
|
|
|
{{ C_STRING_WITH_LEN("definer_host")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, definer.host),
|
2004-07-16 00:15:55 +02:00
|
|
|
FILE_OPTIONS_STRING},
|
2006-08-17 18:13:45 +02:00
|
|
|
{{ C_STRING_WITH_LEN("suid")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, view_suid),
|
2004-07-16 00:15:55 +02:00
|
|
|
FILE_OPTIONS_ULONGLONG},
|
2006-08-17 18:13:45 +02:00
|
|
|
{{ C_STRING_WITH_LEN("with_check_option")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, with_check),
|
2004-07-16 00:15:55 +02:00
|
|
|
FILE_OPTIONS_ULONGLONG},
|
2006-08-17 18:13:45 +02:00
|
|
|
{{ C_STRING_WITH_LEN("revision")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, revision),
|
2004-07-16 00:15:55 +02:00
|
|
|
FILE_OPTIONS_REV},
|
2006-08-17 18:13:45 +02:00
|
|
|
{{ C_STRING_WITH_LEN("timestamp")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, timestamp),
|
2004-07-16 00:15:55 +02:00
|
|
|
FILE_OPTIONS_TIMESTAMP},
|
2006-08-17 18:13:45 +02:00
|
|
|
{{ C_STRING_WITH_LEN("create-version")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, file_version),
|
2004-07-16 00:15:55 +02:00
|
|
|
FILE_OPTIONS_ULONGLONG},
|
2006-08-17 18:13:45 +02:00
|
|
|
{{ C_STRING_WITH_LEN("source")},
|
2006-10-20 13:47:52 +02:00
|
|
|
my_offsetof(TABLE_LIST, source),
|
2004-07-16 00:15:55 +02:00
|
|
|
FILE_OPTIONS_ESTRING},
|
2004-11-03 11:39:38 +01:00
|
|
|
{{NullS, 0}, 0,
|
2004-07-16 00:15:55 +02:00
|
|
|
FILE_OPTIONS_STRING}
|
|
|
|
};
|
|
|
|
|
2005-07-31 11:49:55 +02:00
|
|
|
static LEX_STRING view_file_type[]= {{(char*) STRING_WITH_LEN("VIEW") }};
|
2004-07-16 00:15:55 +02:00
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
Register VIEW (write .frm & process .frm's history backups)
|
|
|
|
|
|
|
|
SYNOPSIS
|
|
|
|
mysql_register_view()
|
|
|
|
thd - thread handler
|
|
|
|
view - view description
|
|
|
|
mode - VIEW_CREATE_NEW, VIEW_ALTER, VIEW_CREATE_OR_REPLACE
|
|
|
|
|
|
|
|
RETURN
|
|
|
|
0 OK
|
|
|
|
-1 Error
|
|
|
|
1 Error and error message given
|
|
|
|
*/
|
2004-09-11 22:52:55 +02:00
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
static int mysql_register_view(THD *thd, TABLE_LIST *view,
|
|
|
|
enum_view_create_mode mode)
|
|
|
|
{
|
2004-10-25 16:32:28 +02:00
|
|
|
LEX *lex= thd->lex;
|
2004-07-16 00:15:55 +02:00
|
|
|
char buff[4096];
|
|
|
|
String str(buff,(uint32) sizeof(buff), system_charset_info);
|
2004-10-28 18:37:25 +02:00
|
|
|
char md5[MD5_BUFF_LENGTH];
|
2004-07-16 00:15:55 +02:00
|
|
|
bool can_be_merged;
|
2006-11-30 02:40:42 +01:00
|
|
|
char dir_buff[FN_REFLEN], path_buff[FN_REFLEN];
|
2006-08-14 11:27:11 +02:00
|
|
|
const uchar *endp;
|
2005-12-31 06:01:26 +01:00
|
|
|
LEX_STRING dir, file, path;
|
2004-07-16 00:15:55 +02:00
|
|
|
DBUG_ENTER("mysql_register_view");
|
|
|
|
|
2004-10-07 00:45:06 +02:00
|
|
|
/* print query */
|
2004-07-16 00:15:55 +02:00
|
|
|
str.length(0);
|
2004-07-20 17:51:02 +02:00
|
|
|
{
|
|
|
|
ulong sql_mode= thd->variables.sql_mode & MODE_ANSI_QUOTES;
|
|
|
|
thd->variables.sql_mode&= ~MODE_ANSI_QUOTES;
|
2004-10-25 16:32:28 +02:00
|
|
|
lex->unit.print(&str);
|
2004-07-20 17:51:02 +02:00
|
|
|
thd->variables.sql_mode|= sql_mode;
|
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
str.append('\0');
|
2005-07-31 11:49:55 +02:00
|
|
|
DBUG_PRINT("info", ("View: %s", str.ptr()));
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2004-10-07 00:45:06 +02:00
|
|
|
/* print file name */
|
2005-12-31 06:01:26 +01:00
|
|
|
dir.length= build_table_filename(dir_buff, sizeof(dir_buff),
|
2006-08-02 17:57:06 +02:00
|
|
|
view->db, "", "", 0);
|
2004-07-16 00:15:55 +02:00
|
|
|
dir.str= dir_buff;
|
|
|
|
|
2005-12-31 06:01:26 +01:00
|
|
|
path.length= build_table_filename(path_buff, sizeof(path_buff),
|
2006-08-02 17:57:06 +02:00
|
|
|
view->db, view->table_name, reg_ext, 0);
|
2005-12-31 06:01:26 +01:00
|
|
|
path.str= path_buff;
|
|
|
|
|
|
|
|
file.str= path.str + dir.length;
|
|
|
|
file.length= path.length - dir.length;
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
/* init timestamp */
|
2004-09-03 20:43:04 +02:00
|
|
|
if (!view->timestamp.str)
|
2004-07-16 00:15:55 +02:00
|
|
|
view->timestamp.str= view->timestamp_buffer;
|
|
|
|
|
2004-10-07 00:45:06 +02:00
|
|
|
/* check old .frm */
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
|
|
|
char path_buff[FN_REFLEN];
|
|
|
|
LEX_STRING path;
|
2004-09-03 20:43:04 +02:00
|
|
|
File_parser *parser;
|
2004-09-29 15:35:01 +02:00
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
path.str= path_buff;
|
|
|
|
fn_format(path_buff, file.str, dir.str, 0, MY_UNPACK_FILENAME);
|
|
|
|
path.length= strlen(path_buff);
|
|
|
|
|
|
|
|
if (!access(path.str, F_OK))
|
|
|
|
{
|
|
|
|
if (mode == VIEW_CREATE_NEW)
|
|
|
|
{
|
|
|
|
my_error(ER_TABLE_EXISTS_ERROR, MYF(0), view->alias);
|
2004-09-03 14:18:40 +02:00
|
|
|
DBUG_RETURN(-1);
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
|
2004-11-09 02:58:44 +01:00
|
|
|
if (!(parser= sql_parse_prepare(&path, thd->mem_root, 0)))
|
2004-09-03 20:43:04 +02:00
|
|
|
DBUG_RETURN(1);
|
|
|
|
|
2005-07-31 11:49:55 +02:00
|
|
|
if (!parser->ok() || !is_equal(&view_type, parser->type()))
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
A fix and a test case for
Bug#19022 "Memory bug when switching db during trigger execution"
Bug#17199 "Problem when view calls function from another database."
Bug#18444 "Fully qualified stored function names don't work correctly in
SELECT statements"
Documentation note: this patch introduces a change in behaviour of prepared
statements.
This patch adds a few new invariants with regard to how THD::db should
be used. These invariants should be preserved in future:
- one should never refer to THD::db by pointer and always make a deep copy
(strmake, strdup)
- one should never compare two databases by pointer, but use strncmp or
my_strncasecmp
- TABLE_LIST object table->db should be always initialized in the parser or
by creator of the object.
For prepared statements it means that if the current database is changed
after a statement is prepared, the database that was current at prepare
remains active. This also means that you can not prepare a statement that
implicitly refers to the current database if the latter is not set.
This is not documented, and therefore needs documentation. This is NOT a
change in behavior for almost all SQL statements except:
- ALTER TABLE t1 RENAME t2
- OPTIMIZE TABLE t1
- ANALYZE TABLE t1
- TRUNCATE TABLE t1 --
until this patch t1 or t2 could be evaluated at the first execution of
prepared statement.
CURRENT_DATABASE() still works OK and is evaluated at every execution
of prepared statement.
Note, that in stored routines this is not an issue as the default
database is the database of the stored procedure and "use" statement
is prohibited in stored routines.
This patch makes obsolete the use of check_db_used (it was never used in the
old code too) and all other places that check for table->db and assign it
from THD::db if it's NULL, except the parser.
How this patch was created: THD::{db,db_length} were replaced with a
LEX_STRING, THD::db. All the places that refer to THD::{db,db_length} were
manually checked and:
- if the place uses thd->db by pointer, it was fixed to make a deep copy
- if a place compared two db pointers, it was fixed to compare them by value
(via strcmp/my_strcasecmp, whatever was approproate)
Then this intermediate patch was used to write a smaller patch that does the
same thing but without a rename.
TODO in 5.1:
- remove check_db_used
- deploy THD::set_db in mysql_change_db
See also comments to individual files.
2006-06-26 22:47:52 +02:00
|
|
|
my_error(ER_WRONG_OBJECT, MYF(0), view->db, view->table_name, "VIEW");
|
2004-09-05 21:14:27 +02:00
|
|
|
DBUG_RETURN(-1);
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
2004-09-03 20:43:04 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
read revision number
|
2004-09-11 22:52:55 +02:00
|
|
|
|
2004-10-07 00:45:06 +02:00
|
|
|
TODO: read dependence list, too, to process cascade/restrict
|
2004-09-03 20:43:04 +02:00
|
|
|
TODO: special cascade/restrict procedure for alter?
|
|
|
|
*/
|
2004-11-09 02:58:44 +01:00
|
|
|
if (parser->parse((gptr)view, thd->mem_root,
|
2005-11-20 19:47:07 +01:00
|
|
|
view_parameters + revision_number_position, 1,
|
|
|
|
&file_parser_dummy_hook))
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-09-05 21:14:27 +02:00
|
|
|
DBUG_RETURN(thd->net.report_error? -1 : 0);
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
if (mode == VIEW_ALTER)
|
|
|
|
{
|
|
|
|
my_error(ER_NO_SUCH_TABLE, MYF(0), view->db, view->alias);
|
2004-09-03 14:18:40 +02:00
|
|
|
DBUG_RETURN(-1);
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2004-10-07 00:45:06 +02:00
|
|
|
/* fill structure */
|
2004-07-16 00:15:55 +02:00
|
|
|
view->query.str= (char*)str.ptr();
|
|
|
|
view->query.length= str.length()-1; // we do not need last \0
|
2005-12-02 20:18:12 +01:00
|
|
|
view->source.str= thd->query + thd->lex->create_view_select_start;
|
2006-08-14 11:27:11 +02:00
|
|
|
endp= (uchar*) view->source.str;
|
|
|
|
endp= skip_rear_comments(endp, (uchar*) (thd->query + thd->query_length));
|
|
|
|
view->source.length= endp - (uchar*) view->source.str;
|
2004-07-16 00:15:55 +02:00
|
|
|
view->file_version= 1;
|
|
|
|
view->calc_md5(md5);
|
|
|
|
view->md5.str= md5;
|
|
|
|
view->md5.length= 32;
|
2004-10-25 16:32:28 +02:00
|
|
|
can_be_merged= lex->can_be_merged();
|
|
|
|
if (lex->create_view_algorithm == VIEW_ALGORITHM_MERGE &&
|
|
|
|
!lex->can_be_merged())
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
|
|
|
push_warning(thd, MYSQL_ERROR::WARN_LEVEL_WARN, ER_WARN_VIEW_MERGE,
|
|
|
|
ER(ER_WARN_VIEW_MERGE));
|
2004-10-25 16:32:28 +02:00
|
|
|
lex->create_view_algorithm= VIEW_ALGORITHM_UNDEFINED;
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
2004-10-25 16:32:28 +02:00
|
|
|
view->algorithm= lex->create_view_algorithm;
|
2005-11-10 20:25:03 +01:00
|
|
|
view->definer.user= lex->definer->user;
|
|
|
|
view->definer.host= lex->definer->host;
|
2005-09-14 09:53:09 +02:00
|
|
|
view->view_suid= lex->create_view_suid;
|
2004-10-25 16:32:28 +02:00
|
|
|
view->with_check= lex->create_view_check;
|
2004-07-22 16:52:04 +02:00
|
|
|
if ((view->updatable_view= (can_be_merged &&
|
2004-09-03 21:38:45 +02:00
|
|
|
view->algorithm != VIEW_ALGORITHM_TMPTABLE)))
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-10-07 00:45:06 +02:00
|
|
|
/* TODO: change here when we will support UNIONs */
|
2004-10-25 16:32:28 +02:00
|
|
|
for (TABLE_LIST *tbl= (TABLE_LIST *)lex->select_lex.table_list.first;
|
2004-09-15 22:42:56 +02:00
|
|
|
tbl;
|
|
|
|
tbl= tbl->next_local)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-11-13 11:56:39 +01:00
|
|
|
if ((tbl->view && !tbl->updatable_view) || tbl->schema_table)
|
2004-11-25 01:23:13 +01:00
|
|
|
{
|
2004-09-15 22:42:56 +02:00
|
|
|
view->updatable_view= 0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
for (TABLE_LIST *up= tbl; up; up= up->embedding)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-09-15 22:42:56 +02:00
|
|
|
if (up->outer_join)
|
|
|
|
{
|
|
|
|
view->updatable_view= 0;
|
|
|
|
goto loop_out;
|
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2004-09-15 22:42:56 +02:00
|
|
|
loop_out:
|
2004-10-25 16:32:28 +02:00
|
|
|
/*
|
|
|
|
Check that table of main select do not used in subqueries.
|
|
|
|
|
|
|
|
This test can catch only very simple cases of such non-updateable views,
|
|
|
|
all other will be detected before updating commands execution.
|
|
|
|
(it is more optimisation then real check)
|
|
|
|
|
|
|
|
NOTE: this skip cases of using table via VIEWs, joined VIEWs, VIEWs with
|
|
|
|
UNION
|
|
|
|
*/
|
|
|
|
if (view->updatable_view &&
|
|
|
|
!lex->select_lex.next_select() &&
|
|
|
|
!((TABLE_LIST*)lex->select_lex.table_list.first)->next_local &&
|
|
|
|
find_table_in_global_list(lex->query_tables->next_global,
|
|
|
|
lex->query_tables->db,
|
2005-01-06 12:00:13 +01:00
|
|
|
lex->query_tables->table_name))
|
2004-10-25 16:32:28 +02:00
|
|
|
{
|
|
|
|
view->updatable_view= 0;
|
|
|
|
}
|
|
|
|
|
2004-09-03 14:18:40 +02:00
|
|
|
if (view->with_check != VIEW_CHECK_NONE &&
|
|
|
|
!view->updatable_view)
|
|
|
|
{
|
2005-01-06 12:00:13 +01:00
|
|
|
my_error(ER_VIEW_NONUPD_CHECK, MYF(0), view->db, view->table_name);
|
2004-09-03 14:18:40 +02:00
|
|
|
DBUG_RETURN(-1);
|
|
|
|
}
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
if (sql_create_definition_file(&dir, &file, view_file_type,
|
2005-09-16 17:13:21 +02:00
|
|
|
(gptr)view, view_parameters, num_view_backups))
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-09-03 14:18:40 +02:00
|
|
|
DBUG_RETURN(thd->net.report_error? -1 : 1);
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
DBUG_RETURN(0);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2005-10-27 23:18:23 +02:00
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
/*
|
|
|
|
read VIEW .frm and create structures
|
|
|
|
|
|
|
|
SYNOPSIS
|
|
|
|
mysql_make_view()
|
2005-11-01 14:54:30 +01:00
|
|
|
thd Thread handler
|
|
|
|
parser parser object
|
|
|
|
table TABLE_LIST structure for filling
|
2006-08-08 22:05:42 +02:00
|
|
|
flags flags
|
2004-07-21 03:26:20 +02:00
|
|
|
RETURN
|
2004-09-03 20:43:04 +02:00
|
|
|
0 ok
|
|
|
|
1 error
|
2004-07-16 00:15:55 +02:00
|
|
|
*/
|
2004-09-03 20:43:04 +02:00
|
|
|
|
2006-08-08 22:05:42 +02:00
|
|
|
bool mysql_make_view(THD *thd, File_parser *parser, TABLE_LIST *table,
|
|
|
|
uint flags)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2005-11-01 14:54:30 +01:00
|
|
|
SELECT_LEX *end, *view_select;
|
|
|
|
LEX *old_lex, *lex;
|
|
|
|
Query_arena *arena, backup;
|
2006-04-13 22:12:26 +02:00
|
|
|
TABLE_LIST *top_view= table->top_table();
|
2005-11-01 14:54:30 +01:00
|
|
|
int res;
|
2006-12-15 05:21:15 +01:00
|
|
|
bool result, view_is_mergeable;
|
|
|
|
TABLE_LIST *view_main_select_tables;
|
2004-07-16 00:15:55 +02:00
|
|
|
DBUG_ENTER("mysql_make_view");
|
2005-11-01 14:54:30 +01:00
|
|
|
DBUG_PRINT("info", ("table: 0x%lx (%s)", (ulong) table, table->table_name));
|
2004-07-16 00:15:55 +02:00
|
|
|
|
|
|
|
if (table->view)
|
|
|
|
{
|
2005-10-27 23:18:23 +02:00
|
|
|
/*
|
|
|
|
It's an execution of a PS/SP and the view has already been unfolded
|
|
|
|
into a list of used tables. Now we only need to update the information
|
|
|
|
about granted privileges in the view tables with the actual data
|
|
|
|
stored in MySQL privilege system. We don't need to restore the
|
|
|
|
required privileges (by calling register_want_access) because they has
|
|
|
|
not changed since PREPARE or the previous execution: the only case
|
|
|
|
when this information is changed is execution of UPDATE on a view, but
|
|
|
|
the original want_access is restored in its end.
|
|
|
|
*/
|
|
|
|
if (!table->prelocking_placeholder && table->prepare_security(thd))
|
|
|
|
{
|
|
|
|
DBUG_RETURN(1);
|
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
DBUG_PRINT("info",
|
2004-09-03 20:43:04 +02:00
|
|
|
("VIEW %s.%s is already processed on previous PS/SP execution",
|
2004-07-16 00:15:55 +02:00
|
|
|
table->view_db.str, table->view_name.str));
|
|
|
|
DBUG_RETURN(0);
|
|
|
|
}
|
|
|
|
|
2006-04-13 22:12:26 +02:00
|
|
|
/* check loop via view definition */
|
|
|
|
for (TABLE_LIST *precedent= table->referencing_view;
|
|
|
|
precedent;
|
|
|
|
precedent= precedent->referencing_view)
|
|
|
|
{
|
|
|
|
if (precedent->view_name.length == table->table_name_length &&
|
|
|
|
precedent->view_db.length == table->db_length &&
|
|
|
|
my_strcasecmp(system_charset_info,
|
|
|
|
precedent->view_name.str, table->table_name) == 0 &&
|
|
|
|
my_strcasecmp(system_charset_info,
|
|
|
|
precedent->view_db.str, table->db) == 0)
|
|
|
|
{
|
|
|
|
my_error(ER_VIEW_RECURSIVE, MYF(0),
|
|
|
|
top_view->view_db.str, top_view->view_name.str);
|
|
|
|
DBUG_RETURN(TRUE);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
/*
|
|
|
|
For now we assume that tables will not be changed during PS life (it
|
|
|
|
will be TRUE as far as we make new table cache).
|
|
|
|
*/
|
2005-11-01 14:54:30 +01:00
|
|
|
old_lex= thd->lex;
|
|
|
|
arena= thd->stmt_arena;
|
2004-09-10 01:22:44 +02:00
|
|
|
if (arena->is_conventional())
|
2004-09-09 05:59:26 +02:00
|
|
|
arena= 0;
|
|
|
|
else
|
2005-09-02 15:21:19 +02:00
|
|
|
thd->set_n_backup_active_arena(arena, &backup);
|
2004-07-16 00:15:55 +02:00
|
|
|
|
|
|
|
/* init timestamp */
|
2004-09-03 20:43:04 +02:00
|
|
|
if (!table->timestamp.str)
|
2004-07-16 00:15:55 +02:00
|
|
|
table->timestamp.str= table->timestamp_buffer;
|
2005-09-14 09:53:09 +02:00
|
|
|
/* prepare default values for old format */
|
2005-10-27 23:18:23 +02:00
|
|
|
table->view_suid= TRUE;
|
2005-09-14 09:53:09 +02:00
|
|
|
table->definer.user.str= table->definer.host.str= 0;
|
|
|
|
table->definer.user.length= table->definer.host.length= 0;
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
/*
|
|
|
|
TODO: when VIEWs will be stored in cache, table mem_root should
|
|
|
|
be used here
|
|
|
|
*/
|
2004-11-09 02:58:44 +01:00
|
|
|
if (parser->parse((gptr)table, thd->mem_root, view_parameters,
|
2005-11-20 19:47:07 +01:00
|
|
|
required_view_parameters, &file_parser_dummy_hook))
|
2004-07-16 00:15:55 +02:00
|
|
|
goto err;
|
|
|
|
|
2005-09-14 09:53:09 +02:00
|
|
|
/*
|
|
|
|
check old format view .frm
|
|
|
|
*/
|
|
|
|
if (!table->definer.user.str)
|
|
|
|
{
|
|
|
|
DBUG_ASSERT(!table->definer.host.str &&
|
|
|
|
!table->definer.user.length &&
|
|
|
|
!table->definer.host.length);
|
|
|
|
push_warning_printf(thd, MYSQL_ERROR::WARN_LEVEL_WARN,
|
|
|
|
ER_VIEW_FRM_NO_USER, ER(ER_VIEW_FRM_NO_USER),
|
|
|
|
table->db, table->table_name);
|
2006-03-02 12:17:13 +01:00
|
|
|
get_default_definer(thd, &table->definer);
|
2005-09-14 09:53:09 +02:00
|
|
|
}
|
2006-08-08 22:05:42 +02:00
|
|
|
if (flags & OPEN_VIEW_NO_PARSE)
|
|
|
|
{
|
|
|
|
DBUG_RETURN(FALSE);
|
|
|
|
}
|
2005-09-14 09:53:09 +02:00
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
/*
|
|
|
|
Save VIEW parameters, which will be wiped out by derived table
|
|
|
|
processing
|
|
|
|
*/
|
|
|
|
table->view_db.str= table->db;
|
|
|
|
table->view_db.length= table->db_length;
|
2005-01-06 12:00:13 +01:00
|
|
|
table->view_name.str= table->table_name;
|
|
|
|
table->view_name.length= table->table_name_length;
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2004-07-16 14:20:51 +02:00
|
|
|
/*TODO: md5 test here and warning if it is differ */
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2004-07-16 14:20:51 +02:00
|
|
|
/*
|
|
|
|
TODO: TABLE mem root should be used here when VIEW will be stored in
|
|
|
|
TABLE cache
|
|
|
|
|
|
|
|
now Lex placed in statement memory
|
|
|
|
*/
|
2004-11-09 02:58:44 +01:00
|
|
|
table->view= lex= thd->lex= (LEX*) new(thd->mem_root) st_lex_local;
|
2004-11-03 11:39:38 +01:00
|
|
|
lex_start(thd, (uchar*)table->query.str, table->query.length);
|
2004-09-14 18:28:29 +02:00
|
|
|
view_select= &lex->select_lex;
|
2005-03-04 14:35:28 +01:00
|
|
|
view_select->select_number= ++thd->select_number;
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2005-07-28 21:39:11 +02:00
|
|
|
ulong save_mode= thd->variables.sql_mode;
|
2004-07-16 00:15:55 +02:00
|
|
|
/* switch off modes which can prevent normal parsing of VIEW
|
|
|
|
- MODE_REAL_AS_FLOAT affect only CREATE TABLE parsing
|
|
|
|
+ MODE_PIPES_AS_CONCAT affect expression parsing
|
|
|
|
+ MODE_ANSI_QUOTES affect expression parsing
|
|
|
|
+ MODE_IGNORE_SPACE affect expression parsing
|
|
|
|
- MODE_NOT_USED not used :)
|
|
|
|
* MODE_ONLY_FULL_GROUP_BY affect execution
|
|
|
|
* MODE_NO_UNSIGNED_SUBTRACTION affect execution
|
|
|
|
- MODE_NO_DIR_IN_CREATE affect table creation only
|
|
|
|
- MODE_POSTGRESQL compounded from other modes
|
|
|
|
- MODE_ORACLE compounded from other modes
|
|
|
|
- MODE_MSSQL compounded from other modes
|
|
|
|
- MODE_DB2 compounded from other modes
|
|
|
|
- MODE_MAXDB affect only CREATE TABLE parsing
|
|
|
|
- MODE_NO_KEY_OPTIONS affect only SHOW
|
|
|
|
- MODE_NO_TABLE_OPTIONS affect only SHOW
|
|
|
|
- MODE_NO_FIELD_OPTIONS affect only SHOW
|
|
|
|
- MODE_MYSQL323 affect only SHOW
|
|
|
|
- MODE_MYSQL40 affect only SHOW
|
|
|
|
- MODE_ANSI compounded from other modes
|
|
|
|
(+ transaction mode)
|
|
|
|
? MODE_NO_AUTO_VALUE_ON_ZERO affect UPDATEs
|
|
|
|
+ MODE_NO_BACKSLASH_ESCAPES affect expression parsing
|
|
|
|
*/
|
2005-07-28 21:39:11 +02:00
|
|
|
thd->variables.sql_mode&= ~(MODE_PIPES_AS_CONCAT | MODE_ANSI_QUOTES |
|
|
|
|
MODE_IGNORE_SPACE | MODE_NO_BACKSLASH_ESCAPES);
|
2004-09-01 21:48:59 +02:00
|
|
|
CHARSET_INFO *save_cs= thd->variables.character_set_client;
|
2004-09-03 20:38:01 +02:00
|
|
|
thd->variables.character_set_client= system_charset_info;
|
2006-03-10 01:44:08 +01:00
|
|
|
res= MYSQLparse((void *)thd);
|
2004-09-01 21:48:59 +02:00
|
|
|
thd->variables.character_set_client= save_cs;
|
2005-07-28 21:39:11 +02:00
|
|
|
thd->variables.sql_mode= save_mode;
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
if (!res && !thd->is_fatal_error)
|
|
|
|
{
|
2004-09-11 22:52:55 +02:00
|
|
|
TABLE_LIST *view_tables= lex->query_tables;
|
|
|
|
TABLE_LIST *view_tables_tail= 0;
|
2004-09-14 18:28:29 +02:00
|
|
|
TABLE_LIST *tbl;
|
2004-07-16 14:20:51 +02:00
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
/*
|
2005-03-04 14:35:28 +01:00
|
|
|
Check rights to run commands (EXPLAIN SELECT & SHOW CREATE) which show
|
|
|
|
underlying tables.
|
|
|
|
Skip this step if we are opening view for prelocking only.
|
2004-07-16 00:15:55 +02:00
|
|
|
*/
|
2005-03-04 14:35:28 +01:00
|
|
|
if (!table->prelocking_placeholder &&
|
|
|
|
(old_lex->sql_command == SQLCOM_SELECT && old_lex->describe))
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-09-11 22:52:55 +02:00
|
|
|
if (check_table_access(thd, SELECT_ACL, view_tables, 1) &&
|
2004-09-17 21:23:59 +02:00
|
|
|
check_table_access(thd, SHOW_VIEW_ACL, table, 1))
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-11-12 13:34:00 +01:00
|
|
|
my_message(ER_VIEW_NO_EXPLAIN, ER(ER_VIEW_NO_EXPLAIN), MYF(0));
|
2004-07-16 00:15:55 +02:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
}
|
2005-03-04 14:35:28 +01:00
|
|
|
else if (!table->prelocking_placeholder &&
|
2006-07-25 14:23:25 +02:00
|
|
|
old_lex->sql_command == SQLCOM_SHOW_CREATE &&
|
|
|
|
!table->belong_to_view)
|
2004-09-17 21:23:59 +02:00
|
|
|
{
|
|
|
|
if (check_table_access(thd, SHOW_VIEW_ACL, table, 0))
|
|
|
|
goto err;
|
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2005-10-27 23:18:23 +02:00
|
|
|
if (!(table->view_tables=
|
|
|
|
(List<TABLE_LIST>*) new(thd->mem_root) List<TABLE_LIST>))
|
|
|
|
goto err;
|
2005-01-04 17:04:16 +01:00
|
|
|
/*
|
|
|
|
mark to avoid temporary table using and put view reference and find
|
|
|
|
last view table
|
|
|
|
*/
|
|
|
|
for (tbl= view_tables;
|
|
|
|
tbl;
|
|
|
|
tbl= (view_tables_tail= tbl)->next_global)
|
|
|
|
{
|
|
|
|
tbl->skip_temporary= 1;
|
|
|
|
tbl->belong_to_view= top_view;
|
2005-10-27 23:18:23 +02:00
|
|
|
tbl->referencing_view= table;
|
2006-03-28 13:06:29 +02:00
|
|
|
tbl->prelocking_placeholder= table->prelocking_placeholder;
|
2005-10-27 23:18:23 +02:00
|
|
|
/*
|
|
|
|
First we fill want_privilege with SELECT_ACL (this is needed for the
|
|
|
|
tables which belongs to view subqueries and temporary table views,
|
|
|
|
then for the merged view underlying tables we will set wanted
|
|
|
|
privileges of top_view
|
|
|
|
*/
|
|
|
|
tbl->grant.want_privilege= SELECT_ACL;
|
|
|
|
/*
|
|
|
|
After unfolding the view we lose the list of tables referenced in it
|
|
|
|
(we will have only a list of underlying tables in case of MERGE
|
|
|
|
algorithm, which does not include the tables referenced from
|
|
|
|
subqueries used in view definition).
|
|
|
|
Let's build a list of all tables referenced in the view.
|
|
|
|
*/
|
|
|
|
table->view_tables->push_back(tbl);
|
2005-01-04 17:04:16 +01:00
|
|
|
}
|
|
|
|
|
2004-09-11 22:52:55 +02:00
|
|
|
/*
|
|
|
|
Put tables of VIEW after VIEW TABLE_LIST
|
|
|
|
|
|
|
|
NOTE: It is important for UPDATE/INSERT/DELETE checks to have this
|
|
|
|
tables just after VIEW instead of tail of list, to be able check that
|
|
|
|
table is unique. Also we store old next table for the same purpose.
|
|
|
|
*/
|
|
|
|
if (view_tables)
|
|
|
|
{
|
|
|
|
if (table->next_global)
|
|
|
|
{
|
2004-10-25 16:32:28 +02:00
|
|
|
view_tables_tail->next_global= table->next_global;
|
2004-09-11 22:52:55 +02:00
|
|
|
table->next_global->prev_global= &view_tables_tail->next_global;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
2005-03-04 14:35:28 +01:00
|
|
|
old_lex->query_tables_last= &view_tables_tail->next_global;
|
2004-09-11 22:52:55 +02:00
|
|
|
}
|
|
|
|
view_tables->prev_global= &table->next_global;
|
|
|
|
table->next_global= view_tables;
|
|
|
|
}
|
|
|
|
|
* Mixed replication mode * :
1) Fix for BUG#19630 "stored function inserting into two auto_increment breaks
statement-based binlog":
a stored function inserting into two such tables may fail to replicate
(inserting wrong data in the slave's copy of the second table) if the slave's
second table had an internal auto_increment counter different from master's.
Because the auto_increment value autogenerated by master for the 2nd table
does not go into binlog, only the first does, so the slave lacks information.
To fix this, if running in mixed binlogging mode, if the stored function or
trigger plans to update two different tables both having auto_increment
columns, we switch to row-based for the whole function.
We don't have a simple solution for statement-based binlogging mode, there
the bug remains and will be documented as a known problem.
Re-enabling rpl_switch_stm_row_mixed.
2) Fix for BUG#20630 "Mixed binlogging mode does not work with stored
functions, triggers, views", which was a documented limitation (in mixed
mode, we didn't detect that a stored function's execution needed row-based
binlogging (due to some UUID() call for example); same for
triggers, same for views (a view created from a SELECT UUID(), and doing
INSERT INTO sometable SELECT theview; would not replicate row-based).
This is implemented by, after parsing a routine's body, remembering in sp_head
that this routine needs row-based binlogging. Then when this routine is used,
the caller is marked to require row-based binlogging too.
Same for views: when we parse a view and detect that its SELECT needs
row-based binary logging, we mark the calling LEX as such.
3) Fix for BUG#20499 "mixed mode with temporary table breaks binlog":
a temporary table containing e.g. UUID has its changes not binlogged,
so any query updating a permanent table with data from the temporary table
will run wrongly on slave. Solution: in mixed mode we don't switch back
from row-based to statement-based when there exists temporary tables.
4) Attempt to test mysqlbinlog on a binlog generated by mysqlbinlog;
impossible due to BUG#11312 and BUG#20329, but test is in place for when
they are fixed.
2006-07-09 17:00:47 +02:00
|
|
|
/*
|
|
|
|
If the view's body needs row-based binlogging (e.g. the VIEW is created
|
|
|
|
from SELECT UUID()), the top statement also needs it.
|
|
|
|
*/
|
|
|
|
if (lex->binlog_row_based_if_mixed)
|
|
|
|
old_lex->binlog_row_based_if_mixed= TRUE;
|
2006-12-15 05:21:15 +01:00
|
|
|
view_is_mergeable= (table->algorithm != VIEW_ALGORITHM_TMPTABLE &&
|
|
|
|
lex->can_be_merged());
|
2006-11-01 18:41:09 +01:00
|
|
|
LINT_INIT(view_main_select_tables);
|
|
|
|
|
2006-08-29 12:32:59 +02:00
|
|
|
if (view_is_mergeable)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
Currently 'view_main_select_tables' differs from 'view_tables'
|
|
|
|
only then view has CONVERT_TZ() function in its select list.
|
|
|
|
This may change in future, for example if we enable merging of
|
|
|
|
views with subqueries in select list.
|
|
|
|
*/
|
|
|
|
view_main_select_tables=
|
|
|
|
(TABLE_LIST*)lex->select_lex.table_list.first;
|
|
|
|
|
|
|
|
/*
|
|
|
|
Let us set proper lock type for tables of the view's main
|
|
|
|
select since we may want to perform update or insert on
|
|
|
|
view. This won't work for view containing union. But this is
|
|
|
|
ok since we don't allow insert and update on such views
|
|
|
|
anyway.
|
|
|
|
*/
|
|
|
|
for (tbl= view_main_select_tables; tbl; tbl= tbl->next_local)
|
|
|
|
tbl->lock_type= table->lock_type;
|
|
|
|
}
|
* Mixed replication mode * :
1) Fix for BUG#19630 "stored function inserting into two auto_increment breaks
statement-based binlog":
a stored function inserting into two such tables may fail to replicate
(inserting wrong data in the slave's copy of the second table) if the slave's
second table had an internal auto_increment counter different from master's.
Because the auto_increment value autogenerated by master for the 2nd table
does not go into binlog, only the first does, so the slave lacks information.
To fix this, if running in mixed binlogging mode, if the stored function or
trigger plans to update two different tables both having auto_increment
columns, we switch to row-based for the whole function.
We don't have a simple solution for statement-based binlogging mode, there
the bug remains and will be documented as a known problem.
Re-enabling rpl_switch_stm_row_mixed.
2) Fix for BUG#20630 "Mixed binlogging mode does not work with stored
functions, triggers, views", which was a documented limitation (in mixed
mode, we didn't detect that a stored function's execution needed row-based
binlogging (due to some UUID() call for example); same for
triggers, same for views (a view created from a SELECT UUID(), and doing
INSERT INTO sometable SELECT theview; would not replicate row-based).
This is implemented by, after parsing a routine's body, remembering in sp_head
that this routine needs row-based binlogging. Then when this routine is used,
the caller is marked to require row-based binlogging too.
Same for views: when we parse a view and detect that its SELECT needs
row-based binary logging, we mark the calling LEX as such.
3) Fix for BUG#20499 "mixed mode with temporary table breaks binlog":
a temporary table containing e.g. UUID has its changes not binlogged,
so any query updating a permanent table with data from the temporary table
will run wrongly on slave. Solution: in mixed mode we don't switch back
from row-based to statement-based when there exists temporary tables.
4) Attempt to test mysqlbinlog on a binlog generated by mysqlbinlog;
impossible due to BUG#11312 and BUG#20329, but test is in place for when
they are fixed.
2006-07-09 17:00:47 +02:00
|
|
|
|
2005-03-04 14:35:28 +01:00
|
|
|
/*
|
|
|
|
If we are opening this view as part of implicit LOCK TABLES, then
|
|
|
|
this view serves as simple placeholder and we should not continue
|
|
|
|
further processing.
|
|
|
|
*/
|
|
|
|
if (table->prelocking_placeholder)
|
|
|
|
goto ok2;
|
|
|
|
|
2005-10-27 23:18:23 +02:00
|
|
|
old_lex->derived_tables|= (DERIVED_VIEW | lex->derived_tables);
|
2005-03-04 14:35:28 +01:00
|
|
|
|
|
|
|
/* move SQL_NO_CACHE & Co to whole query */
|
|
|
|
old_lex->safe_to_cache_query= (old_lex->safe_to_cache_query &&
|
|
|
|
lex->safe_to_cache_query);
|
|
|
|
/* move SQL_CACHE to whole query */
|
|
|
|
if (view_select->options & OPTION_TO_QUERY_CACHE)
|
|
|
|
old_lex->select_lex.options|= OPTION_TO_QUERY_CACHE;
|
|
|
|
|
2005-10-27 23:18:23 +02:00
|
|
|
if (table->view_suid)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
Prepare a security context to check underlying objects of the view
|
|
|
|
*/
|
|
|
|
if (!(table->view_sctx= (Security_context *)
|
|
|
|
thd->stmt_arena->alloc(sizeof(Security_context))))
|
|
|
|
goto err;
|
|
|
|
/* Assign the context to the tables referenced in the view */
|
2007-01-18 10:48:17 +01:00
|
|
|
if (view_tables)
|
|
|
|
{
|
|
|
|
DBUG_ASSERT(view_tables_tail);
|
|
|
|
for (tbl= view_tables; tbl != view_tables_tail->next_global;
|
|
|
|
tbl= tbl->next_global)
|
|
|
|
tbl->security_ctx= table->view_sctx;
|
|
|
|
}
|
2005-10-27 23:18:23 +02:00
|
|
|
/* assign security context to SELECT name resolution contexts of view */
|
|
|
|
for(SELECT_LEX *sl= lex->all_selects_list;
|
|
|
|
sl;
|
|
|
|
sl= sl->next_select_in_list())
|
|
|
|
sl->context.security_ctx= table->view_sctx;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
Setup an error processor to hide error messages issued by stored
|
|
|
|
routines referenced in the view
|
|
|
|
*/
|
|
|
|
for (SELECT_LEX *sl= lex->all_selects_list;
|
|
|
|
sl;
|
|
|
|
sl= sl->next_select_in_list())
|
|
|
|
{
|
|
|
|
sl->context.error_processor= &view_error_processor;
|
|
|
|
sl->context.error_processor_data= (void *)table;
|
|
|
|
}
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
/*
|
|
|
|
check MERGE algorithm ability
|
|
|
|
- algorithm is not explicit TEMPORARY TABLE
|
2004-10-07 00:45:06 +02:00
|
|
|
- VIEW SELECT allow merging
|
2004-07-16 00:15:55 +02:00
|
|
|
- VIEW used in subquery or command support MERGE algorithm
|
|
|
|
*/
|
2006-08-29 12:32:59 +02:00
|
|
|
if (view_is_mergeable &&
|
2004-07-16 00:15:55 +02:00
|
|
|
(table->select_lex->master_unit() != &old_lex->unit ||
|
2004-08-24 21:51:23 +02:00
|
|
|
old_lex->can_use_merged()) &&
|
|
|
|
!old_lex->can_not_use_merged())
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
|
|
|
/* lex should contain at least one table */
|
2006-04-22 09:54:25 +02:00
|
|
|
DBUG_ASSERT(view_main_select_tables != 0);
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2006-08-29 12:32:59 +02:00
|
|
|
List_iterator_fast<TABLE_LIST> ti(view_select->top_join_list);
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
table->effective_algorithm= VIEW_ALGORITHM_MERGE;
|
2004-08-24 21:51:23 +02:00
|
|
|
DBUG_PRINT("info", ("algorithm: MERGE"));
|
2004-07-22 16:52:04 +02:00
|
|
|
table->updatable= (table->updatable_view != 0);
|
2005-07-01 06:05:42 +02:00
|
|
|
table->effective_with_check=
|
|
|
|
old_lex->get_effective_with_check(table);
|
2006-04-22 09:54:25 +02:00
|
|
|
table->merge_underlying_list= view_main_select_tables;
|
2005-10-27 23:18:23 +02:00
|
|
|
|
2006-08-29 12:32:59 +02:00
|
|
|
/* Fill correct wanted privileges. */
|
|
|
|
for (tbl= view_main_select_tables; tbl; tbl= tbl->next_local)
|
2005-10-27 23:18:23 +02:00
|
|
|
tbl->grant.want_privilege= top_view->grant.orig_want_privilege;
|
2005-07-01 06:05:42 +02:00
|
|
|
|
|
|
|
/* prepare view context */
|
2006-04-22 09:54:25 +02:00
|
|
|
lex->select_lex.context.resolve_in_table_list_only(view_main_select_tables);
|
2005-07-01 06:05:42 +02:00
|
|
|
lex->select_lex.context.outer_context= 0;
|
|
|
|
lex->select_lex.context.select_lex= table->select_lex;
|
2005-08-13 16:06:30 +02:00
|
|
|
lex->select_lex.select_n_having_items+=
|
|
|
|
table->select_lex->select_n_having_items;
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
/*
|
2005-05-05 17:49:15 +02:00
|
|
|
Tables of the main select of the view should be marked as belonging
|
|
|
|
to the same select as original view (again we can use LEX::select_lex
|
|
|
|
for this purprose because we don't support MERGE algorithm for views
|
|
|
|
with unions).
|
2004-07-16 00:15:55 +02:00
|
|
|
*/
|
2005-05-05 17:49:15 +02:00
|
|
|
for (tbl= lex->select_lex.get_table_list(); tbl; tbl= tbl->next_local)
|
2005-04-03 00:23:45 +02:00
|
|
|
tbl->select_lex= table->select_lex;
|
|
|
|
|
2004-09-14 18:28:29 +02:00
|
|
|
{
|
2006-04-22 09:54:25 +02:00
|
|
|
if (view_main_select_tables->next_local)
|
2005-08-13 16:06:30 +02:00
|
|
|
{
|
2005-05-11 01:31:13 +02:00
|
|
|
table->multitable_view= TRUE;
|
2005-08-13 16:06:30 +02:00
|
|
|
if (table->belong_to_view)
|
|
|
|
table->belong_to_view->multitable_view= TRUE;
|
|
|
|
}
|
2004-09-14 18:28:29 +02:00
|
|
|
/* make nested join structure for view tables */
|
|
|
|
NESTED_JOIN *nested_join;
|
|
|
|
if (!(nested_join= table->nested_join=
|
|
|
|
(NESTED_JOIN *) thd->calloc(sizeof(NESTED_JOIN))))
|
|
|
|
goto err;
|
|
|
|
nested_join->join_list= view_select->top_join_list;
|
|
|
|
|
|
|
|
/* re-nest tables of VIEW */
|
2005-07-04 02:42:33 +02:00
|
|
|
ti.rewind();
|
|
|
|
while ((tbl= ti++))
|
2004-09-14 18:28:29 +02:00
|
|
|
{
|
2005-07-04 02:42:33 +02:00
|
|
|
tbl->join_list= &nested_join->join_list;
|
|
|
|
tbl->embedding= table;
|
2004-09-14 18:28:29 +02:00
|
|
|
}
|
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2005-10-27 23:18:23 +02:00
|
|
|
/* Store WHERE clause for post-processing in setup_underlying */
|
2004-09-14 18:28:29 +02:00
|
|
|
table->where= view_select->where;
|
2004-10-07 21:54:31 +02:00
|
|
|
/*
|
2005-04-22 22:13:46 +02:00
|
|
|
Add subqueries units to SELECT into which we merging current view.
|
|
|
|
unit(->next)* chain starts with subqueries that are used by this
|
|
|
|
view and continues with subqueries that are used by other views.
|
|
|
|
We must not add any subquery twice (otherwise we'll form a loop),
|
2005-07-01 06:05:42 +02:00
|
|
|
to do this we remember in end_unit the first subquery that has
|
2005-04-22 22:13:46 +02:00
|
|
|
been already added.
|
2005-07-01 06:05:42 +02:00
|
|
|
|
2004-10-07 21:54:31 +02:00
|
|
|
NOTE: we do not support UNION here, so we take only one select
|
|
|
|
*/
|
2005-04-22 22:13:46 +02:00
|
|
|
SELECT_LEX_NODE *end_unit= table->select_lex->slave;
|
2005-04-23 04:55:43 +02:00
|
|
|
SELECT_LEX_UNIT *next_unit;
|
2004-10-07 21:54:31 +02:00
|
|
|
for (SELECT_LEX_UNIT *unit= lex->select_lex.first_inner_unit();
|
|
|
|
unit;
|
2005-04-23 04:55:43 +02:00
|
|
|
unit= next_unit)
|
2004-10-07 21:54:31 +02:00
|
|
|
{
|
2005-04-22 22:13:46 +02:00
|
|
|
if (unit == end_unit)
|
|
|
|
break;
|
2005-04-23 04:55:43 +02:00
|
|
|
SELECT_LEX_NODE *save_slave= unit->slave;
|
|
|
|
next_unit= unit->next_unit();
|
2004-10-07 21:54:31 +02:00
|
|
|
unit->include_down(table->select_lex);
|
|
|
|
unit->slave= save_slave; // fix include_down initialisation
|
|
|
|
}
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
/*
|
|
|
|
This SELECT_LEX will be linked in global SELECT_LEX list
|
|
|
|
to make it processed by mysql_handle_derived(),
|
|
|
|
but it will not be included to SELECT_LEX tree, because it
|
|
|
|
will not be executed
|
|
|
|
*/
|
2007-02-11 20:52:12 +01:00
|
|
|
table->select_lex->order_list.push_back(&lex->select_lex.order_list);
|
2004-07-16 00:15:55 +02:00
|
|
|
goto ok;
|
|
|
|
}
|
|
|
|
|
2004-09-03 20:43:04 +02:00
|
|
|
table->effective_algorithm= VIEW_ALGORITHM_TMPTABLE;
|
2004-08-24 21:51:23 +02:00
|
|
|
DBUG_PRINT("info", ("algorithm: TEMPORARY TABLE"));
|
2004-09-14 18:28:29 +02:00
|
|
|
view_select->linkage= DERIVED_TABLE_TYPE;
|
2004-07-22 16:52:04 +02:00
|
|
|
table->updatable= 0;
|
2004-10-07 14:43:04 +02:00
|
|
|
table->effective_with_check= VIEW_CHECK_NONE;
|
2004-12-06 16:15:54 +01:00
|
|
|
old_lex->subqueries= TRUE;
|
2004-07-16 00:15:55 +02:00
|
|
|
|
|
|
|
/* SELECT tree link */
|
|
|
|
lex->unit.include_down(table->select_lex);
|
2004-09-14 18:28:29 +02:00
|
|
|
lex->unit.slave= view_select; // fix include_down initialisation
|
2004-07-16 00:15:55 +02:00
|
|
|
|
|
|
|
table->derived= &lex->unit;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
ok:
|
|
|
|
/* global SELECT list linking */
|
2004-09-14 18:28:29 +02:00
|
|
|
end= view_select; // primary SELECT_LEX is always last
|
2004-07-16 00:15:55 +02:00
|
|
|
end->link_next= old_lex->all_selects_list;
|
|
|
|
old_lex->all_selects_list->link_prev= &end->link_next;
|
|
|
|
old_lex->all_selects_list= lex->all_selects_list;
|
|
|
|
lex->all_selects_list->link_prev=
|
|
|
|
(st_select_lex_node**)&old_lex->all_selects_list;
|
|
|
|
|
2005-03-04 14:35:28 +01:00
|
|
|
ok2:
|
2005-09-14 22:08:12 +02:00
|
|
|
if (!old_lex->time_zone_tables_used && thd->lex->time_zone_tables_used)
|
|
|
|
old_lex->time_zone_tables_used= thd->lex->time_zone_tables_used;
|
2006-06-01 15:26:16 +02:00
|
|
|
DBUG_ASSERT(lex == thd->lex);
|
|
|
|
thd->lex= old_lex; // Needed for prepare_security
|
2005-11-01 14:54:30 +01:00
|
|
|
result= !table->prelocking_placeholder && table->prepare_security(thd);
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2006-06-01 15:26:16 +02:00
|
|
|
lex_end(lex);
|
2005-11-01 14:54:30 +01:00
|
|
|
end:
|
2004-07-16 00:15:55 +02:00
|
|
|
if (arena)
|
2005-09-02 15:21:19 +02:00
|
|
|
thd->restore_active_arena(arena, &backup);
|
2005-11-01 14:54:30 +01:00
|
|
|
thd->lex= old_lex;
|
|
|
|
DBUG_RETURN(result);
|
|
|
|
|
|
|
|
err:
|
2006-05-04 21:19:31 +02:00
|
|
|
DBUG_ASSERT(thd->lex == table->view);
|
|
|
|
lex_end(thd->lex);
|
2005-03-04 18:54:24 +01:00
|
|
|
delete table->view;
|
2004-07-16 00:15:55 +02:00
|
|
|
table->view= 0; // now it is not VIEW placeholder
|
2005-11-01 14:54:30 +01:00
|
|
|
result= 1;
|
|
|
|
goto end;
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
drop view
|
|
|
|
|
|
|
|
SYNOPSIS
|
|
|
|
mysql_drop_view()
|
|
|
|
thd - thread handler
|
|
|
|
views - views to delete
|
|
|
|
drop_mode - cascade/check
|
|
|
|
|
|
|
|
RETURN VALUE
|
2004-10-20 03:04:37 +02:00
|
|
|
FALSE OK
|
|
|
|
TRUE Error
|
2004-07-16 00:15:55 +02:00
|
|
|
*/
|
2004-09-03 20:43:04 +02:00
|
|
|
|
2004-10-20 03:04:37 +02:00
|
|
|
bool mysql_drop_view(THD *thd, TABLE_LIST *views, enum_drop_mode drop_mode)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
|
|
|
char path[FN_REFLEN];
|
|
|
|
TABLE_LIST *view;
|
2006-07-31 19:56:06 +02:00
|
|
|
String non_existant_views;
|
|
|
|
char *wrong_object_db= NULL, *wrong_object_name= NULL;
|
|
|
|
bool error= FALSE;
|
2005-12-21 19:18:40 +01:00
|
|
|
enum legacy_db_type not_used;
|
2005-11-23 21:45:02 +01:00
|
|
|
DBUG_ENTER("mysql_drop_view");
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2006-10-03 19:38:25 +02:00
|
|
|
VOID(pthread_mutex_lock(&LOCK_open));
|
2004-07-16 00:15:55 +02:00
|
|
|
for (view= views; view; view= view->next_local)
|
|
|
|
{
|
2005-11-23 21:45:02 +01:00
|
|
|
TABLE_SHARE *share;
|
2006-08-01 22:38:38 +02:00
|
|
|
frm_type_enum type= FRMTYPE_ERROR;
|
2005-12-31 06:01:26 +01:00
|
|
|
build_table_filename(path, sizeof(path),
|
2006-08-02 17:57:06 +02:00
|
|
|
view->db, view->table_name, reg_ext, 0);
|
2006-08-01 22:38:38 +02:00
|
|
|
|
2006-07-31 19:56:06 +02:00
|
|
|
if (access(path, F_OK) ||
|
|
|
|
FRMTYPE_VIEW != (type= mysql_frm_type(thd, path, ¬_used)))
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
|
|
|
char name[FN_REFLEN];
|
2005-01-06 12:00:13 +01:00
|
|
|
my_snprintf(name, sizeof(name), "%s.%s", view->db, view->table_name);
|
2004-07-16 00:15:55 +02:00
|
|
|
if (thd->lex->drop_if_exists)
|
|
|
|
{
|
|
|
|
push_warning_printf(thd, MYSQL_ERROR::WARN_LEVEL_NOTE,
|
|
|
|
ER_BAD_TABLE_ERROR, ER(ER_BAD_TABLE_ERROR),
|
|
|
|
name);
|
|
|
|
continue;
|
|
|
|
}
|
2006-07-31 19:56:06 +02:00
|
|
|
if (type == FRMTYPE_TABLE)
|
|
|
|
{
|
|
|
|
if (!wrong_object_name)
|
|
|
|
{
|
|
|
|
wrong_object_db= view->db;
|
|
|
|
wrong_object_name= view->table_name;
|
|
|
|
}
|
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
else
|
2006-07-31 19:56:06 +02:00
|
|
|
{
|
|
|
|
if (non_existant_views.length())
|
|
|
|
non_existant_views.append(',');
|
|
|
|
non_existant_views.append(String(view->table_name,system_charset_info));
|
|
|
|
}
|
|
|
|
continue;
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
if (my_delete(path, MYF(MY_WME)))
|
2006-07-31 19:56:06 +02:00
|
|
|
error= TRUE;
|
2005-11-23 21:45:02 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
For a view, there is only one table_share object which should never
|
|
|
|
be used outside of LOCK_open
|
|
|
|
*/
|
|
|
|
if ((share= get_cached_table_share(view->db, view->table_name)))
|
|
|
|
{
|
|
|
|
DBUG_ASSERT(share->ref_count == 0);
|
|
|
|
pthread_mutex_lock(&share->mutex);
|
|
|
|
share->ref_count++;
|
|
|
|
share->version= 0;
|
|
|
|
pthread_mutex_unlock(&share->mutex);
|
|
|
|
release_table_share(share, RELEASE_WAIT_FOR_DROP);
|
|
|
|
}
|
2005-01-27 13:21:37 +01:00
|
|
|
query_cache_invalidate3(thd, view, 0);
|
2005-07-12 19:44:32 +02:00
|
|
|
sp_cache_invalidate();
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
2006-10-03 19:38:25 +02:00
|
|
|
|
2006-07-31 19:56:06 +02:00
|
|
|
if (error)
|
|
|
|
{
|
2006-10-20 23:44:03 +02:00
|
|
|
VOID(pthread_mutex_unlock(&LOCK_open));
|
2006-07-31 19:56:06 +02:00
|
|
|
DBUG_RETURN(TRUE);
|
|
|
|
}
|
|
|
|
if (wrong_object_name)
|
|
|
|
{
|
2006-10-20 23:44:03 +02:00
|
|
|
VOID(pthread_mutex_unlock(&LOCK_open));
|
2006-07-31 19:56:06 +02:00
|
|
|
my_error(ER_WRONG_OBJECT, MYF(0), wrong_object_db, wrong_object_name,
|
|
|
|
"VIEW");
|
|
|
|
DBUG_RETURN(TRUE);
|
|
|
|
}
|
|
|
|
if (non_existant_views.length())
|
|
|
|
{
|
2006-10-20 23:44:03 +02:00
|
|
|
VOID(pthread_mutex_unlock(&LOCK_open));
|
2006-07-31 19:56:06 +02:00
|
|
|
my_error(ER_BAD_TABLE_ERROR, MYF(0), non_existant_views.c_ptr());
|
|
|
|
DBUG_RETURN(TRUE);
|
|
|
|
}
|
2006-10-20 23:44:03 +02:00
|
|
|
|
|
|
|
if (mysql_bin_log.is_open())
|
|
|
|
{
|
|
|
|
thd->clear_error();
|
|
|
|
thd->binlog_query(THD::STMT_QUERY_TYPE,
|
|
|
|
thd->query, thd->query_length, FALSE, FALSE);
|
|
|
|
}
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
send_ok(thd);
|
2006-10-20 23:44:03 +02:00
|
|
|
VOID(pthread_mutex_unlock(&LOCK_open));
|
2004-10-20 03:04:37 +02:00
|
|
|
DBUG_RETURN(FALSE);
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
Check type of .frm if we are not going to parse it
|
|
|
|
|
|
|
|
SYNOPSIS
|
|
|
|
mysql_frm_type()
|
|
|
|
path path to file
|
|
|
|
|
|
|
|
RETURN
|
|
|
|
FRMTYPE_ERROR error
|
|
|
|
FRMTYPE_TABLE table
|
|
|
|
FRMTYPE_VIEW view
|
|
|
|
*/
|
|
|
|
|
2005-12-21 19:18:40 +01:00
|
|
|
frm_type_enum mysql_frm_type(THD *thd, char *path, enum legacy_db_type *dbt)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
|
|
|
File file;
|
2005-11-03 15:10:11 +01:00
|
|
|
uchar header[10]; //"TYPE=VIEW\n" it is 10 characters
|
|
|
|
int error;
|
2004-07-16 00:15:55 +02:00
|
|
|
DBUG_ENTER("mysql_frm_type");
|
|
|
|
|
2005-11-03 15:10:11 +01:00
|
|
|
*dbt= DB_TYPE_UNKNOWN;
|
|
|
|
|
2005-09-18 21:43:28 +02:00
|
|
|
if ((file= my_open(path, O_RDONLY | O_SHARE, MYF(0))) < 0)
|
2004-07-16 00:15:55 +02:00
|
|
|
DBUG_RETURN(FRMTYPE_ERROR);
|
2005-11-03 15:10:11 +01:00
|
|
|
error= my_read(file, (byte*) header, sizeof(header), MYF(MY_WME | MY_NABP));
|
2004-07-16 00:15:55 +02:00
|
|
|
my_close(file, MYF(MY_WME));
|
2005-11-03 15:10:11 +01:00
|
|
|
|
|
|
|
if (error)
|
2004-09-03 20:43:04 +02:00
|
|
|
DBUG_RETURN(FRMTYPE_ERROR);
|
2005-11-03 15:10:11 +01:00
|
|
|
if (!strncmp((char*) header, "TYPE=VIEW\n", sizeof(header)))
|
2004-09-03 20:43:04 +02:00
|
|
|
DBUG_RETURN(FRMTYPE_VIEW);
|
2005-11-03 15:10:11 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
This is just a check for DB_TYPE. We'll return default unknown type
|
|
|
|
if the following test is true (arg #3). This should not have effect
|
|
|
|
on return value from this function (default FRMTYPE_TABLE)
|
|
|
|
*/
|
|
|
|
if (header[0] != (uchar) 254 || header[1] != 1 ||
|
|
|
|
(header[2] != FRM_VER && header[2] != FRM_VER+1 &&
|
|
|
|
(header[2] < FRM_VER+3 || header[2] > FRM_VER+4)))
|
|
|
|
DBUG_RETURN(FRMTYPE_TABLE);
|
|
|
|
|
2005-12-21 19:18:40 +01:00
|
|
|
*dbt= (enum legacy_db_type) (uint) *(header + 3);
|
2004-09-03 20:43:04 +02:00
|
|
|
DBUG_RETURN(FRMTYPE_TABLE); // Is probably a .frm table
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
check of key (primary or unique) presence in updatable view
|
|
|
|
|
|
|
|
SYNOPSIS
|
|
|
|
check_key_in_view()
|
|
|
|
thd thread handler
|
|
|
|
view view for check with opened table
|
|
|
|
|
2004-10-07 00:45:06 +02:00
|
|
|
DESCRIPTION
|
This changeset is largely a handler cleanup changeset (WL#3281), but includes fixes and cleanups that was found necessary while testing the handler changes
Changes that requires code changes in other code of other storage engines.
(Note that all changes are very straightforward and one should find all issues
by compiling a --debug build and fixing all compiler errors and all
asserts in field.cc while running the test suite),
- New optional handler function introduced: reset()
This is called after every DML statement to make it easy for a handler to
statement specific cleanups.
(The only case it's not called is if force the file to be closed)
- handler::extra(HA_EXTRA_RESET) is removed. Code that was there before
should be moved to handler::reset()
- table->read_set contains a bitmap over all columns that are needed
in the query. read_row() and similar functions only needs to read these
columns
- table->write_set contains a bitmap over all columns that will be updated
in the query. write_row() and update_row() only needs to update these
columns.
The above bitmaps should now be up to date in all context
(including ALTER TABLE, filesort()).
The handler is informed of any changes to the bitmap after
fix_fields() by calling the virtual function
handler::column_bitmaps_signal(). If the handler does caching of
these bitmaps (instead of using table->read_set, table->write_set),
it should redo the caching in this code. as the signal() may be sent
several times, it's probably best to set a variable in the signal
and redo the caching on read_row() / write_row() if the variable was
set.
- Removed the read_set and write_set bitmap objects from the handler class
- Removed all column bit handling functions from the handler class.
(Now one instead uses the normal bitmap functions in my_bitmap.c instead
of handler dedicated bitmap functions)
- field->query_id is removed. One should instead instead check
table->read_set and table->write_set if a field is used in the query.
- handler::extra(HA_EXTRA_RETRIVE_ALL_COLS) and
handler::extra(HA_EXTRA_RETRIEVE_PRIMARY_KEY) are removed. One should now
instead use table->read_set to check for which columns to retrieve.
- If a handler needs to call Field->val() or Field->store() on columns
that are not used in the query, one should install a temporary
all-columns-used map while doing so. For this, we provide the following
functions:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->read_set);
field->val();
dbug_tmp_restore_column_map(table->read_set, old_map);
and similar for the write map:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->write_set);
field->val();
dbug_tmp_restore_column_map(table->write_set, old_map);
If this is not done, you will sooner or later hit a DBUG_ASSERT
in the field store() / val() functions.
(For not DBUG binaries, the dbug_tmp_restore_column_map() and
dbug_tmp_restore_column_map() are inline dummy functions and should
be optimized away be the compiler).
- If one needs to temporary set the column map for all binaries (and not
just to avoid the DBUG_ASSERT() in the Field::store() / Field::val()
methods) one should use the functions tmp_use_all_columns() and
tmp_restore_column_map() instead of the above dbug_ variants.
- All 'status' fields in the handler base class (like records,
data_file_length etc) are now stored in a 'stats' struct. This makes
it easier to know what status variables are provided by the base
handler. This requires some trivial variable names in the extra()
function.
- New virtual function handler::records(). This is called to optimize
COUNT(*) if (handler::table_flags() & HA_HAS_RECORDS()) is true.
(stats.records is not supposed to be an exact value. It's only has to
be 'reasonable enough' for the optimizer to be able to choose a good
optimization path).
- Non virtual handler::init() function added for caching of virtual
constants from engine.
- Removed has_transactions() virtual method. Now one should instead return
HA_NO_TRANSACTIONS in table_flags() if the table handler DOES NOT support
transactions.
- The 'xxxx_create_handler()' function now has a MEM_ROOT_root argument
that is to be used with 'new handler_name()' to allocate the handler
in the right area. The xxxx_create_handler() function is also
responsible for any initialization of the object before returning.
For example, one should change:
static handler *myisam_create_handler(TABLE_SHARE *table)
{
return new ha_myisam(table);
}
->
static handler *myisam_create_handler(TABLE_SHARE *table, MEM_ROOT *mem_root)
{
return new (mem_root) ha_myisam(table);
}
- New optional virtual function: use_hidden_primary_key().
This is called in case of an update/delete when
(table_flags() and HA_PRIMARY_KEY_REQUIRED_FOR_DELETE) is defined
but we don't have a primary key. This allows the handler to take precisions
in remembering any hidden primary key to able to update/delete any
found row. The default handler marks all columns to be read.
- handler::table_flags() now returns a ulonglong (to allow for more flags).
- New/changed table_flags()
- HA_HAS_RECORDS Set if ::records() is supported
- HA_NO_TRANSACTIONS Set if engine doesn't support transactions
- HA_PRIMARY_KEY_REQUIRED_FOR_DELETE
Set if we should mark all primary key columns for
read when reading rows as part of a DELETE
statement. If there is no primary key,
all columns are marked for read.
- HA_PARTIAL_COLUMN_READ Set if engine will not read all columns in some
cases (based on table->read_set)
- HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS
Renamed to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
- HA_DUPP_POS Renamed to HA_DUPLICATE_POS
- HA_REQUIRES_KEY_COLUMNS_FOR_DELETE
Set this if we should mark ALL key columns for
read when when reading rows as part of a DELETE
statement. In case of an update we will mark
all keys for read for which key part changed
value.
- HA_STATS_RECORDS_IS_EXACT
Set this if stats.records is exact.
(This saves us some extra records() calls
when optimizing COUNT(*))
- Removed table_flags()
- HA_NOT_EXACT_COUNT Now one should instead use HA_HAS_RECORDS if
handler::records() gives an exact count() and
HA_STATS_RECORDS_IS_EXACT if stats.records is exact.
- HA_READ_RND_SAME Removed (no one supported this one)
- Removed not needed functions ha_retrieve_all_cols() and ha_retrieve_all_pk()
- Renamed handler::dupp_pos to handler::dup_pos
- Removed not used variable handler::sortkey
Upper level handler changes:
- ha_reset() now does some overall checks and calls ::reset()
- ha_table_flags() added. This is a cached version of table_flags(). The
cache is updated on engine creation time and updated on open.
MySQL level changes (not obvious from the above):
- DBUG_ASSERT() added to check that column usage matches what is set
in the column usage bit maps. (This found a LOT of bugs in current
column marking code).
- In 5.1 before, all used columns was marked in read_set and only updated
columns was marked in write_set. Now we only mark columns for which we
need a value in read_set.
- Column bitmaps are created in open_binary_frm() and open_table_from_share().
(Before this was in table.cc)
- handler::table_flags() calls are replaced with handler::ha_table_flags()
- For calling field->val() you must have the corresponding bit set in
table->read_set. For calling field->store() you must have the
corresponding bit set in table->write_set. (There are asserts in
all store()/val() functions to catch wrong usage)
- thd->set_query_id is renamed to thd->mark_used_columns and instead
of setting this to an integer value, this has now the values:
MARK_COLUMNS_NONE, MARK_COLUMNS_READ, MARK_COLUMNS_WRITE
Changed also all variables named 'set_query_id' to mark_used_columns.
- In filesort() we now inform the handler of exactly which columns are needed
doing the sort and choosing the rows.
- The TABLE_SHARE object has a 'all_set' column bitmap one can use
when one needs a column bitmap with all columns set.
(This is used for table->use_all_columns() and other places)
- The TABLE object has 3 column bitmaps:
- def_read_set Default bitmap for columns to be read
- def_write_set Default bitmap for columns to be written
- tmp_set Can be used as a temporary bitmap when needed.
The table object has also two pointer to bitmaps read_set and write_set
that the handler should use to find out which columns are used in which way.
- count() optimization now calls handler::records() instead of using
handler->stats.records (if (table_flags() & HA_HAS_RECORDS) is true).
- Added extra argument to Item::walk() to indicate if we should also
traverse sub queries.
- Added TABLE parameter to cp_buffer_from_ref()
- Don't close tables created with CREATE ... SELECT but keep them in
the table cache. (Faster usage of newly created tables).
New interfaces:
- table->clear_column_bitmaps() to initialize the bitmaps for tables
at start of new statements.
- table->column_bitmaps_set() to set up new column bitmaps and signal
the handler about this.
- table->column_bitmaps_set_no_signal() for some few cases where we need
to setup new column bitmaps but don't signal the handler (as the handler
has already been signaled about these before). Used for the momement
only in opt_range.cc when doing ROR scans.
- table->use_all_columns() to install a bitmap where all columns are marked
as use in the read and the write set.
- table->default_column_bitmaps() to install the normal read and write
column bitmaps, but not signaling the handler about this.
This is mainly used when creating TABLE instances.
- table->mark_columns_needed_for_delete(),
table->mark_columns_needed_for_delete() and
table->mark_columns_needed_for_insert() to allow us to put additional
columns in column usage maps if handler so requires.
(The handler indicates what it neads in handler->table_flags())
- table->prepare_for_position() to allow us to tell handler that it
needs to read primary key parts to be able to store them in
future table->position() calls.
(This replaces the table->file->ha_retrieve_all_pk function)
- table->mark_auto_increment_column() to tell handler are going to update
columns part of any auto_increment key.
- table->mark_columns_used_by_index() to mark all columns that is part of
an index. It will also send extra(HA_EXTRA_KEYREAD) to handler to allow
it to quickly know that it only needs to read colums that are part
of the key. (The handler can also use the column map for detecting this,
but simpler/faster handler can just monitor the extra() call).
- table->mark_columns_used_by_index_no_reset() to in addition to other columns,
also mark all columns that is used by the given key.
- table->restore_column_maps_after_mark_index() to restore to default
column maps after a call to table->mark_columns_used_by_index().
- New item function register_field_in_read_map(), for marking used columns
in table->read_map. Used by filesort() to mark all used columns
- Maintain in TABLE->merge_keys set of all keys that are used in query.
(Simplices some optimization loops)
- Maintain Field->part_of_key_not_clustered which is like Field->part_of_key
but the field in the clustered key is not assumed to be part of all index.
(used in opt_range.cc for faster loops)
- dbug_tmp_use_all_columns(), dbug_tmp_restore_column_map()
tmp_use_all_columns() and tmp_restore_column_map() functions to temporally
mark all columns as usable. The 'dbug_' version is primarily intended
inside a handler when it wants to just call Field:store() & Field::val()
functions, but don't need the column maps set for any other usage.
(ie:: bitmap_is_set() is never called)
- We can't use compare_records() to skip updates for handlers that returns
a partial column set and the read_set doesn't cover all columns in the
write set. The reason for this is that if we have a column marked only for
write we can't in the MySQL level know if the value changed or not.
The reason this worked before was that MySQL marked all to be written
columns as also to be read. The new 'optimal' bitmaps exposed this 'hidden
bug'.
- open_table_from_share() does not anymore setup temporary MEM_ROOT
object as a thread specific variable for the handler. Instead we
send the to-be-used MEMROOT to get_new_handler().
(Simpler, faster code)
Bugs fixed:
- Column marking was not done correctly in a lot of cases.
(ALTER TABLE, when using triggers, auto_increment fields etc)
(Could potentially result in wrong values inserted in table handlers
relying on that the old column maps or field->set_query_id was correct)
Especially when it comes to triggers, there may be cases where the
old code would cause lost/wrong values for NDB and/or InnoDB tables.
- Split thd->options flag OPTION_STATUS_NO_TRANS_UPDATE to two flags:
OPTION_STATUS_NO_TRANS_UPDATE and OPTION_KEEP_LOG.
This allowed me to remove some wrong warnings about:
"Some non-transactional changed tables couldn't be rolled back"
- Fixed handling of INSERT .. SELECT and CREATE ... SELECT that wrongly reset
(thd->options & OPTION_STATUS_NO_TRANS_UPDATE) which caused us to loose
some warnings about
"Some non-transactional changed tables couldn't be rolled back")
- Fixed use of uninitialized memory in ha_ndbcluster.cc::delete_table()
which could cause delete_table to report random failures.
- Fixed core dumps for some tests when running with --debug
- Added missing FN_LIBCHAR in mysql_rm_tmp_tables()
(This has probably caused us to not properly remove temporary files after
crash)
- slow_logs was not properly initialized, which could maybe cause
extra/lost entries in slow log.
- If we get an duplicate row on insert, change column map to read and
write all columns while retrying the operation. This is required by
the definition of REPLACE and also ensures that fields that are only
part of UPDATE are properly handled. This fixed a bug in NDB and
REPLACE where REPLACE wrongly copied some column values from the replaced
row.
- For table handler that doesn't support NULL in keys, we would give an error
when creating a primary key with NULL fields, even after the fields has been
automaticly converted to NOT NULL.
- Creating a primary key on a SPATIAL key, would fail if field was not
declared as NOT NULL.
Cleanups:
- Removed not used condition argument to setup_tables
- Removed not needed item function reset_query_id_processor().
- Field->add_index is removed. Now this is instead maintained in
(field->flags & FIELD_IN_ADD_INDEX)
- Field->fieldnr is removed (use field->field_index instead)
- New argument to filesort() to indicate that it should return a set of
row pointers (not used columns). This allowed me to remove some references
to sql_command in filesort and should also enable us to return column
results in some cases where we couldn't before.
- Changed column bitmap handling in opt_range.cc to be aligned with TABLE
bitmap, which allowed me to use bitmap functions instead of looping over
all fields to create some needed bitmaps. (Faster and smaller code)
- Broke up found too long lines
- Moved some variable declaration at start of function for better code
readability.
- Removed some not used arguments from functions.
(setup_fields(), mysql_prepare_insert_check_table())
- setup_fields() now takes an enum instead of an int for marking columns
usage.
- For internal temporary tables, use handler::write_row(),
handler::delete_row() and handler::update_row() instead of
handler::ha_xxxx() for faster execution.
- Changed some constants to enum's and define's.
- Using separate column read and write sets allows for easier checking
of timestamp field was set by statement.
- Remove calls to free_io_cache() as this is now done automaticly in ha_reset()
- Don't build table->normalized_path as this is now identical to table->path
(after bar's fixes to convert filenames)
- Fixed some missed DBUG_PRINT(.."%lx") to use "0x%lx" to make it easier to
do comparision with the 'convert-dbug-for-diff' tool.
Things left to do in 5.1:
- We wrongly log failed CREATE TABLE ... SELECT in some cases when using
row based logging (as shown by testcase binlog_row_mix_innodb_myisam.result)
Mats has promised to look into this.
- Test that my fix for CREATE TABLE ... SELECT is indeed correct.
(I added several test cases for this, but in this case it's better that
someone else also tests this throughly).
Lars has promosed to do this.
2006-06-04 17:52:22 +02:00
|
|
|
If it is VIEW and query have LIMIT clause then check that underlying
|
|
|
|
table of view contain one of following:
|
2004-10-07 00:45:06 +02:00
|
|
|
1) primary key of underlying table
|
|
|
|
2) unique key underlying table with fields for which NULL value is
|
|
|
|
impossible
|
|
|
|
3) all fields of underlying table
|
|
|
|
|
2004-07-16 00:15:55 +02:00
|
|
|
RETURN
|
|
|
|
FALSE OK
|
|
|
|
TRUE view do not contain key or all fields
|
|
|
|
*/
|
|
|
|
|
|
|
|
bool check_key_in_view(THD *thd, TABLE_LIST *view)
|
|
|
|
{
|
2004-09-03 20:43:04 +02:00
|
|
|
TABLE *table;
|
2005-07-01 06:05:42 +02:00
|
|
|
Field_translator *trans, *end_of_trans;
|
2004-09-03 20:43:04 +02:00
|
|
|
KEY *key_info, *key_info_end;
|
2004-07-16 00:15:55 +02:00
|
|
|
DBUG_ENTER("check_key_in_view");
|
2004-09-03 20:43:04 +02:00
|
|
|
|
2004-10-07 21:54:31 +02:00
|
|
|
/*
|
2004-11-11 20:18:10 +01:00
|
|
|
we do not support updatable UNIONs in VIEW, so we can check just limit of
|
2004-10-07 21:54:31 +02:00
|
|
|
LEX::select_lex
|
|
|
|
*/
|
2005-06-07 12:11:36 +02:00
|
|
|
if ((!view->view && !view->belong_to_view) ||
|
|
|
|
thd->lex->sql_command == SQLCOM_INSERT ||
|
|
|
|
thd->lex->select_lex.select_limit == 0)
|
2004-10-07 11:13:42 +02:00
|
|
|
DBUG_RETURN(FALSE); /* it is normal table or query without LIMIT */
|
2004-09-03 20:43:04 +02:00
|
|
|
table= view->table;
|
2005-08-02 21:54:49 +02:00
|
|
|
view= view->top_table();
|
2004-09-03 20:43:04 +02:00
|
|
|
trans= view->field_translation;
|
2005-01-06 12:00:13 +01:00
|
|
|
key_info_end= (key_info= table->key_info)+ table->s->keys;
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2005-07-01 06:05:42 +02:00
|
|
|
end_of_trans= view->field_translation_end;
|
2004-09-15 22:42:56 +02:00
|
|
|
DBUG_ASSERT(table != 0 && view->field_translation != 0);
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2005-07-01 06:05:42 +02:00
|
|
|
{
|
|
|
|
/*
|
|
|
|
We should be sure that all fields are ready to get keys from them, but
|
|
|
|
this operation should not have influence on Field::query_id, to avoid
|
|
|
|
marking as used fields which are not used
|
|
|
|
*/
|
This changeset is largely a handler cleanup changeset (WL#3281), but includes fixes and cleanups that was found necessary while testing the handler changes
Changes that requires code changes in other code of other storage engines.
(Note that all changes are very straightforward and one should find all issues
by compiling a --debug build and fixing all compiler errors and all
asserts in field.cc while running the test suite),
- New optional handler function introduced: reset()
This is called after every DML statement to make it easy for a handler to
statement specific cleanups.
(The only case it's not called is if force the file to be closed)
- handler::extra(HA_EXTRA_RESET) is removed. Code that was there before
should be moved to handler::reset()
- table->read_set contains a bitmap over all columns that are needed
in the query. read_row() and similar functions only needs to read these
columns
- table->write_set contains a bitmap over all columns that will be updated
in the query. write_row() and update_row() only needs to update these
columns.
The above bitmaps should now be up to date in all context
(including ALTER TABLE, filesort()).
The handler is informed of any changes to the bitmap after
fix_fields() by calling the virtual function
handler::column_bitmaps_signal(). If the handler does caching of
these bitmaps (instead of using table->read_set, table->write_set),
it should redo the caching in this code. as the signal() may be sent
several times, it's probably best to set a variable in the signal
and redo the caching on read_row() / write_row() if the variable was
set.
- Removed the read_set and write_set bitmap objects from the handler class
- Removed all column bit handling functions from the handler class.
(Now one instead uses the normal bitmap functions in my_bitmap.c instead
of handler dedicated bitmap functions)
- field->query_id is removed. One should instead instead check
table->read_set and table->write_set if a field is used in the query.
- handler::extra(HA_EXTRA_RETRIVE_ALL_COLS) and
handler::extra(HA_EXTRA_RETRIEVE_PRIMARY_KEY) are removed. One should now
instead use table->read_set to check for which columns to retrieve.
- If a handler needs to call Field->val() or Field->store() on columns
that are not used in the query, one should install a temporary
all-columns-used map while doing so. For this, we provide the following
functions:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->read_set);
field->val();
dbug_tmp_restore_column_map(table->read_set, old_map);
and similar for the write map:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->write_set);
field->val();
dbug_tmp_restore_column_map(table->write_set, old_map);
If this is not done, you will sooner or later hit a DBUG_ASSERT
in the field store() / val() functions.
(For not DBUG binaries, the dbug_tmp_restore_column_map() and
dbug_tmp_restore_column_map() are inline dummy functions and should
be optimized away be the compiler).
- If one needs to temporary set the column map for all binaries (and not
just to avoid the DBUG_ASSERT() in the Field::store() / Field::val()
methods) one should use the functions tmp_use_all_columns() and
tmp_restore_column_map() instead of the above dbug_ variants.
- All 'status' fields in the handler base class (like records,
data_file_length etc) are now stored in a 'stats' struct. This makes
it easier to know what status variables are provided by the base
handler. This requires some trivial variable names in the extra()
function.
- New virtual function handler::records(). This is called to optimize
COUNT(*) if (handler::table_flags() & HA_HAS_RECORDS()) is true.
(stats.records is not supposed to be an exact value. It's only has to
be 'reasonable enough' for the optimizer to be able to choose a good
optimization path).
- Non virtual handler::init() function added for caching of virtual
constants from engine.
- Removed has_transactions() virtual method. Now one should instead return
HA_NO_TRANSACTIONS in table_flags() if the table handler DOES NOT support
transactions.
- The 'xxxx_create_handler()' function now has a MEM_ROOT_root argument
that is to be used with 'new handler_name()' to allocate the handler
in the right area. The xxxx_create_handler() function is also
responsible for any initialization of the object before returning.
For example, one should change:
static handler *myisam_create_handler(TABLE_SHARE *table)
{
return new ha_myisam(table);
}
->
static handler *myisam_create_handler(TABLE_SHARE *table, MEM_ROOT *mem_root)
{
return new (mem_root) ha_myisam(table);
}
- New optional virtual function: use_hidden_primary_key().
This is called in case of an update/delete when
(table_flags() and HA_PRIMARY_KEY_REQUIRED_FOR_DELETE) is defined
but we don't have a primary key. This allows the handler to take precisions
in remembering any hidden primary key to able to update/delete any
found row. The default handler marks all columns to be read.
- handler::table_flags() now returns a ulonglong (to allow for more flags).
- New/changed table_flags()
- HA_HAS_RECORDS Set if ::records() is supported
- HA_NO_TRANSACTIONS Set if engine doesn't support transactions
- HA_PRIMARY_KEY_REQUIRED_FOR_DELETE
Set if we should mark all primary key columns for
read when reading rows as part of a DELETE
statement. If there is no primary key,
all columns are marked for read.
- HA_PARTIAL_COLUMN_READ Set if engine will not read all columns in some
cases (based on table->read_set)
- HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS
Renamed to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
- HA_DUPP_POS Renamed to HA_DUPLICATE_POS
- HA_REQUIRES_KEY_COLUMNS_FOR_DELETE
Set this if we should mark ALL key columns for
read when when reading rows as part of a DELETE
statement. In case of an update we will mark
all keys for read for which key part changed
value.
- HA_STATS_RECORDS_IS_EXACT
Set this if stats.records is exact.
(This saves us some extra records() calls
when optimizing COUNT(*))
- Removed table_flags()
- HA_NOT_EXACT_COUNT Now one should instead use HA_HAS_RECORDS if
handler::records() gives an exact count() and
HA_STATS_RECORDS_IS_EXACT if stats.records is exact.
- HA_READ_RND_SAME Removed (no one supported this one)
- Removed not needed functions ha_retrieve_all_cols() and ha_retrieve_all_pk()
- Renamed handler::dupp_pos to handler::dup_pos
- Removed not used variable handler::sortkey
Upper level handler changes:
- ha_reset() now does some overall checks and calls ::reset()
- ha_table_flags() added. This is a cached version of table_flags(). The
cache is updated on engine creation time and updated on open.
MySQL level changes (not obvious from the above):
- DBUG_ASSERT() added to check that column usage matches what is set
in the column usage bit maps. (This found a LOT of bugs in current
column marking code).
- In 5.1 before, all used columns was marked in read_set and only updated
columns was marked in write_set. Now we only mark columns for which we
need a value in read_set.
- Column bitmaps are created in open_binary_frm() and open_table_from_share().
(Before this was in table.cc)
- handler::table_flags() calls are replaced with handler::ha_table_flags()
- For calling field->val() you must have the corresponding bit set in
table->read_set. For calling field->store() you must have the
corresponding bit set in table->write_set. (There are asserts in
all store()/val() functions to catch wrong usage)
- thd->set_query_id is renamed to thd->mark_used_columns and instead
of setting this to an integer value, this has now the values:
MARK_COLUMNS_NONE, MARK_COLUMNS_READ, MARK_COLUMNS_WRITE
Changed also all variables named 'set_query_id' to mark_used_columns.
- In filesort() we now inform the handler of exactly which columns are needed
doing the sort and choosing the rows.
- The TABLE_SHARE object has a 'all_set' column bitmap one can use
when one needs a column bitmap with all columns set.
(This is used for table->use_all_columns() and other places)
- The TABLE object has 3 column bitmaps:
- def_read_set Default bitmap for columns to be read
- def_write_set Default bitmap for columns to be written
- tmp_set Can be used as a temporary bitmap when needed.
The table object has also two pointer to bitmaps read_set and write_set
that the handler should use to find out which columns are used in which way.
- count() optimization now calls handler::records() instead of using
handler->stats.records (if (table_flags() & HA_HAS_RECORDS) is true).
- Added extra argument to Item::walk() to indicate if we should also
traverse sub queries.
- Added TABLE parameter to cp_buffer_from_ref()
- Don't close tables created with CREATE ... SELECT but keep them in
the table cache. (Faster usage of newly created tables).
New interfaces:
- table->clear_column_bitmaps() to initialize the bitmaps for tables
at start of new statements.
- table->column_bitmaps_set() to set up new column bitmaps and signal
the handler about this.
- table->column_bitmaps_set_no_signal() for some few cases where we need
to setup new column bitmaps but don't signal the handler (as the handler
has already been signaled about these before). Used for the momement
only in opt_range.cc when doing ROR scans.
- table->use_all_columns() to install a bitmap where all columns are marked
as use in the read and the write set.
- table->default_column_bitmaps() to install the normal read and write
column bitmaps, but not signaling the handler about this.
This is mainly used when creating TABLE instances.
- table->mark_columns_needed_for_delete(),
table->mark_columns_needed_for_delete() and
table->mark_columns_needed_for_insert() to allow us to put additional
columns in column usage maps if handler so requires.
(The handler indicates what it neads in handler->table_flags())
- table->prepare_for_position() to allow us to tell handler that it
needs to read primary key parts to be able to store them in
future table->position() calls.
(This replaces the table->file->ha_retrieve_all_pk function)
- table->mark_auto_increment_column() to tell handler are going to update
columns part of any auto_increment key.
- table->mark_columns_used_by_index() to mark all columns that is part of
an index. It will also send extra(HA_EXTRA_KEYREAD) to handler to allow
it to quickly know that it only needs to read colums that are part
of the key. (The handler can also use the column map for detecting this,
but simpler/faster handler can just monitor the extra() call).
- table->mark_columns_used_by_index_no_reset() to in addition to other columns,
also mark all columns that is used by the given key.
- table->restore_column_maps_after_mark_index() to restore to default
column maps after a call to table->mark_columns_used_by_index().
- New item function register_field_in_read_map(), for marking used columns
in table->read_map. Used by filesort() to mark all used columns
- Maintain in TABLE->merge_keys set of all keys that are used in query.
(Simplices some optimization loops)
- Maintain Field->part_of_key_not_clustered which is like Field->part_of_key
but the field in the clustered key is not assumed to be part of all index.
(used in opt_range.cc for faster loops)
- dbug_tmp_use_all_columns(), dbug_tmp_restore_column_map()
tmp_use_all_columns() and tmp_restore_column_map() functions to temporally
mark all columns as usable. The 'dbug_' version is primarily intended
inside a handler when it wants to just call Field:store() & Field::val()
functions, but don't need the column maps set for any other usage.
(ie:: bitmap_is_set() is never called)
- We can't use compare_records() to skip updates for handlers that returns
a partial column set and the read_set doesn't cover all columns in the
write set. The reason for this is that if we have a column marked only for
write we can't in the MySQL level know if the value changed or not.
The reason this worked before was that MySQL marked all to be written
columns as also to be read. The new 'optimal' bitmaps exposed this 'hidden
bug'.
- open_table_from_share() does not anymore setup temporary MEM_ROOT
object as a thread specific variable for the handler. Instead we
send the to-be-used MEMROOT to get_new_handler().
(Simpler, faster code)
Bugs fixed:
- Column marking was not done correctly in a lot of cases.
(ALTER TABLE, when using triggers, auto_increment fields etc)
(Could potentially result in wrong values inserted in table handlers
relying on that the old column maps or field->set_query_id was correct)
Especially when it comes to triggers, there may be cases where the
old code would cause lost/wrong values for NDB and/or InnoDB tables.
- Split thd->options flag OPTION_STATUS_NO_TRANS_UPDATE to two flags:
OPTION_STATUS_NO_TRANS_UPDATE and OPTION_KEEP_LOG.
This allowed me to remove some wrong warnings about:
"Some non-transactional changed tables couldn't be rolled back"
- Fixed handling of INSERT .. SELECT and CREATE ... SELECT that wrongly reset
(thd->options & OPTION_STATUS_NO_TRANS_UPDATE) which caused us to loose
some warnings about
"Some non-transactional changed tables couldn't be rolled back")
- Fixed use of uninitialized memory in ha_ndbcluster.cc::delete_table()
which could cause delete_table to report random failures.
- Fixed core dumps for some tests when running with --debug
- Added missing FN_LIBCHAR in mysql_rm_tmp_tables()
(This has probably caused us to not properly remove temporary files after
crash)
- slow_logs was not properly initialized, which could maybe cause
extra/lost entries in slow log.
- If we get an duplicate row on insert, change column map to read and
write all columns while retrying the operation. This is required by
the definition of REPLACE and also ensures that fields that are only
part of UPDATE are properly handled. This fixed a bug in NDB and
REPLACE where REPLACE wrongly copied some column values from the replaced
row.
- For table handler that doesn't support NULL in keys, we would give an error
when creating a primary key with NULL fields, even after the fields has been
automaticly converted to NOT NULL.
- Creating a primary key on a SPATIAL key, would fail if field was not
declared as NOT NULL.
Cleanups:
- Removed not used condition argument to setup_tables
- Removed not needed item function reset_query_id_processor().
- Field->add_index is removed. Now this is instead maintained in
(field->flags & FIELD_IN_ADD_INDEX)
- Field->fieldnr is removed (use field->field_index instead)
- New argument to filesort() to indicate that it should return a set of
row pointers (not used columns). This allowed me to remove some references
to sql_command in filesort and should also enable us to return column
results in some cases where we couldn't before.
- Changed column bitmap handling in opt_range.cc to be aligned with TABLE
bitmap, which allowed me to use bitmap functions instead of looping over
all fields to create some needed bitmaps. (Faster and smaller code)
- Broke up found too long lines
- Moved some variable declaration at start of function for better code
readability.
- Removed some not used arguments from functions.
(setup_fields(), mysql_prepare_insert_check_table())
- setup_fields() now takes an enum instead of an int for marking columns
usage.
- For internal temporary tables, use handler::write_row(),
handler::delete_row() and handler::update_row() instead of
handler::ha_xxxx() for faster execution.
- Changed some constants to enum's and define's.
- Using separate column read and write sets allows for easier checking
of timestamp field was set by statement.
- Remove calls to free_io_cache() as this is now done automaticly in ha_reset()
- Don't build table->normalized_path as this is now identical to table->path
(after bar's fixes to convert filenames)
- Fixed some missed DBUG_PRINT(.."%lx") to use "0x%lx" to make it easier to
do comparision with the 'convert-dbug-for-diff' tool.
Things left to do in 5.1:
- We wrongly log failed CREATE TABLE ... SELECT in some cases when using
row based logging (as shown by testcase binlog_row_mix_innodb_myisam.result)
Mats has promised to look into this.
- Test that my fix for CREATE TABLE ... SELECT is indeed correct.
(I added several test cases for this, but in this case it's better that
someone else also tests this throughly).
Lars has promosed to do this.
2006-06-04 17:52:22 +02:00
|
|
|
enum_mark_columns save_mark_used_columns= thd->mark_used_columns;
|
|
|
|
thd->mark_used_columns= MARK_COLUMNS_NONE;
|
|
|
|
DBUG_PRINT("info", ("thd->mark_used_columns: %d", thd->mark_used_columns));
|
2005-07-01 06:05:42 +02:00
|
|
|
for (Field_translator *fld= trans; fld < end_of_trans; fld++)
|
|
|
|
{
|
|
|
|
if (!fld->item->fixed && fld->item->fix_fields(thd, &fld->item))
|
2005-08-12 11:17:27 +02:00
|
|
|
{
|
This changeset is largely a handler cleanup changeset (WL#3281), but includes fixes and cleanups that was found necessary while testing the handler changes
Changes that requires code changes in other code of other storage engines.
(Note that all changes are very straightforward and one should find all issues
by compiling a --debug build and fixing all compiler errors and all
asserts in field.cc while running the test suite),
- New optional handler function introduced: reset()
This is called after every DML statement to make it easy for a handler to
statement specific cleanups.
(The only case it's not called is if force the file to be closed)
- handler::extra(HA_EXTRA_RESET) is removed. Code that was there before
should be moved to handler::reset()
- table->read_set contains a bitmap over all columns that are needed
in the query. read_row() and similar functions only needs to read these
columns
- table->write_set contains a bitmap over all columns that will be updated
in the query. write_row() and update_row() only needs to update these
columns.
The above bitmaps should now be up to date in all context
(including ALTER TABLE, filesort()).
The handler is informed of any changes to the bitmap after
fix_fields() by calling the virtual function
handler::column_bitmaps_signal(). If the handler does caching of
these bitmaps (instead of using table->read_set, table->write_set),
it should redo the caching in this code. as the signal() may be sent
several times, it's probably best to set a variable in the signal
and redo the caching on read_row() / write_row() if the variable was
set.
- Removed the read_set and write_set bitmap objects from the handler class
- Removed all column bit handling functions from the handler class.
(Now one instead uses the normal bitmap functions in my_bitmap.c instead
of handler dedicated bitmap functions)
- field->query_id is removed. One should instead instead check
table->read_set and table->write_set if a field is used in the query.
- handler::extra(HA_EXTRA_RETRIVE_ALL_COLS) and
handler::extra(HA_EXTRA_RETRIEVE_PRIMARY_KEY) are removed. One should now
instead use table->read_set to check for which columns to retrieve.
- If a handler needs to call Field->val() or Field->store() on columns
that are not used in the query, one should install a temporary
all-columns-used map while doing so. For this, we provide the following
functions:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->read_set);
field->val();
dbug_tmp_restore_column_map(table->read_set, old_map);
and similar for the write map:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->write_set);
field->val();
dbug_tmp_restore_column_map(table->write_set, old_map);
If this is not done, you will sooner or later hit a DBUG_ASSERT
in the field store() / val() functions.
(For not DBUG binaries, the dbug_tmp_restore_column_map() and
dbug_tmp_restore_column_map() are inline dummy functions and should
be optimized away be the compiler).
- If one needs to temporary set the column map for all binaries (and not
just to avoid the DBUG_ASSERT() in the Field::store() / Field::val()
methods) one should use the functions tmp_use_all_columns() and
tmp_restore_column_map() instead of the above dbug_ variants.
- All 'status' fields in the handler base class (like records,
data_file_length etc) are now stored in a 'stats' struct. This makes
it easier to know what status variables are provided by the base
handler. This requires some trivial variable names in the extra()
function.
- New virtual function handler::records(). This is called to optimize
COUNT(*) if (handler::table_flags() & HA_HAS_RECORDS()) is true.
(stats.records is not supposed to be an exact value. It's only has to
be 'reasonable enough' for the optimizer to be able to choose a good
optimization path).
- Non virtual handler::init() function added for caching of virtual
constants from engine.
- Removed has_transactions() virtual method. Now one should instead return
HA_NO_TRANSACTIONS in table_flags() if the table handler DOES NOT support
transactions.
- The 'xxxx_create_handler()' function now has a MEM_ROOT_root argument
that is to be used with 'new handler_name()' to allocate the handler
in the right area. The xxxx_create_handler() function is also
responsible for any initialization of the object before returning.
For example, one should change:
static handler *myisam_create_handler(TABLE_SHARE *table)
{
return new ha_myisam(table);
}
->
static handler *myisam_create_handler(TABLE_SHARE *table, MEM_ROOT *mem_root)
{
return new (mem_root) ha_myisam(table);
}
- New optional virtual function: use_hidden_primary_key().
This is called in case of an update/delete when
(table_flags() and HA_PRIMARY_KEY_REQUIRED_FOR_DELETE) is defined
but we don't have a primary key. This allows the handler to take precisions
in remembering any hidden primary key to able to update/delete any
found row. The default handler marks all columns to be read.
- handler::table_flags() now returns a ulonglong (to allow for more flags).
- New/changed table_flags()
- HA_HAS_RECORDS Set if ::records() is supported
- HA_NO_TRANSACTIONS Set if engine doesn't support transactions
- HA_PRIMARY_KEY_REQUIRED_FOR_DELETE
Set if we should mark all primary key columns for
read when reading rows as part of a DELETE
statement. If there is no primary key,
all columns are marked for read.
- HA_PARTIAL_COLUMN_READ Set if engine will not read all columns in some
cases (based on table->read_set)
- HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS
Renamed to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
- HA_DUPP_POS Renamed to HA_DUPLICATE_POS
- HA_REQUIRES_KEY_COLUMNS_FOR_DELETE
Set this if we should mark ALL key columns for
read when when reading rows as part of a DELETE
statement. In case of an update we will mark
all keys for read for which key part changed
value.
- HA_STATS_RECORDS_IS_EXACT
Set this if stats.records is exact.
(This saves us some extra records() calls
when optimizing COUNT(*))
- Removed table_flags()
- HA_NOT_EXACT_COUNT Now one should instead use HA_HAS_RECORDS if
handler::records() gives an exact count() and
HA_STATS_RECORDS_IS_EXACT if stats.records is exact.
- HA_READ_RND_SAME Removed (no one supported this one)
- Removed not needed functions ha_retrieve_all_cols() and ha_retrieve_all_pk()
- Renamed handler::dupp_pos to handler::dup_pos
- Removed not used variable handler::sortkey
Upper level handler changes:
- ha_reset() now does some overall checks and calls ::reset()
- ha_table_flags() added. This is a cached version of table_flags(). The
cache is updated on engine creation time and updated on open.
MySQL level changes (not obvious from the above):
- DBUG_ASSERT() added to check that column usage matches what is set
in the column usage bit maps. (This found a LOT of bugs in current
column marking code).
- In 5.1 before, all used columns was marked in read_set and only updated
columns was marked in write_set. Now we only mark columns for which we
need a value in read_set.
- Column bitmaps are created in open_binary_frm() and open_table_from_share().
(Before this was in table.cc)
- handler::table_flags() calls are replaced with handler::ha_table_flags()
- For calling field->val() you must have the corresponding bit set in
table->read_set. For calling field->store() you must have the
corresponding bit set in table->write_set. (There are asserts in
all store()/val() functions to catch wrong usage)
- thd->set_query_id is renamed to thd->mark_used_columns and instead
of setting this to an integer value, this has now the values:
MARK_COLUMNS_NONE, MARK_COLUMNS_READ, MARK_COLUMNS_WRITE
Changed also all variables named 'set_query_id' to mark_used_columns.
- In filesort() we now inform the handler of exactly which columns are needed
doing the sort and choosing the rows.
- The TABLE_SHARE object has a 'all_set' column bitmap one can use
when one needs a column bitmap with all columns set.
(This is used for table->use_all_columns() and other places)
- The TABLE object has 3 column bitmaps:
- def_read_set Default bitmap for columns to be read
- def_write_set Default bitmap for columns to be written
- tmp_set Can be used as a temporary bitmap when needed.
The table object has also two pointer to bitmaps read_set and write_set
that the handler should use to find out which columns are used in which way.
- count() optimization now calls handler::records() instead of using
handler->stats.records (if (table_flags() & HA_HAS_RECORDS) is true).
- Added extra argument to Item::walk() to indicate if we should also
traverse sub queries.
- Added TABLE parameter to cp_buffer_from_ref()
- Don't close tables created with CREATE ... SELECT but keep them in
the table cache. (Faster usage of newly created tables).
New interfaces:
- table->clear_column_bitmaps() to initialize the bitmaps for tables
at start of new statements.
- table->column_bitmaps_set() to set up new column bitmaps and signal
the handler about this.
- table->column_bitmaps_set_no_signal() for some few cases where we need
to setup new column bitmaps but don't signal the handler (as the handler
has already been signaled about these before). Used for the momement
only in opt_range.cc when doing ROR scans.
- table->use_all_columns() to install a bitmap where all columns are marked
as use in the read and the write set.
- table->default_column_bitmaps() to install the normal read and write
column bitmaps, but not signaling the handler about this.
This is mainly used when creating TABLE instances.
- table->mark_columns_needed_for_delete(),
table->mark_columns_needed_for_delete() and
table->mark_columns_needed_for_insert() to allow us to put additional
columns in column usage maps if handler so requires.
(The handler indicates what it neads in handler->table_flags())
- table->prepare_for_position() to allow us to tell handler that it
needs to read primary key parts to be able to store them in
future table->position() calls.
(This replaces the table->file->ha_retrieve_all_pk function)
- table->mark_auto_increment_column() to tell handler are going to update
columns part of any auto_increment key.
- table->mark_columns_used_by_index() to mark all columns that is part of
an index. It will also send extra(HA_EXTRA_KEYREAD) to handler to allow
it to quickly know that it only needs to read colums that are part
of the key. (The handler can also use the column map for detecting this,
but simpler/faster handler can just monitor the extra() call).
- table->mark_columns_used_by_index_no_reset() to in addition to other columns,
also mark all columns that is used by the given key.
- table->restore_column_maps_after_mark_index() to restore to default
column maps after a call to table->mark_columns_used_by_index().
- New item function register_field_in_read_map(), for marking used columns
in table->read_map. Used by filesort() to mark all used columns
- Maintain in TABLE->merge_keys set of all keys that are used in query.
(Simplices some optimization loops)
- Maintain Field->part_of_key_not_clustered which is like Field->part_of_key
but the field in the clustered key is not assumed to be part of all index.
(used in opt_range.cc for faster loops)
- dbug_tmp_use_all_columns(), dbug_tmp_restore_column_map()
tmp_use_all_columns() and tmp_restore_column_map() functions to temporally
mark all columns as usable. The 'dbug_' version is primarily intended
inside a handler when it wants to just call Field:store() & Field::val()
functions, but don't need the column maps set for any other usage.
(ie:: bitmap_is_set() is never called)
- We can't use compare_records() to skip updates for handlers that returns
a partial column set and the read_set doesn't cover all columns in the
write set. The reason for this is that if we have a column marked only for
write we can't in the MySQL level know if the value changed or not.
The reason this worked before was that MySQL marked all to be written
columns as also to be read. The new 'optimal' bitmaps exposed this 'hidden
bug'.
- open_table_from_share() does not anymore setup temporary MEM_ROOT
object as a thread specific variable for the handler. Instead we
send the to-be-used MEMROOT to get_new_handler().
(Simpler, faster code)
Bugs fixed:
- Column marking was not done correctly in a lot of cases.
(ALTER TABLE, when using triggers, auto_increment fields etc)
(Could potentially result in wrong values inserted in table handlers
relying on that the old column maps or field->set_query_id was correct)
Especially when it comes to triggers, there may be cases where the
old code would cause lost/wrong values for NDB and/or InnoDB tables.
- Split thd->options flag OPTION_STATUS_NO_TRANS_UPDATE to two flags:
OPTION_STATUS_NO_TRANS_UPDATE and OPTION_KEEP_LOG.
This allowed me to remove some wrong warnings about:
"Some non-transactional changed tables couldn't be rolled back"
- Fixed handling of INSERT .. SELECT and CREATE ... SELECT that wrongly reset
(thd->options & OPTION_STATUS_NO_TRANS_UPDATE) which caused us to loose
some warnings about
"Some non-transactional changed tables couldn't be rolled back")
- Fixed use of uninitialized memory in ha_ndbcluster.cc::delete_table()
which could cause delete_table to report random failures.
- Fixed core dumps for some tests when running with --debug
- Added missing FN_LIBCHAR in mysql_rm_tmp_tables()
(This has probably caused us to not properly remove temporary files after
crash)
- slow_logs was not properly initialized, which could maybe cause
extra/lost entries in slow log.
- If we get an duplicate row on insert, change column map to read and
write all columns while retrying the operation. This is required by
the definition of REPLACE and also ensures that fields that are only
part of UPDATE are properly handled. This fixed a bug in NDB and
REPLACE where REPLACE wrongly copied some column values from the replaced
row.
- For table handler that doesn't support NULL in keys, we would give an error
when creating a primary key with NULL fields, even after the fields has been
automaticly converted to NOT NULL.
- Creating a primary key on a SPATIAL key, would fail if field was not
declared as NOT NULL.
Cleanups:
- Removed not used condition argument to setup_tables
- Removed not needed item function reset_query_id_processor().
- Field->add_index is removed. Now this is instead maintained in
(field->flags & FIELD_IN_ADD_INDEX)
- Field->fieldnr is removed (use field->field_index instead)
- New argument to filesort() to indicate that it should return a set of
row pointers (not used columns). This allowed me to remove some references
to sql_command in filesort and should also enable us to return column
results in some cases where we couldn't before.
- Changed column bitmap handling in opt_range.cc to be aligned with TABLE
bitmap, which allowed me to use bitmap functions instead of looping over
all fields to create some needed bitmaps. (Faster and smaller code)
- Broke up found too long lines
- Moved some variable declaration at start of function for better code
readability.
- Removed some not used arguments from functions.
(setup_fields(), mysql_prepare_insert_check_table())
- setup_fields() now takes an enum instead of an int for marking columns
usage.
- For internal temporary tables, use handler::write_row(),
handler::delete_row() and handler::update_row() instead of
handler::ha_xxxx() for faster execution.
- Changed some constants to enum's and define's.
- Using separate column read and write sets allows for easier checking
of timestamp field was set by statement.
- Remove calls to free_io_cache() as this is now done automaticly in ha_reset()
- Don't build table->normalized_path as this is now identical to table->path
(after bar's fixes to convert filenames)
- Fixed some missed DBUG_PRINT(.."%lx") to use "0x%lx" to make it easier to
do comparision with the 'convert-dbug-for-diff' tool.
Things left to do in 5.1:
- We wrongly log failed CREATE TABLE ... SELECT in some cases when using
row based logging (as shown by testcase binlog_row_mix_innodb_myisam.result)
Mats has promised to look into this.
- Test that my fix for CREATE TABLE ... SELECT is indeed correct.
(I added several test cases for this, but in this case it's better that
someone else also tests this throughly).
Lars has promosed to do this.
2006-06-04 17:52:22 +02:00
|
|
|
thd->mark_used_columns= save_mark_used_columns;
|
2005-07-01 06:05:42 +02:00
|
|
|
return TRUE;
|
2005-08-12 11:17:27 +02:00
|
|
|
}
|
2005-07-01 06:05:42 +02:00
|
|
|
}
|
This changeset is largely a handler cleanup changeset (WL#3281), but includes fixes and cleanups that was found necessary while testing the handler changes
Changes that requires code changes in other code of other storage engines.
(Note that all changes are very straightforward and one should find all issues
by compiling a --debug build and fixing all compiler errors and all
asserts in field.cc while running the test suite),
- New optional handler function introduced: reset()
This is called after every DML statement to make it easy for a handler to
statement specific cleanups.
(The only case it's not called is if force the file to be closed)
- handler::extra(HA_EXTRA_RESET) is removed. Code that was there before
should be moved to handler::reset()
- table->read_set contains a bitmap over all columns that are needed
in the query. read_row() and similar functions only needs to read these
columns
- table->write_set contains a bitmap over all columns that will be updated
in the query. write_row() and update_row() only needs to update these
columns.
The above bitmaps should now be up to date in all context
(including ALTER TABLE, filesort()).
The handler is informed of any changes to the bitmap after
fix_fields() by calling the virtual function
handler::column_bitmaps_signal(). If the handler does caching of
these bitmaps (instead of using table->read_set, table->write_set),
it should redo the caching in this code. as the signal() may be sent
several times, it's probably best to set a variable in the signal
and redo the caching on read_row() / write_row() if the variable was
set.
- Removed the read_set and write_set bitmap objects from the handler class
- Removed all column bit handling functions from the handler class.
(Now one instead uses the normal bitmap functions in my_bitmap.c instead
of handler dedicated bitmap functions)
- field->query_id is removed. One should instead instead check
table->read_set and table->write_set if a field is used in the query.
- handler::extra(HA_EXTRA_RETRIVE_ALL_COLS) and
handler::extra(HA_EXTRA_RETRIEVE_PRIMARY_KEY) are removed. One should now
instead use table->read_set to check for which columns to retrieve.
- If a handler needs to call Field->val() or Field->store() on columns
that are not used in the query, one should install a temporary
all-columns-used map while doing so. For this, we provide the following
functions:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->read_set);
field->val();
dbug_tmp_restore_column_map(table->read_set, old_map);
and similar for the write map:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->write_set);
field->val();
dbug_tmp_restore_column_map(table->write_set, old_map);
If this is not done, you will sooner or later hit a DBUG_ASSERT
in the field store() / val() functions.
(For not DBUG binaries, the dbug_tmp_restore_column_map() and
dbug_tmp_restore_column_map() are inline dummy functions and should
be optimized away be the compiler).
- If one needs to temporary set the column map for all binaries (and not
just to avoid the DBUG_ASSERT() in the Field::store() / Field::val()
methods) one should use the functions tmp_use_all_columns() and
tmp_restore_column_map() instead of the above dbug_ variants.
- All 'status' fields in the handler base class (like records,
data_file_length etc) are now stored in a 'stats' struct. This makes
it easier to know what status variables are provided by the base
handler. This requires some trivial variable names in the extra()
function.
- New virtual function handler::records(). This is called to optimize
COUNT(*) if (handler::table_flags() & HA_HAS_RECORDS()) is true.
(stats.records is not supposed to be an exact value. It's only has to
be 'reasonable enough' for the optimizer to be able to choose a good
optimization path).
- Non virtual handler::init() function added for caching of virtual
constants from engine.
- Removed has_transactions() virtual method. Now one should instead return
HA_NO_TRANSACTIONS in table_flags() if the table handler DOES NOT support
transactions.
- The 'xxxx_create_handler()' function now has a MEM_ROOT_root argument
that is to be used with 'new handler_name()' to allocate the handler
in the right area. The xxxx_create_handler() function is also
responsible for any initialization of the object before returning.
For example, one should change:
static handler *myisam_create_handler(TABLE_SHARE *table)
{
return new ha_myisam(table);
}
->
static handler *myisam_create_handler(TABLE_SHARE *table, MEM_ROOT *mem_root)
{
return new (mem_root) ha_myisam(table);
}
- New optional virtual function: use_hidden_primary_key().
This is called in case of an update/delete when
(table_flags() and HA_PRIMARY_KEY_REQUIRED_FOR_DELETE) is defined
but we don't have a primary key. This allows the handler to take precisions
in remembering any hidden primary key to able to update/delete any
found row. The default handler marks all columns to be read.
- handler::table_flags() now returns a ulonglong (to allow for more flags).
- New/changed table_flags()
- HA_HAS_RECORDS Set if ::records() is supported
- HA_NO_TRANSACTIONS Set if engine doesn't support transactions
- HA_PRIMARY_KEY_REQUIRED_FOR_DELETE
Set if we should mark all primary key columns for
read when reading rows as part of a DELETE
statement. If there is no primary key,
all columns are marked for read.
- HA_PARTIAL_COLUMN_READ Set if engine will not read all columns in some
cases (based on table->read_set)
- HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS
Renamed to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
- HA_DUPP_POS Renamed to HA_DUPLICATE_POS
- HA_REQUIRES_KEY_COLUMNS_FOR_DELETE
Set this if we should mark ALL key columns for
read when when reading rows as part of a DELETE
statement. In case of an update we will mark
all keys for read for which key part changed
value.
- HA_STATS_RECORDS_IS_EXACT
Set this if stats.records is exact.
(This saves us some extra records() calls
when optimizing COUNT(*))
- Removed table_flags()
- HA_NOT_EXACT_COUNT Now one should instead use HA_HAS_RECORDS if
handler::records() gives an exact count() and
HA_STATS_RECORDS_IS_EXACT if stats.records is exact.
- HA_READ_RND_SAME Removed (no one supported this one)
- Removed not needed functions ha_retrieve_all_cols() and ha_retrieve_all_pk()
- Renamed handler::dupp_pos to handler::dup_pos
- Removed not used variable handler::sortkey
Upper level handler changes:
- ha_reset() now does some overall checks and calls ::reset()
- ha_table_flags() added. This is a cached version of table_flags(). The
cache is updated on engine creation time and updated on open.
MySQL level changes (not obvious from the above):
- DBUG_ASSERT() added to check that column usage matches what is set
in the column usage bit maps. (This found a LOT of bugs in current
column marking code).
- In 5.1 before, all used columns was marked in read_set and only updated
columns was marked in write_set. Now we only mark columns for which we
need a value in read_set.
- Column bitmaps are created in open_binary_frm() and open_table_from_share().
(Before this was in table.cc)
- handler::table_flags() calls are replaced with handler::ha_table_flags()
- For calling field->val() you must have the corresponding bit set in
table->read_set. For calling field->store() you must have the
corresponding bit set in table->write_set. (There are asserts in
all store()/val() functions to catch wrong usage)
- thd->set_query_id is renamed to thd->mark_used_columns and instead
of setting this to an integer value, this has now the values:
MARK_COLUMNS_NONE, MARK_COLUMNS_READ, MARK_COLUMNS_WRITE
Changed also all variables named 'set_query_id' to mark_used_columns.
- In filesort() we now inform the handler of exactly which columns are needed
doing the sort and choosing the rows.
- The TABLE_SHARE object has a 'all_set' column bitmap one can use
when one needs a column bitmap with all columns set.
(This is used for table->use_all_columns() and other places)
- The TABLE object has 3 column bitmaps:
- def_read_set Default bitmap for columns to be read
- def_write_set Default bitmap for columns to be written
- tmp_set Can be used as a temporary bitmap when needed.
The table object has also two pointer to bitmaps read_set and write_set
that the handler should use to find out which columns are used in which way.
- count() optimization now calls handler::records() instead of using
handler->stats.records (if (table_flags() & HA_HAS_RECORDS) is true).
- Added extra argument to Item::walk() to indicate if we should also
traverse sub queries.
- Added TABLE parameter to cp_buffer_from_ref()
- Don't close tables created with CREATE ... SELECT but keep them in
the table cache. (Faster usage of newly created tables).
New interfaces:
- table->clear_column_bitmaps() to initialize the bitmaps for tables
at start of new statements.
- table->column_bitmaps_set() to set up new column bitmaps and signal
the handler about this.
- table->column_bitmaps_set_no_signal() for some few cases where we need
to setup new column bitmaps but don't signal the handler (as the handler
has already been signaled about these before). Used for the momement
only in opt_range.cc when doing ROR scans.
- table->use_all_columns() to install a bitmap where all columns are marked
as use in the read and the write set.
- table->default_column_bitmaps() to install the normal read and write
column bitmaps, but not signaling the handler about this.
This is mainly used when creating TABLE instances.
- table->mark_columns_needed_for_delete(),
table->mark_columns_needed_for_delete() and
table->mark_columns_needed_for_insert() to allow us to put additional
columns in column usage maps if handler so requires.
(The handler indicates what it neads in handler->table_flags())
- table->prepare_for_position() to allow us to tell handler that it
needs to read primary key parts to be able to store them in
future table->position() calls.
(This replaces the table->file->ha_retrieve_all_pk function)
- table->mark_auto_increment_column() to tell handler are going to update
columns part of any auto_increment key.
- table->mark_columns_used_by_index() to mark all columns that is part of
an index. It will also send extra(HA_EXTRA_KEYREAD) to handler to allow
it to quickly know that it only needs to read colums that are part
of the key. (The handler can also use the column map for detecting this,
but simpler/faster handler can just monitor the extra() call).
- table->mark_columns_used_by_index_no_reset() to in addition to other columns,
also mark all columns that is used by the given key.
- table->restore_column_maps_after_mark_index() to restore to default
column maps after a call to table->mark_columns_used_by_index().
- New item function register_field_in_read_map(), for marking used columns
in table->read_map. Used by filesort() to mark all used columns
- Maintain in TABLE->merge_keys set of all keys that are used in query.
(Simplices some optimization loops)
- Maintain Field->part_of_key_not_clustered which is like Field->part_of_key
but the field in the clustered key is not assumed to be part of all index.
(used in opt_range.cc for faster loops)
- dbug_tmp_use_all_columns(), dbug_tmp_restore_column_map()
tmp_use_all_columns() and tmp_restore_column_map() functions to temporally
mark all columns as usable. The 'dbug_' version is primarily intended
inside a handler when it wants to just call Field:store() & Field::val()
functions, but don't need the column maps set for any other usage.
(ie:: bitmap_is_set() is never called)
- We can't use compare_records() to skip updates for handlers that returns
a partial column set and the read_set doesn't cover all columns in the
write set. The reason for this is that if we have a column marked only for
write we can't in the MySQL level know if the value changed or not.
The reason this worked before was that MySQL marked all to be written
columns as also to be read. The new 'optimal' bitmaps exposed this 'hidden
bug'.
- open_table_from_share() does not anymore setup temporary MEM_ROOT
object as a thread specific variable for the handler. Instead we
send the to-be-used MEMROOT to get_new_handler().
(Simpler, faster code)
Bugs fixed:
- Column marking was not done correctly in a lot of cases.
(ALTER TABLE, when using triggers, auto_increment fields etc)
(Could potentially result in wrong values inserted in table handlers
relying on that the old column maps or field->set_query_id was correct)
Especially when it comes to triggers, there may be cases where the
old code would cause lost/wrong values for NDB and/or InnoDB tables.
- Split thd->options flag OPTION_STATUS_NO_TRANS_UPDATE to two flags:
OPTION_STATUS_NO_TRANS_UPDATE and OPTION_KEEP_LOG.
This allowed me to remove some wrong warnings about:
"Some non-transactional changed tables couldn't be rolled back"
- Fixed handling of INSERT .. SELECT and CREATE ... SELECT that wrongly reset
(thd->options & OPTION_STATUS_NO_TRANS_UPDATE) which caused us to loose
some warnings about
"Some non-transactional changed tables couldn't be rolled back")
- Fixed use of uninitialized memory in ha_ndbcluster.cc::delete_table()
which could cause delete_table to report random failures.
- Fixed core dumps for some tests when running with --debug
- Added missing FN_LIBCHAR in mysql_rm_tmp_tables()
(This has probably caused us to not properly remove temporary files after
crash)
- slow_logs was not properly initialized, which could maybe cause
extra/lost entries in slow log.
- If we get an duplicate row on insert, change column map to read and
write all columns while retrying the operation. This is required by
the definition of REPLACE and also ensures that fields that are only
part of UPDATE are properly handled. This fixed a bug in NDB and
REPLACE where REPLACE wrongly copied some column values from the replaced
row.
- For table handler that doesn't support NULL in keys, we would give an error
when creating a primary key with NULL fields, even after the fields has been
automaticly converted to NOT NULL.
- Creating a primary key on a SPATIAL key, would fail if field was not
declared as NOT NULL.
Cleanups:
- Removed not used condition argument to setup_tables
- Removed not needed item function reset_query_id_processor().
- Field->add_index is removed. Now this is instead maintained in
(field->flags & FIELD_IN_ADD_INDEX)
- Field->fieldnr is removed (use field->field_index instead)
- New argument to filesort() to indicate that it should return a set of
row pointers (not used columns). This allowed me to remove some references
to sql_command in filesort and should also enable us to return column
results in some cases where we couldn't before.
- Changed column bitmap handling in opt_range.cc to be aligned with TABLE
bitmap, which allowed me to use bitmap functions instead of looping over
all fields to create some needed bitmaps. (Faster and smaller code)
- Broke up found too long lines
- Moved some variable declaration at start of function for better code
readability.
- Removed some not used arguments from functions.
(setup_fields(), mysql_prepare_insert_check_table())
- setup_fields() now takes an enum instead of an int for marking columns
usage.
- For internal temporary tables, use handler::write_row(),
handler::delete_row() and handler::update_row() instead of
handler::ha_xxxx() for faster execution.
- Changed some constants to enum's and define's.
- Using separate column read and write sets allows for easier checking
of timestamp field was set by statement.
- Remove calls to free_io_cache() as this is now done automaticly in ha_reset()
- Don't build table->normalized_path as this is now identical to table->path
(after bar's fixes to convert filenames)
- Fixed some missed DBUG_PRINT(.."%lx") to use "0x%lx" to make it easier to
do comparision with the 'convert-dbug-for-diff' tool.
Things left to do in 5.1:
- We wrongly log failed CREATE TABLE ... SELECT in some cases when using
row based logging (as shown by testcase binlog_row_mix_innodb_myisam.result)
Mats has promised to look into this.
- Test that my fix for CREATE TABLE ... SELECT is indeed correct.
(I added several test cases for this, but in this case it's better that
someone else also tests this throughly).
Lars has promosed to do this.
2006-06-04 17:52:22 +02:00
|
|
|
thd->mark_used_columns= save_mark_used_columns;
|
|
|
|
DBUG_PRINT("info", ("thd->mark_used_columns: %d", thd->mark_used_columns));
|
2005-07-01 06:05:42 +02:00
|
|
|
}
|
2004-09-03 20:43:04 +02:00
|
|
|
/* Loop over all keys to see if a unique-not-null key is used */
|
|
|
|
for (;key_info != key_info_end ; key_info++)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-09-03 20:43:04 +02:00
|
|
|
if ((key_info->flags & (HA_NOSAME | HA_NULL_PART_KEY)) == HA_NOSAME)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
|
|
|
KEY_PART_INFO *key_part= key_info->key_part;
|
2004-09-03 20:43:04 +02:00
|
|
|
KEY_PART_INFO *key_part_end= key_part + key_info->key_parts;
|
|
|
|
|
|
|
|
/* check that all key parts are used */
|
|
|
|
for (;;)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2005-07-01 06:05:42 +02:00
|
|
|
Field_translator *k;
|
|
|
|
for (k= trans; k < end_of_trans; k++)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-09-16 22:45:20 +02:00
|
|
|
Item_field *field;
|
2005-07-01 06:05:42 +02:00
|
|
|
if ((field= k->item->filed_for_view_update()) &&
|
2004-09-16 22:45:20 +02:00
|
|
|
field->field == key_part->field)
|
2004-07-16 00:15:55 +02:00
|
|
|
break;
|
|
|
|
}
|
2005-07-01 06:05:42 +02:00
|
|
|
if (k == end_of_trans)
|
2004-09-03 20:43:04 +02:00
|
|
|
break; // Key is not possible
|
|
|
|
if (++key_part == key_part_end)
|
|
|
|
DBUG_RETURN(FALSE); // Found usable key
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2004-09-03 20:43:04 +02:00
|
|
|
DBUG_PRINT("info", ("checking if all fields of table are used"));
|
2004-07-16 00:15:55 +02:00
|
|
|
/* check all fields presence */
|
|
|
|
{
|
2004-09-03 20:43:04 +02:00
|
|
|
Field **field_ptr;
|
2005-07-01 06:05:42 +02:00
|
|
|
Field_translator *fld;
|
2004-09-03 20:43:04 +02:00
|
|
|
for (field_ptr= table->field; *field_ptr; field_ptr++)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2005-07-01 06:05:42 +02:00
|
|
|
for (fld= trans; fld < end_of_trans; fld++)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-09-16 22:45:20 +02:00
|
|
|
Item_field *field;
|
2005-07-01 06:05:42 +02:00
|
|
|
if ((field= fld->item->filed_for_view_update()) &&
|
2004-09-16 22:45:20 +02:00
|
|
|
field->field == *field_ptr)
|
2004-07-16 00:15:55 +02:00
|
|
|
break;
|
|
|
|
}
|
2005-07-01 06:05:42 +02:00
|
|
|
if (fld == end_of_trans) // If field didn't exists
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-09-03 20:43:04 +02:00
|
|
|
/*
|
2005-07-01 06:05:42 +02:00
|
|
|
Keys or all fields of underlying tables are not found => we have
|
2004-10-07 11:13:42 +02:00
|
|
|
to check variable updatable_views_with_limit to decide should we
|
|
|
|
issue an error or just a warning
|
2004-09-03 20:43:04 +02:00
|
|
|
*/
|
2004-10-07 11:13:42 +02:00
|
|
|
if (thd->variables.updatable_views_with_limit)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-10-07 11:13:42 +02:00
|
|
|
/* update allowed, but issue warning */
|
|
|
|
push_warning(thd, MYSQL_ERROR::WARN_LEVEL_NOTE,
|
|
|
|
ER_WARN_VIEW_WITHOUT_KEY, ER(ER_WARN_VIEW_WITHOUT_KEY));
|
|
|
|
DBUG_RETURN(FALSE);
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
2004-10-07 11:13:42 +02:00
|
|
|
/* prohibit update */
|
|
|
|
DBUG_RETURN(TRUE);
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
DBUG_RETURN(FALSE);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
insert fields from VIEW (MERGE algorithm) into given list
|
|
|
|
|
|
|
|
SYNOPSIS
|
|
|
|
insert_view_fields()
|
2005-07-01 06:05:42 +02:00
|
|
|
thd thread handler
|
2004-07-16 00:15:55 +02:00
|
|
|
list list for insertion
|
|
|
|
view view for processing
|
2004-09-15 22:42:56 +02:00
|
|
|
|
|
|
|
RETURN
|
2004-11-25 01:23:13 +01:00
|
|
|
FALSE OK
|
|
|
|
TRUE error (is not sent to cliet)
|
2004-07-16 00:15:55 +02:00
|
|
|
*/
|
|
|
|
|
2005-07-01 06:05:42 +02:00
|
|
|
bool insert_view_fields(THD *thd, List<Item> *list, TABLE_LIST *view)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2005-07-01 06:05:42 +02:00
|
|
|
Field_translator *trans_end;
|
2004-09-14 18:28:29 +02:00
|
|
|
Field_translator *trans;
|
2004-07-16 00:15:55 +02:00
|
|
|
DBUG_ENTER("insert_view_fields");
|
2004-09-03 20:43:04 +02:00
|
|
|
|
|
|
|
if (!(trans= view->field_translation))
|
2004-11-25 01:23:13 +01:00
|
|
|
DBUG_RETURN(FALSE);
|
2005-07-01 06:05:42 +02:00
|
|
|
trans_end= view->field_translation_end;
|
2004-07-16 00:15:55 +02:00
|
|
|
|
2005-07-01 06:05:42 +02:00
|
|
|
for (Field_translator *entry= trans; entry < trans_end; entry++)
|
2004-07-16 00:15:55 +02:00
|
|
|
{
|
2004-09-16 22:45:20 +02:00
|
|
|
Item_field *fld;
|
2005-07-01 06:05:42 +02:00
|
|
|
if ((fld= entry->item->filed_for_view_update()))
|
2004-09-16 22:45:20 +02:00
|
|
|
list->push_back(fld);
|
2004-09-15 22:42:56 +02:00
|
|
|
else
|
|
|
|
{
|
2006-09-28 23:00:18 +02:00
|
|
|
my_error(ER_NON_INSERTABLE_TABLE, MYF(0), view->alias, "INSERT");
|
2004-11-25 01:23:13 +01:00
|
|
|
DBUG_RETURN(TRUE);
|
2004-09-15 22:42:56 +02:00
|
|
|
}
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
2004-11-25 01:23:13 +01:00
|
|
|
DBUG_RETURN(FALSE);
|
2004-07-16 00:15:55 +02:00
|
|
|
}
|
2004-10-28 18:37:25 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
checking view md5 check suum
|
|
|
|
|
|
|
|
SINOPSYS
|
|
|
|
view_checksum()
|
|
|
|
thd threar handler
|
|
|
|
view view for check
|
|
|
|
|
|
|
|
RETUIRN
|
|
|
|
HA_ADMIN_OK OK
|
|
|
|
HA_ADMIN_NOT_IMPLEMENTED it is not VIEW
|
|
|
|
HA_ADMIN_WRONG_CHECKSUM check sum is wrong
|
|
|
|
*/
|
|
|
|
|
|
|
|
int view_checksum(THD *thd, TABLE_LIST *view)
|
|
|
|
{
|
|
|
|
char md5[MD5_BUFF_LENGTH];
|
|
|
|
if (!view->view || view->md5.length != 32)
|
|
|
|
return HA_ADMIN_NOT_IMPLEMENTED;
|
|
|
|
view->calc_md5(md5);
|
|
|
|
return (strncmp(md5, view->md5.str, 32) ?
|
|
|
|
HA_ADMIN_WRONG_CHECKSUM :
|
|
|
|
HA_ADMIN_OK);
|
|
|
|
}
|
2005-09-16 17:13:21 +02:00
|
|
|
|
2005-09-18 21:43:28 +02:00
|
|
|
/*
|
|
|
|
rename view
|
2005-09-16 17:13:21 +02:00
|
|
|
|
2005-09-18 21:43:28 +02:00
|
|
|
Synopsis:
|
|
|
|
renames a view
|
2005-09-16 17:13:21 +02:00
|
|
|
|
2005-09-18 21:43:28 +02:00
|
|
|
Parameters:
|
|
|
|
thd thread handler
|
|
|
|
new_name new name of view
|
|
|
|
view view
|
2005-09-16 17:13:21 +02:00
|
|
|
|
2005-09-18 21:43:28 +02:00
|
|
|
Return values:
|
|
|
|
FALSE Ok
|
|
|
|
TRUE Error
|
|
|
|
*/
|
2005-09-16 17:13:21 +02:00
|
|
|
bool
|
|
|
|
mysql_rename_view(THD *thd,
|
2005-09-29 12:29:58 +02:00
|
|
|
const char *new_name,
|
|
|
|
TABLE_LIST *view)
|
2005-09-16 17:13:21 +02:00
|
|
|
{
|
2006-10-16 19:42:03 +02:00
|
|
|
LEX_STRING pathstr;
|
2005-09-16 17:13:21 +02:00
|
|
|
File_parser *parser;
|
2006-10-16 19:42:03 +02:00
|
|
|
char path_buff[FN_REFLEN];
|
2005-09-29 12:29:58 +02:00
|
|
|
bool error= TRUE;
|
2005-09-16 17:13:21 +02:00
|
|
|
DBUG_ENTER("mysql_rename_view");
|
|
|
|
|
2006-10-16 19:42:03 +02:00
|
|
|
pathstr.str= (char *) path_buff;
|
|
|
|
pathstr.length= build_table_filename(path_buff, sizeof(path_buff) - 1,
|
|
|
|
view->db, view->table_name,
|
|
|
|
reg_ext, 0);
|
2005-09-16 17:13:21 +02:00
|
|
|
|
|
|
|
if ((parser= sql_parse_prepare(&pathstr, thd->mem_root, 1)) &&
|
2005-09-29 12:29:58 +02:00
|
|
|
is_equal(&view_type, parser->type()))
|
|
|
|
{
|
2005-09-30 15:30:33 +02:00
|
|
|
TABLE_LIST view_def;
|
2006-10-16 19:42:03 +02:00
|
|
|
char dir_buff[FN_REFLEN];
|
|
|
|
LEX_STRING dir, file;
|
2005-09-16 17:13:21 +02:00
|
|
|
|
2005-09-30 15:30:33 +02:00
|
|
|
/*
|
|
|
|
To be PS-friendly we should either to restore state of
|
|
|
|
TABLE_LIST object pointed by 'view' after using it for
|
|
|
|
view definition parsing or use temporary 'view_def'
|
|
|
|
object for it.
|
|
|
|
*/
|
|
|
|
bzero(&view_def, sizeof(view_def));
|
|
|
|
view_def.timestamp.str= view_def.timestamp_buffer;
|
|
|
|
view_def.view_suid= TRUE;
|
|
|
|
|
2005-09-16 17:13:21 +02:00
|
|
|
/* get view definition and source */
|
2005-09-30 15:30:33 +02:00
|
|
|
if (parser->parse((gptr)&view_def, thd->mem_root, view_parameters,
|
2005-11-20 19:47:07 +01:00
|
|
|
array_elements(view_parameters)-1,
|
|
|
|
&file_parser_dummy_hook))
|
2005-09-29 12:29:58 +02:00
|
|
|
goto err;
|
2005-09-16 17:13:21 +02:00
|
|
|
|
|
|
|
/* rename view and it's backups */
|
2005-09-18 21:43:28 +02:00
|
|
|
if (rename_in_schema_file(view->db, view->table_name, new_name,
|
2005-09-30 15:30:33 +02:00
|
|
|
view_def.revision - 1, num_view_backups))
|
2005-09-29 12:29:58 +02:00
|
|
|
goto err;
|
2005-09-16 17:13:21 +02:00
|
|
|
|
2006-10-16 19:42:03 +02:00
|
|
|
dir.str= dir_buff;
|
|
|
|
dir.length= build_table_filename(dir_buff, sizeof(dir_buff) - 1,
|
|
|
|
view->db, "", "", 0);
|
2005-09-16 17:13:21 +02:00
|
|
|
|
2006-10-16 19:42:03 +02:00
|
|
|
pathstr.str= path_buff;
|
|
|
|
pathstr.length= build_table_filename(path_buff, sizeof(path_buff) - 1,
|
|
|
|
view->db, new_name, reg_ext, 0);
|
2005-09-16 17:13:21 +02:00
|
|
|
|
2006-10-16 19:42:03 +02:00
|
|
|
file.str= pathstr.str + dir.length;
|
|
|
|
file.length= pathstr.length - dir.length;
|
2005-09-16 17:13:21 +02:00
|
|
|
|
2006-10-16 19:42:03 +02:00
|
|
|
if (sql_create_definition_file(&dir, &file, view_file_type,
|
2005-09-30 15:30:33 +02:00
|
|
|
(gptr)&view_def, view_parameters,
|
2005-09-29 12:29:58 +02:00
|
|
|
num_view_backups))
|
|
|
|
{
|
2005-09-16 17:13:21 +02:00
|
|
|
/* restore renamed view in case of error */
|
2005-09-18 21:43:28 +02:00
|
|
|
rename_in_schema_file(view->db, new_name, view->table_name,
|
2005-09-30 15:30:33 +02:00
|
|
|
view_def.revision - 1, num_view_backups);
|
2005-09-29 12:29:58 +02:00
|
|
|
goto err;
|
2005-09-16 17:13:21 +02:00
|
|
|
}
|
|
|
|
} else
|
|
|
|
DBUG_RETURN(1);
|
|
|
|
|
|
|
|
/* remove cache entries */
|
|
|
|
query_cache_invalidate3(thd, view, 0);
|
|
|
|
sp_cache_invalidate();
|
2005-09-29 12:29:58 +02:00
|
|
|
error= FALSE;
|
|
|
|
|
|
|
|
err:
|
|
|
|
DBUG_RETURN(error);
|
2005-09-16 17:13:21 +02:00
|
|
|
}
|