2011-06-30 17:46:53 +02:00
|
|
|
/* Copyright (c) 2002, 2010, Oracle and/or its affiliates. All rights reserved.
|
2009-12-22 10:35:56 +01:00
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program; if not, write to the Free Software
|
2019-05-11 20:29:06 +02:00
|
|
|
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1335 USA */
|
2009-12-22 10:35:56 +01:00
|
|
|
|
2017-06-18 05:42:16 +02:00
|
|
|
#include "mariadb.h"
|
2009-12-22 10:35:56 +01:00
|
|
|
#include "keycaches.h"
|
|
|
|
|
|
|
|
/****************************************************************************
|
|
|
|
Named list handling
|
|
|
|
****************************************************************************/
|
|
|
|
|
|
|
|
NAMED_ILIST key_caches;
|
2013-04-16 13:43:28 +02:00
|
|
|
NAMED_ILIST rpl_filters;
|
2009-12-22 10:35:56 +01:00
|
|
|
|
2020-01-29 13:50:26 +01:00
|
|
|
extern "C" PSI_memory_key key_memory_KEY_CACHE;
|
|
|
|
extern PSI_memory_key key_memory_NAMED_ILINK_name;
|
|
|
|
|
2009-12-22 10:35:56 +01:00
|
|
|
/**
|
|
|
|
ilink (intrusive list element) with a name
|
|
|
|
*/
|
|
|
|
class NAMED_ILINK :public ilink
|
|
|
|
{
|
|
|
|
public:
|
|
|
|
const char *name;
|
2018-02-06 13:55:58 +01:00
|
|
|
size_t name_length;
|
2009-12-22 10:35:56 +01:00
|
|
|
uchar* data;
|
|
|
|
|
|
|
|
NAMED_ILINK(I_List<NAMED_ILINK> *links, const char *name_arg,
|
2018-02-06 13:55:58 +01:00
|
|
|
size_t name_length_arg, uchar* data_arg)
|
2009-12-22 10:35:56 +01:00
|
|
|
:name_length(name_length_arg), data(data_arg)
|
|
|
|
{
|
2020-01-29 13:50:26 +01:00
|
|
|
name= my_strndup(key_memory_NAMED_ILINK_name, name_arg, name_length,
|
|
|
|
MYF(MY_WME));
|
2009-12-22 10:35:56 +01:00
|
|
|
links->push_back(this);
|
|
|
|
}
|
2018-02-06 13:55:58 +01:00
|
|
|
inline bool cmp(const char *name_cmp, size_t length)
|
2009-12-22 10:35:56 +01:00
|
|
|
{
|
|
|
|
return length == name_length && !memcmp(name, name_cmp, length);
|
|
|
|
}
|
2024-06-12 15:46:26 +02:00
|
|
|
~NAMED_ILINK() override
|
2009-12-22 10:35:56 +01:00
|
|
|
{
|
Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled
Essentially, the problem is that safemalloc is excruciatingly
slow as it checks all allocated blocks for overrun at each
memory management primitive, yielding a almost exponential
slowdown for the memory management functions (malloc, realloc,
free). The overrun check basically consists of verifying some
bytes of a block for certain magic keys, which catches some
simple forms of overrun. Another minor problem is violation
of aliasing rules and that its own internal list of blocks
is prone to corruption.
Another issue with safemalloc is rather the maintenance cost
as the tool has a significant impact on the server code.
Given the magnitude of memory debuggers available nowadays,
especially those that are provided with the platform malloc
implementation, maintenance of a in-house and largely obsolete
memory debugger becomes a burden that is not worth the effort
due to its slowness and lack of support for detecting more
common forms of heap corruption.
Since there are third-party tools that can provide the same
functionality at a lower or comparable performance cost, the
solution is to simply remove safemalloc. Third-party tools
can provide the same functionality at a lower or comparable
performance cost.
The removal of safemalloc also allows a simplification of the
malloc wrappers, removing quite a bit of kludge: redefinition
of my_malloc, my_free and the removal of the unused second
argument of my_free. Since free() always check whether the
supplied pointer is null, redudant checks are also removed.
Also, this patch adds unit testing for my_malloc and moves
my_realloc implementation into the same file as the other
memory allocation primitives.
client/mysqldump.c:
Pass my_free directly as its signature is compatible with the
callback type -- which wasn't the case for free_table_ent.
2010-07-08 23:20:08 +02:00
|
|
|
my_free((void *) name);
|
2009-12-22 10:35:56 +01:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2018-02-06 13:55:58 +01:00
|
|
|
uchar* find_named(I_List<NAMED_ILINK> *list, const char *name, size_t length,
|
2009-12-22 10:35:56 +01:00
|
|
|
NAMED_ILINK **found)
|
|
|
|
{
|
|
|
|
I_List_iterator<NAMED_ILINK> it(*list);
|
|
|
|
NAMED_ILINK *element;
|
|
|
|
while ((element= it++))
|
|
|
|
{
|
|
|
|
if (element->cmp(name, length))
|
|
|
|
{
|
|
|
|
if (found)
|
|
|
|
*found= element;
|
|
|
|
return element->data;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2019-10-18 08:05:27 +02:00
|
|
|
bool NAMED_ILIST::delete_element(const char *name, size_t length, void (*free_element)(const char *name, void*))
|
2013-04-16 13:43:28 +02:00
|
|
|
{
|
|
|
|
I_List_iterator<NAMED_ILINK> it(*this);
|
|
|
|
NAMED_ILINK *element;
|
|
|
|
DBUG_ENTER("NAMED_ILIST::delete_element");
|
|
|
|
while ((element= it++))
|
|
|
|
{
|
|
|
|
if (element->cmp(name, length))
|
|
|
|
{
|
|
|
|
(*free_element)(element->name, element->data);
|
|
|
|
delete element;
|
|
|
|
DBUG_RETURN(0);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
DBUG_RETURN(1);
|
|
|
|
}
|
|
|
|
|
2019-10-09 02:09:48 +02:00
|
|
|
void NAMED_ILIST::delete_elements(void (*free_element)(const char *name, void*))
|
2009-12-22 10:35:56 +01:00
|
|
|
{
|
|
|
|
NAMED_ILINK *element;
|
|
|
|
DBUG_ENTER("NAMED_ILIST::delete_elements");
|
|
|
|
while ((element= get()))
|
|
|
|
{
|
|
|
|
(*free_element)(element->name, element->data);
|
|
|
|
delete element;
|
|
|
|
}
|
|
|
|
DBUG_VOID_RETURN;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* Key cache functions */
|
|
|
|
|
2018-01-08 14:33:23 +01:00
|
|
|
LEX_CSTRING default_key_cache_base= {STRING_WITH_LEN("default")};
|
2009-12-22 10:35:56 +01:00
|
|
|
|
|
|
|
KEY_CACHE zero_key_cache; ///< @@nonexistent_cache.param->value_ptr() points here
|
|
|
|
|
2017-04-23 18:39:57 +02:00
|
|
|
KEY_CACHE *get_key_cache(const LEX_CSTRING *cache_name)
|
2009-12-22 10:35:56 +01:00
|
|
|
{
|
|
|
|
if (!cache_name || ! cache_name->length)
|
|
|
|
cache_name= &default_key_cache_base;
|
|
|
|
return ((KEY_CACHE*) find_named(&key_caches,
|
|
|
|
cache_name->str, cache_name->length, 0));
|
|
|
|
}
|
|
|
|
|
2018-02-06 13:55:58 +01:00
|
|
|
KEY_CACHE *create_key_cache(const char *name, size_t length)
|
2009-12-22 10:35:56 +01:00
|
|
|
{
|
|
|
|
KEY_CACHE *key_cache;
|
|
|
|
DBUG_ENTER("create_key_cache");
|
2018-02-06 13:55:58 +01:00
|
|
|
DBUG_PRINT("enter",("name: %.*s", (int)length, name));
|
2009-12-22 10:35:56 +01:00
|
|
|
|
2020-01-29 13:50:26 +01:00
|
|
|
if ((key_cache= (KEY_CACHE*) my_malloc(key_memory_KEY_CACHE,
|
|
|
|
sizeof(KEY_CACHE), MYF(MY_ZEROFILL | MY_WME))))
|
2009-12-22 10:35:56 +01:00
|
|
|
{
|
|
|
|
if (!new NAMED_ILINK(&key_caches, name, length, (uchar*) key_cache))
|
|
|
|
{
|
Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled
Essentially, the problem is that safemalloc is excruciatingly
slow as it checks all allocated blocks for overrun at each
memory management primitive, yielding a almost exponential
slowdown for the memory management functions (malloc, realloc,
free). The overrun check basically consists of verifying some
bytes of a block for certain magic keys, which catches some
simple forms of overrun. Another minor problem is violation
of aliasing rules and that its own internal list of blocks
is prone to corruption.
Another issue with safemalloc is rather the maintenance cost
as the tool has a significant impact on the server code.
Given the magnitude of memory debuggers available nowadays,
especially those that are provided with the platform malloc
implementation, maintenance of a in-house and largely obsolete
memory debugger becomes a burden that is not worth the effort
due to its slowness and lack of support for detecting more
common forms of heap corruption.
Since there are third-party tools that can provide the same
functionality at a lower or comparable performance cost, the
solution is to simply remove safemalloc. Third-party tools
can provide the same functionality at a lower or comparable
performance cost.
The removal of safemalloc also allows a simplification of the
malloc wrappers, removing quite a bit of kludge: redefinition
of my_malloc, my_free and the removal of the unused second
argument of my_free. Since free() always check whether the
supplied pointer is null, redudant checks are also removed.
Also, this patch adds unit testing for my_malloc and moves
my_realloc implementation into the same file as the other
memory allocation primitives.
client/mysqldump.c:
Pass my_free directly as its signature is compatible with the
callback type -- which wasn't the case for free_table_ent.
2010-07-08 23:20:08 +02:00
|
|
|
my_free(key_cache);
|
2009-12-22 10:35:56 +01:00
|
|
|
key_cache= 0;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
Set default values for a key cache
|
|
|
|
The values in dflt_key_cache_var is set by my_getopt() at startup
|
|
|
|
|
|
|
|
We don't set 'buff_size' as this is used to enable the key cache
|
|
|
|
*/
|
|
|
|
key_cache->param_block_size= dflt_key_cache_var.param_block_size;
|
|
|
|
key_cache->param_division_limit= dflt_key_cache_var.param_division_limit;
|
|
|
|
key_cache->param_age_threshold= dflt_key_cache_var.param_age_threshold;
|
2010-11-26 12:22:40 +01:00
|
|
|
key_cache->param_partitions= dflt_key_cache_var.param_partitions;
|
2009-12-22 10:35:56 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
DBUG_RETURN(key_cache);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2018-02-06 13:55:58 +01:00
|
|
|
KEY_CACHE *get_or_create_key_cache(const char *name, size_t length)
|
2009-12-22 10:35:56 +01:00
|
|
|
{
|
2017-04-23 18:39:57 +02:00
|
|
|
LEX_CSTRING key_cache_name;
|
2009-12-22 10:35:56 +01:00
|
|
|
KEY_CACHE *key_cache;
|
|
|
|
|
2017-04-23 18:39:57 +02:00
|
|
|
key_cache_name.str= name;
|
2009-12-22 10:35:56 +01:00
|
|
|
key_cache_name.length= length;
|
|
|
|
if (!(key_cache= get_key_cache(&key_cache_name)))
|
|
|
|
key_cache= create_key_cache(name, length);
|
|
|
|
return key_cache;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2019-10-09 02:09:48 +02:00
|
|
|
void free_key_cache(const char *name, void *key_cache)
|
2009-12-22 10:35:56 +01:00
|
|
|
{
|
2019-10-09 02:09:48 +02:00
|
|
|
end_key_cache(static_cast<KEY_CACHE *>(key_cache), 1); // Can never fail
|
Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled
Essentially, the problem is that safemalloc is excruciatingly
slow as it checks all allocated blocks for overrun at each
memory management primitive, yielding a almost exponential
slowdown for the memory management functions (malloc, realloc,
free). The overrun check basically consists of verifying some
bytes of a block for certain magic keys, which catches some
simple forms of overrun. Another minor problem is violation
of aliasing rules and that its own internal list of blocks
is prone to corruption.
Another issue with safemalloc is rather the maintenance cost
as the tool has a significant impact on the server code.
Given the magnitude of memory debuggers available nowadays,
especially those that are provided with the platform malloc
implementation, maintenance of a in-house and largely obsolete
memory debugger becomes a burden that is not worth the effort
due to its slowness and lack of support for detecting more
common forms of heap corruption.
Since there are third-party tools that can provide the same
functionality at a lower or comparable performance cost, the
solution is to simply remove safemalloc. Third-party tools
can provide the same functionality at a lower or comparable
performance cost.
The removal of safemalloc also allows a simplification of the
malloc wrappers, removing quite a bit of kludge: redefinition
of my_malloc, my_free and the removal of the unused second
argument of my_free. Since free() always check whether the
supplied pointer is null, redudant checks are also removed.
Also, this patch adds unit testing for my_malloc and moves
my_realloc implementation into the same file as the other
memory allocation primitives.
client/mysqldump.c:
Pass my_free directly as its signature is compatible with the
callback type -- which wasn't the case for free_table_ent.
2010-07-08 23:20:08 +02:00
|
|
|
my_free(key_cache);
|
2009-12-22 10:35:56 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-04-25 17:22:25 +02:00
|
|
|
bool process_key_caches(process_key_cache_t func, void *param)
|
2009-12-22 10:35:56 +01:00
|
|
|
{
|
|
|
|
I_List_iterator<NAMED_ILINK> it(key_caches);
|
|
|
|
NAMED_ILINK *element;
|
2011-04-25 17:22:25 +02:00
|
|
|
int res= 0;
|
2009-12-22 10:35:56 +01:00
|
|
|
|
|
|
|
while ((element= it++))
|
|
|
|
{
|
|
|
|
KEY_CACHE *key_cache= (KEY_CACHE *) element->data;
|
2011-04-25 17:22:25 +02:00
|
|
|
res |= func(element->name, key_cache, param);
|
2009-12-22 10:35:56 +01:00
|
|
|
}
|
2011-04-25 17:22:25 +02:00
|
|
|
return res != 0;
|
2009-12-22 10:35:56 +01:00
|
|
|
}
|
|
|
|
|
2013-04-16 13:43:28 +02:00
|
|
|
/* Rpl_filter functions */
|
|
|
|
|
2018-01-08 14:33:23 +01:00
|
|
|
LEX_CSTRING default_rpl_filter_base= {STRING_WITH_LEN("")};
|
2013-04-16 13:43:28 +02:00
|
|
|
|
2018-01-08 14:33:23 +01:00
|
|
|
Rpl_filter *get_rpl_filter(LEX_CSTRING *filter_name)
|
2013-04-16 13:43:28 +02:00
|
|
|
{
|
|
|
|
if (!filter_name->length)
|
|
|
|
filter_name= &default_rpl_filter_base;
|
|
|
|
return ((Rpl_filter*) find_named(&rpl_filters,
|
|
|
|
filter_name->str, filter_name->length, 0));
|
|
|
|
}
|
|
|
|
|
2018-02-06 13:55:58 +01:00
|
|
|
Rpl_filter *create_rpl_filter(const char *name, size_t length)
|
2013-04-16 13:43:28 +02:00
|
|
|
{
|
|
|
|
Rpl_filter *filter;
|
|
|
|
DBUG_ENTER("create_rpl_filter");
|
2018-02-06 13:55:58 +01:00
|
|
|
DBUG_PRINT("enter",("name: %.*s", (int)length, name));
|
2013-04-16 13:43:28 +02:00
|
|
|
|
|
|
|
filter= new Rpl_filter;
|
|
|
|
if (filter)
|
|
|
|
{
|
|
|
|
if (!new NAMED_ILINK(&rpl_filters, name, length, (uchar*) filter))
|
|
|
|
{
|
|
|
|
delete filter;
|
|
|
|
filter= 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
DBUG_RETURN(filter);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2018-02-06 13:55:58 +01:00
|
|
|
Rpl_filter *get_or_create_rpl_filter(const char *name, size_t length)
|
2013-04-16 13:43:28 +02:00
|
|
|
{
|
2018-01-08 14:33:23 +01:00
|
|
|
LEX_CSTRING rpl_filter_name;
|
2013-04-16 13:43:28 +02:00
|
|
|
Rpl_filter *filter;
|
|
|
|
|
|
|
|
rpl_filter_name.str= (char *) name;
|
|
|
|
rpl_filter_name.length= length;
|
|
|
|
if (!(filter= get_rpl_filter(&rpl_filter_name)))
|
|
|
|
filter= create_rpl_filter(name, length);
|
|
|
|
return filter;
|
|
|
|
}
|
|
|
|
|
2019-10-09 02:09:48 +02:00
|
|
|
void free_rpl_filter(const char *name, void *filter)
|
2013-04-16 13:43:28 +02:00
|
|
|
{
|
2019-10-09 02:09:48 +02:00
|
|
|
delete static_cast<Rpl_filter*>(filter);
|
2013-04-16 13:43:28 +02:00
|
|
|
}
|
|
|
|
|
2013-04-17 21:33:33 +02:00
|
|
|
void free_all_rpl_filters()
|
|
|
|
{
|
2019-10-09 02:09:48 +02:00
|
|
|
rpl_filters.delete_elements(free_rpl_filter);
|
2013-04-17 21:33:33 +02:00
|
|
|
}
|