2009-12-22 10:35:56 +01:00
|
|
|
#
|
|
|
|
# mysqld --help
|
|
|
|
#
|
|
|
|
--source include/not_embedded.inc
|
2021-03-17 10:35:04 +01:00
|
|
|
--source include/not_asan.inc
|
Fix all warnings given by UBSAN
The easiest way to compile and test the server with UBSAN is to run:
./BUILD/compile-pentium64-ubsan
and then run mysql-test-run.
After this commit, one should be able to run this without any UBSAN
warnings. There is still a few compiler warnings that should be fixed
at some point, but these do not expose any real bugs.
The 'special' cases where we disable, suppress or circumvent UBSAN are:
- ref10 source (as here we intentionally do some shifts that UBSAN
complains about.
- x86 version of optimized int#korr() methods. UBSAN do not like unaligned
memory access of integers. Fixed by using byte_order_generic.h when
compiling with UBSAN
- We use smaller thread stack with ASAN and UBSAN, which forced me to
disable a few tests that prints the thread stack size.
- Verifying class types does not work for shared libraries. I added
suppression in mysql-test-run.pl for this case.
- Added '#ifdef WITH_UBSAN' when using integer arithmetic where it is
safe to have overflows (two cases, in item_func.cc).
Things fixed:
- Don't left shift signed values
(byte_order_generic.h, mysqltest.c, item_sum.cc and many more)
- Don't assign not non existing values to enum variables.
- Ensure that bool and enum values are properly initialized in
constructors. This was needed as UBSAN checks that these types has
correct values when one copies an object.
(gcalc_tools.h, ha_partition.cc, item_sum.cc, partition_element.h ...)
- Ensure we do not called handler functions on unallocated objects or
deleted objects.
(events.cc, sql_acl.cc).
- Fixed bugs in Item_sp::Item_sp() where we did not call constructor
on Query_arena object.
- Fixed several cast of objects to an incompatible class!
(Item.cc, Item_buff.cc, item_timefunc.cc, opt_subselect.cc, sql_acl.cc,
sql_select.cc ...)
- Ensure we do not do integer arithmetic that causes over or underflows.
This includes also ++ and -- of integers.
(Item_func.cc, Item_strfunc.cc, item_timefunc.cc, sql_base.cc ...)
- Added JSON_VALUE_UNITIALIZED to json_value_types and ensure that
value_type is initialized to this instead of to -1, which is not a valid
enum value for json_value_types.
- Ensure we do not call memcpy() when second argument could be null.
- Fixed that Item_func_str::make_empty_result() creates an empty string
instead of a null string (safer as it ensures we do not do arithmetic
on null strings).
Other things:
- Changed struct st_position to an OBJECT and added an initialization
function to it to ensure that we do not copy or use uninitialized
members. The change to a class was also motived that we used "struct
st_position" and POSITION randomly trough the code which was
confusing.
- Notably big rewrite in sql_acl.cc to avoid using deleted objects.
- Changed in sql_partition to use '^' instead of '-'. This is safe as
the operator is either 0 or 0x8000000000000000ULL.
- Added check for select_nr < INT_MAX in JOIN::build_explain() to
avoid bug when get_select() could return NULL.
- Reordered elements in POSITION for better alignment.
- Changed sql_test.cc::print_plan() to use pointers instead of objects.
- Fixed bug in find_set() where could could execute '1 << -1'.
- Added variable have_sanitizer, used by mtr. (This variable was before
only in 10.5 and up). It can now have one of two values:
ASAN or UBSAN.
- Moved ~Archive_share() from ha_archive.cc to ha_archive.h and marked
it virtual. This was an effort to get UBSAN to work with loaded storage
engines. I kept the change as the new place is better.
- Added in CONNECT engine COLBLK::SetName(), to get around a wrong cast
in tabutil.cpp.
- Added HAVE_REPLICATION around usage of rgi_slave, to get embedded
server to compile with UBSAN. (Patch from Marko).
- Added #ifdef for powerpc64 to avoid a bug in old gcc versions related
to integer arithmetic.
Changes that should not be needed but had to be done to suppress warnings
from UBSAN:
- Added static_cast<<uint16_t>> around shift to get rid of a LOT of
compiler warnings when using UBSAN.
- Had to change some '/' of 2 base integers to shift to get rid of
some compile time warnings.
Reviewed by:
- Json changes: Alexey Botchkov
- Charset changes in ctype-uca.c: Alexander Barkov
- InnoDB changes & Embedded server: Marko Mäkelä
- sql_acl.cc changes: Vicențiu Ciorbaru
- build_explain() changes: Sergey Petrunia
2021-04-18 14:29:13 +02:00
|
|
|
--source include/not_ubsan.inc
|
2012-02-23 09:24:11 +01:00
|
|
|
--source include/have_perfschema.inc
|
2017-05-16 13:14:03 +02:00
|
|
|
--source include/have_profiling.inc
|
2012-02-23 09:24:11 +01:00
|
|
|
--source include/platform.inc
|
2009-12-22 10:35:56 +01:00
|
|
|
|
|
|
|
#
|
|
|
|
# force lower-case-table-names=1 (linux/macosx have different defaults)
|
|
|
|
# force symbolic-links=0 (valgrind build has a different default)
|
|
|
|
#
|
2010-09-30 15:52:39 +02:00
|
|
|
|
2009-12-22 10:35:56 +01:00
|
|
|
exec $MYSQLD_BOOTSTRAP_CMD --symbolic-links=0 --lower-case-table-names=1 --help --verbose > $MYSQL_TMP_DIR/mysqld--help.txt 2>&1;
|
|
|
|
|
2010-09-30 15:52:39 +02:00
|
|
|
# The inline perl code below will copy $MYSQL_TMP_DIR/mysqld--help.txt
|
|
|
|
# to output, but filter away some variable stuff (e.g. paths).
|
|
|
|
|
2009-12-22 10:35:56 +01:00
|
|
|
perl;
|
2010-09-30 15:52:39 +02:00
|
|
|
# Variables which we don't want to display in the result file since
|
|
|
|
# their paths may vary:
|
2017-11-24 22:56:13 +01:00
|
|
|
@skipvars=qw/basedir open-files-limit general-log-file log plugin-dir plugin-maturity
|
2011-10-19 21:45:18 +02:00
|
|
|
log-slow-queries pid-file slow-query-log-file log-basename
|
2014-01-02 10:19:19 +01:00
|
|
|
datadir slave-load-tmpdir tmpdir socket thread-pool-size
|
|
|
|
large-files-support lower-case-file-system system-time-zone
|
2020-05-05 11:23:29 +02:00
|
|
|
collation-server character-set-server log-tc-size table-cache
|
2020-08-10 16:57:14 +02:00
|
|
|
table-open-cache table-open-cache-instances max-connections
|
2020-08-10 20:08:46 +02:00
|
|
|
tls-version version.*/;
|
2010-09-30 15:52:39 +02:00
|
|
|
|
|
|
|
# Plugins which may or may not be there:
|
2019-04-15 17:16:02 +02:00
|
|
|
@plugins=qw/innodb archive blackhole federated partition s3
|
2013-04-09 16:19:22 +02:00
|
|
|
feedback debug temp-pool ssl des-key-file xtradb sequence
|
|
|
|
thread-concurrency super-large-pages mutex-deadlock-detector
|
2013-09-21 10:14:42 +02:00
|
|
|
connect null-audit aria oqgraph sphinx thread-handling
|
2019-09-01 15:28:11 +02:00
|
|
|
test-sql-discovery query-cache-info
|
2015-12-21 21:24:22 +01:00
|
|
|
query-response-time metadata-lock-info locales unix-socket
|
2019-05-26 15:55:14 +02:00
|
|
|
wsrep file-key-management cracklib-password-check user-variables
|
|
|
|
thread-pool-groups thread-pool-queues thread-pool-stats thread-pool-waits/;
|
2010-09-30 15:52:39 +02:00
|
|
|
|
|
|
|
# And substitute the content some environment variables with their
|
|
|
|
# names:
|
2011-08-16 11:08:10 +02:00
|
|
|
@env=qw/MYSQLTEST_VARDIR MYSQL_TEST_DIR MYSQL_CHARSETSDIR MYSQL_SHAREDIR/;
|
2010-09-30 15:52:39 +02:00
|
|
|
|
2009-12-22 10:35:56 +01:00
|
|
|
$re1=join('|', @skipvars, @plugins);
|
|
|
|
$re2=join('|', @plugins);
|
|
|
|
$skip=0;
|
|
|
|
open(F, '<', "$ENV{MYSQL_TMP_DIR}/mysqld--help.txt") or die;
|
2019-07-08 18:15:47 +02:00
|
|
|
print "Windows bug: new line disappears when it is exactly at the right offset.\n";
|
2009-12-22 10:35:56 +01:00
|
|
|
while (<F>) {
|
|
|
|
next if 1../The following groups are read/;
|
2010-01-06 18:57:10 +01:00
|
|
|
# formatting, skip line consisting entirely of dashes and blanks
|
2010-05-17 17:28:50 +02:00
|
|
|
next if /^[\- ]+\s?$/;
|
2010-01-06 18:57:10 +01:00
|
|
|
next if /Value \(after reading options\)/; # skip table header
|
2009-12-22 10:35:56 +01:00
|
|
|
next if /^($re1) /;
|
|
|
|
next if /^($re2)-/;
|
2011-07-18 23:04:24 +02:00
|
|
|
$skip=0 if /^ -/ or /^$/;
|
2009-12-22 10:35:56 +01:00
|
|
|
$skip=1 if / --($re2)\b/;
|
2009-12-24 12:30:23 +01:00
|
|
|
y!\\!/!;
|
2010-01-06 18:57:10 +01:00
|
|
|
s/[ ]+/ /; # squeeze spaces to remove table formatting
|
|
|
|
# fixes for 32-bit
|
2009-12-22 10:35:56 +01:00
|
|
|
s/\b4294967295\b/18446744073709551615/;
|
|
|
|
s/\b2146435072\b/9223372036853727232/;
|
2019-03-08 09:21:58 +01:00
|
|
|
s/\b392192\b/299008/;
|
2011-12-02 14:38:05 +01:00
|
|
|
s/\b4294963200\b/18446744073709547520/;
|
2013-11-11 09:31:02 +01:00
|
|
|
foreach $var (@env) { s/\Q$ENV{$var}\E/$var/ }
|
2009-12-22 10:35:56 +01:00
|
|
|
next if /use --skip-(use-)?symbolic-links to disable/; # for valgrind, again
|
|
|
|
next if $skip;
|
|
|
|
print;
|
|
|
|
}
|
|
|
|
close F;
|
|
|
|
EOF
|
|
|
|
|