2004-11-03 11:39:38 +01:00
|
|
|
drop table if exists t1,t2,t3;
|
2001-09-28 07:05:54 +02:00
|
|
|
create table t1 (a int not null);
|
|
|
|
|
insert into t1 values (1);
|
|
|
|
|
insert into t1 values (a+2);
|
This changeset is largely a handler cleanup changeset (WL#3281), but includes fixes and cleanups that was found necessary while testing the handler changes
Changes that requires code changes in other code of other storage engines.
(Note that all changes are very straightforward and one should find all issues
by compiling a --debug build and fixing all compiler errors and all
asserts in field.cc while running the test suite),
- New optional handler function introduced: reset()
This is called after every DML statement to make it easy for a handler to
statement specific cleanups.
(The only case it's not called is if force the file to be closed)
- handler::extra(HA_EXTRA_RESET) is removed. Code that was there before
should be moved to handler::reset()
- table->read_set contains a bitmap over all columns that are needed
in the query. read_row() and similar functions only needs to read these
columns
- table->write_set contains a bitmap over all columns that will be updated
in the query. write_row() and update_row() only needs to update these
columns.
The above bitmaps should now be up to date in all context
(including ALTER TABLE, filesort()).
The handler is informed of any changes to the bitmap after
fix_fields() by calling the virtual function
handler::column_bitmaps_signal(). If the handler does caching of
these bitmaps (instead of using table->read_set, table->write_set),
it should redo the caching in this code. as the signal() may be sent
several times, it's probably best to set a variable in the signal
and redo the caching on read_row() / write_row() if the variable was
set.
- Removed the read_set and write_set bitmap objects from the handler class
- Removed all column bit handling functions from the handler class.
(Now one instead uses the normal bitmap functions in my_bitmap.c instead
of handler dedicated bitmap functions)
- field->query_id is removed. One should instead instead check
table->read_set and table->write_set if a field is used in the query.
- handler::extra(HA_EXTRA_RETRIVE_ALL_COLS) and
handler::extra(HA_EXTRA_RETRIEVE_PRIMARY_KEY) are removed. One should now
instead use table->read_set to check for which columns to retrieve.
- If a handler needs to call Field->val() or Field->store() on columns
that are not used in the query, one should install a temporary
all-columns-used map while doing so. For this, we provide the following
functions:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->read_set);
field->val();
dbug_tmp_restore_column_map(table->read_set, old_map);
and similar for the write map:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->write_set);
field->val();
dbug_tmp_restore_column_map(table->write_set, old_map);
If this is not done, you will sooner or later hit a DBUG_ASSERT
in the field store() / val() functions.
(For not DBUG binaries, the dbug_tmp_restore_column_map() and
dbug_tmp_restore_column_map() are inline dummy functions and should
be optimized away be the compiler).
- If one needs to temporary set the column map for all binaries (and not
just to avoid the DBUG_ASSERT() in the Field::store() / Field::val()
methods) one should use the functions tmp_use_all_columns() and
tmp_restore_column_map() instead of the above dbug_ variants.
- All 'status' fields in the handler base class (like records,
data_file_length etc) are now stored in a 'stats' struct. This makes
it easier to know what status variables are provided by the base
handler. This requires some trivial variable names in the extra()
function.
- New virtual function handler::records(). This is called to optimize
COUNT(*) if (handler::table_flags() & HA_HAS_RECORDS()) is true.
(stats.records is not supposed to be an exact value. It's only has to
be 'reasonable enough' for the optimizer to be able to choose a good
optimization path).
- Non virtual handler::init() function added for caching of virtual
constants from engine.
- Removed has_transactions() virtual method. Now one should instead return
HA_NO_TRANSACTIONS in table_flags() if the table handler DOES NOT support
transactions.
- The 'xxxx_create_handler()' function now has a MEM_ROOT_root argument
that is to be used with 'new handler_name()' to allocate the handler
in the right area. The xxxx_create_handler() function is also
responsible for any initialization of the object before returning.
For example, one should change:
static handler *myisam_create_handler(TABLE_SHARE *table)
{
return new ha_myisam(table);
}
->
static handler *myisam_create_handler(TABLE_SHARE *table, MEM_ROOT *mem_root)
{
return new (mem_root) ha_myisam(table);
}
- New optional virtual function: use_hidden_primary_key().
This is called in case of an update/delete when
(table_flags() and HA_PRIMARY_KEY_REQUIRED_FOR_DELETE) is defined
but we don't have a primary key. This allows the handler to take precisions
in remembering any hidden primary key to able to update/delete any
found row. The default handler marks all columns to be read.
- handler::table_flags() now returns a ulonglong (to allow for more flags).
- New/changed table_flags()
- HA_HAS_RECORDS Set if ::records() is supported
- HA_NO_TRANSACTIONS Set if engine doesn't support transactions
- HA_PRIMARY_KEY_REQUIRED_FOR_DELETE
Set if we should mark all primary key columns for
read when reading rows as part of a DELETE
statement. If there is no primary key,
all columns are marked for read.
- HA_PARTIAL_COLUMN_READ Set if engine will not read all columns in some
cases (based on table->read_set)
- HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS
Renamed to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
- HA_DUPP_POS Renamed to HA_DUPLICATE_POS
- HA_REQUIRES_KEY_COLUMNS_FOR_DELETE
Set this if we should mark ALL key columns for
read when when reading rows as part of a DELETE
statement. In case of an update we will mark
all keys for read for which key part changed
value.
- HA_STATS_RECORDS_IS_EXACT
Set this if stats.records is exact.
(This saves us some extra records() calls
when optimizing COUNT(*))
- Removed table_flags()
- HA_NOT_EXACT_COUNT Now one should instead use HA_HAS_RECORDS if
handler::records() gives an exact count() and
HA_STATS_RECORDS_IS_EXACT if stats.records is exact.
- HA_READ_RND_SAME Removed (no one supported this one)
- Removed not needed functions ha_retrieve_all_cols() and ha_retrieve_all_pk()
- Renamed handler::dupp_pos to handler::dup_pos
- Removed not used variable handler::sortkey
Upper level handler changes:
- ha_reset() now does some overall checks and calls ::reset()
- ha_table_flags() added. This is a cached version of table_flags(). The
cache is updated on engine creation time and updated on open.
MySQL level changes (not obvious from the above):
- DBUG_ASSERT() added to check that column usage matches what is set
in the column usage bit maps. (This found a LOT of bugs in current
column marking code).
- In 5.1 before, all used columns was marked in read_set and only updated
columns was marked in write_set. Now we only mark columns for which we
need a value in read_set.
- Column bitmaps are created in open_binary_frm() and open_table_from_share().
(Before this was in table.cc)
- handler::table_flags() calls are replaced with handler::ha_table_flags()
- For calling field->val() you must have the corresponding bit set in
table->read_set. For calling field->store() you must have the
corresponding bit set in table->write_set. (There are asserts in
all store()/val() functions to catch wrong usage)
- thd->set_query_id is renamed to thd->mark_used_columns and instead
of setting this to an integer value, this has now the values:
MARK_COLUMNS_NONE, MARK_COLUMNS_READ, MARK_COLUMNS_WRITE
Changed also all variables named 'set_query_id' to mark_used_columns.
- In filesort() we now inform the handler of exactly which columns are needed
doing the sort and choosing the rows.
- The TABLE_SHARE object has a 'all_set' column bitmap one can use
when one needs a column bitmap with all columns set.
(This is used for table->use_all_columns() and other places)
- The TABLE object has 3 column bitmaps:
- def_read_set Default bitmap for columns to be read
- def_write_set Default bitmap for columns to be written
- tmp_set Can be used as a temporary bitmap when needed.
The table object has also two pointer to bitmaps read_set and write_set
that the handler should use to find out which columns are used in which way.
- count() optimization now calls handler::records() instead of using
handler->stats.records (if (table_flags() & HA_HAS_RECORDS) is true).
- Added extra argument to Item::walk() to indicate if we should also
traverse sub queries.
- Added TABLE parameter to cp_buffer_from_ref()
- Don't close tables created with CREATE ... SELECT but keep them in
the table cache. (Faster usage of newly created tables).
New interfaces:
- table->clear_column_bitmaps() to initialize the bitmaps for tables
at start of new statements.
- table->column_bitmaps_set() to set up new column bitmaps and signal
the handler about this.
- table->column_bitmaps_set_no_signal() for some few cases where we need
to setup new column bitmaps but don't signal the handler (as the handler
has already been signaled about these before). Used for the momement
only in opt_range.cc when doing ROR scans.
- table->use_all_columns() to install a bitmap where all columns are marked
as use in the read and the write set.
- table->default_column_bitmaps() to install the normal read and write
column bitmaps, but not signaling the handler about this.
This is mainly used when creating TABLE instances.
- table->mark_columns_needed_for_delete(),
table->mark_columns_needed_for_delete() and
table->mark_columns_needed_for_insert() to allow us to put additional
columns in column usage maps if handler so requires.
(The handler indicates what it neads in handler->table_flags())
- table->prepare_for_position() to allow us to tell handler that it
needs to read primary key parts to be able to store them in
future table->position() calls.
(This replaces the table->file->ha_retrieve_all_pk function)
- table->mark_auto_increment_column() to tell handler are going to update
columns part of any auto_increment key.
- table->mark_columns_used_by_index() to mark all columns that is part of
an index. It will also send extra(HA_EXTRA_KEYREAD) to handler to allow
it to quickly know that it only needs to read colums that are part
of the key. (The handler can also use the column map for detecting this,
but simpler/faster handler can just monitor the extra() call).
- table->mark_columns_used_by_index_no_reset() to in addition to other columns,
also mark all columns that is used by the given key.
- table->restore_column_maps_after_mark_index() to restore to default
column maps after a call to table->mark_columns_used_by_index().
- New item function register_field_in_read_map(), for marking used columns
in table->read_map. Used by filesort() to mark all used columns
- Maintain in TABLE->merge_keys set of all keys that are used in query.
(Simplices some optimization loops)
- Maintain Field->part_of_key_not_clustered which is like Field->part_of_key
but the field in the clustered key is not assumed to be part of all index.
(used in opt_range.cc for faster loops)
- dbug_tmp_use_all_columns(), dbug_tmp_restore_column_map()
tmp_use_all_columns() and tmp_restore_column_map() functions to temporally
mark all columns as usable. The 'dbug_' version is primarily intended
inside a handler when it wants to just call Field:store() & Field::val()
functions, but don't need the column maps set for any other usage.
(ie:: bitmap_is_set() is never called)
- We can't use compare_records() to skip updates for handlers that returns
a partial column set and the read_set doesn't cover all columns in the
write set. The reason for this is that if we have a column marked only for
write we can't in the MySQL level know if the value changed or not.
The reason this worked before was that MySQL marked all to be written
columns as also to be read. The new 'optimal' bitmaps exposed this 'hidden
bug'.
- open_table_from_share() does not anymore setup temporary MEM_ROOT
object as a thread specific variable for the handler. Instead we
send the to-be-used MEMROOT to get_new_handler().
(Simpler, faster code)
Bugs fixed:
- Column marking was not done correctly in a lot of cases.
(ALTER TABLE, when using triggers, auto_increment fields etc)
(Could potentially result in wrong values inserted in table handlers
relying on that the old column maps or field->set_query_id was correct)
Especially when it comes to triggers, there may be cases where the
old code would cause lost/wrong values for NDB and/or InnoDB tables.
- Split thd->options flag OPTION_STATUS_NO_TRANS_UPDATE to two flags:
OPTION_STATUS_NO_TRANS_UPDATE and OPTION_KEEP_LOG.
This allowed me to remove some wrong warnings about:
"Some non-transactional changed tables couldn't be rolled back"
- Fixed handling of INSERT .. SELECT and CREATE ... SELECT that wrongly reset
(thd->options & OPTION_STATUS_NO_TRANS_UPDATE) which caused us to loose
some warnings about
"Some non-transactional changed tables couldn't be rolled back")
- Fixed use of uninitialized memory in ha_ndbcluster.cc::delete_table()
which could cause delete_table to report random failures.
- Fixed core dumps for some tests when running with --debug
- Added missing FN_LIBCHAR in mysql_rm_tmp_tables()
(This has probably caused us to not properly remove temporary files after
crash)
- slow_logs was not properly initialized, which could maybe cause
extra/lost entries in slow log.
- If we get an duplicate row on insert, change column map to read and
write all columns while retrying the operation. This is required by
the definition of REPLACE and also ensures that fields that are only
part of UPDATE are properly handled. This fixed a bug in NDB and
REPLACE where REPLACE wrongly copied some column values from the replaced
row.
- For table handler that doesn't support NULL in keys, we would give an error
when creating a primary key with NULL fields, even after the fields has been
automaticly converted to NOT NULL.
- Creating a primary key on a SPATIAL key, would fail if field was not
declared as NOT NULL.
Cleanups:
- Removed not used condition argument to setup_tables
- Removed not needed item function reset_query_id_processor().
- Field->add_index is removed. Now this is instead maintained in
(field->flags & FIELD_IN_ADD_INDEX)
- Field->fieldnr is removed (use field->field_index instead)
- New argument to filesort() to indicate that it should return a set of
row pointers (not used columns). This allowed me to remove some references
to sql_command in filesort and should also enable us to return column
results in some cases where we couldn't before.
- Changed column bitmap handling in opt_range.cc to be aligned with TABLE
bitmap, which allowed me to use bitmap functions instead of looping over
all fields to create some needed bitmaps. (Faster and smaller code)
- Broke up found too long lines
- Moved some variable declaration at start of function for better code
readability.
- Removed some not used arguments from functions.
(setup_fields(), mysql_prepare_insert_check_table())
- setup_fields() now takes an enum instead of an int for marking columns
usage.
- For internal temporary tables, use handler::write_row(),
handler::delete_row() and handler::update_row() instead of
handler::ha_xxxx() for faster execution.
- Changed some constants to enum's and define's.
- Using separate column read and write sets allows for easier checking
of timestamp field was set by statement.
- Remove calls to free_io_cache() as this is now done automaticly in ha_reset()
- Don't build table->normalized_path as this is now identical to table->path
(after bar's fixes to convert filenames)
- Fixed some missed DBUG_PRINT(.."%lx") to use "0x%lx" to make it easier to
do comparision with the 'convert-dbug-for-diff' tool.
Things left to do in 5.1:
- We wrongly log failed CREATE TABLE ... SELECT in some cases when using
row based logging (as shown by testcase binlog_row_mix_innodb_myisam.result)
Mats has promised to look into this.
- Test that my fix for CREATE TABLE ... SELECT is indeed correct.
(I added several test cases for this, but in this case it's better that
someone else also tests this throughly).
Lars has promosed to do this.
2006-06-04 17:52:22 +02:00
|
|
|
insert into t1 values (a+3),(a+4);
|
|
|
|
|
insert into t1 values (5),(a+6);
|
2001-09-28 07:05:54 +02:00
|
|
|
select * from t1;
|
2000-12-28 02:56:38 +01:00
|
|
|
a
|
|
|
|
|
1
|
|
|
|
|
2
|
|
|
|
|
3
|
|
|
|
|
4
|
|
|
|
|
5
|
This changeset is largely a handler cleanup changeset (WL#3281), but includes fixes and cleanups that was found necessary while testing the handler changes
Changes that requires code changes in other code of other storage engines.
(Note that all changes are very straightforward and one should find all issues
by compiling a --debug build and fixing all compiler errors and all
asserts in field.cc while running the test suite),
- New optional handler function introduced: reset()
This is called after every DML statement to make it easy for a handler to
statement specific cleanups.
(The only case it's not called is if force the file to be closed)
- handler::extra(HA_EXTRA_RESET) is removed. Code that was there before
should be moved to handler::reset()
- table->read_set contains a bitmap over all columns that are needed
in the query. read_row() and similar functions only needs to read these
columns
- table->write_set contains a bitmap over all columns that will be updated
in the query. write_row() and update_row() only needs to update these
columns.
The above bitmaps should now be up to date in all context
(including ALTER TABLE, filesort()).
The handler is informed of any changes to the bitmap after
fix_fields() by calling the virtual function
handler::column_bitmaps_signal(). If the handler does caching of
these bitmaps (instead of using table->read_set, table->write_set),
it should redo the caching in this code. as the signal() may be sent
several times, it's probably best to set a variable in the signal
and redo the caching on read_row() / write_row() if the variable was
set.
- Removed the read_set and write_set bitmap objects from the handler class
- Removed all column bit handling functions from the handler class.
(Now one instead uses the normal bitmap functions in my_bitmap.c instead
of handler dedicated bitmap functions)
- field->query_id is removed. One should instead instead check
table->read_set and table->write_set if a field is used in the query.
- handler::extra(HA_EXTRA_RETRIVE_ALL_COLS) and
handler::extra(HA_EXTRA_RETRIEVE_PRIMARY_KEY) are removed. One should now
instead use table->read_set to check for which columns to retrieve.
- If a handler needs to call Field->val() or Field->store() on columns
that are not used in the query, one should install a temporary
all-columns-used map while doing so. For this, we provide the following
functions:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->read_set);
field->val();
dbug_tmp_restore_column_map(table->read_set, old_map);
and similar for the write map:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->write_set);
field->val();
dbug_tmp_restore_column_map(table->write_set, old_map);
If this is not done, you will sooner or later hit a DBUG_ASSERT
in the field store() / val() functions.
(For not DBUG binaries, the dbug_tmp_restore_column_map() and
dbug_tmp_restore_column_map() are inline dummy functions and should
be optimized away be the compiler).
- If one needs to temporary set the column map for all binaries (and not
just to avoid the DBUG_ASSERT() in the Field::store() / Field::val()
methods) one should use the functions tmp_use_all_columns() and
tmp_restore_column_map() instead of the above dbug_ variants.
- All 'status' fields in the handler base class (like records,
data_file_length etc) are now stored in a 'stats' struct. This makes
it easier to know what status variables are provided by the base
handler. This requires some trivial variable names in the extra()
function.
- New virtual function handler::records(). This is called to optimize
COUNT(*) if (handler::table_flags() & HA_HAS_RECORDS()) is true.
(stats.records is not supposed to be an exact value. It's only has to
be 'reasonable enough' for the optimizer to be able to choose a good
optimization path).
- Non virtual handler::init() function added for caching of virtual
constants from engine.
- Removed has_transactions() virtual method. Now one should instead return
HA_NO_TRANSACTIONS in table_flags() if the table handler DOES NOT support
transactions.
- The 'xxxx_create_handler()' function now has a MEM_ROOT_root argument
that is to be used with 'new handler_name()' to allocate the handler
in the right area. The xxxx_create_handler() function is also
responsible for any initialization of the object before returning.
For example, one should change:
static handler *myisam_create_handler(TABLE_SHARE *table)
{
return new ha_myisam(table);
}
->
static handler *myisam_create_handler(TABLE_SHARE *table, MEM_ROOT *mem_root)
{
return new (mem_root) ha_myisam(table);
}
- New optional virtual function: use_hidden_primary_key().
This is called in case of an update/delete when
(table_flags() and HA_PRIMARY_KEY_REQUIRED_FOR_DELETE) is defined
but we don't have a primary key. This allows the handler to take precisions
in remembering any hidden primary key to able to update/delete any
found row. The default handler marks all columns to be read.
- handler::table_flags() now returns a ulonglong (to allow for more flags).
- New/changed table_flags()
- HA_HAS_RECORDS Set if ::records() is supported
- HA_NO_TRANSACTIONS Set if engine doesn't support transactions
- HA_PRIMARY_KEY_REQUIRED_FOR_DELETE
Set if we should mark all primary key columns for
read when reading rows as part of a DELETE
statement. If there is no primary key,
all columns are marked for read.
- HA_PARTIAL_COLUMN_READ Set if engine will not read all columns in some
cases (based on table->read_set)
- HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS
Renamed to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
- HA_DUPP_POS Renamed to HA_DUPLICATE_POS
- HA_REQUIRES_KEY_COLUMNS_FOR_DELETE
Set this if we should mark ALL key columns for
read when when reading rows as part of a DELETE
statement. In case of an update we will mark
all keys for read for which key part changed
value.
- HA_STATS_RECORDS_IS_EXACT
Set this if stats.records is exact.
(This saves us some extra records() calls
when optimizing COUNT(*))
- Removed table_flags()
- HA_NOT_EXACT_COUNT Now one should instead use HA_HAS_RECORDS if
handler::records() gives an exact count() and
HA_STATS_RECORDS_IS_EXACT if stats.records is exact.
- HA_READ_RND_SAME Removed (no one supported this one)
- Removed not needed functions ha_retrieve_all_cols() and ha_retrieve_all_pk()
- Renamed handler::dupp_pos to handler::dup_pos
- Removed not used variable handler::sortkey
Upper level handler changes:
- ha_reset() now does some overall checks and calls ::reset()
- ha_table_flags() added. This is a cached version of table_flags(). The
cache is updated on engine creation time and updated on open.
MySQL level changes (not obvious from the above):
- DBUG_ASSERT() added to check that column usage matches what is set
in the column usage bit maps. (This found a LOT of bugs in current
column marking code).
- In 5.1 before, all used columns was marked in read_set and only updated
columns was marked in write_set. Now we only mark columns for which we
need a value in read_set.
- Column bitmaps are created in open_binary_frm() and open_table_from_share().
(Before this was in table.cc)
- handler::table_flags() calls are replaced with handler::ha_table_flags()
- For calling field->val() you must have the corresponding bit set in
table->read_set. For calling field->store() you must have the
corresponding bit set in table->write_set. (There are asserts in
all store()/val() functions to catch wrong usage)
- thd->set_query_id is renamed to thd->mark_used_columns and instead
of setting this to an integer value, this has now the values:
MARK_COLUMNS_NONE, MARK_COLUMNS_READ, MARK_COLUMNS_WRITE
Changed also all variables named 'set_query_id' to mark_used_columns.
- In filesort() we now inform the handler of exactly which columns are needed
doing the sort and choosing the rows.
- The TABLE_SHARE object has a 'all_set' column bitmap one can use
when one needs a column bitmap with all columns set.
(This is used for table->use_all_columns() and other places)
- The TABLE object has 3 column bitmaps:
- def_read_set Default bitmap for columns to be read
- def_write_set Default bitmap for columns to be written
- tmp_set Can be used as a temporary bitmap when needed.
The table object has also two pointer to bitmaps read_set and write_set
that the handler should use to find out which columns are used in which way.
- count() optimization now calls handler::records() instead of using
handler->stats.records (if (table_flags() & HA_HAS_RECORDS) is true).
- Added extra argument to Item::walk() to indicate if we should also
traverse sub queries.
- Added TABLE parameter to cp_buffer_from_ref()
- Don't close tables created with CREATE ... SELECT but keep them in
the table cache. (Faster usage of newly created tables).
New interfaces:
- table->clear_column_bitmaps() to initialize the bitmaps for tables
at start of new statements.
- table->column_bitmaps_set() to set up new column bitmaps and signal
the handler about this.
- table->column_bitmaps_set_no_signal() for some few cases where we need
to setup new column bitmaps but don't signal the handler (as the handler
has already been signaled about these before). Used for the momement
only in opt_range.cc when doing ROR scans.
- table->use_all_columns() to install a bitmap where all columns are marked
as use in the read and the write set.
- table->default_column_bitmaps() to install the normal read and write
column bitmaps, but not signaling the handler about this.
This is mainly used when creating TABLE instances.
- table->mark_columns_needed_for_delete(),
table->mark_columns_needed_for_delete() and
table->mark_columns_needed_for_insert() to allow us to put additional
columns in column usage maps if handler so requires.
(The handler indicates what it neads in handler->table_flags())
- table->prepare_for_position() to allow us to tell handler that it
needs to read primary key parts to be able to store them in
future table->position() calls.
(This replaces the table->file->ha_retrieve_all_pk function)
- table->mark_auto_increment_column() to tell handler are going to update
columns part of any auto_increment key.
- table->mark_columns_used_by_index() to mark all columns that is part of
an index. It will also send extra(HA_EXTRA_KEYREAD) to handler to allow
it to quickly know that it only needs to read colums that are part
of the key. (The handler can also use the column map for detecting this,
but simpler/faster handler can just monitor the extra() call).
- table->mark_columns_used_by_index_no_reset() to in addition to other columns,
also mark all columns that is used by the given key.
- table->restore_column_maps_after_mark_index() to restore to default
column maps after a call to table->mark_columns_used_by_index().
- New item function register_field_in_read_map(), for marking used columns
in table->read_map. Used by filesort() to mark all used columns
- Maintain in TABLE->merge_keys set of all keys that are used in query.
(Simplices some optimization loops)
- Maintain Field->part_of_key_not_clustered which is like Field->part_of_key
but the field in the clustered key is not assumed to be part of all index.
(used in opt_range.cc for faster loops)
- dbug_tmp_use_all_columns(), dbug_tmp_restore_column_map()
tmp_use_all_columns() and tmp_restore_column_map() functions to temporally
mark all columns as usable. The 'dbug_' version is primarily intended
inside a handler when it wants to just call Field:store() & Field::val()
functions, but don't need the column maps set for any other usage.
(ie:: bitmap_is_set() is never called)
- We can't use compare_records() to skip updates for handlers that returns
a partial column set and the read_set doesn't cover all columns in the
write set. The reason for this is that if we have a column marked only for
write we can't in the MySQL level know if the value changed or not.
The reason this worked before was that MySQL marked all to be written
columns as also to be read. The new 'optimal' bitmaps exposed this 'hidden
bug'.
- open_table_from_share() does not anymore setup temporary MEM_ROOT
object as a thread specific variable for the handler. Instead we
send the to-be-used MEMROOT to get_new_handler().
(Simpler, faster code)
Bugs fixed:
- Column marking was not done correctly in a lot of cases.
(ALTER TABLE, when using triggers, auto_increment fields etc)
(Could potentially result in wrong values inserted in table handlers
relying on that the old column maps or field->set_query_id was correct)
Especially when it comes to triggers, there may be cases where the
old code would cause lost/wrong values for NDB and/or InnoDB tables.
- Split thd->options flag OPTION_STATUS_NO_TRANS_UPDATE to two flags:
OPTION_STATUS_NO_TRANS_UPDATE and OPTION_KEEP_LOG.
This allowed me to remove some wrong warnings about:
"Some non-transactional changed tables couldn't be rolled back"
- Fixed handling of INSERT .. SELECT and CREATE ... SELECT that wrongly reset
(thd->options & OPTION_STATUS_NO_TRANS_UPDATE) which caused us to loose
some warnings about
"Some non-transactional changed tables couldn't be rolled back")
- Fixed use of uninitialized memory in ha_ndbcluster.cc::delete_table()
which could cause delete_table to report random failures.
- Fixed core dumps for some tests when running with --debug
- Added missing FN_LIBCHAR in mysql_rm_tmp_tables()
(This has probably caused us to not properly remove temporary files after
crash)
- slow_logs was not properly initialized, which could maybe cause
extra/lost entries in slow log.
- If we get an duplicate row on insert, change column map to read and
write all columns while retrying the operation. This is required by
the definition of REPLACE and also ensures that fields that are only
part of UPDATE are properly handled. This fixed a bug in NDB and
REPLACE where REPLACE wrongly copied some column values from the replaced
row.
- For table handler that doesn't support NULL in keys, we would give an error
when creating a primary key with NULL fields, even after the fields has been
automaticly converted to NOT NULL.
- Creating a primary key on a SPATIAL key, would fail if field was not
declared as NOT NULL.
Cleanups:
- Removed not used condition argument to setup_tables
- Removed not needed item function reset_query_id_processor().
- Field->add_index is removed. Now this is instead maintained in
(field->flags & FIELD_IN_ADD_INDEX)
- Field->fieldnr is removed (use field->field_index instead)
- New argument to filesort() to indicate that it should return a set of
row pointers (not used columns). This allowed me to remove some references
to sql_command in filesort and should also enable us to return column
results in some cases where we couldn't before.
- Changed column bitmap handling in opt_range.cc to be aligned with TABLE
bitmap, which allowed me to use bitmap functions instead of looping over
all fields to create some needed bitmaps. (Faster and smaller code)
- Broke up found too long lines
- Moved some variable declaration at start of function for better code
readability.
- Removed some not used arguments from functions.
(setup_fields(), mysql_prepare_insert_check_table())
- setup_fields() now takes an enum instead of an int for marking columns
usage.
- For internal temporary tables, use handler::write_row(),
handler::delete_row() and handler::update_row() instead of
handler::ha_xxxx() for faster execution.
- Changed some constants to enum's and define's.
- Using separate column read and write sets allows for easier checking
of timestamp field was set by statement.
- Remove calls to free_io_cache() as this is now done automaticly in ha_reset()
- Don't build table->normalized_path as this is now identical to table->path
(after bar's fixes to convert filenames)
- Fixed some missed DBUG_PRINT(.."%lx") to use "0x%lx" to make it easier to
do comparision with the 'convert-dbug-for-diff' tool.
Things left to do in 5.1:
- We wrongly log failed CREATE TABLE ... SELECT in some cases when using
row based logging (as shown by testcase binlog_row_mix_innodb_myisam.result)
Mats has promised to look into this.
- Test that my fix for CREATE TABLE ... SELECT is indeed correct.
(I added several test cases for this, but in this case it's better that
someone else also tests this throughly).
Lars has promosed to do this.
2006-06-04 17:52:22 +02:00
|
|
|
6
|
2001-09-28 07:05:54 +02:00
|
|
|
drop table t1;
|
|
|
|
|
create table t1 (id int not null auto_increment primary key, username varchar(32) not null, unique (username));
|
|
|
|
|
insert into t1 values (0,"mysql");
|
|
|
|
|
insert into t1 values (0,"mysql ab");
|
|
|
|
|
insert into t1 values (0,"mysql a");
|
|
|
|
|
insert into t1 values (0,"r1manic");
|
|
|
|
|
insert into t1 values (0,"r1man");
|
|
|
|
|
drop table t1;
|
2002-08-08 02:12:02 +02:00
|
|
|
create table t1 (a int not null auto_increment, primary key (a), t timestamp, c char(10) default "hello", i int);
|
|
|
|
|
insert into t1 values (default,default,default,default), (default,default,default,default), (4,0,"a",5),(default,default,default,default);
|
|
|
|
|
select a,t>0,c,i from t1;
|
|
|
|
|
a t>0 c i
|
|
|
|
|
1 1 hello NULL
|
|
|
|
|
2 1 hello NULL
|
|
|
|
|
4 0 a 5
|
|
|
|
|
5 1 hello NULL
|
2002-07-25 00:00:56 +02:00
|
|
|
truncate table t1;
|
|
|
|
|
insert into t1 set a=default,t=default,c=default;
|
2002-08-08 02:12:02 +02:00
|
|
|
insert into t1 set a=default,t=default,c=default,i=default;
|
|
|
|
|
insert into t1 set a=4,t=0,c="a",i=5;
|
|
|
|
|
insert into t1 set a=5,t=0,c="a",i=null;
|
|
|
|
|
insert into t1 set a=default,t=default,c=default,i=default;
|
|
|
|
|
select a,t>0,c,i from t1;
|
|
|
|
|
a t>0 c i
|
|
|
|
|
1 1 hello NULL
|
|
|
|
|
2 1 hello NULL
|
|
|
|
|
4 0 a 5
|
|
|
|
|
5 0 a NULL
|
|
|
|
|
6 1 hello NULL
|
2002-07-25 00:00:56 +02:00
|
|
|
drop table t1;
|
2002-09-18 20:04:49 +02:00
|
|
|
create table t1 (sid char(20), id int(2) NOT NULL auto_increment, key(sid, id));
|
|
|
|
|
insert into t1 values ('skr',NULL),('skr',NULL),('test',NULL);
|
|
|
|
|
select * from t1;
|
|
|
|
|
sid id
|
|
|
|
|
skr 1
|
2002-12-14 11:45:31 +01:00
|
|
|
skr 2
|
2002-12-11 14:46:39 +01:00
|
|
|
test 1
|
|
|
|
|
insert into t1 values ('rts',NULL),('rts',NULL),('test',NULL);
|
|
|
|
|
select * from t1;
|
|
|
|
|
sid id
|
|
|
|
|
rts 1
|
|
|
|
|
rts 2
|
|
|
|
|
skr 1
|
2002-12-14 11:45:31 +01:00
|
|
|
skr 2
|
2002-09-18 20:04:49 +02:00
|
|
|
test 1
|
2002-12-11 14:46:39 +01:00
|
|
|
test 2
|
2002-09-18 20:04:49 +02:00
|
|
|
drop table t1;
|
2003-06-24 07:53:21 +02:00
|
|
|
create table t1 (id int NOT NULL DEFAULT 8);
|
|
|
|
|
insert into t1 values(NULL);
|
2003-08-18 23:08:08 +02:00
|
|
|
ERROR 23000: Column 'id' cannot be null
|
2003-06-24 07:53:21 +02:00
|
|
|
insert into t1 values (1), (NULL), (2);
|
2003-08-18 23:08:08 +02:00
|
|
|
Warnings:
|
2005-12-01 12:30:11 +01:00
|
|
|
Warning 1048 Column 'id' cannot be null
|
2003-06-24 07:53:21 +02:00
|
|
|
select * from t1;
|
|
|
|
|
id
|
|
|
|
|
1
|
2003-07-01 13:38:38 +02:00
|
|
|
0
|
2003-06-24 07:53:21 +02:00
|
|
|
2
|
|
|
|
|
drop table t1;
|
2003-09-29 11:31:35 +02:00
|
|
|
create table t1 (email varchar(50));
|
|
|
|
|
insert into t1 values ('sasha@mysql.com'),('monty@mysql.com'),('foo@hotmail.com'),('foo@aol.com'),('bar@aol.com');
|
|
|
|
|
create table t2(id int not null auto_increment primary key, t2 varchar(50), unique(t2));
|
2003-12-14 05:39:52 +01:00
|
|
|
insert delayed into t2 (t2) select distinct substring(email, locate('@', email)+1) from t1;
|
2003-09-29 11:31:35 +02:00
|
|
|
select * from t2;
|
|
|
|
|
id t2
|
|
|
|
|
1 mysql.com
|
|
|
|
|
2 hotmail.com
|
|
|
|
|
3 aol.com
|
|
|
|
|
drop table t1,t2;
|
|
|
|
|
drop database if exists mysqltest;
|
|
|
|
|
create database mysqltest;
|
|
|
|
|
use mysqltest;
|
2002-07-25 00:00:56 +02:00
|
|
|
create table t1 (c int);
|
2003-09-29 11:31:35 +02:00
|
|
|
insert into mysqltest.t1 set mysqltest.t1.c = '1';
|
|
|
|
|
drop database mysqltest;
|
2003-01-28 17:55:52 +01:00
|
|
|
use test;
|
2004-03-17 23:09:13 +01:00
|
|
|
create table t1(number int auto_increment primary key, original_value varchar(50), f_double double, f_float float, f_double_7_2 double(7,2), f_float_4_3 float (4,3), f_double_u double unsigned, f_float_u float unsigned, f_double_15_1_u double(15,1) unsigned, f_float_3_1_u float (3,1) unsigned);
|
2004-03-04 18:08:14 +01:00
|
|
|
set @value= "aa";
|
|
|
|
|
insert into t1 values(null,@value,@value,@value,@value,@value,@value,@value,@value,@value);
|
|
|
|
|
Warnings:
|
2004-03-17 23:09:13 +01:00
|
|
|
Warning 1265 Data truncated for column 'f_double' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_double_7_2' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float_4_3' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_double_u' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float_u' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_double_15_1_u' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float_3_1_u' at row 1
|
|
|
|
|
select * from t1 where number =last_insert_id();
|
|
|
|
|
number 1
|
|
|
|
|
original_value aa
|
|
|
|
|
f_double 0
|
|
|
|
|
f_float 0
|
|
|
|
|
f_double_7_2 0.00
|
|
|
|
|
f_float_4_3 0.000
|
|
|
|
|
f_double_u 0
|
|
|
|
|
f_float_u 0
|
|
|
|
|
f_double_15_1_u 0.0
|
|
|
|
|
f_float_3_1_u 0.0
|
2004-03-04 18:08:14 +01:00
|
|
|
set @value= "1aa";
|
|
|
|
|
insert into t1 values(null,@value,@value,@value,@value,@value,@value,@value,@value,@value);
|
|
|
|
|
Warnings:
|
2004-03-17 23:09:13 +01:00
|
|
|
Warning 1265 Data truncated for column 'f_double' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_double_7_2' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float_4_3' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_double_u' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float_u' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_double_15_1_u' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float_3_1_u' at row 1
|
|
|
|
|
select * from t1 where number =last_insert_id();
|
|
|
|
|
number 2
|
|
|
|
|
original_value 1aa
|
|
|
|
|
f_double 1
|
|
|
|
|
f_float 1
|
|
|
|
|
f_double_7_2 1.00
|
|
|
|
|
f_float_4_3 1.000
|
|
|
|
|
f_double_u 1
|
|
|
|
|
f_float_u 1
|
|
|
|
|
f_double_15_1_u 1.0
|
|
|
|
|
f_float_3_1_u 1.0
|
2004-03-04 18:08:14 +01:00
|
|
|
set @value= "aa1";
|
|
|
|
|
insert into t1 values(null,@value,@value,@value,@value,@value,@value,@value,@value,@value);
|
|
|
|
|
Warnings:
|
2004-03-17 23:09:13 +01:00
|
|
|
Warning 1265 Data truncated for column 'f_double' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_double_7_2' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float_4_3' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_double_u' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float_u' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_double_15_1_u' at row 1
|
|
|
|
|
Warning 1265 Data truncated for column 'f_float_3_1_u' at row 1
|
|
|
|
|
select * from t1 where number =last_insert_id();
|
|
|
|
|
number 3
|
|
|
|
|
original_value aa1
|
|
|
|
|
f_double 0
|
|
|
|
|
f_float 0
|
|
|
|
|
f_double_7_2 0.00
|
|
|
|
|
f_float_4_3 0.000
|
|
|
|
|
f_double_u 0
|
|
|
|
|
f_float_u 0
|
|
|
|
|
f_double_15_1_u 0.0
|
|
|
|
|
f_float_3_1_u 0.0
|
2004-03-04 18:08:14 +01:00
|
|
|
set @value= "1e+1111111111a";
|
|
|
|
|
insert into t1 values(null,@value,@value,@value,@value,@value,@value,@value,@value,@value);
|
|
|
|
|
Warnings:
|
2005-12-02 12:01:44 +01:00
|
|
|
Warning 1264 Out of range value for column 'f_double' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_7_2' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_7_2' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_4_3' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_4_3' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_15_1_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_15_1_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_3_1_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_3_1_u' at row 1
|
2004-03-17 23:09:13 +01:00
|
|
|
select * from t1 where number =last_insert_id();
|
|
|
|
|
number 4
|
|
|
|
|
original_value 1e+1111111111a
|
|
|
|
|
f_double 1.79769313486232e+308
|
|
|
|
|
f_float 3.40282e+38
|
|
|
|
|
f_double_7_2 99999.99
|
|
|
|
|
f_float_4_3 9.999
|
|
|
|
|
f_double_u 1.79769313486232e+308
|
|
|
|
|
f_float_u 3.40282e+38
|
|
|
|
|
f_double_15_1_u 99999999999999.9
|
|
|
|
|
f_float_3_1_u 99.9
|
2004-03-04 18:08:14 +01:00
|
|
|
set @value= "-1e+1111111111a";
|
|
|
|
|
insert into t1 values(null,@value,@value,@value,@value,@value,@value,@value,@value,@value);
|
|
|
|
|
Warnings:
|
2005-12-02 12:01:44 +01:00
|
|
|
Warning 1264 Out of range value for column 'f_double' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_7_2' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_7_2' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_4_3' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_4_3' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_15_1_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_15_1_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_3_1_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_3_1_u' at row 1
|
2004-03-17 23:09:13 +01:00
|
|
|
select * from t1 where number =last_insert_id();
|
|
|
|
|
number 5
|
|
|
|
|
original_value -1e+1111111111a
|
|
|
|
|
f_double -1.79769313486232e+308
|
|
|
|
|
f_float -3.40282e+38
|
|
|
|
|
f_double_7_2 -99999.99
|
|
|
|
|
f_float_4_3 -9.999
|
|
|
|
|
f_double_u 0
|
|
|
|
|
f_float_u 0
|
|
|
|
|
f_double_15_1_u 0.0
|
|
|
|
|
f_float_3_1_u 0.0
|
2004-03-04 18:08:14 +01:00
|
|
|
set @value= 1e+1111111111;
|
2004-10-02 21:20:08 +02:00
|
|
|
ERROR 22007: Illegal double '1e+1111111111' value found during parsing
|
2004-03-04 18:08:14 +01:00
|
|
|
set @value= -1e+1111111111;
|
2004-10-02 21:20:08 +02:00
|
|
|
ERROR 22007: Illegal double '1e+1111111111' value found during parsing
|
2004-03-04 18:08:14 +01:00
|
|
|
set @value= 1e+111;
|
|
|
|
|
insert into t1 values(null,@value,@value,@value,@value,@value,@value,@value,@value,@value);
|
|
|
|
|
Warnings:
|
2005-12-02 12:01:44 +01:00
|
|
|
Warning 1264 Out of range value for column 'f_float' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_7_2' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_4_3' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_15_1_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_3_1_u' at row 1
|
2004-03-17 23:09:13 +01:00
|
|
|
select * from t1 where number =last_insert_id();
|
2004-10-02 21:20:08 +02:00
|
|
|
number 6
|
2004-03-17 23:09:13 +01:00
|
|
|
original_value 1e+111
|
|
|
|
|
f_double 1e+111
|
|
|
|
|
f_float 3.40282e+38
|
|
|
|
|
f_double_7_2 99999.99
|
|
|
|
|
f_float_4_3 9.999
|
|
|
|
|
f_double_u 1e+111
|
|
|
|
|
f_float_u 3.40282e+38
|
|
|
|
|
f_double_15_1_u 99999999999999.9
|
|
|
|
|
f_float_3_1_u 99.9
|
2004-03-04 18:08:14 +01:00
|
|
|
set @value= -1e+111;
|
|
|
|
|
insert into t1 values(null,@value,@value,@value,@value,@value,@value,@value,@value,@value);
|
|
|
|
|
Warnings:
|
2005-12-02 12:01:44 +01:00
|
|
|
Warning 1264 Out of range value for column 'f_float' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_7_2' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_4_3' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_15_1_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_3_1_u' at row 1
|
2004-03-17 23:09:13 +01:00
|
|
|
select * from t1 where number =last_insert_id();
|
2004-10-02 21:20:08 +02:00
|
|
|
number 7
|
2004-03-17 23:09:13 +01:00
|
|
|
original_value -1e+111
|
|
|
|
|
f_double -1e+111
|
|
|
|
|
f_float -3.40282e+38
|
|
|
|
|
f_double_7_2 -99999.99
|
|
|
|
|
f_float_4_3 -9.999
|
|
|
|
|
f_double_u 0
|
|
|
|
|
f_float_u 0
|
|
|
|
|
f_double_15_1_u 0.0
|
|
|
|
|
f_float_3_1_u 0.0
|
2004-03-04 18:08:14 +01:00
|
|
|
set @value= 1;
|
|
|
|
|
insert into t1 values(null,@value,@value,@value,@value,@value,@value,@value,@value,@value);
|
2004-03-17 23:09:13 +01:00
|
|
|
select * from t1 where number =last_insert_id();
|
2004-10-02 21:20:08 +02:00
|
|
|
number 8
|
2004-03-17 23:09:13 +01:00
|
|
|
original_value 1
|
|
|
|
|
f_double 1
|
|
|
|
|
f_float 1
|
|
|
|
|
f_double_7_2 1.00
|
|
|
|
|
f_float_4_3 1.000
|
|
|
|
|
f_double_u 1
|
|
|
|
|
f_float_u 1
|
|
|
|
|
f_double_15_1_u 1.0
|
|
|
|
|
f_float_3_1_u 1.0
|
2004-03-04 18:08:14 +01:00
|
|
|
set @value= -1;
|
|
|
|
|
insert into t1 values(null,@value,@value,@value,@value,@value,@value,@value,@value,@value);
|
|
|
|
|
Warnings:
|
2005-12-02 12:01:44 +01:00
|
|
|
Warning 1264 Out of range value for column 'f_double_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_double_15_1_u' at row 1
|
|
|
|
|
Warning 1264 Out of range value for column 'f_float_3_1_u' at row 1
|
2004-03-17 23:09:13 +01:00
|
|
|
select * from t1 where number =last_insert_id();
|
2004-10-02 21:20:08 +02:00
|
|
|
number 9
|
2004-03-17 23:09:13 +01:00
|
|
|
original_value -1
|
|
|
|
|
f_double -1
|
|
|
|
|
f_float -1
|
|
|
|
|
f_double_7_2 -1.00
|
|
|
|
|
f_float_4_3 -1.000
|
|
|
|
|
f_double_u 0
|
|
|
|
|
f_float_u 0
|
|
|
|
|
f_double_15_1_u 0.0
|
|
|
|
|
f_float_3_1_u 0.0
|
2004-11-03 11:39:38 +01:00
|
|
|
drop table t1;
|
2003-01-28 17:55:52 +01:00
|
|
|
create table t1(id1 int not null auto_increment primary key, t char(12));
|
|
|
|
|
create table t2(id2 int not null, t char(12));
|
|
|
|
|
create table t3(id3 int not null, t char(12), index(id3));
|
|
|
|
|
select count(*) from t2;
|
|
|
|
|
count(*)
|
|
|
|
|
500
|
|
|
|
|
insert into t2 select t1.* from t1, t2 t, t3 where t1.id1 = t.id2 and t.id2 = t3.id3;
|
|
|
|
|
select count(*) from t2;
|
|
|
|
|
count(*)
|
|
|
|
|
25500
|
2004-11-03 11:39:38 +01:00
|
|
|
drop table t1,t2,t3;
|
This changeset is largely a handler cleanup changeset (WL#3281), but includes fixes and cleanups that was found necessary while testing the handler changes
Changes that requires code changes in other code of other storage engines.
(Note that all changes are very straightforward and one should find all issues
by compiling a --debug build and fixing all compiler errors and all
asserts in field.cc while running the test suite),
- New optional handler function introduced: reset()
This is called after every DML statement to make it easy for a handler to
statement specific cleanups.
(The only case it's not called is if force the file to be closed)
- handler::extra(HA_EXTRA_RESET) is removed. Code that was there before
should be moved to handler::reset()
- table->read_set contains a bitmap over all columns that are needed
in the query. read_row() and similar functions only needs to read these
columns
- table->write_set contains a bitmap over all columns that will be updated
in the query. write_row() and update_row() only needs to update these
columns.
The above bitmaps should now be up to date in all context
(including ALTER TABLE, filesort()).
The handler is informed of any changes to the bitmap after
fix_fields() by calling the virtual function
handler::column_bitmaps_signal(). If the handler does caching of
these bitmaps (instead of using table->read_set, table->write_set),
it should redo the caching in this code. as the signal() may be sent
several times, it's probably best to set a variable in the signal
and redo the caching on read_row() / write_row() if the variable was
set.
- Removed the read_set and write_set bitmap objects from the handler class
- Removed all column bit handling functions from the handler class.
(Now one instead uses the normal bitmap functions in my_bitmap.c instead
of handler dedicated bitmap functions)
- field->query_id is removed. One should instead instead check
table->read_set and table->write_set if a field is used in the query.
- handler::extra(HA_EXTRA_RETRIVE_ALL_COLS) and
handler::extra(HA_EXTRA_RETRIEVE_PRIMARY_KEY) are removed. One should now
instead use table->read_set to check for which columns to retrieve.
- If a handler needs to call Field->val() or Field->store() on columns
that are not used in the query, one should install a temporary
all-columns-used map while doing so. For this, we provide the following
functions:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->read_set);
field->val();
dbug_tmp_restore_column_map(table->read_set, old_map);
and similar for the write map:
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->write_set);
field->val();
dbug_tmp_restore_column_map(table->write_set, old_map);
If this is not done, you will sooner or later hit a DBUG_ASSERT
in the field store() / val() functions.
(For not DBUG binaries, the dbug_tmp_restore_column_map() and
dbug_tmp_restore_column_map() are inline dummy functions and should
be optimized away be the compiler).
- If one needs to temporary set the column map for all binaries (and not
just to avoid the DBUG_ASSERT() in the Field::store() / Field::val()
methods) one should use the functions tmp_use_all_columns() and
tmp_restore_column_map() instead of the above dbug_ variants.
- All 'status' fields in the handler base class (like records,
data_file_length etc) are now stored in a 'stats' struct. This makes
it easier to know what status variables are provided by the base
handler. This requires some trivial variable names in the extra()
function.
- New virtual function handler::records(). This is called to optimize
COUNT(*) if (handler::table_flags() & HA_HAS_RECORDS()) is true.
(stats.records is not supposed to be an exact value. It's only has to
be 'reasonable enough' for the optimizer to be able to choose a good
optimization path).
- Non virtual handler::init() function added for caching of virtual
constants from engine.
- Removed has_transactions() virtual method. Now one should instead return
HA_NO_TRANSACTIONS in table_flags() if the table handler DOES NOT support
transactions.
- The 'xxxx_create_handler()' function now has a MEM_ROOT_root argument
that is to be used with 'new handler_name()' to allocate the handler
in the right area. The xxxx_create_handler() function is also
responsible for any initialization of the object before returning.
For example, one should change:
static handler *myisam_create_handler(TABLE_SHARE *table)
{
return new ha_myisam(table);
}
->
static handler *myisam_create_handler(TABLE_SHARE *table, MEM_ROOT *mem_root)
{
return new (mem_root) ha_myisam(table);
}
- New optional virtual function: use_hidden_primary_key().
This is called in case of an update/delete when
(table_flags() and HA_PRIMARY_KEY_REQUIRED_FOR_DELETE) is defined
but we don't have a primary key. This allows the handler to take precisions
in remembering any hidden primary key to able to update/delete any
found row. The default handler marks all columns to be read.
- handler::table_flags() now returns a ulonglong (to allow for more flags).
- New/changed table_flags()
- HA_HAS_RECORDS Set if ::records() is supported
- HA_NO_TRANSACTIONS Set if engine doesn't support transactions
- HA_PRIMARY_KEY_REQUIRED_FOR_DELETE
Set if we should mark all primary key columns for
read when reading rows as part of a DELETE
statement. If there is no primary key,
all columns are marked for read.
- HA_PARTIAL_COLUMN_READ Set if engine will not read all columns in some
cases (based on table->read_set)
- HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS
Renamed to HA_PRIMARY_KEY_REQUIRED_FOR_POSITION.
- HA_DUPP_POS Renamed to HA_DUPLICATE_POS
- HA_REQUIRES_KEY_COLUMNS_FOR_DELETE
Set this if we should mark ALL key columns for
read when when reading rows as part of a DELETE
statement. In case of an update we will mark
all keys for read for which key part changed
value.
- HA_STATS_RECORDS_IS_EXACT
Set this if stats.records is exact.
(This saves us some extra records() calls
when optimizing COUNT(*))
- Removed table_flags()
- HA_NOT_EXACT_COUNT Now one should instead use HA_HAS_RECORDS if
handler::records() gives an exact count() and
HA_STATS_RECORDS_IS_EXACT if stats.records is exact.
- HA_READ_RND_SAME Removed (no one supported this one)
- Removed not needed functions ha_retrieve_all_cols() and ha_retrieve_all_pk()
- Renamed handler::dupp_pos to handler::dup_pos
- Removed not used variable handler::sortkey
Upper level handler changes:
- ha_reset() now does some overall checks and calls ::reset()
- ha_table_flags() added. This is a cached version of table_flags(). The
cache is updated on engine creation time and updated on open.
MySQL level changes (not obvious from the above):
- DBUG_ASSERT() added to check that column usage matches what is set
in the column usage bit maps. (This found a LOT of bugs in current
column marking code).
- In 5.1 before, all used columns was marked in read_set and only updated
columns was marked in write_set. Now we only mark columns for which we
need a value in read_set.
- Column bitmaps are created in open_binary_frm() and open_table_from_share().
(Before this was in table.cc)
- handler::table_flags() calls are replaced with handler::ha_table_flags()
- For calling field->val() you must have the corresponding bit set in
table->read_set. For calling field->store() you must have the
corresponding bit set in table->write_set. (There are asserts in
all store()/val() functions to catch wrong usage)
- thd->set_query_id is renamed to thd->mark_used_columns and instead
of setting this to an integer value, this has now the values:
MARK_COLUMNS_NONE, MARK_COLUMNS_READ, MARK_COLUMNS_WRITE
Changed also all variables named 'set_query_id' to mark_used_columns.
- In filesort() we now inform the handler of exactly which columns are needed
doing the sort and choosing the rows.
- The TABLE_SHARE object has a 'all_set' column bitmap one can use
when one needs a column bitmap with all columns set.
(This is used for table->use_all_columns() and other places)
- The TABLE object has 3 column bitmaps:
- def_read_set Default bitmap for columns to be read
- def_write_set Default bitmap for columns to be written
- tmp_set Can be used as a temporary bitmap when needed.
The table object has also two pointer to bitmaps read_set and write_set
that the handler should use to find out which columns are used in which way.
- count() optimization now calls handler::records() instead of using
handler->stats.records (if (table_flags() & HA_HAS_RECORDS) is true).
- Added extra argument to Item::walk() to indicate if we should also
traverse sub queries.
- Added TABLE parameter to cp_buffer_from_ref()
- Don't close tables created with CREATE ... SELECT but keep them in
the table cache. (Faster usage of newly created tables).
New interfaces:
- table->clear_column_bitmaps() to initialize the bitmaps for tables
at start of new statements.
- table->column_bitmaps_set() to set up new column bitmaps and signal
the handler about this.
- table->column_bitmaps_set_no_signal() for some few cases where we need
to setup new column bitmaps but don't signal the handler (as the handler
has already been signaled about these before). Used for the momement
only in opt_range.cc when doing ROR scans.
- table->use_all_columns() to install a bitmap where all columns are marked
as use in the read and the write set.
- table->default_column_bitmaps() to install the normal read and write
column bitmaps, but not signaling the handler about this.
This is mainly used when creating TABLE instances.
- table->mark_columns_needed_for_delete(),
table->mark_columns_needed_for_delete() and
table->mark_columns_needed_for_insert() to allow us to put additional
columns in column usage maps if handler so requires.
(The handler indicates what it neads in handler->table_flags())
- table->prepare_for_position() to allow us to tell handler that it
needs to read primary key parts to be able to store them in
future table->position() calls.
(This replaces the table->file->ha_retrieve_all_pk function)
- table->mark_auto_increment_column() to tell handler are going to update
columns part of any auto_increment key.
- table->mark_columns_used_by_index() to mark all columns that is part of
an index. It will also send extra(HA_EXTRA_KEYREAD) to handler to allow
it to quickly know that it only needs to read colums that are part
of the key. (The handler can also use the column map for detecting this,
but simpler/faster handler can just monitor the extra() call).
- table->mark_columns_used_by_index_no_reset() to in addition to other columns,
also mark all columns that is used by the given key.
- table->restore_column_maps_after_mark_index() to restore to default
column maps after a call to table->mark_columns_used_by_index().
- New item function register_field_in_read_map(), for marking used columns
in table->read_map. Used by filesort() to mark all used columns
- Maintain in TABLE->merge_keys set of all keys that are used in query.
(Simplices some optimization loops)
- Maintain Field->part_of_key_not_clustered which is like Field->part_of_key
but the field in the clustered key is not assumed to be part of all index.
(used in opt_range.cc for faster loops)
- dbug_tmp_use_all_columns(), dbug_tmp_restore_column_map()
tmp_use_all_columns() and tmp_restore_column_map() functions to temporally
mark all columns as usable. The 'dbug_' version is primarily intended
inside a handler when it wants to just call Field:store() & Field::val()
functions, but don't need the column maps set for any other usage.
(ie:: bitmap_is_set() is never called)
- We can't use compare_records() to skip updates for handlers that returns
a partial column set and the read_set doesn't cover all columns in the
write set. The reason for this is that if we have a column marked only for
write we can't in the MySQL level know if the value changed or not.
The reason this worked before was that MySQL marked all to be written
columns as also to be read. The new 'optimal' bitmaps exposed this 'hidden
bug'.
- open_table_from_share() does not anymore setup temporary MEM_ROOT
object as a thread specific variable for the handler. Instead we
send the to-be-used MEMROOT to get_new_handler().
(Simpler, faster code)
Bugs fixed:
- Column marking was not done correctly in a lot of cases.
(ALTER TABLE, when using triggers, auto_increment fields etc)
(Could potentially result in wrong values inserted in table handlers
relying on that the old column maps or field->set_query_id was correct)
Especially when it comes to triggers, there may be cases where the
old code would cause lost/wrong values for NDB and/or InnoDB tables.
- Split thd->options flag OPTION_STATUS_NO_TRANS_UPDATE to two flags:
OPTION_STATUS_NO_TRANS_UPDATE and OPTION_KEEP_LOG.
This allowed me to remove some wrong warnings about:
"Some non-transactional changed tables couldn't be rolled back"
- Fixed handling of INSERT .. SELECT and CREATE ... SELECT that wrongly reset
(thd->options & OPTION_STATUS_NO_TRANS_UPDATE) which caused us to loose
some warnings about
"Some non-transactional changed tables couldn't be rolled back")
- Fixed use of uninitialized memory in ha_ndbcluster.cc::delete_table()
which could cause delete_table to report random failures.
- Fixed core dumps for some tests when running with --debug
- Added missing FN_LIBCHAR in mysql_rm_tmp_tables()
(This has probably caused us to not properly remove temporary files after
crash)
- slow_logs was not properly initialized, which could maybe cause
extra/lost entries in slow log.
- If we get an duplicate row on insert, change column map to read and
write all columns while retrying the operation. This is required by
the definition of REPLACE and also ensures that fields that are only
part of UPDATE are properly handled. This fixed a bug in NDB and
REPLACE where REPLACE wrongly copied some column values from the replaced
row.
- For table handler that doesn't support NULL in keys, we would give an error
when creating a primary key with NULL fields, even after the fields has been
automaticly converted to NOT NULL.
- Creating a primary key on a SPATIAL key, would fail if field was not
declared as NOT NULL.
Cleanups:
- Removed not used condition argument to setup_tables
- Removed not needed item function reset_query_id_processor().
- Field->add_index is removed. Now this is instead maintained in
(field->flags & FIELD_IN_ADD_INDEX)
- Field->fieldnr is removed (use field->field_index instead)
- New argument to filesort() to indicate that it should return a set of
row pointers (not used columns). This allowed me to remove some references
to sql_command in filesort and should also enable us to return column
results in some cases where we couldn't before.
- Changed column bitmap handling in opt_range.cc to be aligned with TABLE
bitmap, which allowed me to use bitmap functions instead of looping over
all fields to create some needed bitmaps. (Faster and smaller code)
- Broke up found too long lines
- Moved some variable declaration at start of function for better code
readability.
- Removed some not used arguments from functions.
(setup_fields(), mysql_prepare_insert_check_table())
- setup_fields() now takes an enum instead of an int for marking columns
usage.
- For internal temporary tables, use handler::write_row(),
handler::delete_row() and handler::update_row() instead of
handler::ha_xxxx() for faster execution.
- Changed some constants to enum's and define's.
- Using separate column read and write sets allows for easier checking
of timestamp field was set by statement.
- Remove calls to free_io_cache() as this is now done automaticly in ha_reset()
- Don't build table->normalized_path as this is now identical to table->path
(after bar's fixes to convert filenames)
- Fixed some missed DBUG_PRINT(.."%lx") to use "0x%lx" to make it easier to
do comparision with the 'convert-dbug-for-diff' tool.
Things left to do in 5.1:
- We wrongly log failed CREATE TABLE ... SELECT in some cases when using
row based logging (as shown by testcase binlog_row_mix_innodb_myisam.result)
Mats has promised to look into this.
- Test that my fix for CREATE TABLE ... SELECT is indeed correct.
(I added several test cases for this, but in this case it's better that
someone else also tests this throughly).
Lars has promosed to do this.
2006-06-04 17:52:22 +02:00
|
|
|
create table t1 (a int, b int);
|
|
|
|
|
insert into t1 (a,b) values (a,b);
|
|
|
|
|
insert into t1 SET a=1, b=a+1;
|
|
|
|
|
insert into t1 (a,b) select 1,2;
|
|
|
|
|
INSERT INTO t1 ( a ) SELECT 0 ON DUPLICATE KEY UPDATE a = a + VALUES (a);
|
|
|
|
|
prepare stmt1 from ' replace into t1 (a,a) select 100, ''hundred'' ';
|
|
|
|
|
execute stmt1;
|
|
|
|
|
ERROR 42000: Column 'a' specified twice
|
|
|
|
|
insert into t1 (a,b,b) values (1,1,1);
|
|
|
|
|
ERROR 42000: Column 'b' specified twice
|
|
|
|
|
insert into t1 (a,a) values (1,1,1);
|
|
|
|
|
ERROR 21S01: Column count doesn't match value count at row 1
|
|
|
|
|
insert into t1 (a,a) values (1,1);
|
|
|
|
|
ERROR 42000: Column 'a' specified twice
|
|
|
|
|
insert into t1 SET a=1,b=2,a=1;
|
|
|
|
|
ERROR 42000: Column 'a' specified twice
|
|
|
|
|
insert into t1 (b,b) select 1,2;
|
|
|
|
|
ERROR 42000: Column 'b' specified twice
|
|
|
|
|
INSERT INTO t1 (b,b) SELECT 0,0 ON DUPLICATE KEY UPDATE a = a + VALUES (a);
|
|
|
|
|
ERROR 42000: Column 'b' specified twice
|
|
|
|
|
drop table t1;
|
2006-06-16 18:21:25 +02:00
|
|
|
create table t1 (id int primary key, data int);
|
|
|
|
|
insert into t1 values (1, 1), (2, 2), (3, 3);
|
|
|
|
|
select row_count();
|
|
|
|
|
row_count()
|
|
|
|
|
3
|
|
|
|
|
insert ignore into t1 values (1, 1);
|
|
|
|
|
select row_count();
|
|
|
|
|
row_count()
|
|
|
|
|
0
|
|
|
|
|
replace into t1 values (1, 11);
|
|
|
|
|
select row_count();
|
|
|
|
|
row_count()
|
|
|
|
|
2
|
|
|
|
|
replace into t1 values (4, 4);
|
|
|
|
|
select row_count();
|
|
|
|
|
row_count()
|
|
|
|
|
1
|
|
|
|
|
insert into t1 values (2, 2) on duplicate key update data= data + 10;
|
|
|
|
|
select row_count();
|
|
|
|
|
row_count()
|
|
|
|
|
2
|
|
|
|
|
insert into t1 values (5, 5) on duplicate key update data= data + 10;
|
|
|
|
|
select row_count();
|
|
|
|
|
row_count()
|
|
|
|
|
1
|
|
|
|
|
drop table t1;
|
2007-01-22 13:14:38 +01:00
|
|
|
create table t1 (f1 int unique, f2 int);
|
|
|
|
|
create table t2 (f3 int, f4 int);
|
|
|
|
|
create view v1 as select * from t1, t2 where f1= f3;
|
|
|
|
|
insert into t1 values (1,11), (2,22);
|
|
|
|
|
insert into t2 values (1,12), (2,24);
|
|
|
|
|
insert into v1 (f1) values (3) on duplicate key update f3= f3 + 10;
|
|
|
|
|
ERROR HY000: Can not modify more than one base table through a join view 'test.v1'
|
|
|
|
|
insert into v1 (f1) values (3) on duplicate key update f1= f3 + 10;
|
|
|
|
|
select * from t1;
|
|
|
|
|
f1 f2
|
|
|
|
|
1 11
|
|
|
|
|
2 22
|
|
|
|
|
3 NULL
|
|
|
|
|
insert into v1 (f1) values (3) on duplicate key update f1= f3 + 10;
|
|
|
|
|
select * from t1;
|
|
|
|
|
f1 f2
|
|
|
|
|
1 11
|
|
|
|
|
2 22
|
|
|
|
|
12 NULL
|
|
|
|
|
drop view v1;
|
|
|
|
|
drop table t1,t2;
|
WL#3146 "less locking in auto_increment":
this is a cleanup patch for our current auto_increment handling:
new names for auto_increment variables in THD, new methods to manipulate them
(see sql_class.h), some move into handler::, causing less backup/restore
work when executing substatements.
This makes the logic hopefully clearer, less work is is needed in
mysql_insert().
By cleaning up, using different variables for different purposes (instead
of one for 3 things...), we fix those bugs, which someone may want to fix
in 5.0 too:
BUG#20339 "stored procedure using LAST_INSERT_ID() does not replicate
statement-based"
BUG#20341 "stored function inserting into one auto_increment puts bad
data in slave"
BUG#19243 "wrong LAST_INSERT_ID() after ON DUPLICATE KEY UPDATE"
(now if a row is updated, LAST_INSERT_ID() will return its id)
and re-fixes:
BUG#6880 "LAST_INSERT_ID() value changes during multi-row INSERT"
(already fixed differently by Ramil in 4.1)
Test of documented behaviour of mysql_insert_id() (there was no test).
The behaviour changes introduced are:
- LAST_INSERT_ID() now returns "the first autogenerated auto_increment value
successfully inserted", instead of "the first autogenerated auto_increment
value if any row was successfully inserted", see auto_increment.test.
Same for mysql_insert_id(), see mysql_client_test.c.
- LAST_INSERT_ID() returns the id of the updated row if ON DUPLICATE KEY
UPDATE, see auto_increment.test. Same for mysql_insert_id(), see
mysql_client_test.c.
- LAST_INSERT_ID() does not change if no autogenerated value was successfully
inserted (it used to then be 0), see auto_increment.test.
- if in INSERT SELECT no autogenerated value was successfully inserted,
mysql_insert_id() now returns the id of the last inserted row (it already
did this for INSERT VALUES), see mysql_client_test.c.
- if INSERT SELECT uses LAST_INSERT_ID(X), mysql_insert_id() now returns X
(it already did this for INSERT VALUES), see mysql_client_test.c.
- NDB now behaves like other engines wrt SET INSERT_ID: with INSERT IGNORE,
the id passed in SET INSERT_ID is re-used until a row succeeds; SET INSERT_ID
influences not only the first row now.
Additionally, when unlocking a table we check that the thread is not keeping
a next_insert_id (as the table is unlocked that id is potentially out-of-date);
forgetting about this next_insert_id is done in a new
handler::ha_release_auto_increment().
Finally we prepare for engines capable of reserving finite-length intervals
of auto_increment values: we store such intervals in THD. The next step
(to be done by the replication team in 5.1) is to read those intervals from
THD and actually store them in the statement-based binary log. NDB
will be a good engine to test that.
2006-07-09 17:52:19 +02:00
|
|
|
create table t1 (id int primary key auto_increment, data int, unique(data));
|
|
|
|
|
insert ignore into t1 values(NULL,100),(NULL,110),(NULL,120);
|
|
|
|
|
insert ignore into t1 values(NULL,10),(NULL,20),(NULL,110),(NULL,120),(NULL,100),(NULL,90);
|
|
|
|
|
insert ignore into t1 values(NULL,130),(NULL,140),(500,110),(550,120),(450,100),(NULL,150);
|
|
|
|
|
select * from t1 order by id;
|
|
|
|
|
id data
|
|
|
|
|
1 100
|
|
|
|
|
2 110
|
|
|
|
|
3 120
|
|
|
|
|
4 10
|
|
|
|
|
5 20
|
|
|
|
|
6 90
|
|
|
|
|
7 130
|
|
|
|
|
8 140
|
|
|
|
|
9 150
|
2007-03-01 14:16:38 +01:00
|
|
|
drop table t1;
|
A fix and a test case for
Bug#21483 "Server abort or deadlock on INSERT DELAYED with another
implicit insert"
Also fixes and adds test cases for bugs:
20497 "Trigger with INSERT DELAYED causes Error 1165"
21714 "Wrong NEW.value and server abort on INSERT DELAYED to a
table with a trigger".
Post-review fixes.
Problem:
In MySQL INSERT DELAYED is a way to pipe all inserts into a
given table through a dedicated thread. This is necessary for
simplistic storage engines like MyISAM, which do not have internal
concurrency control or threading and thus can not
achieve efficient INSERT throughput without support from SQL layer.
DELAYED INSERT works as follows:
For every distinct table, which can accept DELAYED inserts and has
pending data to insert, a dedicated thread is created to write data
to disk. All user connection threads that attempt to
delayed-insert into this table interact with the dedicated thread in
producer/consumer fashion: all records to-be inserted are pushed
into a queue of the dedicated thread, which fetches the records and
writes them.
In this design, client connection threads never open or lock
the delayed insert table.
This functionality was introduced in version 3.23 and does not take
into account existence of triggers, views, or pre-locking.
E.g. if INSERT DELAYED is called from a stored function, which,
in turn, is called from another stored function that uses the delayed
table, a deadlock can occur, because delayed locking by-passes
pre-locking. Besides:
* the delayed thread works directly with the subject table through
the storage engine API and does not invoke triggers
* even if it was patched to invoke triggers, if triggers,
in turn, used other tables, the delayed thread would
have to open and lock involved tables (use pre-locking).
* even if it was patched to use pre-locking, without deadlock
detection the delayed thread could easily lock out user
connection threads in case when the same table is used both
in a trigger and on the right side of the insert query:
the delayed thread would not release locks until all inserts
are complete, and user connection can not complete inserts
without having locks on the tables used on the right side of the
query.
Solution:
These considerations suggest two general alternatives for the
future of INSERT DELAYED:
* it is considered a full-fledged alternative to normal INSERT
* it is regarded as an optimisation that is only relevant
for simplistic engines.
Since we missed our chance to provide complete support of new
features when 5.0 was in development, the first alternative
currently renders infeasible.
However, even the second alternative, which is to detect
new features and convert DELAYED insert into a normal insert,
is not easy to implement.
The catch-22 is that we don't know if the subject table has triggers
or is a view before we open it, and we only open it in the
delayed thread. We don't know if the query involves pre-locking
until we have opened all tables, and we always first create
the delayed thread, and only then open the remaining tables.
This patch detects the problematic scenarios and converts
DELAYED INSERT to a normal INSERT using the following approach:
* if the statement is executed under pre-locking (e.g. from
within a stored function or trigger) or the right
side may require pre-locking, we detect the situation
before creating a delayed insert thread and convert the statement
to a conventional INSERT.
* if the subject table is a view or has triggers, we shutdown
the delayed thread and convert the statement to a conventional
INSERT.
2007-05-16 07:51:05 +02:00
|
|
|
DROP TABLE IF EXISTS t1;
|
|
|
|
|
DROP FUNCTION IF EXISTS f1;
|
|
|
|
|
DROP FUNCTION IF EXISTS f2;
|
|
|
|
|
CREATE TABLE t1 (i INT);
|
|
|
|
|
CREATE FUNCTION f1() RETURNS INT
|
|
|
|
|
BEGIN
|
|
|
|
|
INSERT INTO t1 VALUES (1);
|
|
|
|
|
RETURN 1;
|
|
|
|
|
END |
|
|
|
|
|
CREATE FUNCTION f2() RETURNS INT
|
|
|
|
|
BEGIN
|
|
|
|
|
INSERT DELAYED INTO t1 VALUES (2);
|
|
|
|
|
RETURN 1;
|
|
|
|
|
END |
|
|
|
|
|
SELECT f1();
|
|
|
|
|
f1()
|
|
|
|
|
1
|
|
|
|
|
SELECT f2();
|
|
|
|
|
f2()
|
|
|
|
|
1
|
|
|
|
|
INSERT INTO t1 VALUES (3);
|
|
|
|
|
INSERT DELAYED INTO t1 VALUES (4);
|
|
|
|
|
INSERT INTO t1 VALUES (f1());
|
|
|
|
|
ERROR HY000: Can't update table 't1' in stored function/trigger because it is already used by statement which invoked this stored function/trigger.
|
|
|
|
|
INSERT DELAYED INTO t1 VALUES (f1());
|
|
|
|
|
ERROR HY000: Can't update table 't1' in stored function/trigger because it is already used by statement which invoked this stored function/trigger.
|
|
|
|
|
INSERT INTO t1 VALUES (f2());
|
|
|
|
|
ERROR HY000: Can't update table 't1' in stored function/trigger because it is already used by statement which invoked this stored function/trigger.
|
|
|
|
|
INSERT DELAYED INTO t1 VALUES (f2());
|
|
|
|
|
ERROR HY000: Can't update table 't1' in stored function/trigger because it is already used by statement which invoked this stored function/trigger.
|
|
|
|
|
CREATE TRIGGER t1_bi BEFORE INSERT ON t1 FOR EACH ROW
|
|
|
|
|
INSERT INTO t1 VALUES (NEW.i);
|
|
|
|
|
INSERT INTO t1 VALUES (1);
|
|
|
|
|
ERROR HY000: Can't update table 't1' in stored function/trigger because it is already used by statement which invoked this stored function/trigger.
|
|
|
|
|
INSERT DELAYED INTO t1 VALUES (1);
|
|
|
|
|
ERROR HY000: Can't update table 't1' in stored function/trigger because it is already used by statement which invoked this stored function/trigger.
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
i
|
|
|
|
|
1
|
|
|
|
|
2
|
|
|
|
|
3
|
|
|
|
|
4
|
|
|
|
|
DROP FUNCTION f2;
|
|
|
|
|
DROP FUNCTION f1;
|
|
|
|
|
DROP TABLE t1;
|
|
|
|
|
DROP TABLE IF EXISTS t1, t2;
|
|
|
|
|
CREATE TABLE t1 (i INT);
|
|
|
|
|
CREATE TABLE t2 (i INT);
|
|
|
|
|
CREATE TRIGGER t1_bi BEFORE INSERT ON t1 FOR EACH ROW
|
|
|
|
|
INSERT DELAYED INTO t2 VALUES (NEW.i);
|
|
|
|
|
CREATE TRIGGER t1_bu BEFORE UPDATE ON t1 FOR EACH ROW
|
|
|
|
|
INSERT DELAYED INTO t2 VALUES (NEW.i);
|
|
|
|
|
CREATE TRIGGER t1_bd BEFORE DELETE ON t1 FOR EACH ROW
|
|
|
|
|
INSERT DELAYED INTO t2 VALUES (OLD.i);
|
|
|
|
|
INSERT INTO t1 VALUES (1);
|
|
|
|
|
INSERT DELAYED INTO t1 VALUES (2);
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
i
|
|
|
|
|
1
|
|
|
|
|
2
|
|
|
|
|
UPDATE t1 SET i = 3 WHERE i = 1;
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
i
|
|
|
|
|
3
|
|
|
|
|
2
|
|
|
|
|
DELETE FROM t1 WHERE i = 3;
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
i
|
|
|
|
|
2
|
|
|
|
|
SELECT * FROM t2;
|
|
|
|
|
i
|
|
|
|
|
1
|
|
|
|
|
2
|
|
|
|
|
3
|
|
|
|
|
3
|
|
|
|
|
DROP TABLE t1, t2;
|
|
|
|
|
DROP TABLE IF EXISTS t1, t2;
|
|
|
|
|
CREATE TABLE t1 (i INT);
|
|
|
|
|
CREATE TRIGGER t1_bi BEFORE INSERT ON t1 FOR EACH ROW
|
|
|
|
|
SET @a= NEW.i;
|
|
|
|
|
SET @a= 0;
|
|
|
|
|
INSERT DELAYED INTO t1 VALUES (1);
|
|
|
|
|
SELECT @a;
|
|
|
|
|
@a
|
|
|
|
|
1
|
|
|
|
|
INSERT DELAYED INTO t1 VALUES (2);
|
|
|
|
|
SELECT @a;
|
|
|
|
|
@a
|
|
|
|
|
2
|
|
|
|
|
DROP TABLE t1;
|
|
|
|
|
CREATE TABLE t1 (i INT);
|
|
|
|
|
CREATE TABLE t2 (i INT);
|
|
|
|
|
CREATE TRIGGER t1_ai AFTER INSERT ON t1 FOR EACH ROW
|
|
|
|
|
INSERT INTO t2 VALUES (NEW.i);
|
|
|
|
|
CREATE TRIGGER t1_au AFTER UPDATE ON t1 FOR EACH ROW
|
|
|
|
|
INSERT DELAYED INTO t2 VALUES (NEW.i);
|
|
|
|
|
CREATE TRIGGER t1_ad AFTER DELETE ON t1 FOR EACH ROW
|
|
|
|
|
INSERT DELAYED INTO t2 VALUES (OLD.i);
|
|
|
|
|
INSERT DELAYED INTO t1 VALUES (1);
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
i
|
|
|
|
|
1
|
|
|
|
|
UPDATE t1 SET i = 2 WHERE i = 1;
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
i
|
|
|
|
|
2
|
|
|
|
|
DELETE FROM t1 WHERE i = 2;
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
i
|
|
|
|
|
SELECT * FROM t2;
|
|
|
|
|
i
|
|
|
|
|
1
|
|
|
|
|
2
|
|
|
|
|
2
|
|
|
|
|
DROP TABLE t1, t2;
|
2007-12-01 08:05:59 +01:00
|
|
|
CREATE TABLE t1 (
|
|
|
|
|
a char(20) NOT NULL,
|
|
|
|
|
b char(7) DEFAULT NULL,
|
|
|
|
|
c char(4) DEFAULT NULL
|
|
|
|
|
);
|
|
|
|
|
INSERT INTO t1(a,b,c) VALUES (9.999999e+0, 9.999999e+0, 9.999e+0);
|
|
|
|
|
INSERT INTO t1(a,b,c) VALUES (1.225e-05, 1.225e-05, 1.225e-05);
|
|
|
|
|
Warnings:
|
|
|
|
|
Warning 1265 Data truncated for column 'c' at row 1
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e-04, 1.225e-04);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e-01, 1.225e-01);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225877e-01, 1.225877e-01);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e+01, 1.225e+01);
|
|
|
|
|
INSERT INTO t1(a,b,c) VALUES (1.225e+01, 1.225e+01, 1.225e+01);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e+05, 1.225e+05);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e+10, 1.225e+10);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e+15, 1.225e+15);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (5000000e+0, 5000000e+0);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.25e+78, 1.25e+78);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.25e-94, 1.25e-94);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.25e+203, 1.25e+203);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.25e-175, 1.25e-175);
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (1.225e+0, 1.225e+0);
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (1.37e+0, 1.37e+0);
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (-1.37e+0, -1.37e+0);
|
|
|
|
|
Warnings:
|
|
|
|
|
Warning 1265 Data truncated for column 'c' at row 1
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (1.87e-3, 1.87e-3);
|
|
|
|
|
Warnings:
|
|
|
|
|
Warning 1265 Data truncated for column 'c' at row 1
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (-1.87e-2, -1.87e-2);
|
|
|
|
|
Warnings:
|
|
|
|
|
Warning 1265 Data truncated for column 'c' at row 1
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (5000e+0, 5000e+0);
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (-5000e+0, -5000e+0);
|
|
|
|
|
Warnings:
|
|
|
|
|
Warning 1265 Data truncated for column 'c' at row 1
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
a b c
|
2007-12-01 13:25:24 +01:00
|
|
|
9.999999 10 10
|
2007-12-01 08:05:59 +01:00
|
|
|
1.225e-05 1.2e-05 1e-0
|
|
|
|
|
0.0001225 0.00012 NULL
|
2007-12-01 13:25:24 +01:00
|
|
|
0.1225 0.1225 NULL
|
|
|
|
|
0.1225877 0.12259 NULL
|
2007-12-01 08:05:59 +01:00
|
|
|
12.25 12.25 NULL
|
|
|
|
|
12.25 12.25 12.2
|
|
|
|
|
122500 122500 NULL
|
|
|
|
|
12250000000 1.2e+10 NULL
|
2007-12-01 13:25:24 +01:00
|
|
|
1.225e+15 1.2e+15 NULL
|
2007-12-01 08:05:59 +01:00
|
|
|
5000000 5000000 NULL
|
|
|
|
|
1.25e+78 1.2e+78 NULL
|
|
|
|
|
1.25e-94 1.2e-94 NULL
|
|
|
|
|
1.25e+203 1e+203 NULL
|
|
|
|
|
1.25e-175 1e-175 NULL
|
2007-12-01 13:25:24 +01:00
|
|
|
1.225 NULL 1.23
|
|
|
|
|
1.37 NULL 1.37
|
2007-12-01 08:05:59 +01:00
|
|
|
-1.37 NULL -1.3
|
|
|
|
|
0.00187 NULL 0.00
|
|
|
|
|
-0.0187 NULL -0.0
|
|
|
|
|
5000 NULL 5000
|
|
|
|
|
-5000 NULL -500
|
|
|
|
|
DROP TABLE t1;
|
|
|
|
|
CREATE TABLE t1 (
|
|
|
|
|
a char(20) NOT NULL,
|
|
|
|
|
b char(7) DEFAULT NULL,
|
|
|
|
|
c char(5)
|
|
|
|
|
);
|
|
|
|
|
INSERT INTO t1(a,b,c) VALUES (9.999999e+0, 9.999999e+0, 9.999e+0);
|
|
|
|
|
INSERT INTO t1(a,b,c) VALUES (1.225e-05, 1.225e-05, 1.225e-05);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e-04, 1.225e-04);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e-01, 1.225e-01);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225877e-01, 1.225877e-01);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e+01, 1.225e+01);
|
|
|
|
|
INSERT INTO t1(a,b,c) VALUES (1.225e+01, 1.225e+01, 1.225e+01);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e+05, 1.225e+05);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e+10, 1.225e+10);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.225e+15, 1.225e+15);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (5000000e+0, 5000000e+0);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.25e+78, 1.25e+78);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.25e-94, 1.25e-94);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.25e+203, 1.25e+203);
|
|
|
|
|
INSERT INTO t1(a,b) VALUES (1.25e-175, 1.25e-175);
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (1.225e+0, 1.225e+0);
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (1.37e+0, 1.37e+0);
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (-1.37e+0, -1.37e+0);
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (1.87e-3, 1.87e-3);
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (-1.87e-2, -1.87e-2);
|
|
|
|
|
Warnings:
|
|
|
|
|
Warning 1265 Data truncated for column 'c' at row 1
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (5000e+0, 5000e+0);
|
|
|
|
|
INSERT INTO t1(a,c) VALUES (-5000e+0, -5000e+0);
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
a b c
|
2007-12-01 13:25:24 +01:00
|
|
|
9.999999 10 9.999
|
2007-12-01 08:05:59 +01:00
|
|
|
1.225e-05 1.2e-05 1e-05
|
|
|
|
|
0.0001225 0.00012 NULL
|
2007-12-01 13:25:24 +01:00
|
|
|
0.1225 0.1225 NULL
|
|
|
|
|
0.1225877 0.12259 NULL
|
2007-12-01 08:05:59 +01:00
|
|
|
12.25 12.25 NULL
|
|
|
|
|
12.25 12.25 12.25
|
|
|
|
|
122500 122500 NULL
|
|
|
|
|
12250000000 1.2e+10 NULL
|
2007-12-01 13:25:24 +01:00
|
|
|
1.225e+15 1.2e+15 NULL
|
2007-12-01 08:05:59 +01:00
|
|
|
5000000 5000000 NULL
|
|
|
|
|
1.25e+78 1.2e+78 NULL
|
|
|
|
|
1.25e-94 1.2e-94 NULL
|
|
|
|
|
1.25e+203 1e+203 NULL
|
|
|
|
|
1.25e-175 1e-175 NULL
|
2007-12-01 13:25:24 +01:00
|
|
|
1.225 NULL 1.225
|
|
|
|
|
1.37 NULL 1.37
|
2007-12-01 08:05:59 +01:00
|
|
|
-1.37 NULL -1.37
|
|
|
|
|
0.00187 NULL 0.002
|
|
|
|
|
-0.0187 NULL -0.01
|
|
|
|
|
5000 NULL 5000
|
|
|
|
|
-5000 NULL -5000
|
|
|
|
|
DROP TABLE t1;
|
|
|
|
|
CREATE TABLE t (a CHAR(10),b INT);
|
|
|
|
|
INSERT INTO t VALUES (),(),();
|
|
|
|
|
INSERT INTO t(a) SELECT rand() FROM t;
|
|
|
|
|
DROP TABLE t;
|
2007-10-15 08:34:34 +02:00
|
|
|
CREATE TABLE t1 (c1 INT NOT NULL);
|
|
|
|
|
INSERT INTO t1 VALUES(4188.32999999999992724042385816574096679687500),
|
|
|
|
|
('4188.32999999999992724042385816574096679687500'), (4188);
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
c1
|
|
|
|
|
4188
|
|
|
|
|
4188
|
|
|
|
|
4188
|
|
|
|
|
CREATE TABLE t2 (c1 BIGINT);
|
|
|
|
|
INSERT INTO t2 VALUES('15449237462.0000000000');
|
|
|
|
|
SELECT * FROM t2;
|
|
|
|
|
c1
|
|
|
|
|
15449237462
|
|
|
|
|
DROP TABLE t1, t2;
|
2009-04-09 11:19:31 +02:00
|
|
|
CREATE TABLE t1(f1 FLOAT);
|
|
|
|
|
INSERT INTO t1 VALUES (1.23);
|
|
|
|
|
CREATE TABLE t2(f1 CHAR(1));
|
|
|
|
|
INSERT INTO t2 SELECT f1 FROM t1;
|
|
|
|
|
DROP TABLE t1, t2;
|
A fix and a test case for
Bug#21483 "Server abort or deadlock on INSERT DELAYED with another
implicit insert"
Also fixes and adds test cases for bugs:
20497 "Trigger with INSERT DELAYED causes Error 1165"
21714 "Wrong NEW.value and server abort on INSERT DELAYED to a
table with a trigger".
Post-review fixes.
Problem:
In MySQL INSERT DELAYED is a way to pipe all inserts into a
given table through a dedicated thread. This is necessary for
simplistic storage engines like MyISAM, which do not have internal
concurrency control or threading and thus can not
achieve efficient INSERT throughput without support from SQL layer.
DELAYED INSERT works as follows:
For every distinct table, which can accept DELAYED inserts and has
pending data to insert, a dedicated thread is created to write data
to disk. All user connection threads that attempt to
delayed-insert into this table interact with the dedicated thread in
producer/consumer fashion: all records to-be inserted are pushed
into a queue of the dedicated thread, which fetches the records and
writes them.
In this design, client connection threads never open or lock
the delayed insert table.
This functionality was introduced in version 3.23 and does not take
into account existence of triggers, views, or pre-locking.
E.g. if INSERT DELAYED is called from a stored function, which,
in turn, is called from another stored function that uses the delayed
table, a deadlock can occur, because delayed locking by-passes
pre-locking. Besides:
* the delayed thread works directly with the subject table through
the storage engine API and does not invoke triggers
* even if it was patched to invoke triggers, if triggers,
in turn, used other tables, the delayed thread would
have to open and lock involved tables (use pre-locking).
* even if it was patched to use pre-locking, without deadlock
detection the delayed thread could easily lock out user
connection threads in case when the same table is used both
in a trigger and on the right side of the insert query:
the delayed thread would not release locks until all inserts
are complete, and user connection can not complete inserts
without having locks on the tables used on the right side of the
query.
Solution:
These considerations suggest two general alternatives for the
future of INSERT DELAYED:
* it is considered a full-fledged alternative to normal INSERT
* it is regarded as an optimisation that is only relevant
for simplistic engines.
Since we missed our chance to provide complete support of new
features when 5.0 was in development, the first alternative
currently renders infeasible.
However, even the second alternative, which is to detect
new features and convert DELAYED insert into a normal insert,
is not easy to implement.
The catch-22 is that we don't know if the subject table has triggers
or is a view before we open it, and we only open it in the
delayed thread. We don't know if the query involves pre-locking
until we have opened all tables, and we always first create
the delayed thread, and only then open the remaining tables.
This patch detects the problematic scenarios and converts
DELAYED INSERT to a normal INSERT using the following approach:
* if the statement is executed under pre-locking (e.g. from
within a stored function or trigger) or the right
side may require pre-locking, we detect the situation
before creating a delayed insert thread and convert the statement
to a conventional INSERT.
* if the subject table is a view or has triggers, we shutdown
the delayed thread and convert the statement to a conventional
INSERT.
2007-05-16 07:51:05 +02:00
|
|
|
End of 5.0 tests.
|