2006-02-15 17:11:24 +01:00
|
|
|
--source include/have_udf.inc
|
|
|
|
#
|
2006-07-29 04:41:50 +02:00
|
|
|
# To run this tests the "sql/udf_example.c" need to be compiled into
|
2006-03-10 10:41:04 +01:00
|
|
|
# udf_example.so and LD_LIBRARY_PATH should be setup to point out where
|
2006-02-15 17:11:24 +01:00
|
|
|
# the library are.
|
|
|
|
#
|
|
|
|
|
|
|
|
|
|
|
|
--disable_warnings
|
|
|
|
drop table if exists t1;
|
|
|
|
--enable_warnings
|
|
|
|
|
2006-03-10 10:41:04 +01:00
|
|
|
#
|
2006-02-15 17:11:24 +01:00
|
|
|
# Create the example functions from udf_example
|
|
|
|
#
|
|
|
|
|
2006-04-27 16:32:40 +02:00
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION metaphon RETURNS STRING SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION myfunc_double RETURNS REAL SONAME "$UDF_EXAMPLE_LIB";
|
2006-02-15 17:11:24 +01:00
|
|
|
|
2006-04-27 16:32:40 +02:00
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
2006-03-10 10:41:04 +01:00
|
|
|
--error ER_CANT_FIND_DL_ENTRY
|
2006-04-27 16:32:40 +02:00
|
|
|
eval CREATE FUNCTION myfunc_nonexist RETURNS INTEGER SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION myfunc_int RETURNS INTEGER SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION sequence RETURNS INTEGER SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION lookup RETURNS STRING SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION reverse_lookup
|
|
|
|
RETURNS STRING SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE AGGREGATE FUNCTION avgcost
|
|
|
|
RETURNS REAL SONAME "$UDF_EXAMPLE_LIB";
|
2006-02-15 17:11:24 +01:00
|
|
|
|
2007-10-31 22:31:57 +01:00
|
|
|
--error ER_CANT_INITIALIZE_UDF
|
2006-02-15 17:11:24 +01:00
|
|
|
select myfunc_double();
|
|
|
|
select myfunc_double(1);
|
|
|
|
select myfunc_double(78654);
|
2006-03-10 10:41:04 +01:00
|
|
|
--error 1305
|
2006-03-10 12:12:08 +01:00
|
|
|
select myfunc_nonexist();
|
2006-02-15 17:11:24 +01:00
|
|
|
select myfunc_int();
|
2007-10-31 22:31:57 +01:00
|
|
|
--error ER_CANT_INITIALIZE_UDF
|
2006-02-15 17:11:24 +01:00
|
|
|
select lookup();
|
|
|
|
select lookup("127.0.0.1");
|
2007-10-31 22:31:57 +01:00
|
|
|
--error ER_CANT_INITIALIZE_UDF
|
2006-02-15 17:11:24 +01:00
|
|
|
select lookup(127,0,0,1);
|
|
|
|
select lookup("localhost");
|
2007-10-31 22:31:57 +01:00
|
|
|
--error ER_CANT_INITIALIZE_UDF
|
2006-02-15 17:11:24 +01:00
|
|
|
select reverse_lookup();
|
2006-03-10 12:12:08 +01:00
|
|
|
|
|
|
|
# These two functions should return "localhost", but it's
|
|
|
|
# depending on configuration, so just call them and don't log the result
|
|
|
|
--disable_result_log
|
2006-02-15 17:11:24 +01:00
|
|
|
select reverse_lookup("127.0.0.1");
|
|
|
|
select reverse_lookup(127,0,0,1);
|
2006-03-10 12:12:08 +01:00
|
|
|
--enable_result_log
|
|
|
|
|
2006-02-15 17:11:24 +01:00
|
|
|
select reverse_lookup("localhost");
|
2007-10-31 22:31:57 +01:00
|
|
|
--error ER_CANT_INITIALIZE_UDF
|
2006-02-15 17:11:24 +01:00
|
|
|
select avgcost();
|
2007-10-31 22:31:57 +01:00
|
|
|
--error ER_CANT_INITIALIZE_UDF
|
2006-02-15 17:11:24 +01:00
|
|
|
select avgcost(100,23.76);
|
|
|
|
create table t1(sum int, price float(24));
|
|
|
|
insert into t1 values(100, 50.00), (100, 100.00);
|
|
|
|
select avgcost(sum, price) from t1;
|
|
|
|
delete from t1;
|
|
|
|
insert into t1 values(100, 54.33), (200, 199.99);
|
|
|
|
select avgcost(sum, price) from t1;
|
|
|
|
drop table t1;
|
|
|
|
|
|
|
|
#------------------------------------------------------------------------
|
|
|
|
# BUG#17261 Passing a variable from a stored procedure to UDF crashes mysqld
|
|
|
|
#------------------------------------------------------------------------
|
|
|
|
|
2006-03-10 10:41:04 +01:00
|
|
|
select metaphon('hello');
|
2006-02-15 17:11:24 +01:00
|
|
|
|
|
|
|
delimiter //;
|
|
|
|
CREATE PROCEDURE `XXX1`(in testval varchar(10))
|
2006-03-10 10:41:04 +01:00
|
|
|
begin
|
|
|
|
select metaphon(testval);
|
2006-02-15 17:11:24 +01:00
|
|
|
end//
|
|
|
|
delimiter ;//
|
|
|
|
|
|
|
|
call XXX1('hello');
|
|
|
|
drop procedure xxx1;
|
|
|
|
|
|
|
|
delimiter //;
|
|
|
|
CREATE PROCEDURE `XXX2`()
|
2006-03-10 10:41:04 +01:00
|
|
|
begin
|
2006-02-15 17:11:24 +01:00
|
|
|
declare testval varchar(10);
|
|
|
|
set testval = 'hello';
|
2006-03-10 10:41:04 +01:00
|
|
|
select metaphon(testval);
|
2006-02-15 17:11:24 +01:00
|
|
|
end//
|
|
|
|
delimiter ;//
|
|
|
|
|
|
|
|
call XXX2();
|
|
|
|
drop procedure xxx2;
|
|
|
|
|
2006-06-08 19:25:28 +02:00
|
|
|
#
|
|
|
|
# Bug#19904: UDF: not initialized *is_null per row
|
|
|
|
#
|
|
|
|
|
|
|
|
CREATE TABLE bug19904(n INT, v varchar(10));
|
|
|
|
INSERT INTO bug19904 VALUES (1,'one'),(2,'two'),(NULL,NULL),(3,'three'),(4,'four');
|
|
|
|
SELECT myfunc_double(n) AS f FROM bug19904;
|
|
|
|
SELECT metaphon(v) AS f FROM bug19904;
|
|
|
|
DROP TABLE bug19904;
|
|
|
|
|
2006-07-31 21:01:43 +02:00
|
|
|
#
|
|
|
|
# Bug#21269: DEFINER-clause is allowed for UDF-functions
|
|
|
|
#
|
|
|
|
|
Bug#28318 (CREATE FUNCTION (UDF) requires a schema) -- part II
The root cause of the issue was that the CREATE FUNCTION grammar,
for User Defined Functions, was using the sp_name rule.
The sp_name rule is intended for fully qualified stored procedure names,
like either ident.ident, or just ident but with a default database
implicitly selected.
A UDF does not have a fully qualified name, only a name (ident), and should
not use the sp_name grammar fragment during parsing.
The fix is to re-organize the CREATE FUNCTION grammar, to better separate:
- creating UDF (no definer, can have AGGREGATE, simple ident)
- creating Stored Functions (definer, no AGGREGATE, fully qualified name)
With the test case provided, another issue was exposed which is also fixed:
the DROP FUNCTION statement was using sp_name and also failing when no database
is implicitly selected, when droping UDF functions.
The fix is also to change the grammar so that DROP FUNCTION works with
both the ident.ident syntax (to drop a stored function), or just the ident
syntax (to drop either a UDF or a Stored Function, in the current database)
mysql-test/r/sp-error.result:
Adjust test results
mysql-test/r/udf.result:
Adjust test results
mysql-test/t/sp-error.test:
Adjust test results
mysql-test/t/udf.test:
Adjust test results
sql/sql_parse.cc:
CREATE UDF FUNCTION does not use a fully qualified name.
sql/sql_yacc.yy:
Fix grammar for CREATE / DROP FUNCTION, FOR udf
Improve error messages for select no_such_function()
2007-10-16 03:15:38 +02:00
|
|
|
--error ER_PARSE_ERROR
|
2006-07-31 21:01:43 +02:00
|
|
|
CREATE DEFINER=CURRENT_USER() FUNCTION should_not_parse
|
|
|
|
RETURNS STRING SONAME "should_not_parse.so";
|
|
|
|
|
Bug#28318 (CREATE FUNCTION (UDF) requires a schema) -- part II
The root cause of the issue was that the CREATE FUNCTION grammar,
for User Defined Functions, was using the sp_name rule.
The sp_name rule is intended for fully qualified stored procedure names,
like either ident.ident, or just ident but with a default database
implicitly selected.
A UDF does not have a fully qualified name, only a name (ident), and should
not use the sp_name grammar fragment during parsing.
The fix is to re-organize the CREATE FUNCTION grammar, to better separate:
- creating UDF (no definer, can have AGGREGATE, simple ident)
- creating Stored Functions (definer, no AGGREGATE, fully qualified name)
With the test case provided, another issue was exposed which is also fixed:
the DROP FUNCTION statement was using sp_name and also failing when no database
is implicitly selected, when droping UDF functions.
The fix is also to change the grammar so that DROP FUNCTION works with
both the ident.ident syntax (to drop a stored function), or just the ident
syntax (to drop either a UDF or a Stored Function, in the current database)
mysql-test/r/sp-error.result:
Adjust test results
mysql-test/r/udf.result:
Adjust test results
mysql-test/t/sp-error.test:
Adjust test results
mysql-test/t/udf.test:
Adjust test results
sql/sql_parse.cc:
CREATE UDF FUNCTION does not use a fully qualified name.
sql/sql_yacc.yy:
Fix grammar for CREATE / DROP FUNCTION, FOR udf
Improve error messages for select no_such_function()
2007-10-16 03:15:38 +02:00
|
|
|
--error ER_PARSE_ERROR
|
2006-07-31 21:01:43 +02:00
|
|
|
CREATE DEFINER=someone@somewhere FUNCTION should_not_parse
|
|
|
|
RETURNS STRING SONAME "should_not_parse.so";
|
2006-07-25 22:31:29 +02:00
|
|
|
#
|
|
|
|
# Bug#19862: Sort with filesort by function evaluates function twice
|
|
|
|
#
|
|
|
|
create table t1(f1 int);
|
|
|
|
insert into t1 values(1),(2);
|
|
|
|
explain select myfunc_int(f1) from t1 order by 1;
|
|
|
|
drop table t1;
|
2006-10-24 14:26:41 +02:00
|
|
|
|
|
|
|
#
|
|
|
|
# Bug #21809: Error 1356 while selecting from view with grouping though
|
|
|
|
# underlying select OK.
|
|
|
|
#
|
|
|
|
CREATE TABLE t1(a INT, b INT); INSERT INTO t1 values (1,1),(2,2);
|
|
|
|
|
|
|
|
DELIMITER ||;
|
|
|
|
CREATE FUNCTION fn(a int) RETURNS int DETERMINISTIC
|
|
|
|
BEGIN
|
|
|
|
RETURN a;
|
|
|
|
END
|
|
|
|
||
|
|
|
|
DELIMITER ;||
|
|
|
|
|
|
|
|
CREATE VIEW v1 AS SELECT a, fn(MIN(b)) as c FROM t1 GROUP BY a;
|
|
|
|
|
|
|
|
SELECT myfunc_int(a AS attr_name) FROM t1;
|
|
|
|
EXPLAIN EXTENDED SELECT myfunc_int(a AS attr_name) FROM t1;
|
|
|
|
EXPLAIN EXTENDED SELECT myfunc_int(a) FROM t1;
|
|
|
|
SELECT a,c FROM v1;
|
|
|
|
|
Bug#24736: UDF functions parsed as Stored Functions
Before this fix, a call to a User Defined Function (UDF) could,
under some circumstances, be interpreted as a call to a Stored function
instead. This occurred if a native function was invoked in the parameters
for the UDF, as in "select my_udf(abs(x))".
The root cause of this defect is the introduction, by the fix for Bug 21809,
of st_select_lex::udf_list, and it's usage in the parser in sql_yacc.yy
in the rule function_call_generic (in 5.1).
While the fix itself for Bug 21809 is correct in 5.0, the code change
merged into the 5.1 release created the issue, because the calls in 5.1 to :
- lex->current_select->udf_list.push_front(udf)
- lex->current_select->udf_list.pop()
are not balanced in case of native functions, causing the udf_list,
which is really a stack, to be out of sync with the internal stack
maintained by the bison parser.
Instead of moving the call to udf_list.pop(), which would have fixed the
symptom, this patch goes further and removes the need for udf_list.
This is motivated by two reasons:
a) Maintaining a stack in the MySQL code in sync with the stack maintained
internally in sql_yacc.cc (not .yy) is extremely dependent of the
implementation of yacc/bison, and extremely difficult to maintain.
It's also totally dependent of the structure of the grammar, and has a risk
to break with regression defects each time the grammar itself is changed.
b) The previous code did report construct like "foo(expr AS name)" as
syntax errors (ER_PARSER_ERROR), which is incorrect, and misleading.
The syntax is perfectly valid, as this expression is valid when "foo" is
a UDF. Whether this syntax is legal or not depends of the semantic of "foo".
With this change:
a) There is only one stack (in bison), and no List<udf_func> to maintain.
b) "foo(expr AS name)", when used incorrectly, is reported as semantic error:
- ER_WRONG_PARAMETERS_TO_NATIVE_FCT (for native functions)
- ER_WRONG_PARAMETERS_TO_STORED_FCT (for stored functions)
This is achieved by the changes implemented in item_create.cc
mysql-test/r/parser.result:
New tests
mysql-test/r/udf.result:
New tests
mysql-test/t/parser.test:
New tests
mysql-test/t/udf.test:
New tests
sql/item_create.cc:
Semantic checks for named parameters, as in "foo(expr AS name)".
sql/share/errmsg.txt:
New error message
sql/sql_lex.cc:
Remove usage of udf_list.
sql/sql_lex.h:
Remove usage of udf_list.
sql/sql_yacc.yy:
Remove usage of udf_list.
2006-12-02 03:16:03 +01:00
|
|
|
--error ER_WRONG_PARAMETERS_TO_STORED_FCT
|
2006-10-24 14:26:41 +02:00
|
|
|
SELECT a, fn(MIN(b) xx) as c FROM t1 GROUP BY a;
|
Bug#24736: UDF functions parsed as Stored Functions
Before this fix, a call to a User Defined Function (UDF) could,
under some circumstances, be interpreted as a call to a Stored function
instead. This occurred if a native function was invoked in the parameters
for the UDF, as in "select my_udf(abs(x))".
The root cause of this defect is the introduction, by the fix for Bug 21809,
of st_select_lex::udf_list, and it's usage in the parser in sql_yacc.yy
in the rule function_call_generic (in 5.1).
While the fix itself for Bug 21809 is correct in 5.0, the code change
merged into the 5.1 release created the issue, because the calls in 5.1 to :
- lex->current_select->udf_list.push_front(udf)
- lex->current_select->udf_list.pop()
are not balanced in case of native functions, causing the udf_list,
which is really a stack, to be out of sync with the internal stack
maintained by the bison parser.
Instead of moving the call to udf_list.pop(), which would have fixed the
symptom, this patch goes further and removes the need for udf_list.
This is motivated by two reasons:
a) Maintaining a stack in the MySQL code in sync with the stack maintained
internally in sql_yacc.cc (not .yy) is extremely dependent of the
implementation of yacc/bison, and extremely difficult to maintain.
It's also totally dependent of the structure of the grammar, and has a risk
to break with regression defects each time the grammar itself is changed.
b) The previous code did report construct like "foo(expr AS name)" as
syntax errors (ER_PARSER_ERROR), which is incorrect, and misleading.
The syntax is perfectly valid, as this expression is valid when "foo" is
a UDF. Whether this syntax is legal or not depends of the semantic of "foo".
With this change:
a) There is only one stack (in bison), and no List<udf_func> to maintain.
b) "foo(expr AS name)", when used incorrectly, is reported as semantic error:
- ER_WRONG_PARAMETERS_TO_NATIVE_FCT (for native functions)
- ER_WRONG_PARAMETERS_TO_STORED_FCT (for stored functions)
This is achieved by the changes implemented in item_create.cc
mysql-test/r/parser.result:
New tests
mysql-test/r/udf.result:
New tests
mysql-test/t/parser.test:
New tests
mysql-test/t/udf.test:
New tests
sql/item_create.cc:
Semantic checks for named parameters, as in "foo(expr AS name)".
sql/share/errmsg.txt:
New error message
sql/sql_lex.cc:
Remove usage of udf_list.
sql/sql_lex.h:
Remove usage of udf_list.
sql/sql_yacc.yy:
Remove usage of udf_list.
2006-12-02 03:16:03 +01:00
|
|
|
--error ER_WRONG_PARAMETERS_TO_STORED_FCT
|
2006-10-24 14:26:41 +02:00
|
|
|
SELECT myfunc_int(fn(MIN(b) xx)) as c FROM t1 GROUP BY a;
|
|
|
|
--error ER_PARSE_ERROR
|
|
|
|
SELECT myfunc_int(test.fn(MIN(b) xx)) as c FROM t1 GROUP BY a;
|
|
|
|
|
|
|
|
SELECT myfunc_int(fn(MIN(b)) xx) as c FROM t1 GROUP BY a;
|
|
|
|
SELECT myfunc_int(test.fn(MIN(b)) xx) as c FROM t1 GROUP BY a;
|
|
|
|
|
|
|
|
EXPLAIN EXTENDED SELECT myfunc_int(MIN(b) xx) as c FROM t1 GROUP BY a;
|
|
|
|
EXPLAIN EXTENDED SELECT test.fn(MIN(b)) as c FROM t1 GROUP BY a;
|
|
|
|
EXPLAIN EXTENDED SELECT myfunc_int(fn(MIN(b))) as c FROM t1 GROUP BY a;
|
|
|
|
EXPLAIN EXTENDED SELECT myfunc_int(test.fn(MIN(b))) as c FROM t1 GROUP BY a;
|
|
|
|
SELECT myfunc_int(MIN(b) xx) as c FROM t1 GROUP BY a;
|
|
|
|
SELECT test.fn(MIN(b)) as c FROM t1 GROUP BY a;
|
|
|
|
SELECT myfunc_int(fn(MIN(b))) as c FROM t1 GROUP BY a;
|
|
|
|
SELECT myfunc_int(test.fn(MIN(b))) as c FROM t1 GROUP BY a;
|
|
|
|
DROP VIEW v1;
|
|
|
|
DROP TABLE t1;
|
|
|
|
DROP FUNCTION fn;
|
|
|
|
|
2006-06-08 19:25:28 +02:00
|
|
|
--echo End of 5.0 tests.
|
2006-02-15 17:11:24 +01:00
|
|
|
|
Bug#24736: UDF functions parsed as Stored Functions
Before this fix, a call to a User Defined Function (UDF) could,
under some circumstances, be interpreted as a call to a Stored function
instead. This occurred if a native function was invoked in the parameters
for the UDF, as in "select my_udf(abs(x))".
The root cause of this defect is the introduction, by the fix for Bug 21809,
of st_select_lex::udf_list, and it's usage in the parser in sql_yacc.yy
in the rule function_call_generic (in 5.1).
While the fix itself for Bug 21809 is correct in 5.0, the code change
merged into the 5.1 release created the issue, because the calls in 5.1 to :
- lex->current_select->udf_list.push_front(udf)
- lex->current_select->udf_list.pop()
are not balanced in case of native functions, causing the udf_list,
which is really a stack, to be out of sync with the internal stack
maintained by the bison parser.
Instead of moving the call to udf_list.pop(), which would have fixed the
symptom, this patch goes further and removes the need for udf_list.
This is motivated by two reasons:
a) Maintaining a stack in the MySQL code in sync with the stack maintained
internally in sql_yacc.cc (not .yy) is extremely dependent of the
implementation of yacc/bison, and extremely difficult to maintain.
It's also totally dependent of the structure of the grammar, and has a risk
to break with regression defects each time the grammar itself is changed.
b) The previous code did report construct like "foo(expr AS name)" as
syntax errors (ER_PARSER_ERROR), which is incorrect, and misleading.
The syntax is perfectly valid, as this expression is valid when "foo" is
a UDF. Whether this syntax is legal or not depends of the semantic of "foo".
With this change:
a) There is only one stack (in bison), and no List<udf_func> to maintain.
b) "foo(expr AS name)", when used incorrectly, is reported as semantic error:
- ER_WRONG_PARAMETERS_TO_NATIVE_FCT (for native functions)
- ER_WRONG_PARAMETERS_TO_STORED_FCT (for stored functions)
This is achieved by the changes implemented in item_create.cc
mysql-test/r/parser.result:
New tests
mysql-test/r/udf.result:
New tests
mysql-test/t/parser.test:
New tests
mysql-test/t/udf.test:
New tests
sql/item_create.cc:
Semantic checks for named parameters, as in "foo(expr AS name)".
sql/share/errmsg.txt:
New error message
sql/sql_lex.cc:
Remove usage of udf_list.
sql/sql_lex.h:
Remove usage of udf_list.
sql/sql_yacc.yy:
Remove usage of udf_list.
2006-12-02 03:16:03 +01:00
|
|
|
#
|
|
|
|
# Bug#24736: UDF functions parsed as Stored Functions
|
|
|
|
#
|
|
|
|
|
|
|
|
select myfunc_double(3);
|
|
|
|
select myfunc_double(3 AS three);
|
|
|
|
select myfunc_double(abs(3));
|
|
|
|
select myfunc_double(abs(3) AS named_param);
|
|
|
|
select abs(myfunc_double(3));
|
|
|
|
select abs(myfunc_double(3 AS three));
|
|
|
|
|
|
|
|
-- error ER_WRONG_PARAMETERS_TO_NATIVE_FCT
|
|
|
|
select myfunc_double(abs(3 AS wrong));
|
|
|
|
-- error ER_WRONG_PARAMETERS_TO_NATIVE_FCT
|
|
|
|
select abs(myfunc_double(3) AS wrong);
|
|
|
|
|
Bug#18239 (Possible to overload internal functions with stored functions)
Bug#21025 (misleading error message when creating functions named 'x', or 'y')
Bug#22619 (Spaces considered harmful)
This change contains a fix to report warnings or errors, and multiple tests
cases.
Before this fix, name collisions between:
- Native functions
- User Defined Functions
- Stored Functions
were not systematically reported, leading to confusing behavior.
I) Native / User Defined Function
Before this fix, is was possible to create a UDF named "foo", with the same
name as a native function "foo", but it was impossible to invoke the UDF,
since the syntax "foo()" always refer to the native function.
After this fix, creating a UDF fails with an error if there is a name
collision with a native function.
II) Native / Stored Function
Before this fix, is was possible to create a SF named "db.foo", with the same
name as a native function "foo", but this was confusing since the syntax
"foo()" would refer to the native function. To refer to the Stored Function,
the user had to use the "db.foo()" syntax.
After this fix, creating a Stored Function reports a warning if there is a
name collision with a native function.
III) User Defined Function / Stored Function
Before this fix, creating a User Defined Function "foo" and a Stored Function
"db.foo" are mutually exclusive operations. Whenever the second function is
created, an error is reported. However, the test suite did not cover this
behavior.
After this fix, the behavior is unchanged, and is now covered by test cases.
Note that the code change in this patch depends on the fix for Bug 21114.
mysql-test/r/sp.result:
New test cases.
mysql-test/r/udf.result:
New test cases.
mysql-test/t/sp.test:
New test cases.
mysql-test/t/udf.test:
New test cases.
sql/sql_lex.cc:
Name collisions with native functions.
sql/sql_lex.h:
Name collisions with native functions.
sql/sql_yacc.yy:
Name collisions with native functions.
sql/share/errmsg.txt:
Name collisions with native functions.
mysql-test/r/sp_gis.result:
New test cases.
mysql-test/t/sp_gis.test:
New test cases.
2006-11-15 03:34:16 +01:00
|
|
|
#
|
|
|
|
# BUG#18239: Possible to overload internal functions with stored functions
|
|
|
|
#
|
|
|
|
|
|
|
|
--disable_warnings
|
|
|
|
drop function if exists pi;
|
|
|
|
--enable_warnings
|
|
|
|
|
|
|
|
--error ER_NATIVE_FCT_NAME_COLLISION
|
|
|
|
CREATE FUNCTION pi RETURNS STRING SONAME "should_not_parse.so";
|
|
|
|
|
|
|
|
# Verify that Stored Functions and UDF are mutually exclusive
|
|
|
|
DROP FUNCTION IF EXISTS metaphon;
|
|
|
|
|
|
|
|
CREATE FUNCTION metaphon(a int) RETURNS int
|
|
|
|
return 0;
|
|
|
|
|
2007-10-17 04:47:08 +02:00
|
|
|
# this currently passes, and eclipse the stored function
|
Bug#18239 (Possible to overload internal functions with stored functions)
Bug#21025 (misleading error message when creating functions named 'x', or 'y')
Bug#22619 (Spaces considered harmful)
This change contains a fix to report warnings or errors, and multiple tests
cases.
Before this fix, name collisions between:
- Native functions
- User Defined Functions
- Stored Functions
were not systematically reported, leading to confusing behavior.
I) Native / User Defined Function
Before this fix, is was possible to create a UDF named "foo", with the same
name as a native function "foo", but it was impossible to invoke the UDF,
since the syntax "foo()" always refer to the native function.
After this fix, creating a UDF fails with an error if there is a name
collision with a native function.
II) Native / Stored Function
Before this fix, is was possible to create a SF named "db.foo", with the same
name as a native function "foo", but this was confusing since the syntax
"foo()" would refer to the native function. To refer to the Stored Function,
the user had to use the "db.foo()" syntax.
After this fix, creating a Stored Function reports a warning if there is a
name collision with a native function.
III) User Defined Function / Stored Function
Before this fix, creating a User Defined Function "foo" and a Stored Function
"db.foo" are mutually exclusive operations. Whenever the second function is
created, an error is reported. However, the test suite did not cover this
behavior.
After this fix, the behavior is unchanged, and is now covered by test cases.
Note that the code change in this patch depends on the fix for Bug 21114.
mysql-test/r/sp.result:
New test cases.
mysql-test/r/udf.result:
New test cases.
mysql-test/t/sp.test:
New test cases.
mysql-test/t/udf.test:
New test cases.
sql/sql_lex.cc:
Name collisions with native functions.
sql/sql_lex.h:
Name collisions with native functions.
sql/sql_yacc.yy:
Name collisions with native functions.
sql/share/errmsg.txt:
Name collisions with native functions.
mysql-test/r/sp_gis.result:
New test cases.
mysql-test/t/sp_gis.test:
New test cases.
2006-11-15 03:34:16 +01:00
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION metaphon RETURNS STRING SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
|
2007-10-17 04:47:08 +02:00
|
|
|
DROP FUNCTION metaphon;
|
Bug#18239 (Possible to overload internal functions with stored functions)
Bug#21025 (misleading error message when creating functions named 'x', or 'y')
Bug#22619 (Spaces considered harmful)
This change contains a fix to report warnings or errors, and multiple tests
cases.
Before this fix, name collisions between:
- Native functions
- User Defined Functions
- Stored Functions
were not systematically reported, leading to confusing behavior.
I) Native / User Defined Function
Before this fix, is was possible to create a UDF named "foo", with the same
name as a native function "foo", but it was impossible to invoke the UDF,
since the syntax "foo()" always refer to the native function.
After this fix, creating a UDF fails with an error if there is a name
collision with a native function.
II) Native / Stored Function
Before this fix, is was possible to create a SF named "db.foo", with the same
name as a native function "foo", but this was confusing since the syntax
"foo()" would refer to the native function. To refer to the Stored Function,
the user had to use the "db.foo()" syntax.
After this fix, creating a Stored Function reports a warning if there is a
name collision with a native function.
III) User Defined Function / Stored Function
Before this fix, creating a User Defined Function "foo" and a Stored Function
"db.foo" are mutually exclusive operations. Whenever the second function is
created, an error is reported. However, the test suite did not cover this
behavior.
After this fix, the behavior is unchanged, and is now covered by test cases.
Note that the code change in this patch depends on the fix for Bug 21114.
mysql-test/r/sp.result:
New test cases.
mysql-test/r/udf.result:
New test cases.
mysql-test/t/sp.test:
New test cases.
mysql-test/t/udf.test:
New test cases.
sql/sql_lex.cc:
Name collisions with native functions.
sql/sql_lex.h:
Name collisions with native functions.
sql/sql_yacc.yy:
Name collisions with native functions.
sql/share/errmsg.txt:
Name collisions with native functions.
mysql-test/r/sp_gis.result:
New test cases.
mysql-test/t/sp_gis.test:
New test cases.
2006-11-15 03:34:16 +01:00
|
|
|
DROP FUNCTION metaphon;
|
|
|
|
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION metaphon RETURNS STRING SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
|
|
|
|
--error ER_UDF_EXISTS
|
|
|
|
CREATE FUNCTION metaphon(a int) RETURNS int
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
--error ER_UDF_EXISTS
|
|
|
|
CREATE FUNCTION test.metaphon(a int) RETURNS int
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
# End of Bug#18239
|
|
|
|
|
2006-03-10 10:41:04 +01:00
|
|
|
#
|
2006-02-15 17:11:24 +01:00
|
|
|
# Drop the example functions from udf_example
|
|
|
|
#
|
|
|
|
|
|
|
|
DROP FUNCTION metaphon;
|
|
|
|
DROP FUNCTION myfunc_double;
|
2006-03-10 10:41:04 +01:00
|
|
|
--error ER_SP_DOES_NOT_EXIST
|
2006-03-10 12:12:08 +01:00
|
|
|
DROP FUNCTION myfunc_nonexist;
|
2006-02-15 17:11:24 +01:00
|
|
|
DROP FUNCTION myfunc_int;
|
|
|
|
DROP FUNCTION sequence;
|
|
|
|
DROP FUNCTION lookup;
|
|
|
|
DROP FUNCTION reverse_lookup;
|
|
|
|
DROP FUNCTION avgcost;
|
|
|
|
|
2006-12-15 10:38:30 +01:00
|
|
|
#
|
|
|
|
# Bug #15439: UDF name case handling forces DELETE FROM mysql.func to remove
|
|
|
|
# the UDF
|
|
|
|
#
|
|
|
|
select * from mysql.func;
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION is_const RETURNS STRING SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
|
|
|
|
select IS_const(3);
|
|
|
|
|
|
|
|
drop function IS_const;
|
|
|
|
|
|
|
|
select * from mysql.func;
|
|
|
|
|
|
|
|
--error 1305
|
|
|
|
select is_const(3);
|
|
|
|
|
2006-11-13 19:13:44 +01:00
|
|
|
#
|
|
|
|
# Bug#18761: constant expression as UDF parameters not passed in as constant
|
|
|
|
#
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION is_const RETURNS STRING SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
|
|
|
|
select
|
|
|
|
is_const(3) as const,
|
|
|
|
is_const(3.14) as const,
|
|
|
|
is_const('fnord') as const,
|
|
|
|
is_const(2+3) as const,
|
|
|
|
is_const(rand()) as 'nc rand()',
|
|
|
|
is_const(sin(3.14)) as const,
|
|
|
|
is_const(upper('test')) as const;
|
|
|
|
|
|
|
|
create table bug18761 (n int);
|
|
|
|
insert into bug18761 values (null),(2);
|
|
|
|
select
|
|
|
|
is_const(3) as const,
|
|
|
|
is_const(3.14) as const,
|
|
|
|
is_const('fnord') as const,
|
|
|
|
is_const(2+3) as const,
|
|
|
|
is_const(2+n) as 'nc 2+n ',
|
|
|
|
is_const(sin(n)) as 'nc sin(n)',
|
|
|
|
is_const(sin(3.14)) as const,
|
|
|
|
is_const(upper('test')) as const,
|
|
|
|
is_const(rand()) as 'nc rand()',
|
|
|
|
is_const(n) as 'nc n ',
|
|
|
|
is_const(is_const(n)) as 'nc ic?(n)',
|
|
|
|
is_const(is_const('c')) as const
|
|
|
|
from
|
|
|
|
bug18761;
|
|
|
|
drop table bug18761;
|
|
|
|
|
|
|
|
--error 1241
|
|
|
|
select is_const((1,2,3));
|
|
|
|
|
|
|
|
drop function if exists is_const;
|
2007-01-18 16:33:38 +01:00
|
|
|
|
|
|
|
#
|
|
|
|
# Bug #25382: Passing NULL to an UDF called from stored procedures
|
|
|
|
# crashes server
|
|
|
|
#
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION metaphon RETURNS STRING SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION myfunc_double RETURNS REAL SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION myfunc_int RETURNS INTEGER SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
|
|
|
|
delimiter //;
|
|
|
|
create function f1(p1 varchar(255))
|
|
|
|
returns varchar(255)
|
|
|
|
begin
|
|
|
|
return metaphon(p1);
|
|
|
|
end//
|
|
|
|
|
|
|
|
create function f2(p1 varchar(255))
|
|
|
|
returns double
|
|
|
|
begin
|
|
|
|
return myfunc_double(p1);
|
|
|
|
end//
|
|
|
|
|
|
|
|
create function f3(p1 varchar(255))
|
|
|
|
returns double
|
|
|
|
begin
|
|
|
|
return myfunc_int(p1);
|
|
|
|
end//
|
|
|
|
|
|
|
|
delimiter ;//
|
|
|
|
|
|
|
|
select f3(NULL);
|
|
|
|
select f2(NULL);
|
|
|
|
select f1(NULL);
|
|
|
|
|
|
|
|
drop function f1;
|
|
|
|
drop function f2;
|
|
|
|
drop function f3;
|
|
|
|
drop function metaphon;
|
|
|
|
drop function myfunc_double;
|
|
|
|
drop function myfunc_int;
|
|
|
|
|
2007-06-18 23:55:12 +02:00
|
|
|
#
|
|
|
|
# Bug #28921: Queries containing UDF functions are cached
|
|
|
|
#
|
|
|
|
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION metaphon RETURNS STRING SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
create table t1 (a char);
|
|
|
|
|
|
|
|
set GLOBAL query_cache_size=1355776;
|
|
|
|
reset query cache;
|
|
|
|
|
|
|
|
select metaphon('MySQL') from t1;
|
|
|
|
show status like "Qcache_hits";
|
|
|
|
show status like "Qcache_queries_in_cache";
|
|
|
|
|
|
|
|
select metaphon('MySQL') from t1;
|
|
|
|
show status like "Qcache_hits";
|
|
|
|
show status like "Qcache_queries_in_cache";
|
|
|
|
|
|
|
|
drop table t1;
|
|
|
|
drop function metaphon;
|
|
|
|
set GLOBAL query_cache_size=default;
|
|
|
|
|
2007-10-10 01:46:33 +02:00
|
|
|
#
|
|
|
|
# Bug#28318 CREATE FUNCTION (UDF) requires a schema
|
|
|
|
#
|
|
|
|
|
|
|
|
--disable_warnings
|
|
|
|
DROP DATABASE IF EXISTS mysqltest;
|
|
|
|
--enable_warnings
|
|
|
|
CREATE DATABASE mysqltest;
|
|
|
|
USE mysqltest;
|
|
|
|
DROP DATABASE mysqltest;
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION metaphon RETURNS STRING SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
DROP FUNCTION metaphon;
|
|
|
|
USE test;
|
2007-06-18 23:55:12 +02:00
|
|
|
|
2007-08-06 03:37:55 +02:00
|
|
|
#
|
|
|
|
# Bug #29804 UDF parameters don't contain correct string length
|
|
|
|
#
|
|
|
|
|
|
|
|
CREATE TABLE const_len_bug (
|
|
|
|
str_const varchar(4000),
|
|
|
|
result1 varchar(4000),
|
|
|
|
result2 varchar(4000)
|
|
|
|
);
|
|
|
|
|
|
|
|
DELIMITER |;
|
|
|
|
CREATE TRIGGER check_const_len_trigger BEFORE INSERT ON const_len_bug FOR EACH ROW BEGIN
|
|
|
|
set NEW.str_const = 'bar';
|
|
|
|
set NEW.result2 = check_const_len(NEW.str_const);
|
|
|
|
END |
|
|
|
|
|
|
|
|
CREATE PROCEDURE check_const_len_sp (IN str_const VARCHAR(4000))
|
|
|
|
BEGIN
|
|
|
|
DECLARE result VARCHAR(4000);
|
|
|
|
SET result = check_const_len(str_const);
|
|
|
|
insert into const_len_bug values(str_const, result, "");
|
|
|
|
END |
|
|
|
|
DELIMITER ;|
|
|
|
|
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION check_const_len RETURNS string SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
|
|
|
|
CALL check_const_len_sp("foo");
|
|
|
|
|
|
|
|
SELECT * from const_len_bug;
|
|
|
|
|
|
|
|
DROP FUNCTION check_const_len;
|
|
|
|
DROP PROCEDURE check_const_len_sp;
|
|
|
|
DROP TRIGGER check_const_len_trigger;
|
|
|
|
DROP TABLE const_len_bug;
|
|
|
|
|
2007-11-27 16:16:52 +01:00
|
|
|
|
|
|
|
#
|
|
|
|
# Bug #30355: Incorrect ordering of UDF results
|
|
|
|
#
|
|
|
|
|
|
|
|
--replace_result $UDF_EXAMPLE_LIB UDF_EXAMPLE_LIB
|
|
|
|
eval CREATE FUNCTION sequence RETURNS INTEGER SONAME "$UDF_EXAMPLE_LIB";
|
|
|
|
CREATE TABLE t1 (a INT);
|
|
|
|
CREATE TABLE t2 (a INT PRIMARY KEY);
|
|
|
|
INSERT INTO t1 VALUES (4),(3),(2),(1);
|
|
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
|
|
|
|
|
|
SELECT sequence() AS seq, a FROM t1 ORDER BY seq ASC;
|
|
|
|
SELECT sequence() AS seq, a FROM t1 ORDER BY seq DESC;
|
|
|
|
|
|
|
|
SELECT * FROM t1 WHERE a = sequence();
|
|
|
|
SELECT * FROM t2 WHERE a = sequence();
|
|
|
|
|
|
|
|
DROP FUNCTION sequence;
|
|
|
|
DROP TABLE t1,t2;
|
|
|
|
|
2007-01-18 16:33:38 +01:00
|
|
|
--echo End of 5.0 tests.
|