MDEV-13412 main.func_regexp_pcre fails in buildbot on ppc64le
Caused by 2fcd8c12522. It used the documented pcre API
-pcre_exec(NULL, NULL, NULL, -999, -999, 0, NULL, 0)
to calculate the pcre stack frame size. Unfortunately, modern compilers
broke it by cloning and inlining pcre match() function. 2fcd8c12522
tried to workaround it by setting the stack frame size to at least 500.
It didn't work, 500 is not a universal constant.
Now we fix our copy of pcre to not inline or clone match() - so that
stack frame detection would work again - and detect at cmake time
whether system pcre is broken or usable.
Also use stack, not (much slower) malloc in bundled pcre, unless on Windows
2017-10-05 15:01:38 +02:00
|
|
|
INCLUDE (CheckCSourceRuns)
|
2019-12-18 17:51:01 +01:00
|
|
|
INCLUDE (ExternalProject)
|
MDEV-13412 main.func_regexp_pcre fails in buildbot on ppc64le
Caused by 2fcd8c12522. It used the documented pcre API
-pcre_exec(NULL, NULL, NULL, -999, -999, 0, NULL, 0)
to calculate the pcre stack frame size. Unfortunately, modern compilers
broke it by cloning and inlining pcre match() function. 2fcd8c12522
tried to workaround it by setting the stack frame size to at least 500.
It didn't work, 500 is not a universal constant.
Now we fix our copy of pcre to not inline or clone match() - so that
stack frame detection would work again - and detect at cmake time
whether system pcre is broken or usable.
Also use stack, not (much slower) malloc in bundled pcre, unless on Windows
2017-10-05 15:01:38 +02:00
|
|
|
|
2014-03-04 01:22:53 +01:00
|
|
|
SET(WITH_PCRE "auto" CACHE STRING
|
|
|
|
"Which pcre to use (possible values are 'bundled', 'system', or 'auto')")
|
|
|
|
|
2019-12-18 17:51:01 +01:00
|
|
|
MACRO(BUNDLE_PCRE2)
|
|
|
|
SET(dir "${CMAKE_BINARY_DIR}/extra/pcre2")
|
|
|
|
SET(PCRE_INCLUDES ${dir}/src/pcre2-build ${dir}/src/pcre2/src)
|
|
|
|
SET(byproducts)
|
|
|
|
FOREACH(lib pcre2-posix pcre2-8)
|
|
|
|
ADD_LIBRARY(${lib} STATIC IMPORTED GLOBAL)
|
|
|
|
ADD_DEPENDENCIES(${lib} pcre2)
|
2021-10-06 11:31:08 +03:00
|
|
|
|
|
|
|
GET_PROPERTY(MULTICONFIG GLOBAL PROPERTY GENERATOR_IS_MULTI_CONFIG)
|
|
|
|
IF(MULTICONFIG)
|
|
|
|
SET(intdir "${CMAKE_CFG_INTDIR}/")
|
|
|
|
ELSE()
|
|
|
|
SET(intdir)
|
|
|
|
ENDIF()
|
|
|
|
|
|
|
|
SET(file ${dir}/src/pcre2-build/${intdir}${CMAKE_STATIC_LIBRARY_PREFIX}${lib}${CMAKE_STATIC_LIBRARY_SUFFIX})
|
|
|
|
|
2019-12-25 15:09:51 +00:00
|
|
|
IF(WIN32)
|
|
|
|
# Debug libary name.
|
|
|
|
# Same condition as in pcre2 CMakeLists.txt that adds "d"
|
2021-03-09 11:44:29 +01:00
|
|
|
SET(file_d ${dir}/src/pcre2-build/${intdir}${CMAKE_STATIC_LIBRARY_PREFIX}${lib}d${CMAKE_STATIC_LIBRARY_SUFFIX})
|
2019-12-25 15:09:51 +00:00
|
|
|
SET_TARGET_PROPERTIES(${lib} PROPERTIES IMPORTED_LOCATION_DEBUG ${file_d})
|
2019-12-18 17:51:01 +01:00
|
|
|
ELSE()
|
2019-12-25 15:09:51 +00:00
|
|
|
SET(file_d)
|
2019-12-18 17:51:01 +01:00
|
|
|
ENDIF()
|
2020-03-09 16:59:12 +01:00
|
|
|
SET(byproducts ${byproducts} BUILD_BYPRODUCTS ${file} ${file_d})
|
2019-12-18 17:51:01 +01:00
|
|
|
SET_TARGET_PROPERTIES(${lib} PROPERTIES IMPORTED_LOCATION ${file})
|
|
|
|
ENDFOREACH()
|
2020-05-18 11:00:28 +00:00
|
|
|
FOREACH(v "" "_DEBUG" "_RELWITHDEBINFO" "_RELEASE" "_MINSIZEREL")
|
2019-12-18 17:51:01 +01:00
|
|
|
STRING(REPLACE "/WX" "" pcre2_flags${v} "${CMAKE_C_FLAGS${v}}")
|
2019-12-25 15:09:51 +00:00
|
|
|
IF(MSVC)
|
|
|
|
# Suppress a warning
|
|
|
|
STRING(APPEND pcre2_flags${v} " /wd4244 " )
|
2021-03-12 08:43:37 +01:00
|
|
|
# Disable asan support
|
|
|
|
STRING(REPLACE "-fsanitize=address" "" pcre2_flags${v} "${CMAKE_C_FLAGS${v}}")
|
2019-12-25 15:09:51 +00:00
|
|
|
ENDIF()
|
2019-12-18 17:51:01 +01:00
|
|
|
ENDFOREACH()
|
|
|
|
ExternalProject_Add(
|
|
|
|
pcre2
|
|
|
|
PREFIX "${dir}"
|
2021-11-05 00:02:34 +01:00
|
|
|
URL "https://github.com/PhilipHazel/pcre2/releases/download/pcre2-10.37/pcre2-10.37.zip"
|
2021-08-02 20:18:20 +02:00
|
|
|
URL_MD5 8c1699a725d4b28410adf4b964ebbcb7
|
2019-12-18 17:51:01 +01:00
|
|
|
INSTALL_COMMAND ""
|
|
|
|
CMAKE_ARGS
|
|
|
|
"-DPCRE2_BUILD_TESTS=OFF"
|
|
|
|
"-DPCRE2_BUILD_PCRE2GREP=OFF"
|
|
|
|
"-DBUILD_SHARED_LIBS=OFF"
|
|
|
|
"-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}"
|
|
|
|
"-DCMAKE_C_FLAGS=${pcre2_flags} ${PIC_FLAG}"
|
|
|
|
"-DCMAKE_C_FLAGS_DEBUG=${pcre2_flags_DEBUG}"
|
|
|
|
"-DCMAKE_C_FLAGS_RELWITHDEBINFO=${pcre2_flags_RELWITHDEBINFO}"
|
|
|
|
"-DCMAKE_C_FLAGS_RELEASE=${pcre2_flags_RELEASE}"
|
|
|
|
"-DCMAKE_C_FLAGS_MINSIZEREL=${pcre2_flags_MINSIZEREL}"
|
|
|
|
"-DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}"
|
2020-05-18 11:00:28 +00:00
|
|
|
${stdlibs}
|
2019-12-18 17:51:01 +01:00
|
|
|
${byproducts}
|
|
|
|
)
|
|
|
|
SET_TARGET_PROPERTIES(pcre2 PROPERTIES EXCLUDE_FROM_ALL TRUE)
|
|
|
|
ENDMACRO()
|
|
|
|
|
2014-03-04 01:22:53 +01:00
|
|
|
MACRO (CHECK_PCRE)
|
|
|
|
IF(WITH_PCRE STREQUAL "system" OR WITH_PCRE STREQUAL "auto")
|
2019-12-17 01:37:59 +04:00
|
|
|
CHECK_LIBRARY_EXISTS(pcre2-8 pcre2_match_8 "" HAVE_PCRE2)
|
2014-03-04 01:22:53 +01:00
|
|
|
ENDIF()
|
2019-12-17 01:37:59 +04:00
|
|
|
IF(NOT HAVE_PCRE2 OR WITH_PCRE STREQUAL "bundled")
|
2014-03-04 01:22:53 +01:00
|
|
|
IF (WITH_PCRE STREQUAL "system")
|
2019-12-17 01:37:59 +04:00
|
|
|
MESSAGE(FATAL_ERROR "system pcre2-8 library is not found or unusable")
|
2014-03-04 01:22:53 +01:00
|
|
|
ENDIF()
|
2019-12-18 17:51:01 +01:00
|
|
|
BUNDLE_PCRE2()
|
2020-01-13 13:08:55 +01:00
|
|
|
ELSE()
|
|
|
|
CHECK_LIBRARY_EXISTS(pcre2-posix PCRE2regcomp "" NEEDS_PCRE2_DEBIAN_HACK)
|
|
|
|
IF(NEEDS_PCRE2_DEBIAN_HACK)
|
|
|
|
SET(PCRE2_DEBIAN_HACK "-Dregcomp=PCRE2regcomp -Dregexec=PCRE2regexec -Dregerror=PCRE2regerror -Dregfree=PCRE2regfree")
|
|
|
|
ENDIF()
|
2014-03-04 01:22:53 +01:00
|
|
|
ENDIF()
|
|
|
|
ENDMACRO()
|
|
|
|
|