2005-04-06 16:22:21 +02:00
|
|
|
#
|
|
|
|
# Suppress some common (not fatal) errors in system libraries found by valgrind
|
|
|
|
#
|
|
|
|
|
|
|
|
#
|
|
|
|
# Pthread doesn't free all thread specific memory before program exists
|
|
|
|
#
|
|
|
|
{
|
|
|
|
pthread allocate_tls memory loss
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:calloc
|
|
|
|
fun:_dl_allocate_tls
|
|
|
|
fun:allocate_stack
|
2006-05-15 15:06:46 +02:00
|
|
|
fun:pthread_create*
|
2005-04-06 16:22:21 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
pthread allocate_dtv memory loss
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:calloc
|
|
|
|
fun:allocate_dtv
|
|
|
|
fun:_dl_allocate_tls_storage
|
|
|
|
fun:__GI__dl_allocate_tls
|
|
|
|
fun:pthread_create
|
|
|
|
}
|
|
|
|
|
Approximative fixes for BUG#2610,2611,9100 i.e. WL#2146 binlogging/replication of routines (stored procs and functions).
Approximative, because it's using our binlogging way (what we call "query"-level) and this is not as good as record-level binlog (5.1) would be. It imposes several
limitations to routines, and has caveats (which I'll document, and for which the server will try to issue errors but that is not always possible).
Reason I don't propagate caller info to the binlog as planned is that on master and slave
users may be different; even with that some caveats would remain.
mysql-test/mysql-test-run.sh:
In the testsuite we know what we do, we are not creating nasty routines, and breaking binlog is ok except in rpl_sp.
mysql-test/r/blackhole.result:
Updating results now that 4.1 has been merged
mysql-test/valgrind.supp:
Some suppressions for Valgrind (useful on my machine Suse 9.1);
this is just adding to the already existing suppressions of pthread and dl.
sql/item_func.cc:
Don't binlog the substatements when executing a function. If the function
is declared to modify data and does not complete, warning "broken binlog".
Note that SELECT myfunc() will not be binlogged even if myfunc() updates data (will be documented);
but INSERT INTO t VALUES(myfunc()) will be binlogged (what decides is if the caller
gets binlogged; the function changes nothing to binlogging).
sql/log_event.cc:
Just making functions which can be re-used when we binlog more strings
in status_vars in Query_log_event (e.g. one day "user", "host").
sql/log_event.h:
comment
sql/mysql_priv.h:
--log-bin-trust-routine-creators
sql/mysqld.cc:
--log-bin-trust-routine-creators
sql/set_var.cc:
--log-bin-trust-routine-creators
sql/share/errmsg.txt:
error messages to warn about problems with routines and binlog
sql/slave.cc:
If in a routine, replication table inclusion/exclusion rules always answer "replicate!" (see comment in code).
sql/sp.cc:
If binlog is on: errors if one wants to create a non-deterministic update routine
(repeatability problem - note that the test is not perfect for functions) or does not have SUPER (because routines can easily
be made to destroy slave's data with just CREATE ROUTINE and EXECUTE priv on master).
--log-bin-trust-routine-creators removes these errors.
Binlogging of CREATE PROCEDURE|FUNCTION.
sql/sql_acl.cc:
No thd==0 in tables_ok().
sql/sql_parse.cc:
Binlogging of CALL (and not of the substatements of the SP).
If SP returns error, we don't binlog it (see comment); we push warning in this case.
Binlogging of ALTER|DROP PROCEDURE|FUNCTION with safety messages.
2005-05-05 14:20:53 +02:00
|
|
|
{
|
|
|
|
pthread allocate_dtv memory loss second
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:calloc
|
|
|
|
fun:allocate_dtv
|
|
|
|
fun:_dl_allocate_tls
|
|
|
|
fun:pthread_create*
|
|
|
|
}
|
|
|
|
|
2005-04-06 16:22:21 +02:00
|
|
|
{
|
|
|
|
pthread memalign memory loss
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:memalign
|
|
|
|
fun:_dl_allocate_tls_storage
|
|
|
|
fun:__GI__dl_allocate_tls
|
|
|
|
fun:pthread_create
|
|
|
|
}
|
|
|
|
|
2005-09-22 02:23:07 +02:00
|
|
|
{
|
|
|
|
pthread pthread_key_create
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:malloc
|
|
|
|
fun:*
|
|
|
|
fun:*
|
|
|
|
fun:pthread_key_create
|
|
|
|
fun:my_thread_global_init
|
|
|
|
}
|
|
|
|
|
Approximative fixes for BUG#2610,2611,9100 i.e. WL#2146 binlogging/replication of routines (stored procs and functions).
Approximative, because it's using our binlogging way (what we call "query"-level) and this is not as good as record-level binlog (5.1) would be. It imposes several
limitations to routines, and has caveats (which I'll document, and for which the server will try to issue errors but that is not always possible).
Reason I don't propagate caller info to the binlog as planned is that on master and slave
users may be different; even with that some caveats would remain.
mysql-test/mysql-test-run.sh:
In the testsuite we know what we do, we are not creating nasty routines, and breaking binlog is ok except in rpl_sp.
mysql-test/r/blackhole.result:
Updating results now that 4.1 has been merged
mysql-test/valgrind.supp:
Some suppressions for Valgrind (useful on my machine Suse 9.1);
this is just adding to the already existing suppressions of pthread and dl.
sql/item_func.cc:
Don't binlog the substatements when executing a function. If the function
is declared to modify data and does not complete, warning "broken binlog".
Note that SELECT myfunc() will not be binlogged even if myfunc() updates data (will be documented);
but INSERT INTO t VALUES(myfunc()) will be binlogged (what decides is if the caller
gets binlogged; the function changes nothing to binlogging).
sql/log_event.cc:
Just making functions which can be re-used when we binlog more strings
in status_vars in Query_log_event (e.g. one day "user", "host").
sql/log_event.h:
comment
sql/mysql_priv.h:
--log-bin-trust-routine-creators
sql/mysqld.cc:
--log-bin-trust-routine-creators
sql/set_var.cc:
--log-bin-trust-routine-creators
sql/share/errmsg.txt:
error messages to warn about problems with routines and binlog
sql/slave.cc:
If in a routine, replication table inclusion/exclusion rules always answer "replicate!" (see comment in code).
sql/sp.cc:
If binlog is on: errors if one wants to create a non-deterministic update routine
(repeatability problem - note that the test is not perfect for functions) or does not have SUPER (because routines can easily
be made to destroy slave's data with just CREATE ROUTINE and EXECUTE priv on master).
--log-bin-trust-routine-creators removes these errors.
Binlogging of CREATE PROCEDURE|FUNCTION.
sql/sql_acl.cc:
No thd==0 in tables_ok().
sql/sql_parse.cc:
Binlogging of CALL (and not of the substatements of the SP).
If SP returns error, we don't binlog it (see comment); we push warning in this case.
Binlogging of ALTER|DROP PROCEDURE|FUNCTION with safety messages.
2005-05-05 14:20:53 +02:00
|
|
|
{
|
|
|
|
pthread strstr uninit
|
|
|
|
Memcheck:Cond
|
|
|
|
fun:strstr
|
|
|
|
obj:/lib/tls/libpthread.so.*
|
|
|
|
obj:/lib/tls/libpthread.so.*
|
|
|
|
fun:call_init
|
|
|
|
fun:_dl_init
|
|
|
|
obj:/lib/ld-*.so
|
|
|
|
}
|
|
|
|
|
2005-04-06 16:22:21 +02:00
|
|
|
{
|
|
|
|
pthread errno
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:calloc
|
|
|
|
fun:_dlerror_run
|
|
|
|
fun:dlsym
|
|
|
|
fun:__errno_location
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
#
|
|
|
|
# Warnings in libz becasue it works with aligned memory(?)
|
|
|
|
#
|
|
|
|
|
|
|
|
{
|
|
|
|
libz tr_flush_block
|
|
|
|
Memcheck:Cond
|
|
|
|
fun:_tr_flush_block
|
|
|
|
fun:deflate_slow
|
|
|
|
fun:deflate
|
|
|
|
fun:do_flush
|
|
|
|
fun:gzclose
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
libz tr_flush_block2
|
|
|
|
Memcheck:Cond
|
|
|
|
fun:_tr_flush_block
|
|
|
|
fun:deflate_slow
|
|
|
|
fun:deflate
|
|
|
|
fun:compress2
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
libz longest_match
|
|
|
|
Memcheck:Cond
|
|
|
|
fun:longest_match
|
|
|
|
fun:deflate_slow
|
|
|
|
fun:deflate
|
|
|
|
fun:do_flush
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
libz longest_match2
|
|
|
|
Memcheck:Cond
|
|
|
|
fun:longest_match
|
|
|
|
fun:deflate_slow
|
|
|
|
fun:deflate
|
|
|
|
fun:compress2
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
libz deflate
|
|
|
|
Memcheck:Cond
|
2005-09-22 02:23:07 +02:00
|
|
|
obj:*/libz.so.*
|
|
|
|
obj:*/libz.so.*
|
2005-04-06 16:22:21 +02:00
|
|
|
fun:deflate
|
|
|
|
fun:compress2
|
|
|
|
}
|
2005-09-22 02:23:07 +02:00
|
|
|
|
|
|
|
{
|
|
|
|
libz deflate2
|
|
|
|
Memcheck:Cond
|
|
|
|
obj:*/libz.so.*
|
|
|
|
obj:*/libz.so.*
|
|
|
|
fun:deflate
|
|
|
|
obj:*/libz.so.*
|
|
|
|
fun:gzflush
|
|
|
|
}
|
2006-05-15 15:06:46 +02:00
|
|
|
|
2006-06-21 12:52:59 +02:00
|
|
|
#
|
|
|
|
# Warning from my_thread_init becasue mysqld dies before kill thread exists
|
|
|
|
#
|
|
|
|
|
|
|
|
{
|
|
|
|
my_thread_init kill thread memory loss second
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:calloc
|
|
|
|
fun:my_thread_init
|
|
|
|
fun:kill_server_thread
|
|
|
|
}
|
|
|
|
|
2006-05-15 15:06:46 +02:00
|
|
|
#
|
|
|
|
# Leaks reported in _dl_* internal functions on Linux amd64 / glibc2.3.2.
|
|
|
|
#
|
|
|
|
|
|
|
|
{
|
|
|
|
_dl_start invalid write8
|
|
|
|
Memcheck:Addr8
|
|
|
|
fun:_dl_start
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
_dl_start invalid write4
|
|
|
|
Memcheck:Addr4
|
|
|
|
fun:_dl_start
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
_dl_start/_dl_setup_hash invalid read8
|
|
|
|
Memcheck:Addr8
|
|
|
|
fun:_dl_setup_hash
|
|
|
|
fun:_dl_start
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
_dl_sysdep_start invalid write8
|
|
|
|
Memcheck:Addr8
|
|
|
|
fun:_dl_sysdep_start
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
_dl_init invalid write8
|
|
|
|
Memcheck:Addr8
|
|
|
|
fun:_dl_init
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
_dl_init invalid write4
|
|
|
|
Memcheck:Addr4
|
|
|
|
fun:_dl_init
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
_dl_init/_dl_init invalid read8
|
|
|
|
Memcheck:Addr8
|
|
|
|
fun:_dl_debug_initialize
|
|
|
|
fun:_dl_init
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
_dl_init/_dl_debug_state invalid read8
|
|
|
|
Memcheck:Addr8
|
|
|
|
fun:_dl_debug_state
|
|
|
|
fun:_dl_init
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
init invalid write8
|
|
|
|
Memcheck:Addr8
|
|
|
|
fun:init
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
fixup invalid write8
|
|
|
|
Memcheck:Addr8
|
|
|
|
fun:fixup
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
fixup/_dl_lookup_versioned_symbol invalid read8
|
|
|
|
Memcheck:Addr8
|
|
|
|
fun:_dl_lookup_versioned_symbol
|
|
|
|
fun:fixup
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
_dl_runtime_resolve invalid read8
|
|
|
|
Memcheck:Addr8
|
|
|
|
fun:_dl_runtime_resolve
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
__libc_start_main invalid write8
|
|
|
|
Memcheck:Addr8
|
|
|
|
fun:__libc_start_main
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
__libc_start_main/__sigjmp_save invalid write4
|
|
|
|
Memcheck:Addr4
|
|
|
|
fun:__sigjmp_save
|
|
|
|
fun:__libc_start_main
|
|
|
|
}
|
|
|
|
|
|
|
|
#
|
|
|
|
# These seem to be libc threading stuff, not related to MySQL code (allocations
|
|
|
|
# during pthread_exit()). Googling shows other projects also using these
|
|
|
|
# suppressions.
|
|
|
|
#
|
|
|
|
# Note that these all stem from pthread_exit() deeper in the call stack, but
|
|
|
|
# Valgrind only allows the top four calls in the suppressions.
|
|
|
|
#
|
|
|
|
|
|
|
|
{
|
|
|
|
libc pthread_exit 1
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:malloc
|
|
|
|
fun:_dl_new_object
|
|
|
|
fun:_dl_map_object_from_fd
|
|
|
|
fun:_dl_map_object
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
libc pthread_exit 2
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:malloc
|
|
|
|
fun:_dl_map_object
|
|
|
|
fun:dl_open_worker
|
|
|
|
fun:_dl_catch_error
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
libc pthread_exit 3
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:malloc
|
|
|
|
fun:_dl_map_object_deps
|
|
|
|
fun:dl_open_worker
|
|
|
|
fun:_dl_catch_error
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
libc pthread_exit 4
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:calloc
|
|
|
|
fun:_dl_check_map_versions
|
|
|
|
fun:dl_open_worker
|
|
|
|
fun:_dl_catch_error
|
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
libc pthread_exit 5
|
|
|
|
Memcheck:Leak
|
|
|
|
fun:calloc
|
|
|
|
fun:_dl_new_object
|
|
|
|
fun:_dl_map_object_from_fd
|
|
|
|
fun:_dl_map_object
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
#
|
|
|
|
# This is seen internally in the system libraries on 64-bit RHAS3.
|
|
|
|
#
|
|
|
|
|
|
|
|
{
|
|
|
|
__lll_mutex_unlock_wake uninitialized
|
|
|
|
Memcheck:Param
|
|
|
|
futex(utime)
|
|
|
|
fun:__lll_mutex_unlock_wake
|
|
|
|
}
|
2006-06-15 22:02:26 +02:00
|
|
|
|
|
|
|
#
|
|
|
|
# BUG#19940: NDB sends uninitialized parts of field buffers across the wire.
|
|
|
|
# This is "works as designed"; the uninitialized part is not used at the
|
|
|
|
# other end (but Valgrind cannot see this).
|
|
|
|
#
|
|
|
|
{
|
|
|
|
bug19940
|
|
|
|
Memcheck:Param
|
|
|
|
socketcall.sendto(msg)
|
|
|
|
fun:send
|
|
|
|
fun:_ZN15TCP_Transporter6doSendEv
|
|
|
|
fun:_ZN19TransporterRegistry11performSendEv
|
|
|
|
fun:_ZN19TransporterRegistry14forceSendCheckEi
|
|
|
|
}
|