Bug#18239 (Possible to overload internal functions with stored functions)
Bug#21025 (misleading error message when creating functions named 'x', or 'y')
Bug#22619 (Spaces considered harmful)
This change contains a fix to report warnings or errors, and multiple tests
cases.
Before this fix, name collisions between:
- Native functions
- User Defined Functions
- Stored Functions
were not systematically reported, leading to confusing behavior.
I) Native / User Defined Function
Before this fix, is was possible to create a UDF named "foo", with the same
name as a native function "foo", but it was impossible to invoke the UDF,
since the syntax "foo()" always refer to the native function.
After this fix, creating a UDF fails with an error if there is a name
collision with a native function.
II) Native / Stored Function
Before this fix, is was possible to create a SF named "db.foo", with the same
name as a native function "foo", but this was confusing since the syntax
"foo()" would refer to the native function. To refer to the Stored Function,
the user had to use the "db.foo()" syntax.
After this fix, creating a Stored Function reports a warning if there is a
name collision with a native function.
III) User Defined Function / Stored Function
Before this fix, creating a User Defined Function "foo" and a Stored Function
"db.foo" are mutually exclusive operations. Whenever the second function is
created, an error is reported. However, the test suite did not cover this
behavior.
After this fix, the behavior is unchanged, and is now covered by test cases.
Note that the code change in this patch depends on the fix for Bug 21114.
mysql-test/r/sp.result:
New test cases.
mysql-test/r/udf.result:
New test cases.
mysql-test/t/sp.test:
New test cases.
mysql-test/t/udf.test:
New test cases.
sql/sql_lex.cc:
Name collisions with native functions.
sql/sql_lex.h:
Name collisions with native functions.
sql/sql_yacc.yy:
Name collisions with native functions.
sql/share/errmsg.txt:
Name collisions with native functions.
mysql-test/r/sp_gis.result:
New test cases.
mysql-test/t/sp_gis.test:
New test cases.
2006-11-15 03:34:16 +01:00
|
|
|
use test;
|
|
|
|
drop function if exists a;
|
|
|
|
drop function if exists x;
|
|
|
|
drop function if exists y;
|
|
|
|
create function a() returns int
|
|
|
|
return 1;
|
|
|
|
create function x() returns int
|
|
|
|
return 2;
|
|
|
|
Warnings:
|
2007-10-26 22:40:48 +02:00
|
|
|
Note 1585 This function 'x' has the same name as a native function
|
Bug#18239 (Possible to overload internal functions with stored functions)
Bug#21025 (misleading error message when creating functions named 'x', or 'y')
Bug#22619 (Spaces considered harmful)
This change contains a fix to report warnings or errors, and multiple tests
cases.
Before this fix, name collisions between:
- Native functions
- User Defined Functions
- Stored Functions
were not systematically reported, leading to confusing behavior.
I) Native / User Defined Function
Before this fix, is was possible to create a UDF named "foo", with the same
name as a native function "foo", but it was impossible to invoke the UDF,
since the syntax "foo()" always refer to the native function.
After this fix, creating a UDF fails with an error if there is a name
collision with a native function.
II) Native / Stored Function
Before this fix, is was possible to create a SF named "db.foo", with the same
name as a native function "foo", but this was confusing since the syntax
"foo()" would refer to the native function. To refer to the Stored Function,
the user had to use the "db.foo()" syntax.
After this fix, creating a Stored Function reports a warning if there is a
name collision with a native function.
III) User Defined Function / Stored Function
Before this fix, creating a User Defined Function "foo" and a Stored Function
"db.foo" are mutually exclusive operations. Whenever the second function is
created, an error is reported. However, the test suite did not cover this
behavior.
After this fix, the behavior is unchanged, and is now covered by test cases.
Note that the code change in this patch depends on the fix for Bug 21114.
mysql-test/r/sp.result:
New test cases.
mysql-test/r/udf.result:
New test cases.
mysql-test/t/sp.test:
New test cases.
mysql-test/t/udf.test:
New test cases.
sql/sql_lex.cc:
Name collisions with native functions.
sql/sql_lex.h:
Name collisions with native functions.
sql/sql_yacc.yy:
Name collisions with native functions.
sql/share/errmsg.txt:
Name collisions with native functions.
mysql-test/r/sp_gis.result:
New test cases.
mysql-test/t/sp_gis.test:
New test cases.
2006-11-15 03:34:16 +01:00
|
|
|
create function y() returns int
|
|
|
|
return 3;
|
|
|
|
Warnings:
|
2007-10-26 22:40:48 +02:00
|
|
|
Note 1585 This function 'y' has the same name as a native function
|
Bug#18239 (Possible to overload internal functions with stored functions)
Bug#21025 (misleading error message when creating functions named 'x', or 'y')
Bug#22619 (Spaces considered harmful)
This change contains a fix to report warnings or errors, and multiple tests
cases.
Before this fix, name collisions between:
- Native functions
- User Defined Functions
- Stored Functions
were not systematically reported, leading to confusing behavior.
I) Native / User Defined Function
Before this fix, is was possible to create a UDF named "foo", with the same
name as a native function "foo", but it was impossible to invoke the UDF,
since the syntax "foo()" always refer to the native function.
After this fix, creating a UDF fails with an error if there is a name
collision with a native function.
II) Native / Stored Function
Before this fix, is was possible to create a SF named "db.foo", with the same
name as a native function "foo", but this was confusing since the syntax
"foo()" would refer to the native function. To refer to the Stored Function,
the user had to use the "db.foo()" syntax.
After this fix, creating a Stored Function reports a warning if there is a
name collision with a native function.
III) User Defined Function / Stored Function
Before this fix, creating a User Defined Function "foo" and a Stored Function
"db.foo" are mutually exclusive operations. Whenever the second function is
created, an error is reported. However, the test suite did not cover this
behavior.
After this fix, the behavior is unchanged, and is now covered by test cases.
Note that the code change in this patch depends on the fix for Bug 21114.
mysql-test/r/sp.result:
New test cases.
mysql-test/r/udf.result:
New test cases.
mysql-test/t/sp.test:
New test cases.
mysql-test/t/udf.test:
New test cases.
sql/sql_lex.cc:
Name collisions with native functions.
sql/sql_lex.h:
Name collisions with native functions.
sql/sql_yacc.yy:
Name collisions with native functions.
sql/share/errmsg.txt:
Name collisions with native functions.
mysql-test/r/sp_gis.result:
New test cases.
mysql-test/t/sp_gis.test:
New test cases.
2006-11-15 03:34:16 +01:00
|
|
|
select a();
|
|
|
|
a()
|
|
|
|
1
|
|
|
|
select x();
|
|
|
|
ERROR 42000: Incorrect parameter count in the call to native function 'x'
|
|
|
|
select y();
|
|
|
|
ERROR 42000: Incorrect parameter count in the call to native function 'y'
|
|
|
|
select x(PointFromText("POINT(10 20)")), y(PointFromText("POINT(10 20)"));
|
|
|
|
x(PointFromText("POINT(10 20)")) y(PointFromText("POINT(10 20)"))
|
|
|
|
10 20
|
|
|
|
select test.a(), test.x(), test.y();
|
|
|
|
test.a() test.x() test.y()
|
|
|
|
1 2 3
|
|
|
|
drop function a;
|
|
|
|
drop function x;
|
|
|
|
drop function y;
|
2019-07-03 18:08:10 +02:00
|
|
|
#
|
|
|
|
# Start of 10.5 tests
|
|
|
|
#
|
|
|
|
#
|
|
|
|
# MDEV-19944 Remove GIS data types from keyword list in lex.h
|
|
|
|
#
|
|
|
|
CREATE FUNCTION point() RETURNS POINT RETURN NULL;
|
|
|
|
Warnings:
|
|
|
|
Note 1585 This function 'point' has the same name as a native function
|
|
|
|
SELECT point();
|
|
|
|
point()
|
|
|
|
NULL
|
|
|
|
DROP FUNCTION point;
|
|
|
|
CREATE FUNCTION point(x INT) RETURNS POINT RETURN NULL;
|
|
|
|
Warnings:
|
|
|
|
Note 1585 This function 'point' has the same name as a native function
|
|
|
|
SELECT point(1);
|
|
|
|
point(1)
|
|
|
|
NULL
|
|
|
|
DROP FUNCTION point;
|
|
|
|
CREATE FUNCTION point(x INT, y INT) RETURNS POINT RETURN NULL;
|
|
|
|
Warnings:
|
|
|
|
Note 1585 This function 'point' has the same name as a native function
|
|
|
|
SELECT AsText(point(1,1));
|
|
|
|
AsText(point(1,1))
|
|
|
|
POINT(1 1)
|
|
|
|
DROP FUNCTION point;
|
|
|
|
CREATE FUNCTION linestring() RETURNS POINT RETURN NULL;
|
|
|
|
Warnings:
|
|
|
|
Note 1585 This function 'linestring' has the same name as a native function
|
|
|
|
SELECT linestring();
|
|
|
|
linestring()
|
|
|
|
NULL
|
|
|
|
DROP FUNCTION linestring;
|
|
|
|
CREATE FUNCTION polygon() RETURNS POINT RETURN NULL;
|
|
|
|
Warnings:
|
|
|
|
Note 1585 This function 'polygon' has the same name as a native function
|
|
|
|
SELECT polygon();
|
|
|
|
polygon()
|
|
|
|
NULL
|
|
|
|
DROP FUNCTION polygon;
|
|
|
|
CREATE FUNCTION multipoint() RETURNS POINT RETURN NULL;
|
|
|
|
Warnings:
|
|
|
|
Note 1585 This function 'multipoint' has the same name as a native function
|
|
|
|
SELECT multipoint();
|
|
|
|
multipoint()
|
|
|
|
NULL
|
|
|
|
DROP FUNCTION multipoint;
|
|
|
|
CREATE FUNCTION multilinestring() RETURNS POINT RETURN NULL;
|
|
|
|
Warnings:
|
|
|
|
Note 1585 This function 'multilinestring' has the same name as a native function
|
|
|
|
SELECT multilinestring();
|
|
|
|
multilinestring()
|
|
|
|
NULL
|
|
|
|
DROP FUNCTION multilinestring;
|
|
|
|
CREATE FUNCTION multipolygon() RETURNS POINT RETURN NULL;
|
|
|
|
Warnings:
|
|
|
|
Note 1585 This function 'multipolygon' has the same name as a native function
|
|
|
|
SELECT multipolygon();
|
|
|
|
multipolygon()
|
|
|
|
NULL
|
|
|
|
DROP FUNCTION multipolygon;
|
|
|
|
CREATE FUNCTION geometrycollection() RETURNS POINT RETURN NULL;
|
|
|
|
Warnings:
|
|
|
|
Note 1585 This function 'geometrycollection' has the same name as a native function
|
|
|
|
SELECT geometrycollection();
|
|
|
|
geometrycollection()
|
|
|
|
NULL
|
|
|
|
DROP FUNCTION geometrycollection;
|
|
|
|
#
|
|
|
|
# End of 10.5 tests
|
|
|
|
#
|