2013-11-04 21:37:29 +01:00
|
|
|
call mtr.add_suppression("table or database name 'abc`def'");
|
2001-09-28 07:05:54 +02:00
|
|
|
drop table if exists t1;
|
2003-08-18 23:08:08 +02:00
|
|
|
drop database if exists mysqltest;
|
2004-11-03 11:39:38 +01:00
|
|
|
drop database if exists client_test_db;
|
2001-09-28 07:05:54 +02:00
|
|
|
drop table t1;
|
2013-07-03 18:48:41 +02:00
|
|
|
ERROR 42S02: Unknown table 'test.t1'
|
2001-09-28 07:05:54 +02:00
|
|
|
create table t1(n int);
|
|
|
|
insert into t1 values(1);
|
|
|
|
create temporary table t1( n int);
|
|
|
|
insert into t1 values(2);
|
|
|
|
create table t1(n int);
|
2003-06-04 17:28:51 +02:00
|
|
|
ERROR 42S01: Table 't1' already exists
|
2001-09-28 07:05:54 +02:00
|
|
|
drop table t1;
|
|
|
|
select * from t1;
|
2001-03-27 19:23:04 +02:00
|
|
|
n
|
|
|
|
1
|
2001-12-22 14:13:31 +01:00
|
|
|
create database mysqltest;
|
|
|
|
drop database if exists mysqltest;
|
|
|
|
create database mysqltest;
|
|
|
|
create table mysqltest.mysqltest (n int);
|
|
|
|
insert into mysqltest.mysqltest values (4);
|
|
|
|
select * from mysqltest.mysqltest;
|
2001-06-01 23:13:02 +02:00
|
|
|
n
|
|
|
|
4
|
2001-12-22 14:13:31 +01:00
|
|
|
drop database if exists mysqltest;
|
2004-03-19 16:43:03 +01:00
|
|
|
affected rows: 1
|
2001-12-22 14:13:31 +01:00
|
|
|
create database mysqltest;
|
2005-04-02 20:13:19 +02:00
|
|
|
use mysqltest;
|
|
|
|
drop table table1, table2, table3, table4, table5, table6,
|
|
|
|
table7, table8, table9, table10, table11, table12, table13,
|
|
|
|
table14, table15, table16, table17, table18, table19, table20,
|
|
|
|
table21, table22, table23, table24, table25, table26, table27,
|
|
|
|
table28;
|
2020-03-16 16:53:10 +01:00
|
|
|
ERROR 42S02: Unknown table 'mysqltest.table1,mysqltest.table2,mysqltest.table3,mysqltest.table4,mysqltest.table5,mysqltest.ta...'
|
2005-04-02 20:13:19 +02:00
|
|
|
drop table table1, table2, table3, table4, table5, table6,
|
|
|
|
table7, table8, table9, table10, table11, table12, table13,
|
|
|
|
table14, table15, table16, table17, table18, table19, table20,
|
|
|
|
table21, table22, table23, table24, table25, table26, table27,
|
|
|
|
table28, table29, table30;
|
2020-03-16 16:53:10 +01:00
|
|
|
ERROR 42S02: Unknown table 'mysqltest.table1,mysqltest.table2,mysqltest.table3,mysqltest.table4,mysqltest.table5,mysqltest.ta...'
|
2005-04-02 20:13:19 +02:00
|
|
|
use test;
|
2001-12-22 14:13:31 +01:00
|
|
|
drop database mysqltest;
|
2001-09-28 07:05:54 +02:00
|
|
|
flush tables with read lock;
|
2001-12-22 14:13:31 +01:00
|
|
|
create database mysqltest;
|
2001-10-09 04:18:37 +02:00
|
|
|
Got one of the listed errors
|
2001-09-28 07:05:54 +02:00
|
|
|
unlock tables;
|
2001-12-22 14:13:31 +01:00
|
|
|
create database mysqltest;
|
2001-09-28 07:05:54 +02:00
|
|
|
show databases;
|
2001-06-22 16:35:18 +02:00
|
|
|
Database
|
2004-12-10 10:07:11 +01:00
|
|
|
information_schema
|
2008-04-02 10:06:36 +02:00
|
|
|
mtr
|
2001-06-22 16:35:18 +02:00
|
|
|
mysql
|
2001-12-22 14:13:31 +01:00
|
|
|
mysqltest
|
2010-01-12 02:47:27 +01:00
|
|
|
performance_schema
|
2021-03-03 10:30:29 +01:00
|
|
|
sys
|
2001-06-22 16:35:18 +02:00
|
|
|
test
|
2001-09-28 07:05:54 +02:00
|
|
|
flush tables with read lock;
|
2001-12-22 14:13:31 +01:00
|
|
|
drop database mysqltest;
|
2001-10-09 04:18:37 +02:00
|
|
|
Got one of the listed errors
|
2001-09-28 07:05:54 +02:00
|
|
|
unlock tables;
|
2001-12-22 14:13:31 +01:00
|
|
|
drop database mysqltest;
|
2001-09-28 07:05:54 +02:00
|
|
|
show databases;
|
2001-06-22 16:35:18 +02:00
|
|
|
Database
|
2004-12-10 10:07:11 +01:00
|
|
|
information_schema
|
2008-04-02 10:06:36 +02:00
|
|
|
mtr
|
2001-06-22 16:35:18 +02:00
|
|
|
mysql
|
2010-01-12 02:47:27 +01:00
|
|
|
performance_schema
|
2021-03-03 10:30:29 +01:00
|
|
|
sys
|
2001-06-22 16:35:18 +02:00
|
|
|
test
|
2001-12-22 14:13:31 +01:00
|
|
|
drop database mysqltest;
|
2003-07-10 10:02:57 +02:00
|
|
|
ERROR HY000: Can't drop database 'mysqltest'; database doesn't exist
|
2003-08-27 15:03:39 +02:00
|
|
|
drop table t1;
|
|
|
|
flush tables with read lock;
|
|
|
|
create table t1(n int);
|
2003-08-28 15:09:00 +02:00
|
|
|
ERROR HY000: Can't execute the query because you have a conflicting read lock
|
2003-08-27 15:03:39 +02:00
|
|
|
unlock tables;
|
|
|
|
create table t1(n int);
|
|
|
|
show tables;
|
2004-10-10 12:15:14 +02:00
|
|
|
Tables_in_test
|
|
|
|
t1
|
2003-08-27 15:03:39 +02:00
|
|
|
drop table t1;
|
2006-08-21 10:18:59 +02:00
|
|
|
drop database if exists mysqltest;
|
|
|
|
drop table if exists t1;
|
|
|
|
create table t1 (i int);
|
|
|
|
create database mysqltest;
|
2010-01-12 16:15:21 +01:00
|
|
|
lock tables t1 read;
|
2016-03-25 17:51:22 +01:00
|
|
|
connect addconroot1, localhost, root,,;
|
Update tests and result files after running with new mysqltest that better detects problems with test files
mysql-test/r/csv.result:
Update after add of missing semicolon
mysql-test/r/drop.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/flush.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/flush_block_commit.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/flush_read_lock_kill.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/grant2.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/handler.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/innodb_notembedded.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/kill.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/lock_multi.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/multi_update.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/mysqltest.result:
Update result
mysql-test/r/query_cache.result:
Update after add of missing semicolon
mysql-test/r/query_cache_notembedded.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/sp-threads.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/sp_notembedded.result:
Update after add of missing semicolon
mysql-test/r/type_blob.result:
Remove extra drop table
mysql-test/t/csv.test:
Add missing semicolon
mysql-test/t/query_cache.test:
Add missing semicolon
mysql-test/t/sp-error.test:
Remove "tab" from end of error declaration
mysql-test/t/sp.test:
Wrong delimiter, used ; instead of |
mysql-test/t/sp_notembedded.test:
Wrong delimiter, used ; instead of |
mysql-test/t/view_grant.test:
An incomplete error name specification was used.
2006-10-04 13:09:37 +02:00
|
|
|
drop table t1;
|
2016-03-25 17:51:22 +01:00
|
|
|
connect addconroot2, localhost, root,,;
|
2006-08-21 10:18:59 +02:00
|
|
|
show open tables;
|
Update tests and result files after running with new mysqltest that better detects problems with test files
mysql-test/r/csv.result:
Update after add of missing semicolon
mysql-test/r/drop.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/flush.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/flush_block_commit.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/flush_read_lock_kill.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/grant2.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/handler.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/innodb_notembedded.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/kill.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/lock_multi.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/multi_update.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/mysqltest.result:
Update result
mysql-test/r/query_cache.result:
Update after add of missing semicolon
mysql-test/r/query_cache_notembedded.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/sp-threads.result:
Update result file, no space before commands that has been "sent"
mysql-test/r/sp_notembedded.result:
Update after add of missing semicolon
mysql-test/r/type_blob.result:
Remove extra drop table
mysql-test/t/csv.test:
Add missing semicolon
mysql-test/t/query_cache.test:
Add missing semicolon
mysql-test/t/sp-error.test:
Remove "tab" from end of error declaration
mysql-test/t/sp.test:
Wrong delimiter, used ; instead of |
mysql-test/t/sp_notembedded.test:
Wrong delimiter, used ; instead of |
mysql-test/t/view_grant.test:
An incomplete error name specification was used.
2006-10-04 13:09:37 +02:00
|
|
|
drop database mysqltest;
|
2016-03-25 17:51:22 +01:00
|
|
|
connection default;
|
2006-08-21 10:18:59 +02:00
|
|
|
select 1;
|
|
|
|
1
|
|
|
|
1
|
|
|
|
unlock tables;
|
2016-03-25 17:51:22 +01:00
|
|
|
connection addconroot1;
|
|
|
|
connection addconroot2;
|
|
|
|
disconnect addconroot2;
|
|
|
|
connection addconroot1;
|
|
|
|
disconnect addconroot1;
|
|
|
|
connection default;
|
Backport of:
------------------------------------------------------------
revno: 2476.784.3
committer: davi@moksha.local
timestamp: Tue 2007-10-02 21:27:31 -0300
message:
Bug#25858 Some DROP TABLE under LOCK TABLES can cause deadlocks
When a client (connection) holds a lock on a table and attempts to
drop (obtain a exclusive lock) on a second table that is already
held by a second client and the second client then attempts to
drop the table that is held by the first client, leads to a
circular wait deadlock. This scenario is very similar to trying to
drop (or rename) a table while holding read locks and are
correctly forbidden.
The solution is to allow a drop table operation to continue only
if the table being dropped is write (exclusively) locked, or if
the table is temporary, or if the client is not holding any
locks. Using this scheme prevents the creation of a circular
chain in which each client is waiting for one table that the
next client in the chain is holding.
This is incompatible change, as can be seen by number of tests
cases that needed to be fixed, but is consistent with respect to
behavior of the different scenarios in which the circular wait
might happen.
mysql-test/r/drop.result:
Test case result for Bug#25858
mysql-test/r/group_by.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/insert_notembedded.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table
mysql-test/r/lock.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/lock_multi.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/myisam.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/view.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/t/drop.test:
Add test case for Bug#25858
mysql-test/t/group_by.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/insert_notembedded.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/lock.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/lock_multi.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/myisam.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/query_cache_notembedded.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/view.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
sql/lock.cc:
When trying to obtain a name lock under lock tables, ensure that the table is properly exclusively locked and fail otherwise.
2009-11-20 20:51:12 +01:00
|
|
|
drop table if exists t1,t2;
|
|
|
|
create table t1 (a int);
|
|
|
|
create table t2 (a int);
|
|
|
|
lock table t1 read;
|
|
|
|
drop table t2;
|
|
|
|
ERROR HY000: Table 't2' was not locked with LOCK TABLES
|
|
|
|
drop table t1;
|
|
|
|
ERROR HY000: Table 't1' was locked with a READ lock and can't be updated
|
|
|
|
unlock tables;
|
|
|
|
drop table t1,t2;
|
2016-03-25 17:51:22 +01:00
|
|
|
connect addconroot, localhost, root,,;
|
|
|
|
connection default;
|
Backport of:
------------------------------------------------------------
revno: 2476.784.3
committer: davi@moksha.local
timestamp: Tue 2007-10-02 21:27:31 -0300
message:
Bug#25858 Some DROP TABLE under LOCK TABLES can cause deadlocks
When a client (connection) holds a lock on a table and attempts to
drop (obtain a exclusive lock) on a second table that is already
held by a second client and the second client then attempts to
drop the table that is held by the first client, leads to a
circular wait deadlock. This scenario is very similar to trying to
drop (or rename) a table while holding read locks and are
correctly forbidden.
The solution is to allow a drop table operation to continue only
if the table being dropped is write (exclusively) locked, or if
the table is temporary, or if the client is not holding any
locks. Using this scheme prevents the creation of a circular
chain in which each client is waiting for one table that the
next client in the chain is holding.
This is incompatible change, as can be seen by number of tests
cases that needed to be fixed, but is consistent with respect to
behavior of the different scenarios in which the circular wait
might happen.
mysql-test/r/drop.result:
Test case result for Bug#25858
mysql-test/r/group_by.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/insert_notembedded.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table
mysql-test/r/lock.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/lock_multi.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/myisam.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/view.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/t/drop.test:
Add test case for Bug#25858
mysql-test/t/group_by.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/insert_notembedded.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/lock.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/lock_multi.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/myisam.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/query_cache_notembedded.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/view.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
sql/lock.cc:
When trying to obtain a name lock under lock tables, ensure that the table is properly exclusively locked and fail otherwise.
2009-11-20 20:51:12 +01:00
|
|
|
create table t1 (i int);
|
|
|
|
create table t2 (i int);
|
|
|
|
lock tables t1 read;
|
2016-03-25 17:51:22 +01:00
|
|
|
connection addconroot;
|
Backport of:
------------------------------------------------------------
revno: 2476.784.3
committer: davi@moksha.local
timestamp: Tue 2007-10-02 21:27:31 -0300
message:
Bug#25858 Some DROP TABLE under LOCK TABLES can cause deadlocks
When a client (connection) holds a lock on a table and attempts to
drop (obtain a exclusive lock) on a second table that is already
held by a second client and the second client then attempts to
drop the table that is held by the first client, leads to a
circular wait deadlock. This scenario is very similar to trying to
drop (or rename) a table while holding read locks and are
correctly forbidden.
The solution is to allow a drop table operation to continue only
if the table being dropped is write (exclusively) locked, or if
the table is temporary, or if the client is not holding any
locks. Using this scheme prevents the creation of a circular
chain in which each client is waiting for one table that the
next client in the chain is holding.
This is incompatible change, as can be seen by number of tests
cases that needed to be fixed, but is consistent with respect to
behavior of the different scenarios in which the circular wait
might happen.
mysql-test/r/drop.result:
Test case result for Bug#25858
mysql-test/r/group_by.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/insert_notembedded.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table
mysql-test/r/lock.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/lock_multi.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/myisam.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/view.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/t/drop.test:
Add test case for Bug#25858
mysql-test/t/group_by.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/insert_notembedded.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/lock.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/lock_multi.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/myisam.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/query_cache_notembedded.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/view.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
sql/lock.cc:
When trying to obtain a name lock under lock tables, ensure that the table is properly exclusively locked and fail otherwise.
2009-11-20 20:51:12 +01:00
|
|
|
lock tables t2 read;
|
|
|
|
drop table t1;
|
|
|
|
ERROR HY000: Table 't1' was not locked with LOCK TABLES
|
2016-03-25 17:51:22 +01:00
|
|
|
connection default;
|
Backport of:
------------------------------------------------------------
revno: 2476.784.3
committer: davi@moksha.local
timestamp: Tue 2007-10-02 21:27:31 -0300
message:
Bug#25858 Some DROP TABLE under LOCK TABLES can cause deadlocks
When a client (connection) holds a lock on a table and attempts to
drop (obtain a exclusive lock) on a second table that is already
held by a second client and the second client then attempts to
drop the table that is held by the first client, leads to a
circular wait deadlock. This scenario is very similar to trying to
drop (or rename) a table while holding read locks and are
correctly forbidden.
The solution is to allow a drop table operation to continue only
if the table being dropped is write (exclusively) locked, or if
the table is temporary, or if the client is not holding any
locks. Using this scheme prevents the creation of a circular
chain in which each client is waiting for one table that the
next client in the chain is holding.
This is incompatible change, as can be seen by number of tests
cases that needed to be fixed, but is consistent with respect to
behavior of the different scenarios in which the circular wait
might happen.
mysql-test/r/drop.result:
Test case result for Bug#25858
mysql-test/r/group_by.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/insert_notembedded.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table
mysql-test/r/lock.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/lock_multi.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/myisam.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/view.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/t/drop.test:
Add test case for Bug#25858
mysql-test/t/group_by.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/insert_notembedded.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/lock.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/lock_multi.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/myisam.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/query_cache_notembedded.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/view.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
sql/lock.cc:
When trying to obtain a name lock under lock tables, ensure that the table is properly exclusively locked and fail otherwise.
2009-11-20 20:51:12 +01:00
|
|
|
drop table t1,t2;
|
|
|
|
ERROR HY000: Table 't1' was locked with a READ lock and can't be updated
|
2016-03-25 17:51:22 +01:00
|
|
|
disconnect addconroot;
|
|
|
|
connection default;
|
Backport of:
------------------------------------------------------------
revno: 2476.784.3
committer: davi@moksha.local
timestamp: Tue 2007-10-02 21:27:31 -0300
message:
Bug#25858 Some DROP TABLE under LOCK TABLES can cause deadlocks
When a client (connection) holds a lock on a table and attempts to
drop (obtain a exclusive lock) on a second table that is already
held by a second client and the second client then attempts to
drop the table that is held by the first client, leads to a
circular wait deadlock. This scenario is very similar to trying to
drop (or rename) a table while holding read locks and are
correctly forbidden.
The solution is to allow a drop table operation to continue only
if the table being dropped is write (exclusively) locked, or if
the table is temporary, or if the client is not holding any
locks. Using this scheme prevents the creation of a circular
chain in which each client is waiting for one table that the
next client in the chain is holding.
This is incompatible change, as can be seen by number of tests
cases that needed to be fixed, but is consistent with respect to
behavior of the different scenarios in which the circular wait
might happen.
mysql-test/r/drop.result:
Test case result for Bug#25858
mysql-test/r/group_by.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/insert_notembedded.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table
mysql-test/r/lock.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/lock_multi.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/myisam.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/r/view.result:
Fix test case result wrt drop table under lock tables -- unlock tables
before dropping table.
mysql-test/t/drop.test:
Add test case for Bug#25858
mysql-test/t/group_by.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/insert_notembedded.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/lock.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/lock_multi.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/myisam.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/query_cache_notembedded.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
mysql-test/t/view.test:
Fix test case: unlock tables in preparation for a drop table. In some
circumstances, dropping tables while holding locks leads to a deadlock.
sql/lock.cc:
When trying to obtain a name lock under lock tables, ensure that the table is properly exclusively locked and fail otherwise.
2009-11-20 20:51:12 +01:00
|
|
|
unlock tables;
|
|
|
|
drop table t1,t2;
|
2006-08-21 10:18:59 +02:00
|
|
|
End of 5.0 tests
|
2007-11-23 15:21:24 +01:00
|
|
|
create database mysql_test;
|
|
|
|
create table mysql_test.t1(f1 int);
|
|
|
|
create table mysql_test.`#sql-347f_7` (f1 int);
|
2007-11-26 09:56:31 +01:00
|
|
|
create table mysql_test.`#sql-347f_8` (f1 int);
|
|
|
|
drop table mysql_test.`#sql-347f_8`;
|
2007-11-23 15:21:24 +01:00
|
|
|
drop database mysql_test;
|
2020-06-16 09:34:38 +02:00
|
|
|
create database mysql_test;
|
|
|
|
use mysql_test;
|
|
|
|
create table t1(c int);
|
|
|
|
drop database mysql_test;
|
|
|
|
ERROR HY000: Error dropping database (can't rmdir './mysql_test', errno: 39 "Directory not empty")
|
|
|
|
select database();
|
|
|
|
database()
|
|
|
|
mysql_test
|
|
|
|
drop database mysql_test;
|
|
|
|
select database();
|
|
|
|
database()
|
|
|
|
NULL
|
|
|
|
use test;
|
2008-03-20 09:36:35 +01:00
|
|
|
|
|
|
|
# --
|
|
|
|
# -- Bug#29958: Weird message on DROP DATABASE if mysql.proc does not
|
|
|
|
# -- exist.
|
|
|
|
# --
|
|
|
|
DROP DATABASE IF EXISTS mysql_test;
|
|
|
|
CREATE DATABASE mysql_test;
|
|
|
|
DROP TABLE mysql.proc;
|
|
|
|
DROP DATABASE mysql_test;
|
|
|
|
Warnings:
|
|
|
|
Error 1146 Table 'mysql.proc' doesn't exist
|
|
|
|
|
|
|
|
# --
|
|
|
|
# -- End of Bug#29958.
|
|
|
|
# --
|
|
|
|
|
2008-03-12 17:40:12 +01:00
|
|
|
create database mysqltestbug26703;
|
|
|
|
use mysqltestbug26703;
|
|
|
|
create table `#mysql50#abc``def` ( id int );
|
|
|
|
create table `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` (a int);
|
|
|
|
ERROR 42000: Incorrect table name 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
|
|
|
|
create table `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` (a int);
|
2010-09-03 18:20:30 +02:00
|
|
|
create table `#mysql50#aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa1234` (a int);
|
|
|
|
create table `#mysql50#aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa12345` (a int);
|
|
|
|
ERROR 42000: Incorrect table name '#mysql50#aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa12345'
|
|
|
|
show tables;
|
|
|
|
Tables_in_mysqltestbug26703
|
2013-04-07 17:17:25 +02:00
|
|
|
#mysql50#abc`def
|
2010-09-03 18:20:30 +02:00
|
|
|
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa1234
|
|
|
|
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
|
2008-03-12 17:40:12 +01:00
|
|
|
use test;
|
|
|
|
drop database mysqltestbug26703;
|
2007-11-23 15:21:24 +01:00
|
|
|
End of 5.1 tests
|
2009-10-22 20:22:53 +02:00
|
|
|
|
|
|
|
# --
|
|
|
|
# -- Bug#37431 (DROP TABLE does not report errors correctly).
|
|
|
|
# --
|
|
|
|
DROP TABLE IF EXISTS t1;
|
|
|
|
DROP TABLE t1;
|
2013-07-03 18:48:41 +02:00
|
|
|
ERROR 42S02: Unknown table 'test.t1'
|
2009-10-22 20:22:53 +02:00
|
|
|
SHOW WARNINGS;
|
|
|
|
Level Code Message
|
2013-07-03 18:48:41 +02:00
|
|
|
Error 1051 Unknown table 'test.t1'
|
2009-10-22 20:22:53 +02:00
|
|
|
|
|
|
|
# --
|
|
|
|
# -- End of Bug#37431.
|
|
|
|
# --
|
2010-06-07 17:27:40 +02:00
|
|
|
#
|
|
|
|
# Bug#54282 Crash in MDL_context::upgrade_shared_lock_to_exclusive
|
|
|
|
#
|
|
|
|
DROP TABLE IF EXISTS t1;
|
|
|
|
CREATE TABLE t1 (a INT);
|
|
|
|
LOCK TABLE t1 WRITE;
|
|
|
|
DROP TABLE t1, t1;
|
|
|
|
ERROR 42000: Not unique table/alias: 't1'
|
|
|
|
UNLOCK TABLES;
|
|
|
|
DROP TABLE t1;
|
2014-03-20 00:44:35 +01:00
|
|
|
#
|
|
|
|
# BUG#34750: Print database name in Unknown Table error message
|
|
|
|
#
|
|
|
|
|
|
|
|
# Test error message when droping table/view
|
|
|
|
DROP TABLE table1;
|
|
|
|
ERROR 42S02: Unknown table 'test.table1'
|
|
|
|
DROP TABLE table1,table2;
|
|
|
|
ERROR 42S02: Unknown table 'test.table1,test.table2'
|
|
|
|
DROP VIEW view1,view2,view3,view4;
|
2017-03-26 21:30:43 +02:00
|
|
|
ERROR 42S02: Unknown VIEW: 'test.view1,test.view2,test.view3,test.view4'
|
2014-03-20 00:44:35 +01:00
|
|
|
|
|
|
|
DROP TABLE IF EXISTS table1;
|
|
|
|
Warnings:
|
|
|
|
Note 1051 Unknown table 'test.table1'
|
|
|
|
DROP TABLE IF EXISTS table1,table2;
|
|
|
|
Warnings:
|
2020-06-05 17:55:11 +02:00
|
|
|
Note 1051 Unknown table 'test.table1,test.table2'
|
2014-03-20 00:44:35 +01:00
|
|
|
DROP VIEW IF EXISTS view1,view2,view3,view4;
|
|
|
|
Warnings:
|
2020-06-05 11:51:01 +02:00
|
|
|
Note 4092 Unknown VIEW: 'test.view1,test.view2,test.view3,test.view4'
|
2014-03-20 00:44:35 +01:00
|
|
|
|
|
|
|
# Test error message when trigger does not find table
|
|
|
|
CREATE TABLE table1(a int);
|
|
|
|
CREATE TABLE table2(b int);
|
|
|
|
CREATE TRIGGER trg1 AFTER INSERT ON table1
|
|
|
|
FOR EACH ROW
|
|
|
|
INSERT INTO table2 SELECT t.notable.*;
|
|
|
|
INSERT INTO table1 VALUES (1);
|
|
|
|
ERROR 42S02: Unknown table 't.notable'
|
|
|
|
DROP TABLE table1,table2;
|
|
|
|
# End BUG#34750
|
2016-10-26 22:04:26 +02:00
|
|
|
#
|
|
|
|
# MDEV-11105 Table named 'db' has weird side effect.
|
|
|
|
#
|
|
|
|
CREATE DATABASE mysqltest;
|
|
|
|
CREATE TABLE mysqltest.db(id INT);
|
|
|
|
DROP DATABASE mysqltest;
|
2019-12-30 12:56:19 +01:00
|
|
|
#
|
|
|
|
# Verify sql_if_exists
|
|
|
|
#
|
|
|
|
DROP DATABASE mysqltest;
|
|
|
|
ERROR HY000: Can't drop database 'mysqltest'; database doesn't exist
|
|
|
|
CREATE DATABASE mysqltest;
|
|
|
|
drop table mysqltest.does_not_exists;
|
|
|
|
ERROR 42S02: Unknown table 'mysqltest.does_not_exists'
|
|
|
|
set @@session.sql_if_exists=1;
|
|
|
|
drop table mysqltest.does_not_exists;
|
|
|
|
Warnings:
|
|
|
|
Note 1051 Unknown table 'mysqltest.does_not_exists'
|
|
|
|
drop database mysqltest;
|
|
|
|
drop database mysqltest;
|
|
|
|
Warnings:
|
|
|
|
Note 1008 Can't drop database 'mysqltest'; database doesn't exist
|
|
|
|
set @@session.sql_if_exists=0;
|