mariadb/sql/log_event_old.h

572 lines
19 KiB
C
Raw Normal View History

/* Copyright (c) 2007, 2013, Oracle and/or its affiliates.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA */
#ifndef LOG_EVENT_OLD_H
#define LOG_EVENT_OLD_H
/*
Need to include this file at the proper position of log_event.h
*/
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
/**
@file
@brief This file contains classes handling old formats of row-based
binlog events.
*/
/*
Around 2007-10-31, I made these classes completely separated from
the new classes (before, there was a complex class hierarchy
involving multiple inheritance; see BUG#31581), by simply copying
and pasting the entire contents of Rows_log_event into
Old_rows_log_event and the entire contents of
{Write|Update|Delete}_rows_log_event into
{Write|Update|Delete}_rows_log_event_old. For clarity, I will keep
the comments marking which code was cut-and-pasted for some time.
With the classes collapsed into one, there is probably some
redundancy (maybe some methods can be simplified and/or removed),
but we keep them this way for now. /Sven
*/
/* These classes are based on the v1 RowsHeaderLen */
#undef ROWS_HEADER_LEN
#define ROWS_HEADER_LEN ROWS_HEADER_LEN_V1
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
/**
@class Old_rows_log_event
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
Base class for the three types of row-based events
{Write|Update|Delete}_row_log_event_old, with event type codes
PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. These events are never
created any more, except when reading a relay log created by an old
server.
*/
class Old_rows_log_event : public Log_event
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
{
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
/********** BEGIN CUT & PASTE FROM Rows_log_event **********/
public:
/**
Enumeration of the errors that can be returned.
*/
enum enum_error
{
ERR_OPEN_FAILURE = -1, /**< Failure to open table */
ERR_OK = 0, /**< No error */
ERR_TABLE_LIMIT_EXCEEDED = 1, /**< No more room for tables */
ERR_OUT_OF_MEM = 2, /**< Out of memory */
ERR_BAD_TABLE_DEF = 3, /**< Table definition does not match */
ERR_RBR_TO_SBR = 4 /**< daisy-chanining RBR to SBR not allowed */
};
/*
These definitions allow you to combine the flags into an
appropriate flag set using the normal bitwise operators. The
implicit conversion from an enum-constant to an integer is
accepted by the compiler, which is then used to set the real set
of flags.
*/
enum enum_flag
{
/* Last event of a statement */
STMT_END_F = (1U << 0),
/* Value of the OPTION_NO_FOREIGN_KEY_CHECKS flag in thd->options */
NO_FOREIGN_KEY_CHECKS_F = (1U << 1),
/* Value of the OPTION_RELAXED_UNIQUE_CHECKS flag in thd->options */
RELAXED_UNIQUE_CHECKS_F = (1U << 2),
/**
Indicates that rows in this event are complete, that is contain
values for all columns of the table.
*/
COMPLETE_ROWS_F = (1U << 3)
};
typedef uint16 flag_set;
/* Special constants representing sets of flags */
enum
{
RLE_NO_FLAGS = 0U
};
virtual ~Old_rows_log_event();
void set_flags(flag_set flags_arg) { m_flags |= flags_arg; }
void clear_flags(flag_set flags_arg) { m_flags &= ~flags_arg; }
flag_set get_flags(flag_set flags_arg) const { return m_flags & flags_arg; }
#if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
void pack_info(Protocol *protocol) override;
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#endif
#ifdef MYSQL_CLIENT
/* not for direct call, each derived has its own ::print() */
bool print(FILE *file, PRINT_EVENT_INFO *print_event_info) override= 0;
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#endif
#ifndef MYSQL_CLIENT
int add_row_data(uchar *data, size_t length)
{
return do_add_row_data(data,length);
}
#endif
/* Member functions to implement superclass interface */
int get_data_size() override;
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
MY_BITMAP const *get_cols() const { return &m_cols; }
size_t get_width() const { return m_width; }
ulonglong get_table_id() const { return m_table_id; }
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#ifndef MYSQL_CLIENT
bool write_data_header() override;
bool write_data_body() override;
const char *get_db() override { return m_table->s->db.str; }
#ifdef HAVE_REPLICATION
bool is_part_of_group() override { return 1; }
#endif
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#endif
/*
Check that malloc() succeeded in allocating memory for the rows
buffer and the COLS vector. Checking that an Update_rows_log_event_old
is valid is done in the Update_rows_log_event_old::is_valid()
function.
*/
bool is_valid() const override
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
{
return m_rows_buf && m_cols.bitmap;
}
uint m_row_count; /* The number of rows added to the event */
protected:
/*
The constructors are protected since you're supposed to inherit
this class, not create instances of this class.
*/
#ifndef MYSQL_CLIENT
Old_rows_log_event(THD*, TABLE*, ulonglong table_id,
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
MY_BITMAP const *cols, bool is_transactional);
#endif
Old_rows_log_event(const uchar *row_data, uint event_len,
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
Log_event_type event_type,
const Format_description_log_event *description_event);
#ifdef MYSQL_CLIENT
mysqlbinlog now prints "# Number of rows" and stops on errors Main problem was that no log-event print function checked for disk full error on the IO_CACHE. All changes in this patch only affects mysqlbinlog, not the server! - Changed all log-event print functions to return 1 on error - Fixed memory usage when not using --flashback. - Added printing of number of rows in row events. Can be disabled with --print-row-count=0 - Print annotated rows when using mysqlbinlog --short-form - Fixed that mysqlbinlog --debug works - Fixed create_drop_binlog.test test failure - Reorganized fields in PRINT_EVENT_INFO to be according to size to optimize storage - Don't change print_row_event_position or print_row_counts if set by user - Remove some testing of argument to my_free is 0 - base64-output=never is now supported and works in all context - Updated help information for --base64-output and --short-form - print_row_count is now on by default. Reset automatically if --short-form is used - Removed obsolote warning for mysql 5.6.0 - More DBUG_PRINT for mysqltest.cc - my_b_write_byte() now checks for flush failures. This fixed a memory overrun on disk full - my_b_printf() now returns 1 on failure, 0 on ok. This simplifies code and no old code was using the old return value of my_b_printf(). - my_b_Write_backtick_quote() now returns 1 on failure and 0 on ok - Fixed some error conditions in log printing that was not previously handled. - Slave_rows_error_report() can now handle longlong positions - Write_on_release_cache() rewritten so that we can detect errors on flush. Not depending on automatic release anymore. - Changed types for Pos and End_log_pos to 64 bit in SHOW BINLOG EVENTS - Fixed that copy_event_cache_to_string_and_reinit() works with strings longer than 4G (Changed to use LEX_STRING instead of String) - Restricted binlog_rows_event_max_size to UINT32_MAX-1 as String's are anyway restricted to UINT32_MAX - Fixed bug in rpl_binlog_state::write_to_iocache() which hide write failures (duplicate variable name) - Fixed bug in String::append if original string was not allocated - Stop mysqlbinlog output at once if there is an error. - Before printing error message, flush result file. This ensures that the error message is printed last. (Easier to find)
2017-12-23 15:59:41 +01:00
bool print_helper(FILE *, PRINT_EVENT_INFO *, char const *const name);
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#endif
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#ifndef MYSQL_CLIENT
virtual int do_add_row_data(uchar *data, size_t length);
#endif
#ifndef MYSQL_CLIENT
TABLE *m_table; /* The table the rows belong to */
#endif
ulonglong m_table_id; /* Table ID */
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
MY_BITMAP m_cols; /* Bitmap denoting columns available */
ulong m_width; /* The width of the columns bitmap */
ulong m_master_reclength; /* Length of record on master side */
/* Bit buffers in the same memory as the class */
Optimize performance of my_bitmap MDEV-33502 Slowdown when running nested statement with many partitions This change was triggered to help some MariaDB users with close to 10000 bits in their bitmaps. - Change underlaying storage to be 64 bit instead of 32bit. - This reduses number of loops to scan bitmaps. - This can cause some bitmaps to be 4 byte large. - Ensure that all not used top-bits are always 0 (simplifes code as the last 64 bit storage is not a special case anymore). - Use my_find_first_bit() to find the first set bit which is much faster than scanning trough things byte by byte and then bit by bit. Other things: - Added a bool to remember if my_bitmap_init() did allocate the bitmap array. my_bitmap_free() will only free arrays it did allocate. This allowed me to remove setting 'bitmap=0' before calling my_bitmap_free() for cases where the bitmap's where allocated externally. - my_bitmap_init() sets bitmap to 0 in case of failure. - Added 'universal' asserts to most bitmap functions. - Change all remaining calls to bitmap_init() to my_bitmap_init(). - To finish the change from 2014. - Changed all usage of uint32 in my_bitmap.h to my_bitmap_map. - Updated bitmap_copy() to handle bitmaps of different size. - Removed const from bitmap_exists_intersection() as this caused casts on all usage. - Removed not used function bitmap_set_above(). - Renamed create_last_word_mask() to create_last_bit_mask() (to match name changes in my_bitmap.cc) - Extended bitmap-t with test for more bitmap functions.
2024-02-18 16:30:01 +01:00
my_bitmap_map m_bitbuf[128/(sizeof(my_bitmap_map)*8)];
my_bitmap_map m_bitbuf_ai[128/(sizeof(my_bitmap_map)*8)];
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
uchar *m_rows_buf; /* The rows in packed format */
uchar *m_rows_cur; /* One-after the end of the data */
uchar *m_rows_end; /* One-after the end of the allocated space */
flag_set m_flags; /* Flags for row-level events */
/* helper functions */
#if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
const uchar *m_curr_row; /* Start of the row being processed */
const uchar *m_curr_row_end; /* One-after the end of the current row */
uchar *m_key; /* Buffer to keep key value during searches */
int find_row(rpl_group_info *);
int write_row(rpl_group_info *, const bool);
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
// Unpack the current row into m_table->record[0]
int unpack_current_row(rpl_group_info *rgi)
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
{
DBUG_ASSERT(m_table);
ASSERT_OR_RETURN_ERROR(m_curr_row < m_rows_end, HA_ERR_CORRUPT_EVENT);
2014-02-25 16:04:35 +01:00
return ::unpack_row(rgi, m_table, m_width, m_curr_row, &m_cols,
Bug#17632978 SLAVE CRASHES IF ROW EVENT IS CORRUPTED (MYSQLBINLOG -V CRASHES WITH THAT BINLOG) Problem: If slave receives a corrupted row event, slave server is crashing. Analysis: When slave is unpacking the row event, it is not validating the data before applying the event. If the data is corrupted for eg: the length of a field is wrong, it could end up reading wrong data leading to a crash. A similar problem happens when mysqlbinlog tool is used against a corrupted binlog using '-v' option. Due to -v option, the tool tries to print the values of all the fields. Corrupted field length could lead to a crash. Fix: Before unpacking the field, a verification will be made on the length. If it falls into the event range, only then it will be unpacked. Otherwise, "ER_SLAVE_CORRUPT_EVENT" error will be thrown. Incase mysqlbinlog -v case, the field value will not be printed and the processing of the file will be stopped. sql/field.h: Removed a function which is not required anymore sql/log_event.cc: Adding a validation on the field length before the tool tries to print the value. sql/log_event.h: Changing unpack_row call according to the new arguments sql/log_event_old.h: Changing unpack_row call according to the new arguments sql/rpl_record.cc: Adding a new argument 'row_end' which tells the end position of the complete data in the row event. It will be used to do validation before doing 'unpack' field. sql/rpl_record.h: Adding a new argument 'row_end' which tells the end position of the complete data in the row event. It will be used to do validation before doing 'unpack' field. sql/rpl_utility.cc: Now calc_field_size() is required for client too.
2013-12-17 17:41:22 +01:00
&m_curr_row_end, &m_master_reclength, m_rows_end);
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
}
#endif
private:
#if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
int do_apply_event(rpl_group_info *rgi) override;
int do_update_pos(rpl_group_info *rgi) override;
enum_skip_reason do_shall_skip(rpl_group_info *rgi) override;
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
/*
Primitive to prepare for a sequence of row executions.
DESCRIPTION
Before doing a sequence of do_prepare_row() and do_exec_row()
calls, this member function should be called to prepare for the
entire sequence. Typically, this member function will allocate
space for any buffers that are needed for the two member
functions mentioned above.
RETURN VALUE
The member function will return 0 if all went OK, or a non-zero
error code otherwise.
*/
virtual
int do_before_row_operations(const Slave_reporting_capability *const log) = 0;
/*
Primitive to clean up after a sequence of row executions.
DESCRIPTION
After doing a sequence of do_prepare_row() and do_exec_row(),
this member function should be called to clean up and release
any allocated buffers.
The error argument, if non-zero, indicates an error which happened during
row processing before this function was called. In this case, even if
function is successful, it should return the error code given in the argument.
*/
virtual
int do_after_row_operations(const Slave_reporting_capability *const log,
int error) = 0;
/*
Primitive to do the actual execution necessary for a row.
DESCRIPTION
The member function will do the actual execution needed to handle a row.
The row is located at m_curr_row. When the function returns,
m_curr_row_end should point at the next row (one byte after the end
of the current row).
RETURN VALUE
0 if execution succeeded, 1 if execution failed.
*/
virtual int do_exec_row(rpl_group_info *rgi) = 0;
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#endif /* !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION) */
/********** END OF CUT & PASTE FROM Rows_log_event **********/
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
protected:
#if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
int do_apply_event(Old_rows_log_event*, rpl_group_info *rgi);
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
/*
Primitive to prepare for a sequence of row executions.
DESCRIPTION
Before doing a sequence of do_prepare_row() and do_exec_row()
calls, this member function should be called to prepare for the
entire sequence. Typically, this member function will allocate
space for any buffers that are needed for the two member
functions mentioned above.
RETURN VALUE
The member function will return 0 if all went OK, or a non-zero
error code otherwise.
*/
virtual int do_before_row_operations(TABLE *table) = 0;
/*
Primitive to clean up after a sequence of row executions.
DESCRIPTION
After doing a sequence of do_prepare_row() and do_exec_row(),
this member function should be called to clean up and release
any allocated buffers.
*/
virtual int do_after_row_operations(TABLE *table, int error) = 0;
/*
Primitive to prepare for handling one row in a row-level event.
DESCRIPTION
The member function prepares for execution of operations needed for one
row in a row-level event by reading up data from the buffer containing
the row. No specific interpretation of the data is normally done here,
since SQL thread specific data is not available: that data is made
available for the do_exec function.
A pointer to the start of the next row, or NULL if the preparation
failed. Currently, preparation cannot fail, but don't rely on this
behavior.
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
RETURN VALUE
Error code, if something went wrong, 0 otherwise.
*/
virtual int do_prepare_row(THD*, rpl_group_info*, TABLE*,
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
uchar const *row_start,
uchar const **row_end) = 0;
/*
Primitive to do the actual execution necessary for a row.
DESCRIPTION
The member function will do the actual execution needed to handle a row.
RETURN VALUE
0 if execution succeeded, 1 if execution failed.
*/
virtual int do_exec_row(TABLE *table) = 0;
#endif /* !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION) */
};
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
/**
@class Write_rows_log_event_old
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
Old class for binlog events that write new rows to a table (event
type code PRE_GA_WRITE_ROWS_EVENT). Such events are never produced
by this version of the server, but they may be read from a relay log
created by an old server. New servers create events of class
Write_rows_log_event (event type code WRITE_ROWS_EVENT) instead.
*/
class Write_rows_log_event_old : public Old_rows_log_event
{
/********** BEGIN CUT & PASTE FROM Write_rows_log_event **********/
public:
#if !defined(MYSQL_CLIENT)
Write_rows_log_event_old(THD*, TABLE*, ulonglong table_id,
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
MY_BITMAP const *cols, bool is_transactional);
#endif
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#ifdef HAVE_REPLICATION
Write_rows_log_event_old(const uchar *buf, uint event_len,
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
const Format_description_log_event *description_event);
#endif
#if !defined(MYSQL_CLIENT)
static bool binlog_row_logging_function(THD *thd, TABLE *table,
bool is_transactional,
const uchar *before_record
__attribute__((unused)),
const uchar *after_record)
{
return thd->binlog_write_row(table, is_transactional, after_record);
}
#endif
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
private:
#ifdef MYSQL_CLIENT
bool print(FILE *file, PRINT_EVENT_INFO *print_event_info) override;
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#endif
#if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
int do_before_row_operations(const Slave_reporting_capability *const) override;
int do_after_row_operations(const Slave_reporting_capability *const,int) override;
int do_exec_row(rpl_group_info *) override;
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#endif
/********** END OF CUT & PASTE FROM Write_rows_log_event **********/
public:
enum
{
/* Support interface to THD::binlog_prepare_pending_rows_event */
TYPE_CODE = PRE_GA_WRITE_ROWS_EVENT
};
private:
Log_event_type get_type_code() override { return (Log_event_type)TYPE_CODE; }
#if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
// use old definition of do_apply_event()
int do_apply_event(rpl_group_info *rgi) override
{ return Old_rows_log_event::do_apply_event(this, rgi); }
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
// primitives for old version of do_apply_event()
int do_before_row_operations(TABLE *table) override;
int do_after_row_operations(TABLE *table, int error) override;
virtual int do_prepare_row(THD*, rpl_group_info*, TABLE*,
uchar const *row_start, uchar const **row_end) override;
int do_exec_row(TABLE *table) override;
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
#endif
};
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
/**
@class Update_rows_log_event_old
Old class for binlog events that modify existing rows to a table
(event type code PRE_GA_UPDATE_ROWS_EVENT). Such events are never
produced by this version of the server, but they may be read from a
relay log created by an old server. New servers create events of
class Update_rows_log_event (event type code UPDATE_ROWS_EVENT)
instead.
*/
class Update_rows_log_event_old : public Old_rows_log_event
{
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
/********** BEGIN CUT & PASTE FROM Update_rows_log_event **********/
public:
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#ifndef MYSQL_CLIENT
Update_rows_log_event_old(THD*, TABLE*, ulonglong table_id,
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
MY_BITMAP const *cols,
bool is_transactional);
#endif
#ifdef HAVE_REPLICATION
Update_rows_log_event_old(const uchar *buf, uint event_len,
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
const Format_description_log_event *description_event);
#endif
#if !defined(MYSQL_CLIENT)
static bool binlog_row_logging_function(THD *thd, TABLE *table,
bool is_transactional,
MY_BITMAP *cols,
uint fields,
const uchar *before_record,
const uchar *after_record)
{
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
return thd->binlog_update_row(table, is_transactional,
before_record, after_record);
}
#endif
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
protected:
#ifdef MYSQL_CLIENT
bool print(FILE *file, PRINT_EVENT_INFO *print_event_info) override;
#endif
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
int do_before_row_operations(const Slave_reporting_capability *const) override;
int do_after_row_operations(const Slave_reporting_capability *const,int) override;
int do_exec_row(rpl_group_info *) override;
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#endif /* !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION) */
/********** END OF CUT & PASTE FROM Update_rows_log_event **********/
uchar *m_after_image, *m_memory;
public:
enum
{
/* Support interface to THD::binlog_prepare_pending_rows_event */
TYPE_CODE = PRE_GA_UPDATE_ROWS_EVENT
};
private:
Log_event_type get_type_code() override { return (Log_event_type)TYPE_CODE; }
#if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
// use old definition of do_apply_event()
int do_apply_event(rpl_group_info *rgi) override
{ return Old_rows_log_event::do_apply_event(this, rgi); }
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
// primitives for old version of do_apply_event()
int do_before_row_operations(TABLE *table) override;
int do_after_row_operations(TABLE *table, int error) override;
virtual int do_prepare_row(THD*, rpl_group_info*, TABLE*,
uchar const *row_start, uchar const **row_end) override;
int do_exec_row(TABLE *table) override;
#endif /* !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION) */
};
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
/**
@class Delete_rows_log_event_old
Old class for binlog events that delete existing rows from a table
(event type code PRE_GA_DELETE_ROWS_EVENT). Such events are never
produced by this version of the server, but they may be read from a
relay log created by an old server. New servers create events of
class Delete_rows_log_event (event type code DELETE_ROWS_EVENT)
instead.
*/
class Delete_rows_log_event_old : public Old_rows_log_event
{
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
/********** BEGIN CUT & PASTE FROM Update_rows_log_event **********/
public:
#ifndef MYSQL_CLIENT
Delete_rows_log_event_old(THD*, TABLE*, ulonglong,
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
MY_BITMAP const *cols, bool is_transactional);
#endif
#ifdef HAVE_REPLICATION
Delete_rows_log_event_old(const uchar *buf, uint event_len,
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
const Format_description_log_event *description_event);
#endif
#if !defined(MYSQL_CLIENT)
static bool binlog_row_logging_function(THD *thd, TABLE *table,
bool is_transactional,
MY_BITMAP *cols,
uint fields,
const uchar *before_record,
const uchar *after_record
__attribute__((unused)))
{
return thd->binlog_delete_row(table, is_transactional, before_record);
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
}
#endif
protected:
#ifdef MYSQL_CLIENT
bool print(FILE *file, PRINT_EVENT_INFO *print_event_info) override;
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#endif
#if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
int do_before_row_operations(const Slave_reporting_capability *const) override;
int do_after_row_operations(const Slave_reporting_capability *const,int) override;
int do_exec_row(rpl_group_info *) override;
BUG#31581: 5.1-telco-6.1 -> 5.1.22. Slave crashes during starting This patch has two purposes: (1) To refactor the code so that {Write|Update|Delete}_rows_log_event_old does not use code from {Write|Update|Delete}_rows_log_event. Before refactoring there was the following problem: whenever we modifed the code for new events, it affected the old events. This is bad, as it makes maintainance difficult. After refactoring, we can safely edit the new code without affecting old events. So, if we for instance modify the binary format of new events, we no longer need to worry about how the new code reads old events. (2) To fix BUG#31581. These two objectives are reached by the following changes: - Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. - Fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. - Added comments to log_event_old.h (This patch is identical to the previously committed patch which was a collapse of three changesets, except that it adds assert(0) to constructors for old types of row log events that should never be called.) sql/log_event_old.cc: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also fixed the bug by replacing {WRITE|UPDATE|DELETE}_ROWS_EVENT by PRE_GA_{WRITE|UPDATE|DELETE}_ROWS_EVENT. sql/log_event_old.h: Merged Rows_log_event into Old_rows_log_event and {Write|Update|Delete}_rows_log_event into {Write|Update|Delete}_rows_log_event_old. Also added comment explaining what the file contains and what the classes do.
2007-11-20 19:49:35 +01:00
#endif
/********** END CUT & PASTE FROM Delete_rows_log_event **********/
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
uchar *m_after_image, *m_memory;
public:
enum
{
/* Support interface to THD::binlog_prepare_pending_rows_event */
TYPE_CODE = PRE_GA_DELETE_ROWS_EVENT
};
private:
Log_event_type get_type_code() override { return (Log_event_type)TYPE_CODE; }
#if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
// use old definition of do_apply_event()
int do_apply_event(rpl_group_info *rgi) override
{ return Old_rows_log_event::do_apply_event(this, rgi); }
BUG#21842 (Cluster fails to replicate to innodb or myisam with err 134 using TPC-B): Problem: A RBR event can contain incomplete row data (only key value and fields which have been changed). In that case, when the row is unpacked into record and written to a table, the missing fields get incorrect NULL values leading to master-slave inconsistency. Solution: Use values found in slave's table for columns which are not given in the rows event. The code for writing a single row uses the following algorithm: 1. unpack row_data into table->record[0], 2. try to insert record, 3. if duplicate record found, fetch it into table->record[0], 4. unpack row_data into table->record[0], 5. write table->record[0] into the table. Where row_data is the row as stored in the data area of a rows event. Thus: a) unpacking of row_data happens at the time when row is written into a table, b) when unpacking (in step 4), only columns present in row_data are overwritten - all other columns remain as they were found in the table. Since all data needed for the above algorithm is stored inside Rows_log_event class, functions which locate and write rows are turned into methods of that class. replace_record() -> Rows_log_event::write_row() find_and_fetch_row() -> Rows_log_event::find_row() Both methods take row data from event's data buffer - the row being processed is pointed by m_curr_row. They unpack the data as needed into table's record buffers record[0] or record[1]. When row is unpacked, m_curr_row_end is set to point at next row in the data buffer. Other changes introduced in this changeset: - Change signature of unpack_row(): don't report errors and don't setup table's rw_set here. Errors can happen only when setting default values in prepare_record() function and are detected there. - In Rows_log_event and derived classes, don't pass arguments to the execution primitives (do_...() member functions) but use class members instead. - Move old row handling code into log_event_old.cc to be used by *_rows_log_event_old classes. Also, a new test rpl_ndb_2other is added which tests basic replication from master using ndb tables to slave storing the same tables using (possibly) different engine (myisam,innodb). Test is based on existing tests rpl_ndb_2myisam and rpl_ndb_2innodb. However, these tests doesn't work for various reasons and currently are disabled (see BUG#19227). The new test differs from the ones it is based on as follows: 1. Single test tests replication with different storage engines on slave (myisam, innodb, ndb). 2. Include file extra/rpl_tests/rpl_ndb_2multi_eng.test containing original tests is replaced by extra/rpl_tests/rpl_ndb_2multi_basic.test which doesn't contain tests using partitioned tables as these don't work currently. Instead, it tests replication to a slave which has more or less columns than master. 3. Include file include/rpl_multi_engine3.inc is replaced with include/rpl_multi_engine2.inc. The later differs by performing slightly different operations (updating more than one row in the table) and clearing table with "TRUNCATE TABLE" statement instead of "DELETE FROM" as replication of "DELETE" doesn't work well in this setting. 4. Slave must use option --log-slave-updates=0 as otherwise execution of replication events generated by ndb fails if table uses a different storage engine on slave (see BUG#29569). sql/log_event.cc: - Initialization of new Rows_log_event members. - Fixing some typos in documentation. In Rows_log_event::do_apply_event: - Set COMPLETE_ROWS_F flag (when master and slave have the same number of columns and all colums are present in the row) - Move initialization of tables write/read sets here, outside the rows processing loop (and out of unpack_row() function). - Remove calls to do_prepare_row() - no longer needed. - Add code managing m_curr_row and m_curr_row_end pointers. - Change signatures of row processing methods of Rows_log_event and it descendants - now most arguments are taken from class members. - Remove do_prepare_row() methods which are no longer used. - The auto_afree_ptr template is moved to rpl_utility.h (so that it can be used in log_event_old.cc). - Removed copy_extra_fields() function - no longer used. In Rows_log_event::write_row (former replace_record): - The old code is moved to log_event_old.cc. - Use prepare_record() and non-destructive unpack_current_row() to fill record with data. - In case a record being inserted already exists on slave and row data is incomplete use the record found and non-destructive unpack_current_row() to combine new column values with existing ones. - More debug info added. In Rows_log_event::find_row (former find_and_fetch_row function): - The old code is moved to log_event_old.cc. - Unpacking of the row is moved here. - In case of search using PK, the key data is prepared here. - More debug info added. - Remove initialization of Rows_log_event::m_after_image buffer which is no longer used. - Use new row unpacking methods in Update_rows_log_event::do_exec_row() to create before and after image. Note: all existing code used by Rows_log_event::do_apply_event() has been moved to log_event_old.cc to be used by *_rows_log_event_old classes. sql/log_event.h: - Add new COMPLETE_ROWS_F flag in Rows_log_event. - Add Rows_log_event members describing the row being processed. - Add a pointer to key buffer which is used in derived classes. - Add new methods: find__row(), write_row() and unpack_current_row(). - Change signatures of do_...() methods (replace method arguments by class members). - Remove do_prepare_row() method which is no longer used. - Update method documentation. - Add Old_rows_log_event class, which contains the old row processing code, as a friend of Rows_log_event so that it can access all members of an event instance. sql/log_event_old.cc: Move here old implementation of Rows_log_event::do_apply_event() and helper methods. sql/log_event_old.h: - Define new class Old_rows_log_event encapsulating old version of Rows_log_event::do_apply_event() and the helper methods. - Add the Old_rows_log_event class as a base for *_old versions of RBR event classes, ensure that the old version of do_apply_event() is called. - For *_old classes, declare the helper methods used in the old version of do_apply_event(). sql/rpl_record.cc: - Make unpack_row non-destructive for columns not present in the row. - Don't fill read/write set here as it is done outside these functions. - Move initialization of a record with default values to a separate function prepare_record(). sql/rpl_record.h: - Change signature of unpack_row(). - Declare function prepare_record(). sql/rpl_utility.cc: Make tabe_def::calc_field_size() a const method. sql/rpl_utility.h: Make table_def::calc_field_size() a const method. Move auto_afree_ptr template here so that it can be re-used (currently in log_event.cc and log_event_old.cc). Similar with DBUG_PRINT_BITSET macro. mysql-test/extra/rpl_tests/rpl_ndb_2multi_basic.test: Modification of rpl_ndb_2multi_eng test. Tests with partitioned tables are removed and a setup with slave having different number of columns than master is added. mysql-test/include/rpl_multi_engine2.inc: Modification of rpl_multi_engine3.inc which operates on more rows and replaces "DELETE FROM t1" with "TRUNCATE TABLE t1" as the first form doesn't replicate in NDB -> non-NDB setting (BUG#28538). mysql-test/suite/rpl_ndb/r/rpl_ndb_2other.result: Results of the test. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other-slave.opt: Test options. --log-slave-updates=0 is compulsory as otherwise non-NDB slave applying row events from NDB master will fail when trying to log them. mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test: Test replication of NDB table to slave using other engine. The main test is in extra/rpl_tests/rpl_ndb_2multi_basic.test. It is included here several times with different settings of default storage engine on slave.
2007-08-26 14:31:10 +02:00
// primitives for old version of do_apply_event()
int do_before_row_operations(TABLE *table) override;
int do_after_row_operations(TABLE *table, int error) override;
virtual int do_prepare_row(THD*, rpl_group_info*, TABLE*,
uchar const *row_start, uchar const **row_end) override;
int do_exec_row(TABLE *table) override;
#endif
};
#endif