2005-04-04 00:50:05 +02:00
|
|
|
|
#
|
|
|
|
|
# WL#1756
|
|
|
|
|
#
|
|
|
|
|
-- source include/have_innodb.inc
|
2009-03-03 21:34:18 +01:00
|
|
|
|
|
2011-04-14 10:13:28 +02:00
|
|
|
|
--source include/not_embedded.inc
|
|
|
|
|
|
2009-03-03 21:34:18 +01:00
|
|
|
|
# Save the initial number of concurrent sessions
|
|
|
|
|
--source include/count_sessions.inc
|
|
|
|
|
|
2016-12-19 23:32:45 +01:00
|
|
|
|
call mtr.add_suppression("Deadlock found when trying to get lock; try restarting transaction");
|
|
|
|
|
|
2005-04-04 00:50:05 +02:00
|
|
|
|
--disable_warnings
|
|
|
|
|
drop table if exists t1, t2;
|
|
|
|
|
--enable_warnings
|
|
|
|
|
create table t1 (a int) engine=innodb;
|
|
|
|
|
xa start 'test1';
|
|
|
|
|
insert t1 values (10);
|
|
|
|
|
xa end 'test1';
|
|
|
|
|
xa prepare 'test1';
|
|
|
|
|
xa rollback 'test1';
|
|
|
|
|
select * from t1;
|
|
|
|
|
|
|
|
|
|
xa start 'test2';
|
2009-03-03 21:34:18 +01:00
|
|
|
|
--error ER_XAER_RMFAIL
|
2005-04-04 00:50:05 +02:00
|
|
|
|
xa start 'test-bad';
|
|
|
|
|
insert t1 values (20);
|
2009-03-03 21:34:18 +01:00
|
|
|
|
--error ER_XAER_RMFAIL
|
2005-04-04 00:50:05 +02:00
|
|
|
|
xa prepare 'test2';
|
|
|
|
|
xa end 'test2';
|
|
|
|
|
xa prepare 'test2';
|
|
|
|
|
xa commit 'test2';
|
|
|
|
|
select * from t1;
|
|
|
|
|
|
|
|
|
|
xa start 'testa','testb';
|
|
|
|
|
insert t1 values (30);
|
2005-10-05 19:58:16 +02:00
|
|
|
|
|
2009-03-03 21:34:18 +01:00
|
|
|
|
--error ER_XAER_RMFAIL
|
2005-10-05 19:58:16 +02:00
|
|
|
|
commit;
|
|
|
|
|
|
2005-04-04 00:50:05 +02:00
|
|
|
|
xa end 'testa','testb';
|
|
|
|
|
|
2009-03-03 21:34:18 +01:00
|
|
|
|
--error ER_XAER_RMFAIL
|
2005-10-05 19:58:16 +02:00
|
|
|
|
begin;
|
2009-03-03 21:34:18 +01:00
|
|
|
|
--error ER_XAER_RMFAIL
|
2005-10-05 19:58:16 +02:00
|
|
|
|
create table t2 (a int);
|
|
|
|
|
|
2007-02-26 11:49:24 +01:00
|
|
|
|
connect (con1,localhost,root,,);
|
2005-04-04 00:50:05 +02:00
|
|
|
|
connection con1;
|
|
|
|
|
|
2009-03-03 21:34:18 +01:00
|
|
|
|
--error ER_XAER_DUPID
|
2005-08-12 21:15:01 +02:00
|
|
|
|
xa start 'testa','testb';
|
2009-03-03 21:34:18 +01:00
|
|
|
|
--error ER_XAER_DUPID
|
2005-10-05 16:38:53 +02:00
|
|
|
|
xa start 'testa','testb', 123;
|
2005-08-12 21:15:01 +02:00
|
|
|
|
|
2005-04-05 13:17:49 +02:00
|
|
|
|
# gtrid [ , bqual [ , formatID ] ]
|
2005-04-04 00:50:05 +02:00
|
|
|
|
xa start 0x7465737462, 0x2030405060, 0xb;
|
|
|
|
|
insert t1 values (40);
|
|
|
|
|
xa end 'testb',' 0@P`',11;
|
|
|
|
|
xa prepare 'testb',0x2030405060,11;
|
|
|
|
|
|
2009-03-03 21:34:18 +01:00
|
|
|
|
--error ER_XAER_RMFAIL
|
2005-10-05 19:58:16 +02:00
|
|
|
|
start transaction;
|
|
|
|
|
|
2005-04-04 00:50:05 +02:00
|
|
|
|
xa recover;
|
|
|
|
|
|
|
|
|
|
# uncomment the line below when binlog will be able to prepare
|
|
|
|
|
#disconnect con1;
|
|
|
|
|
connection default;
|
|
|
|
|
|
|
|
|
|
xa prepare 'testa','testb';
|
|
|
|
|
|
|
|
|
|
xa recover;
|
|
|
|
|
|
2020-03-02 16:12:35 +01:00
|
|
|
|
--error ER_XAER_OUTSIDE
|
2005-04-04 00:50:05 +02:00
|
|
|
|
xa commit 'testb',0x2030405060,11;
|
|
|
|
|
xa rollback 'testa','testb';
|
|
|
|
|
|
2009-03-03 21:34:18 +01:00
|
|
|
|
--error ER_PARSE_ERROR
|
2005-04-04 00:50:05 +02:00
|
|
|
|
xa start 'zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz';
|
|
|
|
|
|
|
|
|
|
select * from t1;
|
2008-10-21 20:07:31 +02:00
|
|
|
|
disconnect con1;
|
2017-12-18 09:24:02 +01:00
|
|
|
|
--source include/wait_until_count_sessions.inc
|
MDEV-742 XA PREPAREd transaction survive disconnect/server restart
Lifted long standing limitation to the XA of rolling it back at the
transaction's
connection close even if the XA is prepared.
Prepared XA-transaction is made to sustain connection close or server
restart.
The patch consists of
- binary logging extension to write prepared XA part of
transaction signified with
its XID in a new XA_prepare_log_event. The concusion part -
with Commit or Rollback decision - is logged separately as
Query_log_event.
That is in the binlog the XA consists of two separate group of
events.
That makes the whole XA possibly interweaving in binlog with
other XA:s or regular transaction but with no harm to
replication and data consistency.
Gtid_log_event receives two more flags to identify which of the
two XA phases of the transaction it represents. With either flag
set also XID info is added to the event.
When binlog is ON on the server XID::formatID is
constrained to 4 bytes.
- engines are made aware of the server policy to keep up user
prepared XA:s so they (Innodb, rocksdb) don't roll them back
anymore at their disconnect methods.
- slave applier is refined to cope with two phase logged XA:s
including parallel modes of execution.
This patch does not address crash-safe logging of the new events which
is being addressed by MDEV-21469.
CORNER CASES: read-only, pure myisam, binlog-*, @@skip_log_bin, etc
Are addressed along the following policies.
1. The read-only at reconnect marks XID to fail for future
completion with ER_XA_RBROLLBACK.
2. binlog-* filtered XA when it changes engine data is regarded as
loggable even when nothing got cached for binlog. An empty
XA-prepare group is recorded. Consequent Commit-or-Rollback
succeeds in the Engine(s) as well as recorded into binlog.
3. The same applies to the non-transactional engine XA.
4. @@skip_log_bin=OFF does not record anything at XA-prepare
(obviously), but the completion event is recorded into binlog to
admit inconsistency with slave.
The following actions are taken by the patch.
At XA-prepare:
when empty binlog cache - don't do anything to binlog if RO,
otherwise write empty XA_prepare (assert(binlog-filter case)).
At Disconnect:
when Prepared && RO (=> no binlogging was done)
set Xid_cache_element::error := ER_XA_RBROLLBACK
*keep* XID in the cache, and rollback the transaction.
At XA-"complete":
Discover the error, if any don't binlog the "complete",
return the error to the user.
Kudos
-----
Alexey Botchkov took to drive this work initially.
Sergei Golubchik, Sergei Petrunja, Marko Mäkelä provided a number of
good recommendations.
Sergei Voitovich made a magnificent review and improvements to the code.
They all deserve a bunch of thanks for making this work done!
2019-03-30 22:47:28 +01:00
|
|
|
|
xa rollback 'testb',0x2030405060,11;
|
|
|
|
|
xa recover;
|
2017-12-18 09:24:02 +01:00
|
|
|
|
|
Backport of revno ## 2617.31.1, 2617.31.3, 2617.31.4, 2617.31.5,
2617.31.12, 2617.31.15, 2617.31.15, 2617.31.16, 2617.43.1
- initial changeset that introduced the fix for
Bug#989 and follow up fixes for all test suite failures
introduced in the initial changeset.
------------------------------------------------------------
revno: 2617.31.1
committer: Davi Arnaut <Davi.Arnaut@Sun.COM>
branch nick: 4284-6.0
timestamp: Fri 2009-03-06 19:17:00 -0300
message:
Bug#989: If DROP TABLE while there's an active transaction, wrong binlog order
WL#4284: Transactional DDL locking
Currently the MySQL server does not keep metadata locks on
schema objects for the duration of a transaction, thus failing
to guarantee the integrity of the schema objects being used
during the transaction and to protect then from concurrent
DDL operations. This also poses a problem for replication as
a DDL operation might be replicated even thought there are
active transactions using the object being modified.
The solution is to defer the release of metadata locks until
a active transaction is either committed or rolled back. This
prevents other statements from modifying the table for the
entire duration of the transaction. This provides commitment
ordering for guaranteeing serializability across multiple
transactions.
- Incompatible change:
If MySQL's metadata locking system encounters a lock conflict,
the usual schema is to use the try and back-off technique to
avoid deadlocks -- this schema consists in releasing all locks
and trying to acquire them all in one go.
But in a transactional context this algorithm can't be utilized
as its not possible to release locks acquired during the course
of the transaction without breaking the transaction commitments.
To avoid deadlocks in this case, the ER_LOCK_DEADLOCK will be
returned if a lock conflict is encountered during a transaction.
Let's consider an example:
A transaction has two statements that modify table t1, then table
t2, and then commits. The first statement of the transaction will
acquire a shared metadata lock on table t1, and it will be kept
utill COMMIT to ensure serializability.
At the moment when the second statement attempts to acquire a
shared metadata lock on t2, a concurrent ALTER or DROP statement
might have locked t2 exclusively. The prescription of the current
locking protocol is that the acquirer of the shared lock backs off
-- gives up all his current locks and retries. This implies that
the entire multi-statement transaction has to be rolled back.
- Incompatible change:
FLUSH commands such as FLUSH PRIVILEGES and FLUSH TABLES WITH READ
LOCK won't cause locked tables to be implicitly unlocked anymore.
mysql-test/extra/binlog_tests/drop_table.test:
Add test case for Bug#989.
mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction.
mysql-test/include/mix1.inc:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction.
mysql-test/include/mix2.inc:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction.
mysql-test/r/flush_block_commit.result:
Update test case result (WL#4284).
mysql-test/r/flush_block_commit_notembedded.result:
Update test case result (WL#4284).
mysql-test/r/innodb.result:
Update test case result (WL#4284).
mysql-test/r/innodb_mysql.result:
Update test case result (WL#4284).
mysql-test/r/lock.result:
Add test case result for an effect of WL#4284/Bug#989
(all locks should be released when a connection terminates).
mysql-test/r/mix2_myisam.result:
Update test case result (effects of WL#4284/Bug#989).
mysql-test/r/not_embedded_server.result:
Update test case result (effects of WL#4284/Bug#989).
Add a test case for interaction of WL#4284 and FLUSH PRIVILEGES.
mysql-test/r/partition_innodb_semi_consistent.result:
Update test case result (effects of WL#4284/Bug#989).
mysql-test/r/partition_sync.result:
Temporarily disable the test case for Bug#43867,
which will be fixed by a subsequent backport.
mysql-test/r/ps.result:
Add a test case for effect of PREPARE on transactional
locks: we take a savepoint at beginning of PREAPRE
and release it at the end. Thus PREPARE does not
accumulate metadata locks (Bug#989/WL#4284).
mysql-test/r/read_only_innodb.result:
Update test case result (effects of WL#4284/Bug#989).
mysql-test/suite/binlog/r/binlog_row_drop_tbl.result:
Add a test case result (WL#4284/Bug#989).
mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result:
Update test case result (effects of WL#4284/Bug#989).
mysql-test/suite/binlog/r/binlog_stm_drop_tbl.result:
Add a test case result (WL#4284/Bug#989).
mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
Update test case result (effects of WL#4284/Bug#989).
mysql-test/suite/binlog/r/binlog_unsafe.result:
A side effect of Bug#989 -- slightly different table map ids.
mysql-test/suite/binlog/t/binlog_row_drop_tbl.test:
Add a test case for WL#4284/Bug#989.
mysql-test/suite/binlog/t/binlog_stm_drop_tbl.test:
Add a test case for WL#4284/Bug#989.
mysql-test/suite/binlog/t/binlog_stm_row.test:
Update to the new state name. This
is actually a follow up to another patch for WL#4284,
that changes Locked thread state to Table lock.
mysql-test/suite/ndb/r/ndb_index_ordered.result:
Remove result for disabled part of the test case.
mysql-test/suite/ndb/t/disabled.def:
Temporarily disable a test case (Bug#45621).
mysql-test/suite/ndb/t/ndb_index_ordered.test:
Disable a part of a test case (needs update to
reflect semantics of Bug#989).
mysql-test/suite/rpl/t/disabled.def:
Disable tests made meaningless by transactional metadata
locking.
mysql-test/suite/sys_vars/r/autocommit_func.result:
Add a commit (Bug#989).
mysql-test/suite/sys_vars/t/autocommit_func.test:
Add a commit (Bug#989).
mysql-test/t/flush_block_commit.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction.
mysql-test/t/flush_block_commit_notembedded.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction.
Add a test case for transaction-scope locks and the global
read lock (Bug#989/WL#4284).
mysql-test/t/innodb.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction
(effects of Bug#989/WL#4284).
mysql-test/t/lock.test:
Add a test case for Bug#989/WL#4284.
mysql-test/t/not_embedded_server.test:
Add a test case for Bug#989/WL#4284.
mysql-test/t/partition_innodb_semi_consistent.test:
Replace TRUNCATE with DELETE, to not issue
an implicit commit of a transaction, and not depend
on metadata locks.
mysql-test/t/partition_sync.test:
Temporarily disable the test case for Bug#43867,
which needs a fix to be backported from 6.0.
mysql-test/t/ps.test:
Add a test case for semantics of PREPARE and transaction-scope
locks: metadata locks on tables used in PREPARE are enclosed into a
temporary savepoint, taken at the beginning of PREPARE,
and released at the end. Thus PREPARE does not effect
what locks a transaction owns.
mysql-test/t/read_only_innodb.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction
(Bug#989/WL#4284).
Wait for the read_only statement to actually flush tables before
sending other concurrent statements that depend on its state.
mysql-test/t/xa.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction
(Bug#989/WL#4284).
sql/ha_ndbcluster_binlog.cc:
Backport bits of changes of ha_ndbcluster_binlog.cc
from 6.0, to fix the failing binlog test suite with
WL#4284. WL#4284 implementation does not work
with 5.1 implementation of ndbcluster binlog index.
sql/log_event.cc:
Release metadata locks after issuing a commit.
sql/mdl.cc:
Style changes (WL#4284).
sql/mysql_priv.h:
Rename parameter to match the name used in the definition (WL#4284).
sql/rpl_injector.cc:
Release metadata locks on commit (WL#4284).
sql/rpl_rli.cc:
Remove assert made meaningless, metadata locks are released
at the end of the transaction.
sql/set_var.cc:
Close tables and release locks if autocommit mode is set.
sql/slave.cc:
Release metadata locks after a rollback.
sql/sql_acl.cc:
Don't implicitly unlock locked tables. Issue a implicit commit
at the end and unlock tables.
sql/sql_base.cc:
Defer the release of metadata locks when closing tables
if not required to.
Issue a deadlock error if the locking protocol requires
that a transaction re-acquire its locks.
Release metadata locks when closing tables for reopen.
sql/sql_class.cc:
Release metadata locks if the thread is killed.
sql/sql_parse.cc:
Release metadata locks after implicitly committing a active
transaction, or after explicit commits or rollbacks.
sql/sql_plugin.cc:
Allocate MDL request on the stack as the use of the table
is contained within the function. It will be removed from
the context once close_thread_tables is called at the end
of the function.
sql/sql_prepare.cc:
The problem is that the prepare phase of the CREATE TABLE
statement takes a exclusive metadata lock lock and this can
cause a self-deadlock the thread already holds a shared lock
on the table being that should be created.
The solution is to make the prepare phase take a shared
metadata lock when preparing a CREATE TABLE statement. The
execution of the statement will still acquire a exclusive
lock, but won't cause any problem as it issues a implicit
commit.
After some discussions with stakeholders it has been decided that
metadata locks acquired during a PREPARE statement must be released
once the statement is prepared even if it is prepared within a multi
statement transaction.
sql/sql_servers.cc:
Don't implicitly unlock locked tables. Issue a implicit commit
at the end and unlock tables.
sql/sql_table.cc:
Close table and release metadata locks after a admin operation.
sql/table.h:
The problem is that the prepare phase of the CREATE TABLE
statement takes a exclusive metadata lock lock and this can
cause a self-deadlock the thread already holds a shared lock
on the table being that should be created.
The solution is to make the prepare phase take a shared
metadata lock when preparing a CREATE TABLE statement. The
execution of the statement will still acquire a exclusive
lock, but won't cause any problem as it issues a implicit
commit.
sql/transaction.cc:
Release metadata locks after the implicitly committed due
to a new transaction being started. Also, release metadata
locks acquired after a savepoint if the transaction is rolled
back to the save point.
The problem is that in some cases transaction-long metadata locks
could be released before the transaction was committed. This could
happen when a active transaction was ended by a "START TRANSACTION"
or "BEGIN" statement, in which case the metadata locks would be
released before the actual commit of the active transaction.
The solution is to defer the release of metadata locks to after the
transaction has been implicitly committed. No test case is provided
as the effort to provide one is too disproportional to the size of
the fix.
2009-12-05 00:02:48 +01:00
|
|
|
|
connection default;
|
2017-12-17 22:55:40 +01:00
|
|
|
|
|
|
|
|
|
# MDEV-14593 human-readable XA RECOVER
|
|
|
|
|
xa start 'tr1';
|
|
|
|
|
insert t1 values (40);
|
|
|
|
|
xa end 'tr1';
|
|
|
|
|
xa prepare 'tr1';
|
|
|
|
|
xa recover format='SQL';
|
|
|
|
|
xa rollback 'tr1';
|
|
|
|
|
|
|
|
|
|
xa start 'tr1', 'bq';
|
|
|
|
|
insert t1 values (40);
|
|
|
|
|
xa end 'tr1', 'bq';
|
|
|
|
|
xa prepare 'tr1', 'bq';
|
|
|
|
|
xa recover format='SQL';
|
|
|
|
|
xa rollback 'tr1', 'bq';
|
|
|
|
|
|
|
|
|
|
xa start 'tr1', 'bq', 3;
|
|
|
|
|
insert t1 values (40);
|
|
|
|
|
xa end 'tr1', 'bq', 3;
|
|
|
|
|
xa prepare 'tr1', 'bq', 3;
|
|
|
|
|
xa recover format='SQL';
|
|
|
|
|
xa rollback 'tr1', 'bq', 3;
|
|
|
|
|
|
|
|
|
|
xa start 'tr1#$';
|
|
|
|
|
insert t1 values (40);
|
|
|
|
|
xa end 'tr1#$';
|
|
|
|
|
xa prepare 'tr1#$';
|
|
|
|
|
xa recover format='SQL';
|
|
|
|
|
xa rollback 'tr1#$';
|
|
|
|
|
|
|
|
|
|
xa start 'tr1#$', 'bq';
|
|
|
|
|
insert t1 values (40);
|
|
|
|
|
xa end 'tr1#$', 'bq';
|
|
|
|
|
xa prepare 'tr1#$', 'bq';
|
|
|
|
|
xa recover format='SQL';
|
|
|
|
|
xa rollback 'tr1#$', 'bq';
|
|
|
|
|
|
|
|
|
|
xa start 'tr1#$', 'bq', 3;
|
|
|
|
|
insert t1 values (40);
|
|
|
|
|
xa end 'tr1#$', 'bq', 3;
|
|
|
|
|
xa prepare 'tr1#$', 'bq', 3;
|
|
|
|
|
xa recover format='RAW';
|
|
|
|
|
--error ER_UNKNOWN_EXPLAIN_FORMAT
|
|
|
|
|
xa recover format='PLAIN';
|
|
|
|
|
xa recover format='SQL';
|
|
|
|
|
xa rollback 'tr1#$', 'bq', 3;
|
|
|
|
|
|
Backport of revno ## 2617.31.1, 2617.31.3, 2617.31.4, 2617.31.5,
2617.31.12, 2617.31.15, 2617.31.15, 2617.31.16, 2617.43.1
- initial changeset that introduced the fix for
Bug#989 and follow up fixes for all test suite failures
introduced in the initial changeset.
------------------------------------------------------------
revno: 2617.31.1
committer: Davi Arnaut <Davi.Arnaut@Sun.COM>
branch nick: 4284-6.0
timestamp: Fri 2009-03-06 19:17:00 -0300
message:
Bug#989: If DROP TABLE while there's an active transaction, wrong binlog order
WL#4284: Transactional DDL locking
Currently the MySQL server does not keep metadata locks on
schema objects for the duration of a transaction, thus failing
to guarantee the integrity of the schema objects being used
during the transaction and to protect then from concurrent
DDL operations. This also poses a problem for replication as
a DDL operation might be replicated even thought there are
active transactions using the object being modified.
The solution is to defer the release of metadata locks until
a active transaction is either committed or rolled back. This
prevents other statements from modifying the table for the
entire duration of the transaction. This provides commitment
ordering for guaranteeing serializability across multiple
transactions.
- Incompatible change:
If MySQL's metadata locking system encounters a lock conflict,
the usual schema is to use the try and back-off technique to
avoid deadlocks -- this schema consists in releasing all locks
and trying to acquire them all in one go.
But in a transactional context this algorithm can't be utilized
as its not possible to release locks acquired during the course
of the transaction without breaking the transaction commitments.
To avoid deadlocks in this case, the ER_LOCK_DEADLOCK will be
returned if a lock conflict is encountered during a transaction.
Let's consider an example:
A transaction has two statements that modify table t1, then table
t2, and then commits. The first statement of the transaction will
acquire a shared metadata lock on table t1, and it will be kept
utill COMMIT to ensure serializability.
At the moment when the second statement attempts to acquire a
shared metadata lock on t2, a concurrent ALTER or DROP statement
might have locked t2 exclusively. The prescription of the current
locking protocol is that the acquirer of the shared lock backs off
-- gives up all his current locks and retries. This implies that
the entire multi-statement transaction has to be rolled back.
- Incompatible change:
FLUSH commands such as FLUSH PRIVILEGES and FLUSH TABLES WITH READ
LOCK won't cause locked tables to be implicitly unlocked anymore.
mysql-test/extra/binlog_tests/drop_table.test:
Add test case for Bug#989.
mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction.
mysql-test/include/mix1.inc:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction.
mysql-test/include/mix2.inc:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction.
mysql-test/r/flush_block_commit.result:
Update test case result (WL#4284).
mysql-test/r/flush_block_commit_notembedded.result:
Update test case result (WL#4284).
mysql-test/r/innodb.result:
Update test case result (WL#4284).
mysql-test/r/innodb_mysql.result:
Update test case result (WL#4284).
mysql-test/r/lock.result:
Add test case result for an effect of WL#4284/Bug#989
(all locks should be released when a connection terminates).
mysql-test/r/mix2_myisam.result:
Update test case result (effects of WL#4284/Bug#989).
mysql-test/r/not_embedded_server.result:
Update test case result (effects of WL#4284/Bug#989).
Add a test case for interaction of WL#4284 and FLUSH PRIVILEGES.
mysql-test/r/partition_innodb_semi_consistent.result:
Update test case result (effects of WL#4284/Bug#989).
mysql-test/r/partition_sync.result:
Temporarily disable the test case for Bug#43867,
which will be fixed by a subsequent backport.
mysql-test/r/ps.result:
Add a test case for effect of PREPARE on transactional
locks: we take a savepoint at beginning of PREAPRE
and release it at the end. Thus PREPARE does not
accumulate metadata locks (Bug#989/WL#4284).
mysql-test/r/read_only_innodb.result:
Update test case result (effects of WL#4284/Bug#989).
mysql-test/suite/binlog/r/binlog_row_drop_tbl.result:
Add a test case result (WL#4284/Bug#989).
mysql-test/suite/binlog/r/binlog_row_mix_innodb_myisam.result:
Update test case result (effects of WL#4284/Bug#989).
mysql-test/suite/binlog/r/binlog_stm_drop_tbl.result:
Add a test case result (WL#4284/Bug#989).
mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
Update test case result (effects of WL#4284/Bug#989).
mysql-test/suite/binlog/r/binlog_unsafe.result:
A side effect of Bug#989 -- slightly different table map ids.
mysql-test/suite/binlog/t/binlog_row_drop_tbl.test:
Add a test case for WL#4284/Bug#989.
mysql-test/suite/binlog/t/binlog_stm_drop_tbl.test:
Add a test case for WL#4284/Bug#989.
mysql-test/suite/binlog/t/binlog_stm_row.test:
Update to the new state name. This
is actually a follow up to another patch for WL#4284,
that changes Locked thread state to Table lock.
mysql-test/suite/ndb/r/ndb_index_ordered.result:
Remove result for disabled part of the test case.
mysql-test/suite/ndb/t/disabled.def:
Temporarily disable a test case (Bug#45621).
mysql-test/suite/ndb/t/ndb_index_ordered.test:
Disable a part of a test case (needs update to
reflect semantics of Bug#989).
mysql-test/suite/rpl/t/disabled.def:
Disable tests made meaningless by transactional metadata
locking.
mysql-test/suite/sys_vars/r/autocommit_func.result:
Add a commit (Bug#989).
mysql-test/suite/sys_vars/t/autocommit_func.test:
Add a commit (Bug#989).
mysql-test/t/flush_block_commit.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction.
mysql-test/t/flush_block_commit_notembedded.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction.
Add a test case for transaction-scope locks and the global
read lock (Bug#989/WL#4284).
mysql-test/t/innodb.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction
(effects of Bug#989/WL#4284).
mysql-test/t/lock.test:
Add a test case for Bug#989/WL#4284.
mysql-test/t/not_embedded_server.test:
Add a test case for Bug#989/WL#4284.
mysql-test/t/partition_innodb_semi_consistent.test:
Replace TRUNCATE with DELETE, to not issue
an implicit commit of a transaction, and not depend
on metadata locks.
mysql-test/t/partition_sync.test:
Temporarily disable the test case for Bug#43867,
which needs a fix to be backported from 6.0.
mysql-test/t/ps.test:
Add a test case for semantics of PREPARE and transaction-scope
locks: metadata locks on tables used in PREPARE are enclosed into a
temporary savepoint, taken at the beginning of PREPARE,
and released at the end. Thus PREPARE does not effect
what locks a transaction owns.
mysql-test/t/read_only_innodb.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction
(Bug#989/WL#4284).
Wait for the read_only statement to actually flush tables before
sending other concurrent statements that depend on its state.
mysql-test/t/xa.test:
Fix test case to reflect the fact that transactions now hold
metadata locks for the duration of a transaction
(Bug#989/WL#4284).
sql/ha_ndbcluster_binlog.cc:
Backport bits of changes of ha_ndbcluster_binlog.cc
from 6.0, to fix the failing binlog test suite with
WL#4284. WL#4284 implementation does not work
with 5.1 implementation of ndbcluster binlog index.
sql/log_event.cc:
Release metadata locks after issuing a commit.
sql/mdl.cc:
Style changes (WL#4284).
sql/mysql_priv.h:
Rename parameter to match the name used in the definition (WL#4284).
sql/rpl_injector.cc:
Release metadata locks on commit (WL#4284).
sql/rpl_rli.cc:
Remove assert made meaningless, metadata locks are released
at the end of the transaction.
sql/set_var.cc:
Close tables and release locks if autocommit mode is set.
sql/slave.cc:
Release metadata locks after a rollback.
sql/sql_acl.cc:
Don't implicitly unlock locked tables. Issue a implicit commit
at the end and unlock tables.
sql/sql_base.cc:
Defer the release of metadata locks when closing tables
if not required to.
Issue a deadlock error if the locking protocol requires
that a transaction re-acquire its locks.
Release metadata locks when closing tables for reopen.
sql/sql_class.cc:
Release metadata locks if the thread is killed.
sql/sql_parse.cc:
Release metadata locks after implicitly committing a active
transaction, or after explicit commits or rollbacks.
sql/sql_plugin.cc:
Allocate MDL request on the stack as the use of the table
is contained within the function. It will be removed from
the context once close_thread_tables is called at the end
of the function.
sql/sql_prepare.cc:
The problem is that the prepare phase of the CREATE TABLE
statement takes a exclusive metadata lock lock and this can
cause a self-deadlock the thread already holds a shared lock
on the table being that should be created.
The solution is to make the prepare phase take a shared
metadata lock when preparing a CREATE TABLE statement. The
execution of the statement will still acquire a exclusive
lock, but won't cause any problem as it issues a implicit
commit.
After some discussions with stakeholders it has been decided that
metadata locks acquired during a PREPARE statement must be released
once the statement is prepared even if it is prepared within a multi
statement transaction.
sql/sql_servers.cc:
Don't implicitly unlock locked tables. Issue a implicit commit
at the end and unlock tables.
sql/sql_table.cc:
Close table and release metadata locks after a admin operation.
sql/table.h:
The problem is that the prepare phase of the CREATE TABLE
statement takes a exclusive metadata lock lock and this can
cause a self-deadlock the thread already holds a shared lock
on the table being that should be created.
The solution is to make the prepare phase take a shared
metadata lock when preparing a CREATE TABLE statement. The
execution of the statement will still acquire a exclusive
lock, but won't cause any problem as it issues a implicit
commit.
sql/transaction.cc:
Release metadata locks after the implicitly committed due
to a new transaction being started. Also, release metadata
locks acquired after a savepoint if the transaction is rolled
back to the save point.
The problem is that in some cases transaction-long metadata locks
could be released before the transaction was committed. This could
happen when a active transaction was ended by a "START TRANSACTION"
or "BEGIN" statement, in which case the metadata locks would be
released before the actual commit of the active transaction.
The solution is to defer the release of metadata locks to after the
transaction has been implicitly committed. No test case is provided
as the effort to provide one is too disproportional to the size of
the fix.
2009-12-05 00:02:48 +01:00
|
|
|
|
drop table t1;
|
2008-10-21 20:07:31 +02:00
|
|
|
|
|
|
|
|
|
#
|
|
|
|
|
# Bug#28323: Server crashed in xid cache operations
|
|
|
|
|
#
|
|
|
|
|
|
|
|
|
|
--disable_warnings
|
|
|
|
|
drop table if exists t1;
|
|
|
|
|
--enable_warnings
|
|
|
|
|
|
|
|
|
|
create table t1(a int, b int, c varchar(20), primary key(a)) engine = innodb;
|
|
|
|
|
insert into t1 values(1, 1, 'a');
|
|
|
|
|
insert into t1 values(2, 2, 'b');
|
|
|
|
|
|
|
|
|
|
connect (con1,localhost,root,,);
|
|
|
|
|
connect (con2,localhost,root,,);
|
|
|
|
|
|
|
|
|
|
--connection con1
|
|
|
|
|
xa start 'a','b';
|
|
|
|
|
update t1 set c = 'aa' where a = 1;
|
|
|
|
|
--connection con2
|
|
|
|
|
xa start 'a','c';
|
|
|
|
|
update t1 set c = 'bb' where a = 2;
|
|
|
|
|
--connection con1
|
|
|
|
|
--send update t1 set c = 'bb' where a = 2
|
|
|
|
|
--connection con2
|
|
|
|
|
--sleep 1
|
|
|
|
|
--error ER_LOCK_DEADLOCK
|
|
|
|
|
update t1 set c = 'aa' where a = 1;
|
|
|
|
|
select count(*) from t1;
|
|
|
|
|
--error ER_XA_RBDEADLOCK
|
|
|
|
|
xa end 'a','c';
|
|
|
|
|
xa rollback 'a','c';
|
|
|
|
|
--disconnect con2
|
|
|
|
|
|
|
|
|
|
connect (con3,localhost,root,,);
|
|
|
|
|
--connection con3
|
|
|
|
|
xa start 'a','c';
|
|
|
|
|
|
|
|
|
|
--disconnect con1
|
|
|
|
|
--disconnect con3
|
|
|
|
|
--connection default
|
2008-10-21 23:02:26 +02:00
|
|
|
|
drop table t1;
|
2008-10-21 20:07:31 +02:00
|
|
|
|
|
2010-03-10 12:04:32 +01:00
|
|
|
|
--echo #
|
|
|
|
|
--echo # BUG#51342 - more xid crashing
|
|
|
|
|
--echo #
|
|
|
|
|
CREATE TABLE t1(a INT) ENGINE=InnoDB;
|
|
|
|
|
XA START 'x';
|
|
|
|
|
SET SESSION autocommit=0;
|
|
|
|
|
INSERT INTO t1 VALUES(1);
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
SET SESSION autocommit=1;
|
|
|
|
|
SELECT @@autocommit;
|
|
|
|
|
INSERT INTO t1 VALUES(1);
|
|
|
|
|
XA END 'x';
|
|
|
|
|
XA COMMIT 'x' ONE PHASE;
|
|
|
|
|
DROP TABLE t1;
|
2010-03-10 16:28:49 +01:00
|
|
|
|
SET SESSION autocommit=1;
|
2010-03-10 12:04:32 +01:00
|
|
|
|
|
2008-10-21 20:07:31 +02:00
|
|
|
|
--echo End of 5.0 tests
|
2009-03-03 21:34:18 +01:00
|
|
|
|
|
2009-06-06 00:16:54 +02:00
|
|
|
|
#
|
|
|
|
|
# Bug#44672: Assertion failed: thd->transaction.xid_state.xid.is_null()
|
|
|
|
|
#
|
|
|
|
|
|
|
|
|
|
xa start 'a';
|
|
|
|
|
xa end 'a';
|
|
|
|
|
xa rollback 'a';
|
|
|
|
|
xa start 'a';
|
|
|
|
|
xa end 'a';
|
|
|
|
|
xa rollback 'a';
|
|
|
|
|
|
2009-06-25 17:25:23 +02:00
|
|
|
|
#
|
|
|
|
|
# Bug#45548: XA transaction without access to InnoDB tables crashes the server
|
|
|
|
|
#
|
|
|
|
|
|
|
|
|
|
xa start 'a';
|
|
|
|
|
xa end 'a';
|
|
|
|
|
xa prepare 'a';
|
|
|
|
|
xa commit 'a';
|
|
|
|
|
|
|
|
|
|
xa start 'a';
|
|
|
|
|
xa end 'a';
|
|
|
|
|
xa prepare 'a';
|
|
|
|
|
xa commit 'a';
|
|
|
|
|
|
2009-10-28 16:39:08 +01:00
|
|
|
|
#
|
|
|
|
|
# BUG#43171 - Assertion failed: thd->transaction.xid_state.xid.is_null()
|
|
|
|
|
#
|
|
|
|
|
CREATE TABLE t1(a INT, KEY(a)) ENGINE=InnoDB;
|
|
|
|
|
INSERT INTO t1 VALUES(1),(2);
|
|
|
|
|
connect(con1,localhost,root,,);
|
|
|
|
|
|
|
|
|
|
# Part 1: Prepare to test XA START after regular transaction deadlock
|
|
|
|
|
BEGIN;
|
|
|
|
|
UPDATE t1 SET a=3 WHERE a=1;
|
|
|
|
|
|
|
|
|
|
connection default;
|
|
|
|
|
BEGIN;
|
|
|
|
|
UPDATE t1 SET a=4 WHERE a=2;
|
|
|
|
|
|
|
|
|
|
connection con1;
|
|
|
|
|
let $conn_id= `SELECT CONNECTION_ID()`;
|
|
|
|
|
SEND UPDATE t1 SET a=5 WHERE a=2;
|
|
|
|
|
|
|
|
|
|
connection default;
|
|
|
|
|
let $wait_timeout= 2;
|
|
|
|
|
let $wait_condition= SELECT 1 FROM INFORMATION_SCHEMA.PROCESSLIST
|
|
|
|
|
WHERE ID=$conn_id AND STATE='Searching rows for update';
|
|
|
|
|
--source include/wait_condition.inc
|
|
|
|
|
|
|
|
|
|
--error ER_LOCK_DEADLOCK
|
|
|
|
|
UPDATE t1 SET a=5 WHERE a=1;
|
|
|
|
|
ROLLBACK;
|
|
|
|
|
|
|
|
|
|
# Part 2: Prepare to test XA START after XA transaction deadlock
|
|
|
|
|
connection con1;
|
|
|
|
|
REAP;
|
|
|
|
|
ROLLBACK;
|
|
|
|
|
BEGIN;
|
|
|
|
|
UPDATE t1 SET a=3 WHERE a=1;
|
|
|
|
|
|
|
|
|
|
connection default;
|
|
|
|
|
XA START 'xid1';
|
|
|
|
|
UPDATE t1 SET a=4 WHERE a=2;
|
|
|
|
|
|
|
|
|
|
connection con1;
|
|
|
|
|
SEND UPDATE t1 SET a=5 WHERE a=2;
|
|
|
|
|
|
|
|
|
|
connection default;
|
|
|
|
|
let $wait_timeout= 2;
|
|
|
|
|
let $wait_condition= SELECT 1 FROM INFORMATION_SCHEMA.PROCESSLIST
|
|
|
|
|
WHERE ID=$conn_id AND STATE='Searching rows for update';
|
|
|
|
|
--source include/wait_condition.inc
|
|
|
|
|
|
|
|
|
|
--error ER_LOCK_DEADLOCK
|
|
|
|
|
UPDATE t1 SET a=5 WHERE a=1;
|
|
|
|
|
--error ER_XA_RBDEADLOCK
|
|
|
|
|
XA END 'xid1';
|
|
|
|
|
XA ROLLBACK 'xid1';
|
|
|
|
|
|
|
|
|
|
XA START 'xid1';
|
|
|
|
|
XA END 'xid1';
|
|
|
|
|
XA ROLLBACK 'xid1';
|
|
|
|
|
|
|
|
|
|
disconnect con1;
|
|
|
|
|
DROP TABLE t1;
|
|
|
|
|
|
2010-09-13 13:31:22 +02:00
|
|
|
|
|
|
|
|
|
--echo #
|
|
|
|
|
--echo # Bug#56448 Assertion failed: ! is_set() with second xa end
|
|
|
|
|
--echo #
|
|
|
|
|
|
|
|
|
|
XA START 'x';
|
|
|
|
|
XA END 'x';
|
|
|
|
|
# Second XA END caused an assertion.
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
XA END 'x';
|
|
|
|
|
XA PREPARE 'x';
|
|
|
|
|
# Second XA PREPARE also caused an assertion.
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
XA PREPARE 'x';
|
|
|
|
|
XA ROLLBACK 'x';
|
|
|
|
|
|
|
|
|
|
|
2011-02-14 14:16:31 +01:00
|
|
|
|
--echo #
|
|
|
|
|
--echo # Bug#59986 Assert in Diagnostics_area::set_ok_status() for XA COMMIT
|
|
|
|
|
--echo #
|
|
|
|
|
|
|
|
|
|
--disable_warnings
|
|
|
|
|
DROP TABLE IF EXISTS t1;
|
|
|
|
|
--enable_warnings
|
|
|
|
|
|
|
|
|
|
CREATE TABLE t1(a INT, b INT, PRIMARY KEY(a)) engine=InnoDB;
|
|
|
|
|
INSERT INTO t1 VALUES (1, 1), (2, 2);
|
|
|
|
|
|
|
|
|
|
connect (con1, localhost, root);
|
|
|
|
|
XA START 'a';
|
|
|
|
|
UPDATE t1 SET b= 3 WHERE a=1;
|
|
|
|
|
|
|
|
|
|
connection default;
|
|
|
|
|
XA START 'b';
|
|
|
|
|
UPDATE t1 SET b=4 WHERE a=2;
|
|
|
|
|
--echo # Sending:
|
|
|
|
|
--send UPDATE t1 SET b=5 WHERE a=1
|
|
|
|
|
|
|
|
|
|
connection con1;
|
|
|
|
|
--sleep 1
|
|
|
|
|
--error ER_LOCK_DEADLOCK
|
|
|
|
|
UPDATE t1 SET b=6 WHERE a=2;
|
|
|
|
|
# This used to trigger the assert
|
|
|
|
|
--error ER_XA_RBDEADLOCK
|
|
|
|
|
XA COMMIT 'a';
|
|
|
|
|
|
|
|
|
|
connection default;
|
|
|
|
|
--echo # Reaping: UPDATE t1 SET b=5 WHERE a=1
|
|
|
|
|
--reap
|
|
|
|
|
XA END 'b';
|
|
|
|
|
XA ROLLBACK 'b';
|
|
|
|
|
DROP TABLE t1;
|
|
|
|
|
disconnect con1;
|
|
|
|
|
|
|
|
|
|
|
2011-04-12 12:57:02 +02:00
|
|
|
|
--echo #
|
|
|
|
|
--echo # Bug#11766752 59936: multiple xa assertions - transactional
|
|
|
|
|
--echo # statement fuzzer
|
|
|
|
|
--echo #
|
|
|
|
|
|
|
|
|
|
CREATE TABLE t1 (a INT) engine=InnoDB;
|
|
|
|
|
XA START 'a';
|
|
|
|
|
INSERT INTO t1 VALUES (1);
|
|
|
|
|
|
|
|
|
|
SAVEPOINT savep;
|
|
|
|
|
|
|
|
|
|
XA END 'a';
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
INSERT INTO t1 VALUES (2);
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
SAVEPOINT savep;
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
SET @a=(SELECT * FROM t1);
|
|
|
|
|
|
|
|
|
|
XA PREPARE 'a';
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
SELECT * FROM t1; # used to cause InnoDB assert
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
INSERT INTO t1 VALUES (2); # used to cause InnoDB assert
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
SAVEPOINT savep;
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
SET @a=(SELECT * FROM t1); # used to cause InnoDB assert
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
UPDATE t1 SET a=1 WHERE a=2;
|
|
|
|
|
|
|
|
|
|
XA COMMIT 'a';
|
|
|
|
|
SELECT * FROM t1;
|
|
|
|
|
DROP TABLE t1;
|
|
|
|
|
|
|
|
|
|
|
2018-01-15 10:50:28 +01:00
|
|
|
|
--echo #
|
|
|
|
|
--echo # MDEV-14609 XA Transction unable to ROLLBACK TO SAVEPOINT
|
|
|
|
|
--echo #
|
|
|
|
|
|
|
|
|
|
CREATE TABLE t1 (c1 INT) ENGINE=INNODB;
|
|
|
|
|
XA START 'xa1';
|
|
|
|
|
SAVEPOINT savepoint1;
|
|
|
|
|
INSERT INTO t1 (c1) VALUES (1),(2),(3),(4);
|
|
|
|
|
ROLLBACK TO SAVEPOINT savepoint1;
|
|
|
|
|
XA END 'xa1';
|
|
|
|
|
XA ROLLBACK 'xa1';
|
|
|
|
|
DROP TABLE t1;
|
|
|
|
|
|
|
|
|
|
|
2011-04-14 10:13:28 +02:00
|
|
|
|
--echo #
|
|
|
|
|
--echo # Bug#12352846 - TRANS_XA_START(THD*):
|
|
|
|
|
--echo # ASSERTION THD->TRANSACTION.XID_STATE.XID.IS_NULL()
|
2020-11-30 14:29:32 +01:00
|
|
|
|
--echo # FAILED
|
2011-04-14 10:13:28 +02:00
|
|
|
|
--echo #
|
|
|
|
|
|
2012-01-20 11:03:39 +01:00
|
|
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
|
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
2011-04-14 10:13:28 +02:00
|
|
|
|
|
2018-07-03 14:10:06 +02:00
|
|
|
|
INSERT INTO t2 VALUES (1); COMMIT;
|
|
|
|
|
BEGIN;
|
|
|
|
|
INSERT INTO t2 VALUES (2);
|
2021-02-04 15:38:07 +01:00
|
|
|
|
UPDATE t2 SET a=a+2;
|
|
|
|
|
UPDATE t2 SET a=a-1;
|
2011-04-14 10:13:28 +02:00
|
|
|
|
|
|
|
|
|
--connect (con2,localhost,root)
|
|
|
|
|
XA START 'xid1';
|
2018-07-03 14:10:06 +02:00
|
|
|
|
INSERT INTO t1 VALUES (1);
|
2011-04-14 10:13:28 +02:00
|
|
|
|
--echo # Sending:
|
2018-07-03 14:10:06 +02:00
|
|
|
|
--send DELETE FROM t2
|
2011-04-14 10:13:28 +02:00
|
|
|
|
|
|
|
|
|
--connection default
|
|
|
|
|
let $wait_condition=
|
|
|
|
|
SELECT COUNT(*) = 1 FROM information_schema.processlist
|
2018-07-03 14:10:06 +02:00
|
|
|
|
WHERE state = "Updating"
|
|
|
|
|
AND info = "DELETE FROM t2";
|
2011-04-14 10:13:28 +02:00
|
|
|
|
--source include/wait_condition.inc
|
2011-12-19 13:28:30 +01:00
|
|
|
|
--sleep 0.1
|
2018-07-03 14:10:06 +02:00
|
|
|
|
--send DELETE FROM t1
|
2011-04-14 10:13:28 +02:00
|
|
|
|
|
|
|
|
|
--connection con2
|
|
|
|
|
--error ER_LOCK_DEADLOCK
|
|
|
|
|
--reap
|
|
|
|
|
--error ER_XA_RBDEADLOCK
|
|
|
|
|
XA COMMIT 'xid1';
|
2012-01-20 11:03:39 +01:00
|
|
|
|
|
|
|
|
|
connection default;
|
|
|
|
|
|
2018-07-03 14:10:06 +02:00
|
|
|
|
reap;
|
2012-01-20 11:03:39 +01:00
|
|
|
|
COMMIT;
|
|
|
|
|
|
|
|
|
|
connection con2;
|
2011-04-14 10:13:28 +02:00
|
|
|
|
# This caused the assert to be triggered
|
|
|
|
|
XA START 'xid1';
|
|
|
|
|
|
|
|
|
|
XA END 'xid1';
|
|
|
|
|
XA PREPARE 'xid1';
|
|
|
|
|
XA ROLLBACK 'xid1';
|
|
|
|
|
|
|
|
|
|
connection default;
|
|
|
|
|
DROP TABLE t1, t2;
|
|
|
|
|
disconnect con2;
|
|
|
|
|
|
|
|
|
|
|
2018-03-12 05:30:08 +01:00
|
|
|
|
#
|
|
|
|
|
# MDEV 15217 Assertion `thd->transaction.xid_state.xid.is_null()' failed in trans_xa_start.
|
|
|
|
|
#
|
|
|
|
|
CREATE TABLE t1 (pk INT PRIMARY KEY) ENGINE=InnoDB;
|
|
|
|
|
CREATE TABLE t2 (pk INT PRIMARY KEY) ENGINE=InnoDB;
|
|
|
|
|
INSERT INTO t2 VALUES (1),(2);
|
|
|
|
|
CREATE TABLE t3 (i INT) ENGINE=InnoDB;
|
2020-11-30 14:29:32 +01:00
|
|
|
|
|
2018-03-12 05:30:08 +01:00
|
|
|
|
XA BEGIN 'xid1';
|
|
|
|
|
REPLACE INTO t1 SELECT * FROM t2;
|
|
|
|
|
|
|
|
|
|
--connect (con1,localhost,root,,test)
|
|
|
|
|
XA BEGIN 'xid2';
|
|
|
|
|
--send
|
|
|
|
|
INSERT INTO t1 SELECT * FROM t2;
|
|
|
|
|
|
|
|
|
|
--connection default
|
|
|
|
|
REPLACE INTO t2 SELECT * FROM t2;
|
|
|
|
|
|
|
|
|
|
--connection con1
|
2018-03-12 20:43:42 +01:00
|
|
|
|
--error 0, ER_LOCK_DEADLOCK, ER_LOCK_WAIT_TIMEOUT
|
2018-03-12 05:30:08 +01:00
|
|
|
|
--reap
|
|
|
|
|
--disconnect con1
|
|
|
|
|
|
|
|
|
|
--connect (con2,localhost,root,,test)
|
|
|
|
|
INSERT INTO t3 VALUES (1);
|
|
|
|
|
XA BEGIN 'xid3';
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
#Cleanup
|
|
|
|
|
--disconnect con2
|
|
|
|
|
--connection default
|
|
|
|
|
XA END 'xid1';
|
|
|
|
|
XA ROLLBACK 'xid1';
|
|
|
|
|
DROP TABLE t1, t2, t3;
|
|
|
|
|
|
2020-11-30 14:29:32 +01:00
|
|
|
|
--echo #
|
|
|
|
|
--echo # MDEV 15532 XA: Assertion `!log->same_pk' failed in
|
|
|
|
|
--echo # row_log_table_apply_delete
|
|
|
|
|
--echo #
|
|
|
|
|
|
|
|
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
|
|
|
INSERT INTO t1 VALUES (1),(2);
|
|
|
|
|
|
|
|
|
|
--connect (con1,localhost,root,,test)
|
|
|
|
|
|
|
|
|
|
XA START 'xid';
|
|
|
|
|
UPDATE t1 SET a = 5;
|
|
|
|
|
|
|
|
|
|
--connection default
|
|
|
|
|
SET innodb_lock_wait_timeout= 2, lock_wait_timeout= 2;
|
|
|
|
|
|
|
|
|
|
--error ER_NO_SUCH_TABLE
|
|
|
|
|
ALTER TABLE non_existing_table1;
|
|
|
|
|
|
|
|
|
|
--send ALTER TABLE t1 FORCE;
|
2009-03-03 21:34:18 +01:00
|
|
|
|
|
2020-11-30 14:29:32 +01:00
|
|
|
|
--connection con1
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
|
|
|
|
|
ALTER TABLE non_existing_table2;
|
|
|
|
|
DELETE FROM t1 LIMIT 1;
|
|
|
|
|
|
|
|
|
|
--connection default
|
|
|
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
|
|
|
--reap
|
|
|
|
|
|
|
|
|
|
# Cleanup
|
|
|
|
|
--connection con1
|
|
|
|
|
XA END 'xid';
|
|
|
|
|
XA ROLLBACK 'xid';
|
|
|
|
|
DROP TABLE t1;
|
|
|
|
|
--disconnect con1
|
|
|
|
|
connection default;
|
2009-03-03 21:34:18 +01:00
|
|
|
|
|
2020-02-28 16:08:35 +01:00
|
|
|
|
--echo #
|
|
|
|
|
--echo # MDEV-21766 - Forbid XID with empty 'gtrid'
|
|
|
|
|
--echo #
|
|
|
|
|
CREATE TABLE t1(a INT) ENGINE=InnoDB;
|
|
|
|
|
|
|
|
|
|
--error ER_XAER_INVAL
|
|
|
|
|
XA BEGIN '';
|
|
|
|
|
|
|
|
|
|
XA BEGIN '8bytes1x8bytes2x8bytes3x8bytes4x8bytes5x8bytes6x8bytes7x8bytes8x',
|
|
|
|
|
'8bytes1x8bytes2x8bytes3x8bytes4x8bytes5x8bytes6x8bytes7x8bytes8x';
|
|
|
|
|
INSERT INTO t1 VALUES(1);
|
|
|
|
|
XA END '8bytes1x8bytes2x8bytes3x8bytes4x8bytes5x8bytes6x8bytes7x8bytes8x',
|
|
|
|
|
'8bytes1x8bytes2x8bytes3x8bytes4x8bytes5x8bytes6x8bytes7x8bytes8x';
|
|
|
|
|
XA PREPARE '8bytes1x8bytes2x8bytes3x8bytes4x8bytes5x8bytes6x8bytes7x8bytes8x',
|
|
|
|
|
'8bytes1x8bytes2x8bytes3x8bytes4x8bytes5x8bytes6x8bytes7x8bytes8x';
|
|
|
|
|
XA ROLLBACK '8bytes1x8bytes2x8bytes3x8bytes4x8bytes5x8bytes6x8bytes7x8bytes8x',
|
|
|
|
|
'8bytes1x8bytes2x8bytes3x8bytes4x8bytes5x8bytes6x8bytes7x8bytes8x';
|
|
|
|
|
|
|
|
|
|
SET NAMES utf8;
|
|
|
|
|
--error ER_PARSE_ERROR
|
|
|
|
|
XA BEGIN 'Я_упала_с_сеновала_тормозила_головой'; # 36 characters, 67 bytes
|
|
|
|
|
XA BEGIN 'Я_упaлa_c_сеновала_тормозила_головой'; # 36 characters, 64 bytes
|
|
|
|
|
XA END 'Я_упaлa_c_сеновала_тормозила_головой';
|
|
|
|
|
XA PREPARE 'Я_упaлa_c_сеновала_тормозила_головой';
|
|
|
|
|
XA ROLLBACK 'Я_упaлa_c_сеновала_тормозила_головой';
|
|
|
|
|
SET NAMES default;
|
|
|
|
|
|
|
|
|
|
DROP TABLE t1;
|
2020-03-02 16:12:35 +01:00
|
|
|
|
--echo #
|
|
|
|
|
--echo # MDEV-21659 XA rollback foreign_xid is allowed inside active XA
|
|
|
|
|
--echo # MDEV-21854 - xa commit one phase for already prepared transaction
|
|
|
|
|
--echo # must always error out
|
|
|
|
|
--echo #
|
|
|
|
|
BEGIN;
|
|
|
|
|
--error ER_XAER_OUTSIDE
|
|
|
|
|
XA COMMIT 'unknown';
|
|
|
|
|
--error ER_XAER_OUTSIDE
|
|
|
|
|
XA COMMIT 'unknown' ONE PHASE;
|
|
|
|
|
BEGIN;
|
|
|
|
|
--error ER_XAER_OUTSIDE
|
|
|
|
|
XA ROLLBACK 'unknown';
|
|
|
|
|
ROLLBACK;
|
|
|
|
|
|
|
|
|
|
XA START 'xid1';
|
|
|
|
|
--error ER_XAER_OUTSIDE
|
|
|
|
|
XA COMMIT 'unknown';
|
|
|
|
|
--error ER_XAER_OUTSIDE
|
|
|
|
|
XA COMMIT 'unknown' ONE PHASE;
|
|
|
|
|
--error ER_XAER_OUTSIDE
|
|
|
|
|
XA ROLLBACK 'unknown';
|
|
|
|
|
XA END 'xid1';
|
|
|
|
|
XA PREPARE 'xid1';
|
|
|
|
|
--error ER_XAER_INVAL
|
|
|
|
|
XA COMMIT 'xid1' ONE PHASE;
|
|
|
|
|
XA ROLLBACK 'xid1';
|
2020-02-28 16:08:35 +01:00
|
|
|
|
|
2020-03-09 15:31:18 +01:00
|
|
|
|
|
|
|
|
|
--echo #
|
|
|
|
|
--echo # MDEV-21856 - xid_t::formatID has to be constrained to 4 byte size
|
|
|
|
|
--echo #
|
|
|
|
|
--error ER_PARSE_ERROR
|
|
|
|
|
XA START 'gtrid', 'bqual', 0x80000000;
|
|
|
|
|
|
2020-02-28 16:08:35 +01:00
|
|
|
|
--source include/wait_until_count_sessions.inc
|
MDEV-742 XA PREPAREd transaction survive disconnect/server restart
Lifted long standing limitation to the XA of rolling it back at the
transaction's
connection close even if the XA is prepared.
Prepared XA-transaction is made to sustain connection close or server
restart.
The patch consists of
- binary logging extension to write prepared XA part of
transaction signified with
its XID in a new XA_prepare_log_event. The concusion part -
with Commit or Rollback decision - is logged separately as
Query_log_event.
That is in the binlog the XA consists of two separate group of
events.
That makes the whole XA possibly interweaving in binlog with
other XA:s or regular transaction but with no harm to
replication and data consistency.
Gtid_log_event receives two more flags to identify which of the
two XA phases of the transaction it represents. With either flag
set also XID info is added to the event.
When binlog is ON on the server XID::formatID is
constrained to 4 bytes.
- engines are made aware of the server policy to keep up user
prepared XA:s so they (Innodb, rocksdb) don't roll them back
anymore at their disconnect methods.
- slave applier is refined to cope with two phase logged XA:s
including parallel modes of execution.
This patch does not address crash-safe logging of the new events which
is being addressed by MDEV-21469.
CORNER CASES: read-only, pure myisam, binlog-*, @@skip_log_bin, etc
Are addressed along the following policies.
1. The read-only at reconnect marks XID to fail for future
completion with ER_XA_RBROLLBACK.
2. binlog-* filtered XA when it changes engine data is regarded as
loggable even when nothing got cached for binlog. An empty
XA-prepare group is recorded. Consequent Commit-or-Rollback
succeeds in the Engine(s) as well as recorded into binlog.
3. The same applies to the non-transactional engine XA.
4. @@skip_log_bin=OFF does not record anything at XA-prepare
(obviously), but the completion event is recorded into binlog to
admit inconsistency with slave.
The following actions are taken by the patch.
At XA-prepare:
when empty binlog cache - don't do anything to binlog if RO,
otherwise write empty XA_prepare (assert(binlog-filter case)).
At Disconnect:
when Prepared && RO (=> no binlogging was done)
set Xid_cache_element::error := ER_XA_RBROLLBACK
*keep* XID in the cache, and rollback the transaction.
At XA-"complete":
Discover the error, if any don't binlog the "complete",
return the error to the user.
Kudos
-----
Alexey Botchkov took to drive this work initially.
Sergei Golubchik, Sergei Petrunja, Marko Mäkelä provided a number of
good recommendations.
Sergei Voitovich made a magnificent review and improvements to the code.
They all deserve a bunch of thanks for making this work done!
2019-03-30 22:47:28 +01:00
|
|
|
|
|
2021-05-03 18:10:13 +02:00
|
|
|
|
--echo #
|
|
|
|
|
--echo # XA states and SHOW commands
|
|
|
|
|
--echo #
|
|
|
|
|
create table t1 (pk int primary key) engine=innodb;
|
|
|
|
|
xa start 'foo';
|
|
|
|
|
insert t1 set pk=1;
|
|
|
|
|
xa end 'foo';
|
|
|
|
|
xa prepare 'foo';
|
|
|
|
|
show status like 'foo';
|
|
|
|
|
--query_vertical select table_name,table_comment from information_schema.tables where table_schema='test'
|
|
|
|
|
--query_vertical select table_name,table_rows,table_comment from information_schema.tables where table_schema='test'
|
|
|
|
|
xa commit 'foo';
|
|
|
|
|
drop table t1;
|
|
|
|
|
|
2021-10-07 16:02:26 +02:00
|
|
|
|
--echo #
|
|
|
|
|
--echo # MDEV-22445 Crash on HANDLER READ NEXT after XA PREPARE
|
|
|
|
|
--echo #
|
|
|
|
|
|
|
|
|
|
CREATE TABLE t (a INT KEY) ENGINE=InnoDB;
|
|
|
|
|
HANDLER t OPEN AS t;
|
|
|
|
|
XA START '0';
|
|
|
|
|
SELECT * FROM t;
|
|
|
|
|
XA END '0';
|
|
|
|
|
XA PREPARE '0';
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
HANDLER t READ NEXT;
|
|
|
|
|
|
|
|
|
|
--echo # Cleanup
|
|
|
|
|
XA COMMIT '0';
|
|
|
|
|
DROP TABLE t;
|
|
|
|
|
|
2021-05-03 18:10:13 +02:00
|
|
|
|
--echo #
|
|
|
|
|
--echo # End of 10.2 tests
|
|
|
|
|
--echo #
|
2021-05-10 08:09:50 +02:00
|
|
|
|
|
2020-05-22 14:42:11 +02:00
|
|
|
|
#
|
|
|
|
|
# MDEV-22002 Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())'
|
|
|
|
|
# failed upon CREATE TEMPORARY SEQUENCE under XA
|
|
|
|
|
#
|
|
|
|
|
|
|
|
|
|
XA BEGIN 'xid';
|
|
|
|
|
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
CREATE TEMPORARY SEQUENCE s;
|
|
|
|
|
|
|
|
|
|
XA END 'xid';
|
|
|
|
|
|
|
|
|
|
XA ROLLBACK 'xid';
|
|
|
|
|
|
|
|
|
|
XA BEGIN 'xid';
|
|
|
|
|
|
|
|
|
|
--error ER_XAER_RMFAIL
|
|
|
|
|
CREATE SEQUENCE s;
|
|
|
|
|
|
|
|
|
|
XA END 'xid';
|
|
|
|
|
|
|
|
|
|
XA ROLLBACK 'xid';
|
|
|
|
|
|
|
|
|
|
--echo #
|
|
|
|
|
--echo # End of 10.3 tests
|
|
|
|
|
--echo #
|
2020-05-31 09:28:59 +02:00
|
|
|
|
|
|
|
|
|
--echo #
|
|
|
|
|
--echo # Start of 10.5 tests
|
|
|
|
|
--echo #
|
|
|
|
|
|
MDEV-742 XA PREPAREd transaction survive disconnect/server restart
Lifted long standing limitation to the XA of rolling it back at the
transaction's
connection close even if the XA is prepared.
Prepared XA-transaction is made to sustain connection close or server
restart.
The patch consists of
- binary logging extension to write prepared XA part of
transaction signified with
its XID in a new XA_prepare_log_event. The concusion part -
with Commit or Rollback decision - is logged separately as
Query_log_event.
That is in the binlog the XA consists of two separate group of
events.
That makes the whole XA possibly interweaving in binlog with
other XA:s or regular transaction but with no harm to
replication and data consistency.
Gtid_log_event receives two more flags to identify which of the
two XA phases of the transaction it represents. With either flag
set also XID info is added to the event.
When binlog is ON on the server XID::formatID is
constrained to 4 bytes.
- engines are made aware of the server policy to keep up user
prepared XA:s so they (Innodb, rocksdb) don't roll them back
anymore at their disconnect methods.
- slave applier is refined to cope with two phase logged XA:s
including parallel modes of execution.
This patch does not address crash-safe logging of the new events which
is being addressed by MDEV-21469.
CORNER CASES: read-only, pure myisam, binlog-*, @@skip_log_bin, etc
Are addressed along the following policies.
1. The read-only at reconnect marks XID to fail for future
completion with ER_XA_RBROLLBACK.
2. binlog-* filtered XA when it changes engine data is regarded as
loggable even when nothing got cached for binlog. An empty
XA-prepare group is recorded. Consequent Commit-or-Rollback
succeeds in the Engine(s) as well as recorded into binlog.
3. The same applies to the non-transactional engine XA.
4. @@skip_log_bin=OFF does not record anything at XA-prepare
(obviously), but the completion event is recorded into binlog to
admit inconsistency with slave.
The following actions are taken by the patch.
At XA-prepare:
when empty binlog cache - don't do anything to binlog if RO,
otherwise write empty XA_prepare (assert(binlog-filter case)).
At Disconnect:
when Prepared && RO (=> no binlogging was done)
set Xid_cache_element::error := ER_XA_RBROLLBACK
*keep* XID in the cache, and rollback the transaction.
At XA-"complete":
Discover the error, if any don't binlog the "complete",
return the error to the user.
Kudos
-----
Alexey Botchkov took to drive this work initially.
Sergei Golubchik, Sergei Petrunja, Marko Mäkelä provided a number of
good recommendations.
Sergei Voitovich made a magnificent review and improvements to the code.
They all deserve a bunch of thanks for making this work done!
2019-03-30 22:47:28 +01:00
|
|
|
|
--echo # MDEV-7974 related
|
|
|
|
|
--echo # Check XA state when lock_wait_timeout happens
|
|
|
|
|
--echo # More tests added to flush_read_lock.test
|
|
|
|
|
connect (con_tmp,localhost,root,,);
|
|
|
|
|
set session lock_wait_timeout=1;
|
|
|
|
|
create table asd (a int) engine=innodb;
|
|
|
|
|
xa start 'test1';
|
|
|
|
|
insert into asd values(1);
|
|
|
|
|
xa end 'test1';
|
|
|
|
|
connection default;
|
|
|
|
|
flush table with read lock;
|
|
|
|
|
connection con_tmp;
|
|
|
|
|
--echo # PREPARE error will do auto rollback.
|
|
|
|
|
--ERROR ER_LOCK_WAIT_TIMEOUT
|
|
|
|
|
xa prepare 'test1';
|
|
|
|
|
show errors;
|
|
|
|
|
connection default;
|
|
|
|
|
unlock tables;
|
|
|
|
|
|
|
|
|
|
connection con_tmp;
|
|
|
|
|
xa start 'test1';
|
|
|
|
|
insert into asd values(1);
|
|
|
|
|
xa end 'test1';
|
|
|
|
|
xa prepare 'test1';
|
|
|
|
|
connection default;
|
|
|
|
|
flush tables with read lock;
|
|
|
|
|
connection con_tmp;
|
|
|
|
|
--echo # LOCK error during ROLLBACK will not alter transaction state.
|
|
|
|
|
--ERROR ER_LOCK_WAIT_TIMEOUT
|
|
|
|
|
xa rollback 'test1';
|
|
|
|
|
show errors;
|
|
|
|
|
xa recover;
|
|
|
|
|
--echo # LOCK error during COMMIT will not alter transaction state.
|
|
|
|
|
--ERROR ER_LOCK_WAIT_TIMEOUT
|
|
|
|
|
xa commit 'test1';
|
|
|
|
|
show errors;
|
|
|
|
|
xa recover;
|
|
|
|
|
connection default;
|
|
|
|
|
unlock tables;
|
|
|
|
|
connection con_tmp;
|
|
|
|
|
xa rollback 'test1';
|
|
|
|
|
xa recover;
|
|
|
|
|
drop table asd;
|
|
|
|
|
disconnect con_tmp;
|
|
|
|
|
--source include/wait_until_disconnected.inc
|
|
|
|
|
connection default;
|
2020-05-31 09:28:59 +02:00
|
|
|
|
|
|
|
|
|
--echo #
|
|
|
|
|
--echo # End of 10.5 tests
|
|
|
|
|
--echo #
|