From b8048a5538293b3855c2b2eae55d35645e614f11 Mon Sep 17 00:00:00 2001
From: Andreas Straub <andy@strb.org>
Date: Fri, 29 May 2015 11:17:26 +0200
Subject: CryptoNext persistance layer mockup

Initial sketch of the peripheral storage infrastructure for the new
axolotl-based encryption scheme.
---
 .../eu/siacs/conversations/entities/Contact.java   | 182 +++++++++++++--------
 1 file changed, 118 insertions(+), 64 deletions(-)

(limited to 'src/main/java/eu/siacs/conversations/entities/Contact.java')

diff --git a/src/main/java/eu/siacs/conversations/entities/Contact.java b/src/main/java/eu/siacs/conversations/entities/Contact.java
index e546f214..2f9b375d 100644
--- a/src/main/java/eu/siacs/conversations/entities/Contact.java
+++ b/src/main/java/eu/siacs/conversations/entities/Contact.java
@@ -2,15 +2,19 @@ package eu.siacs.conversations.entities;
 
 import android.content.ContentValues;
 import android.database.Cursor;
+import android.util.Log;
 
 import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;
+import org.whispersystems.libaxolotl.IdentityKey;
+import org.whispersystems.libaxolotl.InvalidKeyException;
 
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Locale;
 
+import eu.siacs.conversations.Config;
 import eu.siacs.conversations.utils.UIHelper;
 import eu.siacs.conversations.xml.Element;
 import eu.siacs.conversations.xmpp.jid.InvalidJidException;
@@ -183,20 +187,22 @@ public class Contact implements ListItem, Blockable {
 	}
 
 	public ContentValues getContentValues() {
-		final ContentValues values = new ContentValues();
-		values.put(ACCOUNT, accountUuid);
-		values.put(SYSTEMNAME, systemName);
-		values.put(SERVERNAME, serverName);
-		values.put(JID, jid.toString());
-		values.put(OPTIONS, subscription);
-		values.put(SYSTEMACCOUNT, systemAccount);
-		values.put(PHOTOURI, photoUri);
-		values.put(KEYS, keys.toString());
-		values.put(AVATAR, avatar == null ? null : avatar.getFilename());
-		values.put(LAST_PRESENCE, lastseen.presence);
-		values.put(LAST_TIME, lastseen.time);
-		values.put(GROUPS, groups.toString());
-		return values;
+		synchronized (this.keys) {
+			final ContentValues values = new ContentValues();
+			values.put(ACCOUNT, accountUuid);
+			values.put(SYSTEMNAME, systemName);
+			values.put(SERVERNAME, serverName);
+			values.put(JID, jid.toString());
+			values.put(OPTIONS, subscription);
+			values.put(SYSTEMACCOUNT, systemAccount);
+			values.put(PHOTOURI, photoUri);
+			values.put(KEYS, keys.toString());
+			values.put(AVATAR, avatar == null ? null : avatar.getFilename());
+			values.put(LAST_PRESENCE, lastseen.presence);
+			values.put(LAST_TIME, lastseen.time);
+			values.put(GROUPS, groups.toString());
+			return values;
+		}
 	}
 
 	public int getSubscription() {
@@ -281,63 +287,109 @@ public class Contact implements ListItem, Blockable {
 	}
 
 	public ArrayList<String> getOtrFingerprints() {
-		final ArrayList<String> fingerprints = new ArrayList<String>();
-		try {
-			if (this.keys.has("otr_fingerprints")) {
-				final JSONArray prints = this.keys.getJSONArray("otr_fingerprints");
-				for (int i = 0; i < prints.length(); ++i) {
-					final String print = prints.isNull(i) ? null : prints.getString(i);
-					if (print != null && !print.isEmpty()) {
-						fingerprints.add(prints.getString(i));
+		synchronized (this.keys) {
+			final ArrayList<String> fingerprints = new ArrayList<String>();
+			try {
+				if (this.keys.has("otr_fingerprints")) {
+					final JSONArray prints = this.keys.getJSONArray("otr_fingerprints");
+					for (int i = 0; i < prints.length(); ++i) {
+						final String print = prints.isNull(i) ? null : prints.getString(i);
+						if (print != null && !print.isEmpty()) {
+							fingerprints.add(prints.getString(i));
+						}
 					}
 				}
-			}
-		} catch (final JSONException ignored) {
+			} catch (final JSONException ignored) {
 
+			}
+			return fingerprints;
 		}
-		return fingerprints;
 	}
-
 	public boolean addOtrFingerprint(String print) {
-		if (getOtrFingerprints().contains(print)) {
-			return false;
+		synchronized (this.keys) {
+			if (getOtrFingerprints().contains(print)) {
+				return false;
+            }
+			try {
+				JSONArray fingerprints;
+				if (!this.keys.has("otr_fingerprints")) {
+					fingerprints = new JSONArray();
+				} else {
+					fingerprints = this.keys.getJSONArray("otr_fingerprints");
+				}
+				fingerprints.put(print);
+				this.keys.put("otr_fingerprints", fingerprints);
+				return true;
+			} catch (final JSONException ignored) {
+				return false;
+			}
 		}
-		try {
-			JSONArray fingerprints;
-			if (!this.keys.has("otr_fingerprints")) {
-				fingerprints = new JSONArray();
+	}
 
+	public long getPgpKeyId() {
+		synchronized (this.keys) {
+			if (this.keys.has("pgp_keyid")) {
+				try {
+					return this.keys.getLong("pgp_keyid");
+				} catch (JSONException e) {
+					return 0;
+				}
 			} else {
-				fingerprints = this.keys.getJSONArray("otr_fingerprints");
+				return 0;
 			}
-			fingerprints.put(print);
-			this.keys.put("otr_fingerprints", fingerprints);
-			return true;
-		} catch (final JSONException ignored) {
-			return false;
 		}
 	}
 
-	public long getPgpKeyId() {
-		if (this.keys.has("pgp_keyid")) {
+	public void setPgpKeyId(long keyId) {
+		synchronized (this.keys) {
 			try {
-				return this.keys.getLong("pgp_keyid");
-			} catch (JSONException e) {
-				return 0;
+				this.keys.put("pgp_keyid", keyId);
+			} catch (final JSONException ignored) {
 			}
-		} else {
-			return 0;
 		}
 	}
 
-	public void setPgpKeyId(long keyId) {
-		try {
-			this.keys.put("pgp_keyid", keyId);
-		} catch (final JSONException ignored) {
+	public List<IdentityKey> getTrustedAxolotlIdentityKeys() {
+		synchronized (this.keys) {
+			JSONArray serializedKeyItems = this.keys.optJSONArray("axolotl_identity_key");
+			List<IdentityKey> identityKeys = new ArrayList<>();
+			if(serializedKeyItems != null) {
+				for(int i = 0; i<serializedKeyItems.length();++i) {
+					try {
+						String serializedKeyItem = serializedKeyItems.getString(i);
+						IdentityKey identityKey = new IdentityKey(serializedKeyItem.getBytes(), 0);
+						identityKeys.add(identityKey);
+					} catch (InvalidKeyException e) {
+						Log.e(Config.LOGTAG, "Invalid axolotl identity key encountered at" + this.getJid() + ": " + e.getMessage());
+					} catch (JSONException e) {
+						Log.e(Config.LOGTAG, "Error retrieving axolotl identity key at" + this.getJid() + ": " + e.getMessage());
+					}
+				}
+			}
+			return identityKeys;
+		}
+	}
 
+	public boolean addAxolotlIdentityKey(IdentityKey identityKey, boolean trusted) {
+		synchronized (this.keys) {
+			JSONArray keysList;
+			try {
+				keysList = this.keys.getJSONArray("axolotl_identity_key");
+			} catch (JSONException e) {
+				keysList = new JSONArray();
+			}
+			keysList.put(new String(identityKey.serialize()));
+			try {
+				this.keys.put("axolotl_identity_key", keysList);
+			} catch (JSONException e) {
+				Log.e(Config.LOGTAG, "Error adding Identity Key to Contact " + this.getJid() + ": " + e.getMessage());
+				return false;
+			}
 		}
+		return true;
 	}
 
+
 	public void setOption(int option) {
 		this.subscription |= 1 << option;
 	}
@@ -441,24 +493,26 @@ public class Contact implements ListItem, Blockable {
 	}
 
 	public boolean deleteOtrFingerprint(String fingerprint) {
-		boolean success = false;
-		try {
-			if (this.keys.has("otr_fingerprints")) {
-				JSONArray newPrints = new JSONArray();
-				JSONArray oldPrints = this.keys
-					.getJSONArray("otr_fingerprints");
-				for (int i = 0; i < oldPrints.length(); ++i) {
-					if (!oldPrints.getString(i).equals(fingerprint)) {
-						newPrints.put(oldPrints.getString(i));
-					} else {
-						success = true;
+		synchronized (this.keys) {
+			boolean success = false;
+			try {
+				if (this.keys.has("otr_fingerprints")) {
+					JSONArray newPrints = new JSONArray();
+					JSONArray oldPrints = this.keys
+							.getJSONArray("otr_fingerprints");
+					for (int i = 0; i < oldPrints.length(); ++i) {
+						if (!oldPrints.getString(i).equals(fingerprint)) {
+							newPrints.put(oldPrints.getString(i));
+						} else {
+							success = true;
+						}
 					}
+					this.keys.put("otr_fingerprints", newPrints);
 				}
-				this.keys.put("otr_fingerprints", newPrints);
+				return success;
+			} catch (JSONException e) {
+				return false;
 			}
-			return success;
-		} catch (JSONException e) {
-			return false;
 		}
 	}
 
-- 
cgit v1.2.3


From f73aa1a2006beb741bc39026bfd10e6166d7951a Mon Sep 17 00:00:00 2001
From: Andreas Straub <andreas.straub@rwth-aachen.de>
Date: Thu, 25 Jun 2015 16:56:34 +0200
Subject: Reworked axolotl protocol layer

Numerous fixes
---
 .../eu/siacs/conversations/entities/Contact.java   | 62 +++++++++++++++-------
 1 file changed, 43 insertions(+), 19 deletions(-)

(limited to 'src/main/java/eu/siacs/conversations/entities/Contact.java')

diff --git a/src/main/java/eu/siacs/conversations/entities/Contact.java b/src/main/java/eu/siacs/conversations/entities/Contact.java
index 2f9b375d..45b55e49 100644
--- a/src/main/java/eu/siacs/conversations/entities/Contact.java
+++ b/src/main/java/eu/siacs/conversations/entities/Contact.java
@@ -2,6 +2,7 @@ package eu.siacs.conversations.entities;
 
 import android.content.ContentValues;
 import android.database.Cursor;
+import android.util.Base64;
 import android.util.Log;
 
 import org.json.JSONArray;
@@ -349,20 +350,38 @@ public class Contact implements ListItem, Blockable {
 		}
 	}
 
-	public List<IdentityKey> getTrustedAxolotlIdentityKeys() {
+	public List<IdentityKey> getAxolotlIdentityKeys() {
 		synchronized (this.keys) {
 			JSONArray serializedKeyItems = this.keys.optJSONArray("axolotl_identity_key");
 			List<IdentityKey> identityKeys = new ArrayList<>();
+			List<Integer> toDelete = new ArrayList<>();
 			if(serializedKeyItems != null) {
 				for(int i = 0; i<serializedKeyItems.length();++i) {
 					try {
 						String serializedKeyItem = serializedKeyItems.getString(i);
-						IdentityKey identityKey = new IdentityKey(serializedKeyItem.getBytes(), 0);
+						IdentityKey identityKey = new IdentityKey(Base64.decode(serializedKeyItem, Base64.DEFAULT), 0);
 						identityKeys.add(identityKey);
 					} catch (InvalidKeyException e) {
-						Log.e(Config.LOGTAG, "Invalid axolotl identity key encountered at" + this.getJid() + ": " + e.getMessage());
+						Log.e(Config.LOGTAG, "Invalid axolotl identity key encountered at contact" + this.getJid() + ": " + e.getMessage() + ", marking for deletion...");
+						toDelete.add(i);
 					} catch (JSONException e) {
-						Log.e(Config.LOGTAG, "Error retrieving axolotl identity key at" + this.getJid() + ": " + e.getMessage());
+						Log.e(Config.LOGTAG, "Error retrieving axolotl identity key at contact " + this.getJid() + ": " + e.getMessage());
+					} catch (IllegalArgumentException e) {
+						Log.e(Config.LOGTAG, "Encountered malformed identity key for contact" + this.getJid() + ": " + e.getMessage() + ", marking for deletion... ");
+						toDelete.add(i);
+					}
+				}
+				if(!toDelete.isEmpty()) {
+					try {
+						JSONArray filteredKeyItems = new JSONArray();
+						for (int i = 0; i < serializedKeyItems.length(); ++i) {
+							if (!toDelete.contains(i)) {
+								filteredKeyItems.put(serializedKeyItems.get(i));
+							}
+						}
+						this.keys.put("axolotl_identity_key", filteredKeyItems);
+					} catch (JSONException e) {
+						//should never happen
 					}
 				}
 			}
@@ -370,23 +389,28 @@ public class Contact implements ListItem, Blockable {
 		}
 	}
 
-	public boolean addAxolotlIdentityKey(IdentityKey identityKey, boolean trusted) {
+	public boolean addAxolotlIdentityKey(IdentityKey identityKey) {
 		synchronized (this.keys) {
-			JSONArray keysList;
-			try {
-				keysList = this.keys.getJSONArray("axolotl_identity_key");
-			} catch (JSONException e) {
-				keysList = new JSONArray();
-			}
-			keysList.put(new String(identityKey.serialize()));
-			try {
-				this.keys.put("axolotl_identity_key", keysList);
-			} catch (JSONException e) {
-				Log.e(Config.LOGTAG, "Error adding Identity Key to Contact " + this.getJid() + ": " + e.getMessage());
-				return false;
-			}
+			if(!getAxolotlIdentityKeys().contains(identityKey)) {
+                JSONArray keysList;
+                try {
+                    keysList = this.keys.getJSONArray("axolotl_identity_key");
+                } catch (JSONException e) {
+                    keysList = new JSONArray();
+                }
+
+				keysList.put(Base64.encodeToString(identityKey.serialize(), Base64.DEFAULT));
+				try {
+					this.keys.put("axolotl_identity_key", keysList);
+				} catch (JSONException e) {
+					Log.e(Config.LOGTAG, "Error adding Identity Key to Contact " + this.getJid() + ": " + e.getMessage());
+					return false;
+				}
+                return true;
+			} else {
+                return false;
+            }
 		}
-		return true;
 	}
 
 
-- 
cgit v1.2.3


From 299bbdf27f0144e6eed99e70a3b2e46f9a3aa301 Mon Sep 17 00:00:00 2001
From: Andreas Straub <andy@strb.org>
Date: Fri, 26 Jun 2015 15:41:02 +0200
Subject: Reformat code to use tabs

This really sucks to do it like this. Sorry. :(
---
 .../eu/siacs/conversations/entities/Contact.java     | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

(limited to 'src/main/java/eu/siacs/conversations/entities/Contact.java')

diff --git a/src/main/java/eu/siacs/conversations/entities/Contact.java b/src/main/java/eu/siacs/conversations/entities/Contact.java
index 45b55e49..240d5223 100644
--- a/src/main/java/eu/siacs/conversations/entities/Contact.java
+++ b/src/main/java/eu/siacs/conversations/entities/Contact.java
@@ -310,7 +310,7 @@ public class Contact implements ListItem, Blockable {
 		synchronized (this.keys) {
 			if (getOtrFingerprints().contains(print)) {
 				return false;
-            }
+			}
 			try {
 				JSONArray fingerprints;
 				if (!this.keys.has("otr_fingerprints")) {
@@ -392,12 +392,12 @@ public class Contact implements ListItem, Blockable {
 	public boolean addAxolotlIdentityKey(IdentityKey identityKey) {
 		synchronized (this.keys) {
 			if(!getAxolotlIdentityKeys().contains(identityKey)) {
-                JSONArray keysList;
-                try {
-                    keysList = this.keys.getJSONArray("axolotl_identity_key");
-                } catch (JSONException e) {
-                    keysList = new JSONArray();
-                }
+				JSONArray keysList;
+				try {
+					keysList = this.keys.getJSONArray("axolotl_identity_key");
+				} catch (JSONException e) {
+					keysList = new JSONArray();
+				}
 
 				keysList.put(Base64.encodeToString(identityKey.serialize(), Base64.DEFAULT));
 				try {
@@ -406,10 +406,10 @@ public class Contact implements ListItem, Blockable {
 					Log.e(Config.LOGTAG, "Error adding Identity Key to Contact " + this.getJid() + ": " + e.getMessage());
 					return false;
 				}
-                return true;
+				return true;
 			} else {
-                return false;
-            }
+				return false;
+			}
 		}
 	}
 
-- 
cgit v1.2.3


From 491f623708437f418497ecace2876e9c81708e72 Mon Sep 17 00:00:00 2001
From: Andreas Straub <andy@strb.org>
Date: Tue, 7 Jul 2015 19:27:12 +0200
Subject: Fix displaying Contact IdentityKeys

Migrate ContactDetailsActivity to use new SQL IdentityKeys storage,
remove dead code from Contact class.
---
 .../eu/siacs/conversations/entities/Contact.java   | 64 ----------------------
 1 file changed, 64 deletions(-)

(limited to 'src/main/java/eu/siacs/conversations/entities/Contact.java')

diff --git a/src/main/java/eu/siacs/conversations/entities/Contact.java b/src/main/java/eu/siacs/conversations/entities/Contact.java
index 240d5223..fdb5f932 100644
--- a/src/main/java/eu/siacs/conversations/entities/Contact.java
+++ b/src/main/java/eu/siacs/conversations/entities/Contact.java
@@ -350,70 +350,6 @@ public class Contact implements ListItem, Blockable {
 		}
 	}
 
-	public List<IdentityKey> getAxolotlIdentityKeys() {
-		synchronized (this.keys) {
-			JSONArray serializedKeyItems = this.keys.optJSONArray("axolotl_identity_key");
-			List<IdentityKey> identityKeys = new ArrayList<>();
-			List<Integer> toDelete = new ArrayList<>();
-			if(serializedKeyItems != null) {
-				for(int i = 0; i<serializedKeyItems.length();++i) {
-					try {
-						String serializedKeyItem = serializedKeyItems.getString(i);
-						IdentityKey identityKey = new IdentityKey(Base64.decode(serializedKeyItem, Base64.DEFAULT), 0);
-						identityKeys.add(identityKey);
-					} catch (InvalidKeyException e) {
-						Log.e(Config.LOGTAG, "Invalid axolotl identity key encountered at contact" + this.getJid() + ": " + e.getMessage() + ", marking for deletion...");
-						toDelete.add(i);
-					} catch (JSONException e) {
-						Log.e(Config.LOGTAG, "Error retrieving axolotl identity key at contact " + this.getJid() + ": " + e.getMessage());
-					} catch (IllegalArgumentException e) {
-						Log.e(Config.LOGTAG, "Encountered malformed identity key for contact" + this.getJid() + ": " + e.getMessage() + ", marking for deletion... ");
-						toDelete.add(i);
-					}
-				}
-				if(!toDelete.isEmpty()) {
-					try {
-						JSONArray filteredKeyItems = new JSONArray();
-						for (int i = 0; i < serializedKeyItems.length(); ++i) {
-							if (!toDelete.contains(i)) {
-								filteredKeyItems.put(serializedKeyItems.get(i));
-							}
-						}
-						this.keys.put("axolotl_identity_key", filteredKeyItems);
-					} catch (JSONException e) {
-						//should never happen
-					}
-				}
-			}
-			return identityKeys;
-		}
-	}
-
-	public boolean addAxolotlIdentityKey(IdentityKey identityKey) {
-		synchronized (this.keys) {
-			if(!getAxolotlIdentityKeys().contains(identityKey)) {
-				JSONArray keysList;
-				try {
-					keysList = this.keys.getJSONArray("axolotl_identity_key");
-				} catch (JSONException e) {
-					keysList = new JSONArray();
-				}
-
-				keysList.put(Base64.encodeToString(identityKey.serialize(), Base64.DEFAULT));
-				try {
-					this.keys.put("axolotl_identity_key", keysList);
-				} catch (JSONException e) {
-					Log.e(Config.LOGTAG, "Error adding Identity Key to Contact " + this.getJid() + ": " + e.getMessage());
-					return false;
-				}
-				return true;
-			} else {
-				return false;
-			}
-		}
-	}
-
-
 	public void setOption(int option) {
 		this.subscription |= 1 << option;
 	}
-- 
cgit v1.2.3


From 012f036840ade8f46462eafcc96d1f223f8ba845 Mon Sep 17 00:00:00 2001
From: Andreas Straub <andy@strb.org>
Date: Mon, 20 Jul 2015 14:26:29 +0200
Subject: Optimize imports

---
 src/main/java/eu/siacs/conversations/entities/Contact.java | 5 -----
 1 file changed, 5 deletions(-)

(limited to 'src/main/java/eu/siacs/conversations/entities/Contact.java')

diff --git a/src/main/java/eu/siacs/conversations/entities/Contact.java b/src/main/java/eu/siacs/conversations/entities/Contact.java
index fdb5f932..f924c05a 100644
--- a/src/main/java/eu/siacs/conversations/entities/Contact.java
+++ b/src/main/java/eu/siacs/conversations/entities/Contact.java
@@ -2,20 +2,15 @@ package eu.siacs.conversations.entities;
 
 import android.content.ContentValues;
 import android.database.Cursor;
-import android.util.Base64;
-import android.util.Log;
 
 import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;
-import org.whispersystems.libaxolotl.IdentityKey;
-import org.whispersystems.libaxolotl.InvalidKeyException;
 
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Locale;
 
-import eu.siacs.conversations.Config;
 import eu.siacs.conversations.utils.UIHelper;
 import eu.siacs.conversations.xml.Element;
 import eu.siacs.conversations.xmpp.jid.InvalidJidException;
-- 
cgit v1.2.3