Merge remote-tracking branch 'remotes/origin/trz/rename' into trz/rebase

1 files changed, 35 insertions, 14 deletions

diff --git a/src/main/java/eu/siacs/conversations/ui/listeners/ConversationSwipeRefreshListener.java b/src/main/java/eu/siacs/conversations/ui/listeners/ConversationSwipeRefreshListener.java
index f2b5ca22..e698c9b2 100644
--- a/src/main/java/eu/siacs/conversations/ui/listeners/ConversationSwipeRefreshListener.java
+++ b/src/main/java/eu/siacs/conversations/ui/listeners/ConversationSwipeRefreshListener.java
@@ -1,8 +1,5 @@
 package eu.siacs.conversations.ui.listeners;
 
-import de.thedevstack.conversationsplus.R;
-import de.thedevstack.conversationsplus.services.MessageArchiveService;
-import de.thedevstack.conversationsplus.utils.Logging;
 import android.widget.ListView;
 
 import com.orangegangsters.github.swipyrefreshlayout.library.SwipyRefreshLayout;
@@ -10,8 +7,13 @@ import com.orangegangsters.github.swipyrefreshlayout.library.SwipyRefreshLayoutD
 
 import java.util.List;
 
+import de.thedevstack.android.logcat.Logging;
+
 import eu.siacs.conversations.Config;
+import eu.siacs.conversations.R;
+import eu.siacs.conversations.entities.Conversation;
 import eu.siacs.conversations.entities.Message;
+import eu.siacs.conversations.services.MessageArchiveService;
 import eu.siacs.conversations.ui.ConversationActivity;
 import eu.siacs.conversations.ui.ConversationFragment;
 import eu.siacs.conversations.ui.adapter.MessageAdapter;
@@ -36,7 +38,7 @@ public class ConversationSwipeRefreshListener implements SwipyRefreshLayout.OnRe
         Logging.d(Config.LOGTAG, "Refresh direction " + direction);
         synchronized (this.messageList) {
             long timestamp;
-            if (SwipyRefreshLayoutDirection.TOP == direction) {
+            if (SwipyRefreshLayoutDirection.TOP == direction) { // Load history -> messages sent/received before first message in database
                 if (messageList.isEmpty()) {
                     timestamp = System.currentTimeMillis();
                 } else {
@@ -45,28 +47,47 @@ public class ConversationSwipeRefreshListener implements SwipyRefreshLayout.OnRe
                 ConversationActivity activity = (ConversationActivity) fragment.getActivity();
                 this.listener.setLoadHistory(true);
                 activity.xmppConnectionService.loadMoreMessages(activity.getSelectedConversation(), timestamp, this.listener);
-            } else if (SwipyRefreshLayoutDirection.BOTTOM == direction) {
+            } else if (SwipyRefreshLayoutDirection.BOTTOM == direction) { // load messages sent/received between last received or last session establishment and now
                 Logging.d("mam", "loading missing messages from mam (last session establishing or last received message)");
                 final ConversationActivity activity = (ConversationActivity) fragment.getActivity();
-                long lastSessionEstablished = activity.getSelectedConversation().getAccount().getXmppConnection().getLastSessionEstablished();
-                int lastMessageIndex = this.messageList.size() - 1;
-                long lastReceivedMessage = (0 <= lastMessageIndex) ? this.messageList.get(lastMessageIndex).getTimeSent() : Long.MAX_VALUE;
+                long lastSessionEstablished = this.getTimestampOfLastSessionEstablished(activity.getSelectedConversation());
+                long lastReceivedMessage = this.getTimestampOfLastReceivedOrTransmittedMessage();
                 long startTimestamp = Math.min(lastSessionEstablished, lastReceivedMessage);
                 MessageArchiveService.Query query = activity.xmppConnectionService.getMessageArchiveService().query(activity.getSelectedConversation(), startTimestamp, System.currentTimeMillis());
                 if (query != null) {
                     this.listener.setLoadHistory(false);
                     query.setCallback(this.listener);
                 } else {
-                    activity.runOnUiThread(new Runnable() {
-                        @Override
-                        public void run() {
-                            listener.onMoreMessagesLoaded(0, activity.getSelectedConversation());
-                        }
-                    });
+                    Logging.d("mam", "no query built - no messages loaded");
+                    this.listener.onMoreMessagesLoaded(0, activity.getSelectedConversation());
+                    this.listener.informUser(R.string.no_more_history_on_server);
                 }
                 this.listener.informUser(R.string.fetching_history_from_server);
             }
         }
         Logging.d(Config.LOGTAG, "End Refresh swipe container");
     }
+
+    private long getTimestampOfLastReceivedOrTransmittedMessage() {
+        long lastReceivedOrTransmittedMessage = Long.MAX_VALUE;
+        if (null != this.messageList
+                && !this.messageList.isEmpty()) {
+            int lastMessageIndex = this.messageList.size() - 1;
+            if (0 <= lastMessageIndex && this.messageList.size() > lastMessageIndex) {
+                lastReceivedOrTransmittedMessage = this.messageList.get(lastMessageIndex).getTimeSent();
+            }
+        }
+
+        return lastReceivedOrTransmittedMessage;
+    }
+
+    private long getTimestampOfLastSessionEstablished(Conversation conversation) {
+        long lastSessionEstablished = Long.MAX_VALUE;
+        if (null != conversation
+                && null != conversation.getAccount()
+                && null != conversation.getAccount().getXmppConnection()) {
+            lastSessionEstablished = conversation.getAccount().getXmppConnection().getLastSessionEstablished();
+        }
+        return lastSessionEstablished;
+    }
 }