Fixes FS#37 - Remove special treatment of unicode hearts

Fixes FS#34 - review all calls for String.trim()

1 files changed, 13 insertions, 19 deletions

diff --git a/src/main/java/eu/siacs/conversations/entities/Message.java b/src/main/java/eu/siacs/conversations/entities/Message.java
index e3fb7944..d04dff87 100644
--- a/src/main/java/eu/siacs/conversations/entities/Message.java
+++ b/src/main/java/eu/siacs/conversations/entities/Message.java
@@ -59,7 +59,7 @@ public class Message extends AbstractEntity {
 	protected String conversationUuid;
 	protected Jid counterpart;
 	protected Jid trueCounterpart;
-	protected String body;
+	private String body;
 	protected String encryptedBody;
 	protected long timeSent;
 	protected int encryption;
@@ -319,16 +319,16 @@ public class Message extends AbstractEntity {
 	public boolean equals(Message message) {
 		if (this.serverMsgId != null && message.getServerMsgId() != null) {
 			return this.serverMsgId.equals(message.getServerMsgId());
-		} else if (this.body == null || this.counterpart == null) {
+		} else if (this.getBody() == null || this.counterpart == null) {
 			return false;
 		} else {
 			String body, otherBody;
 			if (this.hasFileOnRemoteHost()) {
 				body = getFileParams().url.toString();
-				otherBody = message.body == null ? null : message.body.trim();
+				otherBody = message.getBody() == null ? null : message.getBody();
 			} else {
-				body = this.body;
-				otherBody = message.body;
+				body = this.getBody();
+				otherBody = message.getBody();
 			}
 			if (message.getRemoteMsgId() != null) {
 				return (message.getRemoteMsgId().equals(this.remoteMsgId) || message.getRemoteMsgId().equals(this.uuid))
@@ -385,13 +385,11 @@ public class Message extends AbstractEntity {
 						this.getCounterpart().equals(message.getCounterpart()) &&
 						(message.getTimeSent() - this.getTimeSent()) <= (Config.MESSAGE_MERGE_WINDOW * 1000) &&
 						!GeoHelper.isGeoUri(message.getBody()) &&
-						!GeoHelper.isGeoUri(this.body) &&
+						!GeoHelper.isGeoUri(this.getBody()) &&
 						message.treatAsDownloadable() == Decision.NEVER &&
 						this.treatAsDownloadable() == Decision.NEVER &&
 						!message.getBody().startsWith(ME_COMMAND) &&
-						!this.getBody().startsWith(ME_COMMAND) &&
-						!this.bodyIsHeart() &&
-						!message.bodyIsHeart()
+						!this.getBody().startsWith(ME_COMMAND)
 				);
 	}
 
@@ -509,7 +507,7 @@ public class Message extends AbstractEntity {
 			}
 		} else {
 			try {
-				return MimeUtils.guessMimeTypeFromExtension(extractRelevantExtension(new URL(body.trim())));
+				return MimeUtils.guessMimeTypeFromExtension(extractRelevantExtension(new URL(this.getBody())));
 			} catch (MalformedURLException e) {
 				return null;
 			}
@@ -522,7 +520,7 @@ public class Message extends AbstractEntity {
 		 * "http://example.com/image.jpg" text that will not be shown /abc.png"
 		 * or more than one image link in one message.
 		 */
-		if (body.trim().contains(" ")) {
+		if (getBody().contains(" ")) {
 			return Decision.NEVER;
 		}
 		try {
@@ -555,10 +553,6 @@ public class Message extends AbstractEntity {
 		}
 	}
 
-	public boolean bodyIsHeart() {
-		return body != null && UIHelper.HEARTS.contains(body.trim());
-	}
-
 	public FileParams getFileParams() {
 		FileParams params = getLegacyFileParams();
 		if (params != null) {
@@ -568,10 +562,10 @@ public class Message extends AbstractEntity {
 		if (this.transferable != null) {
 			params.size = this.transferable.getFileSize();
 		}
-		if (body == null) {
+		if (this.getBody() == null) {
 			return params;
 		}
-		String parts[] = body.split("\\|");
+		String parts[] = this.getBody().split("\\|");
 		switch (parts.length) {
 			case 1:
 				try {
@@ -630,10 +624,10 @@ public class Message extends AbstractEntity {
 
 	public FileParams getLegacyFileParams() {
 		FileParams params = new FileParams();
-		if (body == null) {
+		if (this.getBody() == null) {
 			return params;
 		}
-		String parts[] = body.split(",");
+		String parts[] = this.getBody().split(",");
 		if (parts.length == 3) {
 			try {
 				params.size = Long.parseLong(parts[0]);