Commit graph

115 commits

Author SHA1 Message Date
rvelices
e618e8b944 - fix php warning from comment_list.tpl
- author name is saved always in #comments (even for registered users) so that
  - sql queries are simpler on the comments page (one less table in a big join)
  - when a user is deleted, we can keep the username in the #comments (there might be still a bug that author_id is not updated when a user is deleted)

git-svn-id: http://piwigo.org/svn/trunk@3600 68402e56-0260-453c-a942-63ccdbb3a9ee
2009-07-16 05:20:34 +00:00
vdigital
b102907b51 merge r3519 from branch 2.0 to trunk
Minor: prevent for non numeric values (except all)




git-svn-id: http://piwigo.org/svn/trunk@3520 68402e56-0260-453c-a942-63ccdbb3a9ee
2009-07-04 20:45:14 +00:00
rvelices
ae6ab9966b - remove unnecessary addslashes in comments.cpp
- in template use modifier |@default instead of |default (generated code is faster because we indicate that the input is scalar and not an array)

git-svn-id: http://piwigo.org/svn/trunk@3487 68402e56-0260-453c-a942-63ccdbb3a9ee
2009-07-01 20:43:20 +00:00
nikrou
ed7f7a574e Fix two problem with Feature 1026 :
use of $conf['user_fields']['username'] and $conf['user_fields']['id'] instead of username and id
escape comment content before editing it.

git-svn-id: http://piwigo.org/svn/trunk@3452 68402e56-0260-453c-a942-63ccdbb3a9ee
2009-06-24 19:00:40 +00:00
nikrou
64c872a83e Feature 1026 step 2 :
add author_id column so that guest cannot modify old users comments

git-svn-id: http://piwigo.org/svn/trunk@3450 68402e56-0260-453c-a942-63ccdbb3a9ee
2009-06-23 21:18:16 +00:00
nikrou
9245227e70 Feature 1026 : Modify / delete comments for users
+ update config table content
 + minor modification of Sylvia theme
 + need refactoring

git-svn-id: http://piwigo.org/svn/trunk@3445 68402e56-0260-453c-a942-63ccdbb3a9ee
2009-06-23 13:44:58 +00:00
nikrou
0ace0450a6 remove duplicate retrieved field
git-svn-id: http://piwigo.org/svn/trunk@3405 68402e56-0260-453c-a942-63ccdbb3a9ee
2009-06-10 19:06:16 +00:00
patdenice
254aee2695 Create navigation_bar.tpl file.
Move create_navigation_bar function from functions_html.inc.php to functions.inc.php.

git-svn-id: http://piwigo.org/svn/trunk@3172 68402e56-0260-453c-a942-63ccdbb3a9ee
2009-03-05 21:08:04 +00:00
rvelices
e8dac75c40 - removed second parameter $type from function format_date
git-svn-id: http://piwigo.org/svn/trunk@3122 68402e56-0260-453c-a942-63ccdbb3a9ee
2009-02-04 02:41:03 +00:00
plegall
1b711ad236 Administration: happy new year 2009, all PHP headers updated.
git-svn-id: http://piwigo.org/svn/trunk@3049 68402e56-0260-453c-a942-63ccdbb3a9ee
2009-01-04 23:28:36 +00:00
rvelices
ebc3c2e2f7 merge 2755 and 2756 from branch 2.0 to trunk
- 2755 fix vulnerability http://www.milw0rm.com/exploits/6755
- 2756 security paranoia: protect session/remember me cookies from XSS attacks (works only if php>=5.2 and with IE/FF maybe others)


git-svn-id: http://piwigo.org/svn/trunk@2757 68402e56-0260-453c-a942-63ccdbb3a9ee
2008-10-16 00:38:26 +00:00
plegall
524011bfa6 Bug fixed: as rvelices notified me by email, my header replacement script was
bugged (r2297 was repeating new and old header).

By the way, I've also removed the replacement keywords. We were using them
because it was a common usage with CVS but it is advised not to use them with
Subversion. Personnaly, it is a problem when I search differences between 2
Piwigo installations outside Subversion.


git-svn-id: http://piwigo.org/svn/trunk@2299 68402e56-0260-453c-a942-63ccdbb3a9ee
2008-04-05 14:14:07 +00:00
plegall
3f235497f3 Modification: new header on PHP files, PhpWebGallery renamed Piwigo.
git-svn-id: http://piwigo.org/svn/trunk@2297 68402e56-0260-453c-a942-63ccdbb3a9ee
2008-04-04 22:57:23 +00:00
rvelices
bf1f7c4aec - security fix (profile)
- les langues a la hache
- fix some copy/paste errors

git-svn-id: http://piwigo.org/svn/trunk@2268 68402e56-0260-453c-a942-63ccdbb3a9ee
2008-03-08 12:38:09 +00:00
rvelices
c739232049 - migrate many templates to smarty
git-svn-id: http://piwigo.org/svn/trunk@2223 68402e56-0260-453c-a942-63ccdbb3a9ee
2008-02-28 02:41:48 +00:00
rvelices
36e0e6e8f1 - changed htmlentities to htmlspecialchars in comments.php (utf-8 issue)
- web service explorer in utf-8
- removed warning in function load_language
- feature: show_queries also shows number of selected rows or number of affected rows

git-svn-id: http://piwigo.org/svn/trunk@2134 68402e56-0260-453c-a942-63ccdbb3a9ee
2007-10-11 00:10:41 +00:00
rvelices
a3b23df6ef - admin, comments and tags pages include page_header later in the code (as in picture and index) allowing plugins to change the header until the very end
- fix in admin.php : picture_modify requires cache invalidation
- fix in site_update.php : some echo func calls changed to $template->output .= ...
- upgraded prototype.js to latest version 1.5.1.1

git-svn-id: http://piwigo.org/svn/trunk@2107 68402e56-0260-453c-a942-63ccdbb3a9ee
2007-09-27 22:46:17 +00:00
rub
3fbc92f61e Resolved issue 0000702: Code Injection with picture comment
git-svn-id: http://piwigo.org/svn/trunk@2030 68402e56-0260-453c-a942-63ccdbb3a9ee
2007-06-07 18:50:25 +00:00
rvelices
88d47f2332 keyword search was not working comments.php
git-svn-id: http://piwigo.org/svn/trunk@2012 68402e56-0260-453c-a942-63ccdbb3a9ee
2007-05-15 03:38:48 +00:00
rvelices
ea56d7b2ac feature 657: permalinks for categories
git-svn-id: http://piwigo.org/svn/trunk@1866 68402e56-0260-453c-a942-63ccdbb3a9ee
2007-02-28 03:07:12 +00:00
rvelices
47512ce6a6 - refactoring page['category'] before 1.7 release
page['category'] is not an id anymore, but an associative array of category info
all of page['cat_xxx'] or page['uppercats'] merged into one
simplifies calls to make_index_url
give plugins a clean start for page variables for version 1.7

git-svn-id: http://piwigo.org/svn/trunk@1861 68402e56-0260-453c-a942-63ccdbb3a9ee
2007-02-27 01:56:16 +00:00
rvelices
cea58b64ee - user comments are not saved in the database with htmlspecialchars anymore
- web service: added the possibility to enter a user comment using the service...
- new comment functions from picture_comment.inc.php

git-svn-id: http://piwigo.org/svn/trunk@1849 68402e56-0260-453c-a942-63ccdbb3a9ee
2007-02-22 01:12:32 +00:00
rvelices
711ebcbf2c - thumbnails creation for all local sites (not only site id 1)
- urls for images in notification (rss & mail) is now correct
- removed "Recent pictures" from title in when the flat view is in effect
- removed unnecessary class="" from comments.tpl
- english language correction
- removed unused web service files
- set rating star button left & right margin to 0 (javascript)
- admin menu - put site manager and synchronize together

git-svn-id: http://piwigo.org/svn/trunk@1814 68402e56-0260-453c-a942-63ccdbb3a9ee
2007-02-14 00:36:34 +00:00
rvelices
a512c69225 plugins improvements: allow plugins to fail the installation/activation
comments.php improvements:
  - no more double sql escaping on author & keyword (once in common.inc.php and
once in comments.php)
  - now can search comment content on all special char ( ', ", <, >, & )
  - author & keyword are correctly redisplayed in browser when they are MySql
escaped


git-svn-id: http://piwigo.org/svn/trunk@1716 68402e56-0260-453c-a942-63ccdbb3a9ee
2007-01-11 23:15:26 +00:00
rub
60bcda3564 Fixed: HTML vulnerability (Cross Site Scripting)
git-svn-id: http://piwigo.org/svn/trunk@1696 68402e56-0260-453c-a942-63ccdbb3a9ee
2007-01-03 23:28:09 +00:00
rub
cab8f98c4a Feature Issue ID 0000601: Filter all public pages with only recent elements
It's a finalized version.
Obsolete code of draft are removed.

You can filter categories and images with recent date period on your screen selection.
In the future, filter could be easy done on other type data (plugin?)

You can flat categories and sub-categories with a recent date period of your choice.

Next, perhaps, a panel to choice recent date for the 2 features.

On draft, there have problem with MySql 5, be careful!

Css problem not resolved:
  - Menu "Categories" is bad centered
  - Icon on dark too on the top


git-svn-id: http://piwigo.org/svn/trunk@1677 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-12-21 21:38:20 +00:00
vdigital
906d9bd795 Undo 597: Unvalidated comments
git-svn-id: http://piwigo.org/svn/trunk@1647 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-12-10 11:33:54 +00:00
vdigital
51b13edc9d 0000597: Unvalidated comments are displayed on public side
Just add a comment filter to avoid showing unvalidated comment to non admin people.

git-svn-id: http://piwigo.org/svn/trunk@1646 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-12-09 08:57:43 +00:00
rvelices
5de8aeafad feature 440: send mail to admin when comment is entered
git-svn-id: http://piwigo.org/svn/trunk@1617 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-11-22 04:41:25 +00:00
rvelices
e5e776a263 - comments.php improvements:
- unvalidated comments are shown only for administrators
  - added delete/validate icons for admins
  - removed some unused code
- display of comment content performed through an event
- replace some get_thumbnail_src with get_thumbnail_url

git-svn-id: http://piwigo.org/svn/trunk@1598 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-11-08 04:28:30 +00:00
rvelices
939cfe5e4b comments.php: cleanup url (t=1 in the url for an unknown reason) and image
urls work now with all url styles

git-svn-id: http://piwigo.org/svn/trunk@1563 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-10-17 02:03:14 +00:00
nikrou
bc1f5319b1 fix bug 518: anyone can delete or validate a comment
comment_id must be int: use of intval function to use it in the query.

svn merge -r1534:1535 from branch 1.6 into trunk


git-svn-id: http://piwigo.org/svn/trunk@1536 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-08-14 20:57:50 +00:00
rvelices
0971ce48d2 URL rewriting: capable of fully working with urls without ?
URL rewriting: works with image file instead of image id (change
make_picture_url to generate urls with file name instead of image id)

URL rewriting: completely works with category/best_rated and
picture/best_rated/534 (change 'category.php?' to 'category' in make_index_url
and 'picture.php?' to 'picture' in make_picture_url to see it)

fix: picture category display in upper bar

fix: function rate_picture variables and use of the new user type

fix: caddie icon appears now on category page

fix: admin element_set sql query was using storage_category_id column
(column has moved to #image_categories)

fix: replaced some old $_GET[xxx] with $page[xxx]

fix: pictures have metadata url (use ? parameter - might change later)

git-svn-id: http://piwigo.org/svn/trunk@1092 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-03-22 01:01:47 +00:00
rvelices
e584310d3a URL rewriting: fix some old links, calendar simplification and prepare code
for urls without ? (added functions get_root_url and add_url_param)

git-svn-id: http://piwigo.org/svn/trunk@1090 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-03-21 01:27:21 +00:00
plegall
114ae32445 new: cleaner URL. Instead of category.php?cat=search&search=123&start=42,
you now have category.php?/search/123/start-42. Functions make_index_url and
make_picture_url build these new URLs. Functions duplicate_picture_url and
duplicate_index_url provide shortcuts to URL creation. The current main page
page is still category.php but this can be modified easily in make_index_url
function. In this first version, no backward compatibility. Calendar
definition in URL must be discussed with rvelices.

improvement: picture.php redesigned. First actions like "set as
representative" or "delete a comment" which all lead to a redirection. Then
the page (the big mess) and includes of new sub pages to manage specific
parts of the page (metadata, user comments, rates).

new: with the cleaner URL comes a new terminology. $page['cat'] doesn't
exist anymore. $page['section'] is among 'categories', 'tags' (TODO),
'list', 'most_seen'... And sub parameters are set : $page['category'] if
$page['section'] is "categories". See URL analyse in
include/section_init.inc.php for details.


git-svn-id: http://piwigo.org/svn/trunk@1082 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-03-15 22:44:35 +00:00
rub
31d9ce1604 Step 2 improvement issue 0000301:
o Add and use Functions Check of status
  o Restricted Access for user generic

git-svn-id: http://piwigo.org/svn/trunk@1072 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-03-09 22:46:28 +00:00
nikrou
c3397a2c73 Improve security of sessions:
- use only cookies to store session id on client side
- use default php session system with database handler to store sessions on server side

git-svn-id: http://piwigo.org/svn/trunk@1004 68402e56-0260-453c-a942-63ccdbb3a9ee
2006-01-15 13:45:42 +00:00
plegall
d411c48e9f - modification: localized labels in Administration>Pictures>Caddie
- translation: bug fixed on special categories title in French

- translation: all help pages were translated in french


git-svn-id: http://piwigo.org/svn/trunk@889 68402e56-0260-453c-a942-63ccdbb3a9ee
2005-10-15 21:47:19 +00:00
plegall
f01a9f5b7c - new : HTML BODY identifier to let CSS stylesheets manage specific
behaviour.

- deletion : admin/search useless

- improvement : in admin/user_list, special behaviour for true/false fields
  (expand, show_comments)

- new : gallery_title and gallery_description are displayed at the top of
  each page.

- improvement : simplification in HTML for categories menu.

- improvement : standardization of presentation in all public pages
  (identification, registration, search, profile, notification, comments,
  etc.)

(not in ChangeLog, below this line)

- add forgotten notification.php (should have been added in a previous
  commit)

- [template cclear] deletion of useless class .bouton

- [template cclear] for test purpose, new presentation of register page
  (using FORM.filter)

- [template cclear] adaptation of admin/group_list from template default

- [template cclear] deletion of obsolete admin/infos_images

- [template cclear] deletion of obsolete admin/search_username

- [template cclear] new icon register.png


git-svn-id: http://piwigo.org/svn/trunk@850 68402e56-0260-453c-a942-63ccdbb3a9ee
2005-08-25 22:43:47 +00:00
plegall
b08df04688 - modification : adaptation of template variables and blocks in comments
page to display comment by comment instead of picture by picture.

- [template cclear] comments.tpl copied and adapted from template
  default. Return to home new icon. As asked by chrisaga, special id
  #commentsPage in comments.tpl to set the #content margin-left to 0 (since
  no #menubar to display).

- [template cclear] FORM.filter rules taken from template default (these
  rules have been written some time ago by yoDan.

- [template cclear] bug fixed on #theImage : display:block must be used only
  on IMG and not on the P>A (yes, in BSF you can have HTML in picture and
  categories descriptions)


git-svn-id: http://piwigo.org/svn/trunk@848 68402e56-0260-453c-a942-63ccdbb3a9ee
2005-08-21 21:23:17 +00:00
plegall
9bafdff171 - new feature : RSS notification feed. Feed generator is an external tool
(FeedCreator class v1.7.2). New file feed.php

- new database field : comments.validation_date (datetime). This field is
  required for notification feed.

- new database field : users.feed_id (varchar(50)). users.feed_id is an
  alias of users.id but is much more complicated to find (50 characters,
  figures or letters, case sensitive) : the purpose is to keep it secret (as
  far as possible).

- new database field : users.last_feed_check (datetime)

- new database field : users.registration_date (datetime)

- bug fixed : no need to add the (unavailable) session id to install.php in
  the installation form.

- modified database field : images.date_available become more precise (date
  to datetime). This precision is needed for notification feed.

- new index : comments_i1 (validation_date). Might be useful for feed
  queries.

- new index : comments_i2 (image_id). Useful each time you want to have
  informations about an element and its associated comments.

- version 9.11 of mysqldump outputs database field names and table names
  with backquote "`" (didn't find how to take them off)


git-svn-id: http://piwigo.org/svn/trunk@801 68402e56-0260-453c-a942-63ccdbb3a9ee
2005-07-16 14:29:35 +00:00
plegall
49fb2b6fd3 - comments page rewritten : comments are displayed one by one, with filters
and display options available. The list of comments is paginated.


git-svn-id: http://piwigo.org/svn/trunk@796 68402e56-0260-453c-a942-63ccdbb3a9ee
2005-06-21 21:08:11 +00:00
plegall
cf48bf46e3 - bug fixed : same comments displayed as many times as element categories
git-svn-id: http://piwigo.org/svn/trunk@721 68402e56-0260-453c-a942-63ccdbb3a9ee
2005-01-23 15:27:20 +00:00
plegall
0737f91b19 - use template->parse instead of pparse. (exceptions for install.php and
upgrade.php)

- bug fixed : queries time and count were not displayed on a redirection


git-svn-id: http://piwigo.org/svn/trunk@688 68402e56-0260-453c-a942-63ccdbb3a9ee
2005-01-13 10:18:49 +00:00
plegall
6244654872 all headers adapted to new year 2005, happy new year
git-svn-id: http://piwigo.org/svn/trunk@675 68402e56-0260-453c-a942-63ccdbb3a9ee
2005-01-07 23:10:51 +00:00
plegall
391fac78a8 - in admin menu, status option for categories is not "permissions" but
"private or public" choice = different language item

- get_cat_display_name changed : use $conf['level_separator'] to unify
  presentation

- default values for category properties commentable, uploadable, status and
  visible (set in include/config.inc.php) used for category creation
  (admin/update, admin/remote_site, admin/cat_list)

- use mass_inserts in admin/update for inserting new categories

- only one query for counting the number of sub categories in admin/cat_list


git-svn-id: http://piwigo.org/svn/trunk@642 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-12-12 21:06:39 +00:00
gweltas
f20efb0cfa Unification of "Return to main page" entry in the language files.
git-svn-id: http://piwigo.org/svn/trunk@607 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-11-18 14:57:00 +00:00
plegall
1bf3753f14 - images.path column added to reduce database access
- function mass_inserts moved from admin/remote_sites.php to
  admin/include/function.php

- function mass_inserts used in admin/update.php


git-svn-id: http://piwigo.org/svn/trunk@606 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-11-16 23:38:34 +00:00
z0rglub
a8b1a03018 update headers to comply with GPL
git-svn-id: http://piwigo.org/svn/trunk@593 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-11-06 21:12:59 +00:00
z0rglub
7cd9b65e32 - function mysql_query replaced by pwg_query : the same with debugging
features

- by default, DEBUG is set to 0 (off)


git-svn-id: http://piwigo.org/svn/trunk@587 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-10-30 15:42:29 +00:00
z0rglub
98b65edb83 - refactoring of comments.php
- creation of function get_thumbnail_src used everywhere a thumbnail must be
  displayed

- creation of function parse_comment_content (used in comments.php and
  picture.php)

- concerning undefined index on arrays retrieved in database, instead of
  testing possibly unset values, use of @ operator (smarter...)

- add pre tag in default.css stylesheet for debugging purpose (need to have
  left aligned text)


git-svn-id: http://piwigo.org/svn/trunk@579 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-10-23 17:56:46 +00:00
gweltas
288818b06d - dispatch of configuration
git-svn-id: http://piwigo.org/svn/trunk@527 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-09-19 22:26:41 +00:00
z0rglub
46873b13aa - non picture files management
- refactoring


git-svn-id: http://piwigo.org/svn/trunk@464 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-08-05 17:27:09 +00:00
z0rglub
8db124da81 field comments.date becomes a datetime MySQL field type (instead of int)
git-svn-id: http://piwigo.org/svn/trunk@420 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-05-20 21:22:44 +00:00
gweltas
4128835db8 - Template migration
- Admin Control Panel migration
- Language migration


git-svn-id: http://piwigo.org/svn/trunk@393 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-03-20 00:52:37 +00:00
gweltas
60b84a9db5 Template migration
git-svn-id: http://piwigo.org/svn/trunk@369 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-02-22 02:43:13 +00:00
gweltas
78df1f97d3 Split of langage files
git-svn-id: http://piwigo.org/svn/trunk@364 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-02-19 00:31:09 +00:00
z0rglub
6f4e7d6bc0 header global refactoring
git-svn-id: http://piwigo.org/svn/trunk@362 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-02-11 23:20:38 +00:00
gweltas
135346f2fc Template migration
git-svn-id: http://piwigo.org/svn/trunk@355 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-02-08 01:28:18 +00:00
gweltas
e712c4aef8 Migration of common.php in the include directory to fit the new coding rules
git-svn-id: http://piwigo.org/svn/trunk@354 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-02-07 19:36:44 +00:00
gweltas
bef4b3e3aa Merge of the 1.3.1 release
Creation of an unique include file (common.php)
Creation of an unique define file (include/constants.php)
Modification of the installation procedure


git-svn-id: http://piwigo.org/svn/trunk@345 68402e56-0260-453c-a942-63ccdbb3a9ee
2004-02-02 00:55:18 +00:00
z0rglub
0089ab102c define( CONSTANT, 'value' ) becomes define( "CONSTANT", 'value')
git-svn-id: http://piwigo.org/svn/trunk@231 68402e56-0260-453c-a942-63ccdbb3a9ee
2003-11-03 22:39:53 +00:00
z0rglub
1ee0d7153c Support of special syntax to underline, emphasis or italic words in users
comments


git-svn-id: http://piwigo.org/svn/trunk@180 68402e56-0260-453c-a942-63ccdbb3a9ee
2003-10-05 13:43:00 +00:00
z0rglub
ff1dc9edad Always displays last comments, not only when choosing a number of days (->
use the default)


git-svn-id: http://piwigo.org/svn/trunk@179 68402e56-0260-453c-a942-63ccdbb3a9ee
2003-10-05 13:21:44 +00:00
z0rglub
151dc43370 Adding a page for non admin to see last users comments
git-svn-id: http://piwigo.org/svn/trunk@166 68402e56-0260-453c-a942-63ccdbb3a9ee
2003-10-04 16:08:53 +00:00