Cleaning up GData binding implementation and fixing issue with retrieving Picassa feed

git-svn-id: http://svn.us.apache.org/repos/asf/tuscany@708460 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 15 insertions, 24 deletions

diff --git a/branches/sca-equinox/modules/binding-gdata-runtime/src/main/java/org/apache/tuscany/sca/binding/gdata/provider/GdataBindingInvoker.java b/branches/sca-equinox/modules/binding-gdata-runtime/src/main/java/org/apache/tuscany/sca/binding/gdata/provider/GdataBindingInvoker.java
index 859318a306..460aa81378 100644
--- a/branches/sca-equinox/modules/binding-gdata-runtime/src/main/java/org/apache/tuscany/sca/binding/gdata/provider/GdataBindingInvoker.java
+++ b/branches/sca-equinox/modules/binding-gdata-runtime/src/main/java/org/apache/tuscany/sca/binding/gdata/provider/GdataBindingInvoker.java
@@ -46,6 +46,8 @@ import com.google.gdata.util.ServiceException;
 
 /**
  * Invoker for the GData binding.
+ * 
+ * @version $Rev$ $Date$
  */
 class GdataBindingInvoker implements Invoker, DataExchangeSemantics {
 
@@ -71,6 +73,11 @@ class GdataBindingInvoker implements Invoker, DataExchangeSemantics {
 
     }
 
+
+    public boolean allowsPassByReference() {
+        return true;
+    }
+
     public Message invoke(Message msg) {
         // Shouldn't get here, as the only supported methods are
         // defined in the ResourceCollection interface, and implemented
@@ -83,6 +90,7 @@ class GdataBindingInvoker implements Invoker, DataExchangeSemantics {
      * Get operation invoker
      */
     public static class GetInvoker extends GdataBindingInvoker {
+        
         public GetInvoker(Operation operation,
                           String uri,
                           GoogleService googleService,
@@ -145,23 +153,19 @@ class GdataBindingInvoker implements Invoker, DataExchangeSemantics {
 
                 // Expect an GData entry
 
-                System.out.println("[Debug Info]GdataBindingInvoker.PostInvoker --- supportsFeedEntries: " + provider
-                    .supportsFeedEntries());
+                System.out.println("[Debug Info]GdataBindingInvoker.PostInvoker --- supportsFeedEntries: " + provider.supportsFeedEntries());
                 feedEntry = (com.google.gdata.data.Entry)args[0];
 
-                System.out.println("[Debug Info]GdataBindingInvoker.PostInvoker --- feedEntry title: " + feedEntry
-                    .getTitle().getPlainText());
+                System.out.println("[Debug Info]GdataBindingInvoker.PostInvoker --- feedEntry title: " + feedEntry.getTitle().getPlainText());
 
             } else {
                 // Expect a key and data item
                 Entry<Object, Object> entry = new Entry<Object, Object>(args[0], args[1]);
 
                 // FIXME: this needs to be examinated more....
-                feedEntry =
-                    feedEntry(entry, provider.getItemClassType(), provider.getItemXMLType(), provider.getMediator());
+                feedEntry = feedEntry(entry, provider.getItemClassType(), provider.getItemXMLType(), provider.getMediator());
             }
 
-
             try {
                
                 com.google.gdata.data.Entry createdEntry = googleService.insert(new URL(uri), feedEntry);
@@ -212,13 +216,6 @@ class GdataBindingInvoker implements Invoker, DataExchangeSemantics {
                 id = (String)args[0];
                 Entry<Object, Object> entry = new Entry<Object, Object>(id, args[1]);
 
-                // FIXME: The following statement needs to be modified
-                // accordingly
-                /*
-                 * feedEntry = feedEntry(entry, provider.getItemClassType(),
-                 * provider.getItemXMLType(), provider.getMediator(),
-                 * abderaFactory);
-                 */
             }
 
             // Send an HTTP PUT <Localhost>
@@ -309,7 +306,7 @@ class GdataBindingInvoker implements Invoker, DataExchangeSemantics {
         }
 
         @SuppressWarnings("finally")
-		@Override
+                @Override
         public Message invoke(Message msg) {
 
             // Send an HTTP GET
@@ -351,7 +348,7 @@ class GdataBindingInvoker implements Invoker, DataExchangeSemantics {
         }
 
         @SuppressWarnings("finally")
-		@Override
+                @Override
         public Message invoke(Message msg) {
 
             // Send an HTTP GET
@@ -365,7 +362,7 @@ class GdataBindingInvoker implements Invoker, DataExchangeSemantics {
 
             try {
 
-            	Feed resultFeed = googleService.query(myQuery, Feed.class);
+                Feed resultFeed = googleService.query(myQuery, Feed.class);
                 msg.setBody(resultFeed);
 
             } catch (ResourceNotFoundException ex) {
@@ -425,10 +422,4 @@ class GdataBindingInvoker implements Invoker, DataExchangeSemantics {
             return super.invoke(msg);
         }
     }
-
-    public boolean allowsPassByReference() {
-        // TODO Auto-generated method stub
-        return true;
-    }
-
-}
+}
\ No newline at end of file