From f28057dd4a79ef77843706a191c63d1989c23e76 Mon Sep 17 00:00:00 2001 From: Christian Schneppe Date: Tue, 1 Aug 2017 11:37:32 +0200 Subject: fixed fallback to normal DNS query after DNSSEC failed --- src/main/java/de/pixart/messenger/utils/Resolver.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/main/java/de/pixart/messenger/utils/Resolver.java b/src/main/java/de/pixart/messenger/utils/Resolver.java index 89961a3c3..31e0b3dd4 100644 --- a/src/main/java/de/pixart/messenger/utils/Resolver.java +++ b/src/main/java/de/pixart/messenger/utils/Resolver.java @@ -92,16 +92,22 @@ public class Resolver { private static ResolverResult resolveWithFallback(DNSName dnsName, Class type) throws IOException { try { - return DnssecResolverApi.INSTANCE.resolveDnssecReliable(dnsName, type); + final ResolverResult r = DnssecResolverApi.INSTANCE.resolveDnssecReliable(dnsName, type); + if (r.wasSuccessful()) { + if (r.getAnswers().isEmpty() && type.equals(SRV.class)) { + Log.d(Config.LOGTAG, Resolver.class.getSimpleName() + ": resolving SRV records of " + dnsName.toString() + " with DNSSEC yielded empty result"); + } + return r; + } + Log.d(Config.LOGTAG, Resolver.class.getSimpleName() + ": error resolving " + type.getSimpleName() + " with DNSSEC. Trying DNS instead.", r.getResolutionUnsuccessfulException()); } catch (DNSSECResultNotAuthenticException e) { Log.d(Config.LOGTAG, Resolver.class.getSimpleName() + ": error resolving " + type.getSimpleName() + " with DNSSEC. Trying DNS instead.", e); - return ResolverApi.INSTANCE.resolve(dnsName, type); } catch (IOException e) { throw e; } catch (Throwable throwable) { Log.d(Config.LOGTAG, Resolver.class.getSimpleName() + ": error resolving " + type.getSimpleName() + " with DNSSEC. Trying DNS instead.", throwable); - return ResolverApi.INSTANCE.resolve(dnsName, type); } + return ResolverApi.INSTANCE.resolve(dnsName, type); } public static class Result implements Comparable { -- cgit v1.2.3