From 7df333bf2a8aad44f082ac6a6a9ee49948ce36d7 Mon Sep 17 00:00:00 2001 From: Christian Schneppe Date: Fri, 14 Dec 2018 21:45:44 +0100 Subject: Reduce `minSdkVersion` to 16, fix issues reported by lint This further reduces the minimum API level to 16, which should encompass most users stuck on older versions of Android (mainly BlackBerry OS and Jolla users). Several issues reported by code analysis were fixed, mainly around issues with layouts. --- src/main/res/layout/account_row.xml | 11 ++-- src/main/res/layout/activity_about.xml | 22 ++++---- src/main/res/layout/activity_change_password.xml | 12 +++-- src/main/res/layout/activity_contact_details.xml | 59 +++++++++------------- src/main/res/layout/activity_edit_account.xml | 15 +++++- src/main/res/layout/activity_muc_details.xml | 18 +++++-- .../layout/activity_publish_profile_picture.xml | 2 + src/main/res/layout/activity_recording.xml | 6 +-- src/main/res/layout/activity_share_locaction.xml | 10 ++-- src/main/res/layout/activity_verify_otr.xml | 22 ++++---- src/main/res/layout/contact.xml | 4 ++ src/main/res/layout/contact_key.xml | 4 ++ src/main/res/layout/conversation_list_row.xml | 28 ++++++++-- src/main/res/layout/fragment_conversation.xml | 47 +++++++++-------- src/main/res/layout/message_content.xml | 8 +-- src/main/res/layout/message_received.xml | 9 +++- src/main/res/layout/message_sent.xml | 12 +++-- src/main/res/layout/message_status.xml | 7 ++- 18 files changed, 181 insertions(+), 115 deletions(-) (limited to 'src/main') diff --git a/src/main/res/layout/account_row.xml b/src/main/res/layout/account_row.xml index 9b638172a..eaacbde5e 100644 --- a/src/main/res/layout/account_row.xml +++ b/src/main/res/layout/account_row.xml @@ -4,14 +4,16 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:background="?android:attr/activatedBackgroundIndicator" - android:paddingBottom="8dp" + android:paddingStart="8dp" android:paddingLeft="8dp" - android:paddingTop="8dp"> + android:paddingTop="8dp" + android:paddingBottom="8dp"> @@ -59,8 +59,8 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginLeft="@dimen/activity_horizontal_margin" - android:layout_marginRight="@dimen/activity_horizontal_margin" android:layout_marginTop="@dimen/activity_vertical_margin" + android:layout_marginRight="@dimen/activity_horizontal_margin" android:autoLink="web" android:fontFamily="monospace" android:linksClickable="true" @@ -74,20 +74,18 @@ android:id="@+id/show_privacy_policy" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_centerHorizontal="true" android:layout_gravity="center_horizontal" - android:layout_marginBottom="4dp" android:layout_marginTop="4dp" + android:layout_marginBottom="4dp" android:text="@string/show_privacy" />