1 files changed, 29 insertions, 24 deletions
diff --git a/src/main/java/de/pixart/messenger/ui/ChangePasswordActivity.java b/src/main/java/de/pixart/messenger/ui/ChangePasswordActivity.java
index 49a826f29..f6bec9838 100644
--- a/src/main/java/de/pixart/messenger/ui/ChangePasswordActivity.java
+++ b/src/main/java/de/pixart/messenger/ui/ChangePasswordActivity.java
@@ -2,15 +2,16 @@ package de.pixart.messenger.ui;
 
 import android.content.Intent;
 import android.os.Bundle;
+import android.support.design.widget.TextInputLayout;
 import android.view.View;
 import android.widget.Button;
 import android.widget.EditText;
-import android.widget.TextView;
 import android.widget.Toast;
 
 import de.pixart.messenger.R;
 import de.pixart.messenger.entities.Account;
 import de.pixart.messenger.services.XmppConnectionService;
+import de.pixart.messenger.ui.widget.DisabledActionModeCallback;
 
 public class ChangePasswordActivity extends XmppActivity implements XmppConnectionService.OnAccountPasswordChanged {
 
@@ -21,20 +22,17 @@ public class ChangePasswordActivity extends XmppActivity implements XmppConnecti
             if (mAccount != null) {
                 final String currentPassword = mCurrentPassword.getText().toString();
                 final String newPassword = mNewPassword.getText().toString();
-                final String newPasswordConfirm = mNewPasswordConfirm.getText().toString();
                 if (!mAccount.isOptionSet(Account.OPTION_MAGIC_CREATE) && !currentPassword.equals(mAccount.getPassword())) {
                     mCurrentPassword.requestFocus();
-                    mCurrentPassword.setError(getString(R.string.account_status_unauthorized));
-                } else if (!newPassword.equals(newPasswordConfirm)) {
-                    mNewPasswordConfirm.requestFocus();
-                    mNewPasswordConfirm.setError(getString(R.string.passwords_do_not_match));
+                    mCurrentPasswordLayout.setError(getString(R.string.account_status_unauthorized));
+                    removeErrorsOnAllBut(mCurrentPasswordLayout);
                 } else if (newPassword.trim().isEmpty()) {
                     mNewPassword.requestFocus();
-                    mNewPassword.setError(getString(R.string.password_should_not_be_empty));
+                    mNewPasswordLayout.setError(getString(R.string.password_should_not_be_empty));
+                    removeErrorsOnAllBut(mNewPasswordLayout);
                 } else {
-                    mCurrentPassword.setError(null);
-                    mNewPassword.setError(null);
-                    mNewPasswordConfirm.setError(null);
+                    mCurrentPasswordLayout.setError(null);
+                    mNewPasswordLayout.setError(null);
                     xmppConnectionService.updateAccountPasswordOnServer(mAccount, newPassword, ChangePasswordActivity.this);
                     mChangePasswordButton.setEnabled(false);
                     mChangePasswordButton.setTextColor(getSecondaryTextColor());
@@ -43,20 +41,18 @@ public class ChangePasswordActivity extends XmppActivity implements XmppConnecti
             }
         }
     };
-    private TextView mCurrentPasswordLabel;
     private EditText mCurrentPassword;
     private EditText mNewPassword;
-    private EditText mNewPasswordConfirm;
     private Account mAccount;
+    private TextInputLayout mNewPasswordLayout;
+	private TextInputLayout mCurrentPasswordLayout;
 
     @Override
     void onBackendConnected() {
         this.mAccount = extractAccount(getIntent());
         if (this.mAccount != null && this.mAccount.isOptionSet(Account.OPTION_MAGIC_CREATE)) {
-            this.mCurrentPasswordLabel.setVisibility(View.GONE);
             this.mCurrentPassword.setVisibility(View.GONE);
         } else {
-            this.mCurrentPasswordLabel.setVisibility(View.VISIBLE);
             this.mCurrentPassword.setVisibility(View.VISIBLE);
         }
     }
@@ -74,10 +70,10 @@ public class ChangePasswordActivity extends XmppActivity implements XmppConnecti
         });
         this.mChangePasswordButton = findViewById(R.id.right_button);
         this.mChangePasswordButton.setOnClickListener(this.mOnChangePasswordButtonClicked);
-        this.mCurrentPasswordLabel = findViewById(R.id.current_password_label);
         this.mCurrentPassword = findViewById(R.id.current_password);
+        this.mCurrentPassword.setCustomSelectionActionModeCallback(new DisabledActionModeCallback());
         this.mNewPassword = findViewById(R.id.new_password);
-        this.mNewPasswordConfirm = findViewById(R.id.new_password_confirm);
+        this.mNewPassword.setCustomSelectionActionModeCallback(new DisabledActionModeCallback());
     }
 
     @Override
@@ -104,18 +100,27 @@ public class ChangePasswordActivity extends XmppActivity implements XmppConnecti
 
     @Override
     public void onPasswordChangeFailed() {
-        runOnUiThread(new Runnable() {
-            @Override
-            public void run() {
-                mNewPassword.setError(getString(R.string.could_not_change_password));
-                mChangePasswordButton.setEnabled(true);
-                mChangePasswordButton.setTextColor(getPrimaryTextColor());
-                mChangePasswordButton.setText(R.string.change_password);
-            }
+        runOnUiThread(() -> {
+            mNewPasswordLayout.setError(getString(R.string.could_not_change_password));
+            mChangePasswordButton.setEnabled(true);
+            mChangePasswordButton.setTextColor(getPrimaryTextColor());
+            mChangePasswordButton.setText(R.string.change_password);
         });
 
     }
 
+    private void removeErrorsOnAllBut(TextInputLayout exception) {
+        if (this.mCurrentPasswordLayout != exception) {
+            this.mCurrentPasswordLayout.setErrorEnabled(false);
+            this.mCurrentPasswordLayout.setError(null);
+        }
+        if (this.mNewPasswordLayout != exception) {
+            this.mNewPasswordLayout.setErrorEnabled(false);
+            this.mNewPasswordLayout.setError(null);
+        }
+
+    }
+
     public void refreshUiReal() {
 
     }