diff options
author | Christian Schneppe <christian@pix-art.de> | 2018-12-14 21:45:44 +0100 |
---|---|---|
committer | Christian Schneppe <christian@pix-art.de> | 2018-12-14 21:45:44 +0100 |
commit | 7df333bf2a8aad44f082ac6a6a9ee49948ce36d7 (patch) | |
tree | 2644764ba3a29806d599dfbcfd0143a4bc4a318c /src/main/res/layout/fragment_conversation.xml | |
parent | 6c6d3caea00810df9fb89de599386a93e8dbc4d4 (diff) |
Reduce `minSdkVersion` to 16, fix issues reported by lint
This further reduces the minimum API level to 16, which should encompass
most users stuck on older versions of Android (mainly BlackBerry OS and
Jolla users).
Several issues reported by code analysis were fixed, mainly around issues
with layouts.
Diffstat (limited to 'src/main/res/layout/fragment_conversation.xml')
-rw-r--r-- | src/main/res/layout/fragment_conversation.xml | 47 |
1 files changed, 25 insertions, 22 deletions
diff --git a/src/main/res/layout/fragment_conversation.xml b/src/main/res/layout/fragment_conversation.xml index 3151f6401..b38cc72a5 100644 --- a/src/main/res/layout/fragment_conversation.xml +++ b/src/main/res/layout/fragment_conversation.xml @@ -13,8 +13,8 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:layout_above="@+id/snackbar" - android:layout_alignParentLeft="true" android:layout_alignParentStart="true" + android:layout_alignParentLeft="true" android:layout_alignParentTop="true" android:background="?attr/color_background_tertiary" android:divider="@null" @@ -42,12 +42,12 @@ android:id="@+id/unread_count_custom_view" android:layout_width="?attr/IconSize" android:layout_height="?attr/IconSize" + android:layout_alignTop="@+id/scroll_to_bottom_button" android:layout_alignEnd="@+id/scroll_to_bottom_button" android:layout_alignRight="@+id/scroll_to_bottom_button" - android:layout_alignTop="@+id/scroll_to_bottom_button" + android:layout_marginTop="16dp" android:layout_marginEnd="8dp" android:layout_marginRight="8dp" - android:layout_marginTop="16dp" android:elevation="8dp" android:visibility="gone" app:backgroundColor="?attr/colorAccent" /> @@ -56,26 +56,29 @@ android:id="@+id/input" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_alignParentBottom="true" + android:layout_alignParentStart="true" android:layout_alignParentLeft="true" - android:layout_alignParentStart="true"> + android:layout_alignParentBottom="true"> <RelativeLayout android:id="@+id/textsend" android:layout_width="fill_parent" android:layout_height="wrap_content" + android:layout_alignParentStart="true" android:layout_alignParentLeft="true" android:background="?attr/color_background_tertiary" android:clickable="true" - android:paddingBottom="2dp" + android:paddingStart="2dp" android:paddingLeft="2dp" - android:paddingTop="2dp"> + android:paddingTop="2dp" + android:paddingBottom="2dp"> <ImageButton android:id="@+id/recordVoiceButton" android:layout_width="48dp" android:layout_height="48dp" + android:layout_alignParentStart="true" android:layout_alignParentLeft="true" android:layout_centerVertical="true" android:background="?attr/color_background_tertiary" @@ -87,10 +90,10 @@ android:id="@+id/media_preview" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_alignParentLeft="true" android:layout_alignParentStart="true" - android:layout_toLeftOf="@+id/textSendButton" + android:layout_alignParentLeft="true" android:layout_toStartOf="@+id/textSendButton" + android:layout_toLeftOf="@+id/textSendButton" android:background="@drawable/message_bubble_sent" android:orientation="horizontal" android:paddingTop="8dp" @@ -104,10 +107,10 @@ style="@style/Widget.Conversations.EditText" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_toEndOf="@+id/recordVoiceButton" + android:layout_toStartOf="@+id/textSendButton" android:layout_toLeftOf="@+id/textSendButton" + android:layout_toEndOf="@+id/recordVoiceButton" android:layout_toRightOf="@+id/recordVoiceButton" - android:layout_toStartOf="@+id/textSendButton" android:background="@drawable/message_bubble_sent" android:ems="10" android:imeOptions="flagNoExtractUi|actionSend" @@ -115,10 +118,10 @@ android:maxLines="6" android:minHeight="48dp" android:minLines="1" - android:paddingBottom="12dp" android:paddingLeft="8dp" - android:paddingRight="8dp" android:paddingTop="12dp" + android:paddingRight="8dp" + android:paddingBottom="12dp" android:singleLine="false" android:textColor="?attr/text_Color_Main"> @@ -142,9 +145,9 @@ android:layout_width="fill_parent" android:layout_height="wrap_content" android:layout_above="@+id/input" - android:layout_marginBottom="4dp" android:layout_marginLeft="8dp" android:layout_marginRight="8dp" + android:layout_marginBottom="4dp" android:background="@drawable/snackbar" android:minHeight="48dp" android:visibility="visible"> @@ -153,13 +156,13 @@ android:id="@+id/snackbar_message" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_alignParentLeft="true" android:layout_alignParentStart="true" + android:layout_alignParentLeft="true" android:layout_centerVertical="true" - android:layout_toLeftOf="@+id/snackbar_action" android:layout_toStartOf="@+id/snackbar_action" - android:paddingLeft="24dp" + android:layout_toLeftOf="@+id/snackbar_action" android:paddingStart="24dp" + android:paddingLeft="24dp" android:textAppearance="@style/TextAppearance.Conversations.Body1.OnDark" /> <TextView @@ -169,10 +172,10 @@ android:layout_alignParentEnd="true" android:layout_alignParentRight="true" android:layout_centerVertical="true" - android:paddingBottom="16dp" android:paddingLeft="24dp" - android:paddingRight="24dp" android:paddingTop="16dp" + android:paddingRight="24dp" + android:paddingBottom="16dp" android:textAllCaps="true" android:textAppearance="@style/TextAppearance.Conversations.Body1.OnDark" android:textStyle="bold" /> @@ -183,8 +186,8 @@ android:layout_width="fill_parent" android:layout_height="wrap_content" android:layout_marginLeft="8dp" - android:layout_marginRight="8dp" android:layout_marginTop="4dp" + android:layout_marginRight="8dp" android:background="@drawable/date_bubble" android:minHeight="48dp" android:visibility="gone"> @@ -193,11 +196,11 @@ android:id="@+id/messagehint_message" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_alignParentLeft="true" android:layout_alignParentStart="true" + android:layout_alignParentLeft="true" android:layout_centerVertical="true" - android:paddingLeft="24dp" android:paddingStart="24dp" + android:paddingLeft="24dp" android:textColor="@color/realblack" android:textSize="?attr/TextSizeBody" /> </RelativeLayout> |