diff options
author | Christian Schneppe <christian@pix-art.de> | 2018-12-14 21:45:44 +0100 |
---|---|---|
committer | Christian Schneppe <christian@pix-art.de> | 2018-12-14 21:45:44 +0100 |
commit | 7df333bf2a8aad44f082ac6a6a9ee49948ce36d7 (patch) | |
tree | 2644764ba3a29806d599dfbcfd0143a4bc4a318c /src/main/res/layout/activity_about.xml | |
parent | 6c6d3caea00810df9fb89de599386a93e8dbc4d4 (diff) |
Reduce `minSdkVersion` to 16, fix issues reported by lint
This further reduces the minimum API level to 16, which should encompass
most users stuck on older versions of Android (mainly BlackBerry OS and
Jolla users).
Several issues reported by code analysis were fixed, mainly around issues
with layouts.
Diffstat (limited to '')
-rw-r--r-- | src/main/res/layout/activity_about.xml | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/src/main/res/layout/activity_about.xml b/src/main/res/layout/activity_about.xml index 4da63e957..f3bdb056f 100644 --- a/src/main/res/layout/activity_about.xml +++ b/src/main/res/layout/activity_about.xml @@ -21,10 +21,10 @@ android:id="@+id/LogoLayout" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginBottom="@dimen/activity_vertical_margin" android:layout_marginLeft="@dimen/activity_horizontal_margin" - android:layout_marginRight="@dimen/activity_horizontal_margin" android:layout_marginTop="@dimen/activity_vertical_margin" + android:layout_marginRight="@dimen/activity_horizontal_margin" + android:layout_marginBottom="@dimen/activity_vertical_margin" card_view:cardBackgroundColor="?attr/color_background_secondary"> <ImageView @@ -42,10 +42,10 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_below="@+id/LogoLayout" - android:layout_marginBottom="@dimen/activity_vertical_margin" android:layout_marginLeft="@dimen/activity_horizontal_margin" - android:layout_marginRight="@dimen/activity_horizontal_margin" android:layout_marginTop="@dimen/activity_vertical_margin" + android:layout_marginRight="@dimen/activity_horizontal_margin" + android:layout_marginBottom="@dimen/activity_vertical_margin" android:orientation="vertical" card_view:cardBackgroundColor="?attr/color_background_secondary"> @@ -59,8 +59,8 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginLeft="@dimen/activity_horizontal_margin" - android:layout_marginRight="@dimen/activity_horizontal_margin" android:layout_marginTop="@dimen/activity_vertical_margin" + android:layout_marginRight="@dimen/activity_horizontal_margin" android:autoLink="web" android:fontFamily="monospace" android:linksClickable="true" @@ -74,20 +74,18 @@ android:id="@+id/show_privacy_policy" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_centerHorizontal="true" android:layout_gravity="center_horizontal" - android:layout_marginBottom="4dp" android:layout_marginTop="4dp" + android:layout_marginBottom="4dp" android:text="@string/show_privacy" /> <Button android:id="@+id/show_terms_of_use" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_centerHorizontal="true" android:layout_gravity="center_horizontal" - android:layout_marginBottom="4dp" android:layout_marginTop="4dp" + android:layout_marginBottom="4dp" android:text="@string/show_termsofuse" /> </LinearLayout> @@ -98,10 +96,10 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_below="@+id/aboutLayout" - android:layout_marginBottom="@dimen/activity_vertical_margin" android:layout_marginLeft="@dimen/activity_horizontal_margin" - android:layout_marginRight="@dimen/activity_horizontal_margin" android:layout_marginTop="@dimen/activity_vertical_margin" + android:layout_marginRight="@dimen/activity_horizontal_margin" + android:layout_marginBottom="@dimen/activity_vertical_margin" card_view:cardBackgroundColor="?attr/color_background_secondary"> <TextView @@ -109,8 +107,8 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginLeft="@dimen/activity_horizontal_margin" - android:layout_marginRight="@dimen/activity_horizontal_margin" android:layout_marginTop="@dimen/activity_vertical_margin" + android:layout_marginRight="@dimen/activity_horizontal_margin" android:autoLink="web" android:fontFamily="monospace" android:linksClickable="true" |