From b8f67bfaa38509055ed3cf60877c1d3490b10bc1 Mon Sep 17 00:00:00 2001 From: Daniel Gultsch Date: Mon, 26 Dec 2016 15:13:38 +0100 Subject: deduplicate corrected messages --- src/main/java/eu/siacs/conversations/entities/Message.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/main/java/eu/siacs/conversations/entities/Message.java b/src/main/java/eu/siacs/conversations/entities/Message.java index 20e4c5a5..c53bb061 100644 --- a/src/main/java/eu/siacs/conversations/entities/Message.java +++ b/src/main/java/eu/siacs/conversations/entities/Message.java @@ -411,15 +411,18 @@ public class Message extends AbstractEntity { body = this.body; otherBody = message.body; } + final boolean matchingCounterpart = this.counterpart.equals(message.getCounterpart()); if (message.getRemoteMsgId() != null) { + final boolean hasUuid = CryptoHelper.UUID_PATTERN.matcher(message.getRemoteMsgId()).matches(); + if (hasUuid && this.edited != null && matchingCounterpart && this.edited.equals(message.getRemoteMsgId())) { + return true; + } return (message.getRemoteMsgId().equals(this.remoteMsgId) || message.getRemoteMsgId().equals(this.uuid)) - && this.counterpart.equals(message.getCounterpart()) - && (body.equals(otherBody) - ||(message.getEncryption() == Message.ENCRYPTION_PGP - && CryptoHelper.UUID_PATTERN.matcher(message.getRemoteMsgId()).matches())); + && matchingCounterpart + && (body.equals(otherBody) ||(message.getEncryption() == Message.ENCRYPTION_PGP && hasUuid)); } else { return this.remoteMsgId == null - && this.counterpart.equals(message.getCounterpart()) + && matchingCounterpart && body.equals(otherBody) && Math.abs(this.getTimeSent() - message.getTimeSent()) < Config.MESSAGE_MERGE_WINDOW * 1000; } -- cgit v1.2.3