2 files changed, 36 insertions, 11 deletions

diff --git a/src/main/java/de/thedevstack/conversationsplus/http/HttpConnectionManager.java b/src/main/java/de/thedevstack/conversationsplus/http/HttpConnectionManager.java
index 686587c7..011e2529 100644
--- a/src/main/java/de/thedevstack/conversationsplus/http/HttpConnectionManager.java
+++ b/src/main/java/de/thedevstack/conversationsplus/http/HttpConnectionManager.java
@@ -20,8 +20,8 @@ import javax.net.ssl.X509TrustManager;
 import de.thedevstack.conversationsplus.ConversationsPlusApplication;
 import de.thedevstack.conversationsplus.entities.Message;
 import de.thedevstack.conversationsplus.services.AbstractConnectionManager;
-import de.thedevstack.conversationsplus.services.XmppConnectionService;
 import de.thedevstack.conversationsplus.utils.CryptoHelper;
+import de.thedevstack.conversationsplus.utils.MessageUtil;
 import de.thedevstack.conversationsplus.utils.SSLSocketHelper;
 
 public class HttpConnectionManager extends AbstractConnectionManager {
@@ -38,10 +38,13 @@ public class HttpConnectionManager extends AbstractConnectionManager {
 	}
 
 	public static HttpDownloadConnection createNewDownloadConnection(Message message, boolean interactive) {
-		HttpDownloadConnection connection = new HttpDownloadConnection(INSTANCE);
-		connection.init(message,interactive);
-		INSTANCE.downloadConnections.add(connection);
-		return connection;
+        if (MessageUtil.needsDownload(message)) {
+            HttpDownloadConnection connection = new HttpDownloadConnection(INSTANCE);
+            connection.init(message, interactive);
+            INSTANCE.downloadConnections.add(connection);
+            return connection;
+        }
+		return null;
 	}
 
 	public void finishConnection(HttpDownloadConnection connection) {
diff --git a/src/main/java/de/thedevstack/conversationsplus/http/HttpDownloadConnection.java b/src/main/java/de/thedevstack/conversationsplus/http/HttpDownloadConnection.java
index d9fc9584..07f308fe 100644
--- a/src/main/java/de/thedevstack/conversationsplus/http/HttpDownloadConnection.java
+++ b/src/main/java/de/thedevstack/conversationsplus/http/HttpDownloadConnection.java
@@ -18,6 +18,7 @@ import javax.net.ssl.SSLHandshakeException;
 import de.thedevstack.android.logcat.Logging;
 import de.thedevstack.conversationsplus.ConversationsPlusApplication;
 import de.thedevstack.conversationsplus.ConversationsPlusPreferences;
+import de.thedevstack.conversationsplus.entities.FileParams;
 import de.thedevstack.conversationsplus.enums.FileStatus;
 import de.thedevstack.conversationsplus.exceptions.RemoteFileNotFoundException;
 import de.thedevstack.conversationsplus.utils.MessageUtil;
@@ -75,8 +76,22 @@ public class HttpDownloadConnection implements Transferable {
 		this.message = message;
 		this.message.setTransferable(this);
 		try {
-            mUrl = new URL(message.getFileParams().getUrl());
-			final String sUrlFilename = mUrl.getPath().substring(mUrl.getPath().lastIndexOf('/')).toLowerCase();
+            String url = (null != message && null != message.getFileParams()) ? message.getFileParams().getUrl() : null;
+            if (null == url) {
+                /*
+                 * If this code is reached and the URL is null something went wrong.
+                 * Try again to extract the file parameters from the message.
+                 */
+                MessageUtil.extractFileParamsFromBody(message);
+                url = (null != message.getFileParams()) ? message.getFileParams().getUrl() : null;
+                if (null == url) {
+                    message.setTreatAsDownloadable(Message.Decision.NEVER); // TODO find sth better
+                    this.cancel();
+                    return;
+                }
+            }
+            mUrl = new URL(url);
+			final String sUrlFilename = mUrl.getPath().substring(mUrl.getPath().lastIndexOf('/') + 1).toLowerCase();
 			final String lastPart = FileUtils.getLastExtension(sUrlFilename);
 
 			if (!lastPart.isEmpty() && ("pgp".equals(lastPart) || "gpg".equals(lastPart))) {
@@ -85,18 +100,25 @@ public class HttpDownloadConnection implements Transferable {
 					&& message.getEncryption() != Message.ENCRYPTION_AXOLOTL) {
 				this.message.setEncryption(Message.ENCRYPTION_NONE);
 			}
+
 			String extension;
+            String originalFilename;
 			if (!lastPart.isEmpty() && VALID_CRYPTO_EXTENSIONS.contains(lastPart)) {
 				extension = FileUtils.getSecondToLastExtension(sUrlFilename);
+                originalFilename = sUrlFilename.replace("." + lastPart, "");
 			} else {
 				extension = lastPart;
+                originalFilename = sUrlFilename;
 			}
 			message.setRelativeFilePath(message.getUuid() + "." + extension);
 			this.file = FileBackend.getFile(message, false);
-			String reference = mUrl.getRef();
-			if (reference != null && reference.length() == 96) {
-				this.file.setKeyAndIv(CryptoHelper.hexToBytes(reference));
-			}
+
+            FileParams fileParams = message.getFileParams();
+            if (null == fileParams) {
+                fileParams = new FileParams();
+                message.setFileParams(fileParams);
+            }
+            fileParams.setOriginalFilename(originalFilename);
 
 			if ((this.message.getEncryption() == Message.ENCRYPTION_OTR
 					|| this.message.getEncryption() == Message.ENCRYPTION_AXOLOTL)